[{"id":3675985,"web_url":"http://patchwork.ozlabs.org/comment/3675985/","msgid":"","list_archive_url":null,"date":"2026-04-10T16:41:44","subject":"Re: [PATCH] monitor: fix missing spaces in screendump help text","submitter":{"id":6442,"url":"http://patchwork.ozlabs.org/api/people/6442/","name":"Marc-André Lureau","email":"marcandre.lureau@gmail.com"},"content":"On Fri, Apr 10, 2026 at 8:24 PM Brian Knutsson wrote:\n>\n> From: Knutsson Development \n>\n> Signed-off-by: Knutsson Development \n\nReviewed-by: Marc-André Lureau \n\n> ---\n> hmp-commands.hx | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n>\n> diff --git a/hmp-commands.hx b/hmp-commands.hx\n> index 5cc4788f12..b6f3b8a796 100644\n> --- a/hmp-commands.hx\n> +++ b/hmp-commands.hx\n> @@ -257,8 +257,8 @@ ERST\n> .name = \"screendump\",\n> .args_type = \"filename:F,format:-fs,device:s?,head:i?\",\n> .params = \"filename [-f format] [device [head]]\",\n> - .help = \"save screen from head 'head' of display device 'device'\"\n> - \"in specified format 'format' as image 'filename'.\"\n> + .help = \"save screen from head 'head' of display device 'device' \"\n> + \"in specified format 'format' as image 'filename'. \"\n> \"Currently only 'png' and 'ppm' formats are supported.\",\n> .cmd = hmp_screendump,\n> .coroutine = true,\n> --\n> 2.48.1\n>\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=mDlrLiX8;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fsjJc17Nwz1y2d\n\tfor ; Sat, 11 Apr 2026 02:42:24 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wBEvr-00040q-Rb; Fri, 10 Apr 2026 12:42:11 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wBEvh-00040I-MK\n for qemu-devel@nongnu.org; Fri, 10 Apr 2026 12:42:06 -0400","from mail-dl1-x1234.google.com ([2607:f8b0:4864:20::1234])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1wBEvg-00039n-4n\n for qemu-devel@nongnu.org; Fri, 10 Apr 2026 12:42:01 -0400","by mail-dl1-x1234.google.com with SMTP id\n a92af1059eb24-128b9b7e3edso468226c88.0\n for ; Fri, 10 Apr 2026 09:41:59 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; t=1775839318; cv=none;\n d=google.com; s=arc-20240605;\n b=AdaZm1RCn8IdyyCOO3pKYj1DxavX/jBqOmoBwFvb9bs9sp9sdctJCQb+IDnnY++qph\n swYk1CALT2afJS8FfY3qCp0PJiJx+vzAECogJLUUpqkY5DLiniOkhOBhsc5LNYQs9mYj\n JFNiRxZ8lqALxmASMjgYb0mS9sUPT7RZv47RmrJ1c2Aa6gK4rArHXsOP3Z4niG2HQ46C\n YMbsnwOI5lN/OHL+gcAIaXxGvAGSlbXu8ryh/s03VvDU37B8gUghhugF1fJt1lVRA2S4\n q+djgF461s6NbC5Ri3ZtTGoWQb7MZCJubVzJjyuEpBP/g3SU+avCOAzYPGEP3vLpfudQ\n eRsQ==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:dkim-signature;\n bh=bvesXMpz50kHTUEcp/X0NnnqvOyncblvdLWc0DfGMwU=;\n fh=1U4GF0oLWQ/Y6af78tK/MyKxzL//5ocgILtxHMzYyAA=;\n b=LnTcMYdmTPrnqmheCGJXtD9BmXsx2P96uuWIBCilGcVCwdkspLXWCvTaNubBlapCwe\n KGicipo/prifECJLLWvaMfRRbKgf+pExAQVgYJ/O5wYFe69QhEWMQEWbascDEAFLHd/+\n hNe96BMNb7bJLL/+o8FHr1WG6g2C3xvK0wBMFxvyAbLwDi+h+AgWSf6q/Axcv1ArVFSt\n aZJ9y+GGzCBCW3StkWKRLL+K7yvCsAFHXv9MoAo7ZcdNwRvGdUahpVCXwu92eY5edZ1A\n RU6QzRCOpNxg+LroKh7lSFfeuVuvMQFSrC44jxwGt7kb6J44Y4CoooxQN6l4zuI09RDX\n FeIA==; darn=nongnu.org","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1775839318; x=1776444118; darn=nongnu.org;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:from:to:cc:subject:date\n :message-id:reply-to;\n bh=bvesXMpz50kHTUEcp/X0NnnqvOyncblvdLWc0DfGMwU=;\n b=mDlrLiX8xqNrWSE86+tRXVg1IiZSqTOagg/c9STeM1i8DLWl681Gipwpqz98MNHFw2\n Tv5T05TvTFp8rWu8VS87sZ04UVajThi1hU3M2EBbMtxW80SZxq92yh4H42ZzFUeGgHfK\n YWJwUxgnFbesN75CitNOFzYT7RNk9ep5Ccqv4dF9vUgt2v9tHfM92T0aDLtxVXe7z3EZ\n j90KZ9vA+wZy7eSjaLwYNeIJgh9XeAkxaX1gJiCeUOtKEkhk8yXJRllv7rRgo+eEcyz7\n 6qBGBSns/T7vJL+YAyfDX+BY2D1nBc7kfM2kH6A6o9YSDLxxsBSyFTS47EHyCK7E4yiu\n /TmQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775839318; x=1776444118;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=bvesXMpz50kHTUEcp/X0NnnqvOyncblvdLWc0DfGMwU=;\n b=Hc42ym23CFMyJyHMQVtz83nQzIHfUQdGDrpDx6l2HDQu5AiXEmg5hStxm9xXmDPeeI\n Ou123f7UJE2MKEKMQKDbNbEyeBl70jB4OCH8KL1DInjw8uIXv4jcYHIF6HEe1Mtl2Rwq\n 9NJIU4B+DCHC9EwX9+wZXYLjkKB5X34eIeHR9EH+MIlfBK+Qi4zrnA2U0lLFMhMCTIvw\n kED93U9WteXdtzsDe4EK5sU3DTviz8vVJQdUVzY7USRCFxp44CMga6Vm9N7eEEiMIVG9\n BpvtH2PFDaqL6hdJh5QdETlZZaJ8gbYR3BLP92du2EVK2k3eubyCWS7wkF+1kwxHpwLx\n M0/A==","X-Gm-Message-State":"AOJu0YzJ5AfQwKLJHJIcwizjnDtGWdy0m+/djlgFwKafbkJZw7sDEXr3\n C+gntIh584DZs0/WR3MYNEpvC3Uo+UUi+IS/r4FlZYe4VjMSigffjxNnGufeSxZfhPWBTToBElo\n 2we3Y7VRKps9h86dW1rJQY8Kjsq7Y8PU=","X-Gm-Gg":"AeBDievIRxTqkqF3nCZvSZwLHP1b4uOLQlETVB6Kk+msNTDM7M9dJI8Lrk9PsNm29pO\n jAYcHgqzfUf/SnalSOwtaZAhZX3s5/86cSZb5Ee7rVTKFRygSOSejVlEkdL9okeYPOfOkK26RKY\n TiS/u9zAo0IuzX4A+N9iFHQPk0guIfSCQr/av+9KMNq7lQ6YgKEGSK0mm9UuCb4Quon5Otbd0+D\n 9cHq97sDWn6rNy8Ar2r/yR6FZ+JBln5vz46osPb1nXmePYRore9uKZvXZ9jaotLRCJMVTsbT47I\n ruCA8XmvTxH8HZKIfbBCjfy5+Bxoevi6JbGZKrJ3","X-Received":"by 2002:a05:7022:670a:b0:128:d714:3ca1 with SMTP id\n a92af1059eb24-12c34e39792mr2512772c88.5.1775839317658; Fri, 10 Apr 2026\n 09:41:57 -0700 (PDT)","MIME-Version":"1.0","References":"<20260410151818.817298-1-development@knutsson.it>","In-Reply-To":"<20260410151818.817298-1-development@knutsson.it>","From":"=?utf-8?q?Marc-Andr=C3=A9_Lureau?= ","Date":"Fri, 10 Apr 2026 20:41:44 +0400","X-Gm-Features":"AQROBzBkj661Jq2vxSVu87bi6ZXY6BIVNSDYmE7csTJhBL2RgVjGr9aBeScvi78","Message-ID":"\n ","Subject":"Re: [PATCH] monitor: fix missing spaces in screendump help text","To":"Brian Knutsson ","Cc":"qemu-devel@nongnu.org","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","Received-SPF":"pass client-ip=2607:f8b0:4864:20::1234;\n envelope-from=marcandre.lureau@gmail.com; helo=mail-dl1-x1234.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}},{"id":3676006,"web_url":"http://patchwork.ozlabs.org/comment/3676006/","msgid":"<8912bb9a-6efc-4239-a29a-c309afc82228@linaro.org>","list_archive_url":null,"date":"2026-04-10T18:37:35","subject":"Re: [PATCH] monitor: fix missing spaces in screendump help text","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/people/85046/","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"content":"On 10/4/26 17:18, Brian Knutsson wrote:\n> From: Knutsson Development \n> \n> Signed-off-by: Knutsson Development \n> ---\n> hmp-commands.hx | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n\nReviewed-by: Philippe Mathieu-Daudé ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=BsvgZy9g;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fsltW3Z3tz1y2d\n\tfor ; Sat, 11 Apr 2026 04:38:27 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wBGjj-0007Bx-K6; Fri, 10 Apr 2026 14:37:47 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wBGje-0007Bh-Ed\n for qemu-devel@nongnu.org; Fri, 10 Apr 2026 14:37:43 -0400","from mail-wr1-x42c.google.com ([2a00:1450:4864:20::42c])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1wBGja-0006ou-PC\n for qemu-devel@nongnu.org; Fri, 10 Apr 2026 14:37:41 -0400","by mail-wr1-x42c.google.com with SMTP id\n ffacd0b85a97d-43cfb723793so1633915f8f.2\n for ; Fri, 10 Apr 2026 11:37:37 -0700 (PDT)","from [192.168.69.228] (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-43d63de2e4csm9977725f8f.2.2026.04.10.11.37.35\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Fri, 10 Apr 2026 11:37:35 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1775846256; x=1776451056; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:from:references:to\n :content-language:subject:user-agent:mime-version:date:message-id\n :from:to:cc:subject:date:message-id:reply-to;\n bh=eB7mS78cWJjiwaXFZoRSuwSwbYksJx65WV2q0b6vgZg=;\n b=BsvgZy9gI8/t66ZtPdY9N+1c8xC8+gZOHDPuyz1CEj7y604UFUG462Q5IqXaAaLwl9\n wRsMSdfoYP1O8oHtUKdj8m0/A11MsYnHUyl3gzo5P14u+Q5xhXTsvxHH5hljUowiTuW2\n aOA7gvAyaK83xMu1uaz73eAEnHfvB5a2zwdGLuIdLGLmso9ODtI1v7KXTFuqjolJdUYh\n LImcQhifzAKkxIMBSZG6H9kwH2UqGpx/TS2S2VErCAAaFCzQhsheNhAp7EihUAxFGJlp\n PEKkBBz7IrLJa8SIUR41GphTZVBfTKK4QGHgM7K0C+lkcwIV1baNNFJqYAyfmEgZ7ccr\n n2Qg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775846256; x=1776451056;\n h=content-transfer-encoding:in-reply-to:from:references:to\n :content-language:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=eB7mS78cWJjiwaXFZoRSuwSwbYksJx65WV2q0b6vgZg=;\n b=KqWPl/56f8zrXJbvGxvPNOhZP2TgzAy+oUdu4M9KKI8AMHa5pdS+KpK0w05XsLDb4y\n N7Dj6EYo8JG2BFMrAf/HKgF5K/V/gGWrJGJdjcUpjNxNF4hf9HjnmU9dThLkGfsNPJe3\n wX4tlEu7/HLcNeMQ6hlbH+ifOv8ATBUK78o/TpGTbVNaJ6AwiQu+oedJv74hw5aAJ6cS\n hr9ZVs1kjMEnEsp9/BpCY3bHr3/pHJrT6iPpHfY7jYufRzjQ+XoPCm7/QlnpXEN9JvQ8\n i1fGONyEkHnlFEGQeM6oas2MQIzm58cVPkOgW95dRCWONCqLF+dhK06J7mFLnpgfeiUc\n ECRg==","X-Forwarded-Encrypted":"i=1;\n AJvYcCWUIXk6eEWEBOQAkOY923TA4Qiich6wq4/W4BwtaLRG2HAysVWQG1Y/F45ZdW8zlMzso3kmB8BDAmAa@nongnu.org","X-Gm-Message-State":"AOJu0YzTDbXVA81lqL37p70up2ms4qwqYusvlWIzdTavLHOZy+Ycq4WI\n t04EoFk0JOURylIytBLe1GvlWntRBBRYN33qkahB8SSIgfHtgcuJbSrbfQVi+ZxCawwonLu4sA0\n A6r6F6N8=","X-Gm-Gg":"AeBDiesOU88DHPkdquPBxAXWJ45CV3obyyOsmiQDGygTwOMIsqDZR0fNoxEqZwqaOW6\n mAF8pYtgwHjQit0UJnYR+7LsAesAvnzR/ZclStKXV3tToWaTBkJlpy7xcdqZBET/fDrc+SSXNfY\n w/R8z5rKHSeAhdIvazMWWh60EHra8I/zbFvpujqhPvvIZ4c5sSWW+5vhjAVFn3ts+q6e5EkI5nP\n r2LHYvv+JH4ZrtF+jVNT8/zMV599SAsWh/Z+oysqXoAnXQGSyMiM0sJRiZs5i0jYxlkSS0YMwGA\n /hXe00dOW5It2JmY8yYZiCMq9cgrvfr4+ePKKUyAy0BOJZlwWodKsffyLyqhLYPpAhilqw7ABDS\n nRLJzz0quvM8i5nhCqW6xcMdKFzV8xhKiBm8GIlEV2W0Gg9MNW/tisn488ilYrcZYwptghV/7NO\n sc4nWIi+eLz4ftRnAcOR+L31XyUF2vN1deQauBoKfNj9YL8IBOVaXx3pmauhOQ22Uaww==","X-Received":"by 2002:a05:6000:4284:b0:439:d242:e8fe with SMTP id\n ffacd0b85a97d-43d64289c7emr6737794f8f.11.1775846256458;\n Fri, 10 Apr 2026 11:37:36 -0700 (PDT)","Message-ID":"<8912bb9a-6efc-4239-a29a-c309afc82228@linaro.org>","Date":"Fri, 10 Apr 2026 20:37:35 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH] monitor: fix missing spaces in screendump help text","Content-Language":"en-US","To":"Brian Knutsson , qemu-devel@nongnu.org","References":"<20260410151818.817298-1-development@knutsson.it>","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","In-Reply-To":"<20260410151818.817298-1-development@knutsson.it>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::42c;\n envelope-from=philmd@linaro.org; helo=mail-wr1-x42c.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]