[{"id":3676249,"web_url":"http://patchwork.ozlabs.org/comment/3676249/","msgid":"","date":"2026-04-12T08:56:33","subject":"Re: [patch 30/38] openrisc: Select ARCH_HAS_RANDOM_ENTROPY","submitter":{"id":68420,"url":"http://patchwork.ozlabs.org/api/people/68420/","name":"Stafford Horne","email":"shorne@gmail.com"},"content":"On Fri, Apr 10, 2026 at 02:20:55PM +0200, Thomas Gleixner wrote:\n> The only remaining non-architecture usage of get_cycles() is to provide\n> random_get_entropy().\n> \n> Switch openrisc over to the new scheme of selecting ARCH_HAS_RANDOM_ENTROPY\n> and providing random_get_entropy() in asm/random.h.\n> \n> Add 'asm/timex.h' includes to the relevant files, so the global include can\n> be removed once all architectures are converted over.\n> \n> Signed-off-by: Thomas Gleixner \n> Cc: Jonas Bonn \n> Cc: linux-openrisc@vger.kernel.org\n\nThis looks good to me.\n\nAcked-by: Stafford Horne \n\n> ---\n> arch/openrisc/Kconfig | 1 +\n> arch/openrisc/include/asm/random.h | 12 ++++++++++++\n> arch/openrisc/include/asm/timex.h | 5 -----\n> arch/openrisc/lib/delay.c | 1 +\n> 4 files changed, 14 insertions(+), 5 deletions(-)\n> \n> --- a/arch/openrisc/Kconfig\n> +++ b/arch/openrisc/Kconfig\n> @@ -10,6 +10,7 @@ config OPENRISC\n> \tselect ARCH_HAS_DELAY_TIMER\n> \tselect ARCH_HAS_DMA_SET_UNCACHED\n> \tselect ARCH_HAS_DMA_CLEAR_UNCACHED\n> +\tselect ARCH_HAS_RANDOM_ENTROPY\n> \tselect ARCH_HAS_SYNC_DMA_FOR_DEVICE\n> \tselect GENERIC_BUILTIN_DTB\n> \tselect COMMON_CLK\n> --- /dev/null\n> +++ b/arch/openrisc/include/asm/random.h\n> @@ -0,0 +1,12 @@\n> +/* SPDX-License-Identifier: GPL-2.0-or-later */\n> +#ifndef __ASM_OPENRISC_RANDOM_H\n> +#define __ASM_OPENRISC_RANDOM_H\n> +\n> +#include \n> +\n> +static inline unsigned long random_get_entropy(void)\n> +{\n> +\treturn get_cycles();\n> +}\n> +\n> +#endif\n> --- a/arch/openrisc/include/asm/timex.h\n> +++ b/arch/openrisc/include/asm/timex.h\n> @@ -9,13 +9,9 @@\n> * OpenRISC implementation:\n> * Copyright (C) 2010-2011 Jonas Bonn \n> */\n> -\n> #ifndef __ASM_OPENRISC_TIMEX_H\n> #define __ASM_OPENRISC_TIMEX_H\n> \n> -#define get_cycles get_cycles\n> -\n> -#include \n> #include \n> #include \n> \n> @@ -23,6 +19,5 @@ static inline cycles_t get_cycles(void)\n> {\n> \treturn mfspr(SPR_TTCR);\n> }\n> -#define get_cycles get_cycles\n> \n> #endif\n> --- a/arch/openrisc/lib/delay.c\n> +++ b/arch/openrisc/lib/delay.c\n> @@ -18,6 +18,7 @@\n> #include \n> \n> #include \n> +#include \n> #include \n> \n> bool delay_read_timer(unsigned long *timer_value)\n> \n>","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=IupEoFTz;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=2404:9400:21b9:f100::1; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev+bounces-19656-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)","lists.ozlabs.org;\n arc=none smtp.remote-ip=\"2a00:1450:4864:20::42b\"","lists.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com","lists.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=IupEoFTz;\n\tdkim-atps=neutral","lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com\n (client-ip=2a00:1450:4864:20::42b; helo=mail-wr1-x42b.google.com;\n envelope-from=shorne@gmail.com; receiver=lists.ozlabs.org)"],"Received":["from lists.ozlabs.org (lists.ozlabs.org\n [IPv6:2404:9400:21b9:f100::1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1 raw public key)\n server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4ftktX6czqz1yGj\n\tfor ; Sun, 12 Apr 2026 18:56:52 +1000 (AEST)","from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4ftktQ71fzz2ynv;\n\tSun, 12 Apr 2026 18:56:46 +1000 (AEST)","from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com\n [IPv6:2a00:1450:4864:20::42b])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4ftktP0F87z2yng\n\tfor ; Sun, 12 Apr 2026 18:56:44 +1000 (AEST)","by mail-wr1-x42b.google.com with SMTP id\n ffacd0b85a97d-43d75312379so133520f8f.1\n for ;\n Sun, 12 Apr 2026 01:56:43 -0700 (PDT)","from localhost\n (brnt-04-b2-v4wan-170138-cust2432.vm7.cable.virginm.net. [94.175.9.129])\n by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-488d532ed4dsm197923925e9.4.2026.04.12.01.56.33\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Sun, 12 Apr 2026 01:56:34 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1775984206;\n\tcv=none;\n b=Z3IfRxhX82Oo3mOMs2WUs5IcwxsX+texUs2wi0SreBYpjM7sEZAt7aL45AhVBqteKqaumNZFuQOR7o62SS3wUcaRyreGo7eyIJVv+Fjnk1DoGarHlYzgicuhV/sCnL9Ab7ngXAm6ckanYG27TroCJUAj9E/zsZJMdyVO6YgCMNzDEuc79whdDEHGG0bLfj3mbCtXqmIaVln+58I0x8qxn4P+7e/0EoGTiFtZPpzwziNkuj7zL/jaWD1TxzkXFn1foIwiUHTPLXwMMOqgflTUaEX/aHoDaRJ+DP9Nb823uIJnVlUfw7eU7fZ5MEV9RLqkMHPRbpy8kP4yMzpBWPY0ZA==","ARC-Message-Signature":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1775984206; c=relaxed/relaxed;\n\tbh=EbDgrbrkQIZIzHMqS4zyFwb8jbE/7QCDRz8zhtNheE4=;\n\th=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:\n\t Content-Type:Content-Disposition:In-Reply-To;\n b=DYTV5sCfJfxS8EtrcFN9W0iYry7m7whBlR5Qil/zwlP2IqPCbl+SLlYieQWh7uBljhNOoHMb7S5/UtOXTFzZQk2YrET1EzBAj5xx1nr2JLy5BQajS32sfjofFg2GQZjUV8RUjQdfjMVrn7hNbhElmBFwRqPEukeo+XnIXxRpzI3XYIMwew3GTXGpVYsk9UGPmPHfe0pJU//VbzUUbKptdALxmejufVjWJ3ZpTxBH+Y+PYZbOGsF2+OnvpZujt1QmU6I5dZKDz7c5ZfmVffR7y7Wl5zvUTKGyDmvL0k8wG3AwLeK/xBanYgChxS+7lmVFbEI4KEhG0DxWhNkkJkUEAw==","ARC-Authentication-Results":"i=1; lists.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com; dkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=IupEoFTz; dkim-atps=neutral;\n spf=pass (client-ip=2a00:1450:4864:20::42b; helo=mail-wr1-x42b.google.com;\n envelope-from=shorne@gmail.com;\n receiver=lists.ozlabs.org) smtp.mailfrom=gmail.com","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1775984196; x=1776588996;\n darn=lists.ozlabs.org;\n h=in-reply-to:content-disposition:mime-version:references:message-id\n :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to;\n bh=EbDgrbrkQIZIzHMqS4zyFwb8jbE/7QCDRz8zhtNheE4=;\n b=IupEoFTzVgScv1B4jNJJeSZYkRJAjDRpAhQZUmHA+4XVLql9iHp1pyBcC5f/G1Gw1E\n HgFoA9CUKP3MWdH6hvklTlUNXM5VC+QX9MJGtNsli/pDPeS65smWXBcYs4YGEJxuTi6i\n LBIlhjjwo+h7tiC2fvZ47PwMLCchCYhe8TVAyR3Oj4FrlTUc7xZ/5o4xEFtD/T0VgYt4\n n1DyEeOyu48q5qtlsCiHPgPBpx6YQlBvQIYD8o0rT+/ivPguxoKC60Yroc3LMlykzC+0\n yeFsPTYfTNd2eIYkP5F/cSnkWqL4okT8Y3MqTh/lhZLMq8wkhV7nPcjJ1E/ddgEWpb2k\n 3rEA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775984196; x=1776588996;\n h=in-reply-to:content-disposition:mime-version:references:message-id\n :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=EbDgrbrkQIZIzHMqS4zyFwb8jbE/7QCDRz8zhtNheE4=;\n b=fLIhms6gYksTuxnAHvPe+g0MjgzRu63vS3HuWSVfaYdmKGwtPhMJI5gax+YgQmFRKt\n wqtB/xjtJyeBzzyDKF+dTDrRnqnXHfp0+t6RZndfQpF0UMYcbTjNH24j06SKe437TiZ5\n ExaXSZJAKjiK/6kyp2bEcdFcA7o2cvVSVf1toQGZpzJEZVNWpFcZXJ2K+PgMJSbYhIoX\n cz91G1u+7hiRzsF6NyKHDDPcfMyVcP+UNZ8cVVZz0gfJO3VOhXlWxCE70aq4TgsMykuc\n nDty5z2yTIgHJWu24i3HrahV5C9UXfaa6/1Eq0neZPsGq5eoC9VMep8LpSMv8Tr5MyBS\n qHRQ==","X-Forwarded-Encrypted":"i=1;\n AJvYcCWImZRwfEbH55/uFw0LwOJfNUjyCyCBMCLBLCk402f08ZVstbu6RHdyuundNOBotNnVAKNUeWZ6lbp7bSs=@lists.ozlabs.org","X-Gm-Message-State":"AOJu0YyWMGsrtbpnf1UqP71SfudODsZxfAY3yP63PEZzQmodNJQI0xHz\n\tjyvlmBd63RDms6tqqXnJEt9xGY/5BwQ+Hso2PKoXaog5eAmYtiTl801n","X-Gm-Gg":"AeBDieucooeeNNrQ4nfZTaOvEm62Dwgml2hxz7fx1jbA8Cp3tS3FYxVfne9udLbRd3j\n\twHkqINWv6eXAy85LcYvXhTfILzkvdqhYL5EkW+2DHvb/CXgLXG2zxfxFHKnNSO+eKtiGXNpXRui\n\tG5Ev6ZRNnZHJsnbBHdNCLJdUxu25PUOraVd4BIFBIwCiujPfG1SVacK7yltEYm8mmsLRpjzbT2u\n\ttb22EmGwJug193mcexLRo3KCv2El3ANDObhDYG03E2xlyU8gSIBpfWw6ymMt8OKNbWhbCTFvT8j\n\tM91un2xQW/HqUwiMCqZIgWJMOXlRrVerBF4ELP4KgT+fh1JYxf6+TgKFCj2dAJtLahggsRNj6v/\n\tBsOrHOPl/t9K+gaU7o2gQ86ESxgYJ6Rt7fMCXqyC9gjRH3og8GvBzcaPsXTicpG/uEJhBuWDUia\n\tUm6DM63lxPfSdu6PHQIrOa/sdueGy8xFcANFPpROFawtCUPsE5rB3NjvhSSjRxouqZVJ7RhOxwO\n\tkbjYg==","X-Received":"by 2002:a05:600c:698d:b0:487:22ad:403e with SMTP id\n 5b1f17b1804b1-488d6ac9ce5mr126951995e9.14.1775984195334;\n Sun, 12 Apr 2026 01:56:35 -0700 (PDT)","Date":"Sun, 12 Apr 2026 09:56:33 +0100","From":"Stafford Horne ","To":"Thomas Gleixner ","Cc":"LKML , Jonas Bonn ,\n\tlinux-openrisc@vger.kernel.org, Arnd Bergmann ,\n\tx86@kernel.org, Lu Baolu ,\n\tiommu@lists.linux.dev,\n\tMichael Grzeschik ,\n\tnetdev@vger.kernel.org, linux-wireless@vger.kernel.org,\n\tHerbert Xu ,\n\tlinux-crypto@vger.kernel.org, Vlastimil Babka ,\n\tlinux-mm@kvack.org, David Woodhouse ,\n\tBernie Thompson , linux-fbdev@vger.kernel.org,\n\tTheodore Tso , linux-ext4@vger.kernel.org,\n\tAndrew Morton ,\n\tUladzislau Rezki , Marco Elver ,\n\tDmitry Vyukov , kasan-dev@googlegroups.com,\n\tAndrey Ryabinin ,\n\tThomas Sailer , linux-hams@vger.kernel.org,\n\t\"Jason A. Donenfeld\" ,\n\tRichard Henderson ,\n\tlinux-alpha@vger.kernel.org, Russell King ,\n\tlinux-arm-kernel@lists.infradead.org,\n\tCatalin Marinas ,\n\tHuacai Chen , loongarch@lists.linux.dev,\n\tGeert Uytterhoeven ,\n\tlinux-m68k@lists.linux-m68k.org, Dinh Nguyen ,\n\tHelge Deller , linux-parisc@vger.kernel.org,\n\tMichael Ellerman ,\n\tlinuxppc-dev@lists.ozlabs.org, Paul Walmsley ,\n\tlinux-riscv@lists.infradead.org, Heiko Carstens ,\n\tlinux-s390@vger.kernel.org, \"David S. Miller\" ,\n\tsparclinux@vger.kernel.org","Subject":"Re: [patch 30/38] openrisc: Select ARCH_HAS_RANDOM_ENTROPY","Message-ID":"","References":"<20260410120044.031381086@kernel.org>\n <20260410120319.593798781@kernel.org>","X-Mailing-List":"linuxppc-dev@lists.ozlabs.org","List-Id":"","List-Help":"","List-Owner":"","List-Post":"","List-Archive":",\n ","List-Subscribe":",\n ,\n ","List-Unsubscribe":"","Precedence":"list","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20260410120319.593798781@kernel.org>","X-Spam-Status":"No, score=-0.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID,\n\tDKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,\n\tSPF_HELO_NONE,SPF_PASS autolearn=disabled version=4.0.1 OzLabs 8","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org"}}]