[{"id":3676585,"web_url":"http://patchwork.ozlabs.org/comment/3676585/","msgid":"","date":"2026-04-13T09:15:02","subject":"Re: [patch 07/38] treewide: Consolidate cycles_t","submitter":{"id":83422,"url":"http://patchwork.ozlabs.org/api/people/83422/","name":"Ojaswin Mujoo","email":"ojaswin@linux.ibm.com"},"content":"On Fri, Apr 10, 2026 at 02:19:03PM +0200, Thomas Gleixner wrote:\n> Most architectures define cycles_t as unsigned long execpt:\n> \n> - x86 requires it to be 64-bit independent of the 32-bit/64-bit build.\n> \n> - parisc and mips define it as unsigned int\n> \n> parisc has no real reason to do so as there are only a few usage sites\n> which either expand it to a 64-bit value or utilize only the lower\n> 32bits.\n> \n> mips has no real requirement either.\n> \n> Move the typedef to types.h and provide a config switch to enforce the\n> 64-bit type for x86.\n> \n> Signed-off-by: Thomas Gleixner \n> ---\n> arch/Kconfig | 4 ++++\n> arch/alpha/include/asm/timex.h | 3 ---\n> arch/arm/include/asm/timex.h | 1 -\n> arch/loongarch/include/asm/timex.h | 2 --\n> arch/m68k/include/asm/timex.h | 2 --\n> arch/mips/include/asm/timex.h | 2 --\n> arch/nios2/include/asm/timex.h | 2 --\n> arch/parisc/include/asm/timex.h | 2 --\n> arch/powerpc/include/asm/timex.h | 4 +---\n> arch/riscv/include/asm/timex.h | 2 --\n> arch/s390/include/asm/timex.h | 2 --\n> arch/sparc/include/asm/timex_64.h | 1 -\n> arch/x86/Kconfig | 1 +\n> arch/x86/include/asm/tsc.h | 2 --\n> include/asm-generic/timex.h | 1 -\n> include/linux/types.h | 6 ++++++\n> 16 files changed, 12 insertions(+), 25 deletions(-)\n> \n<...>\n\n> --- a/arch/powerpc/include/asm/timex.h\n> +++ b/arch/powerpc/include/asm/timex.h\n> @@ -11,9 +11,7 @@\n> #include \n> #include \n> \n> -typedef unsigned long cycles_t;\n> -\n> -static inline cycles_t get_cycles(void)\n> +ostatic inline cycles_t get_cycles(void)\n\nHi Thomas, I'm in middle of testing this series on powerpc. In the meantime I\nnoticed that there's probably a small typo here (althrough this is fixed\nlater)\n\nRegards,\nojaswin\n> {\n> \treturn mftb();\n> }","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=oY+vEH1n;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=112.213.38.117; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev+bounces-19670-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)","lists.ozlabs.org;\n arc=none smtp.remote-ip=148.163.156.1","lists.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=linux.ibm.com","lists.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=oY+vEH1n;\n\tdkim-atps=neutral","lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=linux.ibm.com\n (client-ip=148.163.156.1; helo=mx0a-001b2d01.pphosted.com;\n envelope-from=ojaswin@linux.ibm.com; receiver=lists.ozlabs.org)"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1 raw public key)\n server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fvMGG5Mc7z1xtJ\n\tfor ; Mon, 13 Apr 2026 19:16:06 +1000 (AEST)","from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4fvMGG0N7tz2yrb;\n\tMon, 13 Apr 2026 19:16:06 +1000 (AEST)","from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com\n [148.163.156.1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4fvMGF03Drz2yjV\n\tfor ; Mon, 13 Apr 2026 19:16:04 +1000 (AEST)","from pps.filterd (m0360083.ppops.net [127.0.0.1])\n\tby mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 63CNQ6Rp3649347;\n\tMon, 13 Apr 2026 09:15:18 GMT","from ppma12.dal12v.mail.ibm.com\n (dc.9e.1632.ip4.static.sl-reverse.com [50.22.158.220])\n\tby mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4dfdt3px1j-1\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n\tMon, 13 Apr 2026 09:15:17 +0000 (GMT)","from pps.filterd (ppma12.dal12v.mail.ibm.com [127.0.0.1])\n\tby ppma12.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id\n 63D80WMC015153;\n\tMon, 13 Apr 2026 09:15:16 GMT","from smtprelay07.fra02v.mail.ibm.com ([9.218.2.229])\n\tby ppma12.dal12v.mail.ibm.com (PPS) with ESMTPS id 4dg0mscku7-1\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n\tMon, 13 Apr 2026 09:15:16 +0000","from smtpav02.fra02v.mail.ibm.com (smtpav02.fra02v.mail.ibm.com\n [10.20.54.101])\n\tby smtprelay07.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id\n 63D9FEC727328866\n\t(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);\n\tMon, 13 Apr 2026 09:15:14 GMT","from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id 70F6620043;\n\tMon, 13 Apr 2026 09:15:14 +0000 (GMT)","from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1])\n\tby IMSVA (Postfix) with ESMTP id B712A2004F;\n\tMon, 13 Apr 2026 09:15:04 +0000 (GMT)","from li-dc0c254c-257c-11b2-a85c-98b6c1322444.ibm.com (unknown\n [9.123.13.2])\n\tby smtpav02.fra02v.mail.ibm.com (Postfix) with ESMTPS;\n\tMon, 13 Apr 2026 09:15:04 +0000 (GMT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1776071765;\n\tcv=none;\n b=MFWm4xg50HljMElF7XqmioQwkjN7cyrC1Zea2dCQ2Tz3DtAzIOTNnLpcHpq/GxF5VRuW/Iq57FFbC/fi0Z6oUPUmy3BFTMtCUq9JIqelCXM2Ev/PSs8ZOUCnCN9H28w+7JEeJwi7G33jbHJw8Tzk77qYrnzFAnjzlfjCR8FAkg5m66H26Hu+gnN1UuqWo95IeF5t/AibUAOlw5psIyD9Wfx7I4DmVjYrlKvNIRBw/MCyzp+EUQlozoAiw0IxemxZLuLq9hpRTIpp+ASR3Xw7C0r1Y7mmszP+tl8SGJeOel1vea4bgThNgRe9g2ADQ+shPjlZqIItVA1/tFwrPB43PA==","ARC-Message-Signature":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1776071765; c=relaxed/relaxed;\n\tbh=3hYK9Ei+d9kVH0VV/CR68CUDnV5UVCrS18XI/2Q3GjY=;\n\th=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:\n\t Content-Type:Content-Disposition:In-Reply-To;\n b=ipqJhxzFAw2+FuqPg643G4jn/y3a81Ik+dmpi+GkZXvDeUOAsYzfr2Ip4ZVlAt/sStPu4OqU0RCIY+IreBQ57ho0BCPbCacURC0mmnw9QLJHhq8yKxC9etTuuw5cGkwzfHM8XuW9Gg6fvuoFgwm3uCl+aamfmncdSLuV7mBu3xKeQXJBSYXJnYrXWPw/MwNsSwO+TCjwJPQYiCOrlBnUaf9xGZ4J+X40XnKs6146e9HBOEXvXD6CfqKYP78gr50PT2CaTbff4eC/I4TRDZvswBftP+0LDJTP873pdcHmTcbApPvjlOdOhqhSQCE6Y6CaA4YQRvMUoiaut1q6gOnnHQ==","ARC-Authentication-Results":"i=1; lists.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=linux.ibm.com;\n dkim=pass (2048-bit key;\n unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256\n header.s=pp1 header.b=oY+vEH1n; dkim-atps=neutral;\n spf=pass (client-ip=148.163.156.1; helo=mx0a-001b2d01.pphosted.com;\n envelope-from=ojaswin@linux.ibm.com;\n receiver=lists.ozlabs.org) smtp.mailfrom=linux.ibm.com","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc\n\t:content-type:date:from:in-reply-to:message-id:mime-version\n\t:references:subject:to; s=pp1; bh=3hYK9Ei+d9kVH0VV/CR68CUDnV5UVC\n\trS18XI/2Q3GjY=; b=oY+vEH1nHYm21zR7dKdG+rMVbiAs+2M4pSYJYH25H3Q/WQ\n\tS5pbibNxKHXRtCU5RA4BZpoAC/CsLV14kYSk9HD7BI83gpVLqIVXm+N3/UD3mtFb\n\tVGL3bfwkoS+MFSXp/7ksAXz/d/43BdzYyNe+WU94qMB7+oTAY5jMdy/aC1rg5QU1\n\tUhBzNrX2r1ZHEsamBr6j/bYRaaLxasa1WWuLDHkVDfa2K6RkMY6wizvw26f4v3Pw\n\tkdUQa11kKa0O4lHqHX35TBGaxo9cfSk8h/UtwhMbDVaUgMt8SMltIpECwIrRGVKB\n\tKeirN6PqfMTEor0kXcjWPcrhlHvR883P23ApPmxw==","Date":"Mon, 13 Apr 2026 14:45:02 +0530","From":"Ojaswin Mujoo ","To":"Thomas Gleixner ","Cc":"LKML , Arnd Bergmann ,\n x86@kernel.org, Lu Baolu ,\n iommu@lists.linux.dev, Michael Grzeschik ,\n netdev@vger.kernel.org, linux-wireless@vger.kernel.org,\n Herbert Xu ,\n linux-crypto@vger.kernel.org,\n Vlastimil Babka , linux-mm@kvack.org,\n David Woodhouse ,\n Bernie Thompson , linux-fbdev@vger.kernel.org,\n Theodore Tso , linux-ext4@vger.kernel.org,\n Andrew Morton ,\n Uladzislau Rezki , Marco Elver ,\n Dmitry Vyukov , kasan-dev@googlegroups.com,\n Andrey Ryabinin ,\n Thomas Sailer , linux-hams@vger.kernel.org,\n \"Jason A. Donenfeld\" ,\n Richard Henderson ,\n linux-alpha@vger.kernel.org, Russell King ,\n linux-arm-kernel@lists.infradead.org,\n Catalin Marinas ,\n Huacai Chen , loongarch@lists.linux.dev,\n Geert Uytterhoeven ,\n linux-m68k@lists.linux-m68k.org, Dinh Nguyen ,\n Jonas Bonn , linux-openrisc@vger.kernel.org,\n Helge Deller , linux-parisc@vger.kernel.org,\n Michael Ellerman , linuxppc-dev@lists.ozlabs.org,\n Paul Walmsley , linux-riscv@lists.infradead.org,\n Heiko Carstens , linux-s390@vger.kernel.org,\n \"David S. Miller\" , sparclinux@vger.kernel.org","Subject":"Re: [patch 07/38] treewide: Consolidate cycles_t","Message-ID":"","References":"<20260410120044.031381086@kernel.org>\n <20260410120318.045532623@kernel.org>","X-Mailing-List":"linuxppc-dev@lists.ozlabs.org","List-Id":"","List-Help":"","List-Owner":"","List-Post":"","List-Archive":",\n ","List-Subscribe":",\n ,\n ","List-Unsubscribe":"","Precedence":"list","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20260410120318.045532623@kernel.org>","X-TM-AS-GCONF":"00","X-Proofpoint-Reinject":"loops=2 maxloops=12","X-Proofpoint-ORIG-GUID":"r6KN03kK1HZaoam71kVl5aHZm9BfgAQ4","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwNDEzMDA4NSBTYWx0ZWRfX+Gwbo0yddZP/\n ED3CWrVQNFFw/TECS1M9+tSS57FYBZnMmG79KmJVnAwBWc3o5BgyeadFZ9maSHI4Tv+/+VHQiXF\n uu6/EAbMsVnRYIXugjj6TyQBBqRyeSoPbLxIVX8tqr0goumkz0lPJ9Y4Y3a3ECfM9WbzUtOSm5u\n eNbyrRMw+nuwi0Afz/QuxwA0FuazktkFPrSziYKfNEV92tR6ksCbhLbdKwZfOQ6IaUNAK3mHh04\n Z9ZuJvFG4+5R/DIJQ8v5H1fE5bYExgqIL1hC1HoekBef4/UHL3Jav5jU5Ty8ib2gAESLlopFcCb\n VttV6mxWXomhvrcFDBgGSdweqIiLio3UyKWRaxfdCdf1K3UdP0nDdx3LiWp/XKSUCxaso/02xav\n PADy/jEsrag0vsgcCLG1/jcBcJ3bFL3cNcYlDCC6JXFySGCPKTcpDMOtfvLh9vv4Vg7VR02ItSs\n a0USozVz3do3GTBrHkA==","X-Proofpoint-GUID":"iwEVNX-0n_YmGG6iAARt9TRRoEhRuwqE","X-Authority-Analysis":"v=2.4 cv=WpEb99fv c=1 sm=1 tr=0 ts=69dcb426 cx=c_pps\n a=bLidbwmWQ0KltjZqbj+ezA==:117 a=bLidbwmWQ0KltjZqbj+ezA==:17\n a=kj9zAlcOel0A:10 a=A5OVakUREuEA:10 a=VkNPw1HP01LnGYTKEx00:22\n a=RnoormkPH1_aCDwRdu11:22 a=iQ6ETzBq9ecOQQE5vZCe:22 a=VwQbUJbxAAAA:8\n a=9Pz4rRoAHiK5H5RfW9YA:9 a=CjuIK1q_8ugA:10","X-Proofpoint-Virus-Version":"vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-04-13_02,2026-04-09_02,2025-10-01_01","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n priorityscore=1501 phishscore=0 bulkscore=0 adultscore=0 spamscore=0\n malwarescore=0 clxscore=1011 lowpriorityscore=0 suspectscore=0\n impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc=\n route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604010000\n definitions=main-2604130085","X-Spam-Status":"No, score=-0.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID,\n\tRCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,\n\tSPF_PASS autolearn=disabled version=4.0.1 OzLabs 8","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org"}}]