[{"id":3675912,"web_url":"http://patchwork.ozlabs.org/comment/3675912/","msgid":"<20260410144457.GU41863@bill-the-cat>","list_archive_url":null,"date":"2026-04-10T14:44:57","subject":"Re: [PATCH] common: spl: spl_nand: make CONFIG_SYS_NAND_U_BOOT_OFFS\n optional in spl_nand_get_uboot_raw_page()","submitter":{"id":65875,"url":"http://patchwork.ozlabs.org/api/people/65875/","name":"Tom Rini","email":"trini@konsulko.com"},"content":"On Fri, Apr 10, 2026 at 04:49:33PM +0800, Weijie Gao wrote:\n\n> As spl_nand_get_uboot_raw_page() is a weak function, when a board wants to\n> override it, the CONFIG_SYS_NAND_U_BOOT_OFFS becomes meaningless within\n> this function.\n> \n> This patch allows spl_nand_get_uboot_raw_page() being compiled without\n> CONFIG_SYS_NAND_U_BOOT_OFFS being defined.\n> \n> Note: this is available only when both CONFIG_SPL_NAND_RAW_ONLY and\n> CONFIG_SYS_NAND_U_BOOT_OFFS_REDUND are not defined.\n> \n> Signed-off-by: Weijie Gao \n> ---\n> common/spl/spl_nand.c | 4 ++++\n> 1 file changed, 4 insertions(+)\n\nI think the bug here is that when SYS_NAND_U_BOOT_LOCATIONS isn't\ndefined, we should still be able to override spl_nand_get_uboot_raw_page\n(with an implementation that does not use CONFIG_SYS_NAND_U_BOOT_OFFS).\nCan you please re-examine the code with that in mind? Thanks!","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=konsulko.com header.i=@konsulko.com header.a=rsa-sha256\n header.s=google header.b=FGjRxLff;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=85.214.62.61; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=konsulko.com","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=konsulko.com header.i=@konsulko.com\n header.b=\"FGjRxLff\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=konsulko.com","phobos.denx.de;\n spf=pass smtp.mailfrom=trini@konsulko.com"],"Received":["from phobos.denx.de (phobos.denx.de [85.214.62.61])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fsfjL5dKPz1yGb\n\tfor ; Sat, 11 Apr 2026 00:45:10 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 4772D8414B;\n\tFri, 10 Apr 2026 16:45:06 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id 9356A8414B; Fri, 10 Apr 2026 16:45:05 +0200 (CEST)","from mail-oi1-x22d.google.com (mail-oi1-x22d.google.com\n [IPv6:2607:f8b0:4864:20::22d])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 74F3A84154\n for ; Fri, 10 Apr 2026 16:45:01 +0200 (CEST)","by mail-oi1-x22d.google.com with SMTP id\n 5614622812f47-45f053b7b90so1210840b6e.0\n for ; Fri, 10 Apr 2026 07:45:01 -0700 (PDT)","from bill-the-cat (fixed-189-203-106-235.totalplay.net.\n [189.203.106.235]) by smtp.gmail.com with ESMTPSA id\n 006d021491bc7-68bc88c80a7sm1456150eaf.8.2026.04.10.07.44.59\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 10 Apr 2026 07:44:59 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,\n SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=konsulko.com; s=google; t=1775832300; x=1776437100; darn=lists.denx.de;\n h=in-reply-to:content-disposition:mime-version:references:message-id\n :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to;\n bh=PXVYsMPy+7/2vlC/9evhJEzaeFlFB61pOWczpUjgibk=;\n b=FGjRxLffL4s5jrhVGSs6+lTm4zFAKpgAR3/6qT9TZlDK5e7P90urvCcZdugF9Uf2B6\n leFftQJzv5RwJutphPx2xCWKFTh2FnCtFZVla1Ky6U9OJ8f2OW4nBm4PkGNunL2fwP1A\n R5dp2KJlWlDS6azWRkgNIXKX8Ege2WTE4m63Q=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775832300; x=1776437100;\n h=in-reply-to:content-disposition:mime-version:references:message-id\n :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=PXVYsMPy+7/2vlC/9evhJEzaeFlFB61pOWczpUjgibk=;\n b=eUH3cUaEfls7jj6wpgF3+Gl/C8TL9Cvh6cdJJfsbkkW2hjwRu/PvmXwfP9RWoCQbly\n q+u0RqvwSKrNx+KVeMl+GiS3+iV3zZGTkXA5+gi+pZs8wMEu3rsnlEue2Aeuqc37AbXX\n 5zOm6K2QVyuhlWb5Jl8wbrYA5DWatwPljhxpDwALvjkPcsP34oHcD6xz4t0Qb15ICR7o\n oGqc1z00qIgSFbF4qZVPjjL/BFtrwsxyWnUueQ8pW8OLmqOX80nS+XCOxWz2ZnoMZTYU\n AEiXbFhJum16c7wHirZRPzyT52cMX9FCb9l81kJp7x8C3kF0/umxsx7Ccx6+qYggEJkt\n +aMQ==","X-Gm-Message-State":"AOJu0YzvJXThMCMP760cJhk/EHRGgb4TIXgB4d5huzr+9bcrI6UzAX6+\n ShRKZvKV5BuetSW1aTGaEMOwn0znQAsGb/otdIVhMirkoCq53Ql0FwvHROhrUKwKm1s=","X-Gm-Gg":"AeBDiesleNJKzLJBb1x7OaigMNZIN5b3saBpQc+9gVWDX+MoJU7KgLw1kFAb7X71H/b\n 5se2guYv0SEmQ9HrR7agiqFR3L/EqIqBnRpnq+TmwvW8c5UhcpQGg5bougaOzYxEM6UWdID0wHl\n 1cAtWHyYARV1c9hFMrTVICtWFiZqA+nQTDiSxVNEzFj5QRwsv/iVowG8Hm3k5O4DEq7GrJ2imw0\n iSe4WRuiNi9nTqEfYJoXjxZkMo4XGEYiyBSXLCjmzScGTN6o/CRIEVX7lDt5YdOX8LHS+xkfGoQ\n AW9std3pkQ9LbWkGY4DiH+Oio4lnv9eSdRk5z7EVORuak/7xluxmY3v9XQrR1X4FcdLLYT2W6cq\n tSuiMKXLlgM0bUb9Y6cnCUI5mVBX2vW0fwCWwZhxmxx39APO0pSGAYbcpLeYCnraxSsio61uktq\n fmAQ1svf/6Ho5oOT6B+/jeYPRCtlR2wDM1tga9f9pkcyCeJrdCGEie88aWcqR/3PPQOV6FXQG6G\n 1HI0UtbFH1wBiZx69qw/pGFN+BFOH7rNwr7qdKcflLYOs/TB6U=","X-Received":"by 2002:a05:6820:1749:b0:685:c62e:f8a8 with SMTP id\n 006d021491bc7-68be6331a56mr1691962eaf.17.1775832300125;\n Fri, 10 Apr 2026 07:45:00 -0700 (PDT)","Date":"Fri, 10 Apr 2026 08:44:57 -0600","From":"Tom Rini ","To":"Weijie Gao ","Cc":"u-boot@lists.denx.de,\n GSS_MTK_Uboot_upstream ","Subject":"Re: [PATCH] common: spl: spl_nand: make CONFIG_SYS_NAND_U_BOOT_OFFS\n optional in spl_nand_get_uboot_raw_page()","Message-ID":"<20260410144457.GU41863@bill-the-cat>","References":"<20260410084933.103186-1-weijie.gao@mediatek.com>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha512;\n protocol=\"application/pgp-signature\"; boundary=\"oqC9o2ZsQFYt9Af8\"","Content-Disposition":"inline","In-Reply-To":"<20260410084933.103186-1-weijie.gao@mediatek.com>","X-Clacks-Overhead":"GNU Terry Pratchett","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}}]