[{"id":3675816,"web_url":"http://patchwork.ozlabs.org/comment/3675816/","msgid":"","date":"2026-04-10T11:11:11","subject":"Re: [PATCH 12/20] alpha/PCI: Use PCI resource accessor macros","submitter":{"id":83553,"url":"http://patchwork.ozlabs.org/api/people/83553/","name":"Ilpo Järvinen","email":"ilpo.jarvinen@linux.intel.com"},"content":"On Fri, 10 Apr 2026, Krzysztof Wilczyński wrote:\n\n> Replace direct pdev->resource[] accesses with pci_resource_n(),\n> and pdev->resource[].flags accesses with pci_resource_flags().\n> \n> No functional changes intended.\n> \n> Signed-off-by: Krzysztof Wilczyński \n> ---\n> arch/alpha/kernel/pci-sysfs.c | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/arch/alpha/kernel/pci-sysfs.c b/arch/alpha/kernel/pci-sysfs.c\n> index c84867ce31f5..7aac5e76dcd6 100644\n> --- a/arch/alpha/kernel/pci-sysfs.c\n> +++ b/arch/alpha/kernel/pci-sysfs.c\n> @@ -141,7 +141,7 @@ static int sparse_mem_mmap_fits(struct pci_dev *pdev, int num)\n> \tlong dense_offset;\n> \tunsigned long sparse_size;\n> \n> -\tpcibios_resource_to_bus(pdev->bus, &bar, &pdev->resource[num]);\n> +\tpcibios_resource_to_bus(pdev->bus, &bar, pci_resource_n(pdev, num));\n> \n> \t/* All core logic chips have 4G sparse address space, except\n> \t CIA which has 16G (see xxx_SPARSE_MEM and xxx_DENSE_MEM\n> @@ -181,7 +181,7 @@ static int pci_create_attr(struct pci_dev *pdev, int num)\n> \tsuffix = \"\";\t/* Assume bwx machine, normal resourceN files. */\n> \tnlen1 = 10;\n> \n> -\tif (pdev->resource[num].flags & IORESOURCE_MEM) {\n> +\tif (pci_resource_flags(pdev, num) & IORESOURCE_MEM) {\n\nReviewed-by: Ilpo Järvinen \n\nI started wonder though if we'd want to add pci_resource_is_mem/io() \nshortcuts for these, as it's largely what\n\n git grep pci_resource_flags\n\nresults contain.","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=GspGzkgp;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=112.213.38.117; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev+bounces-19559-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)","lists.ozlabs.org;\n arc=none smtp.remote-ip=198.175.65.16","lists.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=linux.intel.com","lists.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=GspGzkgp;\n\tdkim-atps=neutral","lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=linux.intel.com\n (client-ip=198.175.65.16; helo=mgamail.intel.com;\n envelope-from=ilpo.jarvinen@linux.intel.com; receiver=lists.ozlabs.org)"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1 raw public key)\n server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fsYyq1Wxkz1yGb\n\tfor ; Fri, 10 Apr 2026 21:11:30 +1000 (AEST)","from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4fsYyp60M2z2yft;\n\tFri, 10 Apr 2026 21:11:30 +1000 (AEST)","from mgamail.intel.com (mgamail.intel.com [198.175.65.16])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4fsYyl1W4Gz2xT6\n\tfor ; Fri, 10 Apr 2026 21:11:24 +1000 (AEST)","from fmviesa006.fm.intel.com ([10.60.135.146])\n by orvoesa108.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 10 Apr 2026 04:11:22 -0700","from ijarvine-mobl1.ger.corp.intel.com (HELO localhost)\n ([10.245.244.118])\n by fmviesa006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 10 Apr 2026 04:11:14 -0700"],"ARC-Seal":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1775819490;\n\tcv=none;\n b=Rw3rjeMVZov0JjKcoGL8nPrkVV7xbHL92tYkKw9LgMpNwp5cqkyJO/djhuP/8bOY2m00GiVxML4iJ8JyVFvZ7ksBrzz2Fto1PbN5AH+TYLSwDeSNyPAri3pnQ6IkIt9bNbM1YlJ/VuZZOdh5xGSWQEMwi7c9rA3mSnNpRzqYFWM5pm8tM5Pdtr2Qfxnx0sPCKk7C3pyuZQGChDsR33tjoDWaPLL9qn9HPPyHHVXSbyRn5Fgol6bOknIHwEdpknztMm2nZhxTBDfVwoeYrNx1wRYhcCt/Fo+ASO+xfXlMG0MNaKwH2SgBjckk4GMgf3oyVPF4ZSb9sqEVcxrc39BLOw==","ARC-Message-Signature":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1775819490; c=relaxed/relaxed;\n\tbh=/1nu+i+xJBr0gNAW4Tv1D35zSdF63RaLALTRmfPqfA0=;\n\th=From:Date:To:cc:Subject:In-Reply-To:Message-ID:References:\n\t MIME-Version:Content-Type;\n b=HhoYqS9tAEChxf6LjBgewIYHLBoPgMc/HtaXMpxsICJ/NiKmioCKCimn0ig5D/nEbkDnGVi2BWNrm+Vk0E0e7RZq4UFz66fBtfmRvL3Lr6LcMOM7mWAJIPe0i2/np1JKtGAi2T5Hvdl+9qbhuQFUPowp4XmRux7jO9w6W53XhbSLnYKyGLAFfs9v2pddYxsuDay0mGHR39783jwbVMt3dpulLbbO/XkVXu+/EpX/C9ouE3FG6KJF5RjavRsAygDuqkXgB5RlTMxA43o4E3InJW/I8p52R+IaeHnQRJlGOk3lhWZWpRFvNMAkflNoAGIks0ksIU9gmO39ZhiWtYXQzw==","ARC-Authentication-Results":"i=1; lists.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=linux.intel.com;\n dkim=pass (2048-bit key;\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=GspGzkgp; dkim-atps=neutral;\n spf=pass (client-ip=198.175.65.16; helo=mgamail.intel.com;\n envelope-from=ilpo.jarvinen@linux.intel.com;\n receiver=lists.ozlabs.org) smtp.mailfrom=linux.intel.com","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1775819488; x=1807355488;\n h=from:date:to:cc:subject:in-reply-to:message-id:\n references:mime-version;\n bh=YmmZv/KghyXwXxLltau1kH9MzqjsToUkSr3yj3hE0LI=;\n b=GspGzkgp+eyMHzu3/TSebFjgdg7QWzpl/1ZE4qsgqn7EtjFCxjYhgiOz\n 5VJ9qV4ZqQWpvsQ08zN4zyEodFDpRu2ZE8hpjPr6P8MWmj57iuB0QSd6R\n fyIR/sDF96kgMPsw+oq3BGlhOWeqpgVI4+7pM27L80MLczL4v7oFrBPKX\n yrH3ijwohzFqrnxL2VgeRfAjhck6XnhnBsjH5MsNDnixieiLQMazG09iQ\n 23qWBMLskkm4zovb+206gOW3SSG5G1h6X1gnGdhNPXTU7JAMKlGLqq3Gz\n jINHnVNcGjc8TYlp2WogkUt7qfmwV3dsPUxQ0o5SrdL4lKNH3nrw4+q2A\n A==;","X-CSE-ConnectionGUID":["1i/QnXFcTc+MPVPN8LmexA==","RGX5iTjcQ+GI+udWcK3Itg=="],"X-CSE-MsgGUID":["s8wokyzqTl+KeWkO3Eo3hg==","pFRvyePbSROC6CAFst+SHA=="],"X-IronPort-AV":["E=McAfee;i=\"6800,10657,11754\"; a=\"77023376\"","E=Sophos;i=\"6.23,171,1770624000\";\n d=\"scan'208\";a=\"77023376\"","E=Sophos;i=\"6.23,171,1770624000\";\n d=\"scan'208\";a=\"224315446\""],"X-ExtLoop1":"1","From":"=?utf-8?q?Ilpo_J=C3=A4rvinen?= ","Date":"Fri, 10 Apr 2026 14:11:11 +0300 (EEST)","To":"=?iso-8859-2?q?Krzysztof_Wilczy=F1ski?= ","cc":"Bjorn Helgaas , Bjorn Helgaas ,\n Manivannan Sadhasivam ,\n Lorenzo Pieralisi ,\n Magnus Lindholm , Matt Turner ,\n Richard Henderson ,\n Christophe Leroy ,\n Madhavan Srinivasan ,\n Michael Ellerman , Nicholas Piggin ,\n Dexuan Cui ,\n =?iso-8859-2?q?Krzysztof_Ha=B3asa?= ,\n Lukas Wunner , Oliver O'Halloran ,\n Saurabh Singh Sengar ,\n Shuan He ,\n Srivatsa Bhat , linux-pci@vger.kernel.org,\n linux-alpha@vger.kernel.org, linuxppc-dev@lists.ozlabs.org","Subject":"Re: [PATCH 12/20] alpha/PCI: Use PCI resource accessor macros","In-Reply-To":"<20260410055040.39233-13-kwilczynski@kernel.org>","Message-ID":"","References":"<20260410055040.39233-1-kwilczynski@kernel.org>\n <20260410055040.39233-13-kwilczynski@kernel.org>","X-Mailing-List":"linuxppc-dev@lists.ozlabs.org","List-Id":"","List-Help":"","List-Owner":"","List-Post":"","List-Archive":",\n ","List-Subscribe":",\n ,\n ","List-Unsubscribe":"","Precedence":"list","MIME-Version":"1.0","Content-Type":"multipart/mixed; boundary=\"8323328-1891398941-1775819471=:1195\"","X-Spam-Status":"No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,\n\tDKIM_VALID,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS autolearn=disabled\n\tversion=4.0.1 OzLabs 8","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org"}},{"id":3675834,"web_url":"http://patchwork.ozlabs.org/comment/3675834/","msgid":"<20260410112709.GB1756033@rocinante>","date":"2026-04-10T11:27:09","subject":"Re: [PATCH 12/20] alpha/PCI: Use PCI resource accessor macros","submitter":{"id":86709,"url":"http://patchwork.ozlabs.org/api/people/86709/","name":"Krzysztof Wilczyński","email":"kwilczynski@kernel.org"},"content":"Hello,\n\n> > -\tif (pdev->resource[num].flags & IORESOURCE_MEM) {\n> > +\tif (pci_resource_flags(pdev, num) & IORESOURCE_MEM) {\n> \n> Reviewed-by: Ilpo Järvinen \n> \n> I started wonder though if we'd want to add pci_resource_is_mem/io() \n> shortcuts for these, as it's largely what\n> \n> git grep pci_resource_flags\n> \n> results contain.\n\nI see what you mean... We can introduce such helpers here, and be the first\nusers within the PCI tree, that is, before someone will do a tree-wide or some\nmore granular update eventually.\n\nShould I do it? Thoughts?\n\nThank you!\n\n\tKrzysztof","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=PysyFQl6;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=112.213.38.117; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev+bounces-19564-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)","lists.ozlabs.org;\n arc=none smtp.remote-ip=\"2600:3c04:e001:324:0:1991:8:25\"","lists.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org","lists.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=PysyFQl6;\n\tdkim-atps=neutral","lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org\n (client-ip=2600:3c04:e001:324:0:1991:8:25; helo=tor.source.kernel.org;\n envelope-from=kwilczynski@kernel.org; receiver=lists.ozlabs.org)"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fsZK55d8gz1yGb\n\tfor ; Fri, 10 Apr 2026 21:27:21 +1000 (AEST)","from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4fsZK431bVz2yft;\n\tFri, 10 Apr 2026 21:27:20 +1000 (AEST)","from tor.source.kernel.org (tor.source.kernel.org\n [IPv6:2600:3c04:e001:324:0:1991:8:25])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4fsZK33lqCz2xT6\n\tfor ; Fri, 10 Apr 2026 21:27:19 +1000 (AEST)","from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58])\n\tby tor.source.kernel.org (Postfix) with ESMTP id 2F07D6024D;\n\tFri, 10 Apr 2026 11:27:12 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 7EB18C19421;\n\tFri, 10 Apr 2026 11:27:11 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1775820440;\n\tcv=none;\n b=YzQ7Wm0cM/5Q9MYsoCdWM1OOSH1LclA/1VO9meBz+EVfhbny5a/z+jJ4PDonkuzPGsiUcVgmtjqgWZbF4L/R8O/UO5b3/XOVNv5hQxAITiIQqB8IKhBTAAQSMfgq1QhhWwy4QSEph4KIkhlK4lk5zCdVdPl7IJ2hwrCgeMfkDjt6JR3fKx6iqfd9cBrrMYlvhUNs9YCOTx+JlRSfd4VZbveZsU6qHd+Ln6020aGCZuYvOcCNz9Tm23xmPHRqDqkEMmh2MxCABbqryiYtkw9RzXAITmS4yP621KsCm92LorguvINBXnEdWG0k2pdflNlOS2JvSL/x38un/B0mQlofbQ==","ARC-Message-Signature":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1775820440; c=relaxed/relaxed;\n\tbh=0ZVKsqv+5qtMdGcJHiFFvWRp4e2aeYFFhOxWJTFHaHU=;\n\th=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:\n\t Content-Type:Content-Disposition:In-Reply-To;\n b=Ro/0TWImkg9mBQYeLiZAYvC5jrGDIeA8f+qFiFrX/00Jflu59xtPyqTwzo3VqsbJiiCgJ2Lyma1YXrrNGoxBP0EBI4A6fOaZWNWhR64tKp8p/ZrPEf4w4uz+NhTO44k9EZot5SQKInuSXAUY39NZY85f+d2HcfF4qPN2iwTquojcCFeHoje/+YWDT7QFgFaaAFy+q2aIauiFCU5YXwA1vLc+1IXu5Y6E1Ir6yjf8zK6M3igykC2xRS5KZy0BaXIJDkH4kc+xbK+Y4Og+NKi0RU6m7yenULTunQ3Ut8uWkLmMM9nQwfrJPDEfJLEHnlHGAsTMnqOlEsPNPrsnJI9dqA==","ARC-Authentication-Results":"i=1; lists.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org;\n dkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=PysyFQl6; dkim-atps=neutral;\n spf=pass (client-ip=2600:3c04:e001:324:0:1991:8:25;\n helo=tor.source.kernel.org; envelope-from=kwilczynski@kernel.org;\n receiver=lists.ozlabs.org) smtp.mailfrom=kernel.org","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1775820431;\n\tbh=1su7Hk+2MPUWstIkBAykmSdSjnEsIRdA/siC5BZw4x0=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=PysyFQl6cHHK121wyAz9FjAkUHXRBYYV0l8JL1w0Gb3CrDtM52JIADeYXSy+RQj90\n\t Rb/QLPZTrzyCHpZpi94xhrHAMOOVLE9rvMBQryCpadewXyqKFsDh/XybTPr4riFcYM\n\t nYY+Q5cJDURPt+QOYNqDRYm85T+qux6XCyHhsFcTZH83F9yfxGVA1e+cNapPmnasqD\n\t qRgemNPh5xlNYZehbYiW4cWaNj43FUqgxa92TiIK5ZRPEklq5HcGupxDe8+zrOHP8G\n\t qHs3LHYYSm66jU2NtITeLSEd9oucxEHQp3zhnAqNqGK/AQ+slZFYKeKB+wrfJ37oBZ\n\t 2uHS+pp7Hhd2w==","Date":"Fri, 10 Apr 2026 20:27:09 +0900","From":"Krzysztof =?utf-8?q?Wilczy=C5=84ski?= ","To":"Ilpo =?utf-8?b?SsOkcnZpbmVu?= ","Cc":"Bjorn Helgaas , Bjorn Helgaas ,\n Manivannan Sadhasivam ,\n Lorenzo Pieralisi ,\n Magnus Lindholm , Matt Turner ,\n Richard Henderson ,\n Christophe Leroy ,\n Madhavan Srinivasan ,\n Michael Ellerman , Nicholas Piggin ,\n Dexuan Cui ,\n Krzysztof =?utf-8?q?Ha=C5=82asa?= ,\n Lukas Wunner , Oliver O'Halloran ,\n Saurabh Singh Sengar ,\n Shuan He , Srivatsa Bhat ,\n linux-pci@vger.kernel.org, linux-alpha@vger.kernel.org,\n linuxppc-dev@lists.ozlabs.org","Subject":"Re: [PATCH 12/20] alpha/PCI: Use PCI resource accessor macros","Message-ID":"<20260410112709.GB1756033@rocinante>","References":"<20260410055040.39233-1-kwilczynski@kernel.org>\n <20260410055040.39233-13-kwilczynski@kernel.org>\n ","X-Mailing-List":"linuxppc-dev@lists.ozlabs.org","List-Id":"","List-Help":"","List-Owner":"","List-Post":"","List-Archive":",\n ","List-Subscribe":",\n ,\n ","List-Unsubscribe":"","Precedence":"list","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"","X-Spam-Status":"No, score=-0.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,\n\tDKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS\n\tautolearn=disabled version=4.0.1 OzLabs 8","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org"}}]