[{"id":3675806,"web_url":"http://patchwork.ozlabs.org/comment/3675806/","msgid":"<93f81aa9-ce74-92bb-5227-d2ccb0a3e06c@linux.intel.com>","date":"2026-04-10T11:04:16","subject":"Re: [PATCH 10/20] alpha/PCI: Add security_locked_down() check to\n pci_mmap_resource()","submitter":{"id":83553,"url":"http://patchwork.ozlabs.org/api/people/83553/","name":"Ilpo Järvinen","email":"ilpo.jarvinen@linux.intel.com"},"content":"On Fri, 10 Apr 2026, Krzysztof Wilczyński wrote:\n\n> Currently, Alpha's pci_mmap_resource() does not check\n> security_locked_down(LOCKDOWN_PCI_ACCESS) before allowing\n> userspace to mmap PCI BARs.\n> \n> The generic version has had this check since commit eb627e17727e\n> (\"PCI: Lock down BAR access when the kernel is locked down\") to\n> prevent DMA attacks when the kernel is locked down.\n> \n> Add the same check to Alpha's pci_mmap_resource().\n> \n> Signed-off-by: Krzysztof Wilczyński \n\nMaybe add Fixes: eb627e17727e ...\n\n> ---\n> arch/alpha/kernel/pci-sysfs.c | 7 ++++++-\n> 1 file changed, 6 insertions(+), 1 deletion(-)\n> \n> diff --git a/arch/alpha/kernel/pci-sysfs.c b/arch/alpha/kernel/pci-sysfs.c\n> index 3048758304b5..2324720c3e83 100644\n> --- a/arch/alpha/kernel/pci-sysfs.c\n> +++ b/arch/alpha/kernel/pci-sysfs.c\n> @@ -11,6 +11,7 @@\n> */\n> \n> #include \n> +#include \n> #include \n> #include \n> #include \n> @@ -71,7 +72,11 @@ static int pci_mmap_resource(struct kobject *kobj,\n> \tstruct resource *res = attr->private;\n> \tenum pci_mmap_state mmap_type;\n> \tstruct pci_bus_region bar;\n> -\tint i;\n> +\tint i, ret;\n> +\n> +\tret = security_locked_down(LOCKDOWN_PCI_ACCESS);\n> +\tif (ret)\n> +\t\treturn ret;\n> \n> \tfor (i = 0; i < PCI_STD_NUM_BARS; i++)\n> \t\tif (res == &pdev->resource[i])\n> \n\nReviewed-by: Ilpo Järvinen ","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=n9xZFUFx;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=2404:9400:21b9:f100::1; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev+bounces-19557-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)","lists.ozlabs.org;\n arc=none smtp.remote-ip=198.175.65.13","lists.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=linux.intel.com","lists.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=n9xZFUFx;\n\tdkim-atps=neutral","lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=linux.intel.com\n (client-ip=198.175.65.13; helo=mgamail.intel.com;\n envelope-from=ilpo.jarvinen@linux.intel.com; receiver=lists.ozlabs.org)"],"Received":["from lists.ozlabs.org (lists.ozlabs.org\n [IPv6:2404:9400:21b9:f100::1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1 raw public key)\n server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fsYpq4Q5vz1yGS\n\tfor ; Fri, 10 Apr 2026 21:04:35 +1000 (AEST)","from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4fsYpp1Q3rz2yft;\n\tFri, 10 Apr 2026 21:04:34 +1000 (AEST)","from mgamail.intel.com (mgamail.intel.com [198.175.65.13])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4fsYpm3rPqz2xT6\n\tfor ; Fri, 10 Apr 2026 21:04:31 +1000 (AEST)","from orviesa006.jf.intel.com ([10.64.159.146])\n by orvoesa105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 10 Apr 2026 04:04:29 -0700","from ijarvine-mobl1.ger.corp.intel.com (HELO localhost)\n ([10.245.244.118])\n by orviesa006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 10 Apr 2026 04:04:19 -0700"],"ARC-Seal":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1775819074;\n\tcv=none;\n b=eCif3ao9GX7sg9P4kmAg7v0MKCGCFMvYFZgNNiaF/QQHRap5Indly0MDbb/miqpabX4BI7bKwy9v366JjaBVyoEOc651YQCsMHP+QHXdfGwrUttwE/kAA8Su4ylR6O6X67kPE9hEDKJDnoA2vgnOhC0WaIg9vBzjivn2MYmBM5m39QtByKw9yIEIUc8gVNRJu3lNu2L6sC8e1lszEUfMCPS7I6QBCG1izu9lc05wceR5s3/CbEl4ZgQWI7yMLSwuyuncMKNQ30zaQsPJy369eLcsYVtknXeOe7I+BsMlW4ak6auFAKbWt25MDwkGmh1D6duBMGDb39Ik+tTumShjGA==","ARC-Message-Signature":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1775819074; c=relaxed/relaxed;\n\tbh=0Ykeq5M8C7fHPxjiFFLiU9Ta+PpIQ8ybI3+n6Kdy408=;\n\th=From:Date:To:cc:Subject:In-Reply-To:Message-ID:References:\n\t MIME-Version:Content-Type;\n b=ZQgyX1Xty4sr1VjhgAKeGzv4eAS+fiy/0xRYMI9+1T57BwFlBSc0iJL6A7rLzS59+2V0RCoT6HXIZEHIzO1neQtL4XmRyOSztyzsYVZgnO3hAeE5GTRm8riJX9pZGjvoc8zkbOu+NHiH5iKzmsZ612a7FR152uhQCrYVKfh2+YFs+3RhgEC0VYyqXgty/Wi+NG0RnzOaVwJbBGIzO/BfqrmQxKkDfxu86y5IZX7xsQ1zPZA+f9Z6GCOLivcmgTG8GOcmDgtE69TbQwgoX8ny3e6EN1nt4RXAf3TH/WnWk0gA/cheeug4/Xyb79H2FiqrwehTffnjwn58iBwpp8vacw==","ARC-Authentication-Results":"i=1; lists.ozlabs.org;\n dmarc=pass (p=none dis=none) header.from=linux.intel.com;\n dkim=pass (2048-bit key;\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=n9xZFUFx; dkim-atps=neutral;\n spf=pass (client-ip=198.175.65.13; helo=mgamail.intel.com;\n envelope-from=ilpo.jarvinen@linux.intel.com;\n receiver=lists.ozlabs.org) smtp.mailfrom=linux.intel.com","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1775819074; x=1807355074;\n h=from:date:to:cc:subject:in-reply-to:message-id:\n references:mime-version;\n bh=ie5mL37AI9/SoDKmjWEXYIZ3Y62rbPGSCw23WIYez+M=;\n b=n9xZFUFxYrYlKZVy5L6YhLA8RVXEjuLGugMBYo3YiEEfyzjJFSFPIdNs\n 0/nwUy/fyVeVprtKn+RNTwj5uHu3E1KQj9T3VCCi7pr9jMfIbsdIUr3pc\n 83JWb9hZLVkdj2iveHID8OZl+/1cDIFI4j8pVtttmRFNT3tIpduci4P7z\n uMp4iO2bAQbrvv/hDdSktK3Q9s6S+HON5kSycxeUYulnzcSZYrMMYw/Xu\n dCcx9sEDn2euLZx9mmYi9nt7Hs1+3/6NDKBtO/Z5VaqNBXNQJlVjDuNK7\n t0m0PoaUhO6zNd+IqwijJqVjilI6Q7Rp1Sugvm8EJ4deTvowcdcXQYFzK\n g==;","X-CSE-ConnectionGUID":["Nfl7FehcQRG5vXoZEUkjVw==","AFN9uzRlTtyiLYJXbIC8Hg=="],"X-CSE-MsgGUID":["qREuCkGzTlWzxeB2JwbVEw==","1Qnc4FGjTdGVlIiX03QVWg=="],"X-IronPort-AV":["E=McAfee;i=\"6800,10657,11754\"; a=\"87913349\"","E=Sophos;i=\"6.23,171,1770624000\";\n d=\"scan'208\";a=\"87913349\"","E=Sophos;i=\"6.23,171,1770624000\";\n d=\"scan'208\";a=\"228059061\""],"X-ExtLoop1":"1","From":"=?utf-8?q?Ilpo_J=C3=A4rvinen?= ","Date":"Fri, 10 Apr 2026 14:04:16 +0300 (EEST)","To":"=?iso-8859-2?q?Krzysztof_Wilczy=F1ski?= ","cc":"Bjorn Helgaas , Bjorn Helgaas ,\n Manivannan Sadhasivam ,\n Lorenzo Pieralisi ,\n Magnus Lindholm , Matt Turner ,\n Richard Henderson ,\n Christophe Leroy ,\n Madhavan Srinivasan ,\n Michael Ellerman , Nicholas Piggin ,\n Dexuan Cui ,\n =?iso-8859-2?q?Krzysztof_Ha=B3asa?= ,\n Lukas Wunner , Oliver O'Halloran ,\n Saurabh Singh Sengar ,\n Shuan He ,\n Srivatsa Bhat , linux-pci@vger.kernel.org,\n linux-alpha@vger.kernel.org, linuxppc-dev@lists.ozlabs.org","Subject":"Re: [PATCH 10/20] alpha/PCI: Add security_locked_down() check to\n pci_mmap_resource()","In-Reply-To":"<20260410055040.39233-11-kwilczynski@kernel.org>","Message-ID":"<93f81aa9-ce74-92bb-5227-d2ccb0a3e06c@linux.intel.com>","References":"<20260410055040.39233-1-kwilczynski@kernel.org>\n <20260410055040.39233-11-kwilczynski@kernel.org>","X-Mailing-List":"linuxppc-dev@lists.ozlabs.org","List-Id":"","List-Help":"","List-Owner":"","List-Post":"","List-Archive":",\n ","List-Subscribe":",\n ,\n ","List-Unsubscribe":"","Precedence":"list","MIME-Version":"1.0","Content-Type":"multipart/mixed; boundary=\"8323328-1107943852-1775819056=:1195\"","X-Spam-Status":"No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,\n\tDKIM_VALID,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS autolearn=disabled\n\tversion=4.0.1 OzLabs 8","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org"}},{"id":3675815,"web_url":"http://patchwork.ozlabs.org/comment/3675815/","msgid":"<20260410111003.GA1750802@rocinante>","date":"2026-04-10T11:10:03","subject":"Re: [PATCH 10/20] alpha/PCI: Add security_locked_down() check to\n pci_mmap_resource()","submitter":{"id":86709,"url":"http://patchwork.ozlabs.org/api/people/86709/","name":"Krzysztof Wilczyński","email":"kwilczynski@kernel.org"},"content":"Hello,\n\n> > Currently, Alpha's pci_mmap_resource() does not check\n> > security_locked_down(LOCKDOWN_PCI_ACCESS) before allowing\n> > userspace to mmap PCI BARs.\n> > \n> > The generic version has had this check since commit eb627e17727e\n> > (\"PCI: Lock down BAR access when the kernel is locked down\") to\n> > prevent DMA attacks when the kernel is locked down.\n> > \n> > Add the same check to Alpha's pci_mmap_resource().\n> > \n> > Signed-off-by: Krzysztof Wilczyński \n> \n> Maybe add Fixes: eb627e17727e ...\n\nGood call, will do!\n\nThank you!\n\n\tKrzysztof","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=HfvGo9op;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=2404:9400:21b9:f100::1; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev+bounces-19558-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)","lists.ozlabs.org;\n arc=none smtp.remote-ip=172.105.4.254","lists.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org","lists.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=HfvGo9op;\n\tdkim-atps=neutral","lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org\n (client-ip=172.105.4.254; helo=tor.source.kernel.org;\n envelope-from=kwilczynski@kernel.org; receiver=lists.ozlabs.org)"],"Received":["from lists.ozlabs.org (lists.ozlabs.org\n [IPv6:2404:9400:21b9:f100::1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fsYxJ12Kzz1yGb\n\tfor ; Fri, 10 Apr 2026 21:10:11 +1000 (AEST)","from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4fsYxG3SwZz2yft;\n\tFri, 10 Apr 2026 21:10:10 +1000 (AEST)","from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4fsYxF1FT2z2xT6\n\tfor ; Fri, 10 Apr 2026 21:10:09 +1000 (AEST)","from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58])\n\tby tor.source.kernel.org (Postfix) with ESMTP id D987460154;\n\tFri, 10 Apr 2026 11:10:05 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 2F97AC19421;\n\tFri, 10 Apr 2026 11:10:05 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1775819410;\n\tcv=none;\n b=onWp+wdmcm2zoRAUp6ukF/hrY70xAVGxGUiHVHLEBYMKkuenQ9ImEJkMSc03OyjQa7Q6cxGnXNyavWoJgUehgHmBxED16OmzoaVHSYU7n2ScOzxceFcRumqTZzGK8Xze0FmLfAe11TGt0/4qFzVYAvkWM9PEq3hLy3ExeuxjmHrgnMLzk4GARH6PbYtUSR0PTy35qivwRQ6yshc1vWe1N383tc3wYJmxhXp+MA6+JxHs9z1KgQz145+fEWdOAtQCiPHPbs+3vwgir+zUBOHhTtyUpH2B99SVoHLX2o7gKGESXG8J4poXV3FVQ8FkW2JIWIm80M0QA16Ui2s2UpLBKA==","ARC-Message-Signature":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1775819410; c=relaxed/relaxed;\n\tbh=yJwq2JLveAbgpcDyiS3SaUa9fNcTfhoxXyNF1+OxAEI=;\n\th=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:\n\t Content-Type:Content-Disposition:In-Reply-To;\n b=aub9VUBUTDB5Gy5n7BbCEu3MSnnt5kyhXwWiY4uDl0GwoWdEWVxA9lMC7iqg1RfKsW9K9z3m78Z4wRRAc0aFLqyGb32SL2bHJS4CmIy2Zkm5WEVX1ymGfwZJD7u8GeXPM6VWmm2vLSg4sxHI2FMov1h0Rt359lfpng4XohD1FNDsb/Ghic39EJSJMqsmxp6p9abLDGUSBvb1HGDVkdzvh6uAVzXaS2XDHO8ydeoliBfDphzqv2PP+wppScdecjsB0iAUrZm0sbOoBkc1eW1+XSRsJeoaup+hTz1VuDznt8dEtU7JGCJFx9H12MY5NGiWgQoasOTOK0fHXsxOtJPFag==","ARC-Authentication-Results":"i=1; lists.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org;\n dkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=HfvGo9op; dkim-atps=neutral;\n spf=pass (client-ip=172.105.4.254; helo=tor.source.kernel.org;\n envelope-from=kwilczynski@kernel.org;\n receiver=lists.ozlabs.org) smtp.mailfrom=kernel.org","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1775819405;\n\tbh=J9CQoX7GTnEen2B2gzOk+uOsLwI3v0SjpCO+RqDM+0I=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=HfvGo9opSrGDxa/afsb88WuMvZhMT79PSWGaCkUCXr+PWuyTIlqzJku/vQIfjwWzL\n\t j2vA53DlizDMUF4zGV35/RZldLiqoGohXZq6jnSNOk01PxuBBZUCXkjRNlagG6ky4a\n\t MXb0vT3zawPDmi/1awFBO/99cerh8h1xZTxJfColV8aXphUT0XSSO0DLJkexxwh2ga\n\t ppeWV2HjA3itU5agbnn2tKpIsJPnDq3FnXy/j0/yEbBbFZes7bKtcmd5SIU0SXLjYM\n\t zOiNgiowSHB/nNlZglFxRlfwkT6zSGpE8Db96Qj+Mhs5V1Kpl2dpMBp08WZXhKF6/3\n\t Bvk2bfIBUQynQ==","Date":"Fri, 10 Apr 2026 20:10:03 +0900","From":"Krzysztof =?utf-8?q?Wilczy=C5=84ski?= ","To":"Ilpo =?utf-8?b?SsOkcnZpbmVu?= ","Cc":"Bjorn Helgaas , Bjorn Helgaas ,\n Manivannan Sadhasivam ,\n Lorenzo Pieralisi ,\n Magnus Lindholm , Matt Turner ,\n Richard Henderson ,\n Christophe Leroy ,\n Madhavan Srinivasan ,\n Michael Ellerman , Nicholas Piggin ,\n Dexuan Cui ,\n Krzysztof =?utf-8?q?Ha=C5=82asa?= ,\n Lukas Wunner , Oliver O'Halloran ,\n Saurabh Singh Sengar ,\n Shuan He , Srivatsa Bhat ,\n linux-pci@vger.kernel.org, linux-alpha@vger.kernel.org,\n linuxppc-dev@lists.ozlabs.org","Subject":"Re: [PATCH 10/20] alpha/PCI: Add security_locked_down() check to\n pci_mmap_resource()","Message-ID":"<20260410111003.GA1750802@rocinante>","References":"<20260410055040.39233-1-kwilczynski@kernel.org>\n <20260410055040.39233-11-kwilczynski@kernel.org>\n <93f81aa9-ce74-92bb-5227-d2ccb0a3e06c@linux.intel.com>","X-Mailing-List":"linuxppc-dev@lists.ozlabs.org","List-Id":"","List-Help":"","List-Owner":"","List-Post":"","List-Archive":",\n ","List-Subscribe":",\n ,\n ","List-Unsubscribe":"","Precedence":"list","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<93f81aa9-ce74-92bb-5227-d2ccb0a3e06c@linux.intel.com>","X-Spam-Status":"No, score=-0.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,\n\tDKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS\n\tautolearn=disabled version=4.0.1 OzLabs 8","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org"}}]