[{"id":3675825,"web_url":"http://patchwork.ozlabs.org/comment/3675825/","msgid":"","list_archive_url":null,"date":"2026-04-10T11:11:11","subject":"Re: [PATCH 12/20] alpha/PCI: Use PCI resource accessor macros","submitter":{"id":83553,"url":"http://patchwork.ozlabs.org/api/people/83553/","name":"Ilpo Järvinen","email":"ilpo.jarvinen@linux.intel.com"},"content":"On Fri, 10 Apr 2026, Krzysztof Wilczyński wrote:\n\n> Replace direct pdev->resource[] accesses with pci_resource_n(),\n> and pdev->resource[].flags accesses with pci_resource_flags().\n> \n> No functional changes intended.\n> \n> Signed-off-by: Krzysztof Wilczyński \n> ---\n> arch/alpha/kernel/pci-sysfs.c | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/arch/alpha/kernel/pci-sysfs.c b/arch/alpha/kernel/pci-sysfs.c\n> index c84867ce31f5..7aac5e76dcd6 100644\n> --- a/arch/alpha/kernel/pci-sysfs.c\n> +++ b/arch/alpha/kernel/pci-sysfs.c\n> @@ -141,7 +141,7 @@ static int sparse_mem_mmap_fits(struct pci_dev *pdev, int num)\n> \tlong dense_offset;\n> \tunsigned long sparse_size;\n> \n> -\tpcibios_resource_to_bus(pdev->bus, &bar, &pdev->resource[num]);\n> +\tpcibios_resource_to_bus(pdev->bus, &bar, pci_resource_n(pdev, num));\n> \n> \t/* All core logic chips have 4G sparse address space, except\n> \t CIA which has 16G (see xxx_SPARSE_MEM and xxx_DENSE_MEM\n> @@ -181,7 +181,7 @@ static int pci_create_attr(struct pci_dev *pdev, int num)\n> \tsuffix = \"\";\t/* Assume bwx machine, normal resourceN files. */\n> \tnlen1 = 10;\n> \n> -\tif (pdev->resource[num].flags & IORESOURCE_MEM) {\n> +\tif (pci_resource_flags(pdev, num) & IORESOURCE_MEM) {\n\nReviewed-by: Ilpo Järvinen \n\nI started wonder though if we'd want to add pci_resource_is_mem/io() \nshortcuts for these, as it's largely what\n\n git grep pci_resource_flags\n\nresults contain.","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-pci@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=IWum9QaQ;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=linux-pci+bounces-52297-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com\n header.b=\"IWum9QaQ\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=198.175.65.16","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=linux.intel.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=linux.intel.com"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fsZ4M6Glwz1yGS\n\tfor ; Fri, 10 Apr 2026 21:16:19 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id 172D0305BAB7\n\tfor ; Fri, 10 Apr 2026 11:11:35 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 1482D3B7B7A;\n\tFri, 10 Apr 2026 11:11:27 +0000 (UTC)","from mgamail.intel.com (mgamail.intel.com [198.175.65.16])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id BECF43B8BBB;\n\tFri, 10 Apr 2026 11:11:22 +0000 (UTC)","from fmviesa006.fm.intel.com ([10.60.135.146])\n by orvoesa108.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 10 Apr 2026 04:11:22 -0700","from ijarvine-mobl1.ger.corp.intel.com (HELO localhost)\n ([10.245.244.118])\n by fmviesa006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 10 Apr 2026 04:11:14 -0700"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1775819486; cv=none;\n b=H+EQ1mZd3QrZS6bIzC0M6D0uPCxJAju3/M3wOscO6mR9u1EuMffM7ErwEsPhFBuxHBDyPigi4Fjd/CV1yU7c2q9fb9t8RhXNJqNHD2z0GwoSy/zMLMZpboq4MDzLUyO2qPG79CnNuhMv1nOtU0r4cxsH50DxasZ06XhSke8ElhQ=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1775819486; c=relaxed/simple;\n\tbh=YmmZv/KghyXwXxLltau1kH9MzqjsToUkSr3yj3hE0LI=;\n\th=From:Date:To:cc:Subject:In-Reply-To:Message-ID:References:\n\t MIME-Version:Content-Type;\n b=FBuPnqed/PcN8GGv5NxrnCutVJsEJQ+HSAkXeL6OFz2jn2lp5Egmpgvc+KP+zwtXD0vnqLSqRXZ2jIdvKQgzknjIYW3ykWA8zHlBQ8ysqB/20tGfj4n6p2isIUaTtzg5TtJYAUJVNwy4Aqv5KwZhNDYkbKXP451X7saTqSGKVFI=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=linux.intel.com;\n spf=pass smtp.mailfrom=linux.intel.com;\n dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com\n header.b=IWum9QaQ; arc=none smtp.client-ip=198.175.65.16","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1775819483; x=1807355483;\n h=from:date:to:cc:subject:in-reply-to:message-id:\n references:mime-version;\n bh=YmmZv/KghyXwXxLltau1kH9MzqjsToUkSr3yj3hE0LI=;\n b=IWum9QaQC7UCkpSF9t67RLp5vRnFxX0OjKNy+KHeWKvZwONzXkrPU7zl\n cGghgi99RwOm+A08lfPf/cpFhM1M5xYbon/MMH+8TvayfBNIFNkfFXZ9+\n D8RlLfNPmJSeBM49tbsAn3+3CkhJUjewHH5W+9JgcxlPcIRy+aN4QDBbj\n /yULyEIRofEoRqqNMKTmRUIs8Nh/KM29xvKFktZ45p0PlHBrq2zl1d2Cn\n mYmheq7OZpZ4bA8GPEyL1QCpIjEQwGdMZT4QrxyGL7LZDKBlGoxRYozrc\n aNIwm5KgMooTZrq+Kd9tz7FgVo1Qd4M4pSz8PHfzvZ52iT0OYBgBFbEwc\n A==;","X-CSE-ConnectionGUID":["7g7AhKi6QUamrL1SL2zlXg==","RGX5iTjcQ+GI+udWcK3Itg=="],"X-CSE-MsgGUID":["XRKeZeePQoyby1NYEvnDLQ==","pFRvyePbSROC6CAFst+SHA=="],"X-IronPort-AV":["E=McAfee;i=\"6800,10657,11754\"; a=\"77023377\"","E=Sophos;i=\"6.23,171,1770624000\";\n d=\"scan'208\";a=\"77023377\"","E=Sophos;i=\"6.23,171,1770624000\";\n d=\"scan'208\";a=\"224315446\""],"X-ExtLoop1":"1","From":"=?utf-8?q?Ilpo_J=C3=A4rvinen?= ","Date":"Fri, 10 Apr 2026 14:11:11 +0300 (EEST)","To":"=?iso-8859-2?q?Krzysztof_Wilczy=F1ski?= ","cc":"Bjorn Helgaas , Bjorn Helgaas ,\n Manivannan Sadhasivam ,\n Lorenzo Pieralisi ,\n Magnus Lindholm , Matt Turner ,\n Richard Henderson ,\n Christophe Leroy ,\n Madhavan Srinivasan ,\n Michael Ellerman , Nicholas Piggin ,\n Dexuan Cui ,\n =?iso-8859-2?q?Krzysztof_Ha=B3asa?= ,\n Lukas Wunner , Oliver O'Halloran ,\n Saurabh Singh Sengar ,\n Shuan He ,\n Srivatsa Bhat , linux-pci@vger.kernel.org,\n linux-alpha@vger.kernel.org, linuxppc-dev@lists.ozlabs.org","Subject":"Re: [PATCH 12/20] alpha/PCI: Use PCI resource accessor macros","In-Reply-To":"<20260410055040.39233-13-kwilczynski@kernel.org>","Message-ID":"","References":"<20260410055040.39233-1-kwilczynski@kernel.org>\n <20260410055040.39233-13-kwilczynski@kernel.org>","Precedence":"bulk","X-Mailing-List":"linux-pci@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Type":"multipart/mixed; boundary=\"8323328-1891398941-1775819471=:1195\""}},{"id":3675835,"web_url":"http://patchwork.ozlabs.org/comment/3675835/","msgid":"<20260410112709.GB1756033@rocinante>","list_archive_url":null,"date":"2026-04-10T11:27:09","subject":"Re: [PATCH 12/20] alpha/PCI: Use PCI resource accessor macros","submitter":{"id":86709,"url":"http://patchwork.ozlabs.org/api/people/86709/","name":"Krzysztof Wilczyński","email":"kwilczynski@kernel.org"},"content":"Hello,\n\n> > -\tif (pdev->resource[num].flags & IORESOURCE_MEM) {\n> > +\tif (pci_resource_flags(pdev, num) & IORESOURCE_MEM) {\n> \n> Reviewed-by: Ilpo Järvinen \n> \n> I started wonder though if we'd want to add pci_resource_is_mem/io() \n> shortcuts for these, as it's largely what\n> \n> git grep pci_resource_flags\n> \n> results contain.\n\nI see what you mean... We can introduce such helpers here, and be the first\nusers within the PCI tree, that is, before someone will do a tree-wide or some\nmore granular update eventually.\n\nShould I do it? Thoughts?\n\nThank you!\n\n\tKrzysztof","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-pci@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=PysyFQl6;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c04:e001:36c::12fc:5321; helo=tor.lore.kernel.org;\n envelope-from=linux-pci+bounces-52302-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"PysyFQl6\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201"],"Received":["from tor.lore.kernel.org (tor.lore.kernel.org\n [IPv6:2600:3c04:e001:36c::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fsZK62H2Hz20HT\n\tfor ; Fri, 10 Apr 2026 21:27:22 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id 66FC03017BCB\n\tfor ; Fri, 10 Apr 2026 11:27:15 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 98F2F39F192;\n\tFri, 10 Apr 2026 11:27:12 +0000 (UTC)","from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 6E7E139E177;\n\tFri, 10 Apr 2026 11:27:12 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 7EB18C19421;\n\tFri, 10 Apr 2026 11:27:11 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1775820432; cv=none;\n b=H54DSQ23TypqFKsh4UI3F0rznrdIjhxd9JOD551qLRGx/0mvk3cycUfhMTOpIsxD0/rHAKTDQwROGhqD17UuME/Bg2+ehIm/ZJmRHKK253nR6lvutIKJLpRtd60DbfCmZFqKKHcxjzW0EeNnfgZuCDVckocsRHxlGv+j0INXeIs=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1775820432; c=relaxed/simple;\n\tbh=1su7Hk+2MPUWstIkBAykmSdSjnEsIRdA/siC5BZw4x0=;\n\th=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:\n\t Content-Type:Content-Disposition:In-Reply-To;\n b=b3E0yMTgtOKUUzdZCCfKUkpFozU0Ki+JkcWIke+PWV8ZAkmEb87xRz+9a4QQZernv3mzo2DUwdyWOscUCFeSoEax6sdMAxaJ7NOZkvXoYndvPRnc099g6TQAepIhF4CE4eEegUM6Rk9Vg+xK6GZLTzraFV3FnbF564+4vjzKfUQ=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=PysyFQl6; arc=none smtp.client-ip=10.30.226.201","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1775820431;\n\tbh=1su7Hk+2MPUWstIkBAykmSdSjnEsIRdA/siC5BZw4x0=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=PysyFQl6cHHK121wyAz9FjAkUHXRBYYV0l8JL1w0Gb3CrDtM52JIADeYXSy+RQj90\n\t Rb/QLPZTrzyCHpZpi94xhrHAMOOVLE9rvMBQryCpadewXyqKFsDh/XybTPr4riFcYM\n\t nYY+Q5cJDURPt+QOYNqDRYm85T+qux6XCyHhsFcTZH83F9yfxGVA1e+cNapPmnasqD\n\t qRgemNPh5xlNYZehbYiW4cWaNj43FUqgxa92TiIK5ZRPEklq5HcGupxDe8+zrOHP8G\n\t qHs3LHYYSm66jU2NtITeLSEd9oucxEHQp3zhnAqNqGK/AQ+slZFYKeKB+wrfJ37oBZ\n\t 2uHS+pp7Hhd2w==","Date":"Fri, 10 Apr 2026 20:27:09 +0900","From":"Krzysztof =?utf-8?q?Wilczy=C5=84ski?= ","To":"Ilpo =?utf-8?b?SsOkcnZpbmVu?= ","Cc":"Bjorn Helgaas , Bjorn Helgaas ,\n Manivannan Sadhasivam ,\n Lorenzo Pieralisi ,\n Magnus Lindholm , Matt Turner ,\n Richard Henderson ,\n Christophe Leroy ,\n Madhavan Srinivasan ,\n Michael Ellerman , Nicholas Piggin ,\n Dexuan Cui ,\n Krzysztof =?utf-8?q?Ha=C5=82asa?= ,\n Lukas Wunner , Oliver O'Halloran ,\n Saurabh Singh Sengar ,\n Shuan He , Srivatsa Bhat ,\n linux-pci@vger.kernel.org, linux-alpha@vger.kernel.org,\n linuxppc-dev@lists.ozlabs.org","Subject":"Re: [PATCH 12/20] alpha/PCI: Use PCI resource accessor macros","Message-ID":"<20260410112709.GB1756033@rocinante>","References":"<20260410055040.39233-1-kwilczynski@kernel.org>\n <20260410055040.39233-13-kwilczynski@kernel.org>\n ","Precedence":"bulk","X-Mailing-List":"linux-pci@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":""}}]