[{"id":3675788,"web_url":"http://patchwork.ozlabs.org/comment/3675788/","msgid":"","list_archive_url":null,"date":"2026-04-10T10:20:44","subject":"Re: [PATCH 01/20] PCI/sysfs: Use PCI resource accessor macros","submitter":{"id":83553,"url":"http://patchwork.ozlabs.org/api/people/83553/","name":"Ilpo Järvinen","email":"ilpo.jarvinen@linux.intel.com"},"content":"On Fri, 10 Apr 2026, Krzysztof Wilczyński wrote:\n\n> Replace direct pdev->resource[] accesses with pci_resource_n(),\n> and pdev->resource[].flags accesses with pci_resource_flags().\n> \n> No functional changes intended.\n> \n> Signed-off-by: Krzysztof Wilczyński \n> ---\n> drivers/pci/pci-sysfs.c | 8 ++++----\n> 1 file changed, 4 insertions(+), 4 deletions(-)\n> \n> diff --git a/drivers/pci/pci-sysfs.c b/drivers/pci/pci-sysfs.c\n> index 16eaaf749ba9..ad3c17f86c7f 100644\n> --- a/drivers/pci/pci-sysfs.c\n> +++ b/drivers/pci/pci-sysfs.c\n> @@ -177,7 +177,7 @@ static ssize_t resource_show(struct device *dev, struct device_attribute *attr,\n> \t\tmax = PCI_BRIDGE_RESOURCES;\n> \n> \tfor (i = 0; i < max; i++) {\n> -\t\tstruct resource *res = &pci_dev->resource[i];\n> +\t\tstruct resource *res = pci_resource_n(pci_dev, i);\n> \t\tstruct resource zerores = {};\n> \n> \t\t/* For backwards compatibility */\n> @@ -715,7 +715,7 @@ static ssize_t boot_vga_show(struct device *dev, struct device_attribute *attr,\n> \t\treturn sysfs_emit(buf, \"%u\\n\", (pdev == vga_dev));\n> \n> \treturn sysfs_emit(buf, \"%u\\n\",\n> -\t\t\t !!(pdev->resource[PCI_ROM_RESOURCE].flags &\n> +\t\t\t !!(pci_resource_flags(pdev, PCI_ROM_RESOURCE) &\n> \t\t\t IORESOURCE_ROM_SHADOW));\n> }\n> static DEVICE_ATTR_RO(boot_vga);\n> @@ -1108,7 +1108,7 @@ static int pci_mmap_resource(struct kobject *kobj, const struct bin_attribute *a\n> \tstruct pci_dev *pdev = to_pci_dev(kobj_to_dev(kobj));\n> \tint bar = (unsigned long)attr->private;\n> \tenum pci_mmap_state mmap_type;\n> -\tstruct resource *res = &pdev->resource[bar];\n> +\tstruct resource *res = pci_resource_n(pdev, bar);\n> \tint ret;\n> \n> \tret = security_locked_down(LOCKDOWN_PCI_ACCESS);\n> @@ -1312,7 +1312,7 @@ static int pci_create_resource_files(struct pci_dev *pdev)\n> \t\tretval = pci_create_attr(pdev, i, 0);\n> \t\t/* for prefetchable resources, create a WC mappable file */\n> \t\tif (!retval && arch_can_pci_mmap_wc() &&\n> -\t\t pdev->resource[i].flags & IORESOURCE_PREFETCH)\n> +\t\t pci_resource_flags(pdev, i) & IORESOURCE_PREFETCH)\n> \t\t\tretval = pci_create_attr(pdev, i, 1);\n> \t\tif (retval) {\n> \t\t\tpci_remove_resource_files(pdev);\n> \n\nReviewed-by: Ilpo Järvinen ","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-pci@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=eBlTK0Tj;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c0a:e001:db::12fc:5321; helo=sea.lore.kernel.org;\n envelope-from=linux-pci+bounces-52293-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com\n header.b=\"eBlTK0Tj\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=192.198.163.12","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=linux.intel.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=linux.intel.com"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org\n [IPv6:2600:3c0a:e001:db::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fsY110rPwz1y2d\n\tfor ; Fri, 10 Apr 2026 20:28:21 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id 2BE21305541E\n\tfor ; Fri, 10 Apr 2026 10:21:00 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 8814735BDDB;\n\tFri, 10 Apr 2026 10:20:59 +0000 (UTC)","from mgamail.intel.com (mgamail.intel.com [192.198.163.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 423592FE05C;\n\tFri, 10 Apr 2026 10:20:58 +0000 (UTC)","from fmviesa003.fm.intel.com ([10.60.135.143])\n by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 10 Apr 2026 03:20:57 -0700","from ijarvine-mobl1.ger.corp.intel.com (HELO localhost)\n ([10.245.244.118])\n by fmviesa003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 10 Apr 2026 03:20:49 -0700"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1775816459; cv=none;\n b=sf7cektQWjlSiKzpVyBX+kG8yPE13//rpthfde894QJDScfv8jevHdfriGm1LLQ1LTYKiuG5A9rIDPmrMsIvW9XImKZ+7h0URNNSztoqE/sNnr6q5x8jHDB598EazavShG0XpcJWTHi46dYJiqd2sjcDERuX1Xc/Yw3ZpBSqsCo=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1775816459; c=relaxed/simple;\n\tbh=N7SkzmsbvwjvxbIwFnYfZTQzj2yOdMq5pJu+/jX/36o=;\n\th=From:Date:To:cc:Subject:In-Reply-To:Message-ID:References:\n\t MIME-Version:Content-Type;\n b=QaF5Py3auk7kTIvx3WMV1BvedQexej320+K1cUw1EJj6IaIBt8w/ae7N+8GaTjMNQhAHAjjo0UrEumOTDbz6VZJolzbqNDkuZBLy6UDSQqTY3GDSUMwXPoAjwtxuBLFM1wfa007FJ4X3qnH9AmvgYBL49IjufP+3mbCIvmJP7JU=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=linux.intel.com;\n spf=pass smtp.mailfrom=linux.intel.com;\n dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com\n header.b=eBlTK0Tj; arc=none smtp.client-ip=192.198.163.12","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1775816458; x=1807352458;\n h=from:date:to:cc:subject:in-reply-to:message-id:\n references:mime-version;\n bh=N7SkzmsbvwjvxbIwFnYfZTQzj2yOdMq5pJu+/jX/36o=;\n b=eBlTK0TjBvhtsZwd+EWIuHSRl4BjfvLUaVeWksOZi4mdEt+tyBUErBfc\n 1ocEZYZo59VtCddcXW5qFslp35ybt36D2iV2bI10jbFo/f+F6juZXsYMF\n tARzdRnM9lcJJrKNCb7yrHCfbZtntYlZTeA9Y1/HRBi9VeqJrCt2396to\n t4L+A0nVsN+txXg6QKAMdPB488+6OgknH/cEL6NuxOlv6ntw1sHFsThVG\n Vt+uLnp+HLWTV3epPGddpqZXpHCo16Cpq+r0KE+GkaEyUcYYpddwl+NS4\n eai79aA1iA4SuZmv4otyVDUUqfxWa5eKXH6Ex/HYz91Zp2COHvUgaEPOs\n w==;","X-CSE-ConnectionGUID":["EyNBjPbGQaCBgSheif1RHA==","b1xv5qhxQKewR1yTv/q0Pw=="],"X-CSE-MsgGUID":["L+nU4D0HTLOYd/5M4tKLhg==","CBvJAwIOR3+IrzUnbUoSAg=="],"X-IronPort-AV":["E=McAfee;i=\"6800,10657,11754\"; a=\"80723447\"","E=Sophos;i=\"6.23,171,1770624000\";\n d=\"scan'208\";a=\"80723447\""],"X-ExtLoop1":"1","From":"=?utf-8?q?Ilpo_J=C3=A4rvinen?= ","Date":"Fri, 10 Apr 2026 13:20:44 +0300 (EEST)","To":"=?iso-8859-2?q?Krzysztof_Wilczy=F1ski?= ","cc":"Bjorn Helgaas , Bjorn Helgaas ,\n Manivannan Sadhasivam ,\n Lorenzo Pieralisi ,\n Magnus Lindholm , Matt Turner ,\n Richard Henderson ,\n Christophe Leroy ,\n Madhavan Srinivasan ,\n Michael Ellerman , Nicholas Piggin ,\n Dexuan Cui ,\n =?iso-8859-2?q?Krzysztof_Ha=B3asa?= ,\n Lukas Wunner , Oliver O'Halloran ,\n Saurabh Singh Sengar ,\n Shuan He ,\n Srivatsa Bhat , linux-pci@vger.kernel.org,\n linux-alpha@vger.kernel.org, linuxppc-dev@lists.ozlabs.org","Subject":"Re: [PATCH 01/20] PCI/sysfs: Use PCI resource accessor macros","In-Reply-To":"<20260410055040.39233-2-kwilczynski@kernel.org>","Message-ID":"","References":"<20260410055040.39233-1-kwilczynski@kernel.org>\n <20260410055040.39233-2-kwilczynski@kernel.org>","Precedence":"bulk","X-Mailing-List":"linux-pci@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Type":"multipart/mixed; boundary=\"8323328-511166342-1775816444=:1195\""}}]