[{"id":3677720,"web_url":"http://patchwork.ozlabs.org/comment/3677720/","msgid":"","list_archive_url":null,"date":"2026-04-15T15:02:28","subject":"Re: [PATCH] arm: mediatek: enable fw loader support","submitter":{"id":87228,"url":"http://patchwork.ozlabs.org/api/people/87228/","name":"David Lechner","email":"dlechner@baylibre.com"},"content":"On 4/9/26 8:53 PM, Weijie Gao wrote:\n> Enable SUPPORTS_FW_LOADER to allow the mediatek platform to use ethernet PHY\n> drivers with fw loading.\n> \n> Signed-off-by: Weijie Gao \n> ---\n> arch/arm/Kconfig | 1 +\n> 1 file changed, 1 insertion(+)\n> \n> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig\n> index 03416c55265..aee8e74dace 100644\n> --- a/arch/arm/Kconfig\n> +++ b/arch/arm/Kconfig\n> @@ -868,6 +868,7 @@ config ARCH_MEDIATEK\n> \tselect SPL_LIBGENERIC_SUPPORT if SPL\n> \tselect SPL_OF_CONTROL if SPL\n> \tselect SUPPORT_SPL\n> +\tselect SUPPORTS_FW_LOADER\n\nI don't think this is how this config option is meant to be used.\n\nBased on [1], it sounds like we just need to make sure CMDLINE and\nENV_SUPPORT are enabled in any config that also enables PHY_MEDIATEK_2P5GE.\n\nI don't see any defconfig that enables PHY_MEDIATEK_2P5GE though, so\nI'm not sure there is anything to do here. Unless it makes sense to\nenable this in one of the existing defconfigs or add a new defconfig?\n\n[1]: https://lore.kernel.org/u-boot/20260310162610.1163833-1-trini@konsulko.com/\n\n> \thelp\n> \t Support for the MediaTek SoCs family developed by MediaTek Inc.\n> \t Please refer to doc/README.mediatek for more information.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=baylibre-com.20251104.gappssmtp.com\n header.i=@baylibre-com.20251104.gappssmtp.com header.a=rsa-sha256\n header.s=20251104 header.b=LylJ+HJ9;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=none (p=none dis=none) header.from=baylibre.com","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=baylibre-com.20251104.gappssmtp.com\n header.i=@baylibre-com.20251104.gappssmtp.com header.b=\"LylJ+HJ9\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=none (p=none dis=none) header.from=baylibre.com","phobos.denx.de;\n spf=pass smtp.mailfrom=dlechner@baylibre.com"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fwksG6WwKz1yHM\n\tfor ; Thu, 16 Apr 2026 01:02:42 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id BA74E83B99;\n\tWed, 15 Apr 2026 17:02:34 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id 3185583C2B; Wed, 15 Apr 2026 17:02:34 +0200 (CEST)","from mail-oa1-x2b.google.com (mail-oa1-x2b.google.com\n [IPv6:2001:4860:4864:20::2b])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 741A983936\n for ; Wed, 15 Apr 2026 17:02:31 +0200 (CEST)","by mail-oa1-x2b.google.com with SMTP id\n 586e51a60fabf-40ef10ec84cso4937857fac.2\n for ; Wed, 15 Apr 2026 08:02:31 -0700 (PDT)","from ?IPV6:2600:8803:e7e4:500:5ab6:1e6d:2337:887c?\n ([2600:8803:e7e4:500:5ab6:1e6d:2337:887c])\n by smtp.gmail.com with ESMTPSA id\n 586e51a60fabf-4264469bafbsm1660312fac.0.2026.04.15.08.02.28\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Wed, 15 Apr 2026 08:02:29 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=baylibre-com.20251104.gappssmtp.com; s=20251104; t=1776265350;\n x=1776870150;\n darn=lists.denx.de;\n h=content-transfer-encoding:in-reply-to:from:content-language\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :from:to:cc:subject:date:message-id:reply-to;\n bh=/53wSaihosguF9AAfotOTHKNy4GtHUoS70Dx5HEDlWU=;\n b=LylJ+HJ9oZL1K77hdgukpbi4XVbB3Z1DL9j/Q65qf594X+wA0AnuNmlHz490ZiIysv\n u1CwHuUgaQosGMG9IznFA8zIQRg+vh1m0L8oXjIBfkEGHy91uNTEw3rkCPUH/zyYlkY0\n 3EIMbxPrNmrj65yZ5Y1G5HI3TEKce3KNZieazkaG2ROmHPCM0JagVCVc7TKeUmsaQPZt\n 4CkFnfv1MJZMwxofIWPqsaHfDFs2jDSaSH84gMDXLiXm2bGz22j092c6hWB8LQlQcS3P\n 9MOWlY+KX/lsMDYPhqF2HrFrNDDcmHcnJUK+Y+jqQjgBrV/bMYHbi38TYdjXKdF6erun\n 5Saw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776265350; x=1776870150;\n h=content-transfer-encoding:in-reply-to:from:content-language\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=/53wSaihosguF9AAfotOTHKNy4GtHUoS70Dx5HEDlWU=;\n b=PQJEs//zXAqVLS3ViVpPh/ysiq8s9Z4keprlPiNwoMcXs7iGnNLITE4jPPf/liXiLu\n L5xld7UcFJIjyQ8fmLUqyUoJdv2RMVE10nJt7fZb2qSyK8HTUDEuPGJV/q70dveznHGc\n usQsf7cOXOwl80aDUh5JrQ99A1Law6rty4PD5nYTe2jztd2yhj6b61m/w4EwktO4TjAX\n 0Xg1eMxUfa6kLa6mKAnvIHgs6zl7xTfDPXyMPbXDOaNvsXT7B8R10W6TtmSgc7zhKkuw\n ctTYtXZQ3oB0DzwHPr7Hemt6+LSaVlkDfNYn3ft9/S7H73hWlGhqjQD8EmltN/R5neM6\n yZXA==","X-Forwarded-Encrypted":"i=1;\n AFNElJ90TXrIKryKtKCpbmH50KPj/oZ+v5jQtDqkLfu0lDsT1G3ayDMVSNz6y3UbLliu6uGWlOqsN4M=@lists.denx.de","X-Gm-Message-State":"AOJu0YxNOEzmX7sOFmMLn4ILuOBE+IbGYglctVy3O4APu+BPKFkr2vDQ\n qojOuD8n40dm1Gssb7ig/70NNMPRJGQF5SEWCFyNag++YLo70dk99OK+4+gDcA7xKrMzbQkmMtO\n InXZE","X-Gm-Gg":"AeBDietFgrWpBhl9WmOGEk8RhJQvVxS+JC6AyNptUBArSa6GIBDYNN+C9UArRx+b7jc\n VTP9iv1B7Y4BTHp9Ck4TS7UVVKGOUyjxjaOF7i2f8rTfJG4k4RmGPaUDCUQRhbsTtDZfZ4YyOuE\n 8yTJL/0wvynORS5DaX+8onOr0f8lQlMEpn1CldiiCHtw+TH9fy+rNQovrgCbI6Lu7oha6hUSIBv\n hBLAbT59yL8G4SDnBr1Pa/5p8lOaPVy3vqDwPJtUevuUCORfoqh/GCFkbw045avaThHKyWlFWzv\n +xTDXoo2KN5WsBuOkT4Oau3fLrnv8ID23sYPwYKArcTwo3gwBZmzdOJfDkIadR+fFZJ5HY+Iz/3\n JRfZs2HyTWXyh8pA2jGdwem4cjW/38OjQe+uCmvZk5PKsA+6+27EIh1/sBW3XljGkF09Cp/ah0t\n rqTOmlH0MxGxeyIZ3nOjp90PkaqopuRBP8r+f3qHfGt65zmzybf28iiHEhL21MDwReAPfF8NbNb\n wdEtw628kwL","X-Received":"by 2002:a05:6870:7d89:b0:40a:4467:d5 with SMTP id\n 586e51a60fabf-423e0eacef0mr13036043fac.14.1776265349946;\n Wed, 15 Apr 2026 08:02:29 -0700 (PDT)","Message-ID":"","Date":"Wed, 15 Apr 2026 10:02:28 -0500","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH] arm: mediatek: enable fw loader support","To":"Weijie Gao , u-boot@lists.denx.de","Cc":"GSS_MTK_Uboot_upstream ,\n Tom Rini ","References":"<20260410015311.4066075-1-weijie.gao@mediatek.com>","Content-Language":"en-US","From":"David Lechner ","In-Reply-To":"<20260410015311.4066075-1-weijie.gao@mediatek.com>","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"7bit","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}},{"id":3677801,"web_url":"http://patchwork.ozlabs.org/comment/3677801/","msgid":"<0d7ba570-335e-4de7-b272-7152b540def2@baylibre.com>","list_archive_url":null,"date":"2026-04-15T19:27:39","subject":"Re: [PATCH] arm: mediatek: enable fw loader support","submitter":{"id":87228,"url":"http://patchwork.ozlabs.org/api/people/87228/","name":"David Lechner","email":"dlechner@baylibre.com"},"content":"On 4/15/26 10:02 AM, David Lechner wrote:\n> On 4/9/26 8:53 PM, Weijie Gao wrote:\n>> Enable SUPPORTS_FW_LOADER to allow the mediatek platform to use ethernet PHY\n>> drivers with fw loading.\n>>\n>> Signed-off-by: Weijie Gao \n>> ---\n>> arch/arm/Kconfig | 1 +\n>> 1 file changed, 1 insertion(+)\n>>\n>> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig\n>> index 03416c55265..aee8e74dace 100644\n>> --- a/arch/arm/Kconfig\n>> +++ b/arch/arm/Kconfig\n>> @@ -868,6 +868,7 @@ config ARCH_MEDIATEK\n>> \tselect SPL_LIBGENERIC_SUPPORT if SPL\n>> \tselect SPL_OF_CONTROL if SPL\n>> \tselect SUPPORT_SPL\n>> +\tselect SUPPORTS_FW_LOADER\n> \n> I don't think this is how this config option is meant to be used.\n> \n> Based on [1], it sounds like we just need to make sure CMDLINE and\n> ENV_SUPPORT are enabled in any config that also enables PHY_MEDIATEK_2P5GE.\n> \n> I don't see any defconfig that enables PHY_MEDIATEK_2P5GE though, so\n> I'm not sure there is anything to do here. Unless it makes sense to\n> enable this in one of the existing defconfigs or add a new defconfig?\n> \n> [1]: https://lore.kernel.org/u-boot/20260310162610.1163833-1-trini@konsulko.com/\n> \n>> \thelp\n>> \t Support for the MediaTek SoCs family developed by MediaTek Inc.\n>> \t Please refer to doc/README.mediatek for more information.\n> \n\nI thought about this some more and I wonder if we need to do something\nlike this to make it actually work correctly though...\n\n---\ndiff --git a/lib/Kconfig b/lib/Kconfig\nindex 4e6a0c6a1b6..ed37daa28b8 100644\n--- a/lib/Kconfig\n+++ b/lib/Kconfig\n@@ -73,6 +73,7 @@ config DYNAMIC_CRC_TABLE\n \n config SUPPORTS_FW_LOADER\n \tbool\n+\tdefault y\n \tdepends on CMDLINE\n \tdepends on ENV_SUPPORT","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=baylibre-com.20251104.gappssmtp.com\n header.i=@baylibre-com.20251104.gappssmtp.com header.a=rsa-sha256\n header.s=20251104 header.b=qL07nYpJ;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=none (p=none dis=none) header.from=baylibre.com","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=baylibre-com.20251104.gappssmtp.com\n header.i=@baylibre-com.20251104.gappssmtp.com header.b=\"qL07nYpJ\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=none (p=none dis=none) header.from=baylibre.com","phobos.denx.de;\n spf=pass smtp.mailfrom=dlechner@baylibre.com"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fwrlH0026z1yCv\n\tfor ; Thu, 16 Apr 2026 05:27:54 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 4BD2683C2B;\n\tWed, 15 Apr 2026 21:27:47 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id 4D70783EEF; Wed, 15 Apr 2026 21:27:45 +0200 (CEST)","from mail-ot1-x32b.google.com (mail-ot1-x32b.google.com\n [IPv6:2607:f8b0:4864:20::32b])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id C473E83B99\n for ; Wed, 15 Apr 2026 21:27:41 +0200 (CEST)","by mail-ot1-x32b.google.com with SMTP id\n 46e09a7af769-7dbd08144deso6507470a34.0\n for ; Wed, 15 Apr 2026 12:27:41 -0700 (PDT)","from ?IPV6:2600:8803:e7e4:500:5ab6:1e6d:2337:887c?\n ([2600:8803:e7e4:500:5ab6:1e6d:2337:887c])\n by smtp.gmail.com with ESMTPSA id\n 46e09a7af769-7dc76b95a2csm1981183a34.22.2026.04.15.12.27.39\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Wed, 15 Apr 2026 12:27:40 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=baylibre-com.20251104.gappssmtp.com; s=20251104; t=1776281260;\n x=1776886060;\n darn=lists.denx.de;\n h=content-transfer-encoding:in-reply-to:content-language:references\n :cc:to:from:subject:user-agent:mime-version:date:message-id:from:to\n :cc:subject:date:message-id:reply-to;\n bh=Z9pHAyC2MSXCOGZS4EM/jAg/9KPWyZ8FeYONgRLWmsc=;\n b=qL07nYpJywdssicWDqhc33GoscRks+qYp6ocWulbtTHLANp0jZfSqsQNGVe3gU/r3x\n xOPTrdwX5vK90Fb9scBG28PUowMhL7ezCw6wlpgfYRB+3AGJ6KV2AGaJ/vVAneyviGLh\n oeQ3fkIATPjZQdL5ZOOpW2DJVhIlzQTUorv57mZpTjdWn41Be5dHmaXvY3qH5E+ZR/OH\n SRrrAdNHUgmb1wenFI0YkCjA3Nw3e5lPC5gs+VzE3ai9qq6DbQtafmZ/e+tclDmec2+D\n HPlItjhufeVC7IIzimSxbRQYPChSEMnk2/S8AD/2t7R6WhzXx/xfL1DDlt6tu6GBSqyY\n afLg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776281260; x=1776886060;\n h=content-transfer-encoding:in-reply-to:content-language:references\n :cc:to:from:subject:user-agent:mime-version:date:message-id:x-gm-gg\n :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;\n bh=Z9pHAyC2MSXCOGZS4EM/jAg/9KPWyZ8FeYONgRLWmsc=;\n b=EWAKrcMs5be6D9KD5arX2G1/U1g9rFJe7qaLiPGkELBUbQwNORo8wK/qegRn4gt5S8\n US2afe2K+/GnxxVyAZI/d2cANNkJ+XK+fvqpR9VBLfM+S3fiGMMNredYuDeXjhRNGEIO\n TBmqdyCJ6PSTDR5w+6rpSanNl5oQL8Ml006dK+rS2PZ28JHNJNEF2fxNIT8me1B6hFnC\n V9gQo66spvw+znqoULbZgjMgMJpBrZOT/tB23bLNZUXD8ES9IJnM8t1rWkIVR5dvJ1ei\n 3DT+AZ6Wf+cT3DzRN1jmEpt9mT/JG8B58G5zXymjFCI5KkaYznQhnHtX2FgBuDabzcAE\n x9Mg==","X-Forwarded-Encrypted":"i=1;\n AFNElJ9JUQgkzT4FTA8CnKZwduhvl2f4I73qhpymdjq9iBkWOsadyJLaEws5S13HVEpkuwa3msscvYY=@lists.denx.de","X-Gm-Message-State":"AOJu0YygSP2x0AauNb9z1ElFygAYz/eHAXGjU+QQgOToZc5VWdHGjTBg\n pOWkoXhsaJ5y2q171MjC+pij5IALHNXfSsNYlXeiZqBBIwVNu3ceGpXaq7B9aJKgcbU=","X-Gm-Gg":"AeBDiesR9aZu1R8j19zsjcQPQy0ko4lH9sQz784hrTmRSwU+N5n+jlGNf/5/vqcQBmP\n NJ6k0MCUiGS539rZja4PQEws9vzqEWVzjfdo/ZpkFDgW71YiY3ce1pkJoRG9wCjwaeSCMZ2iM/o\n bn4kuiNYwlorl32jBcJX7b+Ps0rd0pXmZ8QwAhFJVBDE5C40Hb10y4MArW+V26cb2u/jT5Wk66L\n /VFFaiSkaQx55IG1u5dXPeQHblg7UtvHbG7RM8P9Co5+GgIif9WaY6Q5FFCrrfhjVmsnbNGyVbk\n CAUmx5v1UjM6JTj42QRC9F/N91fEVoC+o3vAGv9LLJ1d2t2oEQsKqx1bzGGZnfgr/9ohyjeBT09\n +JMBC3yKP049zp5qNymUcDxrx5uc+b/eWL42d1oGuyz5jfqwQvD9je56dblgvfdiPGeX8r2rCma\n vdC/zygxbOUu2IdqxbkbTEu5Iw3IjwEGUsy2puKiX+OqOYcY1B4h0ZADE6DtgrTRu+7oZ3Q05nH\n aYhRzVrfa59","X-Received":"by 2002:a05:6830:8290:b0:7d9:f50f:96cc with SMTP id\n 46e09a7af769-7dc27c643e8mr13764339a34.2.1776281260513;\n Wed, 15 Apr 2026 12:27:40 -0700 (PDT)","Message-ID":"<0d7ba570-335e-4de7-b272-7152b540def2@baylibre.com>","Date":"Wed, 15 Apr 2026 14:27:39 -0500","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH] arm: mediatek: enable fw loader support","From":"David Lechner ","To":"Weijie Gao , Tom Rini ","Cc":"GSS_MTK_Uboot_upstream ,\n u-boot@lists.denx.de","References":"<20260410015311.4066075-1-weijie.gao@mediatek.com>\n ","Content-Language":"en-US","In-Reply-To":"","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"7bit","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}},{"id":3677821,"web_url":"http://patchwork.ozlabs.org/comment/3677821/","msgid":"<20260415205624.GP41863@bill-the-cat>","list_archive_url":null,"date":"2026-04-15T20:56:24","subject":"Re: [PATCH] arm: mediatek: enable fw loader support","submitter":{"id":65875,"url":"http://patchwork.ozlabs.org/api/people/65875/","name":"Tom Rini","email":"trini@konsulko.com"},"content":"On Wed, Apr 15, 2026 at 02:27:39PM -0500, David Lechner wrote:\n> On 4/15/26 10:02 AM, David Lechner wrote:\n> > On 4/9/26 8:53 PM, Weijie Gao wrote:\n> >> Enable SUPPORTS_FW_LOADER to allow the mediatek platform to use ethernet PHY\n> >> drivers with fw loading.\n> >>\n> >> Signed-off-by: Weijie Gao \n> >> ---\n> >> arch/arm/Kconfig | 1 +\n> >> 1 file changed, 1 insertion(+)\n> >>\n> >> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig\n> >> index 03416c55265..aee8e74dace 100644\n> >> --- a/arch/arm/Kconfig\n> >> +++ b/arch/arm/Kconfig\n> >> @@ -868,6 +868,7 @@ config ARCH_MEDIATEK\n> >> \tselect SPL_LIBGENERIC_SUPPORT if SPL\n> >> \tselect SPL_OF_CONTROL if SPL\n> >> \tselect SUPPORT_SPL\n> >> +\tselect SUPPORTS_FW_LOADER\n> > \n> > I don't think this is how this config option is meant to be used.\n> > \n> > Based on [1], it sounds like we just need to make sure CMDLINE and\n> > ENV_SUPPORT are enabled in any config that also enables PHY_MEDIATEK_2P5GE.\n> > \n> > I don't see any defconfig that enables PHY_MEDIATEK_2P5GE though, so\n> > I'm not sure there is anything to do here. Unless it makes sense to\n> > enable this in one of the existing defconfigs or add a new defconfig?\n> > \n> > [1]: https://lore.kernel.org/u-boot/20260310162610.1163833-1-trini@konsulko.com/\n> > \n> >> \thelp\n> >> \t Support for the MediaTek SoCs family developed by MediaTek Inc.\n> >> \t Please refer to doc/README.mediatek for more information.\n> > \n> \n> I thought about this some more and I wonder if we need to do something\n> like this to make it actually work correctly though...\n> \n> ---\n> diff --git a/lib/Kconfig b/lib/Kconfig\n> index 4e6a0c6a1b6..ed37daa28b8 100644\n> --- a/lib/Kconfig\n> +++ b/lib/Kconfig\n> @@ -73,6 +73,7 @@ config DYNAMIC_CRC_TABLE\n> \n> config SUPPORTS_FW_LOADER\n> \tbool\n> +\tdefault y\n> \tdepends on CMDLINE\n> \tdepends on ENV_SUPPORT\n\nThat would be \"def_bool y\" in practice. And yes, that looks right, and\nshould have a Fixes.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=konsulko.com header.i=@konsulko.com header.a=rsa-sha256\n header.s=google header.b=Man+8qOO;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=konsulko.com","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=konsulko.com header.i=@konsulko.com\n header.b=\"Man+8qOO\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=konsulko.com","phobos.denx.de;\n spf=pass smtp.mailfrom=trini@konsulko.com"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fwtjb2L0tz1yCv\n\tfor ; Thu, 16 Apr 2026 06:56:35 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 391F38407D;\n\tWed, 15 Apr 2026 22:56:32 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id EC9CB8407E; Wed, 15 Apr 2026 22:56:31 +0200 (CEST)","from mail-oo1-xc33.google.com (mail-oo1-xc33.google.com\n [IPv6:2607:f8b0:4864:20::c33])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 7CAB983B99\n for ; Wed, 15 Apr 2026 22:56:28 +0200 (CEST)","by mail-oo1-xc33.google.com with SMTP id\n 006d021491bc7-662f30d3f1fso4139192eaf.1\n for ; Wed, 15 Apr 2026 13:56:28 -0700 (PDT)","from bill-the-cat (fixed-189-203-106-235.totalplay.net.\n [189.203.106.235]) by smtp.gmail.com with ESMTPSA id\n 006d021491bc7-6932b374a0dsm1497544eaf.5.2026.04.15.13.56.26\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 15 Apr 2026 13:56:26 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,\n SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=konsulko.com; s=google; t=1776286587; x=1776891387; darn=lists.denx.de;\n h=in-reply-to:content-disposition:mime-version:references:message-id\n :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to;\n bh=5QvlajjKIiOAipAYL4AKUMRw74HxcSCGaCNdQ7nNjnw=;\n b=Man+8qOOLloT/uuDV3N2PkuE57xlNbyxi3e5eFs+IPmrd3nQTtEOMPVHkv6rW7iS9b\n +TTMvnTDuITM2fKKq8S5GEI/zNgzBMHMsm0pyCVOyR7ZwA63SyNp1SxXB96WGzhzarB9\n isEA3CYzEutrUIcTxQDvrQ4j0JVH7c4Ckf4Rw=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776286587; x=1776891387;\n h=in-reply-to:content-disposition:mime-version:references:message-id\n :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=5QvlajjKIiOAipAYL4AKUMRw74HxcSCGaCNdQ7nNjnw=;\n b=FusNwbAOGmRTwzi0cYgVUjyn2VQzUzHY3RFoTFpKEQ5XpFqYxw9/Wb8plHF+pk9V3f\n cm/4IHK3HI62cLkP735jh2mccLty8pta7bTFwPLjO1j0rMaWh9NkxG/Yj0cSZmflGNeK\n 7iOCdIKlbovFQaPBo6UCa2DhEFt6zamb0k5Uysvs3Y3zFCDCo+f/5Xva6P+P5bpkWQO7\n Zbf7EXJmRSQIe61jdtuHFqZjOvikXqOCcgSUi3n6rS4r60ZUbhZDyW1WNqvyt7JWcQss\n hkHazeKYJombaP2BamiIxJC1zJXhIvo+l71PdDszVOpFsoLQNNDVDLrme9OgwJ2f+hu/\n zsaA==","X-Forwarded-Encrypted":"i=1;\n AFNElJ+w912RzDHxDphz0xUW4zRXLHf4fTyiOJ89jQw8UJLxzW72y5IxzBuxW0+nEpLgRK+/+ci/NMQ=@lists.denx.de","X-Gm-Message-State":"AOJu0Yw30LJBvCdpfkM2aNYh4c/4lc1/rlBf4SiBsPGvztQD5I67vbKj\n OdFRbcLs5vAE5DeJGAt2jK6Kx5TqoXRpsT57MWLMY6kCLAtvD6Tfcdg8Uu5oE8OxRY4=","X-Gm-Gg":"AeBDies3P47J/xr/B2YJMAj4Pno36roMbTdLIKJ+z50dGS16R7OzcCSbDXvU9Tml53b\n giRak0PQUmIE/ujpb5fiasOCE7olMB5BxQ/A/539kkIo7aZTovJap3wNAczO2jM1pyiTPLJ2/zq\n 0pvN0oRliOSZgOcnsg0YMDNixAZQj8GCDOkmeTaTfi8IPgMaJdDCh6JizklG+rVdrfDHoetaWD9\n jIwy+MW4jcKBNi4iGxBgbzft2QJfHW39OslEapJMEWNMgFLJVwALc1MtletLqcr/M8qLQZuDN+7\n 5gAT/uPYGYvXu6KU+uwMx6dCwh+OF1T4uyMltrpELMmoOFa8RhGLzm6ifVkBc8aP0qxcqd7H8HK\n dd69rjwc+FCWpWgqA8vbByjzZusH9B++rKqFp8CJe/OBcyovL+avMT9iNZyiAqG72LRxc8coo6B\n qo/Ggs4ctP6VHSJgQDCGuBzdgwHlEfZIKMJqPPo4U9cKGPHL2OIeIqa2NQWXJlIH28Y2A6xRF6l\n Zkv69/zg/px6tP0eUMq/Kvgi8JQiSLLzxLM0Qtq6nfbC7wDd9Q0O7Coaxgo4f3aYuxQsn/m","X-Received":"by 2002:a05:6820:1519:b0:67d:e78f:38d2 with SMTP id\n 006d021491bc7-694235fbd9emr568633eaf.25.1776286587226;\n Wed, 15 Apr 2026 13:56:27 -0700 (PDT)","Date":"Wed, 15 Apr 2026 14:56:24 -0600","From":"Tom Rini ","To":"David Lechner ","Cc":"Weijie Gao ,\n GSS_MTK_Uboot_upstream ,\n u-boot@lists.denx.de","Subject":"Re: [PATCH] arm: mediatek: enable fw loader support","Message-ID":"<20260415205624.GP41863@bill-the-cat>","References":"<20260410015311.4066075-1-weijie.gao@mediatek.com>\n \n <0d7ba570-335e-4de7-b272-7152b540def2@baylibre.com>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha512;\n protocol=\"application/pgp-signature\"; boundary=\"4BNZA1cJYNJnQ2ut\"","Content-Disposition":"inline","In-Reply-To":"<0d7ba570-335e-4de7-b272-7152b540def2@baylibre.com>","X-Clacks-Overhead":"GNU Terry Pratchett","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}}]