[{"id":3676243,"web_url":"http://patchwork.ozlabs.org/comment/3676243/","msgid":"<7b526c07-ef87-424d-acae-6875f62d6f65@kernel.org>","list_archive_url":null,"date":"2026-04-12T07:25:52","subject":"Re: [PATCH 1/3] scsi: scsi_devinfo: add COMPAQ PD-1 multi-LUN ATAPI\n device quirk","submitter":{"id":86188,"url":"http://patchwork.ozlabs.org/api/people/86188/","name":"Damien Le Moal","email":"dlemoal@kernel.org"},"content":"On 4/9/26 23:05, Phil Pemberton wrote:\n> The Compaq-branded variant of the Panasonic/Matsushita LF-1195C PD/CD\n> combo drive is a multi-LUN ATAPI device that exposes the CD-ROM on\n> LUN 0 and a PD optical drive on LUN 1.\n> \n> An entry already exists for the \"MATSHITA PD-1\" variant with OEM\n> firmware.\n> \n> Add the Compaq-branded variant with the same BLIST_FORCELUN |\n> BLIST_SINGLELUN flags so that additional LUNs are scanned and commands\n> are serialised, matching the existing entries.\n\nHmmm, since the following patches actually enable multi-LUN scanning, it feels\nlike this patch should come last in the series.\n\n> \n> Assisted-by: Claude:claude-opus-4-6\n\nLet's stay neutral vis-a-vis commercial software/tools and drop this please.\n\n> Signed-off-by: Phil Pemberton \n> ---\n> drivers/scsi/scsi_devinfo.c | 1 +\n> 1 file changed, 1 insertion(+)\n> \n> diff --git a/drivers/scsi/scsi_devinfo.c b/drivers/scsi/scsi_devinfo.c\n> index 68a992494b12..06b211b93567 100644\n> --- a/drivers/scsi/scsi_devinfo.c\n> +++ b/drivers/scsi/scsi_devinfo.c\n> @@ -150,6 +150,7 @@ static struct {\n> \t{\"COMPAQ\", \"MSA1000\", NULL, BLIST_SPARSELUN | BLIST_NOSTARTONADD},\n> \t{\"COMPAQ\", \"MSA1000 VOLUME\", NULL, BLIST_SPARSELUN | BLIST_NOSTARTONADD},\n> \t{\"COMPAQ\", \"HSV110\", NULL, BLIST_REPORTLUN2 | BLIST_NOSTARTONADD},\n> +\t{\"COMPAQ\", \"PD-1\", NULL, BLIST_FORCELUN | BLIST_SINGLELUN},\n> \t{\"DDN\", \"SAN DataDirector\", \"*\", BLIST_SPARSELUN},\n> \t{\"DEC\", \"HSG80\", NULL, BLIST_REPORTLUN2 | BLIST_NOSTARTONADD},\n> \t{\"DELL\", \"PV660F\", NULL, BLIST_SPARSELUN},","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-ide@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=f6Cj3A44;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=104.64.211.4; helo=sin.lore.kernel.org;\n envelope-from=linux-ide+bounces-5473-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"f6Cj3A44\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201"],"Received":["from sin.lore.kernel.org (sin.lore.kernel.org [104.64.211.4])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fthsj0BSdz1yCx\n\tfor ; Sun, 12 Apr 2026 17:26:00 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sin.lore.kernel.org (Postfix) with ESMTP id 2EB8F300BCB9\n\tfor ; Sun, 12 Apr 2026 07:25:58 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 6C7AD29DB86;\n\tSun, 12 Apr 2026 07:25:56 +0000 (UTC)","from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 490DE28C869;\n\tSun, 12 Apr 2026 07:25:56 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 689AEC19424;\n\tSun, 12 Apr 2026 07:25:54 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1775978756; cv=none;\n b=G4N4I9qqKWLgj/76h0rmoasiGkZ7LduMxSH7cARS2fPntywm/AoIHwqiuab0cpjKu+pGlvwu/H1a5AJZNGZE/HlSSH/ooTYjq+HHvO0qeJD9TrhAcdw9Bwr7v1N4N0q3oz209tklGZiekBV4u4USd3tYsDYqZngEeNihYCrqslk=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1775978756; c=relaxed/simple;\n\tbh=0WbEcNq/78bW8NvZHsxdK3QJE/W0As0Y7hwTYFhizPc=;\n\th=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:\n\t In-Reply-To:Content-Type;\n b=AbN6iqgLpCXvMgZcxdlBwgMWJ550HzbkeJv36ADQYUB+qQgJQjQNFOHHFSbSo0aklTL2S8FY2c+swTPEAD4T+tnq61lxNDntEkGXZ/Luwr3yA8emsUIll4rLRp90ohw97ox9prXHlGt+PuyAmBWBAciOaskIElk/R7xDymhh4Ag=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=f6Cj3A44; arc=none smtp.client-ip=10.30.226.201","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1775978756;\n\tbh=0WbEcNq/78bW8NvZHsxdK3QJE/W0As0Y7hwTYFhizPc=;\n\th=Date:Subject:To:Cc:References:From:In-Reply-To:From;\n\tb=f6Cj3A44PSduP4qRxwo/j53MfDweQIGckUH9tCmHk9KAmZxYa7hoRoq0vekgdU6I/\n\t xcrEdKAa4fcREppS9vWETzKN70Sr0ljWJsvTOcJkXZlrH/H8JMy2OEPqZlfzOFndmb\n\t 7M25JgeyHzlE5YObCnJ17o2Rz6Uay32EiXWbKbliKAczFIDZIj1XX/SrKkjdx171d+\n\t Ilrm/gjuzet1kF9+XCSzfs+HMUoVJNMwfGhB6bG6TjMd+iIic6sC60opqZ2NhaXCjm\n\t 98/RfAfgKf9LA1oBxLBh8QVhdf65UvkvedeQ9RyVoP3kms28Fw1FI7pljr7AHJAFEI\n\t EisnMzIPQVKMQ==","Message-ID":"<7b526c07-ef87-424d-acae-6875f62d6f65@kernel.org>","Date":"Sun, 12 Apr 2026 09:25:52 +0200","Precedence":"bulk","X-Mailing-List":"linux-ide@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH 1/3] scsi: scsi_devinfo: add COMPAQ PD-1 multi-LUN ATAPI\n device quirk","To":"Phil Pemberton , cassel@kernel.org,\n James.Bottomley@HansenPartnership.com, martin.petersen@oracle.com","Cc":"linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org,\n linux-kernel@vger.kernel.org","References":"<20260409210559.155864-1-philpem@philpem.me.uk>\n <20260409210559.155864-2-philpem@philpem.me.uk>","Content-Language":"en-US","From":"Damien Le Moal ","Organization":"Western Digital Research","In-Reply-To":"<20260409210559.155864-2-philpem@philpem.me.uk>","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"7bit"}}]