[{"id":3675480,"web_url":"http://patchwork.ozlabs.org/comment/3675480/","msgid":"","list_archive_url":null,"date":"2026-04-09T19:32:06","subject":"Re: [PATCH v2] ASoC: uda1380: Modernize the driver","submitter":{"id":24878,"url":"http://patchwork.ozlabs.org/api/people/24878/","name":"Mark Brown","email":"broonie@kernel.org"},"content":"On Thu, Apr 09, 2026 at 09:17:14PM +0200, Linus Walleij wrote:\n\n> This makes the driver usable on contemporary Linux, maybe it will\n> even work, I can't test it.\n\nDon't think so...\n\n> @@ -742,6 +745,7 @@ static const struct snd_soc_component_driver soc_component_dev_uda1380 = {\n> static int uda1380_i2c_probe(struct i2c_client *i2c)\n> {\n> \tstruct uda1380_platform_data *pdata = i2c->dev.platform_data;\n> +\tstruct device *dev = &i2c->dev;\n> \tstruct uda1380_priv *uda1380;\n> \tint ret;\n\nWe still have the platform data above, and just below this we have:\n\n if (!pdata)\n return -EINVAL;\n\nso I'm not sure how the driver is going to instantiate, there's\nmandatory platform data still. Not that the driver would've\ninstantiated before either with anyhing in mainline...","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-gpio@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=bIEMmMum;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.234.253.10; helo=sea.lore.kernel.org;\n envelope-from=linux-gpio+bounces-34972-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"bIEMmMum\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org [172.234.253.10])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fs9H03wxmz1yHG\n\tfor ; Fri, 10 Apr 2026 05:39:08 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id EB4193009510\n\tfor ; Thu, 9 Apr 2026 19:38:58 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 6B14030F53C;\n\tThu, 9 Apr 2026 19:38:57 +0000 (UTC)","from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 2EC083002DC;\n\tThu, 9 Apr 2026 19:38:57 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id A48E5C4CEF7;\n\tThu, 9 Apr 2026 19:38:56 +0000 (UTC)","by finisterre.sirena.org.uk (Postfix, from userid 1000)\n\tid 77FAE1AC589F; Thu, 09 Apr 2026 20:32:06 +0100 (BST)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1775763537; cv=none;\n b=gvejguYZhyjt3IfoDJtc5mtm31qoI1kH1yjdkGIUFNriPS8MpBfA1gHcKTpR+tWboprNie6wgIRdCSCKEEoaRlm7nKlXqOofm//MgeGaACVDHJBH5xvnQeurU424R20wj5q0cU2pFEKagh7MfUnnJHcRxY0+AkzXgISCF13Y+eY=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1775763537; c=relaxed/simple;\n\tbh=zzPwLipKtSXYmft9jKL7F+YuBKt98uxsZx70dOz14gM=;\n\th=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:\n\t Content-Type:Content-Disposition:In-Reply-To;\n b=PnKnc5jCVprbkHTnVrNet4IxVO8ccJWiL+e25ll0lIQ7y8yRz2Mty2ljZHvNiTC9rnZKIDF3CvxXYCpdNIr2sD8QufE3W9C5oaCoO2YBsezF4Mmf/W2QzC+gT0Qy4vzrNGICwkcmpb0LiZ22WSaE1OkX1UThYAQgpWF9MUgAD+c=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=bIEMmMum; arc=none smtp.client-ip=10.30.226.201","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1775763536;\n\tbh=zzPwLipKtSXYmft9jKL7F+YuBKt98uxsZx70dOz14gM=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=bIEMmMum9HbiTU2PcL8KEZ72ZTmR88Plz9CfN3fv7xRjKgB1VMDaD0Cq841jn/k7i\n\t +t9RoGm4vb78ggpGOLdVZvHrdbh0A+552k/RlSkE8ooA7PmG/R9nzQiGgByT56xD5M\n\t yWWEqP001lZd13CcIEajI8mxVYKutnm0RYF5ueb89sBNCrtUvQ6ElqWtlGQAbC9J4q\n\t SgFTHn/54oPZbxTfQ1JXxji+4fZx8Sp/bX5S4PHJ/Mn+eAAIft6JSTe1YBTLvXIW0R\n\t quQjxvUeqgwzUlvTi3CFAxSrN21cq7jhYvWLSWGXIgt0gQVhaQDSlyC0gf2l4zSJjg\n\t LGCnjvtfAufPw==","Date":"Thu, 9 Apr 2026 20:32:06 +0100","From":"Mark Brown ","To":"Linus Walleij ","Cc":"Philipp Zabel ,\n\tJaroslav Kysela , Takashi Iwai ,\n\tLiam Girdwood ,\n\tBartosz Golaszewski , linux-sound@vger.kernel.org,\n\tlinux-gpio@vger.kernel.org","Subject":"Re: [PATCH v2] ASoC: uda1380: Modernize the driver","Message-ID":"","References":"<20260409-asoc-uda1380-v2-1-42d02079ecd5@kernel.org>","Precedence":"bulk","X-Mailing-List":"linux-gpio@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha512;\n\tprotocol=\"application/pgp-signature\"; boundary=\"IBQlhWmMOANbG5oH\"","Content-Disposition":"inline","In-Reply-To":"<20260409-asoc-uda1380-v2-1-42d02079ecd5@kernel.org>","X-Cookie":"Are we not men?"}}]