[{"id":3675437,"web_url":"http://patchwork.ozlabs.org/comment/3675437/","msgid":"","list_archive_url":null,"date":"2026-04-09T17:38:25","subject":"Re: [PATCH 2/4] drivers: ufs: qcom: Add SPL support","submitter":{"id":90020,"url":"http://patchwork.ozlabs.org/api/people/90020/","name":"Ferass El Hafidi","email":"funderscore@postmarketos.org"},"content":"Hi, some drive-by feedback:\n\nOn Thu, 09 Apr 2026 14:43, \"Balaji Selvanathan via groups.io\" wrote:\n>Enable Qualcomm UFS driver to be built for SPL. The ufs-uclass is\n>also built conditionally based on whether SPL or\n>U-Boot proper is being compiled.\n>\n>Signed-off-by: Balaji Selvanathan \n>---\n> drivers/ufs/Kconfig | 8 ++++++++\n> drivers/ufs/Makefile | 7 ++++++-\n> 2 files changed, 14 insertions(+), 1 deletion(-)\n>\n>diff --git a/drivers/ufs/Kconfig b/drivers/ufs/Kconfig\n>index 49472933de3..a32d51cae1d 100644\n>--- a/drivers/ufs/Kconfig\n>+++ b/drivers/ufs/Kconfig\n>@@ -55,6 +55,14 @@ config UFS_QCOM\n> \t This selects the platform driver for the UFS host\n> \t controller present on Qualcomm Snapdragon SoCs.\n> \n>+config SPL_UFS_QCOM\n>+\tbool \"Qualcomm Host Controller driver for UFS in SPL\"\n>+\tdepends on SPL_UFS_SUPPORT && ARCH_SNAPDRAGON\n>+\thelp\n>+\t This selects the platform driver for the UFS host\n>+\t controller present on Qualcomm Snapdragon SoCs for use in SPL.\n>+\t Enable this to use UFS as a boot device in SPL on Qualcomm platforms.\n>+\n> config UFS_RENESAS\n> \tbool \"Renesas R-Car S4 UFS Controller support\"\n> \tdepends on UFS\n>diff --git a/drivers/ufs/Makefile b/drivers/ufs/Makefile\n>index e7f3c1d30c4..7056066ce25 100644\n>--- a/drivers/ufs/Makefile\n>+++ b/drivers/ufs/Makefile\n>@@ -3,13 +3,18 @@\n> # Copyright (C) 2019 Texas Instruments Incorporated - https://www.ti.com\n> #\n> \n>+ifdef CONFIG_SPL_BUILD\n>+obj-$(CONFIG_SPL_UFS_SUPPORT) += ufs-uclass.o\n>+else\n> obj-$(CONFIG_UFS) += ufs-uclass.o\n>+endif\n\nCONFIG_SPL_UFS_SUPPORT depends on CONFIG_UFS being enabled, so from my\nunderstanding, don't think this change is needed, is it?\n\n> obj-$(CONFIG_UFS_AMD_VERSAL2) += ufs-amd-versal2.o ufshcd-dwc.o\n> obj-$(CONFIG_UFS_CADENCE) += cdns-platform.o\n> obj-$(CONFIG_UFS_MEDIATEK) += ufs-mediatek.o\n> obj-$(CONFIG_UFS_PCI) += ufs-pci.o\n>-obj-$(CONFIG_UFS_QCOM) += ufs-qcom.o\n>+obj-$(CONFIG_$(PHASE_)UFS_QCOM) += ufs-qcom.o\n> obj-$(CONFIG_UFS_RENESAS) += ufs-renesas.o\n> obj-$(CONFIG_UFS_RENESAS_GEN5) += ufs-renesas-rcar-gen5.o\n> obj-$(CONFIG_UFS_ROCKCHIP) += ufs-rockchip.o\n> obj-$(CONFIG_UFS_TI_J721E) += ti-j721e-ufs.o\n>+\n>\n\nBest regards,\nFerass","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=postmarketos.org header.i=@postmarketos.org\n header.a=rsa-sha256 header.s=key1 header.b=RZlMw3fJ;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=fail (p=quarantine dis=none) header.from=postmarketos.org","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=postmarketos.org header.i=@postmarketos.org\n header.b=\"RZlMw3fJ\";\n\tdkim-atps=neutral","phobos.denx.de; dmarc=fail (p=quarantine dis=none)\n header.from=postmarketos.org","phobos.denx.de;\n spf=pass smtp.mailfrom=funderscore@postmarketos.org"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fs7MW6TQyz1yCv\n\tfor ; Fri, 10 Apr 2026 04:12:55 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 8EABA84167;\n\tThu, 9 Apr 2026 20:12:24 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id 0F55B84099; Thu, 9 Apr 2026 19:43:58 +0200 (CEST)","from out-170.mta0.migadu.com (out-170.mta0.migadu.com\n [IPv6:2001:41d0:1004:224b::aa])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id C7D9A83D8A\n for ; Thu, 9 Apr 2026 19:43:54 +0200 (CEST)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-1.7 required=5.0 tests=BAYES_00,DKIM_INVALID,\n DKIM_SIGNED,RCVD_IN_DNSWL_BLOCKED,SPF_HELO_PASS,SPF_PASS autolearn=no\n autolearn_force=no version=3.4.2","Date":"Thu, 09 Apr 2026 17:38:25 +0000","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=postmarketos.org;\n s=key1; t=1775756633;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=tw/J9VRpjgEKX+sgPsRv04aZlKhkiyBr/oxQ6MnS1bg=;\n b=RZlMw3fJ+eCpXpvC5jlqo2dG65t3zCSyvXo5Hp/l3YUKa5FuZpvex+WlYOdO6W7yjO0DST\n XpI8pCfaBxwo0Zqe0JBJzWb0RBJPeVgTXlwmUFjw/JO14xSAh5PS7FAbxMhfK9IkApUuZT\n 0U1DXqsO74u8r/RYuRg17DCcj/FQNlpYgH4w3zOG67yQGbEjs6n/Bc23muD4pJKfSnWrkK\n Lq56PsbPwjt9mXu5XZUSYyZMV9AYb26ccoTzBX3bPplw6zHWri5WavN4chGqXey+4c60fR\n Rakd6iksN7pLh7lOK0dhrkXlbkL3EDR/TYJjfx4odwyiS2ESDk8RxwnWjIkRWA==","X-Report-Abuse":"Please report any abuse attempt to abuse@migadu.com and\n include these headers.","From":"Ferass El Hafidi ","To":"u-boot-qcom@groups.io, u-boot@lists.denx.de,\n Sumit Garg ","Cc":"Tom Rini , Neil Armstrong ,\n Bhupesh Sharma ,\n Neha Malcom Francis , Anshul Dalal ,\n Peng Fan , Mattijs Korpershoek ,\n Quentin Schulz ,\n Hrushikesh Salunke , Alexey Charkov ,\n Dario Binacchi ,\n Andre Przywara ,\n Ilias Apalodimas ,\n Javier Martinez Canillas ,\n Jan Kiszka , Javier Tia ,\n Rasmus Villemoes ,\n Varadarajan Narayanan ,\n Jo =?utf-8?b?w6M=?= o Marcos Costa ,\n Dhruva Gole , Richard Genoud ,\n Marek Vasut ,\n Simon Glass ,\n Igor Belwon ,\n Shawn Lin , Tuyen Dang ,\n Casey Connolly , Lukasz Majewski ,\n Patrice Chotard ,\n Patrick Delaunay ,\n Michal Simek , Yao Zi ,\n Peter Korsgaard ,\n Balaji Selvanathan ","Subject":"Re: [PATCH 2/4] drivers: ufs: qcom: Add SPL support","References":"<20260409-spl_ufs_only-v1-0-f7e0e243d805@oss.qualcomm.com>\n <20260409-spl_ufs_only-v1-2-f7e0e243d805@oss.qualcomm.com>","In-Reply-To":"<20260409-spl_ufs_only-v1-2-f7e0e243d805@oss.qualcomm.com>","Message-ID":"","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Content-Type":"text/plain; charset=utf-8; format=flowed","X-Migadu-Flow":"FLOW_OUT","X-Mailman-Approved-At":"Thu, 09 Apr 2026 20:12:23 +0200","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}},{"id":3675438,"web_url":"http://patchwork.ozlabs.org/comment/3675438/","msgid":"","list_archive_url":null,"date":"2026-04-09T17:45:03","subject":"Re: [PATCH 2/4] drivers: ufs: qcom: Add SPL support","submitter":{"id":90020,"url":"http://patchwork.ozlabs.org/api/people/90020/","name":"Ferass El Hafidi","email":"funderscore@postmarketos.org"},"content":"On Thu, 09 Apr 2026 17:38, Ferass El Hafidi wrote:\n>Hi, some drive-by feedback:\n>\n>On Thu, 09 Apr 2026 14:43, \"Balaji Selvanathan via groups.io\" wrote:\n>>Enable Qualcomm UFS driver to be built for SPL. The ufs-uclass is\n>>also built conditionally based on whether SPL or\n>>U-Boot proper is being compiled.\n>>\n>>Signed-off-by: Balaji Selvanathan \n>>---\n>> drivers/ufs/Kconfig | 8 ++++++++\n>> drivers/ufs/Makefile | 7 ++++++-\n>> 2 files changed, 14 insertions(+), 1 deletion(-)\n>>\n>>diff --git a/drivers/ufs/Kconfig b/drivers/ufs/Kconfig\n>>index 49472933de3..a32d51cae1d 100644\n>>--- a/drivers/ufs/Kconfig\n>>+++ b/drivers/ufs/Kconfig\n>>@@ -55,6 +55,14 @@ config UFS_QCOM\n>> \t This selects the platform driver for the UFS host\n>> \t controller present on Qualcomm Snapdragon SoCs.\n>> \n>>+config SPL_UFS_QCOM\n>>+\tbool \"Qualcomm Host Controller driver for UFS in SPL\"\n>>+\tdepends on SPL_UFS_SUPPORT && ARCH_SNAPDRAGON\n>>+\thelp\n>>+\t This selects the platform driver for the UFS host\n>>+\t controller present on Qualcomm Snapdragon SoCs for use in SPL.\n>>+\t Enable this to use UFS as a boot device in SPL on Qualcomm platforms.\n>>+\n>> config UFS_RENESAS\n>> \tbool \"Renesas R-Car S4 UFS Controller support\"\n>> \tdepends on UFS\n>>diff --git a/drivers/ufs/Makefile b/drivers/ufs/Makefile\n>>index e7f3c1d30c4..7056066ce25 100644\n>>--- a/drivers/ufs/Makefile\n>>+++ b/drivers/ufs/Makefile\n>>@@ -3,13 +3,18 @@\n>> # Copyright (C) 2019 Texas Instruments Incorporated - https://www.ti.com\n>> #\n>> \n>>+ifdef CONFIG_SPL_BUILD\n>>+obj-$(CONFIG_SPL_UFS_SUPPORT) += ufs-uclass.o\n>>+else\n>> obj-$(CONFIG_UFS) += ufs-uclass.o\n>>+endif\n>\n>CONFIG_SPL_UFS_SUPPORT depends on CONFIG_UFS being enabled, so from my\n>understanding, don't think this change is needed, is it?\n>\n\nOh ignore this, my bad. It is needed for an SPL build.\n\n>> obj-$(CONFIG_UFS_AMD_VERSAL2) += ufs-amd-versal2.o ufshcd-dwc.o\n>> obj-$(CONFIG_UFS_CADENCE) += cdns-platform.o\n>> obj-$(CONFIG_UFS_MEDIATEK) += ufs-mediatek.o\n>> obj-$(CONFIG_UFS_PCI) += ufs-pci.o\n>>-obj-$(CONFIG_UFS_QCOM) += ufs-qcom.o\n>>+obj-$(CONFIG_$(PHASE_)UFS_QCOM) += ufs-qcom.o\n>> obj-$(CONFIG_UFS_RENESAS) += ufs-renesas.o\n>> obj-$(CONFIG_UFS_RENESAS_GEN5) += ufs-renesas-rcar-gen5.o\n>> obj-$(CONFIG_UFS_ROCKCHIP) += ufs-rockchip.o\n>> obj-$(CONFIG_UFS_TI_J721E) += ti-j721e-ufs.o\n>>+\n>>\n>\n>Best regards,\n>Ferass","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=postmarketos.org header.i=@postmarketos.org\n header.a=rsa-sha256 header.s=key1 header.b=FeHmlx/5;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=85.214.62.61; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=fail (p=quarantine dis=none) header.from=postmarketos.org","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=postmarketos.org header.i=@postmarketos.org\n header.b=\"FeHmlx/5\";\n\tdkim-atps=neutral","phobos.denx.de; dmarc=fail (p=quarantine dis=none)\n header.from=postmarketos.org","phobos.denx.de;\n spf=pass smtp.mailfrom=funderscore@postmarketos.org"],"Received":["from phobos.denx.de (phobos.denx.de [85.214.62.61])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fs7Mk2DNQz1yCv\n\tfor ; Fri, 10 Apr 2026 04:13:06 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id CA5E58419C;\n\tThu, 9 Apr 2026 20:12:24 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id 9C23C840D8; Thu, 9 Apr 2026 19:45:58 +0200 (CEST)","from out-179.mta0.migadu.com (out-179.mta0.migadu.com\n [IPv6:2001:41d0:1004:224b::b3])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 5EEBD83DC9\n for ; Thu, 9 Apr 2026 19:45:56 +0200 (CEST)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-1.7 required=5.0 tests=BAYES_00,DKIM_INVALID,\n DKIM_SIGNED,RCVD_IN_DNSWL_BLOCKED,SPF_HELO_PASS,SPF_PASS autolearn=no\n autolearn_force=no version=3.4.2","Date":"Thu, 09 Apr 2026 17:45:03 +0000","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=postmarketos.org;\n s=key1; t=1775756754;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=HDT9IRniGLCX54nJ+/EKi6ZehdAxmUXRe8zPP4607nU=;\n b=FeHmlx/52b5M9vsVtzonQboJdwgKv6qcKlxII9qiSAmUgnVom/azDH42MMoj+URAHuJxt9\n DqDJYYpDBpjLrvDgYy+VD+0/vp3bRTMW3SL/Bp3swKyua2/Zvfg17EDS67kIsxCUuy00To\n OCFj9orKe9BPSHhUkQr+KnxSgk676JIVenSP+5LyFlaBRYiS62CWjR4wXcSkP479m2YSVk\n kUzCEPpXNBbj9uXbLj2HT8Gnh2jv7ZP23NMjOyxvj0yk9Yz09H1sNOHCCJFK1noge+Ddh6\n 3aKOBMjzFO6cYBjgXsGvHYxl4YFxhIk1tBOaCVB2QXdSiDrGKg303hINuK4WYw==","X-Report-Abuse":"Please report any abuse attempt to abuse@migadu.com and\n include these headers.","From":"Ferass El Hafidi ","To":"u-boot-qcom@groups.io, u-boot@lists.denx.de,\n Sumit Garg ","Cc":"Tom Rini , Neil Armstrong ,\n Bhupesh Sharma ,\n Neha Malcom Francis , Anshul Dalal ,\n Peng Fan , Mattijs Korpershoek ,\n Quentin Schulz ,\n Hrushikesh Salunke , Alexey Charkov ,\n Dario Binacchi ,\n Andre Przywara ,\n Ilias Apalodimas ,\n Javier Martinez Canillas ,\n Jan Kiszka , Javier Tia ,\n Rasmus Villemoes ,\n Varadarajan Narayanan ,\n Jo =?utf-8?b?w6M=?= o Marcos Costa ,\n Dhruva Gole , Richard Genoud ,\n Marek Vasut ,\n Simon Glass ,\n Igor Belwon ,\n Shawn Lin , Tuyen Dang ,\n Casey Connolly , Lukasz Majewski ,\n Patrice Chotard ,\n Patrick Delaunay ,\n Michal Simek , Yao Zi ,\n Peter Korsgaard ,\n Balaji Selvanathan ","Subject":"Re: [PATCH 2/4] drivers: ufs: qcom: Add SPL support","References":"<20260409-spl_ufs_only-v1-0-f7e0e243d805@oss.qualcomm.com>\n <20260409-spl_ufs_only-v1-2-f7e0e243d805@oss.qualcomm.com>\n ","In-Reply-To":"","Message-ID":"","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Content-Type":"text/plain; charset=utf-8; format=flowed","X-Migadu-Flow":"FLOW_OUT","X-Mailman-Approved-At":"Thu, 09 Apr 2026 20:12:23 +0200","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}}]