[{"id":3675379,"web_url":"http://patchwork.ozlabs.org/comment/3675379/","msgid":"<20260409-headwear-condense-c119f423095b@spud>","list_archive_url":null,"date":"2026-04-09T15:57:06","subject":"Re: [PATCH v7 1/6] dt-bindings: iio: adc: add AD4691 family","submitter":{"id":84372,"url":"http://patchwork.ozlabs.org/api/people/84372/","name":"Conor Dooley","email":"conor@kernel.org"},"content":"On Thu, Apr 09, 2026 at 06:28:22PM +0300, Radu Sabau via B4 Relay wrote:\n> From: Radu Sabau \n> \n> Add DT bindings for the Analog Devices AD4691 family of multichannel\n> SAR ADCs (AD4691, AD4692, AD4693, AD4694).\n> \n> The binding describes the hardware connections:\n> \n> - Power domains: avdd-supply (required), vio-supply, ref-supply or\n> refin-supply (external reference; the REFIN path enables the\n> internal reference buffer), and an optional ldo-in-supply, that if\n> absent, means the on-chip internal LDO will be used.\n> \n> - Optional PWM on the CNV pin selects CNV Burst Mode; when absent,\n> Manual Mode is assumed with CNV tied to SPI CS.\n> \n> - An optional reset GPIO (reset-gpios) for hardware reset.\n> \n> - Up to four GP pins (gp0..gp3) usable as interrupt sources,\n> identified in firmware via interrupt-names \"gp0\"..\"gp3\".\n> \n> - gpio-controller with #gpio-cells = <2> for GP pin GPIO usage.\n> \n> - #trigger-source-cells = <1>: one cell selecting the GP pin number\n> (0-3) used as the SPI offload trigger source.\n> \n> Two binding examples are provided: CNV Burst Mode with SPI offload\n> (DMA data acquisition driven by DATA_READY on a GP pin), and Manual\n> Mode for CPU-driven triggered-buffer or single-shot capture.\n> \n> Signed-off-by: Radu Sabau \n> ---\n> .../devicetree/bindings/iio/adc/adi,ad4691.yaml | 162 +++++++++++++++++++++\n> MAINTAINERS | 7 +\n> 2 files changed, 169 insertions(+)\n> \n> diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad4691.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad4691.yaml\n> new file mode 100644\n> index 000000000000..81d2ca4e0e22\n> --- /dev/null\n> +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad4691.yaml\n> @@ -0,0 +1,162 @@\n> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)\n> +%YAML 1.2\n> +---\n> +$id: http://devicetree.org/schemas/iio/adc/adi,ad4691.yaml#\n> +$schema: http://devicetree.org/meta-schemas/core.yaml#\n> +\n> +title: Analog Devices AD4691 Family Multichannel SAR ADCs\n> +\n> +maintainers:\n> + - Radu Sabau \n> +\n> +description: |\n> + The AD4691 family are high-speed, low-power, multichannel successive\n> + approximation register (SAR) analog-to-digital converters (ADCs) with\n> + an SPI-compatible serial interface. The ADC supports CNV Burst Mode,\n> + where an external PWM drives the CNV pin, and Manual Mode, where CNV\n> + is directly tied to the SPI chip-select.\n> +\n> + Datasheets:\n> + * https://www.analog.com/en/products/ad4691.html\n> + * https://www.analog.com/en/products/ad4692.html\n> + * https://www.analog.com/en/products/ad4693.html\n> + * https://www.analog.com/en/products/ad4694.html\n> +\n> +$ref: /schemas/spi/spi-peripheral-props.yaml#\n> +\n> +properties:\n> + compatible:\n> + enum:\n> + - adi,ad4691\n> + - adi,ad4692\n> + - adi,ad4693\n> + - adi,ad4694\n\nPlease add a note to the commit message about why these devices are not\ncompatible. With that,\nAcked-by: Conor Dooley \npw-bot: not-applicable","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-gpio@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=tD+Traxk;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c09:e001:a7::12fc:5321; helo=sto.lore.kernel.org;\n envelope-from=linux-gpio+bounces-34965-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"tD+Traxk\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201"],"Received":["from sto.lore.kernel.org (sto.lore.kernel.org\n [IPv6:2600:3c09:e001:a7::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fs4M22k7gz1yHG\n\tfor ; Fri, 10 Apr 2026 01:57:18 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sto.lore.kernel.org (Postfix) with ESMTP id A130F30059B5\n\tfor ; Thu, 9 Apr 2026 15:57:15 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 25CDA3431EF;\n\tThu, 9 Apr 2026 15:57:13 +0000 (UTC)","from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id D5D462F83A2;\n\tThu, 9 Apr 2026 15:57:12 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 768C0C4CEF7;\n\tThu, 9 Apr 2026 15:57:08 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1775750232; cv=none;\n b=crMY1ud/zaoJCbnSx/bAZFJAtrIE6+pcZWIoMIRsd5ncFe1kUtxhM7kgCT17AY1IqxnC4DQJsLZ+yo1GyhZ98EWVyOyPHzyKy6pz844F8g4iY6uThl+gNzMyidPDHOkQrX1CunvcxT0V3RtcrWP0CbXWmU9SkSIEhbBALATG88o=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1775750232; c=relaxed/simple;\n\tbh=WR+qzP41usMsL+U2CHUcv+sT27DtSgM6KltIpwfZcnY=;\n\th=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:\n\t Content-Type:Content-Disposition:In-Reply-To;\n b=GMJkXW5qszJ5WEAjzZPsgLI4jcmmayMXNupt+lhNzjXMytmcCgYigQjOPbnmDWzlTNUSLQ+YE8kdmAktT5laiGzWYsLmko8JGs4EeDpw6GZ8fWgH6fvLbzcmE2P+YWtJizWpp3UjMxCo9hrxLdoD5GzZ1tNf6bRwGpvo6E1Z98c=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=tD+Traxk; arc=none smtp.client-ip=10.30.226.201","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1775750232;\n\tbh=WR+qzP41usMsL+U2CHUcv+sT27DtSgM6KltIpwfZcnY=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=tD+TraxkBSWzV1OrvrD/QSp3BLnXIyQ/r5VEw6Ssz3oVkX62k9yBe3TLQioa/1soi\n\t pwx5mlxqS6foCBa5LNeuMMUU16bHPdrWEfieNxK+dyyT+lyEaiFtCE2rRc+83+PC5a\n\t K/2pOvpJ0ECptyYkObH3plHWEH1NYAkS6HHUESwGZki2P/UqMiwpiIZjucJN39BENx\n\t OBo4WsN5BqX+ULmrxtpN3dIJnAgIXmLrFEp5Co2xDwD5ek+foaAd2xxGQHGc7qHwRt\n\t Xqb9KwwQypnh1KRJ3vALlj/mwQqaexs+JkfB5teKHDpMco9wLLTzVsA+gA/tSA3FGc\n\t FYT/GUmKcq9yQ==","Date":"Thu, 9 Apr 2026 16:57:06 +0100","From":"Conor Dooley ","To":"radu.sabau@analog.com","Cc":"Lars-Peter Clausen ,\n Michael Hennerich ,\n Jonathan Cameron , David Lechner ,\n Nuno =?iso-8859-1?q?S=E1?= ,\n Andy Shevchenko , Rob Herring ,\n Krzysztof Kozlowski , Conor Dooley ,\n Uwe =?iso-8859-1?q?Kleine-K=F6nig?= ,\n Liam Girdwood , Mark Brown ,\n Linus Walleij , Bartosz Golaszewski ,\n Philipp Zabel , Jonathan Corbet ,\n Shuah Khan , linux-iio@vger.kernel.org,\n devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,\n linux-pwm@vger.kernel.org, linux-gpio@vger.kernel.org,\n linux-doc@vger.kernel.org","Subject":"Re: [PATCH v7 1/6] dt-bindings: iio: adc: add AD4691 family","Message-ID":"<20260409-headwear-condense-c119f423095b@spud>","References":"\n <20260409-ad4692-multichannel-sar-adc-driver-v7-0-be375d4df2c5@analog.com>\n <20260409-ad4692-multichannel-sar-adc-driver-v7-1-be375d4df2c5@analog.com>","Precedence":"bulk","X-Mailing-List":"linux-gpio@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha512;\n\tprotocol=\"application/pgp-signature\"; boundary=\"6AiVT6msxNHZX0tI\"","Content-Disposition":"inline","In-Reply-To":"\n <20260409-ad4692-multichannel-sar-adc-driver-v7-1-be375d4df2c5@analog.com>"}}]