[{"id":3675357,"web_url":"http://patchwork.ozlabs.org/comment/3675357/","msgid":"<0d32e594-8cca-4d59-b838-442ce2cad394@baylibre.com>","list_archive_url":null,"date":"2026-04-09T14:48:06","subject":"Re: [PATCH v2] boot/fit: fix misleading comment","submitter":{"id":87228,"url":"http://patchwork.ozlabs.org/api/people/87228/","name":"David Lechner","email":"dlechner@baylibre.com"},"content":"On 4/9/26 8:15 AM, Julien Stephan wrote:\n> When load address is specified but set to 0, we ignore it and load in\n> place instead. The current comment is misleading, so update it.\n> \n> Signed-off-by: Julien Stephan \n> ---\n> It turns out that the else is not useless. The comment associated to it,\n> was misleading, so update the comment instead of removing the else\n> branch\n> ---\n> Changes in v2:\n> - update comment instead of removing else branch\n> - Link to v1: https://lore.kernel.org/r/20260324-boot-fit-fix-8-byte-alignement-for-overlays-v1-1-257b132b6bda@baylibre.com\n> ---\n> boot/image-fit.c | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/boot/image-fit.c b/boot/image-fit.c\n> index 067ad236081..2d2709aa5b1 100644\n> --- a/boot/image-fit.c\n> +++ b/boot/image-fit.c\n> @@ -2282,7 +2282,7 @@ int fit_image_load(struct bootm_headers *images, ulong addr,\n> \t\tprintf(\" Loading %s from 0x%08lx to 0x%08lx\\n\",\n> \t\t prop_name, data, load);\n> \t} else {\n> -\t\tload = data;\t/* No load address specified */\n> +\t\tload = data;\t/* load address specified but set to 0 */\n\nIt would be even more clear to me if it said something like:\n\n\"fit_image_get_load() succeeded but it set load address to 0\".\n\n\n> \t}\n> \n> \tcomp = IH_COMP_NONE;\n> \n> ---\n> base-commit: f0000b4a57e9edf8ff8454b9056d767466dff57f\n> change-id: 20260324-boot-fit-fix-8-byte-alignement-for-overlays-381b0a17bf4e\n> \n> Best regards,","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=baylibre-com.20251104.gappssmtp.com\n header.i=@baylibre-com.20251104.gappssmtp.com header.a=rsa-sha256\n header.s=20251104 header.b=InpK25Dj;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=none (p=none dis=none) header.from=baylibre.com","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=baylibre-com.20251104.gappssmtp.com\n header.i=@baylibre-com.20251104.gappssmtp.com header.b=\"InpK25Dj\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=none (p=none dis=none) header.from=baylibre.com","phobos.denx.de;\n spf=pass smtp.mailfrom=dlechner@baylibre.com"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fs2qT4Y4Lz1yCv\n\tfor ; Fri, 10 Apr 2026 00:48:21 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id C30378407E;\n\tThu, 9 Apr 2026 16:48:12 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id 1F1DD84099; Thu, 9 Apr 2026 16:48:12 +0200 (CEST)","from mail-ot1-x335.google.com (mail-ot1-x335.google.com\n [IPv6:2607:f8b0:4864:20::335])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 934FE83CF5\n for ; Thu, 9 Apr 2026 16:48:09 +0200 (CEST)","by mail-ot1-x335.google.com with SMTP id\n 46e09a7af769-7dbcd61429cso463857a34.2\n for ; Thu, 09 Apr 2026 07:48:09 -0700 (PDT)","from ?IPV6:2600:8803:e7e4:500:a548:cf0c:d054:fd01?\n ([2600:8803:e7e4:500:a548:cf0c:d054:fd01])\n by smtp.gmail.com with ESMTPSA id\n 46e09a7af769-7dbfc1cb79esm4940415a34.15.2026.04.09.07.48.07\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Thu, 09 Apr 2026 07:48:07 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=baylibre-com.20251104.gappssmtp.com; s=20251104; t=1775746088;\n x=1776350888;\n darn=lists.denx.de;\n h=content-transfer-encoding:in-reply-to:from:content-language\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :from:to:cc:subject:date:message-id:reply-to;\n bh=dA2BEfvSYiDFfXDP8hmBc6qmvHdhWLAahf8w4Wg9Z94=;\n b=InpK25DjCIKGfhMcrclsoLsrNGbge0ovkzmi5fE3O2yBbgbA2tvh2mwROxVrc1l4Kn\n YvUNvhhdqU9D8pRayKzobmgGOI9mLEWNxC5OC4Jai7QA4KAT21rHR5euXuoU4J9ibo+P\n LwEN/89CshtQt5UuxzaR6Zs9nyS3CpkFTKtwyhUAaxBCkGH3Ep0qJ1GXReRsxQVfqL2m\n ZtpzPxw5X15CRjpJIzekpDunaULNU8pYnCuivRw4Ba7UEJ9e1eCR02njFwk2YPK9ZEiU\n 4V6IElLYGV33xvmWFMProqsdY7IndnBF85D9Dm58Gn653lB+FN2DR6fnUKroizsn3jlF\n y1Bg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775746088; x=1776350888;\n h=content-transfer-encoding:in-reply-to:from:content-language\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=dA2BEfvSYiDFfXDP8hmBc6qmvHdhWLAahf8w4Wg9Z94=;\n b=V5yUrhCojNgyEARz3758CUm9IFrkk+NXnR1e2iyAguKQluGEeyCCWmGy8otrUEWr+Y\n fDgvaT+W3hqb+kY/jGz2/ms2AIL5+W+x96n14G3HXIBs74Zzp2KeDhHnslUoX+DdQQ3Q\n 9svh6/ZcbDDuco1e+D1YKkhrP17QHO1UaH4yC3iad3ChskWGrtLDVfD/QWQL5szQng0Q\n HZGxgcJLBQl1ANvH+aczEttXnsBiLTpBf2H5JshAq1rbVTSDrU1wPV4h88AT160cu5KI\n 9dYwo7Wp3PA/JX83YnN8baLfRbWA7rMM/LG80TKQC7c7vDba1V6D6cinF19DcKogn3q7\n ZOJQ==","X-Forwarded-Encrypted":"i=1;\n AJvYcCXEzspldRp2flbQK6gLYtFEZ6fNz6iDKruoxeGXzICeV/OZjslzy40oN2YRsldzBX4Tej5RL/8=@lists.denx.de","X-Gm-Message-State":"AOJu0YzTXKEDaxcFFJy9LD2TnFbp9aT5ApJ5r37Y/UUgMjLTp570TW9T\n IohDJ5vW3twE0Lq1RLFblnPg6wvAw0BkGaXyxoNMeLgaHdWlGNJwZrm5ozFAVjH/5w8=","X-Gm-Gg":"AeBDiesCpXq4B7LGycc8XRSWZ8VHr8KYT4UcpUmttRbDCoci2qjkPbzhw4DkTWjGNTT\n Z/WrrBfHQkFwup920HOjCapXrbnlXVuBxc2HQ/T5TbCck2QOOHh1NnBueFx2tC8d317mJlHOUCg\n kovtPr7rMb/rG6UT5fdAUU0l6d8psI1gQlE8xNW+xWoXFCTzwE0Hf9wjQEI6ePeY/0bF8pnhdlt\n V9c1YWPPeTkDjSS7+IVbw9/hmsxrZkTXpmsn0tJCbkAClkqFPrS2PQlP6MF+QsBb96d8o3ZMREo\n +OcI+7e7fCpM+YLxs9papyFWXHGeFm9s2o32Br9muCpq8M31UjrzqLMVXvkllXroK8cFQttChlJ\n Sk8kBZ0CG7qGYw+rWM57nkVtp+Z40Of348cWdblyjGv5aOTZkTS+HYWwzsaYJagtT2DVs7YIKEv\n Os8WUHetcbS6zutxRDRPzDU0EzWqn1NdY9ibq3gHzukvxNfPl7YMG+8OuXycxQMvbnEaQaz1+yk\n g==","X-Received":"by 2002:a05:6830:82ab:b0:7d7:f146:873a with SMTP id\n 46e09a7af769-7dc16ded8demr2247450a34.2.1775746088293;\n Thu, 09 Apr 2026 07:48:08 -0700 (PDT)","Message-ID":"<0d32e594-8cca-4d59-b838-442ce2cad394@baylibre.com>","Date":"Thu, 9 Apr 2026 09:48:06 -0500","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v2] boot/fit: fix misleading comment","To":"Julien Stephan , u-boot@lists.denx.de","Cc":"GSS_MTK_Uboot_upstream ,\n Tom Rini , Quentin Schulz ,\n Marek Vasut ,\n James Hilliard ","References":"\n <20260409-boot-fit-fix-8-byte-alignement-for-overlays-v2-1-32a7878e134a@baylibre.com>","Content-Language":"en-US","From":"David Lechner ","In-Reply-To":"\n <20260409-boot-fit-fix-8-byte-alignement-for-overlays-v2-1-32a7878e134a@baylibre.com>","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"7bit","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}}]