[{"id":3675446,"web_url":"http://patchwork.ozlabs.org/comment/3675446/","msgid":"<20260409163404.GQ41863@bill-the-cat>","list_archive_url":null,"date":"2026-04-09T16:34:04","subject":"Re: [PATCH 7/9] board: hpe: Add GSC board support","submitter":{"id":65875,"url":"http://patchwork.ozlabs.org/api/people/65875/","name":"Tom Rini","email":"trini@konsulko.com"},"content":"On Wed, Apr 08, 2026 at 07:24:19PM +0000, Jorge Cisneros wrote:\n\n> Add board support for the HPE GSC (Gen Server Controller), the BMC\n> SoC used in HPE Gen12 ProLiant and Synergy servers.\n> \n> Board files include:\n> - gsc_board.c: Board init, DRAM sizing from Denali memory controller,\n>   MAC address provisioning from memory-mapped EEPROM, and FDT fixups\n>   for network configuration based on CPLD xregisters\n> - common-phy.c: Shared Ethernet/DisplayPort PHY initialization with\n>   configurable transmitter amplitude and de-emphasis\n> - server_id.c: Custom command to read server identification from CPLD\n> - gsc.env: Default SPI flash boot environment\n> - gsc.h: Board configuration header with GICv3 and spin-table addresses\n> \n> Signed-off-by: Jorge Cisneros <jorge.cisneros@hpe.com>\n[snip]\n> +int board_init(void)\n> +{\n> +\treturn 0;\n> +}\n\nI think you can just disable CONFIG_BOARD_INIT in the defconfig instead.","headers":{"Return-Path":"<u-boot-bounces@lists.denx.de>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=konsulko.com header.i=@konsulko.com header.a=rsa-sha256\n header.s=google header.b=tEOlEoQ3;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=konsulko.com","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=konsulko.com header.i=@konsulko.com\n header.b=\"tEOlEoQ3\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=konsulko.com","phobos.denx.de;\n spf=pass smtp.mailfrom=trini@konsulko.com"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fs7Nr5mSZz1yCv\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 10 Apr 2026 04:14:04 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 53B9C8421A;\n\tThu,  9 Apr 2026 20:12:36 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id 15B1984099; Thu,  9 Apr 2026 18:34:12 +0200 (CEST)","from mail-oa1-x36.google.com (mail-oa1-x36.google.com\n [IPv6:2001:4860:4864:20::36])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id C7CAA83CF5\n for <u-boot@lists.denx.de>; Thu,  9 Apr 2026 18:34:09 +0200 (CEST)","by mail-oa1-x36.google.com with SMTP id\n 586e51a60fabf-415e568a7ecso411450fac.0\n for <u-boot@lists.denx.de>; Thu, 09 Apr 2026 09:34:09 -0700 (PDT)","from bill-the-cat (fixed-189-203-106-235.totalplay.net.\n [189.203.106.235]) by smtp.gmail.com with ESMTPSA id\n 5614622812f47-476bb506178sm2570442b6e.10.2026.04.09.09.34.05\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 09 Apr 2026 09:34:07 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,\n SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=konsulko.com; s=google; t=1775752448; x=1776357248; darn=lists.denx.de;\n h=in-reply-to:content-disposition:mime-version:references:message-id\n :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to;\n bh=PdrIZF8Q64iwZ6utWil5Nr8xqvULJXBOj3XZtHXf2e8=;\n b=tEOlEoQ3ea7PFpM0BER3kKXF0eQon5saWLr/mvmkAp6LnZpAYTtoSdTCzUFcizFYbS\n wQzRiOM3fK/HtXJ9dnHgi8FcimDiC+heFSt7vDEBJhJLjMgT35nS+aIEfW4L5OAabdiI\n vlHFwUXxSfnAS2/dGRyMzn23xnPTz5X/26JI4=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775752448; x=1776357248;\n h=in-reply-to:content-disposition:mime-version:references:message-id\n :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=PdrIZF8Q64iwZ6utWil5Nr8xqvULJXBOj3XZtHXf2e8=;\n b=nCbn3gfUHMye4rOsv1HnoT62dM6YnyyHmIPDlsWWqgVU6N28bwn/Ijdux5DTtIz+/W\n yugWyV4ThhwK+l6leYR7Rg0XMr+IGK51xkcMw+72YR45PlWmKWac9OQD5omjN4LJfz6L\n b8wp0mPNA/LawtzdYaXEO56/kNcW72Bkg5JFYqB55eSSHVkOGLtwFXu8GLOdPrI88Hnz\n mdfxyAmJe8RaTnuvede+rp5rW+U4mqM4X3Z+VRVCCJPqHRYUfXgg5wi50v40R5vNFXxU\n ZmP27isnCElwl3uYRiQ1IB49zREyiOowY1foCxLXK4Ur6wkfcquQkf0zXlr9e1LEz7m6\n Vbyw==","X-Gm-Message-State":"AOJu0Yx0Z0MU0h4SVx/cBEWrxoN4ZPBbu20rA9JpXeYIXWMBXu6rnLrH\n TSgPUFeZFNLrIjIs6upmY9Hq3yEK2Mex9TZ2hbx+47lV4uTgqRLYf6AWvInbEL/n0MU=","X-Gm-Gg":"AeBDievfMwRcFvgzNLgozi1gxYzBzWa3xR+yhCiOncKPEmAGiqFJjB8ISIyeo3/t3oN\n mFVuMW2YWji8Z6QvoTYe7dRq8A8l9ejzJ4myWrTCIOZVHqOR7GLjbTYK2RkX/o2ThxDT/dHJCwq\n PIo9GRG8bMnrK6U7+R/W/+9QqyuuUX2L55RWI7ygOHQafWO5cl20u3US5BxvamUjlL0arjDBBPD\n XX9J8CjaUpqD9HAbHN3DIWmclIDi0TwG+KVTbEFPpOoIVG1cS40dPH7iGRORXFcmRDSYO7BPSBP\n 7rGeOocUv61DcNVOXNKrDuPC5Pl5KHrLarvMFgo0rqWcv6fNLhoHzVJhsKC7IlRfLKeJb64vRNQ\n sb2XL/aJdZwsiWC/U4DBrDR+sf4fgQWxij5qftt2cTSufGIHSNvdPi4N+KmnNPEGAQ7B7dA1zsh\n 6KqvFsPtk3hoXQ8fI5JYBUmF1Yz5EXGkqX11uyDQCOPDDi7ts8hk5lnrs/7pWqapwHSItgp8kC3\n 9gFmoEQYJEBiSrx2DUqGq0gexmDb08Z3KVqFLizg5GbPpr7ILgg1KrHtSPVKA==","X-Received":"by 2002:a05:6808:c1ee:b0:474:b050:bf5d with SMTP id\n 5614622812f47-47724489c42mr1957220b6e.43.1775752448396;\n Thu, 09 Apr 2026 09:34:08 -0700 (PDT)","Date":"Thu, 9 Apr 2026 10:34:04 -0600","From":"Tom Rini <trini@konsulko.com>","To":"Jorge Cisneros <jorge.cisneros@hpe.com>","Cc":"u-boot@lists.denx.de,\n Rayagonda Kokatanur <rayagonda.kokatanur@broadcom.com>,\n Jean-Marie Verdun <verdun@hpe.com>, Nick Hawkins <nick.hawkins@hpe.com>,\n Casey Connolly <casey.connolly@linaro.org>, Anshul Dalal <anshuld@ti.com>,\n Tien Fong Chee <tien.fong.chee@altera.com>, Peng Fan <peng.fan@nxp.com>,\n Alif Zakuan Yuslaimi <alif.zakuan.yuslaimi@altera.com>,\n Tingting Meng <tingting.meng@altera.com>, Alice Guo <alice.guo@nxp.com>,\n Quentin Schulz <quentin.schulz@cherry.de>,\n Ilias Apalodimas <ilias.apalodimas@linaro.org>,\n Tony Dinh <mibodhi@gmail.com>,\n Marek Vasut <marek.vasut+renesas@mailbox.org>,\n Stefan Roese <stefan.roese@mailbox.org>,\n Svyatoslav Ryhel <clamor95@gmail.com>,\n Patrice Chotard <patrice.chotard@foss.st.com>,\n Mattijs Korpershoek <mkorpershoek@kernel.org>,\n Shmuel Leib Melamud <smelamud@redhat.com>,\n Lukasz Majewski <lukma@nabladev.com>,\n Sumit Garg <sumit.garg@oss.qualcomm.com>, Chen-Yu Tsai <wens@kernel.org>,\n Justin Klaassen <justin@tidylabs.net>,\n Neha Malcom Francis <n-francis@ti.com>,\n Jamie Gibbons <jamie.gibbons@microchip.com>,\n Leo Yu-Chi Liang <ycliang@andestech.com>,\n Jerome Forissier <jerome.forissier@arm.com>,\n Simon Glass <sjg@chromium.org>,\n Neil Armstrong <neil.armstrong@linaro.org>, Yao Zi <me@ziyao.cc>,\n Kuan-Wei Chiu <visitorckw@gmail.com>,\n \"Kory Maincent (TI.com)\" <kory.maincent@bootlin.com>,\n Raymond Mao <raymond.mao@riscstar.com>,\n Philip Molloy <philip.molloy@analog.com>","Subject":"Re: [PATCH 7/9] board: hpe: Add GSC board support","Message-ID":"<20260409163404.GQ41863@bill-the-cat>","References":"<20260408-hpe-gsc-upstream-v1-0-2be1fb7cbbfc@hpe.com>\n <20260408-hpe-gsc-upstream-v1-7-2be1fb7cbbfc@hpe.com>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha512;\n protocol=\"application/pgp-signature\"; boundary=\"guJEybmWzvla/ba/\"","Content-Disposition":"inline","In-Reply-To":"<20260408-hpe-gsc-upstream-v1-7-2be1fb7cbbfc@hpe.com>","X-Clacks-Overhead":"GNU Terry Pratchett","X-Mailman-Approved-At":"Thu, 09 Apr 2026 20:12:34 +0200","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion <u-boot.lists.denx.de>","List-Unsubscribe":"<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>","List-Archive":"<https://lists.denx.de/pipermail/u-boot/>","List-Post":"<mailto:u-boot@lists.denx.de>","List-Help":"<mailto:u-boot-request@lists.denx.de?subject=help>","List-Subscribe":"<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" <u-boot-bounces@lists.denx.de>","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}}]