[{"id":3675916,"web_url":"http://patchwork.ozlabs.org/comment/3675916/","msgid":"","list_archive_url":null,"date":"2026-04-10T15:02:27","subject":"Re: [PATCH 2/2] accel/mshv: return correct errno value from\n ioeventfd failure","submitter":{"id":90753,"url":"http://patchwork.ozlabs.org/api/people/90753/","name":"Magnus Kulke","email":"magnuskulke@linux.microsoft.com"},"content":"On Thu, Apr 09, 2026 at 11:53:07AM +0000, Aastha Rawat wrote:\n> Returning the raw ioctl return value results in misleading error\n> message. Ensure that actual failure reason is propagated by returning\n> -errno for ioeventfd failure.\n> \n> Signed-off-by: Aastha Rawat \n> ---\n> accel/mshv/mshv-all.c | 7 ++++++-\n> 1 file changed, 6 insertions(+), 1 deletion(-)\n> \n> diff --git a/accel/mshv/mshv-all.c b/accel/mshv/mshv-all.c\n> index e1a8d62f8d..58af674bd9 100644\n> --- a/accel/mshv/mshv-all.c\n> +++ b/accel/mshv/mshv-all.c\n> @@ -275,7 +275,12 @@ static int ioeventfd(int vm_fd, int event_fd, uint64_t addr, Datamatch dm,\n> }\n> }\n> \n> - return ioctl(vm_fd, MSHV_IOEVENTFD, &args);\n> + int ret = ioctl(vm_fd, MSHV_IOEVENTFD, &args);\n> + if (ret < 0) {\n> + return -errno;\n> + }\n> +\n> + return ret;\n> }\n> \n> static int unregister_ioevent(int vm_fd, int event_fd, uint64_t mmio_addr,\n> \n\nReviewed-by: Magnus Kulke ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=linux.microsoft.com header.i=@linux.microsoft.com\n header.a=rsa-sha256 header.s=default header.b=dg1+2+dR;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fsg5n6HRGz1yGb\n\tfor ; Sat, 11 Apr 2026 01:02:53 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wBDNU-0004Gq-Fb; Fri, 10 Apr 2026 11:02:36 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wBDNT-0004EJ-6j\n for qemu-devel@nongnu.org; Fri, 10 Apr 2026 11:02:35 -0400","from linux.microsoft.com ([13.77.154.182])\n by eggs.gnu.org with esmtp (Exim 4.90_1)\n (envelope-from ) id 1wBDNR-00013C-L9\n for qemu-devel@nongnu.org; Fri, 10 Apr 2026 11:02:34 -0400","from example.com (unknown [167.220.208.74])\n by linux.microsoft.com (Postfix) with ESMTPSA id 628AF20B710C;\n Fri, 10 Apr 2026 08:02:30 -0700 (PDT)"],"DKIM-Filter":"OpenDKIM Filter v2.11.0 linux.microsoft.com 628AF20B710C","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;\n s=default; t=1775833351;\n bh=ObFwLXSfg3jNCgdwQVBI5LkJM0+S7ryTW7yysNqlMEI=;\n h=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n b=dg1+2+dRm8vi7JYiyDHc0y+sv9I3VvqKOJKuGMN9UU/5SPqJ9Ul9R3YnZFtd+aDTP\n C2fQ64IC23ab/KeSOB+cybhp/3Lv1rRAEbjlfzCOeQfvWeYPVQIx65bAIwfS2Lc4aA\n ZhOq2fpv15gKwT4eWERM0Na5oAhLFftUStq/rwkI=","Date":"Fri, 10 Apr 2026 17:02:27 +0200","From":"Magnus Kulke ","To":"Aastha Rawat ","Cc":"qemu-devel@nongnu.org, Wei Liu ","Subject":"Re: [PATCH 2/2] accel/mshv: return correct errno value from\n ioeventfd failure","Message-ID":"","References":"<20260409-fix_ioevent-v1-0-053b810ae6fb@linux.microsoft.com>\n <20260409-fix_ioevent-v1-2-053b810ae6fb@linux.microsoft.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20260409-fix_ioevent-v1-2-053b810ae6fb@linux.microsoft.com>","Received-SPF":"pass client-ip=13.77.154.182;\n envelope-from=magnuskulke@linux.microsoft.com; helo=linux.microsoft.com","X-Spam_score_int":"-42","X-Spam_score":"-4.3","X-Spam_bar":"----","X-Spam_report":"(-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]