[{"id":3675247,"web_url":"http://patchwork.ozlabs.org/comment/3675247/","msgid":"<adeEHeacVSfEKp-V@redhat.com>","list_archive_url":null,"date":"2026-04-09T10:49:01","subject":"Re: [PULL 1/1] virtio-scsi: pass the same cdb_size to\n virtio_scsi_pop_req and virtio_scsi_handle_cmd_req_prepare","submitter":{"id":2694,"url":"http://patchwork.ozlabs.org/api/people/2694/","name":"Daniel P. Berrangé","email":"berrange@redhat.com"},"content":"On Thu, Apr 09, 2026 at 12:33:09PM +0200, Paolo Bonzini wrote:\n> Ensure that there is no allocation/usage mismatch when requests\n> are processed in virtio_scsi_handle_cmd_vq.  To do this,\n> retrieve the value once and pass it to both functions.\n> \n> For other calls to virtio_scsi_pop_req the extra size\n> can be 0, because control and event requests fit\n> entirely in VirtIOSCSIReq.\n> \n> Reported-by: Jihe Wang <wangjihe.mail@gmail.com>\n> Tested-by: Jihe Wang <wangjihe.mail@gmail.com>\n> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>\n> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>\n> ---\n>  hw/scsi/virtio-scsi.c | 26 +++++++++++++++-----------\n>  1 file changed, 15 insertions(+), 11 deletions(-)\n\nThis issue is tagged CVE-2026-5763   - if possible can we get that\nin the commit message before merging.\n\n> \n> diff --git a/hw/scsi/virtio-scsi.c b/hw/scsi/virtio-scsi.c\n> index 774968d8c70..6c737680119 100644\n> --- a/hw/scsi/virtio-scsi.c\n> +++ b/hw/scsi/virtio-scsi.c\n> @@ -227,16 +227,16 @@ static int virtio_scsi_parse_req(VirtIOSCSIReq *req,\n>      return 0;\n>  }\n>  \n> -static VirtIOSCSIReq *virtio_scsi_pop_req(VirtIOSCSI *s, VirtQueue *vq, QemuMutex *vq_lock)\n> +static VirtIOSCSIReq *virtio_scsi_pop_req(VirtIOSCSI *s, VirtQueue *vq, size_t extra_req_size,\n> +                                          QemuMutex *vq_lock)\n>  {\n> -    VirtIOSCSICommon *vs = (VirtIOSCSICommon *)s;\n>      VirtIOSCSIReq *req;\n>  \n>      if (vq_lock) {\n>          qemu_mutex_lock(vq_lock);\n>      }\n>  \n> -    req = virtqueue_pop(vq, sizeof(VirtIOSCSIReq) + vs->cdb_size);\n> +    req = virtqueue_pop(vq, sizeof(VirtIOSCSIReq) + extra_req_size);\n>  \n>      if (vq_lock) {\n>          qemu_mutex_unlock(vq_lock);\n> @@ -682,7 +682,7 @@ static void virtio_scsi_handle_ctrl_vq(VirtIOSCSI *s, VirtQueue *vq)\n>  {\n>      VirtIOSCSIReq *req;\n>  \n> -    while ((req = virtio_scsi_pop_req(s, vq, &s->ctrl_lock))) {\n> +    while ((req = virtio_scsi_pop_req(s, vq, 0, &s->ctrl_lock))) {\n>          virtio_scsi_handle_ctrl_req(s, req);\n>      }\n>  }\n> @@ -850,13 +850,14 @@ static void virtio_scsi_fail_cmd_req(VirtIOSCSIReq *req)\n>      virtio_scsi_complete_cmd_req(req);\n>  }\n>  \n> -static int virtio_scsi_handle_cmd_req_prepare(VirtIOSCSI *s, VirtIOSCSIReq *req)\n> +static int virtio_scsi_handle_cmd_req_prepare(VirtIOSCSI *s, VirtIOSCSIReq *req,\n> +                                              size_t cdb_size)\n>  {\n>      VirtIOSCSICommon *vs = VIRTIO_SCSI_COMMON(s);\n>      SCSIDevice *d;\n>      int rc;\n>  \n> -    rc = virtio_scsi_parse_req(req, sizeof(VirtIOSCSICmdReq) + vs->cdb_size,\n> +    rc = virtio_scsi_parse_req(req, sizeof(VirtIOSCSICmdReq) + cdb_size,\n>                                 sizeof(VirtIOSCSICmdResp) + vs->sense_size);\n>      if (rc < 0) {\n>          if (rc == -ENOTSUP) {\n> @@ -878,7 +879,7 @@ static int virtio_scsi_handle_cmd_req_prepare(VirtIOSCSI *s, VirtIOSCSIReq *req)\n>      }\n>      req->sreq = scsi_req_new(d, req->req.cmd.tag,\n>                               virtio_scsi_get_lun(req->req.cmd.lun),\n> -                             req->req.cmd.cdb, vs->cdb_size, req);\n> +                             req->req.cmd.cdb, cdb_size, req);\n>  \n>      if (req->sreq->cmd.mode != SCSI_XFER_NONE\n>          && (req->sreq->cmd.mode != req->mode ||\n> @@ -913,12 +914,15 @@ static void virtio_scsi_handle_cmd_vq(VirtIOSCSI *s, VirtQueue *vq)\n>      QTAILQ_HEAD(, VirtIOSCSIReq) reqs = QTAILQ_HEAD_INITIALIZER(reqs);\n>  \n>      do {\n> +        VirtIOSCSICommon *vs = (VirtIOSCSICommon *)s;\n> +        size_t cdb_size = qatomic_read(&vs->cdb_size);\n> +\n>          if (suppress_notifications) {\n>              virtio_queue_set_notification(vq, 0);\n>          }\n>  \n> -        while ((req = virtio_scsi_pop_req(s, vq, NULL))) {\n> -            ret = virtio_scsi_handle_cmd_req_prepare(s, req);\n> +        while ((req = virtio_scsi_pop_req(s, vq, cdb_size, NULL))) {\n> +            ret = virtio_scsi_handle_cmd_req_prepare(s, req, cdb_size);\n>              if (!ret) {\n>                  QTAILQ_INSERT_TAIL(&reqs, req, next);\n>              } else if (ret == -EINVAL) {\n> @@ -989,7 +993,7 @@ static void virtio_scsi_set_config(VirtIODevice *vdev,\n>      }\n>  \n>      vs->sense_size = virtio_ldl_p(vdev, &scsiconf->sense_size);\n> -    vs->cdb_size = virtio_ldl_p(vdev, &scsiconf->cdb_size);\n> +    qatomic_set(&vs->cdb_size, virtio_ldl_p(vdev, &scsiconf->cdb_size));\n>  }\n>  \n>  static uint64_t virtio_scsi_get_features(VirtIODevice *vdev,\n> @@ -1050,7 +1054,7 @@ static void virtio_scsi_push_event(VirtIOSCSI *s,\n>          return;\n>      }\n>  \n> -    req = virtio_scsi_pop_req(s, vs->event_vq, &s->event_lock);\n> +    req = virtio_scsi_pop_req(s, vs->event_vq, 0, &s->event_lock);\n>      WITH_QEMU_LOCK_GUARD(&s->event_lock) {\n>          if (!req) {\n>              s->events_dropped = true;\n> -- \n> 2.53.0\n> \n> \n\nWith regards,\nDaniel","headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=PGWJF1zF;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4frxX33WGyz1xy1\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 09 Apr 2026 20:49:39 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wAmww-0007P6-8w; Thu, 09 Apr 2026 06:49:26 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <berrange@redhat.com>)\n id 1wAmwn-0007FA-9A\n for qemu-devel@nongnu.org; Thu, 09 Apr 2026 06:49:18 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <berrange@redhat.com>)\n id 1wAmwj-0006Y2-OZ\n for qemu-devel@nongnu.org; Thu, 09 Apr 2026 06:49:15 -0400","from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com\n (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by\n relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n cipher=TLS_AES_256_GCM_SHA384) id us-mta-489-dPFG4SeIMbm88SyB1XkT7w-1; Thu,\n 09 Apr 2026 06:49:06 -0400","from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com\n (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS\n id A794E1800345; Thu,  9 Apr 2026 10:49:05 +0000 (UTC)","from redhat.com (headnet01.pony-001.prod.iad2.dc.redhat.com\n [10.2.32.101])\n by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with\n ESMTPS\n id 439A71800B7F; Thu,  9 Apr 2026 10:49:04 +0000 (UTC)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1775731750;\n h=from:from:reply-to:reply-to:subject:subject:date:date:\n message-id:message-id:to:to:cc:cc:mime-version:mime-version:\n content-type:content-type:in-reply-to:in-reply-to:  references:references;\n bh=3x31sPYFGovHrBN4EFAaaFCFYdPWzfdaBZtVag+fQqg=;\n b=PGWJF1zFRw25SRpe1rR28BBfudAjE+z3Cbxhqh/mmPqy9ClMg9o9UoRXTiK7JVEWArZ2qG\n uFvP08fhnIlEaYemyodJ4jLDQ+rZoOaxOPWvh5lln/Cw3gFHy/sT5adCyrJw2O3b+oNBoU\n wkGHyHogUq1Ep/aTmMu9vsMWqfYv52Q=","X-MC-Unique":"dPFG4SeIMbm88SyB1XkT7w-1","X-Mimecast-MFC-AGG-ID":"dPFG4SeIMbm88SyB1XkT7w_1775731746","Date":"Thu, 9 Apr 2026 11:49:01 +0100","From":"Daniel =?utf-8?b?UC4gQmVycmFuZ8Op?= <berrange@redhat.com>","To":"Paolo Bonzini <pbonzini@redhat.com>","Cc":"qemu-devel@nongnu.org, Jihe Wang <wangjihe.mail@gmail.com>,\n Stefan Hajnoczi <stefanha@redhat.com>","Subject":"Re: [PULL 1/1] virtio-scsi: pass the same cdb_size to\n virtio_scsi_pop_req and virtio_scsi_handle_cmd_req_prepare","Message-ID":"<adeEHeacVSfEKp-V@redhat.com>","References":"<20260409103310.1884968-1-pbonzini@redhat.com>\n <20260409103310.1884968-2-pbonzini@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20260409103310.1884968-2-pbonzini@redhat.com>","User-Agent":"Mutt/2.2.14 (2025-02-20)","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.111","Received-SPF":"pass client-ip=170.10.129.124;\n envelope-from=berrange@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-25","X-Spam_score":"-2.6","X-Spam_bar":"--","X-Spam_report":"(-2.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.54,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development <qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<https://lists.nongnu.org/archive/html/qemu-devel>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Reply-To":"Daniel =?utf-8?b?UC4gQmVycmFuZ8Op?= <berrange@redhat.com>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}},{"id":3675248,"web_url":"http://patchwork.ozlabs.org/comment/3675248/","msgid":"<CABgObfZ=dGwYMNsxvJb6pd++UQGhZj5D22qs42Z30vce3R9HMw@mail.gmail.com>","list_archive_url":null,"date":"2026-04-09T10:53:37","subject":"Re: [PULL 1/1] virtio-scsi: pass the same cdb_size to\n virtio_scsi_pop_req and virtio_scsi_handle_cmd_req_prepare","submitter":{"id":2701,"url":"http://patchwork.ozlabs.org/api/people/2701/","name":"Paolo Bonzini","email":"pbonzini@redhat.com"},"content":"On Thu, Apr 9, 2026 at 12:49 PM Daniel P. Berrangé <berrange@redhat.com> wrote:\n>\n> On Thu, Apr 09, 2026 at 12:33:09PM +0200, Paolo Bonzini wrote:\n> > Ensure that there is no allocation/usage mismatch when requests\n> > are processed in virtio_scsi_handle_cmd_vq.  To do this,\n> > retrieve the value once and pass it to both functions.\n> >\n> > For other calls to virtio_scsi_pop_req the extra size\n> > can be 0, because control and event requests fit\n> > entirely in VirtIOSCSIReq.\n> >\n> > Reported-by: Jihe Wang <wangjihe.mail@gmail.com>\n> > Tested-by: Jihe Wang <wangjihe.mail@gmail.com>\n> > Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>\n> > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>\n> > ---\n> >  hw/scsi/virtio-scsi.c | 26 +++++++++++++++-----------\n> >  1 file changed, 15 insertions(+), 11 deletions(-)\n>\n> This issue is tagged CVE-2026-5763   - if possible can we get that\n> in the commit message before merging.\n\nDone, new commit hash is 79971302935472232a68073faddb085177e3ca54.\n\nPaolo","headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=GjfrXOAy;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=google header.b=r1bv6xqS;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4frxdq1lgfz1yD3\n\tfor <incoming@patchwork.ozlabs.org>; Thu, 09 Apr 2026 20:54:37 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wAn1K-00009G-P1; Thu, 09 Apr 2026 06:53:58 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <pbonzini@redhat.com>)\n id 1wAn1I-000097-Vg\n for qemu-devel@nongnu.org; Thu, 09 Apr 2026 06:53:57 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <pbonzini@redhat.com>)\n id 1wAn1G-0007eC-1H\n for qemu-devel@nongnu.org; Thu, 09 Apr 2026 06:53:56 -0400","from mail-wr1-f70.google.com (mail-wr1-f70.google.com\n [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-563-_LNMLL_xOSup3YJdwd4c0w-1; Thu, 09 Apr 2026 06:53:51 -0400","by mail-wr1-f70.google.com with SMTP id\n ffacd0b85a97d-43d14a4bcd0so982073f8f.3\n for <qemu-devel@nongnu.org>; Thu, 09 Apr 2026 03:53:51 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1775732032;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=aH8EYGVmRIg72V1Pgnm38S53Ly8d3QbMpZRRw8MwNaM=;\n b=GjfrXOAyJTbvK7CPzBuHrQJlmSBuXWy8270Rv9/01VXDFLeM2JllEIj4tfHaLnMpOXbd3q\n XYVAiu+CNqX7j9lGA5Gv+iFtNs2owDN39DCMLs11mJpiRjcpQDwbV+ddx9mnj0qwRtSUDM\n OC9qn6mHYwLlx7vtKcSkdnPn6ad1Llw=","v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=redhat.com; s=google; t=1775732030; x=1776336830; darn=nongnu.org;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:from:to:cc:subject:date\n :message-id:reply-to;\n bh=aH8EYGVmRIg72V1Pgnm38S53Ly8d3QbMpZRRw8MwNaM=;\n b=r1bv6xqSCqJ2CBXnf2+quR+TPaHauZ4FoNt2jmJqS+TRSEGEIkmtdl/B63cE2+12sY\n OYQNCdnQqh+8DViqL0wrHD0s5nfpy+gp2MKARu3k8ZE6QSI+4u2x5qkhc7PNDISnSFla\n +CBccxXPbXwrcB5JugooKcn8Bf6eVnLPdbZm2G4WcM89j9zN6L5HFs0AGrSJKzKZ/6QH\n M6FUXW5s5kP0aDaJehP8T2cApzV3ReVC7zbSAbcredceJ6NHJK5rLbLvv32XfZn0Sa/Y\n kykDH0ucLlupH38StQyvGMAKZdMQjVb1AISoAJSgRSBlf6Td77u2GxhXVVbcEqTFTOIB\n Q3fg=="],"X-MC-Unique":"_LNMLL_xOSup3YJdwd4c0w-1","X-Mimecast-MFC-AGG-ID":"_LNMLL_xOSup3YJdwd4c0w_1775732030","ARC-Seal":"i=1; a=rsa-sha256; t=1775732030; cv=none;\n d=google.com; s=arc-20240605;\n b=iH7U+5bospo5Mb3oJcWTBi0qEqsklGOPThBV54htVroA05+TDhmKBiewOTeX3ms+jW\n elkkJh2kfXphUFQhDtk6WeCC7cpRCpGGFZerYH3G7PI/0DiMog5vrQ7qJGV05VqQoOPY\n OF9mFV3ouU5X3HqRj6gXXIBhYyIrpFJUWEaPe6v2JPuS6fiPofMjFRX59lSRVrwrFa0h\n /NRlQB+NOw7AotUSjWRb3QSN/xsxUR9/zIf/THy3IKMEOofsKoOrpyQXTrlFsNOh6Gq2\n lK1bItJSDlOkSFzNXO4JfcSq5fZsEBGx7QeSActkWbdkGBa2QnmJDdrbY5ifHvYURz9B\n 7BZQ==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:dkim-signature;\n bh=aH8EYGVmRIg72V1Pgnm38S53Ly8d3QbMpZRRw8MwNaM=;\n fh=sWcw3HoY1LaCt8qN2YujPvFLN2rsUTf8ZQNrxkcqM6c=;\n b=K6417zDwqRT+JiEeQQY2V2Hgvhe2DJGFImFob14bBAfmwojiJZZxibUePd4CdkMKMJ\n E+TyvVw886ceQbWQV5uRyJ3Qrh4eJmu7lMYCd/JsGkNOjJpwhDLH2Ef9ja463fx+UaRM\n wMPLFrioLx3V5GJJi6GGhfq0YPjTGwCCUw65kxxwLjT+me4npGvL0Sb+YyYYZrG6OsFR\n Bz0OGUMfx34tzRLFAZKymPAW7oMhzJalS55toXc/ouZUpAx32ZYWCGK7oXH3f6z1aqnl\n 7K/ZTRDAAv2QlcEnLD13LYAVdVtO3IJ+13DOTaI2dHUvjWU981j80nbCcYFT6OTug4Ba\n SoTw==; darn=nongnu.org","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775732030; x=1776336830;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=aH8EYGVmRIg72V1Pgnm38S53Ly8d3QbMpZRRw8MwNaM=;\n b=ZmtmABDCYETBCyy4RsQ3DrHD4Ll6RnkvP/wgBcZ17PUXjfCw+Z/NdParTVvWk0Z7UN\n 3IqlkulBnLsnJqy3/oUfET5FsvxBv/bXUIk5ruUDp5fJJGzW6763NyxnaWdRK/+cSWeW\n D+U5G5HS8HUpqtS1PZbmuYVQpE7V2NYKwFLdXSWPYywmDgsmf0RCTsn6CLiU7fmpRU/r\n DTmlelPVgo70qIhAV+Hv0L8+/doP8yiqrEODNwSultFKrlGdaxHXCWmU0HS0Jb/AyTf4\n x/2FFsDQCmi4cF9YKUpqc2k+odtpSmznS0MT+OKsd/uWCLPM7cGSw2p2WRTFMHLIzPnM\n dtlQ==","X-Gm-Message-State":"AOJu0YynlkdXz8d7COZHOTDxamhWBM9UimtI2/CLV9PLFnNkX3jKPRiu\n aU5T8SmzGmnIxMTkNdhIGdFZCIWmpBBIDnzs7znl9h6cc1VqoYwzmC3eCnKRExXkjiCrcy7j72u\n qDSdDj30D4y09N5jmaIIEpNKU/kRF2KiU/XlO437fCWHYd8bWbc2Ec3TKt1WPRA8UM9VPnWMumg\n Ab3/9txQSpkO2N0wuyg7sjhFF0RlYG7HA=","X-Gm-Gg":"AeBDievbyR+VuL7E9DZoYF4Hm4m3aL3Wkt7NDE9VggWwKbz7ZdBemyVO96iXXqwB918\n kWPXhuYjWk0nAGcIiFNKlLbhqM7L9loRA7i7DFyWoGvMq5ZGE1WKWMG+0caK82ZTkV2j0uqnj/Z\n rNqrSnnJACQRCn1kHsm8Zz2TkHU8KD5pbSSGwP1Imi8uPKV8KwXcluXHwU8eNOJjJG0os/lrGA9\n yBYP6HO7vKMbZVN5Ek24OwXz9Pem+ioYnFFceh2VlH7tdQ79z1BoK/PSxOINO1Ij/a7aJ/xl1cf\n i7gK","X-Received":["by 2002:a05:6000:310a:b0:43c:fc5c:a9fc with SMTP id\n ffacd0b85a97d-43d2929dcd9mr36372054f8f.21.1775732030228;\n Thu, 09 Apr 2026 03:53:50 -0700 (PDT)","by 2002:a05:6000:310a:b0:43c:fc5c:a9fc with SMTP id\n ffacd0b85a97d-43d2929dcd9mr36372022f8f.21.1775732029754; Thu, 09 Apr 2026\n 03:53:49 -0700 (PDT)"],"MIME-Version":"1.0","References":"<20260409103310.1884968-1-pbonzini@redhat.com>\n <20260409103310.1884968-2-pbonzini@redhat.com>\n <adeEHeacVSfEKp-V@redhat.com>","In-Reply-To":"<adeEHeacVSfEKp-V@redhat.com>","From":"Paolo Bonzini <pbonzini@redhat.com>","Date":"Thu, 9 Apr 2026 12:53:37 +0200","X-Gm-Features":"AQROBzB5-JU4C8nX2ddRvXfeOXmiZO1W0OcVrhJmf-UI_2t_tl8y9CiC7P9bxHw","Message-ID":"\n <CABgObfZ=dGwYMNsxvJb6pd++UQGhZj5D22qs42Z30vce3R9HMw@mail.gmail.com>","Subject":"Re: [PULL 1/1] virtio-scsi: pass the same cdb_size to\n virtio_scsi_pop_req and virtio_scsi_handle_cmd_req_prepare","To":"=?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= <berrange@redhat.com>","Cc":"qemu-devel@nongnu.org, Jihe Wang <wangjihe.mail@gmail.com>,\n Stefan Hajnoczi <stefanha@redhat.com>","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","Received-SPF":"pass client-ip=170.10.129.124;\n envelope-from=pbonzini@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-25","X-Spam_score":"-2.6","X-Spam_bar":"--","X-Spam_report":"(-2.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.54,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development <qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<https://lists.nongnu.org/archive/html/qemu-devel>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]