[{"id":3675292,"web_url":"http://patchwork.ozlabs.org/comment/3675292/","msgid":"","list_archive_url":null,"date":"2026-04-09T12:35:28","subject":"Re: [Intel-wired-lan] [PATCH net-next v2] iavf: fix kernel-doc\n comment style in iavf_ethtool.c","submitter":{"id":71262,"url":"http://patchwork.ozlabs.org/api/people/71262/","name":"Breno Leitao","email":"leitao@debian.org"},"content":"On Thu, Apr 09, 2026 at 11:30:20AM +0200, Aleksandr Loktionov wrote:\n> iavf_ethtool.c contains 31 kernel-doc comment blocks using the legacy\n> `**/` terminator instead of the correct single `*/`. Two function\n> headers also use a colon separator (`iavf_get_channels:`,\n> `iavf_set_channels:`) instead of the ` - ` dash required by kernel-doc.\n> \n> Additionally several comments embed their return-value descriptions in\n> the body paragraph, producing `scripts/kernel-doc -Wreturn` warnings.\n> Void functions that incorrectly say \"Returns ...\" are also rephrased.\n> \n> Fix all issues across the full file:\n> - Replace every `**/` terminator with `*/`.\n> - Change `function_name:` doc headers to `function_name -`.\n> - Move inline \"Returns ...\" sentences into dedicated `Return:` sections\n> for non-void functions (iavf_get_msglevel, iavf_get_rxnfc,\n> iavf_set_channels, iavf_get_rxfh_key_size, iavf_get_rxfh_indir_size,\n> iavf_get_rxfh, iavf_set_rxfh).\n> - Rephrase body descriptions in void functions that incorrectly said\n> \"Returns ...\" (iavf_get_drvinfo, iavf_get_ringparam, iavf_get_coalesce).\n> - Remove boilerplate body text for iavf_get_rxfh_key_size and\n> iavf_get_rxfh_indir_size; the `Return:` line now conveys the same\n> information without the vague \"Returns the table size.\" sentence.\n> \n> Suggested-by: Anthony L. Nguyen \n> Suggested-by: Leszek Pepiak \n> Signed-off-by: Aleksandr Loktionov \n\nReviewed-by: Breno Leitao ","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=T34IdG67;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::137; helo=smtp4.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4frztX1NlWz1xy1\n\tfor ; Thu, 09 Apr 2026 22:35:47 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id 642514087A;\n\tThu, 9 Apr 2026 12:35:46 +0000 (UTC)","from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id HO95Je1CDF4r; Thu, 9 Apr 2026 12:35:45 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id 91990407F3;\n\tThu, 9 Apr 2026 12:35:45 +0000 (UTC)","from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138])\n by lists1.osuosl.org (Postfix) with ESMTP id 73C5F1F6\n for ; Thu, 9 Apr 2026 12:35:44 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp1.osuosl.org (Postfix) with ESMTP id 59B5581445\n for ; Thu, 9 Apr 2026 12:35:44 +0000 (UTC)","from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id rBKTB_595-8S for ;\n Thu, 9 Apr 2026 12:35:43 +0000 (UTC)","from stravinsky.debian.org (stravinsky.debian.org\n [IPv6:2001:41b8:202:deb::311:108])\n by smtp1.osuosl.org (Postfix) with ESMTPS id 558788143D\n for ; Thu, 9 Apr 2026 12:35:43 +0000 (UTC)","from authenticated user by stravinsky.debian.org with esmtpsa\n (TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256)\n (Exim 4.96) (envelope-from ) id 1wAobc-009CdJ-16;\n Thu, 09 Apr 2026 12:35:32 +0000"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp4.osuosl.org 91990407F3","OpenDKIM Filter v2.11.0 smtp1.osuosl.org 558788143D"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1775738145;\n\tbh=w706NqgBqyMKvr0nVOHn4NlIhTaCVyxRXyIz0wu2eTw=;\n\th=Date:From:To:Cc:References:In-Reply-To:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t From;\n\tb=T34IdG677omdV5Mm+zotG6xSw+781CGS2xI7dj6fZ30bHBqDfZJC8TUbbEcE0edrw\n\t 0br//nxV8ahXiA/glAyqbIri7aMIIQAqo3wJ3V5uol7j3UlzRh20T3qw+KPRVCttLt\n\t 5pEnkQsXLZOWU47gJFHPG3ZuznvMJrSAclX88Od2JWjMCp8xtsn0XvPml8QyUv1FdL\n\t koW3e1ObE3YsZXOo7KPcgPC41IAo1ppjsuDWSecpY5YBtgJvxLc9f2eqIb1QGZaIZh\n\t A4iofW5SBQT/+4NiFqxrj4kQCI8Epxap53gXTr3v3xb8oogMVUvMRlMKTvM4oVZmnd\n\t vm0oO2rBZKaCA==","Received-SPF":"None (mailfrom) identity=mailfrom;\n client-ip=2001:41b8:202:deb::311:108; helo=stravinsky.debian.org;\n envelope-from=leitao@debian.org; receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp1.osuosl.org 558788143D","Date":"Thu, 9 Apr 2026 05:35:28 -0700","From":"Breno Leitao ","To":"Aleksandr Loktionov ","Cc":"intel-wired-lan@lists.osuosl.org, anthony.l.nguyen@intel.com,\n netdev@vger.kernel.org, Leszek Pepiak ","Message-ID":"","References":"<20260409093020.3808687-1-aleksandr.loktionov@intel.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20260409093020.3808687-1-aleksandr.loktionov@intel.com>","X-Debian-User":"leitao","X-Mailman-Original-DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt;\n c=relaxed/relaxed; d=debian.org;\n s=smtpauto.stravinsky; h=X-Debian-User:In-Reply-To:Content-Type:MIME-Version:\n References:Message-ID:Subject:Cc:To:From:Date:Reply-To:\n Content-Transfer-Encoding:Content-ID:Content-Description;\n bh=w706NqgBqyMKvr0nVOHn4NlIhTaCVyxRXyIz0wu2eTw=; b=OC2TM+lfxYsLQIhsCdB3HrmzIP\n 054IXBC5UmIQIuU01hqYd0KX4/xz+4PAH8Kg9X5PRVH8Pddy86B4veXRGWqPjJz838D7tkhHHYJ7U\n dP0ENSI6N3dwoH+L8DqU9Ml2ob5B1rcwo9Z0P8EMb9TQQTq8bAtgaLQM3geR57eZPjcT/FR//ohZr\n XPfJql6cSUVy16+W0D0hSf/ZQnCstnMP7SCJwBYjbd193ja0sUlJOBy/7LD0m6Ez+kYqGgu55CrzZ\n /E1FXD28pda3h1/NhV1KCQkivjTdHkg2Z44tFBlXDTnraek4mzyB/y2OYno8/5mbEzMbeLwXQyMpY\n IMSr4ziQ==;","X-Mailman-Original-Authentication-Results":["smtp1.osuosl.org;\n dmarc=none (p=none dis=none)\n header.from=debian.org","smtp1.osuosl.org;\n dkim=pass (2048-bit key,\n unprotected) header.d=debian.org header.i=@debian.org header.a=rsa-sha256\n header.s=smtpauto.stravinsky header.b=OC2TM+lf"],"Subject":"Re: [Intel-wired-lan] [PATCH net-next v2] iavf: fix kernel-doc\n comment style in iavf_ethtool.c","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "}},{"id":3675998,"web_url":"http://patchwork.ozlabs.org/comment/3675998/","msgid":"","list_archive_url":null,"date":"2026-04-10T17:53:09","subject":"Re: [Intel-wired-lan] [PATCH net-next v2] iavf: fix kernel-doc\n comment style in iavf_ethtool.c","submitter":{"id":91060,"url":"http://patchwork.ozlabs.org/api/people/91060/","name":"Joe Damato","email":"joe@dama.to"},"content":"On Thu, Apr 09, 2026 at 11:30:20AM +0200, Aleksandr Loktionov wrote:\n> iavf_ethtool.c contains 31 kernel-doc comment blocks using the legacy\n> `**/` terminator instead of the correct single `*/`. Two function\n> headers also use a colon separator (`iavf_get_channels:`,\n> `iavf_set_channels:`) instead of the ` - ` dash required by kernel-doc.\n> \n> Additionally several comments embed their return-value descriptions in\n> the body paragraph, producing `scripts/kernel-doc -Wreturn` warnings.\n> Void functions that incorrectly say \"Returns ...\" are also rephrased.\n> \n> Fix all issues across the full file:\n> - Replace every `**/` terminator with `*/`.\n> - Change `function_name:` doc headers to `function_name -`.\n> - Move inline \"Returns ...\" sentences into dedicated `Return:` sections\n> for non-void functions (iavf_get_msglevel, iavf_get_rxnfc,\n> iavf_set_channels, iavf_get_rxfh_key_size, iavf_get_rxfh_indir_size,\n> iavf_get_rxfh, iavf_set_rxfh).\n> - Rephrase body descriptions in void functions that incorrectly said\n> \"Returns ...\" (iavf_get_drvinfo, iavf_get_ringparam, iavf_get_coalesce).\n> - Remove boilerplate body text for iavf_get_rxfh_key_size and\n> iavf_get_rxfh_indir_size; the `Return:` line now conveys the same\n> information without the vague \"Returns the table size.\" sentence.\n> \n> Suggested-by: Anthony L. Nguyen \n> Suggested-by: Leszek Pepiak \n> Signed-off-by: Aleksandr Loktionov \n> ---\n> v1 -> v2 extending the scope of the changes to whole iavf_ethtool.c file\n> ---\n> drivers/net/ethernet/intel/iavf/iavf_ethtool.c | 103 ++++++++++++------------\n> 1 file changed, 53 insertions(+), 50 deletions(-)\n\nReviewed-by: Joe Damato ","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=Zj9aofsC;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=140.211.166.136; helo=smtp3.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fsktR3bQYz1yGb\n\tfor ; Sat, 11 Apr 2026 03:53:17 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id AEE78610F7;\n\tFri, 10 Apr 2026 17:53:14 +0000 (UTC)","from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id wHNrvAyEkJMs; Fri, 10 Apr 2026 17:53:14 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id ED050610F4;\n\tFri, 10 Apr 2026 17:53:13 +0000 (UTC)","from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n by lists1.osuosl.org (Postfix) with ESMTP id 09142EC\n for ; Fri, 10 Apr 2026 17:53:13 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp3.osuosl.org (Postfix) with ESMTP id E2B32610F4\n for ; Fri, 10 Apr 2026 17:53:12 +0000 (UTC)","from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id ZU1v-h1d3utH for ;\n Fri, 10 Apr 2026 17:53:11 +0000 (UTC)","from mail-pg1-x52b.google.com (mail-pg1-x52b.google.com\n [IPv6:2607:f8b0:4864:20::52b])\n by smtp3.osuosl.org (Postfix) with ESMTPS id 479B4610F3\n for ; Fri, 10 Apr 2026 17:53:10 +0000 (UTC)","by mail-pg1-x52b.google.com with SMTP id\n 41be03b00d2f7-c76b6abdb73so1667318a12.1\n for ; Fri, 10 Apr 2026 10:53:10 -0700 (PDT)","from localhost ([2a03:2880:2ff:46::])\n by smtp.gmail.com with ESMTPSA id\n 41be03b00d2f7-c79218fc7e7sm3005525a12.10.2026.04.10.10.53.09\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 10 Apr 2026 10:53:09 -0700 (PDT)"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp3.osuosl.org ED050610F4","OpenDKIM Filter v2.11.0 smtp3.osuosl.org 479B4610F3"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1775843594;\n\tbh=Sq+y/9byaIkL7h6Mh25RQ0k7WMeVVSbAl+IgT/3yRhM=;\n\th=Date:From:To:Cc:References:In-Reply-To:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t From;\n\tb=Zj9aofsCOV46pVfCLotnOCjwoyuHBZ/LS3WLpN6qpIar7JjIi2MYlb5wYEH6F6zJR\n\t 6BfNcGtEG5D5Q3TpO812IeBHPO+acA7eoU0PT1udR3nIxCumtTpSk64Zc5qfZd/PH6\n\t s7Cq+5doOnT5hPINLTpzEriDb3uFvGh7DCkHIuk1YbqLr7tQnVT5YyfJ9cAW3TYfM0\n\t 01UU3RboeogctnTX/Ik+RdrQZSUmz6JIFqgBKxPNbSax43XnBhCzcvWDsezmB30RfX\n\t li9ggcnfbBkqza+cv+eOB8fjpxhf3gtr4VD1ydDZqK1Wfqev12Jzt8DS9dmskTrnBH\n\t 3ghuzXQYoXjeQ==","Received-SPF":"None (mailfrom) identity=mailfrom;\n client-ip=2607:f8b0:4864:20::52b; helo=mail-pg1-x52b.google.com;\n envelope-from=joe@dama.to; receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp3.osuosl.org 479B4610F3","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775843590; x=1776448390;\n h=in-reply-to:content-disposition:mime-version:references\n :mail-followup-to:message-id:subject:cc:to:from:date:x-gm-gg\n :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;\n bh=Sq+y/9byaIkL7h6Mh25RQ0k7WMeVVSbAl+IgT/3yRhM=;\n b=EhKf3mJklnDosWGY19Y0WIxxYDypKnYPMoRt4hAavI27qdd3jR8CEWPh/2iAKD6aIY\n i0QOJVb2H48kZNpY3ptXsLozTAsp7dC5b9wcLmwdE/LyCk0X9wDoCTEbZvN8PgBkRfHE\n GTJAjivzSLuADPzu6CQVLHUvjGGHwDEQV/SkJrrcMyV4SQ1jzCV9rndrZrr2YNYUr7Tf\n WEA5UEPZY3pIr0Zlx7cYs5YqVdN37gonlbKJ0WtwzlhpUPSuk9TbQxYGVcEHUaZ/+pgJ\n rsMZ7IsPyZu71FaLoyZTMWKvhC+Z7is80c0jLOFxsM0dTk5SwScNHYhu3RY3xlDE5AU8\n YlRw==","X-Gm-Message-State":"AOJu0YxbLm+i3X2diD6ospwaIm8i7EsEDdr69hRcSwvnzqmUIhT0hZEB\n TikGzCMl/4cecjFeTyoXcwUTBVnyKn7J6N8iaIH13sApkhuDzdIZmLjZDbtEUQWr320=","X-Gm-Gg":"AeBDies+MsWNVtbwJS9Vsqbh7MRd/lVb5aLMxNAqB2dvN2yEN7AiGQQ94uNt3+snTDl\n ki8X32gwjVLsGgp/C6rGd6YZv11a/hU0V3X+NUQLT6kFwUqDDKUq0EPmYuGOl6VhKtZUjQDiKUZ\n CX037h3ObdcdbxUIs1Xdb7xy094yww++LJF7nk/zFG0uyk5ANtMpEwxzTFRjn9FpWuf5ERd9UK7\n SPfTOdoyUmM6fLNBsN6q306/FdHcixCUp5vgFEgvwb8i23bXoil/+D2vsXvqW+F/hHKHnteRxAX\n 8eonpuCboWZg2jp18oYEBvvJmqIqxnAwAsJne9+OS1r1DhjftypBZsf4akhTPIbrH2MQ3vhbKEK\n 9Zt3C4DwEdGuRGyDi6W/U61FoJdRcItM7pabe5/+orqyAcg8txXtCGu0O6VHCDBQlO6Zo8HI0/2\n lYtANzY6RgLzwt5jE=","X-Received":"by 2002:a05:6a20:12d0:b0:39f:794f:94d8 with SMTP id\n adf61e73a8af0-39fe3f49777mr4765807637.29.1775843590350;\n Fri, 10 Apr 2026 10:53:10 -0700 (PDT)","Date":"Fri, 10 Apr 2026 10:53:09 -0700","From":"Joe Damato ","To":"Aleksandr Loktionov ","Cc":"intel-wired-lan@lists.osuosl.org, anthony.l.nguyen@intel.com,\n netdev@vger.kernel.org, Leszek Pepiak ","Message-ID":"","Mail-Followup-To":"Joe Damato ,\n Aleksandr Loktionov ,\n intel-wired-lan@lists.osuosl.org, anthony.l.nguyen@intel.com,\n netdev@vger.kernel.org, Leszek Pepiak ","References":"<20260409093020.3808687-1-aleksandr.loktionov@intel.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20260409093020.3808687-1-aleksandr.loktionov@intel.com>","X-Mailman-Original-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=dama-to.20251104.gappssmtp.com; s=20251104; t=1775843590; x=1776448390;\n darn=lists.osuosl.org;\n h=in-reply-to:content-disposition:mime-version:references\n :mail-followup-to:message-id:subject:cc:to:from:date:from:to:cc\n :subject:date:message-id:reply-to;\n bh=Sq+y/9byaIkL7h6Mh25RQ0k7WMeVVSbAl+IgT/3yRhM=;\n b=mkRN06LG3crl31RJovVAMqdutVxL3tNFiF47WIpGwL1BHafFz2N9Oyv1LmqVZn0/6+\n QsQWWxsxJDUE7y5UDsbp6dwo/8+OsjD2mhkfxMAuUSR8wHvIwqTfzcE+h0gG3fZ4/+/S\n TLFwLNd88tnfdiK2rwp73yCT2XNfO4OBi+Fba0PngBnXVWwcOiXqQY0VplQpyWviwQ0o\n 1BtxioO8Lpj9fSM6AeRFZ5Ah8HX2qw0t2suRIGySpVZoEB3DijVqas9teH6jPQTYofGh\n tD40rvKB7Ajx22YmdDQ5XlUk/Adu2Yq4lSTFYT6nvopAu57kxJ180NvnRUJ5SUpssHeq\n fKvQ==","X-Mailman-Original-Authentication-Results":["smtp3.osuosl.org;\n dmarc=none (p=none dis=none)\n header.from=dama.to","smtp3.osuosl.org;\n dkim=pass (2048-bit key,\n unprotected) header.d=dama-to.20251104.gappssmtp.com\n header.i=@dama-to.20251104.gappssmtp.com header.a=rsa-sha256\n header.s=20251104 header.b=mkRN06LG"],"Subject":"Re: [Intel-wired-lan] [PATCH net-next v2] iavf: fix kernel-doc\n comment style in iavf_ethtool.c","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "}},{"id":3676087,"web_url":"http://patchwork.ozlabs.org/comment/3676087/","msgid":"<177586262379.2678602.4461794362716512859.git-patchwork-notify@kernel.org>","list_archive_url":null,"date":"2026-04-10T23:10:23","subject":"Re: [Intel-wired-lan] [PATCH net-next v2] iavf: fix kernel-doc\n comment style in iavf_ethtool.c","submitter":{"id":80291,"url":"http://patchwork.ozlabs.org/api/people/80291/","name":null,"email":"patchwork-bot+netdevbpf@kernel.org"},"content":"Hello:\n\nThis patch was applied to netdev/net-next.git (main)\nby Jakub Kicinski :\n\nOn Thu, 9 Apr 2026 11:30:20 +0200 you wrote:\n> iavf_ethtool.c contains 31 kernel-doc comment blocks using the legacy\n> `**/` terminator instead of the correct single `*/`. Two function\n> headers also use a colon separator (`iavf_get_channels:`,\n> `iavf_set_channels:`) instead of the ` - ` dash required by kernel-doc.\n> \n> Additionally several comments embed their return-value descriptions in\n> the body paragraph, producing `scripts/kernel-doc -Wreturn` warnings.\n> Void functions that incorrectly say \"Returns ...\" are also rephrased.\n> \n> [...]\n\nHere is the summary with links:\n - [net-next,v2] iavf: fix kernel-doc comment style in iavf_ethtool.c\n https://git.kernel.org/netdev/net-next/c/3f3a2aefbc66\n\nYou are awesome, thank you!","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=luROoWe0;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::138; helo=smtp1.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fsswy4BxCz1yCv\n\tfor ; Sat, 11 Apr 2026 09:10:56 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id 322BD83C55;\n\tFri, 10 Apr 2026 23:10:54 +0000 (UTC)","from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id JP0AJ1YraQG8; Fri, 10 Apr 2026 23:10:53 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id 71FEA83C56;\n\tFri, 10 Apr 2026 23:10:53 +0000 (UTC)","from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n by lists1.osuosl.org (Postfix) with ESMTP id DC2F6194\n for ; Fri, 10 Apr 2026 23:10:51 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp4.osuosl.org (Postfix) with ESMTP id D9EEC41225\n for ; Fri, 10 Apr 2026 23:10:51 +0000 (UTC)","from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id FfUxf-4UwWQq for ;\n Fri, 10 Apr 2026 23:10:51 +0000 (UTC)","from tor.source.kernel.org (tor.source.kernel.org\n [IPv6:2600:3c04:e001:324:0:1991:8:25])\n by smtp4.osuosl.org (Postfix) with ESMTPS id 2A02940CA0\n for ; Fri, 10 Apr 2026 23:10:50 +0000 (UTC)","from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58])\n by tor.source.kernel.org (Postfix) with ESMTP id F040760181;\n Fri, 10 Apr 2026 23:10:49 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id A80CBC19421;\n Fri, 10 Apr 2026 23:10:49 +0000 (UTC)","from [10.30.226.235] (localhost [IPv6:::1])\n by aws-us-west-2-korg-oddjob-rhel9-1.codeaurora.org (Postfix) with ESMTP id\n 3FCBF3809A88; Fri, 10 Apr 2026 23:10:25 +0000 (UTC)"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp1.osuosl.org 71FEA83C56","OpenDKIM Filter v2.11.0 smtp4.osuosl.org 2A02940CA0"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1775862653;\n\tbh=WgWtPNRr8FVLCsIgvudRtpMQ7i10lZ9yDhFemLfXDCA=;\n\th=From:Date:References:In-Reply-To:To:Cc:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t From;\n\tb=luROoWe0cF9vhYGjABmltPwfMWvVL0peayQ4htE6IdWFj6hGoa4gD5qgZU6oc+idv\n\t 68w0qB6sijhgc0T7W7YqblDWgw5JSzgyeyR8fJp0cwYAH8nL9BotluJkPpLh0Sc5ly\n\t s7z1zpg+mZcixs2MbOxACuC6aadniNo7t5GbvOaUFMAhzFAqisbI1E9VrESLnemlxg\n\t 6SGmInWKqxnfOUniJOEA9XceqilUWv881Ov++SP++idTEcSdZ+x+VwlGY0xHRE0Yom\n\t Ua6tW177OBpY9mZVyv8pupQ3GZRTH1PYewzaP9SnaquVtiyK6dIJ0pX7qY0cj0JrUO\n\t OKLmD7fTdKIOA==","Received-SPF":"Pass (mailfrom) identity=mailfrom;\n client-ip=2600:3c04:e001:324:0:1991:8:25; helo=tor.source.kernel.org;\n envelope-from=patchwork-bot+netdevbpf@kernel.org; receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp4.osuosl.org 2A02940CA0","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","From":"patchwork-bot+netdevbpf@kernel.org","Message-Id":"\n <177586262379.2678602.4461794362716512859.git-patchwork-notify@kernel.org>","Date":"Fri, 10 Apr 2026 23:10:23 +0000","References":"<20260409093020.3808687-1-aleksandr.loktionov@intel.com>","In-Reply-To":"<20260409093020.3808687-1-aleksandr.loktionov@intel.com>","To":"Loktionov@aws-us-west-2-korg-oddjob-rhel9-1.codeaurora.org,\n Aleksandr ","Cc":"intel-wired-lan@lists.osuosl.org, anthony.l.nguyen@intel.com,\n netdev@vger.kernel.org, leszek.pepiak@intel.com","X-Mailman-Original-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n d=kernel.org; s=k20201202; t=1775862649;\n bh=J4LOl9rF5ZCwKIsleAPXSM56vZS43EMCOiWOUy1W4vM=;\n h=Subject:From:Date:References:In-Reply-To:To:Cc:From;\n b=hUgqET5Ocr0nbQxBSw6DgCwzy3dXUangtyph7ynq/pgXfUX+ERN+zA19p2TgdzDC7\n 2rNpk5txApudlMu4/4DANexqTQgh2iUYQM6yBPSFFYv5aFs5iFwcGNvaKRY8/UfFUn\n EzA/TEa8lilr2MmJ501DWxH1Q+I+Om4ik8pa9+nI4a3NC9jGVeLk/QrJwv4nzr/bMx\n UvwxGEoilj6hvZ7TZL9ZgBM/Z20LlMfQZUG5c2NaUPkzc2u8m2bcHt4VpAtU+ygZ0m\n WMTIXsv2G7Ept7Nz/I1OGMjpjn/Y8d2WuK+n9An4GKD0QCqnK48e42DDVjdM0RuAYV\n iGBqmycPIvN7w==","X-Mailman-Original-Authentication-Results":["smtp4.osuosl.org;\n dmarc=pass (p=quarantine dis=none)\n header.from=kernel.org","smtp4.osuosl.org;\n dkim=pass (2048-bit key,\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=hUgqET5O"],"Subject":"Re: [Intel-wired-lan] [PATCH net-next v2] iavf: fix kernel-doc\n comment style in iavf_ethtool.c","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "}}]