[{"id":3675308,"web_url":"http://patchwork.ozlabs.org/comment/3675308/","msgid":"<875x605lu0.fsf@suse.de>","list_archive_url":null,"date":"2026-04-09T13:01:43","subject":"Re: [PATCH v4 4/5] tests/qtest: add tests for dynamic monitor\n add/remove","submitter":{"id":85343,"url":"http://patchwork.ozlabs.org/api/people/85343/","name":"Fabiano Rosas","email":"farosas@suse.de"},"content":"Christian Brauner writes:\n\n> Test the monitor-add, monitor-remove, and query-monitors QMP commands:\n>\n> - Basic lifecycle: chardev-add -> monitor-add -> query-monitors ->\n> monitor-remove -> chardev-remove\n> - Error: duplicate monitor id\n> - Error: monitor-remove on nonexistent id\n> - Error: monitor-add with nonexistent chardev\n> - Error: second monitor on same chardev (chardev already in use)\n> - Removal of CLI-created QMP monitor succeeds\n> - Error: monitor-remove on HMP monitor\n> - Re-add after remove: same id and chardev reusable after removal\n>\n> Signed-off-by: Christian Brauner (Amutable) \n\nReviewed-by: Fabiano Rosas ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256\n header.s=susede2_rsa header.b=2Ljk0I43;\n\tdkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=0sO+btA8;\n\tdkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de\n header.a=rsa-sha256 header.s=susede2_rsa header.b=M5cfSYo0;\n\tdkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256\n header.s=susede2_ed25519 header.b=rhkd5Jj3;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)","smtp-out1.suse.de;\n dkim=pass header.d=suse.de header.s=susede2_rsa header.b=M5cfSYo0;\n dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=rhkd5Jj3"],"Received":["from lists.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fs0VR4wksz211N\n\tfor ; Thu, 09 Apr 2026 23:03:26 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wAp1I-0006Yy-4S; Thu, 09 Apr 2026 09:02:04 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wAp1B-0006Xn-E0\n for qemu-devel@nongnu.org; Thu, 09 Apr 2026 09:01:57 -0400","from smtp-out1.suse.de ([195.135.223.130])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1wAp19-0001Gl-Qm\n for qemu-devel@nongnu.org; Thu, 09 Apr 2026 09:01:57 -0400","from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org\n [IPv6:2a07:de40:b281:104:10:150:64:97])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by smtp-out1.suse.de (Postfix) with ESMTPS id C54686A7CC;\n Thu, 9 Apr 2026 13:01:45 +0000 (UTC)","from imap1.dmz-prg2.suse.org (localhost [127.0.0.1])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest\n SHA256)\n (No client certificate requested)\n by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 581204A0B3;\n Thu, 9 Apr 2026 13:01:45 +0000 (UTC)","from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167])\n by imap1.dmz-prg2.suse.org with ESMTPSA id oAc5CTmj12krJwAAD6G6ig\n (envelope-from ); Thu, 09 Apr 2026 13:01:45 +0000"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_rsa;\n t=1775739710;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:content-type:content-type:\n in-reply-to:in-reply-to:references:references;\n bh=Nw4bv4HCC0b1u7UIB6a6YYq+wepQnD3SGB7wXKl7euk=;\n b=2Ljk0I43O0rB3jwttD7hrK3SAJL/OB/c1Fi/18P6zC8NO94tnWXTRsikIk1lgqW7gU7rRZ\n RFvgbTu2ezk+h0nFsjx9btmdi8LndwVDjhZP5SA//5wuNwpm3RkhtmuEPDiMkBLBAGS9+E\n Xbffqu0S0fetzMUS78uZ3EeJ8Z8/LwY=","v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_ed25519; t=1775739710;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:content-type:content-type:\n in-reply-to:in-reply-to:references:references;\n bh=Nw4bv4HCC0b1u7UIB6a6YYq+wepQnD3SGB7wXKl7euk=;\n b=0sO+btA8PPKG+90GjdP1z5rL4kayilsaqM/TTx/UTkLeakbzi6xaC6IiEix1kPQtiq7ilc\n yRDCg3nYQyixUUBQ==","v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_rsa;\n t=1775739705;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:content-type:content-type:\n in-reply-to:in-reply-to:references:references;\n bh=Nw4bv4HCC0b1u7UIB6a6YYq+wepQnD3SGB7wXKl7euk=;\n b=M5cfSYo0kosMy80gqPGw94w7ZMYcrxHuEFqzfP7ZhlFzkDdRdBPFnhso9mp72Z0VeOphP7\n 9/nNRtULsZ0kqNxdNpV/F4puNHpYtLW2FD4Ww6dBjRXIMLXbDaCFKNZIRCO3PO0vJKlQwX\n YvHeodFWxCOgudjBfN8yF33lUy6Hh34=","v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;\n s=susede2_ed25519; t=1775739705;\n h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:\n mime-version:mime-version:content-type:content-type:\n in-reply-to:in-reply-to:references:references;\n bh=Nw4bv4HCC0b1u7UIB6a6YYq+wepQnD3SGB7wXKl7euk=;\n b=rhkd5Jj3A9TLXzunzH9YTYujg15bIslkST5sO+jairkTB1DEfk9Czvluisy88xiuD7+Zii\n ebBEPIRzE1BBpxBQ=="],"From":"Fabiano Rosas ","To":"Christian Brauner , qemu-devel@nongnu.org","Cc":"Markus Armbruster , Eric Blake ,\n Laurent Vivier , Paolo Bonzini ,\n Thomas Huth ,\n Philippe =?utf-8?q?Mathieu-Daud=C3=A9?= , =?utf-8?q?Dani?=\n\t=?utf-8?q?el_P=2E_Berrang=C3=A9?= ,\n Christian Brauner ","Subject":"Re: [PATCH v4 4/5] tests/qtest: add tests for dynamic monitor\n add/remove","In-Reply-To":"<20260409-work-qmp-monitor-hotplug-v4-4-89c4fdf69df1@kernel.org>","References":"<20260409-work-qmp-monitor-hotplug-v4-0-89c4fdf69df1@kernel.org>\n <20260409-work-qmp-monitor-hotplug-v4-4-89c4fdf69df1@kernel.org>","Date":"Thu, 09 Apr 2026 10:01:43 -0300","Message-ID":"<875x605lu0.fsf@suse.de>","MIME-Version":"1.0","Content-Type":"text/plain","X-Spamd-Result":"default: False [-2.96 / 50.00]; BAYES_HAM(-2.95)[99.81%];\n SUSPICIOUS_RECIPS(1.50)[]; NEURAL_HAM_LONG(-1.00)[-1.000];\n R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519];\n NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain];\n MX_GOOD(-0.01)[]; TO_MATCH_ENVRCPT_ALL(0.00)[];\n DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519];\n FUZZY_RATELIMITED(0.00)[rspamd.com]; ARC_NA(0.00)[];\n RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from];\n TO_DN_SOME(0.00)[]; MIME_TRACE(0.00)[0:+]; FROM_HAS_DN(0.00)[];\n DKIM_TRACE(0.00)[suse.de:+];\n SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from];\n DNSWL_BLOCKED(0.00)[2a07:de40:b281:104:10:150:64:97:from,2a07:de40:b281:106:10:150:64:167:received];\n MID_RHS_MATCH_FROM(0.00)[]; RCVD_COUNT_TWO(0.00)[2];\n FROM_EQ_ENVFROM(0.00)[]; RCVD_TLS_ALL(0.00)[];\n RCPT_COUNT_SEVEN(0.00)[10]; TAGGED_RCPT(0.00)[qemu];\n RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received];\n MISSING_XM_UA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[];\n DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:mid, suse.de:dkim, suse.de:email,\n imap1.dmz-prg2.suse.org:helo, imap1.dmz-prg2.suse.org:rdns]","X-Rspamd-Action":"no action","X-Spam-Score":"-2.96","X-Rspamd-Server":"rspamd1.dmz-prg2.suse.org","X-Rspamd-Queue-Id":"C54686A7CC","Received-SPF":"pass client-ip=195.135.223.130; envelope-from=farosas@suse.de;\n helo=smtp-out1.suse.de","X-Spam_score_int":"-43","X-Spam_score":"-4.4","X-Spam_bar":"----","X-Spam_report":"(-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001,\n RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]