[{"id":3675208,"web_url":"http://patchwork.ozlabs.org/comment/3675208/","msgid":"","list_archive_url":null,"date":"2026-04-09T09:41:01","subject":"Re: [PATCH 3/5] hw/mips: Use hex unit addresses in FDT CPU nodes","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/people/85046/","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"content":"On 9/4/26 08:40, Vivian Wang wrote:\n> These unit addresses should have been in hex, not decimal, as per de\n> facto convention [1]. Fix them.\n> \n> Link: https://lore.kernel.org/devicetree-spec/CAL_JsqJFv3+UJ-bjLGk0i7Wc+spsowCrqQZ_s3P4gN8r1W-Q-w@mail.gmail.com/ # [1]\n> Signed-off-by: Vivian Wang \n> ---\n> hw/mips/boston.c | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/hw/mips/boston.c b/hw/mips/boston.c\n> index 4579df23eb..9ef3f6c814 100644\n> --- a/hw/mips/boston.c\n> +++ b/hw/mips/boston.c\n> @@ -542,7 +542,7 @@ static const void *create_fdt(BostonState *s,\n> qemu_fdt_setprop_cell(fdt, \"/cpus\", \"#address-cells\", 0x1);\n> \n> for (cpu = 0; cpu < ms->smp.cpus; cpu++) {\n> - name = g_strdup_printf(\"/cpus/cpu@%d\", cpu);\n> + name = g_strdup_printf(\"/cpus/cpu@%x\", (unsigned)cpu);\n\nNo need to cast to unsigned explicitly, otherwise:\nReviewed-by: Philippe Mathieu-Daudé ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=k/mSWxj+;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4frw235jT0z1yD3\n\tfor ; Thu, 09 Apr 2026 19:42:03 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wAlsp-0001YJ-M8; Thu, 09 Apr 2026 05:41:07 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wAlso-0001XP-2e\n for qemu-devel@nongnu.org; Thu, 09 Apr 2026 05:41:06 -0400","from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1wAlsm-0001e8-C2\n for qemu-devel@nongnu.org; Thu, 09 Apr 2026 05:41:05 -0400","by mail-wm1-x32e.google.com with SMTP id\n 5b1f17b1804b1-488b0e1b870so9749615e9.2\n for ; Thu, 09 Apr 2026 02:41:03 -0700 (PDT)","from [192.168.69.228] (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-43d1e2c50a7sm65497555f8f.15.2026.04.09.02.41.01\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Thu, 09 Apr 2026 02:41:02 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1775727663; x=1776332463; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:from:references:cc:to\n :content-language:subject:user-agent:mime-version:date:message-id\n :from:to:cc:subject:date:message-id:reply-to;\n bh=b5nYDmYgKSlz8Cdbt2udVqydHBlMo/5r0CRBZdvjimg=;\n b=k/mSWxj+C1Y+0e3aBmBMj/JWRF67JKHt/xk3hv0fF1US9eD8uuDKMnUXbWbVRb+Pjk\n lPZRNcRIL7mzOT2FXNfUUN8D0EnSEGb7dHcB5xQ3zU0pk/NI9tNGmwiUF3gpjxkoSxXN\n 4d0V1h40GQMgNQePp4/1a5eI9rOYzkTbhoSvzp1DFXCLDqF5csIimXCD0ftuYsex7A0W\n 4zAZyxFifeFqUJ7YMJwkiaz72MEXaHKXCvuoXMN5aFnUn5zVjStT1/b+Fuqu9RUHuInj\n yN+DZgTx2EdXcC/Ehe1xtqhxnXSyrRL2JrpaID1+I0aUgEY7eWmvQMoiQVYK3PfOBf0n\n wewg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775727663; x=1776332463;\n h=content-transfer-encoding:in-reply-to:from:references:cc:to\n :content-language:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=b5nYDmYgKSlz8Cdbt2udVqydHBlMo/5r0CRBZdvjimg=;\n b=jk1icKrthjp1zWdloJpawmrEV8j9Jgnic1aCWH/u7C3TUGsVFmDHBP4iLrkedHMByX\n 6frsd89Mgvs+U67spALPo8SpEZmJNAHn7zIUCadCuYuMKgAIWRpnJ75ekJqZXy0JjpFu\n PKGSLxLs3tVu0W5opdf8mm6J3eqC/613KTMOKAinzTqeL2CUH5s6cSG5fcwc7ijKIp3X\n /GJXGnL0Mu+oxU3S9FI567WERroB85exLxhtW2/nhf5qtV5JJdl/OKDkzznVrMWlawWf\n 0v7zjSYnc477AW2ttvY3QI8TXbbBk3XReRSnfLjZ3Q4QdHO5b89xfN5CH67m/CqmZmsY\n 82ew==","X-Forwarded-Encrypted":"i=1;\n AJvYcCVSN9jbHmUOyBCqcgBzMIYT3/1FMweec72+pakgm6jMV5BLhBUBzBHAajLGR8RSUegzd6C30WiDVvcx@nongnu.org","X-Gm-Message-State":"AOJu0YxKmANZxJx/JTUGfTPN81+1/40lBB0we1VhXnACMjDRPAYiT1ZS\n nEJUO6Un2ojRzuacehR8Bubbo9gJbgaGu0uprL7A5GpUSLb14wJmIvNObJ9lh6oA6Ag=","X-Gm-Gg":"AeBDieue7s8R3ZnpRhxC2p9DlJk78wK/UX/0gOmctCS+pyXBH5KDF7e2zU6VBxbeq5u\n r1bbPh+zwVcjI45ZdVJaSpNR5mmm9Kx5dQAeECG27NwSL5FxVPyxSP8rVhL0TXyJyoxvqSpXDuj\n jp9u+hNGHougIOaPHNukxXhcVljAau8dJ6vLJTUGW74pH+U4d1jzgNdhZxR7AD62a9eSNcGgmVz\n Q+j6mXuGUhz/Nz6MP6zXXtuVhOkKbx/C4DkcW76s8dWwOvyAyrOhtSwpl/jWdd236SAkTG8QUYW\n qsnHCkzNenPU59ue+GWlzq18Rs5PtKLKitOmTc0B4KdYbjNLtJQo0KuC9TEppQ4E0uo1DZVBvC6\n f61vborUs3v/ZN/HUdkzVR7jpN1ODUTL4fYwqxTVSXMzM/twhR9jNwiu/xHEnd57IgMgwhwaau0\n krh8vjT9X3KwBZvFBVz9OFK6DFo1op4ft2rWia3Mg6Fq6/9SIKOHsbPZsEVGUELuxo4g==","X-Received":"by 2002:a05:600c:3492:b0:488:b14f:b8ed with SMTP id\n 5b1f17b1804b1-488b14fb9e4mr222692255e9.0.1775727662930;\n Thu, 09 Apr 2026 02:41:02 -0700 (PDT)","Message-ID":"","Date":"Thu, 9 Apr 2026 11:41:01 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH 3/5] hw/mips: Use hex unit addresses in FDT CPU nodes","Content-Language":"en-US","To":"Vivian Wang , qemu-devel@nongnu.org","Cc":"Peter Maydell ,\n Leif Lindholm , qemu-arm@nongnu.org,\n Song Gao , Bibo Mao ,\n Jiaxun Yang , Paul Burton ,\n Aleksandar Rikalo , Jia Liu ,\n Stafford Horne ,\n Alistair Francis ,\n Palmer Dabbelt , Weiwei Li ,\n Daniel Henrique Barboza ,\n Liu Zhiwei ,\n Chao Liu , qemu-riscv@nongnu.org","References":"<20260409-fix-unit-address-v1-0-946840930af2@iscas.ac.cn>\n <20260409-fix-unit-address-v1-3-946840930af2@iscas.ac.cn>","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","In-Reply-To":"<20260409-fix-unit-address-v1-3-946840930af2@iscas.ac.cn>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::32e;\n envelope-from=philmd@linaro.org; helo=mail-wm1-x32e.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]