[{"id":3675199,"web_url":"http://patchwork.ozlabs.org/comment/3675199/","msgid":"","list_archive_url":null,"date":"2026-04-09T09:18:34","subject":"Re: [PATCH 1/5] hw/arm: Fix unit addresses of FDT CPU nodes","submitter":{"id":5111,"url":"http://patchwork.ozlabs.org/api/people/5111/","name":"Peter Maydell","email":"peter.maydell@linaro.org"},"content":"On Thu, 9 Apr 2026 at 07:40, Vivian Wang wrote:\n>\n> The node unit addresses should be based on the reg value (which is in\n> turn based on MPIDR), rather than some arbitrary number [1]. Also, they\n> should have been in hex, not decimal, as per de facto convention [2].\n> Fix them.\n\nPlease don't fix multiple different things in one patch.\n\nIn particular, sbsa-ref is special: the \"dtb\" it produces is\nnot intended to be an actual DTB, it's just a convenient way\nto pass a tiny amount of information to the firmware for\nthis board. We talk about this in the docs:\nhttps://www.qemu.org/docs/master/system/arm/sbsa.html#board-to-firmware-interface\n\nThe firmware doesn't need the MPIDR in the node name, so there's\nno real need to change this.\n\nthanks\n-- PMM","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=F0kclfwW;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4frvWt5vt4z1xtJ\n\tfor ; Thu, 09 Apr 2026 19:19:22 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wAlXG-00056h-7X; Thu, 09 Apr 2026 05:18:50 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wAlXF-00056E-2R\n for qemu-devel@nongnu.org; Thu, 09 Apr 2026 05:18:49 -0400","from mail-yx1-xb12d.google.com ([2607:f8b0:4864:20::b12d])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1wAlXD-0005jq-8l\n for qemu-devel@nongnu.org; Thu, 09 Apr 2026 05:18:48 -0400","by mail-yx1-xb12d.google.com with SMTP id\n 956f58d0204a3-64937edbc9eso599250d50.2\n for ; Thu, 09 Apr 2026 02:18:46 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; t=1775726326; cv=none;\n d=google.com; s=arc-20240605;\n b=eslG45Ofw/F6Nwo0IB+Q6IOyjU7O5CSxlDDpgS85QYUrwIw75aUjMPySPidAPYcwzG\n Xcn0kz2N2K0Ih1QHtDOO79q9K6Y3Sk3xx9bKhbGZspfq/e1ttOvuGopXcgictpTXy+on\n uKuKHIxmnk8FnpHGB4agdO/AdSRXegPt25Ree5Wa79gTxngrc0Umhv0B/WNEgpmoVxoH\n w2MxqZSzgz2OpmDXGSR4YMjcX/AFloM0MqP95Ob23VLozJFnSiVCC0Yj7ITBj8Yeny2/\n 57kJh0XxSmFpFy31IimPEM3sgUjqEyAX9EScEBMeH5KrT3mLawd2V62qyc9LagzVZGAJ\n DDqg==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:dkim-signature;\n bh=BWegvmsqAEMLsVg7d+5gDL/Xyt4tYWPMAeL182yYasI=;\n fh=ZKds+nUgoQEsVQWyLb5eyl+oP68VH/5k4ombeful5ps=;\n b=W1yL9/x6Zpre4Fxms8njhjT1fRnLjnFtwl4RjJxlpr8CNNHoQuP2d4A5F/8ya5Hg3r\n Nq3o/j3I7ZjJ1WSnGXmvBW0AzoHXavzUNBpwZANFDxQybhDjDF1aQZRuZkwa0G2MKglY\n D4DDkj6/eIwEETJOAbPdcRngMVS09+Mtm1xxdVPTVu1AktAByOfvWNu0ClNrVQZNuxKD\n HSpUfesFZp2QcubZrumzJO4A//MkycKY61sjOHHqeMhEjeiPTf8Au+teVADdaYfHCCih\n NRZotoKWSYKZu9sd19vGP79LZQhTTDmtryqwN11zy/K9NzHg6a8lBS0zYe2jVWyD0AFM\n DR5w==; darn=nongnu.org","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1775726326; x=1776331126; darn=nongnu.org;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:from:to:cc:subject:date:message-id:reply-to;\n bh=BWegvmsqAEMLsVg7d+5gDL/Xyt4tYWPMAeL182yYasI=;\n b=F0kclfwWQCauXZryBl3nwsZhBle4ki1f/5qNioc83LrCFtR4AeqFt/LpmuDt/D/KsS\n s8BC0Hl2LF0B3fzFS5ScxBb61hrWVuEF4ggp5LwQvh4T3IhluNC6+VpifRmldMPCJh5y\n dUfFUWtWgjBRUlnHRNHrX15hoNQXBf6g0KZBcK46co70fs4hRi4To7LjnTxrJhKfbqQD\n dZgIdv9tPDtfHtqa1w2izP4dfgf6b1Ta5EMYBY5GnILYHyK3CmRc2UdTPLBv8uJCQ8J3\n YOfdRoxoPTMIo7idP3PXinnkTXrGhPXnkNicV3pNGH5oZkSUOFpdL8Fv0WGCT/hnvwOO\n Egcg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775726326; x=1776331126;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=BWegvmsqAEMLsVg7d+5gDL/Xyt4tYWPMAeL182yYasI=;\n b=g6Emt40AB+GZY+PdHUFHUD9lUwIH3tW7lR4wD8tJkHUcc1XMdEZdFRaKc/mIgWWzfj\n naIYgIUZJnPF9X56FJv3f/6/0IsBFkxc9bDb2D6n2P6QZgOgC/wGT+v3kCNRK22xsj4c\n lZ4ynCEncgVlcEKRHAadVoI4qXckF0S29gBEua79NdzwDdubLdPhSLw6ElnOKQqpl1Rd\n lQMxk8c6ejpg6xTnRFJ7tUXaV+EajWC0DbwqFcYo5Y2K/MR3nMM6/pdMynq9f2okPaTh\n jTgAewQt/bWAWGi2rQXq5EjxW7jRKXq+CFbLZMl/3hJnhtRU2Ng6li+osRrnin/L5aa+\n p0fA==","X-Gm-Message-State":"AOJu0YxOc5/3iDzXVBheRY8G5yYo/ic8a0/0rnK0NNNjAC2a0kAXf3pf\n VgoSDKT09srpKP7qWgujQAq0GHxZEkZ08h+caGWAFCYzLi0ts/RhAtzsScArN+1agRDDRkvRR9M\n +gG8oKffzPhD1q9cZVT5a7vANeGNLBf8APcyf8KGGDQ==","X-Gm-Gg":"AeBDietMhnAZMYCtu9bHD2Zu1nv6j7o0hLAQdBt7EJf4jSQAdCOzuMCmZv4OHmbksSl\n yqBBP6TWSoc9vusRSM/CcF7w6nKVJ7wvnXvpbiJ5+uY88ZSvuJNHQWSiv3zZAWgxjvKJeX5ez3v\n dt9SRBe44PAJOZqNeOKe6Mga9Brg28Udlh5pfwphf9hUuN0fODqByopFZU01EE1jNU8Hjt5WZde\n 1/PEI4r5dB8a+fx5PWWbJsKHm62hUeAXWnS6CM3yFbN33VugJ4zYYJPqnq6dMtpEevpHRHQ+X8u\n RxvTMW2KjRVdl8ySDDhJuUi0429Ahp9S9rqGz7Y4i/ah6tocP56cF2O/xl1sX7EmKUI=","X-Received":"by 2002:a05:690e:120c:b0:650:2ff9:d654 with SMTP id\n 956f58d0204a3-651875febe7mr2331592d50.26.1775726325932; Thu, 09 Apr 2026\n 02:18:45 -0700 (PDT)","MIME-Version":"1.0","References":"<20260409-fix-unit-address-v1-0-946840930af2@iscas.ac.cn>\n <20260409-fix-unit-address-v1-1-946840930af2@iscas.ac.cn>","In-Reply-To":"<20260409-fix-unit-address-v1-1-946840930af2@iscas.ac.cn>","From":"Peter Maydell ","Date":"Thu, 9 Apr 2026 10:18:34 +0100","X-Gm-Features":"AQROBzD7PAoRbJQCon-foLQnsOtbREpfTbSOaPoZYJfzNgUoB0OdCB2YWscPhqs","Message-ID":"\n ","Subject":"Re: [PATCH 1/5] hw/arm: Fix unit addresses of FDT CPU nodes","To":"Vivian Wang ","Cc":"qemu-devel@nongnu.org, Leif Lindholm ,\n qemu-arm@nongnu.org, Song Gao ,\n Bibo Mao , Jiaxun Yang ,\n Paul Burton , Aleksandar Rikalo ,\n\t=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ,\n Jia Liu , Stafford Horne ,\n Alistair Francis ,\n Palmer Dabbelt , Weiwei Li ,\n Daniel Henrique Barboza ,\n Liu Zhiwei ,\n Chao Liu , qemu-riscv@nongnu.org","Content-Type":"text/plain; charset=\"UTF-8\"","Received-SPF":"pass client-ip=2607:f8b0:4864:20::b12d;\n envelope-from=peter.maydell@linaro.org; helo=mail-yx1-xb12d.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}},{"id":3675206,"web_url":"http://patchwork.ozlabs.org/comment/3675206/","msgid":"","list_archive_url":null,"date":"2026-04-09T09:39:29","subject":"Re: [PATCH 1/5] hw/arm: Fix unit addresses of FDT CPU nodes","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/people/85046/","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"content":"On 9/4/26 08:40, Vivian Wang wrote:\n> The node unit addresses should be based on the reg value (which is in\n> turn based on MPIDR), rather than some arbitrary number [1]. Also, they\n> should have been in hex, not decimal, as per de facto convention [2].\n> Fix them.\n> \n\nMaybe worth to add:\n\n Cc: qemu-stable@nongnu.org\n\n> Link: https://github.com/devicetree-org/devicetree-specification/blob/v0.4/source/chapter2-devicetree-basics.rst#devicetree-structure-and-conventions # [1]\n> Link: https://lore.kernel.org/devicetree-spec/CAL_JsqJFv3+UJ-bjLGk0i7Wc+spsowCrqQZ_s3P4gN8r1W-Q-w@mail.gmail.com/ # [2]\n> Signed-off-by: Vivian Wang \n> ---\n> hw/arm/sbsa-ref.c | 4 ++--\n> hw/arm/virt.c | 7 +++++--\n> 2 files changed, 7 insertions(+), 4 deletions(-)\n\nReviewed-by: Philippe Mathieu-Daudé ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=eC8YAIdB;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4frw0Q5zrZz1yD3\n\tfor ; Thu, 09 Apr 2026 19:40:36 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wAlrV-0000th-Ir; Thu, 09 Apr 2026 05:39:45 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wAlrO-0000sX-QX\n for qemu-devel@nongnu.org; Thu, 09 Apr 2026 05:39:40 -0400","from mail-wr1-x431.google.com ([2a00:1450:4864:20::431])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1wAlrM-0001JN-4C\n for qemu-devel@nongnu.org; Thu, 09 Apr 2026 05:39:37 -0400","by mail-wr1-x431.google.com with SMTP id\n ffacd0b85a97d-43cf5fbacc9so290291f8f.1\n for ; Thu, 09 Apr 2026 02:39:35 -0700 (PDT)","from [192.168.69.228] (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-43d1e4e1c27sm63442304f8f.26.2026.04.09.02.39.30\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Thu, 09 Apr 2026 02:39:32 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1775727574; x=1776332374; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:from:references:cc:to\n :content-language:subject:user-agent:mime-version:date:message-id\n :from:to:cc:subject:date:message-id:reply-to;\n bh=6ELFGL2WrLDDYG6szntjODti3hgx+XgDueR1SctaY3k=;\n b=eC8YAIdB1WCTm0JNeJiXcxRRph+iAEaPh023Durdi3aw5pAMGCd8XJqeusrQEECCGM\n 6fj6/pgDciUqqTPs9vPH++KUCSkWqLQYqpYpUDiX51NMZSdBNnQuSJ5NuU+Ay3LO3OLA\n 6xMMvln/Fc35YTjTWDlaZWV46pTIz4Bvd3D5DqaTqF0TNRsFxW4OIDZkJ5ySviKj00X2\n 2DsCELAeyFQr5Ii0mNanuTVgvBdYMXDPLG0QtEk+P4/1MSgTb6m2dwSI7jDMHyYkf7oZ\n /7HETIlQsvvgXEJ7wrFbSllwdYhxmYvtIx1fZiDSD0Bd6xT3mikSG2JZydB4z4m1B53y\n y11g==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775727574; x=1776332374;\n h=content-transfer-encoding:in-reply-to:from:references:cc:to\n :content-language:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=6ELFGL2WrLDDYG6szntjODti3hgx+XgDueR1SctaY3k=;\n b=gJGM4VFODaHOjg8fdZLKxjl85RT73EHD70iSppAMsYZH95HgHTsDCuMHUWozo7Ttud\n nzLV94xqe0U+Zyo4bjXX1U7a+62QrPaPuUIEidhIIrqbxTCr+dtkfkTttqzg5ATzhy2/\n zcG7K+JpEzr4wk97GV/Hpkofuoh77VRt3RG1dU6KG5OTboKCD7rd7NMoyjrbUPAcJSCB\n 5E7trZRSV41iDeRhv9wMx6xvkA3VMqWupZdkTGQ+6CG65vwygQIBcIV4MmakHj0PNAzn\n YxIuy+T/Wc7WLb1XzmMbBEJaHIZinskjij0EA1SXrYWhQC/Cx0SI6sGR+TLR0bCw7zXh\n n+EA==","X-Forwarded-Encrypted":"i=1;\n AJvYcCUql81QpRgsbmWr8LPlDQcd9zmBhSW2wSUCsdOKgL3js/0F6JliwhPFAt+mwVpu8hhN0a8Vl7vyRE9M@nongnu.org","X-Gm-Message-State":"AOJu0YyeW5o878GGJSNG1qsDzXlq8CkORRkdj7Q0/SCjp6OUagTzDdaG\n Y/hxmtYCg2ODasNwrQVx3aHdfEJO6CAiHJotcwUY+kq5DwVKHLcB5jb2NkWvvJAKfNw=","X-Gm-Gg":"AeBDievmokM8myKFlr7VNXg/9+JITzZeDvxiUPEd4HeFX23csLaE1bJU7isl+1oDqZP\n o7gnhTteR/+D/9e214C1xaO2vWQsgArzNemY4nQNT7ITU7O754D3wE1WqO4XNQOgBrlhUpMKKFX\n e2YrOfB4DRGD7i7McAjf98Fq1HIIWq4Ts2Q6yLe9f42yLX85yjYDD760Zm8oJnqeaccqN8kL2dS\n yiD9FhORg7okNgKuuCvUfy/K6ut0Hch97gOGmOBhxYjmiJjIXptSuh6Low6t3d8HrPR1X25aXXc\n PSTSUcLo3JUqekliQxQe8ZMACvqjqAIC0t9J041BYgouTtuTOGfUKSyXguBLS/pPv8+5Ab59OMn\n wp23+efZnvfDuxxA10d3OKPuRvHrxICK21A7gF3kIGzhy4P8VC6B1iU7gmXR4xrzie5tpyUxcZz\n gCuEDt2bKjDPq+VVLywrz6HcSczyb8Kw+NtpAYvhQsQSAyucto5QpdKyY592nzCSrDDwtKSIqCk\n Cjv","X-Received":"by 2002:a05:6000:41c2:b0:43d:184:8a89 with SMTP id\n ffacd0b85a97d-43d595eb258mr3274762f8f.30.1775727573586;\n Thu, 09 Apr 2026 02:39:33 -0700 (PDT)","Message-ID":"","Date":"Thu, 9 Apr 2026 11:39:29 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH 1/5] hw/arm: Fix unit addresses of FDT CPU nodes","Content-Language":"en-US","To":"Vivian Wang , qemu-devel@nongnu.org","Cc":"Peter Maydell ,\n Leif Lindholm , qemu-arm@nongnu.org,\n Song Gao , Bibo Mao ,\n Jiaxun Yang , Paul Burton ,\n Aleksandar Rikalo , Jia Liu ,\n Stafford Horne ,\n Alistair Francis ,\n Palmer Dabbelt , Weiwei Li ,\n Daniel Henrique Barboza ,\n Liu Zhiwei ,\n Chao Liu , qemu-riscv@nongnu.org","References":"<20260409-fix-unit-address-v1-0-946840930af2@iscas.ac.cn>\n <20260409-fix-unit-address-v1-1-946840930af2@iscas.ac.cn>","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","In-Reply-To":"<20260409-fix-unit-address-v1-1-946840930af2@iscas.ac.cn>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::431;\n envelope-from=philmd@linaro.org; helo=mail-wr1-x431.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}},{"id":3675211,"web_url":"http://patchwork.ozlabs.org/comment/3675211/","msgid":"","list_archive_url":null,"date":"2026-04-09T09:43:17","subject":"Re: [PATCH 1/5] hw/arm: Fix unit addresses of FDT CPU nodes","submitter":{"id":5111,"url":"http://patchwork.ozlabs.org/api/people/5111/","name":"Peter Maydell","email":"peter.maydell@linaro.org"},"content":"On Thu, 9 Apr 2026 at 10:39, Philippe Mathieu-Daudé wrote:\n>\n> On 9/4/26 08:40, Vivian Wang wrote:\n> > The node unit addresses should be based on the reg value (which is in\n> > turn based on MPIDR), rather than some arbitrary number [1]. Also, they\n> > should have been in hex, not decimal, as per de facto convention [2].\n> > Fix them.\n> >\n>\n> Maybe worth to add:\n>\n> Cc: qemu-stable@nongnu.org\n\nWhy? What bug is this fixing?\n\n-- PMM","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=l19sUWUi;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4frw4Q6Zf3z1yD3\n\tfor ; Thu, 09 Apr 2026 19:44:06 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wAlvI-0004PZ-BS; Thu, 09 Apr 2026 05:43:42 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wAlvC-0004HF-JK\n for qemu-devel@nongnu.org; Thu, 09 Apr 2026 05:43:36 -0400","from mail-yx1-xb12d.google.com ([2607:f8b0:4864:20::b12d])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1wAlv9-0002oY-GV\n for qemu-devel@nongnu.org; Thu, 09 Apr 2026 05:43:32 -0400","by mail-yx1-xb12d.google.com with SMTP id\n 956f58d0204a3-64edf260b49so1031139d50.0\n for ; Thu, 09 Apr 2026 02:43:30 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; t=1775727810; cv=none;\n d=google.com; s=arc-20240605;\n b=NINvLfCOjzMV2mINIp5c8SDqgdsden+C5g/r675CT55SJx7U32Hr72MR3gqLvi3mTR\n 40Dq74EXHO1vYH3jJ5xlSvAsP/B/cUJJ8vBKZCNA7He1XkP/6JKq6NXVh2i5G+906SAm\n vex2S+fkXjx6oZAnGM5ZMGDaSd+ytldQDXJ10r44I/vDOrndbBtt9ZOQvdFbfMIW7pyZ\n +DjmzFEckWU90WY5FC5X8w6eAAP1Ql04++nsx8vs/jN0nmMnWy/826YlcTRdzC61Y7U2\n CKYYdVoHBfKe7hLp0liKMS6S/WcJvTOcJm0Pze1nnyMN1ObmrLDNCtUQ0Y1m7HKTje1s\n x+4A==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:dkim-signature;\n bh=7DY5vgoK0OPxe5ysWxdHMOOyaxoUFNwyCJ8ueUu29KM=;\n fh=ZqPVTEDghJbO/O/Ejla232P63L6N6DvTIi6uVG9cmQs=;\n b=jC+4bUnypJSq14+o0frKExFqqX6kkDgXVyBi2m7C/Llsx66Rjw7v2pPWBTg0g2Uakc\n 4ixFFmQ5qtiNVHnhnLpNUTstDiWzKqLP4FPyoKfXajnV/8p0PFkMWj6TSSImqxlS4A86\n 0hkjTb/uJajBjapc5Q6VUgQfbwo7NpZW/X+GYQfVOkL0ycKPF1ljIYMtwio/R+Fo4v1B\n DUPF6UOUSxb5/21R7jYOH6Rs1rmPcFDipTvvIPMAdM4OLJOTHkFxVyWIx0qOIt3AUFwj\n 3kETslhDzZYnucQBkBLUE7ChH3fpPYWsg2kgXlShnV6FChtjvPpQ3Acd5TLfCTxhZkYd\n bNSQ==; darn=nongnu.org","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1775727810; x=1776332610; darn=nongnu.org;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:from:to:cc:subject:date\n :message-id:reply-to;\n bh=7DY5vgoK0OPxe5ysWxdHMOOyaxoUFNwyCJ8ueUu29KM=;\n b=l19sUWUiIP70LX6Q7jIhe5B0YGKWALm3Ya9u7DwqIXB9WGaB75RPVGONuiYXtFsKn/\n GXxuA5LoLXsrTS8WATbB+3w9CjLr1cbbqNJ/3aDsmuEldq8e12Q60c9DJgJrPEgNTbx+\n +SZndGgp7t6OpzdGsJsWGgGkuEsVHab+Z3RL4lD4pyJYaO10HSpYdBQvoaGjeQTNIExZ\n u5JJVgKognB6kr4GxVgy3fuGchgVTnEoBS8JcXrUyrYCf5qGoxd7+rUpq0G6RdkvnBa6\n IeohjhJTb+E3d9zDPHh6JvsNuMqKvup5N2X9upIuRiZxC9pT+TTtTaPAhFDo7h86rL/M\n 9OPQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775727810; x=1776332610;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=7DY5vgoK0OPxe5ysWxdHMOOyaxoUFNwyCJ8ueUu29KM=;\n b=qbQkOi7U//68iOyi6Jf+QpU6c30P3o2HJevH/+UYQI14tVZyBZ29fDIvbiFzy5Q1Ne\n 1+2vIyj7Km3JlrxdcXJlHIzq9SHogcf0wHYlt9902CAQ4R+oMqz56yjqHwRa5VU0Fwl7\n 9r/mRNYYBiqazHUHkU5RExHK10Nn0BJHupOXE7kTj60g0TMat9BE/DXBF130cS6a+Mzr\n ijU7pu6u+lTGsvzill9GNgUo5qyk6Icg0Y+GS+2Tv7HT2U1fjPCBa9/Bw7vy5H63BcFc\n hwxYH95Qb7tDpJJuk/UlThnm9HjhaTMiwsz8McJ21gdtc66TKgSg7J9D00IgtHrFYrtm\n u+4Q==","X-Forwarded-Encrypted":"i=1;\n AJvYcCUemYbb/j+PUei/xSIMhedcET8wNYou8KjByWa5iV0BVNuwK4rzNdlDZLQ8REat64hajttRlu08czNq@nongnu.org","X-Gm-Message-State":"AOJu0Yyt/kA4n3V6MewkxXSB1i9PLayCvf4tF71aEb8BYobSNu+zlJ/Y\n ffhSWACbmxtNeqJj3wfqKB3WPpLD48uPa6C+LPA1c/NmUQrXx5yt5mPkbaqdFvOhK4Y/UnhO5Xg\n XjIPVMf3Lg1zCZVN4tEkn27TfdOeUbOtVGsKL97/ueQ==","X-Gm-Gg":"AeBDietT5Blf1AtUjdhwyrSuWQlFit17+zPENS9omtdcusJTxrmfS1PyeizZJ3qRShv\n peGzMQYR05pLanHM/Pe9OyXhz6kzzr/L3vLHWRDsybFrqIBOxgLTm9JhqZMGtpdZRTEhmdqahJM\n hNYh6HYW9g+2RC8lPwsXBrCOtNz9GztQjOr5R0PwQ+7fgaS3mhwB8f7XAmfqGpATKS8gvNJ2E6D\n Z+0VPqJVWzkyjaVtIQ9YPt53OMWgDtqsJgIDYkbZMS3kfRJfSvYgOEoNdLMfq4g+cQ4ypLSVfOx\n Wv8WsNR0GOW6zSz1wWmwK6jCeuJiXHQicoT8i8hiTFL97Uxn8177IfO020/Kmp7rAPA=","X-Received":"by 2002:a05:690e:1502:b0:650:26c1:ee84 with SMTP id\n 956f58d0204a3-6518714b9f5mr2069174d50.11.1775727809775; Thu, 09 Apr 2026\n 02:43:29 -0700 (PDT)","MIME-Version":"1.0","References":"<20260409-fix-unit-address-v1-0-946840930af2@iscas.ac.cn>\n <20260409-fix-unit-address-v1-1-946840930af2@iscas.ac.cn>\n ","In-Reply-To":"","From":"Peter Maydell ","Date":"Thu, 9 Apr 2026 10:43:17 +0100","X-Gm-Features":"AQROBzBTK_KqKGLcQvAFpVWYtJwjO6_0s710KQOQJSWNSOEWuGi3cV-mbZlTYvY","Message-ID":"\n ","Subject":"Re: [PATCH 1/5] hw/arm: Fix unit addresses of FDT CPU nodes","To":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","Cc":"Vivian Wang , qemu-devel@nongnu.org,\n Leif Lindholm , qemu-arm@nongnu.org,\n Song Gao , Bibo Mao ,\n Jiaxun Yang , Paul Burton ,\n Aleksandar Rikalo , Jia Liu ,\n Stafford Horne ,\n Alistair Francis ,\n Palmer Dabbelt , Weiwei Li ,\n Daniel Henrique Barboza ,\n Liu Zhiwei ,\n Chao Liu , qemu-riscv@nongnu.org","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","Received-SPF":"pass client-ip=2607:f8b0:4864:20::b12d;\n envelope-from=peter.maydell@linaro.org; helo=mail-yx1-xb12d.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}},{"id":3675215,"web_url":"http://patchwork.ozlabs.org/comment/3675215/","msgid":"<18a3a770-9d57-47d1-9edf-ac55edccb8f9@iscas.ac.cn>","list_archive_url":null,"date":"2026-04-09T09:46:35","subject":"Re: [PATCH 1/5] hw/arm: Fix unit addresses of FDT CPU nodes","submitter":{"id":91053,"url":"http://patchwork.ozlabs.org/api/people/91053/","name":"Vivian Wang","email":"wangruikang@iscas.ac.cn"},"content":"On 4/9/26 17:39, Philippe Mathieu-Daudé wrote:\n> On 9/4/26 08:40, Vivian Wang wrote:\n>> The node unit addresses should be based on the reg value (which is in\n>> turn based on MPIDR), rather than some arbitrary number [1]. Also, they\n>> should have been in hex, not decimal, as per de facto convention [2].\n>> Fix them.\n>>\n>\n> Maybe worth to add:\n>\n>     Cc: qemu-stable@nongnu.org\n>\nAs Peter Maydell mentioned in other replies in this thread, most\nsoftware don't really care about these node names, so I don't think this\nneeds backporting to stable.\n\nI'm unsure if this is still worth fixing then. Peter expressed that it's\nnot something worth fixing.\n\nThanks for your review,\nVivian \"dramforever\" Wang\n\n>> Link:\n>> https://github.com/devicetree-org/devicetree-specification/blob/v0.4/source/chapter2-devicetree-basics.rst#devicetree-structure-and-conventions\n>> # [1]\n>> Link:\n>> https://lore.kernel.org/devicetree-spec/CAL_JsqJFv3+UJ-bjLGk0i7Wc+spsowCrqQZ_s3P4gN8r1W-Q-w@mail.gmail.com/\n>> # [2]\n>> Signed-off-by: Vivian Wang \n>> ---\n>>   hw/arm/sbsa-ref.c | 4 ++--\n>>   hw/arm/virt.c     | 7 +++++--\n>>   2 files changed, 7 insertions(+), 4 deletions(-)\n>\n> Reviewed-by: Philippe Mathieu-Daudé ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":"legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)","Received":["from lists.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4frw8F1dZdz1xtJ\n\tfor ; Thu, 09 Apr 2026 19:47:23 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wAlyU-0005pU-Rc; Thu, 09 Apr 2026 05:46:58 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wAlyR-0005ow-7g; Thu, 09 Apr 2026 05:46:55 -0400","from smtp21.cstnet.cn ([159.226.251.21] helo=cstnet.cn)\n by eggs.gnu.org with esmtps (TLS1.2:DHE_RSA_AES_256_CBC_SHA1:256)\n (Exim 4.90_1) (envelope-from )\n id 1wAlyO-00053C-9I; Thu, 09 Apr 2026 05:46:54 -0400","from [10.213.22.34] (unknown [36.110.52.2])\n by APP-01 (Coremail) with SMTP id qwCowAAn0Wx8dddpsii6DA--.39971S2;\n Thu, 09 Apr 2026 17:46:36 +0800 (CST)"],"Message-ID":"<18a3a770-9d57-47d1-9edf-ac55edccb8f9@iscas.ac.cn>","Date":"Thu, 9 Apr 2026 17:46:35 +0800","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH 1/5] hw/arm: Fix unit addresses of FDT CPU nodes","To":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ,\n qemu-devel@nongnu.org","Cc":"Peter Maydell ,\n Leif Lindholm , qemu-arm@nongnu.org,\n Song Gao , Bibo Mao ,\n Jiaxun Yang , Paul Burton ,\n Aleksandar Rikalo , Jia Liu ,\n Stafford Horne ,\n Alistair Francis ,\n Palmer Dabbelt , Weiwei Li ,\n Daniel Henrique Barboza ,\n Liu Zhiwei ,\n Chao Liu , qemu-riscv@nongnu.org","References":"<20260409-fix-unit-address-v1-0-946840930af2@iscas.ac.cn>\n <20260409-fix-unit-address-v1-1-946840930af2@iscas.ac.cn>\n ","Content-Language":"en-US","From":"Vivian Wang ","In-Reply-To":"","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"quoted-printable","X-CM-TRANSID":"qwCowAAn0Wx8dddpsii6DA--.39971S2","X-Coremail-Antispam":"1UD129KBjvJXoW7ArWkCr4rXFWfAFWUJF47Arb_yoW8Jw1UpF\n Z7GFyYkF1Skr4xGa9I93WIqF17KrsYga1jq34ayw18WF98ZrySqr4I93s0gw1UXFs7GFWY\n vFZIv3Z5XFZ5ArJanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2\n 9KBjDU0xBIdaVrnRJUUUvmb7Iv0xC_Kw4lb4IE77IF4wAFF20E14v26ryj6rWUM7CY07I2\n 0VC2zVCF04k26cxKx2IYs7xG6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rw\n A2F7IY1VAKz4vEj48ve4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_Xr0_Ar1l84ACjcxK6xII\n jxv20xvEc7CjxVAFwI0_Cr0_Gr1UM28EF7xvwVC2z280aVAFwI0_GcCE3s1l84ACjcxK6I\n 8E87Iv6xkF7I0E14v26rxl6s0DM2AIxVAIcxkEcVAq07x20xvEncxIr21l5I8CrVACY4xI\n 64kE6c02F40Ex7xfMcIj6xIIjxv20xvE14v26r1Y6r17McIj6I8E87Iv67AKxVW8JVWxJw\n Am72CE4IkC6x0Yz7v_Jr0_Gr1lF7xvr2IY64vIr41lFIxGxcIEc7CjxVA2Y2ka0xkIwI1l\n c7CjxVAaw2AFwI0_GFv_Wryl42xK82IYc2Ij64vIr41l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr\n 1lx2IqxVAqx4xG67AKxVWUJVWUGwC20s026x8GjcxK67AKxVWUGVWUWwC2zVAF1VAY17CE\n 14v26r4a6rW5MIIYrxkI7VAKI48JMIIF0xvE2Ix0cI8IcVAFwI0_Jr0_JF4lIxAIcVC0I7\n IYx2IY6xkF7I0E14v26r4j6F4UMIIF0xvE42xK8VAvwI8IcIk0rVWUJVWUCwCI42IY6I8E\n 87Iv67AKxVWUJVW8JwCI42IY6I8E87Iv6xkF7I0E14v26r4UJVWxJrUvcSsGvfC2KfnxnU\n UI43ZEXa7IUYh_-JUUUUU==","X-Originating-IP":"[36.110.52.2]","X-CM-SenderInfo":"pzdqw2pxlnt03j6l2u1dvotugofq/","Received-SPF":"pass client-ip=159.226.251.21;\n envelope-from=wangruikang@iscas.ac.cn; helo=cstnet.cn","X-Spam_score_int":"-41","X-Spam_score":"-4.2","X-Spam_bar":"----","X-Spam_report":"(-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}},{"id":3675225,"web_url":"http://patchwork.ozlabs.org/comment/3675225/","msgid":"","list_archive_url":null,"date":"2026-04-09T10:01:09","subject":"Re: [PATCH 1/5] hw/arm: Fix unit addresses of FDT CPU nodes","submitter":{"id":5111,"url":"http://patchwork.ozlabs.org/api/people/5111/","name":"Peter Maydell","email":"peter.maydell@linaro.org"},"content":"On Thu, 9 Apr 2026 at 10:46, Vivian Wang wrote:\n>\n> On 4/9/26 17:39, Philippe Mathieu-Daudé wrote:\n> > On 9/4/26 08:40, Vivian Wang wrote:\n> >> The node unit addresses should be based on the reg value (which is in\n> >> turn based on MPIDR), rather than some arbitrary number [1]. Also, they\n> >> should have been in hex, not decimal, as per de facto convention [2].\n> >> Fix them.\n> >>\n> >\n> > Maybe worth to add:\n> >\n> > Cc: qemu-stable@nongnu.org\n> >\n> As Peter Maydell mentioned in other replies in this thread, most\n> software don't really care about these node names, so I don't think this\n> needs backporting to stable.\n>\n> I'm unsure if this is still worth fixing then. Peter expressed that it's\n> not something worth fixing.\n\nFor the virt board, I think it depends whether the spec really says\nthat the node name must have the MPIDR in it and that consumers\ncan rely on that as a source of the MPIDR. I hope it does not.\nIf it's just a node name, then I don't see why it matters what\nnode name we generate as long as we're not generating the same\nnodename twice. We're not trying to generate DT files that are\nintended for submission upstream.\n\nThere are other places where our nodenames don't match the\nconventions upstream prefers; I generally prefer not to mess with\nthe existing working code in QEMU unless there's something actually\nbroken about what we're doing. Thread from the last time this came up:\n\nhttps://lore.kernel.org/qemu-devel/CAFEAcA9OWDiWh3S=0Co7Z27EtOp-1B9H7FxyQy1T2sFnTyNdqA@mail.gmail.com/\n\nEssentially, the set of things that it makes sense to have a\nconvention for and perhaps to validate for a hand-written DTS\nfile is stricter than the set of actual requirements for a\ngenerated DTB, and I prefer not to potentially break some\nguest code that's looking for a particular node name purely\nto bring us in to line with conventions intended for\nhand-written DTS files.\n\nthanks\n-- PMM","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=ITTbm/D4;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4frwVC4RF4z1xy1\n\tfor ; Thu, 09 Apr 2026 20:02:59 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wAmDd-0001CY-4g; Thu, 09 Apr 2026 06:02:37 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wAmCZ-00010k-6S\n for qemu-devel@nongnu.org; Thu, 09 Apr 2026 06:01:36 -0400","from mail-yx1-xb12d.google.com ([2607:f8b0:4864:20::b12d])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1wAmCS-0006sl-SF\n for qemu-devel@nongnu.org; Thu, 09 Apr 2026 06:01:28 -0400","by mail-yx1-xb12d.google.com with SMTP id\n 956f58d0204a3-65032e9cf01so630043d50.3\n for ; Thu, 09 Apr 2026 03:01:23 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; t=1775728882; cv=none;\n d=google.com; s=arc-20240605;\n b=ilw3BhbOKAEadslZBJr0PiV6+kdiVwsLt1qo7IfzOklRkHR+w4MlcIF80D/T1kVJtU\n hAaO2YQwzx3gLkLHO0L5p+/oNrRzDfo6OtL7DERVhrmfuLsJaJf+vU/1B/T7Sd6IcI82\n 8MIaUIf4BiP1gU2OdtORhyr4Azs1c8m1XfNJr6eVHxIbalMWUO8lRFuZhWURVDS8b2K+\n KoQwIX+KvRFoBz1XPHwYuPMUPxMvS6MRGK1rtp8CLwt2nF/1sqktID/O/oqGEyltl5Dp\n luySYznmQ5txziOQVfKc+MC2uZOtua87Gda/40ej4c3k2TB2QYJA/mTDDCgSO6WM9zGQ\n Cf1w==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:dkim-signature;\n bh=xYdyAJ1ZBVzWNAlvsnmeiUZEob1hhv0ZSCbc1WMT93M=;\n fh=JXvZJDaVkVWOnflwW69YBz01iw7i6OeI2P6voW+7aI8=;\n b=dGVQgPXRsYiRT6grdEOaRTs8bDtvMdyLg3s//eougZPFTHpy5dgOypjqRdVq/Sgys/\n 7lyMbAHHbQA0AnIxYhMLDAwoFwcBQ2tA4n4xVzN+XHwLoHbRPdPTzuzcrxmTYnngq+UW\n pu2eiAWdjpKrngjSRy6gtHn91ml30v5hgYswdRj+Kx/lmHLJRdMfxIo+YRhy9YZ85Xsq\n 9dr8aUngSzlPnFWucjO0AbRx2vbTjY4AqRtVzQclz/AZ0GV8suz11vkYjKWMsT+Wyd/l\n IqGx+gWZDn50ECSb/rRVgxhhyDbEJa7kbJAc6i/CST2/xuEhdo8f1NztEIVMLIikz3hh\n Y2gQ==; darn=nongnu.org","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1775728882; x=1776333682; darn=nongnu.org;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:from:to:cc:subject:date\n :message-id:reply-to;\n bh=xYdyAJ1ZBVzWNAlvsnmeiUZEob1hhv0ZSCbc1WMT93M=;\n b=ITTbm/D4OFYfZ5ZVSMih36tkrBwUWTScOLBvC7mhloBUZV6aR3Kf9Hj0ZR/zUZp28j\n O5Uw9GegU+7AqYPt1aeZE5aWh52a7lX62/cTkKXCvFcEtt6eor4LV/lOR/ButZgCGQdQ\n qhwdYMPeG26KO0TXum60C9tUr2wRhnZinDofrNtBiM99XV5upoDMI07X/1rxywlTDbwV\n cG0Vtemt/ADDGksiNCqdyhkQ0tE3QEskHUQ4LFfdPDfx7OV+CqieII1oCU2ibHoHAeDq\n pbrsQ+bd32MPomk6zo/rYrGCZXwpsG6ad0WiQUH/B6F2dgsGDvFKdjgHH+ITzxhhCdW+\n k6Tw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775728882; x=1776333682;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=xYdyAJ1ZBVzWNAlvsnmeiUZEob1hhv0ZSCbc1WMT93M=;\n b=IsUoF03NhXUsOdMiMhOd47Y0PCzWfJng7UAWoigqtoHB1QXEwZK1hYoPEny0W4jnEA\n MQ74YxiatTkR5cirZGkyMSrTfu05X0je6/RLng6zc9eM5Ysd0+wYa7Auu2IrG+C1bq8j\n 9+LBkNJDgQx0FH0KuoHb15Eb/DKP+1gkajFrOkK+Dd0CMwQO3YVCQ2U8yYQFgxsfiGcI\n KDHZxD9Nv0RAJyrUhS8D8uRU1anUmiNjPJc0Q5pdDr5KQyk0rTn8fNnDYRETsymuNoh4\n WhPFntdq7pAK9oGuPVhgqcL0/5g+bDhkaBmEKI4aTakvNNVgrUge705ClJ6R2y/C0UL0\n hAhA==","X-Forwarded-Encrypted":"i=1;\n AJvYcCVKCpm7U7fMxH+w30BOgLCMSqQJ4TNXeKMyL4sZHFOGYIEkL8jEgMXdogWPCAES29QqHfaVq8Pwjs21@nongnu.org","X-Gm-Message-State":"AOJu0YwJs+mnvd8fyXX0kUhCnDG+V3nAM+wloja9j7ADeo4aAJkSOfll\n qgEhX07uSAVQID94UIU5XvDAvukl4zMTQIxkneMucipp7PDY2uORYm4xm5YXDdaxKnVCjTssHMO\n lRqqOyTU2Rt2K5rfQnnTt8STJU+BC5YtFvbffhRIAjQ==","X-Gm-Gg":"AeBDievCFJd9ji1nIf4dGf5plrovvrzn6fghkpJYKInktYQ0o4QpdvKUjp93rA+1uH3\n NZk9MO7oPC9GLEMqkV7mvxbOW0XaI6JS+Up0ZHpy5NaNW2BfxLFCXz9tGEGShiim5GuLLxslEGV\n oZ+uF0rwgkViY+5xzQ39qfSCjuvCc4BJ00rC/KyuZAkZMuP4YGOAe8nGaDVkh5NWYkMwIFgBDd6\n hxvxzDpMC8XKceiYGnGycwH2Vooa59tW5DhQAEX3rFob9IuJa8Oi2cgeuDDL9gJpObIUqRAWU+3\n pYo++xW8+SaRz0Y83zp83d822mJBSC9VhCAc+4iSuLKWZ4oaIt4se2Qn5RD62D8RwnQ=","X-Received":"by 2002:a05:690e:1c1c:b0:650:5316:1756 with SMTP id\n 956f58d0204a3-6505316228bmr19792260d50.57.1775728881898; Thu, 09 Apr 2026\n 03:01:21 -0700 (PDT)","MIME-Version":"1.0","References":"<20260409-fix-unit-address-v1-0-946840930af2@iscas.ac.cn>\n <20260409-fix-unit-address-v1-1-946840930af2@iscas.ac.cn>\n \n <18a3a770-9d57-47d1-9edf-ac55edccb8f9@iscas.ac.cn>","In-Reply-To":"<18a3a770-9d57-47d1-9edf-ac55edccb8f9@iscas.ac.cn>","From":"Peter Maydell ","Date":"Thu, 9 Apr 2026 11:01:09 +0100","X-Gm-Features":"AQROBzCVASMzofaqQYGDV-WL1MRwPfn_32V7Z_sr4ZIpjr7tv-upq2Ck3Hldy7s","Message-ID":"\n ","Subject":"Re: [PATCH 1/5] hw/arm: Fix unit addresses of FDT CPU nodes","To":"Vivian Wang ","Cc":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ,\n qemu-devel@nongnu.org, Leif Lindholm ,\n qemu-arm@nongnu.org, Song Gao ,\n Bibo Mao , Jiaxun Yang ,\n Paul Burton , Aleksandar Rikalo ,\n Jia Liu , Stafford Horne ,\n Alistair Francis ,\n Palmer Dabbelt , Weiwei Li ,\n Daniel Henrique Barboza ,\n Liu Zhiwei ,\n Chao Liu , qemu-riscv@nongnu.org","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","Received-SPF":"pass client-ip=2607:f8b0:4864:20::b12d;\n envelope-from=peter.maydell@linaro.org; helo=mail-yx1-xb12d.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}},{"id":3675239,"web_url":"http://patchwork.ozlabs.org/comment/3675239/","msgid":"<4a1718a3-aac0-47ce-a18a-8c3be6278d2c@iscas.ac.cn>","list_archive_url":null,"date":"2026-04-09T10:13:14","subject":"Re: [PATCH 1/5] hw/arm: Fix unit addresses of FDT CPU nodes","submitter":{"id":91053,"url":"http://patchwork.ozlabs.org/api/people/91053/","name":"Vivian Wang","email":"wangruikang@iscas.ac.cn"},"content":"On 4/9/26 18:01, Peter Maydell wrote:\n> On Thu, 9 Apr 2026 at 10:46, Vivian Wang wrote:\n>> On 4/9/26 17:39, Philippe Mathieu-Daudé wrote:\n>>> On 9/4/26 08:40, Vivian Wang wrote:\n>>>> The node unit addresses should be based on the reg value (which is in\n>>>> turn based on MPIDR), rather than some arbitrary number [1]. Also, they\n>>>> should have been in hex, not decimal, as per de facto convention [2].\n>>>> Fix them.\n>>>>\n>>> Maybe worth to add:\n>>>\n>>> Cc: qemu-stable@nongnu.org\n>>>\n>> As Peter Maydell mentioned in other replies in this thread, most\n>> software don't really care about these node names, so I don't think this\n>> needs backporting to stable.\n>>\n>> I'm unsure if this is still worth fixing then. Peter expressed that it's\n>> not something worth fixing.\n> For the virt board, I think it depends whether the spec really says\n> that the node name must have the MPIDR in it and that consumers\n> can rely on that as a source of the MPIDR. I hope it does not.\n> If it's just a node name, then I don't see why it matters what\n> node name we generate as long as we're not generating the same\n> nodename twice. We're not trying to generate DT files that are\n> intended for submission upstream.\n>\n> There are other places where our nodenames don't match the\n> conventions upstream prefers; I generally prefer not to mess with\n> the existing working code in QEMU unless there's something actually\n> broken about what we're doing. Thread from the last time this came up:\n>\n> https://lore.kernel.org/qemu-devel/CAFEAcA9OWDiWh3S=0Co7Z27EtOp-1B9H7FxyQy1T2sFnTyNdqA@mail.gmail.com/\n>\n> Essentially, the set of things that it makes sense to have a\n> convention for and perhaps to validate for a hand-written DTS\n> file is stricter than the set of actual requirements for a\n> generated DTB, and I prefer not to potentially break some\n> guest code that's looking for a particular node name purely\n> to bring us in to line with conventions intended for\n> hand-written DTS files.\n\nThanks for the explanation. I can understand that these DTBs don't\nreally need to be held up to the same standards/pedantry as Linux\nupstream DTS files.\n\nThanks,\nVivian \"dramforever\" Wang","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":"legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)","Received":["from lists.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4frwkv6RgNz1yCv\n\tfor ; Thu, 09 Apr 2026 20:13:59 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wAmOJ-00069Y-3k; Thu, 09 Apr 2026 06:13:39 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wAmOF-00069K-Bo; Thu, 09 Apr 2026 06:13:35 -0400","from smtp21.cstnet.cn ([159.226.251.21] helo=cstnet.cn)\n by eggs.gnu.org with esmtps (TLS1.2:DHE_RSA_AES_256_CBC_SHA1:256)\n (Exim 4.90_1) (envelope-from )\n id 1wAmOA-0003uG-Jc; Thu, 09 Apr 2026 06:13:33 -0400","from [10.213.22.34] (unknown [36.110.52.2])\n by APP-01 (Coremail) with SMTP id qwCowADXfmq6e9dpZJm6DA--.7959S2;\n Thu, 09 Apr 2026 18:13:15 +0800 (CST)"],"Message-ID":"<4a1718a3-aac0-47ce-a18a-8c3be6278d2c@iscas.ac.cn>","Date":"Thu, 9 Apr 2026 18:13:14 +0800","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH 1/5] hw/arm: Fix unit addresses of FDT CPU nodes","To":"Peter Maydell ","Cc":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ,\n qemu-devel@nongnu.org, Leif Lindholm ,\n qemu-arm@nongnu.org, Song Gao ,\n Bibo Mao , Jiaxun Yang ,\n Paul Burton , Aleksandar Rikalo ,\n Jia Liu , Stafford Horne ,\n Alistair Francis ,\n Palmer Dabbelt , Weiwei Li ,\n Daniel Henrique Barboza ,\n Liu Zhiwei ,\n Chao Liu , qemu-riscv@nongnu.org","References":"<20260409-fix-unit-address-v1-0-946840930af2@iscas.ac.cn>\n <20260409-fix-unit-address-v1-1-946840930af2@iscas.ac.cn>\n \n <18a3a770-9d57-47d1-9edf-ac55edccb8f9@iscas.ac.cn>\n ","Content-Language":"en-US","From":"Vivian Wang ","In-Reply-To":"\n ","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"quoted-printable","X-CM-TRANSID":"qwCowADXfmq6e9dpZJm6DA--.7959S2","X-Coremail-Antispam":"1UD129KBjvJXoW7Cw47tw4rJrW5ZFWrWF48Zwb_yoW8tr48pa\n 93KF1IkFs2yr1xW34vva17Zw1Ikwn3Gr4UX3s0q342y398WF1fKF4Igryaga48Gw48GFWj\n van0qas5JF1Fv37anT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2\n 9KBjDU0xBIdaVrnRJUUU9Eb7Iv0xC_Kw4lb4IE77IF4wAFF20E14v26ryj6rWUM7CY07I2\n 0VC2zVCF04k26cxKx2IYs7xG6rWj6s0DM7CIcVAFz4kK6r1j6r18M28lY4IEw2IIxxk0rw\n A2F7IY1VAKz4vEj48ve4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_Gr0_Xr1l84ACjcxK6xII\n jxv20xvEc7CjxVAFwI0_Gr0_Cr1l84ACjcxK6I8E87Iv67AKxVW0oVCq3wA2z4x0Y4vEx4\n A2jsIEc7CjxVAFwI0_GcCE3s1le2I262IYc4CY6c8Ij28IcVAaY2xG8wAqx4xG64xvF2IE\n w4CE5I8CrVC2j2WlYx0E2Ix0cI8IcVAFwI0_Jrv_JF1lYx0Ec7CjxVAajcxG14v26r1j6r\n 4UMcIj6I8E87Iv67AKxVW8JVWxJwAm72CE4IkC6x0Yz7v_Jr0_Gr1lF7xvr2IY64vIr41l\n FIxGxcIEc7CjxVA2Y2ka0xkIwI1lc7CjxVAaw2AFwI0_GFv_Wryl42xK82IYc2Ij64vIr4\n 1l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr1lx2IqxVAqx4xG67AKxVWUJVWUGwC20s026x8GjcxK\n 67AKxVWUGVWUWwC2zVAF1VAY17CE14v26r4a6rW5MIIYrxkI7VAKI48JMIIF0xvE2Ix0cI\n 8IcVAFwI0_Jr0_JF4lIxAIcVC0I7IYx2IY6xkF7I0E14v26r4j6F4UMIIF0xvE42xK8VAv\n wI8IcIk0rVWUJVWUCwCI42IY6I8E87Iv67AKxVWUJVW8JwCI42IY6I8E87Iv6xkF7I0E14\n v26r4UJVWxJrUvcSsGvfC2KfnxnUUI43ZEXa7IUYmksPUUUUU==","X-Originating-IP":"[36.110.52.2]","X-CM-SenderInfo":"pzdqw2pxlnt03j6l2u1dvotugofq/","Received-SPF":"pass client-ip=159.226.251.21;\n envelope-from=wangruikang@iscas.ac.cn; helo=cstnet.cn","X-Spam_score_int":"-41","X-Spam_score":"-4.2","X-Spam_bar":"----","X-Spam_report":"(-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]