[{"id":3675209,"web_url":"http://patchwork.ozlabs.org/comment/3675209/","msgid":"<7fcff35b-383d-4dac-bfcc-3d889db35df0@linaro.org>","list_archive_url":null,"date":"2026-04-09T09:41:38","subject":"Re: [PATCH 5/5] hw/riscv: Use hex unit addresses in FDT CPU nodes","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/people/85046/","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"content":"On 9/4/26 08:40, Vivian Wang wrote:\n> These unit addresses should have been in hex, not decimal, as per de\n> facto convention [1]. Fix them.\n> \n> Link: https://lore.kernel.org/devicetree-spec/CAL_JsqJFv3+UJ-bjLGk0i7Wc+spsowCrqQZ_s3P4gN8r1W-Q-w@mail.gmail.com/ # [1]\n> Signed-off-by: Vivian Wang \n> ---\n> hw/riscv/sifive_u.c | 9 +++++----\n> hw/riscv/spike.c | 4 ++--\n> hw/riscv/virt.c | 4 ++--\n> 3 files changed, 9 insertions(+), 8 deletions(-)\n> \n> diff --git a/hw/riscv/sifive_u.c b/hw/riscv/sifive_u.c\n> index 7ec67b2565..54f3bcc3b2 100644\n> --- a/hw/riscv/sifive_u.c\n> +++ b/hw/riscv/sifive_u.c\n> @@ -168,8 +168,9 @@ static void create_fdt(SiFiveUState *s, const MemMapEntry *memmap,\n> \n> for (cpu = ms->smp.cpus - 1; cpu >= 0; cpu--) {\n> int cpu_phandle = phandle++;\n> - nodename = g_strdup_printf(\"/cpus/cpu@%d\", cpu);\n> - char *intc = g_strdup_printf(\"/cpus/cpu@%d/interrupt-controller\", cpu);\n> + nodename = g_strdup_printf(\"/cpus/cpu@%x\", (unsigned)cpu);\n> + char *intc = g_strdup_printf(\"/cpus/cpu@%x/interrupt-controller\",\n> + (unsigned)cpu);\n\nNo need to cast to unsigned explicitly, otherwise:\nReviewed-by: Philippe Mathieu-Daudé ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=bR+sM89s;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4frw2V0y8hz1yD3\n\tfor ; Thu, 09 Apr 2026 19:42:26 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wAltd-00029p-Tg; Thu, 09 Apr 2026 05:41:57 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wAltY-0001zr-6L\n for qemu-devel@nongnu.org; Thu, 09 Apr 2026 05:41:53 -0400","from mail-wr1-x432.google.com ([2a00:1450:4864:20::432])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1wAltT-0002Gx-Ej\n for qemu-devel@nongnu.org; Thu, 09 Apr 2026 05:41:51 -0400","by mail-wr1-x432.google.com with SMTP id\n ffacd0b85a97d-43cf7683a28so415869f8f.2\n for ; Thu, 09 Apr 2026 02:41:42 -0700 (PDT)","from [192.168.69.228] (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-43d1e4e52a0sm62750693f8f.30.2026.04.09.02.41.39\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Thu, 09 Apr 2026 02:41:40 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1775727701; x=1776332501; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:from:references:cc:to\n :content-language:subject:user-agent:mime-version:date:message-id\n :from:to:cc:subject:date:message-id:reply-to;\n bh=+8+VUiGXz/KBYfn2QYKbors7gxAzS8hUuH0VayBvlUo=;\n b=bR+sM89sFAJfe4taRvSxdOciWJeCsxQ6PtdQ/h+LJ9ikrRXNn2UrdWaolhUb4nJFjZ\n VfY41S5a1Re9rBrrJEYi8PcGF/0RN4g2otc13PddbVzaZ8igq3zUji2B9qBThMAekmPC\n Ak+ndnLgKVeN9R9dip4OY/4XzycT/qRREmLN9xxU7jiaHDigGdlNfRAwL2/hmUTbv06c\n ncH+vc7bH0PEfwGZZyc6WpOhTsEYTLk/bvDqCPGhV/efdNkJpoRXHr8ZBWtEOIXjUmzS\n PNThvM6gcQmChtME1nQNugRz8IuDgMwSok+++/V/asNRCW+4sYooSkc6fPzzpPPgMfHU\n DkGg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775727701; x=1776332501;\n h=content-transfer-encoding:in-reply-to:from:references:cc:to\n :content-language:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=+8+VUiGXz/KBYfn2QYKbors7gxAzS8hUuH0VayBvlUo=;\n b=q/gIx4Fox3CaAC8EHW/0zOBJNz2OYKsGBGQ364T6vWKuxvf+ne+xU5/VdiuOZptrwk\n 024XppSBYj1lseeioAtXu6Bwpz6Ve2aS4yi3kXATp21DteG8baHcq+kroow6+uF3dFdA\n hiJxXYNKdt2uUG1TmqT2d9HL/xL+dgVjfRJ9QEuuKRusTNOJiU0blQTRNnXOm29eQro0\n tm+mNgacWYHwmJWQxDPb0S0m3gQAALJTgkHesjhPFjBLvoOLyWGdKKE9VfVQ/N6g0QsD\n HSCDkLxNKorZsaAgK85BD46nmpOnumXZu2SykVQC9i3Iabjc2E4qpakjTnHZvFr3xQIl\n hZXQ==","X-Forwarded-Encrypted":"i=1;\n AJvYcCUexqC4tpnC1jyeZZrgP3ri2fbNNEQ+d1J1cHiWiBqiFp8/WF/SSkWVNBsTR8aGG01XlH3br1/WqHPS@nongnu.org","X-Gm-Message-State":"AOJu0YzK4vg5yw0LNCMAbX2tk/OWBTf3XMSKBXj+CE4HrgaKSbaIbE81\n 3tClg1B5KMrpGvTQUV6LlwyDX6OrsyneOI8bAgJwGWqN6dLLYOVm4rJ7yLBquN6AMCk=","X-Gm-Gg":"AeBDievZtGlXzbBrliPC1MbMt8wULjH0BHNGcjOfCJL31lumrxMbMxe0Ux0dbRDfMSc\n yYNmqGGmVF/IEdBT5g5+q1jXHYAzOn3wnNenlDECXTlQG+Z11JYUawgfsq8ZtuzKrpaN32Al0QR\n pmOLSMMnGXxrMOstIXkBeleiJfdVLR78mM1qJdZtFEP/+azdllCwLUDP33x26uhHBgMaNe6EQzH\n 70Xcgi5L9rBMB8Szsq//hq59uBLBoxY2xjC5iThP4aB7M9pYiwRscJgT/qLqYCMFc6CpVeJ3N39\n PBcCC0R1grTxtZYjJPqclc8ueJtEjGwZ3X3gX4+3uXD2ac5tlzAvblL94S2MnXjoYLxuIj4ZrrY\n wPlPfwKVW5WEAzzB45wreEa2m1rpfC5qldrrn6qjcES8M9IDIxzPbLkH+8yXe8a+o4/98JzhkZ9\n 63sY6IcOD9VN/zrZgfOGTM5NiwbrKorlhl1aedS8pxdjFqXnea3adVEnxw5epybaReZA==","X-Received":"by 2002:a05:6000:4201:b0:43d:e31:68d1 with SMTP id\n ffacd0b85a97d-43d2928fd52mr34867086f8f.21.1775727700809;\n Thu, 09 Apr 2026 02:41:40 -0700 (PDT)","Message-ID":"<7fcff35b-383d-4dac-bfcc-3d889db35df0@linaro.org>","Date":"Thu, 9 Apr 2026 11:41:38 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH 5/5] hw/riscv: Use hex unit addresses in FDT CPU nodes","Content-Language":"en-US","To":"Vivian Wang , qemu-devel@nongnu.org","Cc":"Peter Maydell ,\n Leif Lindholm , qemu-arm@nongnu.org,\n Song Gao , Bibo Mao ,\n Jiaxun Yang , Paul Burton ,\n Aleksandar Rikalo , Jia Liu ,\n Stafford Horne ,\n Alistair Francis ,\n Palmer Dabbelt , Weiwei Li ,\n Daniel Henrique Barboza ,\n Liu Zhiwei ,\n Chao Liu , qemu-riscv@nongnu.org","References":"<20260409-fix-unit-address-v1-0-946840930af2@iscas.ac.cn>\n <20260409-fix-unit-address-v1-5-946840930af2@iscas.ac.cn>","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","In-Reply-To":"<20260409-fix-unit-address-v1-5-946840930af2@iscas.ac.cn>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::432;\n envelope-from=philmd@linaro.org; helo=mail-wr1-x432.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}},{"id":3675550,"web_url":"http://patchwork.ozlabs.org/comment/3675550/","msgid":"","list_archive_url":null,"date":"2026-04-09T23:10:40","subject":"Re: [PATCH 5/5] hw/riscv: Use hex unit addresses in FDT CPU nodes","submitter":{"id":64571,"url":"http://patchwork.ozlabs.org/api/people/64571/","name":"Alistair Francis","email":"alistair23@gmail.com"},"content":"On Thu, Apr 9, 2026 at 4:42 PM Vivian Wang wrote:\n>\n> These unit addresses should have been in hex, not decimal, as per de\n> facto convention [1]. Fix them.\n>\n> Link: https://lore.kernel.org/devicetree-spec/CAL_JsqJFv3+UJ-bjLGk0i7Wc+spsowCrqQZ_s3P4gN8r1W-Q-w@mail.gmail.com/ # [1]\n> Signed-off-by: Vivian Wang \n\nReviewed-by: Alistair Francis \n\nAlistair\n\n> ---\n> hw/riscv/sifive_u.c | 9 +++++----\n> hw/riscv/spike.c | 4 ++--\n> hw/riscv/virt.c | 4 ++--\n> 3 files changed, 9 insertions(+), 8 deletions(-)\n>\n> diff --git a/hw/riscv/sifive_u.c b/hw/riscv/sifive_u.c\n> index 7ec67b2565..54f3bcc3b2 100644\n> --- a/hw/riscv/sifive_u.c\n> +++ b/hw/riscv/sifive_u.c\n> @@ -168,8 +168,9 @@ static void create_fdt(SiFiveUState *s, const MemMapEntry *memmap,\n>\n> for (cpu = ms->smp.cpus - 1; cpu >= 0; cpu--) {\n> int cpu_phandle = phandle++;\n> - nodename = g_strdup_printf(\"/cpus/cpu@%d\", cpu);\n> - char *intc = g_strdup_printf(\"/cpus/cpu@%d/interrupt-controller\", cpu);\n> + nodename = g_strdup_printf(\"/cpus/cpu@%x\", (unsigned)cpu);\n> + char *intc = g_strdup_printf(\"/cpus/cpu@%x/interrupt-controller\",\n> + (unsigned)cpu);\n> qemu_fdt_add_subnode(fdt, nodename);\n> /* cpu 0 is the management hart that does not have mmu */\n> if (cpu != 0) {\n> @@ -198,7 +199,7 @@ static void create_fdt(SiFiveUState *s, const MemMapEntry *memmap,\n> cells = g_new0(uint32_t, ms->smp.cpus * 4);\n> for (cpu = 0; cpu < ms->smp.cpus; cpu++) {\n> nodename =\n> - g_strdup_printf(\"/cpus/cpu@%d/interrupt-controller\", cpu);\n> + g_strdup_printf(\"/cpus/cpu@%x/interrupt-controller\", (unsigned)cpu);\n> uint32_t intc_phandle = qemu_fdt_get_phandle(fdt, nodename);\n> cells[cpu * 4 + 0] = cpu_to_be32(intc_phandle);\n> cells[cpu * 4 + 1] = cpu_to_be32(IRQ_M_SOFT);\n> @@ -249,7 +250,7 @@ static void create_fdt(SiFiveUState *s, const MemMapEntry *memmap,\n> cells = g_new0(uint32_t, ms->smp.cpus * 4 - 2);\n> for (cpu = 0; cpu < ms->smp.cpus; cpu++) {\n> nodename =\n> - g_strdup_printf(\"/cpus/cpu@%d/interrupt-controller\", cpu);\n> + g_strdup_printf(\"/cpus/cpu@%x/interrupt-controller\", (unsigned)cpu);\n> uint32_t intc_phandle = qemu_fdt_get_phandle(fdt, nodename);\n> /* cpu 0 is the management hart that does not have S-mode */\n> if (cpu == 0) {\n> diff --git a/hw/riscv/spike.c b/hw/riscv/spike.c\n> index 35c696f891..cac01ea1ff 100644\n> --- a/hw/riscv/spike.c\n> +++ b/hw/riscv/spike.c\n> @@ -105,8 +105,8 @@ static void create_fdt(SpikeState *s, const MemMapEntry *memmap,\n> for (cpu = s->soc[socket].num_harts - 1; cpu >= 0; cpu--) {\n> cpu_phandle = phandle++;\n>\n> - cpu_name = g_strdup_printf(\"/cpus/cpu@%d\",\n> - s->soc[socket].hartid_base + cpu);\n> + cpu_name = g_strdup_printf(\"/cpus/cpu@%\" PRIx32,\n> + s->soc[socket].hartid_base + (uint32_t)cpu);\n> qemu_fdt_add_subnode(fdt, cpu_name);\n> if (is_32_bit) {\n> qemu_fdt_setprop_string(fdt, cpu_name, \"mmu-type\", \"riscv,sv32\");\n> diff --git a/hw/riscv/virt.c b/hw/riscv/virt.c\n> index a1c323e66d..42a83dd829 100644\n> --- a/hw/riscv/virt.c\n> +++ b/hw/riscv/virt.c\n> @@ -248,8 +248,8 @@ static void create_fdt_socket_cpus(RISCVVirtState *s, int socket,\n>\n> cpu_phandle = (*phandle)++;\n>\n> - cpu_name = g_strdup_printf(\"/cpus/cpu@%d\",\n> - s->soc[socket].hartid_base + cpu);\n> + cpu_name = g_strdup_printf(\"/cpus/cpu@%\" PRIx32,\n> + s->soc[socket].hartid_base + (uint32_t)cpu);\n> qemu_fdt_add_subnode(ms->fdt, cpu_name);\n>\n> if (satp_mode_max != -1) {\n>\n> --\n> 2.53.0\n>\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=Tu289g1w;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fsG0b4SDtz1xtJ\n\tfor ; Fri, 10 Apr 2026 09:11:57 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wAyWw-0004yn-Nu; Thu, 09 Apr 2026 19:11:23 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wAyWt-0004yL-2B\n for qemu-devel@nongnu.org; Thu, 09 Apr 2026 19:11:19 -0400","from mail-ej1-x630.google.com ([2a00:1450:4864:20::630])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1wAyWl-00062z-6h\n for qemu-devel@nongnu.org; Thu, 09 Apr 2026 19:11:13 -0400","by mail-ej1-x630.google.com with SMTP id\n a640c23a62f3a-b982b0889d8so194270766b.2\n for ; Thu, 09 Apr 2026 16:11:09 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; t=1775776268; cv=none;\n d=google.com; s=arc-20240605;\n b=af0bXdrFHc+o1sh8sL8iZKuOl4JsRbzHbXnBnlkTbhTlVS8JUuubVliyFbk/spe5tE\n kOhadgfY3Y6JCoA611uW606KxHzhbPwTy/ygaK+7gXJ4RzX3a6nCxCu/OdrOl+0bjS/7\n LMjQX4JAHmJ6Br+tV71dpJymxjKlgPEYg1JXHEiRwPGjjAmS7dMbZt825V8qTl6CyzKU\n WwNmBeX70SCDtPfYs/K10iJiVEfGEf6RFGuWLpcHF6TxYtZGkUMzdfCwEnECKSKhRD/O\n /Jb/f2HhQffjcvo7JUPBm4U/OuCKfdf6XBXQ3nlO0IQ4mPw2FP90JgmGOIK7683XqA6c\n X7dw==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:dkim-signature;\n bh=/KR+60lP4zq7vXYcivRUWvNT63Pne3rX1vPM0BghTmw=;\n fh=xvOUwrcwxtg+VZcGdo9zS5Ms/Ss2nmX2J2qzOxbT/C8=;\n b=jAe3Pjg3lTp8GxssO5DZRQRMOorFw6/blz2Xpi/tkIQdgqwoccdIpHt3oWHdmMIcUk\n Q/ZNKhnoUuvUjT6Y7PialpZCh2NJgJxsGQOEkUBoy2iM5+rO7gC74If97hFPJnLfsR6p\n lvCYYm6d3IC2wNhzqFUxgjtEe22uZgJN3lKTz7qJ6CdvFSQJXWcvBChe2wn3CnBvYJuH\n K5kM+lCwhYfzgIHCq9cO01867CLdsSbWwcsyBGkw54FWtUVsKuEOtDYCvH7ASzjNqQlE\n nwMc7CiyTlqP8jhImPQ+H5lF3HxthqaGdo23s8KODBUa1JHVnbXfzBR/INvgFIcHnvSP\n j3/g==; darn=nongnu.org","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1775776268; x=1776381068; darn=nongnu.org;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:from:to:cc:subject:date\n :message-id:reply-to;\n bh=/KR+60lP4zq7vXYcivRUWvNT63Pne3rX1vPM0BghTmw=;\n b=Tu289g1wHpKBb6ioud9lBSN3QscAeQIbvYXx6Qe1Tzsd/LHsTpLcsFDJDO/VoImLJU\n u8oINkN6JWRrbA8w4vCIyxO5eHMO5UBk+dxPIWwXjL/jE9LX30fPyFgeDNJrhAhdlNa8\n l/vlZSOLl+8kh80Cif7exJ2OPSbePgzU/Ujm4p9ol7DAIMCkgCJFXyd8C/AjvUSpuIIu\n iZQpEcj1ns+Yj0KHQe/gfYDmb9l7HTs3Z3K6Jl4ZLBJgE8BjxgS+jmWeljJSejZq0nYK\n KM46FpST7BtHfxbiDt1C8Z/92yL6CIGOzX62mMQ6uaU0kF1t42q0BZ0WOHXSKtA86N7P\n ggJQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775776268; x=1776381068;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=/KR+60lP4zq7vXYcivRUWvNT63Pne3rX1vPM0BghTmw=;\n b=Mn/xKxgZWo3aWxkYy6VS5sOOvU01OchtzH8c5NC0Y/jgF87D4IODeLRXJhUltbz1Sa\n cBW6fSFsoe09W4dA5ooZ1o/No+vNnczqwHIbl8flonbxWk7wlxABQ8fCf48C6iPmS7Pb\n iaVjjHiJc1KezB9gSjP9rCX3K1xDUQFYhDlh2JPrgz2hgxptK/nIxaHpurbQokBnGPoK\n uHQoTlHP6jsNbBxEqyFOcEKWw6gVxt1IldLmaeC8pv5+ndSG7iRQLw8qnFBj/m8zEobV\n BPkq2HxVKEVDOXqi6/E1sUKJCAWweRYMjaGCC9hMfE59mKji0foUFvr6Cy9Svn4XhXZX\n JWvA==","X-Gm-Message-State":"AOJu0Yx4QgPb86ad1t0WNQPCT3n6BSVebin+Ug9nfnOcFuQPVrNDh9Cd\n MzhrZ7ygZlFX8bX4xt4pFVOLvrova1WhTgffsC45idsqoZqG6jNCcUCSVNV1ZUlPIO3mDZ9W8RG\n xpZ6mJngg7oxRZ5ilNlq4ooiHife2ffI=","X-Gm-Gg":"AeBDievyN4kCKUY/DAV6/RnCdtYTFvWr4wzIAkavCJAHa+TjrcfwqNKvdsEiZVTHUZH\n 5REzNWCpLx/L0/BtV4vzMYoLGWzJbwCd7ElN4Beb3hh8zEOOm21iTMdUDHwYhEMgjmNjaRWJEi/\n AaHW4KiSoXHUwk9gpmTJi/UcmagGmmnm29vPykAoQbh5JchaTZHHeqws0GgVLXYcFKI2EKS+GLL\n 1qs5oBOXW4ehoqJTyVvJVJLrR7byfTde52Y/LI+JAmDihri5rxutEpd2RHrjOIPMSlhd+5LjsSU\n rUufckra/Wb0RhsYPlc=","X-Received":"by 2002:a17:907:9608:b0:b9c:b88c:6364 with SMTP id\n a640c23a62f3a-b9d7249921cmr61420666b.22.1775776267420; Thu, 09 Apr 2026\n 16:11:07 -0700 (PDT)","MIME-Version":"1.0","References":"<20260409-fix-unit-address-v1-0-946840930af2@iscas.ac.cn>\n <20260409-fix-unit-address-v1-5-946840930af2@iscas.ac.cn>","In-Reply-To":"<20260409-fix-unit-address-v1-5-946840930af2@iscas.ac.cn>","From":"Alistair Francis ","Date":"Fri, 10 Apr 2026 09:10:40 +1000","X-Gm-Features":"AQROBzDXAHNGs9bJ86tYCUcUqXcY2fo0XK7RCn50bqQwvzx_rhA2w66un2AP4tE","Message-ID":"\n ","Subject":"Re: [PATCH 5/5] hw/riscv: Use hex unit addresses in FDT CPU nodes","To":"Vivian Wang ","Cc":"qemu-devel@nongnu.org, Peter Maydell ,\n Leif Lindholm , qemu-arm@nongnu.org,\n Song Gao , Bibo Mao ,\n Jiaxun Yang , Paul Burton ,\n Aleksandar Rikalo , =?utf-8?q?Philippe_Mathieu-Daud?=\n\t=?utf-8?q?=C3=A9?= , Jia Liu ,\n Stafford Horne ,\n Alistair Francis ,\n Palmer Dabbelt , Weiwei Li ,\n Daniel Henrique Barboza ,\n Liu Zhiwei ,\n Chao Liu , qemu-riscv@nongnu.org","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","Received-SPF":"pass client-ip=2a00:1450:4864:20::630;\n envelope-from=alistair23@gmail.com; helo=mail-ej1-x630.google.com","X-Spam_score_int":"-17","X-Spam_score":"-1.8","X-Spam_bar":"-","X-Spam_report":"(-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]