[{"id":3675210,"web_url":"http://patchwork.ozlabs.org/comment/3675210/","msgid":"<7f7f6217-4432-449c-a3fe-83d97265a9d7@linaro.org>","list_archive_url":null,"date":"2026-04-09T09:40:52","subject":"Re: [PATCH 2/5] hw/loongarch: Use hex unit addresses in FDT CPU nodes","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/people/85046/","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"content":"On 9/4/26 08:40, Vivian Wang wrote:\n> These unit addresses should have been in hex, not decimal, as per de\n> facto convention [1]. Fix them.\n> \n> Link: https://lore.kernel.org/devicetree-spec/CAL_JsqJFv3+UJ-bjLGk0i7Wc+spsowCrqQZ_s3P4gN8r1W-Q-w@mail.gmail.com/ # [1]\n> Signed-off-by: Vivian Wang \n> ---\n> hw/loongarch/virt-fdt-build.c | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/hw/loongarch/virt-fdt-build.c b/hw/loongarch/virt-fdt-build.c\n> index 6c06b36fca..5875c6d9ae 100644\n> --- a/hw/loongarch/virt-fdt-build.c\n> +++ b/hw/loongarch/virt-fdt-build.c\n> @@ -66,7 +66,7 @@ static void fdt_add_cpu_nodes(const LoongArchVirtMachineState *lvms)\n> continue;\n> }\n> \n> - nodename = g_strdup_printf(\"/cpus/cpu@%d\", num);\n> + nodename = g_strdup_printf(\"/cpus/cpu@%x\", (unsigned)num);\n\nNo need to cast to unsigned explicitly, otherwise:\nReviewed-by: Philippe Mathieu-Daudé ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=XqXezwIw;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4frw2V4bzXz1yHG\n\tfor ; Thu, 09 Apr 2026 19:42:26 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wAlsi-0001Wp-CO; Thu, 09 Apr 2026 05:41:00 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wAlsg-0001WA-SR\n for qemu-devel@nongnu.org; Thu, 09 Apr 2026 05:40:58 -0400","from mail-wm1-x329.google.com ([2a00:1450:4864:20::329])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1wAlse-0001dI-Cf\n for qemu-devel@nongnu.org; Thu, 09 Apr 2026 05:40:58 -0400","by mail-wm1-x329.google.com with SMTP id\n 5b1f17b1804b1-48897fd88ebso7089365e9.2\n for ; Thu, 09 Apr 2026 02:40:55 -0700 (PDT)","from [192.168.69.228] (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-488cd0cb7b7sm20685215e9.3.2026.04.09.02.40.52\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Thu, 09 Apr 2026 02:40:53 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1775727654; x=1776332454; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:from:references:cc:to\n :content-language:subject:user-agent:mime-version:date:message-id\n :from:to:cc:subject:date:message-id:reply-to;\n bh=4s4U4hC2ghdczoWrVYARbsjOeBNZlC8PGpb2hWgnoWc=;\n b=XqXezwIwGgxY2ve+iwiy3//W1KTY7KaAlGDquBSxQ7C4oGL1ZSDWgxcYDQZzl7soAV\n AAu5IBojThJuntmT3xqWHdZ0viLzNCnd1SBcT42IDFP9q81JpRj6OLUmpk0dhxGgFJAP\n IRKVnhRt8lqJtnx2jeehQhb73rogHZu1DrBc+UyU/F97BztX1ev/bfMsyFoWprWjqA1n\n tFDopaHZN473+fIwe7AZBy7oMqnU7/7mlKDLxykH/4xdwuTD/IsLRJimzPlXcA70octQ\n R0TQWhRL5AwZELdNUH88SS0MiraU/dV7bwIwos3noPH0KWhEiNEyw70LCHgEuo2tCAzx\n e27w==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775727654; x=1776332454;\n h=content-transfer-encoding:in-reply-to:from:references:cc:to\n :content-language:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=4s4U4hC2ghdczoWrVYARbsjOeBNZlC8PGpb2hWgnoWc=;\n b=RpEkQ6RuEaXeoDdu229ll5vYVuQj8jSTegy0SHsBUJdKqbgVGdEYiRxnYa17Wa7GHO\n zNQyutTnmUnubOVph6IeA93CMfk3zGoQQtzp9vybGv8Wg6rr+klzwKIYhNX1h8edf9sp\n RkjzRnVQbjZt6xd5/LwhGFGL87Xet//7m4JNGL3f7BjU/LIzy8yG2FbRpSHZLKhAyRFf\n iJSOZUFVSKDpOcnh10ZMojJMG4JupLVp8PKVuO2k/tgp3QIT0wveyqTvuFgUPm8LyUgA\n XLjg08g+xk4Bb4ObEBYsFOSkuvddeL2/tSes7DM3hlcBZuf4P/055Dw2RXd1O4xpLUB2\n JRHw==","X-Forwarded-Encrypted":"i=1;\n AJvYcCVAoVjSfmaP03TNw1Q+EzOhMRGbLG+wBsiFCWbWBc61wiMtDDF/o5tq8hwZ7gnLx4eqmi6AM5V/V8g7@nongnu.org","X-Gm-Message-State":"AOJu0Yx8k5gZ0GEdCvRV2ViTbPb5B59Ev0loLfK9XiF25Ucsc6xd7MeE\n 2UYd3quiZnfKH2d3heLgOQdDN5ZEcBwjJAT68atx1KX2EEebIqjxzHSPeixWTTmvpF8=","X-Gm-Gg":"AeBDievp/nkRjCiafDXOCRKIrLncFp6cYJAVozS/0Pm9Fm9OlpWGruI3y4Uw41r/5qz\n eEvjIdM5MkLOo/Mf13qm1ck16YEufxj6CnrMXsF9wb8ZoNxt48m7u/1NUdh7dzCbUEbkcgjnboo\n 35sgtmilPMiHGRttBMA3kh2F70ExQ4T2i0cr2mh8DWqGSvriCuynx4l/4Mmwvg/FrO/EY6X3t12\n Unf9L6OEYdyfuzNsiAzCLug9Wgm8Q001n7SLLtszysLfKaw+2qRRU6R0IQsLsOn+ttyMYHrDfhn\n MmNavSh/NykNTDbiWtm8xQEJLyI5KyfRJ8LDU6OqxKlpCXRbquAvyJVT4jljh/5EntJUD80GBt+\n sx/vzConP0BoAOiG78/E8veXZljJFLmUGOH2Mo9c9Ak7Ui2LglBPBepxsAVtB97X4oYH33vghSw\n lFMpwxLDqCuiF17vw2sejWWgA0rrdOXMk58tGpDVuJfZqgP3HPUNbTFdA7Jttf/IejBQ==","X-Received":"by 2002:a05:600c:c081:b0:480:1c69:9d36 with SMTP id\n 5b1f17b1804b1-488ccfd947emr28902825e9.17.1775727654307;\n Thu, 09 Apr 2026 02:40:54 -0700 (PDT)","Message-ID":"<7f7f6217-4432-449c-a3fe-83d97265a9d7@linaro.org>","Date":"Thu, 9 Apr 2026 11:40:52 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH 2/5] hw/loongarch: Use hex unit addresses in FDT CPU nodes","Content-Language":"en-US","To":"Vivian Wang , qemu-devel@nongnu.org","Cc":"Peter Maydell ,\n Leif Lindholm , qemu-arm@nongnu.org,\n Song Gao , Bibo Mao ,\n Jiaxun Yang , Paul Burton ,\n Aleksandar Rikalo , Jia Liu ,\n Stafford Horne ,\n Alistair Francis ,\n Palmer Dabbelt , Weiwei Li ,\n Daniel Henrique Barboza ,\n Liu Zhiwei ,\n Chao Liu , qemu-riscv@nongnu.org","References":"<20260409-fix-unit-address-v1-0-946840930af2@iscas.ac.cn>\n <20260409-fix-unit-address-v1-2-946840930af2@iscas.ac.cn>","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","In-Reply-To":"<20260409-fix-unit-address-v1-2-946840930af2@iscas.ac.cn>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::329;\n envelope-from=philmd@linaro.org; helo=mail-wm1-x329.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]