[{"id":3675171,"web_url":"http://patchwork.ozlabs.org/comment/3675171/","msgid":"","list_archive_url":null,"date":"2026-04-09T08:33:18","subject":"Re: [PATCH v3 3/5] hw/ufs: Add idle operation","submitter":{"id":86755,"url":"http://patchwork.ozlabs.org/api/people/86755/","name":"Jeuk Kim","email":"jeuk20.kim@gmail.com"},"content":"On 4/9/2026 2:37 PM, Jaemyung Lee wrote:\n> When no I/O occurs, the UFS Device performs various internal operations.\n> To emulate this, adds a timer that periodically checks the current I/O\n> status of the device and call the ufs_process_idle() function when idle.\n>\n> Signed-off-by: Jaemyung Lee \n> ---\n> hw/ufs/ufs.c | 63 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++\n> hw/ufs/ufs.h | 2 ++\n> 2 files changed, 65 insertions(+)\n>\n> diff --git a/hw/ufs/ufs.c b/hw/ufs/ufs.c\n> index 69f82ab462d135fe6cda479891f9d8f26d19be9a..33887ac12a4bae647acb94b292f1d680bff9a007 100644\n> --- a/hw/ufs/ufs.c\n> +++ b/hw/ufs/ufs.c\n> @@ -1801,6 +1801,63 @@ static void ufs_sendback_req(void *opaque)\n> ufs_irq_check(u);\n> }\n> \n> +static void ufs_process_idle(UfsHc *u)\n> +{\n> + /* Currently do nothing */\n> + return;\n> +}\n> +\n> +static inline bool ufs_check_idle(UfsHc *u)\n> +{\n> + return !u->reg.utrldbr;\n> +}\n> +\n> +static inline bool ufs_mcq_check_idle(UfsHc *u)\n> +{\n> + if (!u->params.mcq) {\n> + return true;\n> + }\n> +\n> + for (int qid = 0; qid < ARRAY_SIZE(u->sq); qid++) {\n> + if (!ufs_mcq_sq_empty(u, qid) || !u->sq[qid]) {\n\nThis is still not correct.\n\nOnly actually created MCQ queues are non-NULL, so NULL entries must be \nskipped, not treated as non-idle.\n\nPlease change it like this:\nif (!u->sq[qid]) {\n     continue;\n}\nif (!ufs_mcq_sq_empty(u, qid)) {\n     return false;\n}\n\n\nand:\nif (!u->cq[qid]) {\n     continue;\n}\nif (!ufs_mcq_cq_empty(u, qid)) {\n     return false;\n}\nif (!QTAILQ_EMPTY(&u->cq[qid]->req_list)) {\n     return false;\n}\n\n\n> + return false;\n> + }\n> +\n> + /* internal ongoing MCQ request check */\n> + UfsSq *sq = u->sq[qid];\n> + for (int i = 0; i < sq->size; i++) {\n> + if (sq->req[i].state != UFS_REQUEST_IDLE) {\n> + return false;\n> + }\n> + }\n> + }\n> +\n> + for (int qid = 0; qid < ARRAY_SIZE(u->cq); qid++) {\n> + if (!ufs_mcq_cq_empty(u, qid) || !u->cq[qid]) {\n> + return false;\n> + }\n> +\n> + if (!QTAILQ_EMPTY(&u->cq[qid]->req_list)) {\n> + return false;\n> + }\n> + }\n> +\n> + return true;\n> +}\n> +\n> +#define UFS_IDLE_TIMER_TICK 100 /* 0.1s */\n> +static void ufs_idle_timer_cb(void *opaque)\n> +{\n> + UfsHc *u = opaque;\n> + int64_t now = qemu_clock_get_ms(QEMU_CLOCK_VIRTUAL_RT);\n> +\n> + if (ufs_check_idle(u) && ufs_mcq_check_idle(u)) {\n> + ufs_process_idle(u);\n> + }\n> +\n> + timer_mod(&u->idle_timer, now + UFS_IDLE_TIMER_TICK);\n> +}\n> +\n> static bool ufs_check_constraints(UfsHc *u, Error **errp)\n> {\n> if (u->params.nutrs > UFS_MAX_NUTRS) {\n> @@ -1863,6 +1920,7 @@ static void ufs_init_hc(UfsHc *u)\n> uint32_t cap = 0;\n> uint32_t mcqconfig = 0;\n> uint32_t mcqcap = 0;\n> + int64_t now = qemu_clock_get_ms(QEMU_CLOCK_VIRTUAL_RT);\n> \n> u->reg_size = pow2ceil(ufs_reg_size(u));\n> \n> @@ -1959,6 +2017,9 @@ static void ufs_init_hc(UfsHc *u)\n> * dynamically\n> */\n> u->temperature = UFS_TEMPERATURE;\n> +\n> + timer_init_ms(&u->idle_timer, QEMU_CLOCK_VIRTUAL_RT, ufs_idle_timer_cb, u);\n> + timer_mod(&u->idle_timer, now + UFS_IDLE_TIMER_TICK);\n> }\n> \n> static void ufs_realize(PCIDevice *pci_dev, Error **errp)\n> @@ -1986,6 +2047,8 @@ static void ufs_exit(PCIDevice *pci_dev)\n> {\n> UfsHc *u = UFS(pci_dev);\n> \n> + timer_del(&u->idle_timer);\n> +\n> qemu_free_irq(u->irq);\n> \n> qemu_bh_delete(u->doorbell_bh);\n> diff --git a/hw/ufs/ufs.h b/hw/ufs/ufs.h\n> index 13d964c5ae5ec430a98b2ef71987cb9279e9a317..b5f040302129f4d02732ddd20ef82eb33c41922a 100644\n> --- a/hw/ufs/ufs.h\n> +++ b/hw/ufs/ufs.h\n> @@ -148,6 +148,8 @@ typedef struct UfsHc {\n> UfsCq *cq[UFS_MAX_MCQ_QNUM];\n> \n> uint8_t temperature;\n> +\n> + QEMUTimer idle_timer;\n> } UfsHc;\n> \n> static inline uint32_t ufs_mcq_sq_tail(UfsHc *u, uint32_t qid)\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=K02rSbuq;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4frtWt6tJzz1yHG\n\tfor ; Thu, 09 Apr 2026 18:34:17 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wAkpP-0003Za-7o; Thu, 09 Apr 2026 04:33:31 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wAkpI-0003UV-3S\n for qemu-devel@nongnu.org; Thu, 09 Apr 2026 04:33:25 -0400","from mail-pj1-x102d.google.com ([2607:f8b0:4864:20::102d])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1wAkpF-0007Kn-7N\n for qemu-devel@nongnu.org; Thu, 09 Apr 2026 04:33:22 -0400","by mail-pj1-x102d.google.com with SMTP id\n 98e67ed59e1d1-35c238f1063so532230a91.1\n for ; Thu, 09 Apr 2026 01:33:20 -0700 (PDT)","from [192.168.0.22] ([211.226.54.223])\n by smtp.gmail.com with ESMTPSA id\n 98e67ed59e1d1-35e34fa9ecdsm2313212a91.4.2026.04.09.01.33.16\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Thu, 09 Apr 2026 01:33:18 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1775723599; x=1776328399; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:from:references:cc:to\n :content-language:subject:user-agent:mime-version:date:message-id\n :from:to:cc:subject:date:message-id:reply-to;\n bh=Hb0hyvG4NVMGqig9mXj4GVha4CGNBj8WZM/iYnW7vAE=;\n b=K02rSbuqhv7y4tlUKw5CbJ9gqPl9xrtB96O4un0YoPDMd5/gVeEwKfNvLyfP9ZTChZ\n BhkhAy3hY6ikNxV1gv5rF2jEZpYdBTtR0fu8pzjKywGi/lciJDi01Uz1TVfu8yE/3B6d\n sS2Dl31V5bFarL1mAZi6Ldv2CalsvPg8AsNIo7M0dK/tjYRWtF76fdoyxH/VnPa3G8FE\n qMaVPHvS/0r6osA2t3wZJmMuUK9Mo63Nae8jaaiGrK3za561WDCKGPraScJnP4yE14o5\n GVMlpevC5iDA9rRt0qKxo7UBOuzbEL9r1ZUVEoky9x7Sh1JzIcnmWA9PXoSFrxi4XqRg\n VQbA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775723599; x=1776328399;\n h=content-transfer-encoding:in-reply-to:from:references:cc:to\n :content-language:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=Hb0hyvG4NVMGqig9mXj4GVha4CGNBj8WZM/iYnW7vAE=;\n b=O0a2QY6FvokMGz5t9+7OUMh/E6H0C6i7HoGgstZ3BUNu6wYQArBGXkp7Z1iWTw/7xn\n ZFrXBBKXF0TqlEipMyhqczwupvmQIY33hXaMKz1o4cOLmmJHRY0j58CCxGNTN/5Bm1Jq\n a+UkINJoO92bavHQLkxLU79rTrJxJo51EXFLrkqqqIYSEeh9Ik86pFSxK8YgnY0ZDUG+\n iaHPTYRN8S9A2zwj1CN9nueZO7r62DOEKcczNDpc7fUFCRU0UxVcgK+bTM5lIWsfi7Wt\n X5rGCR2A5fw34rBjYyrY1i3jspfQOoPKTZVnQFIzQFXr2WmFI8YK3OrMPKmNkern9qLI\n T6Eg==","X-Forwarded-Encrypted":"i=1;\n AJvYcCXumzqYSbBqk/8gqGe6/Rtrkq25Usy2aHAi5pSiXyst4ThzDR7c3xh0Itp9t3G4zm54FjnNywLbfnor@nongnu.org","X-Gm-Message-State":"AOJu0Yw8GR4lAgKrJ3yAZZ152GjlqWFYdGwQ7K8kI70gbcYnrFe3iJpn\n YVcWHGYmNL0//cCQZi3cm0DaVDjeVZvaci900WYcwr63QaOC22erlGKt","X-Gm-Gg":"AeBDieugXVhN/3hP8UfPqfCpbWpPLQ66YPjfSI9kBKogm1yjb1FHiViXgY9TqLKqdSf\n k4i7TVag+VlckpK8sw7O+3kYC1zpksLiKvvq717LPxeaSD6Ldkjw+6q5nG2JEAGOWITf8pba/j3\n inoxtAPZAX9U/gs+voxxoOWePHpfD1SSlEzj7p1E2Y/Sym8ACGE5eqs8+f8FunnIR5xNfGlDJYT\n apP1TWElUC9n2RPHWSl0HBRIjmCVmld6PTL487urkNwSvuD7ZW0LXlnnDeM5XWG/Gf37XSK8MNt\n Y0jGLnDbRx/DH45hnbBKc+cj5lZEQdl6Yoo7/PwoJGn5gJaYrUP8pZiuNCkGnMr/YulzBBZGQ7j\n KpuARQpyNzw+UfNO/Az0QeztIG+N53jAjPJt01qJ/8H/BDqsQGa7l/OGD0G+axerzqYN9YM6Vsn\n xZ+oRVKwZ4hD6gRh4hIXl2WsowOd9NRuL1U2YJfCLJKQ==","X-Received":"by 2002:a17:90b:3fce:b0:359:8eaa:7f42 with SMTP id\n 98e67ed59e1d1-35e35969d15mr2645072a91.18.1775723599088;\n Thu, 09 Apr 2026 01:33:19 -0700 (PDT)","Message-ID":"","Date":"Thu, 9 Apr 2026 17:33:18 +0900","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v3 3/5] hw/ufs: Add idle operation","Content-Language":"ko","To":"Jaemyung Lee , qemu-devel@nongnu.org","Cc":"Jeuk Kim , Kevin Wolf ,\n Hanna Reitz , qemu-block@nongnu.org,\n Fabiano Rosas , Laurent Vivier ,\n Paolo Bonzini , Jaemyung Lee ","References":"<20260409-write_booster-v3-0-dd2f1c0119c8@samsung.com>\n <20260409-write_booster-v3-3-dd2f1c0119c8@samsung.com>","From":"Jeuk Kim ","In-Reply-To":"<20260409-write_booster-v3-3-dd2f1c0119c8@samsung.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2607:f8b0:4864:20::102d;\n envelope-from=jeuk20.kim@gmail.com; helo=mail-pj1-x102d.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]