[{"id":3675582,"web_url":"http://patchwork.ozlabs.org/comment/3675582/","msgid":"","list_archive_url":null,"date":"2026-04-10T01:06:39","subject":"Re: [PATCH v4 2/2] ubifs: use strscpy() and kmemdup_nul() where\n appropriate","submitter":{"id":76854,"url":"http://patchwork.ozlabs.org/api/people/76854/","name":"Zhihao Cheng","email":"chengzhihao1@huawei.com"},"content":"在 2026/4/9 12:56, Dmitry Antipov 写道:\n> Go closer to the modern kernel API and use 'strscpy()' and 'kmemdup_nul()'\n> over an ad-hoc ensure-to-have-'\\0' quirks where appropriate.\n> \n> Signed-off-by: Dmitry Antipov \n> ---\n> v4: once again to not forget a filesystem-native (little) to CPU endian swap\n> v3: fix strscpy() usage as noticed by Zhihao\n> v2: initial version to join the series\n> ---\n> fs/ubifs/journal.c | 18 ++++++------------\n> fs/ubifs/replay.c | 3 +--\n> fs/ubifs/super.c | 8 ++------\n> 3 files changed, 9 insertions(+), 20 deletions(-)\n> \n> diff --git a/fs/ubifs/journal.c b/fs/ubifs/journal.c\n> index e28ab4395e5c..43e19c83ad6d 100644\n> --- a/fs/ubifs/journal.c\n> +++ b/fs/ubifs/journal.c\n> @@ -729,8 +729,7 @@ int ubifs_jnl_update(struct ubifs_info *c, const struct inode *dir,\n> \tdent->inum = deletion ? 0 : cpu_to_le64(inode->i_ino);\n> \tdent->type = get_dent_type(inode->i_mode);\n> \tdent->nlen = cpu_to_le16(fname_len(nm));\n> -\tmemcpy(dent->name, fname_name(nm), fname_len(nm));\n> -\tdent->name[fname_len(nm)] = '\\0';\n> +\tstrscpy(dent->name, fname_name(nm), le16_to_cpu(dent->nlen) + 1);\n\nI think we can use 'fname_len(nm) + 1' to replace \n'le16_to_cpu(dent->nlen) + 1'.\n> \tset_dent_cookie(c, dent);\n> \n> \tzero_dent_node_unused(dent);\n> @@ -1232,8 +1231,7 @@ int ubifs_jnl_xrename(struct ubifs_info *c, const struct inode *fst_dir,\n> \tdent1->inum = cpu_to_le64(fst_inode->i_ino);\n> \tdent1->type = get_dent_type(fst_inode->i_mode);\n> \tdent1->nlen = cpu_to_le16(fname_len(snd_nm));\n> -\tmemcpy(dent1->name, fname_name(snd_nm), fname_len(snd_nm));\n> -\tdent1->name[fname_len(snd_nm)] = '\\0';\n> +\tstrscpy(dent1->name, fname_name(snd_nm), le16_to_cpu(dent1->nlen) + 1);\n> \tset_dent_cookie(c, dent1);\n> \tzero_dent_node_unused(dent1);\n> \tubifs_prep_grp_node(c, dent1, dlen1, 0);\n> @@ -1248,8 +1246,7 @@ int ubifs_jnl_xrename(struct ubifs_info *c, const struct inode *fst_dir,\n> \tdent2->inum = cpu_to_le64(snd_inode->i_ino);\n> \tdent2->type = get_dent_type(snd_inode->i_mode);\n> \tdent2->nlen = cpu_to_le16(fname_len(fst_nm));\n> -\tmemcpy(dent2->name, fname_name(fst_nm), fname_len(fst_nm));\n> -\tdent2->name[fname_len(fst_nm)] = '\\0';\n> +\tstrscpy(dent2->name, fname_name(fst_nm), le16_to_cpu(dent2->nlen) + 1);\n> \tset_dent_cookie(c, dent2);\n> \tzero_dent_node_unused(dent2);\n> \tubifs_prep_grp_node(c, dent2, dlen2, 0);\n> @@ -1424,8 +1421,7 @@ int ubifs_jnl_rename(struct ubifs_info *c, const struct inode *old_dir,\n> \tdent->inum = cpu_to_le64(old_inode->i_ino);\n> \tdent->type = get_dent_type(old_inode->i_mode);\n> \tdent->nlen = cpu_to_le16(fname_len(new_nm));\n> -\tmemcpy(dent->name, fname_name(new_nm), fname_len(new_nm));\n> -\tdent->name[fname_len(new_nm)] = '\\0';\n> +\tstrscpy(dent->name, fname_name(new_nm), le16_to_cpu(dent->nlen) + 1);\n> \tset_dent_cookie(c, dent);\n> \tzero_dent_node_unused(dent);\n> \tubifs_prep_grp_node(c, dent, dlen1, 0);\n> @@ -1446,8 +1442,7 @@ int ubifs_jnl_rename(struct ubifs_info *c, const struct inode *old_dir,\n> \t\tdent2->type = DT_UNKNOWN;\n> \t}\n> \tdent2->nlen = cpu_to_le16(fname_len(old_nm));\n> -\tmemcpy(dent2->name, fname_name(old_nm), fname_len(old_nm));\n> -\tdent2->name[fname_len(old_nm)] = '\\0';\n> +\tstrscpy(dent2->name, fname_name(old_nm), le16_to_cpu(dent2->nlen) + 1);\n> \tset_dent_cookie(c, dent2);\n> \tzero_dent_node_unused(dent2);\n> \tubifs_prep_grp_node(c, dent2, dlen2, 0);\n> @@ -1897,8 +1892,7 @@ int ubifs_jnl_delete_xattr(struct ubifs_info *c, const struct inode *host,\n> \txent->inum = 0;\n> \txent->type = get_dent_type(inode->i_mode);\n> \txent->nlen = cpu_to_le16(fname_len(nm));\n> -\tmemcpy(xent->name, fname_name(nm), fname_len(nm));\n> -\txent->name[fname_len(nm)] = '\\0';\n> +\tstrscpy(xent->name, fname_name(nm), le16_to_cpu(xent->nlen) + 1);\n> \tzero_dent_node_unused(xent);\n> \tubifs_prep_grp_node(c, xent, xlen, 0);\n> \n> diff --git a/fs/ubifs/replay.c b/fs/ubifs/replay.c\n> index a9a568f4a868..ef6ae63792d1 100644\n> --- a/fs/ubifs/replay.c\n> +++ b/fs/ubifs/replay.c\n> @@ -463,8 +463,7 @@ static int insert_dent(struct ubifs_info *c, int lnum, int offs, int len,\n> \tr->sqnum = sqnum;\n> \tkey_copy(c, key, &r->key);\n> \tfname_len(&r->nm) = nlen;\n> -\tmemcpy(nbuf, name, nlen);\n> -\tnbuf[nlen] = '\\0';\n> +\tstrscpy(nbuf, name, nlen + 1);\n> \tfname_name(&r->nm) = nbuf;\n> \n> \tlist_add_tail(&r->list, &c->replay_list);\n> diff --git a/fs/ubifs/super.c b/fs/ubifs/super.c\n> index 03bf924756ca..da2f1067f054 100644\n> --- a/fs/ubifs/super.c\n> +++ b/fs/ubifs/super.c\n> @@ -168,13 +168,11 @@ struct inode *ubifs_iget(struct super_block *sb, unsigned long inum)\n> \t\tinode->i_op = &ubifs_file_inode_operations;\n> \t\tinode->i_fop = &ubifs_file_operations;\n> \t\tif (ui->xattr) {\n> -\t\t\tui->data = kmalloc(ui->data_len + 1, GFP_NOFS);\n> +\t\t\tui->data = kmemdup_nul(ino->data, ui->data_len, GFP_NOFS);\n> \t\t\tif (!ui->data) {\n> \t\t\t\terr = -ENOMEM;\n> \t\t\t\tgoto out_ino;\n> \t\t\t}\n> -\t\t\tmemcpy(ui->data, ino->data, ui->data_len);\n> -\t\t\t((char *)ui->data)[ui->data_len] = '\\0';\n> \t\t} else if (ui->data_len != 0) {\n> \t\t\terr = 10;\n> \t\t\tgoto out_invalid;\n> @@ -194,13 +192,11 @@ struct inode *ubifs_iget(struct super_block *sb, unsigned long inum)\n> \t\t\terr = 12;\n> \t\t\tgoto out_invalid;\n> \t\t}\n> -\t\tui->data = kmalloc(ui->data_len + 1, GFP_NOFS);\n> +\t\tui->data = kmemdup_nul(ino->data, ui->data_len, GFP_NOFS);\n> \t\tif (!ui->data) {\n> \t\t\terr = -ENOMEM;\n> \t\t\tgoto out_ino;\n> \t\t}\n> -\t\tmemcpy(ui->data, ino->data, ui->data_len);\n> -\t\t((char *)ui->data)[ui->data_len] = '\\0';\n> \t\tbreak;\n> \tcase S_IFBLK:\n> \tcase S_IFCHR:\n>","headers":{"Return-Path":"\n ","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n secure) header.d=lists.infradead.org header.i=@lists.infradead.org\n header.a=rsa-sha256 header.s=bombadil.20210309 header.b=bus6+9fc;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n unprotected) header.d=huawei.com header.i=@huawei.com header.a=rsa-sha256\n header.s=dkim header.b=3YSM6JW3;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=temperror (SPF Temporary Error: DNS Timeout)\n smtp.mailfrom=lists.infradead.org (client-ip=2607:7c80:54:3::133;\n helo=bombadil.infradead.org;\n envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n [IPv6:2607:7c80:54:3::133])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fsJZ95glNz1yCv\n\tfor ; Fri, 10 Apr 2026 11:07:22 +1000 (AEST)","from localhost ([::1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux))\n\tid 1wB0Km-0000000BOcF-1F4F;\n\tFri, 10 Apr 2026 01:06:56 +0000","from canpmsgout03.his.huawei.com ([113.46.200.218])\n\tby bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux))\n\tid 1wB0Kj-0000000BObi-0XiB\n\tfor linux-mtd@lists.infradead.org;\n\tFri, 10 Apr 2026 01:06:55 +0000","from mail.maildlp.com (unknown [172.19.163.104])\n\tby canpmsgout03.his.huawei.com (SkyGuard) with ESMTPS id 4fsJPx4wr4zpSwq;\n\tFri, 10 Apr 2026 09:00:37 +0800 (CST)","from kwepemk500005.china.huawei.com (unknown [7.202.194.90])\n\tby mail.maildlp.com (Postfix) with ESMTPS id BDB474048F;\n\tFri, 10 Apr 2026 09:06:40 +0800 (CST)","from [10.174.178.46] (10.174.178.46) by\n kwepemk500005.china.huawei.com (7.202.194.90) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.1544.11; Fri, 10 Apr 2026 09:06:40 +0800"],"DKIM-Signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type:\n\tContent-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive:\n\tList-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From:\n\tReferences:CC:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date:\n\tResent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner;\n\tbh=GOcIQ6l+cYBP1eG8OZ1J3yK9OCjxiPpXc/m04jnUoJk=; b=bus6+9fcluQP5rddpWauIHyss/\n\tTjXZeiaDnQUVRe/UwOWPYyM1yR763CykO3u2Ge0CsQwzcOwHE8GFA9QA7TQxhU1w1am2pKplALkVQ\n\taVxtkSM2/Y5FiNwrLEh/nRK/owYJpy5siZWba/FhMSnFOdVu/DbOogHzpug0NBev/JW+asSgCtaMT\n\t0QCguCWXrP55S+wb2K5+rYtb5vA/4PfrpymdYxIMN7RKPdglQGPsociTI7eevm7rHVsxSU3UzAYxz\n\tFKXUIhtSydS0rAEFj/TFkQkgTD/szfku+/JcoNOJ1D66MZ8h3wItsZDZdFd+2XaWQNf9zWUa3PVj2\n\tJfz0dNjA==;","v=1; a=rsa-sha256; d=huawei.com; s=dkim;\n\tc=relaxed/relaxed; q=dns/txt;\n\th=From;\n\tbh=fsxoXGD/fPWpV5xyEdnFJYBL5PDJH6ffP46dWCdx3SE=;\n\tb=3YSM6JW35iLVppJzaQ013Lmj3JLxwMeFjfVZJ/WgFHGttYpjzqVVyqXHqxsnC7oukQ6797kue\n\tNWo9GrxRTH4QfFWFbEzGuxZLy+uRnXjEnFuhmJ7JBbNtvSEN1zcjhMuAJLLlEU88NSYjuOcF5lq\n\tMc3bGUdeCGYNvi8T0Y5IvJk="],"dkim-signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type:\n\tContent-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive:\n\tList-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From:\n\tReferences:CC:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date:\n\tResent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner;\n\tbh=GOcIQ6l+cYBP1eG8OZ1J3yK9OCjxiPpXc/m04jnUoJk=; b=bus6+9fcluQP5rddpWauIHyss/\n\tTjXZeiaDnQUVRe/UwOWPYyM1yR763CykO3u2Ge0CsQwzcOwHE8GFA9QA7TQxhU1w1am2pKplALkVQ\n\taVxtkSM2/Y5FiNwrLEh/nRK/owYJpy5siZWba/FhMSnFOdVu/DbOogHzpug0NBev/JW+asSgCtaMT\n\t0QCguCWXrP55S+wb2K5+rYtb5vA/4PfrpymdYxIMN7RKPdglQGPsociTI7eevm7rHVsxSU3UzAYxz\n\tFKXUIhtSydS0rAEFj/TFkQkgTD/szfku+/JcoNOJ1D66MZ8h3wItsZDZdFd+2XaWQNf9zWUa3PVj2\n\tJfz0dNjA==;","v=1; a=rsa-sha256; d=huawei.com; s=dkim;\n\tc=relaxed/relaxed; q=dns/txt;\n\th=From;\n\tbh=fsxoXGD/fPWpV5xyEdnFJYBL5PDJH6ffP46dWCdx3SE=;\n\tb=3YSM6JW35iLVppJzaQ013Lmj3JLxwMeFjfVZJ/WgFHGttYpjzqVVyqXHqxsnC7oukQ6797kue\n\tNWo9GrxRTH4QfFWFbEzGuxZLy+uRnXjEnFuhmJ7JBbNtvSEN1zcjhMuAJLLlEU88NSYjuOcF5lq\n\tMc3bGUdeCGYNvi8T0Y5IvJk="],"Subject":"Re: [PATCH v4 2/2] ubifs: use strscpy() and kmemdup_nul() where\n appropriate","To":"Dmitry Antipov ","CC":"Richard Weinberger , ","References":"<5deffdfa-6a99-8205-1f71-ff1f07ce28d1@huawei.com>\n <20260409045629.527019-1-dmantipov@yandex.ru>\n <20260409045629.527019-2-dmantipov@yandex.ru>","From":"Zhihao Cheng ","Message-ID":"","Date":"Fri, 10 Apr 2026 09:06:39 +0800","User-Agent":"Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101\n Thunderbird/68.5.0","MIME-Version":"1.0","In-Reply-To":"<20260409045629.527019-2-dmantipov@yandex.ru>","X-Originating-IP":"[10.174.178.46]","X-ClientProxiedBy":"kwepems200002.china.huawei.com (7.221.188.68) To\n kwepemk500005.china.huawei.com (7.202.194.90)","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20260409_180653_794758_317B0094 ","X-CRM114-Status":"GOOD ( 16.64 )","X-Spam-Score":"-5.2 (-----)","X-Spam-Report":"=?unknown-8bit?q?Spam_detection_software=2C_running_on_the_sy?=\n\t=?unknown-8bit?q?stem_=22bombadil=2Einfradead=2Eorg=22=2C?=\n\t=?unknown-8bit?q?_has_NOT_identified_this_incoming_email_as_spam=2E__The_ori?=\n\t=?unknown-8bit?q?ginal?=\n\t=?unknown-8bit?q?_message_has_been_attached_to_this_so_you_can_view_it_or_la?=\n\t=?unknown-8bit?q?bel?=\n\t=?unknown-8bit?q?_similar_future_email=2E__If_you_have_any_questions=2C_see?=\n\t=?unknown-8bit?q?_the_administrator_of_that_system_for_details=2E?=\n\t=?unknown-8bit?q?_?=\n\t=?unknown-8bit?q?_Content_preview=3A__=E5=9C=A8_2026/4/9_12=3A56=2C_Dmitry_A?=\n\t=?unknown-8bit?q?ntipov_=E5=86=99=E9=81=93=3A_=3E_Go_closer_to?=\n\t=?unknown-8bit?q?_the_modern_kernel_API_and_use_=27strscpy=28=29=27_and_=27k?=\n\t=?unknown-8bit?q?memdup=5Fnul=28=29=27_=3E_over_an_ad-hoc?=\n\t=?unknown-8bit?q?_ensure-to-have-=27=5C0=27_quirks_where_appropriate=2E_=3E_?=\n\t=?unknown-8bit?q?=3E_Signed-off-by_=5B=2E=2E=2E=5D_?=\n\t=?unknown-8bit?q?_?=\n\t=?unknown-8bit?q?_Content_analysis_details=3A___=28-5=2E2_points=2C_5=2E0_re?=\n\t=?unknown-8bit?q?quired=29?=\n\t=?unknown-8bit?q?_?=\n\t=?unknown-8bit?q?_pts_rule_name______________description?=\n\t=?unknown-8bit?q?_----_----------------------_------------------------------?=\n\t=?unknown-8bit?q?--------------------?=\n\t=?unknown-8bit?q?_0=2E0_RCVD=5FIN=5FVALIDITY=5FSAFE=5FBLOCKED_RBL=3A_ADMINIS?=\n\t=?unknown-8bit?q?TRATOR_NOTICE=3A_The_query_to?=\n\t=?unknown-8bit?q?_Validity_was_blocked=2E__See?=\n\t=?unknown-8bit?q?_https=3A//knowledge=2Evalidity=2Ecom/hc/en-us/articles/209?=\n\t=?unknown-8bit?q?61730681243?=\n\t=?unknown-8bit?q?_for_more_information=2E?=\n\t=?unknown-8bit?q?_=5B113=2E46=2E200=2E218_listed_in_sa-accredit=2Ehabeas=2Ec?=\n\t=?unknown-8bit?q?om=5D?=\n\t=?unknown-8bit?q?_0=2E0_RCVD=5FIN=5FVALIDITY=5FCERTIFIED=5FBLOCKED_RBL=3A_AD?=\n\t=?unknown-8bit?q?MINISTRATOR_NOTICE=3A_The?=\n\t=?unknown-8bit?q?_query_to_Validity_was_blocked=2E__See?=\n\t=?unknown-8bit?q?_https=3A//knowledge=2Evalidity=2Ecom/hc/en-us/articles/209?=\n\t=?unknown-8bit?q?61730681243?=\n\t=?unknown-8bit?q?_for_more_information=2E?=\n\t=?unknown-8bit?q?_=5B113=2E46=2E200=2E218_listed_in_sa-trusted=2Ebondedsende?=\n\t=?unknown-8bit?q?r=2Eorg=5D?=\n\t=?unknown-8bit?q?_0=2E0_RCVD=5FIN=5FVALIDITY=5FRPBL=5FBLOCKED_RBL=3A_ADMINIS?=\n\t=?unknown-8bit?q?TRATOR_NOTICE=3A_The_query_to?=\n\t=?unknown-8bit?q?_Validity_was_blocked=2E__See?=\n\t=?unknown-8bit?q?_https=3A//knowledge=2Evalidity=2Ecom/hc/en-us/articles/209?=\n\t=?unknown-8bit?q?61730681243?=\n\t=?unknown-8bit?q?_for_more_information=2E?=\n\t=?unknown-8bit?q?_=5B113=2E46=2E200=2E218_listed_in_bl=2Escore=2Esenderscore?=\n\t=?unknown-8bit?q?=2Ecom=5D?=\n\t=?unknown-8bit?q?_-0=2E0_SPF=5FPASS_______________SPF=3A_sender_matches_SPF_?=\n\t=?unknown-8bit?q?record?=\n\t=?unknown-8bit?q?_0=2E0_SPF=5FHELO=5FNONE__________SPF=3A_HELO_does_not_publ?=\n\t=?unknown-8bit?q?ish_an_SPF_Record?=\n\t=?unknown-8bit?q?_-0=2E1_DKIM=5FVALID=5FEF__________Message_has_a_valid_DKIM?=\n\t=?unknown-8bit?q?_or_DK_signature_from?=\n\t=?unknown-8bit?q?_envelope-from_domain?=\n\t=?unknown-8bit?q?_0=2E1_DKIM=5FSIGNED____________Message_has_a_DKIM_or_DK_si?=\n\t=?unknown-8bit?q?gnature=2C_not_necessarily_valid?=\n\t=?unknown-8bit?q?_-0=2E1_DKIM=5FVALID=5FAU__________Message_has_a_valid_DKIM?=\n\t=?unknown-8bit?q?_or_DK_signature_from_author=27s?=\n\t=?unknown-8bit?q?_domain?=\n\t=?unknown-8bit?q?_-0=2E1_DKIM=5FVALID_____________Message_has_at_least_one_v?=\n\t=?unknown-8bit?q?alid_DKIM_or_DK_signature?=\n\t=?unknown-8bit?q?_-1=2E9_BAYES=5F00_______________BODY=3A_Bayes_spam_probabi?=\n\t=?unknown-8bit?q?lity_is_0_to_1=25?=\n\t=?unknown-8bit?q?_=5Bscore=3A_0=2E0000=5D?=\n\t=?unknown-8bit?q?_-3=2E1_NICE=5FREPLY=5FA___________Looks_like_a_legit_reply?=\n\t=?unknown-8bit?q?_=28A=29?=","X-BeenThere":"linux-mtd@lists.infradead.org","X-Mailman-Version":"2.1.34","Precedence":"list","List-Id":"Linux MTD discussion mailing list ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Content-Transfer-Encoding":"base64","Content-Type":"text/plain; charset=\"gbk\"; Format=\"flowed\"","Sender":"\"linux-mtd\" ","Errors-To":"linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"}},{"id":3675667,"web_url":"http://patchwork.ozlabs.org/comment/3675667/","msgid":"<2056092139.32098.1775800654235.JavaMail.zimbra@nod.at>","list_archive_url":null,"date":"2026-04-10T05:57:34","subject":"Re: [PATCH v4 2/2] ubifs: use strscpy() and kmemdup_nul() where\n appropriate","submitter":{"id":8164,"url":"http://patchwork.ozlabs.org/api/people/8164/","name":"Richard Weinberger","email":"richard@nod.at"},"content":"----- Ursprüngliche Mail -----\n> Von: \"chengzhihao1\" \n> An: \"Dmitry Antipov\" \n> CC: \"richard\" , \"linux-mtd\" \n> Gesendet: Freitag, 10. April 2026 03:06:39\n> Betreff: Re: [PATCH v4 2/2] ubifs: use strscpy() and kmemdup_nul() where appropriate\n\n> 在 2026/4/9 12:56, Dmitry Antipov 写道:\n>> Go closer to the modern kernel API and use 'strscpy()' and 'kmemdup_nul()'\n>> over an ad-hoc ensure-to-have-'\\0' quirks where appropriate.\n>> \n>> Signed-off-by: Dmitry Antipov \n\nDmitry, how are you testing these changes?\n\nThanks,\n//richard","headers":{"Return-Path":"\n ","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":"legolas.ozlabs.org;\n spf=none (no SPF record) smtp.mailfrom=lists.infradead.org\n (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org;\n envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n receiver=patchwork.ozlabs.org)","Received":["from bombadil.infradead.org (bombadil.infradead.org\n [IPv6:2607:7c80:54:3::133])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fsR1Y4MK5z1y2d\n\tfor ; Fri, 10 Apr 2026 15:58:16 +1000 (AEST)","from localhost ([::1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux))\n\tid 1wB4sK-0000000BeTL-42fi;\n\tFri, 10 Apr 2026 05:57:52 +0000","from mailout.nod.at ([116.203.167.152] helo=lithops.sigma-star.at)\n\tby bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux))\n\tid 1wB4sH-0000000BeSO-1k2u\n\tfor linux-mtd@lists.infradead.org;\n\tFri, 10 Apr 2026 05:57:51 +0000","from localhost (localhost [127.0.0.1])\n\tby lithops.sigma-star.at (Postfix) with ESMTP id CF5BA298599;\n\tFri, 10 Apr 2026 07:57:36 +0200 (CEST)","from lithops.sigma-star.at ([127.0.0.1])\n\tby localhost (lithops.sigma-star.at [127.0.0.1]) (amavisd-new, port 10032)\n\twith ESMTP id mkI-zZTGsW03; Fri, 10 Apr 2026 07:57:34 +0200 (CEST)","from localhost (localhost [127.0.0.1])\n\tby lithops.sigma-star.at (Postfix) with ESMTP id A33D229859E;\n\tFri, 10 Apr 2026 07:57:34 +0200 (CEST)","from lithops.sigma-star.at ([127.0.0.1])\n\tby localhost (lithops.sigma-star.at [127.0.0.1]) (amavisd-new, port 10026)\n\twith ESMTP id nxvVRf2y1HbB; Fri, 10 Apr 2026 07:57:34 +0200 (CEST)","from lithops.sigma-star.at (lithops.sigma-star.at [195.201.40.130])\n\tby lithops.sigma-star.at (Postfix) with ESMTP id 7DB8A298599;\n\tFri, 10 Apr 2026 07:57:34 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20210309; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:MIME-Version:Subject:References:\n\tIn-Reply-To:Message-ID:Cc:To:From:Date:Reply-To:Content-ID:\n\tContent-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc\n\t:Resent-Message-ID:List-Owner;\n\tbh=EY1zeo3Ccv0bu+RFHRKU6Nw34cEVHZuJTivBASc5CoM=; b=Ug1yqxogPSjL3ljHAxpOPc6l4q\n\t5FtTfyZPx7eT3ND9dBg50gS+ziJX3PY+UnzeELqzoy3+TYtWw4/+GMalbc71u+trYQxru9V0MFQgY\n\t/WLAgQLxaHg0rjmNK66fQfGAO+LhtjlJ1S9OLTbd0aB5yQtSeBLNnrdFMczW8QLfeQeFYS9P+3m+B\n\t7cg/MVVediAyBYIQmgO9X0YXlxMoG3gPtbXWOCEualti/fe4MtUXrZAn4kJLOpvAcOdQbypKSqlHm\n\tAgxTeEtsF+2BLgPupne8vijSh/9xm6FVinmpI22teDYDuvCp6jqZOZv89of0IC6MeK/xwtZaIfqcR\n\tFGJ0fC9Q==;","Date":"Fri, 10 Apr 2026 07:57:34 +0200 (CEST)","From":"Richard Weinberger ","To":"chengzhihao1 ,\n Dmitry Antipov ","Cc":"linux-mtd ","Message-ID":"<2056092139.32098.1775800654235.JavaMail.zimbra@nod.at>","In-Reply-To":"","References":"<5deffdfa-6a99-8205-1f71-ff1f07ce28d1@huawei.com>\n <20260409045629.527019-1-dmantipov@yandex.ru>\n <20260409045629.527019-2-dmantipov@yandex.ru>\n ","Subject":"Re: [PATCH v4 2/2] ubifs: use strscpy() and kmemdup_nul() where\n appropriate","MIME-Version":"1.0","X-Originating-IP":"[195.201.40.130]","X-Mailer":"Zimbra 8.8.12_GA_3807 (ZimbraWebClient - FF148\n (Linux)/8.8.12_GA_3809)","Thread-Topic":"ubifs: use strscpy() and kmemdup_nul() where appropriate","Thread-Index":"s7gVgcTU0IFrkoVKcOKRVCdAJKTqdA==","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20260409_225749_593228_46BD0057 ","X-CRM114-Status":"UNSURE ( 2.94 )","X-CRM114-Notice":"Please train this message.","X-Spam-Score":"-1.9 (-)","X-Spam-Report":"=?unknown-8bit?q?Spam_detection_software=2C_running_on_the_sy?=\n\t=?unknown-8bit?q?stem_=22bombadil=2Einfradead=2Eorg=22=2C?=\n\t=?unknown-8bit?q?_has_NOT_identified_this_incoming_email_as_spam=2E__The_ori?=\n\t=?unknown-8bit?q?ginal?=\n\t=?unknown-8bit?q?_message_has_been_attached_to_this_so_you_can_view_it_or_la?=\n\t=?unknown-8bit?q?bel?=\n\t=?unknown-8bit?q?_similar_future_email=2E__If_you_have_any_questions=2C_see?=\n\t=?unknown-8bit?q?_the_administrator_of_that_system_for_details=2E?=\n\t=?unknown-8bit?q?_?=\n\t=?unknown-8bit?q?_Content_preview=3A__-----_Urspr=C3=BCngliche_Mail_-----_?=\n\t=?unknown-8bit?q?=3E_Von=3A_=22chengzhihao1=22_=3Cchengzhihao1=40huawei=2Ec?=\n\t=?unknown-8bit?q?om=3E?=\n\t=?unknown-8bit?b?ID4gQW46ICJEbWl0cnkgQW50aXBvdiIgPGRtYW50aXBvdkB5YW5kZXgu?=\n\t=?unknown-8bit?b?cnU+ID4gQ0M6ICJyaWNoYXJkIiA8cmljaGFyZEBub2QuYXQ+LA==?=\n\t=?unknown-8bit?b?ICJsaW51eC1tdGQiIDxsaW51eC1tdGRAbGlzdHMuaW5mcmFkZWFkLm9y?=\n\t=?unknown-8bit?b?IFsuLi5dIA==?=\n\t=?unknown-8bit?q?_?=\n\t=?unknown-8bit?q?_Content_analysis_details=3A___=28-1=2E9_points=2C_5=2E0_re?=\n\t=?unknown-8bit?q?quired=29?=\n\t=?unknown-8bit?q?_?=\n\t=?unknown-8bit?q?_pts_rule_name______________description?=\n\t=?unknown-8bit?q?_----_----------------------_------------------------------?=\n\t=?unknown-8bit?q?--------------------?=\n\t=?unknown-8bit?q?_0=2E0_RCVD=5FIN=5FVALIDITY=5FCERTIFIED=5FBLOCKED_RBL=3A_AD?=\n\t=?unknown-8bit?q?MINISTRATOR_NOTICE=3A_The?=\n\t=?unknown-8bit?q?_query_to_Validity_was_blocked=2E__See?=\n\t=?unknown-8bit?q?_https=3A//knowledge=2Evalidity=2Ecom/hc/en-us/articles/209?=\n\t=?unknown-8bit?q?61730681243?=\n\t=?unknown-8bit?q?_for_more_information=2E?=\n\t=?unknown-8bit?q?_=5B116=2E203=2E167=2E152_listed_in_sa-trusted=2Ebondedsend?=\n\t=?unknown-8bit?q?er=2Eorg=5D?=\n\t=?unknown-8bit?q?_0=2E0_RCVD=5FIN=5FVALIDITY=5FSAFE=5FBLOCKED_RBL=3A_ADMINIS?=\n\t=?unknown-8bit?q?TRATOR_NOTICE=3A_The_query_to?=\n\t=?unknown-8bit?q?_Validity_was_blocked=2E__See?=\n\t=?unknown-8bit?q?_https=3A//knowledge=2Evalidity=2Ecom/hc/en-us/articles/209?=\n\t=?unknown-8bit?q?61730681243?=\n\t=?unknown-8bit?q?_for_more_information=2E?=\n\t=?unknown-8bit?q?_=5B116=2E203=2E167=2E152_listed_in_sa-accredit=2Ehabeas=2E?=\n\t=?unknown-8bit?q?com=5D?=\n\t=?unknown-8bit?q?_0=2E0_RCVD=5FIN=5FVALIDITY=5FRPBL=5FBLOCKED_RBL=3A_ADMINIS?=\n\t=?unknown-8bit?q?TRATOR_NOTICE=3A_The_query_to?=\n\t=?unknown-8bit?q?_Validity_was_blocked=2E__See?=\n\t=?unknown-8bit?q?_https=3A//knowledge=2Evalidity=2Ecom/hc/en-us/articles/209?=\n\t=?unknown-8bit?q?61730681243?=\n\t=?unknown-8bit?q?_for_more_information=2E?=\n\t=?unknown-8bit?q?_=5B116=2E203=2E167=2E152_listed_in_bl=2Escore=2Esenderscor?=\n\t=?unknown-8bit?q?e=2Ecom=5D?=\n\t=?unknown-8bit?q?_0=2E0_T=5FSPF=5FPERMERROR________SPF=3A_test_of_record_fai?=\n\t=?unknown-8bit?q?led_=28permerror=29?=\n\t=?unknown-8bit?q?_0=2E0_SPF=5FHELO=5FNONE__________SPF=3A_HELO_does_not_publ?=\n\t=?unknown-8bit?q?ish_an_SPF_Record?=\n\t=?unknown-8bit?q?_-1=2E9_BAYES=5F00_______________BODY=3A_Bayes_spam_probabi?=\n\t=?unknown-8bit?q?lity_is_0_to_1=25?=\n\t=?unknown-8bit?q?_=5Bscore=3A_0=2E0000=5D?=","X-BeenThere":"linux-mtd@lists.infradead.org","X-Mailman-Version":"2.1.34","Precedence":"list","List-Id":"Linux MTD discussion mailing list ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Sender":"\"linux-mtd\" ","Errors-To":"linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"}},{"id":3676517,"web_url":"http://patchwork.ozlabs.org/comment/3676517/","msgid":"","list_archive_url":null,"date":"2026-04-10T11:55:22","subject":"Re: [PATCH v4 2/2] ubifs: use strscpy() and kmemdup_nul() where\n appropriate","submitter":{"id":87610,"url":"http://patchwork.ozlabs.org/api/people/87610/","name":"Dmitry Antipov","email":"dmantipov@yandex.ru"},"content":"On Fri, 2026-04-10 at 07:57 +0200, Richard Weinberger wrote:\n\n> Dmitry, how are you testing these changes?\n\nBuild with:\n\nCONFIG_KASAN=y\n\nCONFIG_MTD_NAND_NANDSIM=m\n\nCONFIG_MTD_UBI=m\nCONFIG_MTD_UBI_WL_THRESHOLD=4096\nCONFIG_MTD_UBI_BEB_LIMIT=20\nCONFIG_UBIFS_FS=m\nCONFIG_UBIFS_FS_ADVANCED_COMPR=y\nCONFIG_UBIFS_FS_LZO=y\nCONFIG_UBIFS_FS_ZLIB=y\nCONFIG_UBIFS_FS_ZSTD=y\nCONFIG_UBIFS_ATIME_SUPPORT=y\nCONFIG_UBIFS_FS_XATTR=y\nCONFIG_UBIFS_FS_SECURITY=y\nCONFIG_UBIFS_FS_AUTHENTICATION=y\n\nand boot (QEMU VM), then:\n\n# modprobe nandsim second_id_byte=0xdc third_id_byte=0x80 fourth_id_byte=0x1d\n[ 24.282259] [nandsim] warning: read_byte: unexpected data output cycle, state is STATE_READY return 0x0\n[ 24.282787] [nandsim] warning: read_byte: unexpected data output cycle, state is STATE_READY return 0x0\n[ 24.283441] [nandsim] warning: read_byte: unexpected data output cycle, state is STATE_READY return 0x0\n[ 24.284083] [nandsim] warning: read_byte: unexpected data output cycle, state is STATE_READY return 0x0\n[ 24.284783] [nandsim] warning: read_byte: unexpected data output cycle, state is STATE_READY return 0x0\n[ 24.285473] nand: device found, Manufacturer ID: 0x98, Chip ID: 0xdc\n[ 24.285932] nand: Toshiba NAND 512MiB 3,3V 8-bit\n[ 24.286275] nand: 512 MiB, SLC, erase size: 128 KiB, page size: 2048, OOB size: 64\n[ 24.286749] flash size: 512 MiB\n[ 24.286925] page size: 2048 bytes\n[ 24.287104] OOB area size: 64 bytes\n[ 24.287337] sector size: 128 KiB\n[ 24.287578] pages number: 262144\n[ 24.287817] pages per sector: 64\n[ 24.288068] bus width: 8\n[ 24.288269] bits in sector size: 17\n[ 24.288527] bits in page size: 11\n[ 24.288775] bits in OOB size: 6\n[ 24.289024] flash size with OOB: 540672 KiB\n[ 24.289334] page address bytes: 5\n[ 24.289572] sector address bytes: 3\n[ 24.289837] options: 0x8\n[ 24.290676] Scanning device for bad blocks\n[ 24.311973] Creating 1 MTD partitions on \"NAND 512MiB 3,3V 8-bit\":\n[ 24.312376] 0x000000000000-0x000020000000 : \"NAND simulator partition 0\"\n\n# modprobe ubi mtd=0\n[ 44.884572] ubi0: attaching mtd0\n[ 44.893002] ubi0: scanning is finished\n[ 44.893308] ubi0: empty MTD device detected\n[ 44.947667] ubi0: attached mtd0 (name \"NAND 512MiB 3,3V 8-bit\", size 512 MiB)\n[ 44.948231] ubi0: PEB size: 131072 bytes (128 KiB), LEB size: 129024 bytes\n[ 44.948719] ubi0: min./max. I/O unit sizes: 2048/2048, sub-page size 512\n[ 44.949206] ubi0: VID header offset: 512 (aligned 512), data offset: 2048\n[ 44.949686] ubi0: good PEBs: 4096, bad PEBs: 0, corrupted PEBs: 0\n[ 44.950113] ubi0: user volume: 0, internal volumes: 1, max. volumes count: 128\n[ 44.950639] ubi0: max/mean erase counter: 0/0, WL threshold: 4096, image sequence number: 3902257690\n[ 44.951285] ubi0: available PEBs: 4012, total reserved PEBs: 84, PEBs reserved for bad PEB handling: 80\n[ 44.951946] ubi0: background thread \"ubi_bgt0d\" started, PID 1022\n\n# ubimkvol /dev/ubi0 -N test -m\nSet volume size to 517644288\nVolume ID 0, size 4012 LEBs (517644288 bytes, 493.6 MiB), LEB size 129024 bytes (126.0 KiB), dynamic, name \"test\", alignment 1\n\n# mount -t ubifs ubi0:test /mnt/ubifs\n[ 122.812026] UBIFS (ubi0:0): default file-system created\n[ 122.812377] UBIFS (ubi0:0): Mounting in unauthenticated mode\n[ 122.813415] UBIFS (ubi0:0): background thread \"ubifs_bgt0_0\" started, PID 1053\n[ 122.813963] UBIFS (ubi0:0): UBIFS: mounted UBI device 0, volume 0, name \"test\"\n[ 122.814334] UBIFS (ubi0:0): LEB size: 129024 bytes (126 KiB), min./max. I/O unit sizes: 2048 bytes/2048 bytes\n[ 122.814849] UBIFS (ubi0:0): FS size: 515579904 bytes (491 MiB, 3996 LEBs), max 4012 LEBs, journal size 25804800 bytes (24 MiB, 200 LEBs)\n[ 122.815701] UBIFS (ubi0:0): reserved for root: 4952683 bytes (4836 KiB)\n[ 122.816225] UBIFS (ubi0:0): media format: w5/r0 (latest is w5/r0), UUID 999464F1-4417-4523-B773-57C6EBD728DC, small LPT model\n[ 122.817041] UBIFS (ubi0:0): full atime support is enabled.\n\n# cp -a [~390M source tree] /mnt/ubifs\n# diff -ur [tree] /mnt/ubifs/[copy of that tree] ; no output hopefully means OK\n\n# umount /mnt/ubifs\n[ 179.322533] UBIFS (ubi0:0): un-mount UBI device 0\n[ 179.323801] UBIFS (ubi0:0): background thread \"ubifs_bgt0_0\" stops\n\n# mount -t ubifs ubi0:test /mnt/ubifs\n[ 185.313439] UBIFS (ubi0:0): Mounting in unauthenticated mode\n...\n\n# diff -ur [tree] /mnt/ubifs/[copy of that tree] ; likewise\n\netc.\n\nDmitry","headers":{"Return-Path":"\n ","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n secure) header.d=lists.infradead.org header.i=@lists.infradead.org\n header.a=rsa-sha256 header.s=bombadil.20210309 header.b=cGnufM3g;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n unprotected) header.d=yandex.ru header.i=@yandex.ru header.a=rsa-sha256\n header.s=mail header.b=N5DtlJcD;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=none (no SPF record) smtp.mailfrom=lists.infradead.org\n (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org;\n envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n receiver=patchwork.ozlabs.org)","\n mail-nwsmtp-smtp-production-main-89.sas.yp-c.yandex.net;\n dkim=pass header.i=@yandex.ru"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n [IPv6:2607:7c80:54:3::133])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fvKCM3DrSz1yDG\n\tfor ; Mon, 13 Apr 2026 17:43:22 +1000 (AEST)","from localhost ([::1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux))\n\tid 1wCBwq-0000000FAZj-0JjI;\n\tMon, 13 Apr 2026 07:43:08 +0000","from forward502b.mail.yandex.net ([178.154.239.146])\n\tby bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux))\n\tid 1wCBwm-0000000FAYh-0Jzi\n\tfor linux-mtd@lists.infradead.org;\n\tMon, 13 Apr 2026 07:43:06 +0000","from mail-nwsmtp-smtp-production-main-89.sas.yp-c.yandex.net\n (mail-nwsmtp-smtp-production-main-89.sas.yp-c.yandex.net\n [IPv6:2a02:6b8:c11:2281:0:640:870e:0])\n\tby forward502b.mail.yandex.net (Yandex) with ESMTPS id BD7AF81041;\n\tMon, 13 Apr 2026 10:42:56 +0300 (MSK)","by mail-nwsmtp-smtp-production-main-89.sas.yp-c.yandex.net\n (smtp/Yandex) with ESMTPSA id tgEA7hxRqW20-wbEI3tYp;\n\tMon, 13 Apr 2026 10:42:56 +0300"],"DKIM-Signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20210309; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:Date:MIME-Version:References:\n\tIn-Reply-To:Cc:To:From:Subject:Message-ID:Reply-To:Content-ID:\n\tContent-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc\n\t:Resent-Message-ID:List-Owner;\n\tbh=CRmXShV8dsH1u69QQVNCll3ZMu7UN5gcubQgK99aBVc=; b=cGnufM3gGuuIDbTNhJ3Mq+FYr2\n\t9mUiTTR+G03pO9juEJlmPhljdz3KACK1gqeGpv/PponjroRGanISzAcAHu+Ff6t0olI6aEcJ+yosx\n\tbl2xNafKb45f8XmZX+Vifc4SfEVNmkiCKjk0W7CZoZjFuyBVqJxRJV0X33WCSg4o1ps4cXeGi/j/6\n\t7grYVxq4kT7gOHCmAHO2Adn3JSB+VaOKAwPPnGsV8ocJ/9RChZuisn+Pt9YIP/hdyDaxJNg+9DOHr\n\tf6blE7L6lZrwWPggtFDRAC3vzAOAHePi1A9uvCuXvMkBuSi353lhLgSa7DLSKUx4YwajUI2dXBBuL\n\tEHk+cWhA==;","v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail;\n\tt=1776066176; bh=U3f8nmO2QXRnCSjIan32SJ+Ij7HjpuM5kHSLGiuMsEY=;\n\th=References:Date:Cc:In-Reply-To:To:From:Subject:Message-ID;\n\tb=N5DtlJcD59YNC1FfO//Y7b8zuPR6uErsK+uLYd8Dwn3M5ljQB3qpU8GL3SG8sqqzD\n\t 0DxcuRNuqElUwvzXw2fsRT9q1yXNyujvkakFcuRFLBt/1RLVKnU/RAkrWdWeTUHEaW\n\t DwHu0P6awlblh2p4xCsew/nHeGTtmWO+Tg2v/TGs="],"X-Yandex-Fwd":"1","Message-ID":"","Subject":"Re: [PATCH v4 2/2] ubifs: use strscpy() and kmemdup_nul() where\n appropriate","From":"Dmitry Antipov ","To":"Richard Weinberger , chengzhihao1\n ","Cc":"linux-mtd ","In-Reply-To":"<2056092139.32098.1775800654235.JavaMail.zimbra@nod.at>","References":"<5deffdfa-6a99-8205-1f71-ff1f07ce28d1@huawei.com>\n\t <20260409045629.527019-1-dmantipov@yandex.ru>\n\t <20260409045629.527019-2-dmantipov@yandex.ru>\n\t \n\t <2056092139.32098.1775800654235.JavaMail.zimbra@nod.at>","MIME-Version":"1.0","Date":"Fri, 10 Apr 2026 14:55:22 +0300","User-Agent":"Evolution 3.58.3 (3.58.3-1.fc43) ","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20260413_004304_662653_A6A07CF0 ","X-CRM114-Status":"UNSURE ( 7.15 )","X-CRM114-Notice":"Please train this message.","X-Spam-Score":"-2.1 (--)","X-Spam-Report":"Spam detection software,\n running on the system \"bombadil.infradead.org\",\n has NOT identified this incoming email as spam. The original\n message has been attached to this so you can view it or label\n similar future email. If you have any questions, see\n the administrator of that system for details.\n Content preview: On Fri, 2026-04-10 at 07:57 +0200,\n Richard Weinberger wrote:\n > Dmitry, how are you testing these changes? Build with:\n Content analysis details: (-2.1 points, 5.0 required)\n pts rule name description\n ---- ----------------------\n --------------------------------------------------\n 0.0 RCVD_IN_VALIDITY_CERTIFIED_BLOCKED RBL: ADMINISTRATOR NOTICE: The\n query to Validity was blocked. See\n https://knowledge.validity.com/hc/en-us/articles/20961730681243\n for more information.\n [178.154.239.146 listed in\n sa-trusted.bondedsender.org]\n 0.0 RCVD_IN_VALIDITY_SAFE_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to\n Validity was blocked. See\n https://knowledge.validity.com/hc/en-us/articles/20961730681243\n for more information.\n [178.154.239.146 listed in\n sa-accredit.habeas.com]\n 0.0 RCVD_IN_VALIDITY_RPBL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to\n Validity was blocked. See\n https://knowledge.validity.com/hc/en-us/articles/20961730681243\n for more information.\n [178.154.239.146 listed in\n bl.score.senderscore.com]\n -0.0 SPF_PASS SPF: sender matches SPF record\n 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record\n -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from\n envelope-from domain\n 0.1 DKIM_SIGNED Message has a DKIM or DK signature,\n not necessarily valid\n -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from\n author's\n domain\n -0.1 DKIM_VALID Message has at least one valid DKIM or DK\n signature\n -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n [score: 0.0000]\n 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\n provider\n [dmantipov(at)yandex.ru]","X-BeenThere":"linux-mtd@lists.infradead.org","X-Mailman-Version":"2.1.34","Precedence":"list","List-Id":"Linux MTD discussion mailing list ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-mtd\" ","Errors-To":"linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"}},{"id":3676519,"web_url":"http://patchwork.ozlabs.org/comment/3676519/","msgid":"<2cf9ec17854da2ff4bc7c53d3dc12558b9089bf7.camel@yandex.ru>","list_archive_url":null,"date":"2026-04-10T12:00:59","subject":"Re: [PATCH v4 2/2] ubifs: use strscpy() and kmemdup_nul() where\n appropriate","submitter":{"id":87610,"url":"http://patchwork.ozlabs.org/api/people/87610/","name":"Dmitry Antipov","email":"dmantipov@yandex.ru"},"content":"On Fri, 2026-04-10 at 07:57 +0200, Richard Weinberger wrote:\n\n> Dmitry, how are you testing these changes?\n\nBuild with:\n\nCONFIG_KASAN=y\n\nCONFIG_MTD_NAND_NANDSIM=m\n\nCONFIG_MTD_UBI=m\nCONFIG_MTD_UBI_WL_THRESHOLD=4096\nCONFIG_MTD_UBI_BEB_LIMIT=20\nCONFIG_UBIFS_FS=m\nCONFIG_UBIFS_FS_ADVANCED_COMPR=y\nCONFIG_UBIFS_FS_LZO=y\nCONFIG_UBIFS_FS_ZLIB=y\nCONFIG_UBIFS_FS_ZSTD=y\nCONFIG_UBIFS_ATIME_SUPPORT=y\nCONFIG_UBIFS_FS_XATTR=y\nCONFIG_UBIFS_FS_SECURITY=y\nCONFIG_UBIFS_FS_AUTHENTICATION=y\n\nand boot (QEMU VM). Then use nandsim to create ~512M ubifs volume:\n\n# modprobe nandsim second_id_byte=0xdc third_id_byte=0x80 fourth_id_byte=0x1d\n# modprobe ubi mtd=0\n# ubimkvol /dev/ubi0 -N test -m\nSet volume size to 517644288\nVolume ID 0, size 4012 LEBs (517644288 bytes, 493.6 MiB), LEB size 129024 bytes (126.0 KiB), dynamic, name \"test\", alignment 1\n# mount -t ubifs ubi0:test /mnt/ubifs\n\nAnd do basic consistency check with something like:\n\n# cp -a [~390M source tree] /mnt/ubifs\n# diff -ur [tree] /mnt/ubifs/[copy of that tree] ; no output hopefully means OK\n# umount /mnt/ubifs\n# mount -t ubifs ubi0:test /mnt/ubifs\n# diff -ur [tree] /mnt/ubifs/[copy of that tree] ; likewise\n\netc.\n\nDmitry","headers":{"Return-Path":"\n ","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n secure) header.d=lists.infradead.org header.i=@lists.infradead.org\n header.a=rsa-sha256 header.s=bombadil.20210309 header.b=GmaCrBTf;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n secure) header.d=infradead.org header.i=@infradead.org header.a=rsa-sha256\n header.s=desiato.20200630 header.b=QXtqgkWN;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n unprotected) header.d=yandex.ru header.i=@yandex.ru header.a=rsa-sha256\n header.s=mail header.b=hHuwSYNC;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=none (no SPF record) smtp.mailfrom=lists.infradead.org\n (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org;\n envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n receiver=patchwork.ozlabs.org)","\n mail-nwsmtp-smtp-production-main-63.sas.yp-c.yandex.net;\n dkim=pass header.i=@yandex.ru"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n [IPv6:2607:7c80:54:3::133])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fvKCL5GQBz1y2d\n\tfor ; Mon, 13 Apr 2026 17:43:25 +1000 (AEST)","from localhost ([::1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux))\n\tid 1wCBww-0000000FAbG-07RE;\n\tMon, 13 Apr 2026 07:43:14 +0000","from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05])\n\tby bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux))\n\tid 1wCBwu-0000000FAat-3cTq\n\tfor linux-mtd@bombadil.infradead.org;\n\tMon, 13 Apr 2026 07:43:12 +0000","from forward500b.mail.yandex.net ([2a02:6b8:c02:900:1:45:d181:d500])\n\tby desiato.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux))\n\tid 1wCBwq-0000000GIfr-1TIe\n\tfor linux-mtd@lists.infradead.org;\n\tMon, 13 Apr 2026 07:43:11 +0000","from mail-nwsmtp-smtp-production-main-63.sas.yp-c.yandex.net\n (mail-nwsmtp-smtp-production-main-63.sas.yp-c.yandex.net\n [IPv6:2a02:6b8:c1e:489c:0:640:8d6b:0])\n\tby forward500b.mail.yandex.net (Yandex) with ESMTPS id 39B1DC02F0;\n\tMon, 13 Apr 2026 10:43:00 +0300 (MSK)","by mail-nwsmtp-smtp-production-main-63.sas.yp-c.yandex.net\n (smtp/Yandex) with ESMTPSA id vgEJLL0Q6eA0-OAJiqaSp;\n\tMon, 13 Apr 2026 10:42:59 +0300"],"DKIM-Signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20210309; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:Date:MIME-Version:References:\n\tIn-Reply-To:Cc:To:From:Subject:Message-ID:Reply-To:Content-ID:\n\tContent-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc\n\t:Resent-Message-ID:List-Owner;\n\tbh=G1OVG7Xq82Mpe0PkE2z+heycEc2l99usElGz6wDnPmA=; b=GmaCrBTfh6oH5x6bWfbuw7Zxzn\n\tbUYGRH1OD8QS8Uinnalt02Ylr2tAfP9WKD0WS32QSFHsRaW+E9Rn8X0KP90jjWAqMCnp/rFx3E/Pf\n\t9jSj/qjR7dhRtnpmjmPo7QUFcSBnCowZ2SnjYsBx0LCyzrJ05E37i+KwLkcLTlRJc0r+eEqdnuXej\n\tDh3xNISsvi1+3kbo1EktVR8J6283P24h0X8LqUvq9JY2t37Riir6QirFCRQjL+0otsuh7TmAvrV3b\n\tSzIKyFw57P278xRjyEluMYiCQjqjQZeP19b/cJTiU4KGnkEjwf50Ig76YJrLKNMtD4NiESlL+H7Xk\n\tpQqei76A==;","v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=infradead.org; s=desiato.20200630; h=Date:MIME-Version:\n\tContent-Transfer-Encoding:Content-Type:References:In-Reply-To:Cc:To:From:\n\tSubject:Message-ID:Sender:Reply-To:Content-ID:Content-Description;\n\tbh=LNnItVaYd6S0rWE1LpiXG6tl4JJQ1PYdtKzZuJYRToc=; b=QXtqgkWNxzrqlsB17NFMaDQ6kU\n\t1FvwLWc3nEORMn5XLIakyHeaC92PY2TLWm2dH2CVMNxvMmReOwwsJzjlKBp/0/q3ErHuKcqpA8H71\n\t4ozkHUPtdk9EJ3ioq17zZuWV/QD5ySYqOSZhQrup8arRhE5m1auCmiU2lAEfJ0pJejDCVza/HdGGj\n\tZUJ7J5X1poB1VaWE6/QbbNC6+RDU+RGDcLcIpUyigrovx5+dIuHJKbVMpyA5FZw5R8gXs1v+jeSaX\n\twehU3ykM8tXVZ1Eni++3AXnOr91EQW3eqRF7JpaCLUN1Ndmkxcx5LDAtOsfsiOXD8x8s4whO+Nl20\n\tQTFG7Nug==;","v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail;\n\tt=1776066179; bh=LNnItVaYd6S0rWE1LpiXG6tl4JJQ1PYdtKzZuJYRToc=;\n\th=References:Date:Cc:In-Reply-To:To:From:Subject:Message-ID;\n\tb=hHuwSYNCAUJAizvEou+qeU0fTEtnxJEZeiLnWTTTlgUubuaY0OvEYKVJfdksVSXn5\n\t R3Uu/T4z+dw6984o5PdiDtXwZqVY4ud84BGThvZ9lRXDVpAaW21bATUqY28uG0pGVW\n\t Nf/g5fm7n9er0B95S3agRYqctyid4Z3INvOooaQE="],"X-Yandex-Fwd":"1","Message-ID":"<2cf9ec17854da2ff4bc7c53d3dc12558b9089bf7.camel@yandex.ru>","Subject":"Re: [PATCH v4 2/2] ubifs: use strscpy() and kmemdup_nul() where\n appropriate","From":"Dmitry Antipov ","To":"Richard Weinberger , chengzhihao1\n ","Cc":"linux-mtd ","In-Reply-To":"<2056092139.32098.1775800654235.JavaMail.zimbra@nod.at>","References":"<5deffdfa-6a99-8205-1f71-ff1f07ce28d1@huawei.com>\n\t <20260409045629.527019-1-dmantipov@yandex.ru>\n\t <20260409045629.527019-2-dmantipov@yandex.ru>\n\t \n\t <2056092139.32098.1775800654235.JavaMail.zimbra@nod.at>","MIME-Version":"1.0","Date":"Fri, 10 Apr 2026 15:00:59 +0300","User-Agent":"Evolution 3.58.3 (3.58.3-1.fc43) ","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20260413_084310_076436_FF5D5FBF ","X-CRM114-Status":"UNSURE ( 4.53 )","X-CRM114-Notice":"Please train this message.","X-Spam-Score":"-0.9 (/)","X-Spam-Report":"Spam detection software,\n running on the system \"desiato.infradead.org\",\n has NOT identified this incoming email as spam. The original\n message has been attached to this so you can view it or label\n similar future email. If you have any questions, see\n the administrator of that system for details.\n Content preview: On Fri, 2026-04-10 at 07:57 +0200,\n Richard Weinberger wrote:\n > Dmitry, how are you testing these changes? Build with:\n Content analysis details: (-0.9 points, 5.0 required)\n pts rule name description\n ---- ----------------------\n --------------------------------------------------\n -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low\n trust\n [2a02:6b8:c02:900:1:45:d181:d500 listed in]\n [list.dnswl.org]\n -0.0 SPF_PASS SPF: sender matches SPF record\n 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record\n -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from\n envelope-from domain\n -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from\n author's\n domain\n -0.1 DKIM_VALID Message has at least one valid DKIM or DK\n signature\n 0.1 DKIM_SIGNED Message has a DKIM or DK signature,\n not necessarily valid\n 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\n provider\n [dmantipov(at)yandex.ru]","X-BeenThere":"linux-mtd@lists.infradead.org","X-Mailman-Version":"2.1.34","Precedence":"list","List-Id":"Linux MTD discussion mailing list ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-mtd\" ","Errors-To":"linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"}},{"id":3676747,"web_url":"http://patchwork.ozlabs.org/comment/3676747/","msgid":"<1272521ed33b17b51d32bd5ad9466b1439c092e9.camel@yandex.ru>","list_archive_url":null,"date":"2026-04-13T13:24:42","subject":"Re: [PATCH v4 2/2] ubifs: use strscpy() and kmemdup_nul() where\n appropriate","submitter":{"id":87610,"url":"http://patchwork.ozlabs.org/api/people/87610/","name":"Dmitry Antipov","email":"dmantipov@yandex.ru"},"content":"On Fri, 2026-04-10 at 07:57 +0200, Richard Weinberger wrote:\n\n> Dmitry, how are you testing these changes?\n\n# modprobe nandsim second_id_byte=0xdc third_id_byte=0x80 fourth_id_byte=0x1d\n# modprobe ubi mtd=0\n# ubimkvol /dev/ubi0 -N test -m\nSet volume size to 517644288\nVolume ID 0, size 4012 LEBs (517644288 bytes, 493.6 MiB), LEB size 129024\nbytes (126.0 KiB), dynamic, name \"test\", alignment 1\n# mount -t ubifs ubi0:test /mnt/ubifs\n# cp -a [~390M source tree] /mnt/ubifs\n# diff -ur [tree] /mnt/ubifs/[tree]\n# umount /mnt/ubifs\n# sync\n# mount /mnt/ubifs\n# diff -ur [tree] /mnt/ubifs/[tree]\n\netc, etc. And yes, I'm aware of fsck.ubifs since 2.3.0 of mtd-utils.\n\nDmitry","headers":{"Return-Path":"\n ","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n secure) header.d=lists.infradead.org header.i=@lists.infradead.org\n header.a=rsa-sha256 header.s=bombadil.20210309 header.b=hrVxnyZP;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n unprotected) header.d=yandex.ru header.i=@yandex.ru header.a=rsa-sha256\n header.s=mail header.b=R1NuQ4w8;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=none (no SPF record) smtp.mailfrom=lists.infradead.org\n (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org;\n envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n receiver=patchwork.ozlabs.org)","\n mail-nwsmtp-smtp-production-main-52.klg.yp-c.yandex.net;\n dkim=pass header.i=@yandex.ru"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n [IPv6:2607:7c80:54:3::133])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fvSnX4D8gz1xtJ\n\tfor ; Mon, 13 Apr 2026 23:25:04 +1000 (AEST)","from localhost ([::1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux))\n\tid 1wCHHa-0000000FjW5-2no9;\n\tMon, 13 Apr 2026 13:24:54 +0000","from forward502d.mail.yandex.net ([178.154.239.210])\n\tby bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux))\n\tid 1wCHHW-0000000FjVJ-2RP8\n\tfor linux-mtd@lists.infradead.org;\n\tMon, 13 Apr 2026 13:24:53 +0000","from mail-nwsmtp-smtp-production-main-52.klg.yp-c.yandex.net\n (mail-nwsmtp-smtp-production-main-52.klg.yp-c.yandex.net\n [IPv6:2a02:6b8:c42:ea2:0:640:ef77:0])\n\tby forward502d.mail.yandex.net (Yandex) with ESMTPS id D2A68C0DBC;\n\tMon, 13 Apr 2026 16:24:43 +0300 (MSK)","by mail-nwsmtp-smtp-production-main-52.klg.yp-c.yandex.net\n (smtp/Yandex) with ESMTPSA id gOKVHa5S70U0-jnxRXkyF;\n\tMon, 13 Apr 2026 16:24:43 +0300"],"DKIM-Signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20210309; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post:\n\tList-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:\n\tDate:Cc:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=mwH8BTCjx+z+++HTR/4CCkhk5NZn7eJmiR8bOwbGMhU=; b=hrVxnyZPeZjVw9\n\tdwDHsP+AOQfvtwfB0uZkLkEZLpf4MA8YhERFJXRcJSIzjm2bWPg4KJro6dQv02YHrOrMoRGCgZVa8\n\tIPHjWaiEALc3vb/IL3TJjlsMwQPOjIW9YHaNxupIoSjLYHuzEccCHN+9eqzIAFvhcQSNPZ/E7jBst\n\triYk0iBk21tAnLUqdo6R031rBdnq15J2NTx+T4AGViFJepiDAPfmrIsLSPJ0/+7r0FfqjBWBdJnv0\n\tjRy3ZYfadLQnhHh2KqEmry/ZbsAmIlj8AarO7w1CwNK2wdUGuY8lNBj7B/r2OW3aUMM2JGjjjd9pn\n\tgIv7G2b+j+hzv6vTj1pw==;","v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail;\n\tt=1776086683; bh=U5cdrwKeRRFnCtjOxyHDbAeQIXV9eBWRAaYQDsFm6kY=;\n\th=References:Date:In-Reply-To:Cc:To:From:Subject:Message-ID;\n\tb=R1NuQ4w8kl3Qcx7Nyxu9ZSkSYS/TSn0kLYrg56sryuIDLQ/Lf8KmnH+rLeZ/dFKDH\n\t JxEpyfTKWyDadbkaOK6BHfHgdlcw0lOiDL94Nb1P7HLlrHMsVyMYXF3ns8y3SAO/55\n\t bcsr/vHken0TVrGhFkvL5+vn49TSXLdBC860rSSc="],"X-Yandex-Fwd":"1","Message-ID":"<1272521ed33b17b51d32bd5ad9466b1439c092e9.camel@yandex.ru>","Subject":"Re: [PATCH v4 2/2] ubifs: use strscpy() and kmemdup_nul() where\n appropriate","From":"Dmitry Antipov ","To":"Richard Weinberger , chengzhihao1\n ","Cc":"linux-mtd ","Date":"Mon, 13 Apr 2026 16:24:42 +0300","In-Reply-To":"<2056092139.32098.1775800654235.JavaMail.zimbra@nod.at>","References":"<5deffdfa-6a99-8205-1f71-ff1f07ce28d1@huawei.com>\n\t <20260409045629.527019-1-dmantipov@yandex.ru>\n\t <20260409045629.527019-2-dmantipov@yandex.ru>\n\t \n\t <2056092139.32098.1775800654235.JavaMail.zimbra@nod.at>","User-Agent":"Evolution 3.58.3 (3.58.3-1.fc43) ","MIME-Version":"1.0","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20260413_062451_195124_7298431E ","X-CRM114-Status":"UNSURE ( 4.85 )","X-CRM114-Notice":"Please train this message.","X-Spam-Score":"-2.1 (--)","X-Spam-Report":"Spam detection software,\n running on the system \"bombadil.infradead.org\",\n has NOT identified this incoming email as spam. The original\n message has been attached to this so you can view it or label\n similar future email. If you have any questions, see\n the administrator of that system for details.\n Content preview: On Fri, 2026-04-10 at 07:57 +0200,\n Richard Weinberger wrote:\n > Dmitry,\n how are you testing these changes? # modprobe nandsim second_id_byte=0xdc\n third_id_byte=0x80 fourth_id_byte=0x1d # modprobe ubi mtd=0 # ubimkvol\n /dev/ubi0\n -N test -m Set volume size to 517644288 Volume ID 0,\n size 4012 LEBs (517644288\n b [...]\n Content analysis details: (-2.1 points, 5.0 required)\n pts rule name description\n ---- ----------------------\n --------------------------------------------------\n 0.0 RCVD_IN_VALIDITY_SAFE_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to\n Validity was blocked. See\n https://knowledge.validity.com/hc/en-us/articles/20961730681243\n for more information.\n [178.154.239.210 listed in\n sa-accredit.habeas.com]\n 0.0 RCVD_IN_VALIDITY_CERTIFIED_BLOCKED RBL: ADMINISTRATOR NOTICE: The\n query to Validity was blocked. See\n https://knowledge.validity.com/hc/en-us/articles/20961730681243\n for more information.\n [178.154.239.210 listed in\n sa-trusted.bondedsender.org]\n 0.0 RCVD_IN_MSPIKE_H5 RBL: Excellent reputation (+5)\n [178.154.239.210 listed in wl.mailspike.net]\n 0.0 RCVD_IN_VALIDITY_RPBL_BLOCKED RBL: ADMINISTRATOR NOTICE: The query to\n Validity was blocked. See\n https://knowledge.validity.com/hc/en-us/articles/20961730681243\n for more information.\n [178.154.239.210 listed in\n bl.score.senderscore.com]\n -0.0 SPF_PASS SPF: sender matches SPF record\n 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record\n -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from\n envelope-from domain\n 0.1 DKIM_SIGNED Message has a DKIM or DK signature,\n not necessarily valid\n -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from\n author's\n domain\n -0.1 DKIM_VALID Message has at least one valid DKIM or DK\n signature\n 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders\n -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n [score: 0.0000]\n 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\n provider\n [dmantipov(at)yandex.ru]","X-BeenThere":"linux-mtd@lists.infradead.org","X-Mailman-Version":"2.1.34","Precedence":"list","List-Id":"Linux MTD discussion mailing list ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"linux-mtd\" ","Errors-To":"linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"}},{"id":3677914,"web_url":"http://patchwork.ozlabs.org/comment/3677914/","msgid":"<7b528d03-5f5c-532e-20dc-bcb7dd5cc4a7@huawei.com>","list_archive_url":null,"date":"2026-04-16T03:30:13","subject":"Re: [PATCH v4 2/2] ubifs: use strscpy() and kmemdup_nul() where\n appropriate","submitter":{"id":76854,"url":"http://patchwork.ozlabs.org/api/people/76854/","name":"Zhihao Cheng","email":"chengzhihao1@huawei.com"},"content":"在 2026/4/10 20:00, Dmitry Antipov 写道:\n> On Fri, 2026-04-10 at 07:57 +0200, Richard Weinberger wrote:\n> \n>> Dmitry, how are you testing these changes?\n> \n> Build with:\n> \n> CONFIG_KASAN=y\n\nHi, Dmitry\nI'm pleasure with CONFIG_KASAN=y, and a fsstress test(>8h) for ubifs is \nstill needed.\n> \n> CONFIG_MTD_NAND_NANDSIM=m\n> \n> CONFIG_MTD_UBI=m\n> CONFIG_MTD_UBI_WL_THRESHOLD=4096\n> CONFIG_MTD_UBI_BEB_LIMIT=20\n> CONFIG_UBIFS_FS=m\n> CONFIG_UBIFS_FS_ADVANCED_COMPR=y\n> CONFIG_UBIFS_FS_LZO=y\n> CONFIG_UBIFS_FS_ZLIB=y\n> CONFIG_UBIFS_FS_ZSTD=y\n> CONFIG_UBIFS_ATIME_SUPPORT=y\n> CONFIG_UBIFS_FS_XATTR=y\n> CONFIG_UBIFS_FS_SECURITY=y\n> CONFIG_UBIFS_FS_AUTHENTICATION=y\n> \n> and boot (QEMU VM). Then use nandsim to create ~512M ubifs volume:\n> \n> # modprobe nandsim second_id_byte=0xdc third_id_byte=0x80 fourth_id_byte=0x1d\n> # modprobe ubi mtd=0\n> # ubimkvol /dev/ubi0 -N test -m\n> Set volume size to 517644288\n> Volume ID 0, size 4012 LEBs (517644288 bytes, 493.6 MiB), LEB size 129024 bytes (126.0 KiB), dynamic, name \"test\", alignment 1\n> # mount -t ubifs ubi0:test /mnt/ubifs\n> \n> And do basic consistency check with something like:\n> \n> # cp -a [~390M source tree] /mnt/ubifs\n> # diff -ur [tree] /mnt/ubifs/[copy of that tree] ; no output hopefully means OK\n> # umount /mnt/ubifs\n> # mount -t ubifs ubi0:test /mnt/ubifs\n> # diff -ur [tree] /mnt/ubifs/[copy of that tree] ; likewise\n> \n> etc.\n> \n> Dmitry\n> .\n>","headers":{"Return-Path":"\n ","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n secure) header.d=lists.infradead.org header.i=@lists.infradead.org\n header.a=rsa-sha256 header.s=bombadil.20210309 header.b=OIa1AYfw;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n unprotected) header.d=huawei.com header.i=@huawei.com header.a=rsa-sha256\n header.s=dkim header.b=gwJLA3hT;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=none (no SPF record) smtp.mailfrom=lists.infradead.org\n (client-ip=2607:7c80:54:3::133; helo=bombadil.infradead.org;\n envelope-from=linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n [IPv6:2607:7c80:54:3::133])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fx3SF01t6z1yG9\n\tfor ; Thu, 16 Apr 2026 13:30:36 +1000 (AEST)","from localhost ([::1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux))\n\tid 1wDDQy-00000001vft-3nE1;\n\tThu, 16 Apr 2026 03:30:28 +0000","from canpmsgout03.his.huawei.com ([113.46.200.218])\n\tby bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux))\n\tid 1wDDQw-00000001vfb-3yzr\n\tfor linux-mtd@lists.infradead.org;\n\tThu, 16 Apr 2026 03:30:28 +0000","from mail.maildlp.com (unknown [172.19.163.0])\n\tby canpmsgout03.his.huawei.com (SkyGuard) with ESMTPS id 4fx3Jd47jwzpSvW;\n\tThu, 16 Apr 2026 11:24:01 +0800 (CST)","from kwepemk500005.china.huawei.com (unknown [7.202.194.90])\n\tby mail.maildlp.com (Postfix) with ESMTPS id 5E6C140574;\n\tThu, 16 Apr 2026 11:30:15 +0800 (CST)","from [10.174.178.46] (10.174.178.46) by\n kwepemk500005.china.huawei.com (7.202.194.90) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.1544.11; Thu, 16 Apr 2026 11:30:14 +0800"],"DKIM-Signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type:\n\tContent-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive:\n\tList-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From:\n\tReferences:CC:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date:\n\tResent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner;\n\tbh=X0DT76LsDka9/UPcnLPP17bLDiw6Hyzax0RSZWIen9g=; b=OIa1AYfwRsnC20A59DdP+a98DS\n\tql3ctGRkLZakiYKmAXuoW33rUtarLQInUAiaMm6DHSGkI2J04J1Q6hHSYe/7HpyORMapjXAMEcsfM\n\t8LmNB8jB3qXWbK5GdWs8zt487312E3zorVaLeOpF+Ja8cuUa9zKtLnqsHlNOqYETzV4AMQC2uYq33\n\teyVsua+tWiiFB6YKex/5Kqo8dNWalHWAhgYBu9xBwJxxQk5O0yqCqOK2ynpPWICxykqw2jpQibix9\n\tA13o2LEwyZPYyyXiryaay+aw/7t3ANS2J+jtUOXIBpC19NZvOSIGjaumTvqDW7l5Y8WVsc1LJHjGU\n\tYog0SOrg==;","v=1; a=rsa-sha256; d=huawei.com; s=dkim;\n\tc=relaxed/relaxed; q=dns/txt;\n\th=From;\n\tbh=mnRUmTaUCaa7bCXaapnbN9HRan9nBBOenZeQcHiXfDo=;\n\tb=gwJLA3hTzZAdvI+S9CETY+kbB6QwnluxMqu3yPpBsnhY4anmWUrZw8iPTDFA46uM5jqd4CSfo\n\tqmp7Z1tipbvnM/3sjBIkNCt69J8uOib1ecFtXc1gmRtiylKLYRKQDc6oFLHljSqqIp/Z33p/wAt\n\ty1viimoVrzQBJRwRuX53yEg="],"dkim-signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type:\n\tContent-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive:\n\tList-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From:\n\tReferences:CC:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date:\n\tResent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner;\n\tbh=X0DT76LsDka9/UPcnLPP17bLDiw6Hyzax0RSZWIen9g=; b=OIa1AYfwRsnC20A59DdP+a98DS\n\tql3ctGRkLZakiYKmAXuoW33rUtarLQInUAiaMm6DHSGkI2J04J1Q6hHSYe/7HpyORMapjXAMEcsfM\n\t8LmNB8jB3qXWbK5GdWs8zt487312E3zorVaLeOpF+Ja8cuUa9zKtLnqsHlNOqYETzV4AMQC2uYq33\n\teyVsua+tWiiFB6YKex/5Kqo8dNWalHWAhgYBu9xBwJxxQk5O0yqCqOK2ynpPWICxykqw2jpQibix9\n\tA13o2LEwyZPYyyXiryaay+aw/7t3ANS2J+jtUOXIBpC19NZvOSIGjaumTvqDW7l5Y8WVsc1LJHjGU\n\tYog0SOrg==;","v=1; a=rsa-sha256; d=huawei.com; s=dkim;\n\tc=relaxed/relaxed; q=dns/txt;\n\th=From;\n\tbh=mnRUmTaUCaa7bCXaapnbN9HRan9nBBOenZeQcHiXfDo=;\n\tb=gwJLA3hTzZAdvI+S9CETY+kbB6QwnluxMqu3yPpBsnhY4anmWUrZw8iPTDFA46uM5jqd4CSfo\n\tqmp7Z1tipbvnM/3sjBIkNCt69J8uOib1ecFtXc1gmRtiylKLYRKQDc6oFLHljSqqIp/Z33p/wAt\n\ty1viimoVrzQBJRwRuX53yEg="],"Subject":"Re: [PATCH v4 2/2] ubifs: use strscpy() and kmemdup_nul() where\n appropriate","To":"Dmitry Antipov , Richard Weinberger ","CC":"linux-mtd ","References":"<5deffdfa-6a99-8205-1f71-ff1f07ce28d1@huawei.com>\n <20260409045629.527019-1-dmantipov@yandex.ru>\n <20260409045629.527019-2-dmantipov@yandex.ru>\n \n <2056092139.32098.1775800654235.JavaMail.zimbra@nod.at>\n <2cf9ec17854da2ff4bc7c53d3dc12558b9089bf7.camel@yandex.ru>","From":"Zhihao Cheng ","Message-ID":"<7b528d03-5f5c-532e-20dc-bcb7dd5cc4a7@huawei.com>","Date":"Thu, 16 Apr 2026 11:30:13 +0800","User-Agent":"Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101\n Thunderbird/68.5.0","MIME-Version":"1.0","In-Reply-To":"<2cf9ec17854da2ff4bc7c53d3dc12558b9089bf7.camel@yandex.ru>","X-Originating-IP":"[10.174.178.46]","X-ClientProxiedBy":"kwepems500002.china.huawei.com (7.221.188.17) To\n kwepemk500005.china.huawei.com (7.202.194.90)","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20260415_203027_202358_0B945D20 ","X-CRM114-Status":"UNSURE ( 9.72 )","X-CRM114-Notice":"Please train this message.","X-Spam-Score":"-5.2 (-----)","X-Spam-Report":"=?unknown-8bit?q?Spam_detection_software=2C_running_on_the_sy?=\n\t=?unknown-8bit?q?stem_=22bombadil=2Einfradead=2Eorg=22=2C?=\n\t=?unknown-8bit?q?_has_NOT_identified_this_incoming_email_as_spam=2E__The_ori?=\n\t=?unknown-8bit?q?ginal?=\n\t=?unknown-8bit?q?_message_has_been_attached_to_this_so_you_can_view_it_or_la?=\n\t=?unknown-8bit?q?bel?=\n\t=?unknown-8bit?q?_similar_future_email=2E__If_you_have_any_questions=2C_see?=\n\t=?unknown-8bit?q?_the_administrator_of_that_system_for_details=2E?=\n\t=?unknown-8bit?q?_?=\n\t=?unknown-8bit?b?IENvbnRlbnQgcHJldmlldzogIOWcqCAyMDI2LzQvMTAgMjA6MDAsIERt?=\n\t=?unknown-8bit?b?aXRyeSBBbnRpcG92IOWGmemBkzogPiBPbiBGcmksIDIwMjYtMDQtMTA=?=\n\t=?unknown-8bit?q?_at_07=3A57_+0200=2C_Richard_Weinberger_wrote=3A_=3E_=3E=3E?=\n\t=?unknown-8bit?q?_Dmitry=2C_how_are_you_testing?=\n\t=?unknown-8bit?q?_these_changes=3F_=3E_=3E_Build_with=3A_=3E_=3E_CONFIG=5FKA?=\n\t=?unknown-8bit?q?SAN=3Dy_Hi=2C_Dmitry_I=27m_pleasure?=\n\t=?unknown-8bit?q?_with_CONFIG=5FKASAN=3Dy=2C_and_a_fsstress_test=28=3E8h=29_?=\n\t=?unknown-8bit?q?for_ubifs_is_still_needed=2E?=\n\t=?unknown-8bit?b?ID4gPiBDT05GSUdfTVREX05BTkRfTkFORFNJTT1tID4gPiBDT05GSUdf?=\n\t=?unknown-8bit?b?TVREX1VCST1tID4gQ09ORklHX01URF9VQklfV0xfVEhSRVNIT0xEPTQw?=\n\t=?unknown-8bit?b?OTY=?=\n\t=?unknown-8bit?b?ID4gQ09ORklHX01URF9VQklfIFsuLi5dIA==?=\n\t=?unknown-8bit?q?_?=\n\t=?unknown-8bit?q?_Content_analysis_details=3A___=28-5=2E2_points=2C_5=2E0_re?=\n\t=?unknown-8bit?q?quired=29?=\n\t=?unknown-8bit?q?_?=\n\t=?unknown-8bit?q?_pts_rule_name______________description?=\n\t=?unknown-8bit?q?_----_----------------------_------------------------------?=\n\t=?unknown-8bit?q?--------------------?=\n\t=?unknown-8bit?q?_0=2E0_RCVD=5FIN=5FVALIDITY=5FCERTIFIED=5FBLOCKED_RBL=3A_AD?=\n\t=?unknown-8bit?q?MINISTRATOR_NOTICE=3A_The?=\n\t=?unknown-8bit?q?_query_to_Validity_was_blocked=2E__See?=\n\t=?unknown-8bit?q?_https=3A//knowledge=2Evalidity=2Ecom/hc/en-us/articles/209?=\n\t=?unknown-8bit?q?61730681243?=\n\t=?unknown-8bit?q?_for_more_information=2E?=\n\t=?unknown-8bit?q?_=5B113=2E46=2E200=2E218_listed_in_sa-trusted=2Ebondedsende?=\n\t=?unknown-8bit?q?r=2Eorg=5D?=\n\t=?unknown-8bit?q?_0=2E0_RCVD=5FIN=5FVALIDITY=5FSAFE=5FBLOCKED_RBL=3A_ADMINIS?=\n\t=?unknown-8bit?q?TRATOR_NOTICE=3A_The_query_to?=\n\t=?unknown-8bit?q?_Validity_was_blocked=2E__See?=\n\t=?unknown-8bit?q?_https=3A//knowledge=2Evalidity=2Ecom/hc/en-us/articles/209?=\n\t=?unknown-8bit?q?61730681243?=\n\t=?unknown-8bit?q?_for_more_information=2E?=\n\t=?unknown-8bit?q?_=5B113=2E46=2E200=2E218_listed_in_sa-accredit=2Ehabeas=2Ec?=\n\t=?unknown-8bit?q?om=5D?=\n\t=?unknown-8bit?q?_-0=2E0_SPF=5FPASS_______________SPF=3A_sender_matches_SPF_?=\n\t=?unknown-8bit?q?record?=\n\t=?unknown-8bit?q?_0=2E0_SPF=5FHELO=5FNONE__________SPF=3A_HELO_does_not_publ?=\n\t=?unknown-8bit?q?ish_an_SPF_Record?=\n\t=?unknown-8bit?q?_-0=2E1_DKIM=5FVALID=5FEF__________Message_has_a_valid_DKIM?=\n\t=?unknown-8bit?q?_or_DK_signature_from?=\n\t=?unknown-8bit?q?_envelope-from_domain?=\n\t=?unknown-8bit?q?_0=2E1_DKIM=5FSIGNED____________Message_has_a_DKIM_or_DK_si?=\n\t=?unknown-8bit?q?gnature=2C_not_necessarily_valid?=\n\t=?unknown-8bit?q?_-0=2E1_DKIM=5FVALID=5FAU__________Message_has_a_valid_DKIM?=\n\t=?unknown-8bit?q?_or_DK_signature_from_author=27s?=\n\t=?unknown-8bit?q?_domain?=\n\t=?unknown-8bit?q?_-0=2E1_DKIM=5FVALID_____________Message_has_at_least_one_v?=\n\t=?unknown-8bit?q?alid_DKIM_or_DK_signature?=\n\t=?unknown-8bit?q?_-1=2E9_BAYES=5F00_______________BODY=3A_Bayes_spam_probabi?=\n\t=?unknown-8bit?q?lity_is_0_to_1=25?=\n\t=?unknown-8bit?q?_=5Bscore=3A_0=2E0000=5D?=\n\t=?unknown-8bit?q?_0=2E0_RCVD=5FIN=5FVALIDITY=5FRPBL=5FBLOCKED_RBL=3A_ADMINIS?=\n\t=?unknown-8bit?q?TRATOR_NOTICE=3A_The_query_to?=\n\t=?unknown-8bit?q?_Validity_was_blocked=2E__See?=\n\t=?unknown-8bit?q?_https=3A//knowledge=2Evalidity=2Ecom/hc/en-us/articles/209?=\n\t=?unknown-8bit?q?61730681243?=\n\t=?unknown-8bit?q?_for_more_information=2E?=\n\t=?unknown-8bit?q?_=5B113=2E46=2E200=2E218_listed_in_bl=2Escore=2Esenderscore?=\n\t=?unknown-8bit?q?=2Ecom=5D?=\n\t=?unknown-8bit?q?_-3=2E1_NICE=5FREPLY=5FA___________Looks_like_a_legit_reply?=\n\t=?unknown-8bit?q?_=28A=29?=","X-BeenThere":"linux-mtd@lists.infradead.org","X-Mailman-Version":"2.1.34","Precedence":"list","List-Id":"Linux MTD discussion mailing list ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Content-Transfer-Encoding":"base64","Content-Type":"text/plain; charset=\"utf-8\"; Format=\"flowed\"","Sender":"\"linux-mtd\" ","Errors-To":"linux-mtd-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"}}]