[{"id":3675372,"web_url":"http://patchwork.ozlabs.org/comment/3675372/","msgid":"<20260409-laboring-announcer-4a0f9ca152a1@spud>","list_archive_url":null,"date":"2026-04-09T15:41:45","subject":"Re: [PATCH 1/2] dt-bindings: pwm: marvell,pxa-pwm: Add SpacemiT K3\n PWM support","submitter":{"id":84372,"url":"http://patchwork.ozlabs.org/api/people/84372/","name":"Conor Dooley","email":"conor@kernel.org"},"content":"On Thu, Apr 09, 2026 at 12:45:11AM +0000, Yixun Lan wrote:\n> The PWM controller in SpacemiT K3 SoC reuse the same IP as previous K1\n> generation, while the difference is that one additional bus clock is\n> added.\n> \n> Signed-off-by: Yixun Lan \n> ---\n> .../devicetree/bindings/pwm/marvell,pxa-pwm.yaml | 53 ++++++++++++++++++++--\n> 1 file changed, 50 insertions(+), 3 deletions(-)\n> \n> diff --git a/Documentation/devicetree/bindings/pwm/marvell,pxa-pwm.yaml b/Documentation/devicetree/bindings/pwm/marvell,pxa-pwm.yaml\n> index 8df327e52810..3427c8ef3945 100644\n> --- a/Documentation/devicetree/bindings/pwm/marvell,pxa-pwm.yaml\n> +++ b/Documentation/devicetree/bindings/pwm/marvell,pxa-pwm.yaml\n> @@ -15,7 +15,9 @@ allOf:\n> properties:\n> compatible:\n> contains:\n> - const: spacemit,k1-pwm\n> + enum:\n> + - spacemit,k1-pwm\n> + - spacemit,k3-pwm\n> then:\n> properties:\n> \"#pwm-cells\":\n> @@ -26,6 +28,38 @@ allOf:\n> const: 1\n> description: |\n> Used for specifying the period length in nanoseconds.\n> + - if:\n> + properties:\n> + compatible:\n> + contains:\n> + enum:\n> + - spacemit,k3-pwm\n> + then:\n> + properties:\n> + clock-names:\n> + items:\n> + - const: func\n> + - const: bus\n\nThis condition here doesn't appear to do anything? It just repeats\nwhat's already done unconditonally below?\n\n> + - if:\n> + properties:\n> + compatible:\n> + contains:\n> + enum:\n> + - spacemit,k3-pwm\n> + then:\n> + required:\n> + - clock-names\n> + properties:\n> + clocks:\n> + minItems: 2\n> + clock-names:\n> + minItems: 2\n> + else:\n> + properties:\n> + clocks:\n> + maxItems: 1\n> + clock-names:\n> + maxItems: 1\n> \n> properties:\n> compatible:\n> @@ -36,7 +70,9 @@ properties:\n> - marvell,pxa168-pwm\n> - marvell,pxa910-pwm\n> - items:\n> - - const: spacemit,k1-pwm\n> + - enum:\n> + - spacemit,k1-pwm\n> + - spacemit,k3-pwm\n> - const: marvell,pxa910-pwm\n> \n> reg:\n> @@ -47,7 +83,18 @@ properties:\n> description: Number of cells in a pwm specifier.\n> \n> clocks:\n> - maxItems: 1\n> + minItems: 1\n> + items:\n> + - description: The function clock\n> + - description: An optional bus clock\n> +\n> + clock-names:\n> + minItems: 1\n> + maxItems: 2\n> + oneOf:\n> + - items:\n> + - const: func\n> + - const: bus\n> \n> resets:\n> maxItems: 1\n> \n> -- \n> 2.53.0\n>","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-pwm@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=fPF2pvnr;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.234.253.10; helo=sea.lore.kernel.org;\n envelope-from=linux-pwm+bounces-8536-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"fPF2pvnr\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org [172.234.253.10])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fs45Q12mLz1yCv\n\tfor ; Fri, 10 Apr 2026 01:45:30 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id D6E093015CB2\n\tfor ; Thu, 9 Apr 2026 15:41:50 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 16AE53DD524;\n\tThu, 9 Apr 2026 15:41:50 +0000 (UTC)","from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id E64A32F549C;\n\tThu, 9 Apr 2026 15:41:49 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 6CEF9C4CEF7;\n\tThu, 9 Apr 2026 15:41:47 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1775749310; cv=none;\n b=n8t+zN7GHIqz1yC/wPutAVBQUoMnjEzjC+PMsBD0BWn051cFLbfPGcWxJnDAQ7zjwLmicg2yqmTsPb8+G26kk7LR4+dN5fhIR2cAn8ITI7r0+tNIha39cWMAAG13gCplxYxYhyPUFrwgxsbxgx6j59osomre1uD0lGrOGQawQOc=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1775749310; c=relaxed/simple;\n\tbh=osskFND0gD7NhmG8a1qgihTn2NK1itGDCwQVH1cu8EI=;\n\th=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:\n\t Content-Type:Content-Disposition:In-Reply-To;\n b=TuuW08isTEvAu8upkkZxpqy0zuFPxLQrEYRk2JNZ2WBTPDAApt+AbYMTQmhaZdt2JRrWqN8fvEpUNfVtyKoxxfjG6Bd5UoS6M9XMkFdguCB4v39dSRBydpMqU08AAcBhHl0Dqk0UBz355sZWmpyzcIhFbM7fCIdQK2fRxzeMBDk=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=fPF2pvnr; arc=none smtp.client-ip=10.30.226.201","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1775749309;\n\tbh=osskFND0gD7NhmG8a1qgihTn2NK1itGDCwQVH1cu8EI=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=fPF2pvnr2fSjiJLAMO6Bh4704uS8IM2kd4jIdmqJh9Kp3mr8aIgS9maEMa8S/y78v\n\t LH7IIjy3xqgecHDnFGGUBj5+8PdSyfnTJvpQnVPN0Yqab+yKL4ViF/ouT35Mnv2jDS\n\t 5G5shg0YpHicJ2REZOgP7eWyN65ODI2QFSzA9/UqGx0UP6XL3S3Aix4UM/JbUR0Ya9\n\t V/xFtEYPlTi/gjz9++HViNAHO7mkBxGDfCqr1Wezl8ooJcvEZpPlCP0TCT0UkJQ9S+\n\t 8wxkIcx0c/Ddt48BXco7b+FNdDtY5H7/7/FDtPBANKFLGu97Y7cUjN34VCWpdXQ9QT\n\t AWYXRwY8V2TBw==","Date":"Thu, 9 Apr 2026 16:41:45 +0100","From":"Conor Dooley ","To":"Yixun Lan ","Cc":"Uwe =?iso-8859-1?q?Kleine-K=F6nig?= ,\n Rob Herring , Krzysztof Kozlowski ,\n Conor Dooley ,\n Duje =?utf-8?q?Mihanovi=C4=87?= ,\n linux-pwm@vger.kernel.org, devicetree@vger.kernel.org,\n linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org,\n spacemit@lists.linux.dev","Subject":"Re: [PATCH 1/2] dt-bindings: pwm: marvell,pxa-pwm: Add SpacemiT K3\n PWM support","Message-ID":"<20260409-laboring-announcer-4a0f9ca152a1@spud>","References":"<20260409-03-k3-pwm-drv-v1-0-1307a06fba38@kernel.org>\n <20260409-03-k3-pwm-drv-v1-1-1307a06fba38@kernel.org>","Precedence":"bulk","X-Mailing-List":"linux-pwm@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha512;\n\tprotocol=\"application/pgp-signature\"; boundary=\"5LSQ/VAQK69bVtgG\"","Content-Disposition":"inline","In-Reply-To":"<20260409-03-k3-pwm-drv-v1-1-1307a06fba38@kernel.org>"}},{"id":3675563,"web_url":"http://patchwork.ozlabs.org/comment/3675563/","msgid":"<20260409234351-GKA1160389@kernel.org>","list_archive_url":null,"date":"2026-04-09T23:43:51","subject":"Re: [PATCH 1/2] dt-bindings: pwm: marvell,pxa-pwm: Add SpacemiT K3\n PWM support","submitter":{"id":91543,"url":"http://patchwork.ozlabs.org/api/people/91543/","name":"Yixun Lan","email":"dlan@kernel.org"},"content":"Hi Conor, \n\nOn 16:41 Thu 09 Apr , Conor Dooley wrote:\n> On Thu, Apr 09, 2026 at 12:45:11AM +0000, Yixun Lan wrote:\n> > The PWM controller in SpacemiT K3 SoC reuse the same IP as previous K1\n> > generation, while the difference is that one additional bus clock is\n> > added.\n> > \n> > Signed-off-by: Yixun Lan \n> > ---\n> > .../devicetree/bindings/pwm/marvell,pxa-pwm.yaml | 53 ++++++++++++++++++++--\n> > 1 file changed, 50 insertions(+), 3 deletions(-)\n> > \n> > diff --git a/Documentation/devicetree/bindings/pwm/marvell,pxa-pwm.yaml b/Documentation/devicetree/bindings/pwm/marvell,pxa-pwm.yaml\n> > index 8df327e52810..3427c8ef3945 100644\n> > --- a/Documentation/devicetree/bindings/pwm/marvell,pxa-pwm.yaml\n> > +++ b/Documentation/devicetree/bindings/pwm/marvell,pxa-pwm.yaml\n> > @@ -15,7 +15,9 @@ allOf:\n> > properties:\n> > compatible:\n> > contains:\n> > - const: spacemit,k1-pwm\n> > + enum:\n> > + - spacemit,k1-pwm\n> > + - spacemit,k3-pwm\n> > then:\n> > properties:\n> > \"#pwm-cells\":\n> > @@ -26,6 +28,38 @@ allOf:\n> > const: 1\n> > description: |\n> > Used for specifying the period length in nanoseconds.\n> > + - if:\n> > + properties:\n> > + compatible:\n> > + contains:\n> > + enum:\n> > + - spacemit,k3-pwm\n> > + then:\n> > + properties:\n> > + clock-names:\n> > + items:\n> > + - const: func\n> > + - const: bus\n> \n> This condition here doesn't appear to do anything? It just repeats\n> what's already done unconditonally below?\n> \nYou right, I should merge clock-names with below..\n\n> > + - if:\n> > + properties:\n> > + compatible:\n> > + contains:\n> > + enum:\n> > + - spacemit,k3-pwm\n> > + then:\n> > + required:\n> > + - clock-names\n> > + properties:\n> > + clocks:\n> > + minItems: 2\n> > + clock-names:\n> > + minItems: 2\n> > + else:\n> > + properties:\n> > + clocks:\n> > + maxItems: 1\n> > + clock-names:\n> > + maxItems: 1\n> > \n> > properties:\n> > compatible:\n> > @@ -36,7 +70,9 @@ properties:\n> > - marvell,pxa168-pwm\n> > - marvell,pxa910-pwm\n> > - items:\n> > - - const: spacemit,k1-pwm\n> > + - enum:\n> > + - spacemit,k1-pwm\n> > + - spacemit,k3-pwm\n> > - const: marvell,pxa910-pwm\n> > \n> > reg:\n> > @@ -47,7 +83,18 @@ properties:\n> > description: Number of cells in a pwm specifier.\n> > \n> > clocks:\n> > - maxItems: 1\n> > + minItems: 1\n> > + items:\n> > + - description: The function clock\n> > + - description: An optional bus clock\n> > +\n> > + clock-names:\n> > + minItems: 1\n> > + maxItems: 2\n> > + oneOf:\n> > + - items:\n> > + - const: func\n> > + - const: bus\n> > \n> > resets:\n> > maxItems: 1\n> > \n> > -- \n> > 2.53.0\n> >","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-pwm@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=BAmDpI6p;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c09:e001:a7::12fc:5321; helo=sto.lore.kernel.org;\n envelope-from=linux-pwm+bounces-8542-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"BAmDpI6p\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201"],"Received":["from sto.lore.kernel.org (sto.lore.kernel.org\n [IPv6:2600:3c09:e001:a7::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fsGjT656pz1xtJ\n\tfor ; Fri, 10 Apr 2026 09:43:57 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sto.lore.kernel.org (Postfix) with ESMTP id 71D0C3012BF4\n\tfor ; Thu, 9 Apr 2026 23:43:55 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 63A883A2569;\n\tThu, 9 Apr 2026 23:43:54 +0000 (UTC)","from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 403883A2542;\n\tThu, 9 Apr 2026 23:43:54 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 58292C2BC87;\n\tThu, 9 Apr 2026 23:43:53 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1775778234; cv=none;\n b=ai3DAcsDnhEaSoeXSZOpffn4eCQwapYDp+vAuQYrmlBXzVhqct8Na/QKvGpDabo1Ly7IdRBZC3Ux7H9FfZqrZPtvXbRmKlmqSnLk1LSrbJQL3jiVhgaxG+m4VGhLMfgXrQIt2A9B0RjodqRd8HtUoCZD8y2O05XXaKFJouNjR1c=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1775778234; c=relaxed/simple;\n\tbh=gAUOUKeQWfXMQS+gwzMyPSCdGvq7t2FyRZ1piCNyVsw=;\n\th=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:\n\t Content-Type:Content-Disposition:In-Reply-To;\n b=OHBu+a6YvjrfYH9D1MLlUR41Lokg/QFwKdiNNANq2hWPSHvO4lyxkLCoHrPG4IYZFQ7gS/ecBOdbB54WtslU+ZEFd3LSNV/MLJ8NIzX+nK0EuH1j/Kj8AJ3wllQTTfQVlzcPTwJq98GK4QGm3MLhhhluxFaatfVY6YSgvVtPlvE=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=BAmDpI6p; arc=none smtp.client-ip=10.30.226.201","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1775778233;\n\tbh=gAUOUKeQWfXMQS+gwzMyPSCdGvq7t2FyRZ1piCNyVsw=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=BAmDpI6p5H0OzeaMLCTzHNoflFqzKwKYdloMNxBi+6kGcMaa4S6XHSQ9wg5Wd2jcP\n\t hy+C8CQSJihzNs6WDtWiTnma3TI+IKBcM0eVxqMxPrDOo3PevseGl26/51rvAA4YIG\n\t VG3oYhF9d4HAYX/lDdTcrD3jxGWifNabJHPFhl1M/iMjcjiukfx35yyorXaozrTqqP\n\t Ox7EUsiNQ8S0sKwtrnMmgH39FKcQqDMQq4v2N+q45JKihxhiEwJVX5k7FpKxDFyUnD\n\t IsMTRDGdVcTP0ERDCfC0o8yblXIhHFBYzaJRswWrryilqniMO23nc0rMuc1s83Bjog\n\t 09JY03oEqpviA==","Date":"Fri, 10 Apr 2026 07:43:51 +0800","From":"Yixun Lan ","To":"Conor Dooley ","Cc":"=?unknown-8bit?q?Uwe__Kleine-K=F6nig__=3Cukleinek=40kernel=2Eorg=3E=2C_R?=\n\t=?unknown-8bit?q?ob_Herring_=3Crobh=40kernel=2Eorg=3E=2C_Krzysztof_Kozlowsk?=\n\t=?unknown-8bit?q?i_=3Ckrzk+dt=40kernel=2Eorg=3E=2C_Conor_Dooley_=3Cconor+dt?=\n\t=?unknown-8bit?q?=40kernel=2Eorg=3E=2C_Duje__Mihanovi=C4=87__=3Cduje=40duje?=\n\t=?unknown-8bit?q?mihanovic=2Exyz=3E=2C_linux-pwm=40vger=2Ekernel=2Eorg=2C_d?=\n\t=?unknown-8bit?q?evicetree=40vger=2Ekernel=2Eorg=2C_linux-kernel=40vger=2Ek?=\n\t=?unknown-8bit?q?ernel=2Eorg=2C_linux-riscv=40lists=2Einfradead=2Eorg=2C_sp?=\n\t=?unknown-8bit?q?acemit=40lists=2Elinux=2Edev?=","Subject":"Re: [PATCH 1/2] dt-bindings: pwm: marvell,pxa-pwm: Add SpacemiT K3\n PWM support","Message-ID":"<20260409234351-GKA1160389@kernel.org>","References":"<20260409-03-k3-pwm-drv-v1-0-1307a06fba38@kernel.org>\n <20260409-03-k3-pwm-drv-v1-1-1307a06fba38@kernel.org>\n <20260409-laboring-announcer-4a0f9ca152a1@spud>","Precedence":"bulk","X-Mailing-List":"linux-pwm@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20260409-laboring-announcer-4a0f9ca152a1@spud>"}}]