[{"id":3675113,"web_url":"http://patchwork.ozlabs.org/comment/3675113/","msgid":"<20260409-massive-natural-crayfish-c1cf2f@quoll>","list_archive_url":null,"date":"2026-04-09T07:30:22","subject":"Re: [PATCH v3 2/3] ARM: dts: aspeed-g6: Add nodes for i3c controllers","submitter":{"id":68952,"url":"http://patchwork.ozlabs.org/api/people/68952/","name":"Krzysztof Kozlowski","email":"krzk@kernel.org"},"content":"On Wed, Apr 08, 2026 at 10:34:34PM +0200, Dawid Glazik wrote:\n> Add the i3c controller devices to the ast2600 g6 common dts. We add all\n> 6 busses to the common g6 definition, but leave disabled through the\n> status property, to be enabled per-platform.\n> \n> Originally-by: Jeremy Kerr \n\nDon't invent tags. This is not used outside of TIP.\n\n> Signed-off-by: Dawid Glazik \n> ---\n> v3:\n> - add i3c aliases\n> - rebase on top of latest tree and solve conflicts\n> - as agreed with Jeremy off-list, he said I can take authorship of this going forward\n> v2:\n> - use inline bus representation, without the i3c: label\n> ---\n> arch/arm/boot/dts/aspeed/aspeed-g6.dtsi | 97 +++++++++++++++++++++++++\n> 1 file changed, 97 insertions(+)\n> \n> diff --git a/arch/arm/boot/dts/aspeed/aspeed-g6.dtsi b/arch/arm/boot/dts/aspeed/aspeed-g6.dtsi\n> index f5641128614f..f986fcbed604 100644\n> --- a/arch/arm/boot/dts/aspeed/aspeed-g6.dtsi\n> +++ b/arch/arm/boot/dts/aspeed/aspeed-g6.dtsi\n> @@ -29,6 +29,12 @@ aliases {\n> \t\ti2c13 = &i2c13;\n> \t\ti2c14 = &i2c14;\n> \t\ti2c15 = &i2c15;\n> +\t\ti3c0 = &i3c0;\n> +\t\ti3c1 = &i3c1;\n> +\t\ti3c2 = &i3c2;\n> +\t\ti3c3 = &i3c3;\n> +\t\ti3c4 = &i3c4;\n> +\t\ti3c5 = &i3c5;\n\nBus aliases are not properties of SoC DTSI.\n\n> \t\tserial0 = &uart1;\n> \t\tserial1 = &uart2;\n> \t\tserial2 = &uart3;\n> @@ -1066,6 +1072,97 @@ i2c15: i2c@800 {\n> \t\t\t\t};\n> \t\t\t};\n> \n> +\t\t\tbus@1e7a0000 {\n> +\t\t\t\tcompatible = \"simple-bus\";\n> +\t\t\t\t#address-cells = <1>;\n> +\t\t\t\t#size-cells = <1>;\n> +\t\t\t\tranges = <0 0x1e7a0000 0x8000>;\n> +\n> +\t\t\t\ti3c_global: i3c-global@0 {\n\nNode names should be generic. See also an explanation and list of\nexamples (not exhaustive) in DT specification:\nhttps://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation\nIf you cannot find a name matching your device, please check in kernel\nsources for similar cases or you can grow the spec (via pull request to\nDT spec repo).\n\nBest regards,\nKrzysztof","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-aspeed@lists.ozlabs.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=ubxdOzey;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=112.213.38.117; helo=lists.ozlabs.org;\n envelope-from=linux-aspeed+bounces-3879-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)","lists.ozlabs.org;\n arc=none smtp.remote-ip=\"2600:3c04:e001:324:0:1991:8:25\"","lists.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org","lists.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=ubxdOzey;\n\tdkim-atps=neutral","lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org\n (client-ip=2600:3c04:e001:324:0:1991:8:25; helo=tor.source.kernel.org;\n envelope-from=krzk@kernel.org; receiver=lists.ozlabs.org)"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1 raw public key)\n server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4frs6D1q1vz1xtJ\n\tfor ; Thu, 09 Apr 2026 17:30:28 +1000 (AEST)","from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4frs6C6Ckrz2yVt;\n\tThu, 09 Apr 2026 17:30:27 +1000 (AEST)","from tor.source.kernel.org (tor.source.kernel.org\n [IPv6:2600:3c04:e001:324:0:1991:8:25])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4frs6C1GgSz2xTh\n\tfor ; Thu, 09 Apr 2026 17:30:27 +1000 (AEST)","from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58])\n\tby tor.source.kernel.org (Postfix) with ESMTP id 2443D600AD;\n\tThu, 9 Apr 2026 07:30:25 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 4827EC4CEF7;\n\tThu, 9 Apr 2026 07:30:24 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1775719827;\n\tcv=none;\n b=RDT746Vev5Anp4C5i4DIZE2N821DZmRqJvZ9vbYkXVM5T5KOU2GYA8twNJSml4tcfGPF5skGpdSegsop0O5UYMe7Nq1uPmaDwtAgIoyDGD41Jx4ya8LqOWb/4SA3fvVMW0Ytag/hvfIQyVHhTsuP7kF5Cx2/aeR60RY9vJDsT7SWKRlsY5XXUgof1z4yCs0PlPtL7g15nPRoeHXcvw+eOm2E0dbAzJEWQeip48P7XnjziyKmoVA77+MG8qvV0v0KKvUcxSR1+NEewNH/IMKemT4CG9Db08FjGInHEN/PQRg/Rx1E8WoCGe/BtyvK+f81l4Bg2lW7lkCY9mrfihi4jA==","ARC-Message-Signature":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1775719827; c=relaxed/relaxed;\n\tbh=BT4K2Zf/nxxoglAtguOwCkdFi7MIc2xLvXbL9RRrrX4=;\n\th=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:\n\t Content-Type:Content-Disposition:In-Reply-To;\n b=OpYepLiiSTyoMV2tLOOqo6pOZ49ZNZLvQwoZq/027YHenjEKBy5a+LBYPnsqgDsfuOeCxyj1JnmA0mwkqhBQ3g/R+K3Nn5XyH0H1Unevs4DMxIsKR4uNxDSYUfqWJfYe19cUsr+H8V1CLvTLMCLDjc4OBDqL0cF9E2Wc4BfwnZ2ew+736h/3gd4VGXXKZw1heBhEapNvv4qus1+ZJqrc22hk5mI6YRhYhXEFRjUFKrsNVfhZZZ38kxgoSVfYL9SwASqhfnYcvSyRHCU1xeqsSWwrbj+ZB5g1Gm48kk6s7T7X+NS0KICDOeGDtghSPi1R4gqLqFAS/tUXsgTPzbTS9A==","ARC-Authentication-Results":"i=1; lists.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org;\n dkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=ubxdOzey; dkim-atps=neutral;\n spf=pass (client-ip=2600:3c04:e001:324:0:1991:8:25;\n helo=tor.source.kernel.org; envelope-from=krzk@kernel.org;\n receiver=lists.ozlabs.org) smtp.mailfrom=kernel.org","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1775719824;\n\tbh=vwghWor8OZe17SmQaOpkWmuy9YBmg+3I3XnkIV/bOig=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=ubxdOzeyBTj+xJL5QphQ13nGFi9Y7uZlWAPeqOQVhIbTssTm5eLVRQfZGM0zCNBP2\n\t CuRqfybrbijyPd2NCt9JaXYmSRYiI+ObSkFP89QOPazz6ZKGRlwC2BRRg2LiIaUaUZ\n\t vArBk2OpZRCUFWnWxD69y3CShwa7If0gChD47f9b59ibWotr1kowXE7gOoXaP96ymj\n\t 54R8bO/ZzzCjyDS9y8Rz+ge2M0HXiDnncQGdtibon+vRkHEb4oU3l/o8DpRgUrUWHc\n\t D8dbVIw99xyu5lXojtVjYkysEKG+/bjMk4o1ND4HSjv200ODdMIcbC6ixGTeiVhdRs\n\t 2NXKxf8/6xyoA==","Date":"Thu, 9 Apr 2026 09:30:22 +0200","From":"Krzysztof Kozlowski ","To":"Dawid Glazik ","Cc":"Alexandre Belloni ,\n\tRob Herring , Krzysztof Kozlowski ,\n\tConor Dooley , Joel Stanley ,\n\tAndrew Jeffery , linux-aspeed@lists.ozlabs.org,\n linux-i3c@lists.infradead.org,\n\tdevicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,\n\tFrank Li , Maciej Lawniczak ,\n\tJeremy Kerr ","Subject":"Re: [PATCH v3 2/3] ARM: dts: aspeed-g6: Add nodes for i3c controllers","Message-ID":"<20260409-massive-natural-crayfish-c1cf2f@quoll>","References":"\n <51c4bdc02b45f67a0e32610a228091e137c135a6.1775679285.git.dawid.glazik@linux.intel.com>","X-Mailing-List":"linux-aspeed@lists.ozlabs.org","List-Id":"","List-Help":"","List-Owner":"","List-Post":"","List-Archive":",\n ","List-Subscribe":",\n ,\n ","List-Unsubscribe":"","Precedence":"list","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"\n <51c4bdc02b45f67a0e32610a228091e137c135a6.1775679285.git.dawid.glazik@linux.intel.com>","X-Spam-Status":"No, score=-0.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,\n\tDKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS\n\tautolearn=disabled version=4.0.1","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org"}},{"id":3675115,"web_url":"http://patchwork.ozlabs.org/comment/3675115/","msgid":"<20260409-beautiful-paper-labradoodle-d846f1@quoll>","list_archive_url":null,"date":"2026-04-09T07:31:41","subject":"Re: [PATCH v3 2/3] ARM: dts: aspeed-g6: Add nodes for i3c controllers","submitter":{"id":68952,"url":"http://patchwork.ozlabs.org/api/people/68952/","name":"Krzysztof Kozlowski","email":"krzk@kernel.org"},"content":"On Wed, Apr 08, 2026 at 10:34:34PM +0200, Dawid Glazik wrote:\n> +\t\t\tbus@1e7a0000 {\n> +\t\t\t\tcompatible = \"simple-bus\";\n> +\t\t\t\t#address-cells = <1>;\n> +\t\t\t\t#size-cells = <1>;\n> +\t\t\t\tranges = <0 0x1e7a0000 0x8000>;\n> +\n> +\t\t\t\ti3c_global: i3c-global@0 {\n> +\t\t\t\t\tcompatible = \"aspeed,ast2600-i3c-global\", \"syscon\";\n\nAlso undocumented ABI. Apply this patch and run checkpatch.\n\n\nBest regards,\nKrzysztof","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-aspeed@lists.ozlabs.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=P1V3bA0G;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=2404:9400:21b9:f100::1; helo=lists.ozlabs.org;\n envelope-from=linux-aspeed+bounces-3881-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)","lists.ozlabs.org;\n arc=none smtp.remote-ip=\"2600:3c04:e001:324:0:1991:8:25\"","lists.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org","lists.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=P1V3bA0G;\n\tdkim-atps=neutral","lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org\n (client-ip=2600:3c04:e001:324:0:1991:8:25; helo=tor.source.kernel.org;\n envelope-from=krzk@kernel.org; receiver=lists.ozlabs.org)"],"Received":["from lists.ozlabs.org (lists.ozlabs.org\n [IPv6:2404:9400:21b9:f100::1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1 raw public key)\n server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4frs7k22Gvz1xtJ\n\tfor ; Thu, 09 Apr 2026 17:31:46 +1000 (AEST)","from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4frs7k15XTz2ygY;\n\tThu, 09 Apr 2026 17:31:46 +1000 (AEST)","from tor.source.kernel.org (tor.source.kernel.org\n [IPv6:2600:3c04:e001:324:0:1991:8:25])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4frs7j3svNz2xTh\n\tfor ; Thu, 09 Apr 2026 17:31:45 +1000 (AEST)","from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58])\n\tby tor.source.kernel.org (Postfix) with ESMTP id A07BB600AD;\n\tThu, 9 Apr 2026 07:31:43 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id C547FC4CEF7;\n\tThu, 9 Apr 2026 07:31:42 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1775719906;\n\tcv=none;\n b=mBA8BfJMOc2ImvGvPb8FrOHWXchiTfxlwXPWbiDggPhRXWMyl42aQ0uXjTjmtUZRpkKKXoA/uU4/r0fi9/RUlSeziO8oYoQFgsaUPK8iVcAYOWunKSTzYPGPa6liVz90VUf+axF0JSTGj9R5p6YORz/WY0pKh5BQzv/IR87WPUlLRs/jBP3wLuHQILIgdnyxQeMYPr+EvZIGdQbxX8FVxMClAst68gacHhBseJQyiihgfEPMD9ApLsFDtXSt1m3O4iuwGd7HznA+0dUfXI4bIFVQqOyv+G/12Vkz6Cd3ax+k2/QP4nzV4hojFQPRefUpFAummdJIiwji1RQORS0Ocg==","ARC-Message-Signature":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1775719906; c=relaxed/relaxed;\n\tbh=/NkLF4MygYy5gKmKhlqnhxgftiNvN3ddcJNBsSrhiws=;\n\th=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:\n\t Content-Type:Content-Disposition:In-Reply-To;\n b=LVvrAnaAKAX7GOP64jaj3CRINsMFef4HayUGDpdn4wYiI7abhjbxvi1ZgK+penCEd3uO10UEIsxaqZRCjG2TSq8D26RH3YK8A7p8zy/E7vUuiwOO0OuF+9biSq1797mUx9QtWsnImmv9VtN/OU4zsPkLueawc3pQQN09H7SEgrWVMzLzQh/JdQWWmNaXoj2v1ch6Z8BcVBoPRvfd0swxf/puLf90ZUpeVyBrHP0Zo3oMPmSIVeHV0avQpknae6r60/PDxpUA9U7Sgx42945Jcd/jJvrRJsOZTTMIb40yg/KKkdhMOH9WTJX9x0M5erT39t3yaEzJLBJoWaBnglHpag==","ARC-Authentication-Results":"i=1; lists.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org;\n dkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=P1V3bA0G; dkim-atps=neutral;\n spf=pass (client-ip=2600:3c04:e001:324:0:1991:8:25;\n helo=tor.source.kernel.org; envelope-from=krzk@kernel.org;\n receiver=lists.ozlabs.org) smtp.mailfrom=kernel.org","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1775719903;\n\tbh=xoXaHyJutfcxSGhgHWM74nFyJDBXvAN8t1HEtk8e6vY=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=P1V3bA0Gzx8Fwg65L8SnBoKFD6eyiea3S/Y2uxq8LK+hYe0oJUYUkPN+ZpqJGS9Kw\n\t txd7qibsvXqwu7xi5KYPir2Agb/zIPjfAR6CRySWRvrffJPp0rQ6jVLTlWL5t9z4aN\n\t wY/ohTIkESdhFiKCEp9eBzhEl5HkEWyHKLhQLy8zQNBzJjlsaYoUkIKsYJfYI2z8jd\n\t Z68yTV5jmF0LAcPe/fuCY6/c7BMtM782ASnFqB2UEkU6/Wyc8oQgO+NCpthhnxgFgi\n\t n969xqxvD0SzDMwlTr3oo4RGRuNy0pVeKeETFZS5xkALG0mIaM3VC8rtdsF6g0GLwC\n\t dR9q86Zb7gJUQ==","Date":"Thu, 9 Apr 2026 09:31:41 +0200","From":"Krzysztof Kozlowski ","To":"Dawid Glazik ","Cc":"Alexandre Belloni ,\n\tRob Herring , Krzysztof Kozlowski ,\n\tConor Dooley , Joel Stanley ,\n\tAndrew Jeffery , linux-aspeed@lists.ozlabs.org,\n linux-i3c@lists.infradead.org,\n\tdevicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,\n\tFrank Li , Maciej Lawniczak ,\n\tJeremy Kerr ","Subject":"Re: [PATCH v3 2/3] ARM: dts: aspeed-g6: Add nodes for i3c controllers","Message-ID":"<20260409-beautiful-paper-labradoodle-d846f1@quoll>","References":"\n <51c4bdc02b45f67a0e32610a228091e137c135a6.1775679285.git.dawid.glazik@linux.intel.com>","X-Mailing-List":"linux-aspeed@lists.ozlabs.org","List-Id":"","List-Help":"","List-Owner":"","List-Post":"","List-Archive":",\n ","List-Subscribe":",\n ,\n ","List-Unsubscribe":"","Precedence":"list","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"\n <51c4bdc02b45f67a0e32610a228091e137c135a6.1775679285.git.dawid.glazik@linux.intel.com>","X-Spam-Status":"No, score=-0.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,\n\tDKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS\n\tautolearn=disabled version=4.0.1","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org"}}]