[{"id":3676202,"web_url":"http://patchwork.ozlabs.org/comment/3676202/","msgid":"<358e3185-1a42-4786-9c37-fe7ac41054e6@kernel-space.org>","list_archive_url":null,"date":"2026-04-11T20:28:16","subject":"Re: [PATCH v3 5/5] board: qemu: m68k: Create virtio mmio instances","submitter":{"id":85702,"url":"http://patchwork.ozlabs.org/api/people/85702/","name":"Angelo Dureghello","email":"angelo@kernel-space.org"},"content":"Hi Daniel,\n\nAfter applying this patch i got an error building\n\non a test build i am getting this error:\n\n m68k: + qemu-m68k\n+ 422 | sep = memchr(fixup_str, ':', fixup_len);\n+ | ^\n+ 432 | sep = memchr(name, ':', fixup_len);\n+m68k-linux-ld: cmd/virtio.o: in function `do_virtio':\n+cmd/virtio.c:42:(.text.do_virtio+0xa6): undefined reference to `blk_common_cmd'\n+m68k-linux-ld: final link failed: bad value\n+make[1]: *** [Makefile:2105: u-boot] Error 1\n+make: *** [Makefile:189: __sub-make] Error 2\n\nLooks like a \"select BLK\" is missing.\n\nRegards,\nangelo\n\nOn 4/9/26 00:09, Daniel Palmer wrote:\n> So that you can use virtio network, block etc create the virtio mmio\n> instances. There are 128 of these even if they are not all used, a\n> single mmio base value is passed via bootinfo.\n> \n> Signed-off-by: Daniel Palmer \n> ---\n> arch/m68k/Kconfig | 14 ++++----\n> board/emulation/qemu-m68k/qemu-m68k.c | 47 +++++++++++++++++++++++++++\n> 2 files changed, 55 insertions(+), 6 deletions(-)\n> \n> diff --git a/arch/m68k/Kconfig b/arch/m68k/Kconfig\n> index 6ce8f577e3a1..20a112880c87 100644\n> --- a/arch/m68k/Kconfig\n> +++ b/arch/m68k/Kconfig\n> @@ -195,12 +195,14 @@ config TARGET_STMARK2\n> select M54418\n> \n> config TARGET_QEMU_M68K\n> - bool \"Support QEMU m68k virt\"\n> - select M68040\n> - imply CMD_DM\n> - help\n> - This target supports the QEMU m68k virtual machine (-M virt).\n> - It simulates a Motorola 68040 CPU with Goldfish peripherals.\n> +\tbool \"Support QEMU m68k virt\"\n> +\tselect M68040\n> +\tselect BOARD_EARLY_INIT_R\n> +\tselect VIRTIO_MMIO\n> +\timply CMD_DM\n> +\thelp\n> +\t This target supports the QEMU m68k virtual machine (-M virt).\n> +\t It simulates a Motorola 68040 CPU with Goldfish peripherals.\n> \n> endchoice\n> \n> diff --git a/board/emulation/qemu-m68k/qemu-m68k.c b/board/emulation/qemu-m68k/qemu-m68k.c\n> index d3527aee1128..3617c61b5c1f 100644\n> --- a/board/emulation/qemu-m68k/qemu-m68k.c\n> +++ b/board/emulation/qemu-m68k/qemu-m68k.c\n> @@ -14,9 +14,14 @@\n> #include \n> #include \n> #include \n> +#include \n> +#include \n> +#include \n> #include \n> +#include \n> #include \n> #include \n> +#include \n> \n> DECLARE_GLOBAL_DATA_PTR;\n> \n> @@ -25,6 +30,38 @@ static struct goldfish_rtc_plat rtc_plat;\n> static struct goldfish_timer_plat timer_plat;\n> static struct qemu_virt_ctrl_plat reset_plat;\n> \n> +#define VIRTIO_MMIO_NUM\t128\n> +#define VIRTIO_MMIO_SZ\t0x200\n> +\n> +static struct virtio_mmio_plat virtio_mmio_plat[VIRTIO_MMIO_NUM];\n> +static char virtio_mmio_names[VIRTIO_MMIO_NUM][11];\n> +static phys_addr_t virtio_mmio_base;\n> +\n> +static inline int create_virtio_mmios(void)\n> +{\n> +\tstruct driver *drv;\n> +\tint i, ret;\n> +\n> +\tif (!virtio_mmio_base)\n> +\t\treturn -ENODEV;\n> +\n> +\tdrv = lists_driver_lookup_name(\"virtio-mmio\");\n> +\tif (!drv)\n> +\t\treturn -ENOENT;\n> +\n> +\tfor (i = 0; i < VIRTIO_MMIO_NUM; i++) {\n> +\t\tvirtio_mmio_plat[i].base = virtio_mmio_base + (VIRTIO_MMIO_SZ * i);\n> +\t\tsprintf(virtio_mmio_names[i], \"virtio-%d\", i);\n> +\n> +\t\tret = device_bind(dm_root(), drv, virtio_mmio_names[i],\n> +\t\t\t\t &virtio_mmio_plat[i], ofnode_null(), NULL);\n> +\t\tif (ret)\n> +\t\t\treturn ret;\n> +\t}\n> +\n> +\treturn 0;\n> +}\n> +\n> /*\n> * Theoretical limit derivation:\n> * Max Bootinfo Size (Standard Page) = 4096 bytes\n> @@ -65,6 +102,9 @@ static void parse_bootinfo(void)\n> \t\tcase BI_VIRT_CTRL_BASE:\n> \t\t\treset_plat.reg = base;\n> \t\t\tbreak;\n> +\t\tcase BI_VIRT_VIRTIO_BASE:\n> +\t\t\tvirtio_mmio_base = base;\n> +\t\t\tbreak;\n> \t\tcase BI_MEMCHUNK:\n> \t\t\tgd->ram_size = record->data[1];\n> \t\t\tbreak;\n> @@ -80,6 +120,13 @@ int board_early_init_f(void)\n> \treturn 0;\n> }\n> \n> +int board_early_init_r(void)\n> +{\n> +\tcreate_virtio_mmios();\n> +\n> +\treturn 0;\n> +}\n> +\n> int checkboard(void)\n> {\n> \tputs(\"Board: QEMU m68k virt\\n\");\n\n-- Angelo","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=kernel-space.org header.i=@kernel-space.org\n header.a=rsa-sha256 header.s=s1 header.b=MlPtCDk6;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=85.214.62.61; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=reject dis=none) header.from=kernel-space.org","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=kernel-space.org header.i=@kernel-space.org\n header.b=\"MlPtCDk6\";\n\tdkim-atps=neutral","phobos.denx.de; dmarc=pass (p=reject dis=none)\n header.from=kernel-space.org","phobos.denx.de;\n spf=pass smtp.mailfrom=angelo@kernel-space.org"],"Received":["from phobos.denx.de (phobos.denx.de [85.214.62.61])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4ftQH16Kmdz1yGb\n\tfor ; Sun, 12 Apr 2026 06:28:29 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 7BE1384154;\n\tSat, 11 Apr 2026 22:28:21 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id 060E28416F; Sat, 11 Apr 2026 22:28:20 +0200 (CEST)","from mail.kernel-space.org (unknown\n [IPv6:2a03:4000:b:d08:14a9:1bff:fedc:75ad])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 095F484118\n for ; Sat, 11 Apr 2026 22:28:18 +0200 (CEST)","from [IPV6:2a07:7e81:7daa:0:62cf:84ff:feee:627] (\n [2a07:7e81:7daa:0:62cf:84ff:feee:627])\n by oreshnik (OpenSMTPD) with ESMTPSA id dcb11655\n (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO);\n Sat, 11 Apr 2026 20:28:17 +0000 (UTC)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-1.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,RDNS_NONE,\n SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.2","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-space.org;\n s=s1; t=1775939297;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=acy90WBzBBJuVe2EbSnH/yoTHey0BoWflW9qc95271Y=;\n b=MlPtCDk61CVXWGPVTaurevWPLcTxozaO6SbwZNyVp0hCzlOU4r8qUvr7Tn1FV5ZwR3ltcm\n Rn+WXNprMNwG8kHsLbAqsPCVhG5h8UBTE4n05kyaIzHy/b7t2peKuKoaiWX0KeNmK0AaeW\n 1HuxuVZ5Jf+yUgVieq5qqwDdV8j76pM=","Message-ID":"<358e3185-1a42-4786-9c37-fe7ac41054e6@kernel-space.org>","Date":"Sat, 11 Apr 2026 22:28:16 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v3 5/5] board: qemu: m68k: Create virtio mmio instances","To":"Daniel Palmer , visitorckw@gmail.com, bmeng.cn@gmail.com","Cc":"u-boot@lists.denx.de","References":"<20260408220928.3328551-1-daniel@thingy.jp>\n <20260408220928.3328551-6-daniel@thingy.jp>","Content-Language":"en-US, it","From":"Angelo Dureghello ","In-Reply-To":"<20260408220928.3328551-6-daniel@thingy.jp>","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"7bit","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}},{"id":3676204,"web_url":"http://patchwork.ozlabs.org/comment/3676204/","msgid":"","list_archive_url":null,"date":"2026-04-11T20:31:04","subject":"Re: [PATCH v3 5/5] board: qemu: m68k: Create virtio mmio instances","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"Hi Daniel,\n\nOn 2026-04-08T22:09:23, Daniel Palmer wrote:\n> board: qemu: m68k: Create virtio mmio instances\n>\n> So that you can use virtio network, block etc create the virtio mmio\n> instances. There are 128 of these even if they are not all used, a\n> single mmio base value is passed via bootinfo.\n>\n> Signed-off-by: Daniel Palmer \n>\n> arch/m68k/Kconfig | 14 ++++++-----\n> board/emulation/qemu-m68k/qemu-m68k.c | 47 +++++++++++++++++++++++++++++++++++\n> 2 files changed, 55 insertions(+), 6 deletions(-)\n\n> diff --git a/board/emulation/qemu-m68k/qemu-m68k.c b/board/emulation/qemu-m68k/qemu-m68k.c\n> @@ -25,6 +30,38 @@ static struct qemu_virt_ctrl_plat reset_plat;\n> +static inline int create_virtio_mmios(void)\n\nPlease can you drop the inline keyword here? It is not needed for a\nfunction called only once and not in a header file.\n\n> diff --git a/board/emulation/qemu-m68k/qemu-m68k.c b/board/emulation/qemu-m68k/qemu-m68k.c\n> @@ -80,6 +120,13 @@ int board_early_init_f(void)\n> +int board_early_init_r(void)\n> +{\n> + create_virtio_mmios();\n> +\n> + return 0;\n> +}\n\nThe return value from create_virtio_mmios() is discarded - really this\nshould be checked. If not, perhaps log_debug() or log_warning() would\nhelp report when virtio-mmio devices are not created?\n\nRegards,\nSimon","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256\n header.s=google header.b=VU5cByAJ;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=85.214.62.61; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org\n header.b=\"VU5cByAJ\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=sjg@chromium.org"],"Received":["from phobos.denx.de (phobos.denx.de [85.214.62.61])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4ftQLS6Sh5z1yCv\n\tfor ; Sun, 12 Apr 2026 06:31:28 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 4DCAC84198;\n\tSat, 11 Apr 2026 22:31:26 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id 4858884198; Sat, 11 Apr 2026 22:31:24 +0200 (CEST)","from mail-ed1-x535.google.com (mail-ed1-x535.google.com\n [IPv6:2a00:1450:4864:20::535])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 2AA2D841B9\n for ; Sat, 11 Apr 2026 22:31:21 +0200 (CEST)","by mail-ed1-x535.google.com with SMTP id\n 4fb4d7f45d1cf-66f727d6849so4671146a12.1\n for ; Sat, 11 Apr 2026 13:31:21 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2","ARC-Seal":"i=1; a=rsa-sha256; t=1775939480; cv=none;\n d=google.com; s=arc-20240605;\n b=kZiD0V2spfQzU5TPg47tB6aTJlNsnK0vvKtziHeFnTNpEJyd8LdV+3xHlIRyMZ2xHP\n 0kZsfN4+6jtNsMkLTWfG1SmlOX/9bM4+sIgLJ8FYuyUvYpaFnrvZKHDSHTMFPoRtwrKQ\n 341sV31vDq0M87/qVjIyGDdsSR3AhAl8auwnOVPx7SiFJGLzlTfpaKNVUtKf/mTpYBFy\n qFdNY4pQiLRQx0/F/J2xt5RBfMKtFXUd+5mNRxeVLXNMuA/J+vw93iNtswhX8vOSXiav\n UhQQEVqRoQSXXEntBCwBmLUfp2YAwXRINK67m/wEyOzLsjXpoHxm428zSETGhOU7occS\n UrTQ==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:dkim-signature;\n bh=asciO2sC2l8wVvFXsrQEdWvaKuH8CNKKLgigQZwvWCE=;\n fh=zmaIjKiWjntoLGDg2H+ia8/7xCQKism+FOaSsAFHQho=;\n b=WDjz2H+HC3cQUhnu6K5hmhy145GWAonZdVMWAN12gAyBi/+aqqQ6NyccCl0lcWknj3\n 4lU519Ob7yCWVDd8rsgI3nLq9MyALLhFcv/Ul4DZIgvizaxA8bGXEW89rTqNNzPN8FoR\n 1iTWSyG3ajvSp2itSgkEXT4kWIsQ0EP5PqIXMumcpXgjZ4SfyFIFDQc/iCdI2SfBG1SQ\n 7pCmCFkEUOFBOg7rXAuHXVCiGNX2Pek5AuJ7wlR2qgzOKgqpr0nUL/DyN256WGINVcGA\n FF1Fi8tpk5SJAr5j0RHQoJcVdyQpRBHs7vk1WjdNH3amYHrredlQ7btvagOIk2lE2OSB\n mxxQ==; darn=lists.denx.de","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=chromium.org; s=google; t=1775939480; x=1776544280; darn=lists.denx.de;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:from:to:cc:subject:date:message-id:reply-to;\n bh=asciO2sC2l8wVvFXsrQEdWvaKuH8CNKKLgigQZwvWCE=;\n b=VU5cByAJgvTTZ84dIFAUIAL643Zn0luQ/StCreB1WB/jUc3PtfDruvpvqtuRPQX1ss\n GPqwzTk0Psaxzk2kz6V4r18KZAjlWEcA8P+yXYnq0NSc7ig2entaRIY1KbrTLD3Gb6Vp\n WxR6to7CLuxGKSc4mWbDGYRLAG/pGnEI+C4Mc=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775939480; x=1776544280;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=asciO2sC2l8wVvFXsrQEdWvaKuH8CNKKLgigQZwvWCE=;\n b=XgG3AWZVJIoiEOX1sOvglfNS9upWaBMTqOOMjUHRUwHM+Xezt7ggERY8byCRdVT7Mr\n oqpDQ2mpxXydXnPMxhtqDphvg2Mv/0Keah15r8GE6nk0JGMGR2NmeL3gom7N7Gi8NdS0\n qDJxvN1tUXlUc12WxXiSG2oq577yh5cq4xN7b4JjX28ijBs0qnV1vI8Ye5oe0eOKqZDj\n TrElQjxhSgO9XBROHzaz8LkDJn3LgFtc19N9o2/+BjUjXYPM6yTMPYnoNzxgv9qpbZ9z\n kCLBnjqK54/XtHgbEFX5iLAoJpd2ybraUVngI+emshm4pd61lRAUC7BAZ7NVCK+X9H0C\n YgWQ==","X-Forwarded-Encrypted":"i=1;\n AJvYcCWpjkFXvl/XW8dDLPRa8Ajht/bRwfH30RhwAwmOA4JrjtEDa0pGb5/v5J/Kc6j/qb6V7m6jxnE=@lists.denx.de","X-Gm-Message-State":"AOJu0YwcI19HN9avnfGqWKTVdMVvbhpxG9gxQ8V+VLslwHYez8ub9HOs\n 38m53uVgOd9rhRK1KVYJzl2cLWFR++Weimb8kA7VtxNmbRRlTaLrDTjB/L5rXsQxM9/Npi1Eb1z\n bnrtOWUM4V5vwhLw0wenM2fB3arwOmyFk+qphJb8/","X-Gm-Gg":"AeBDiev+YyljLFJSzX4y/mjqnWehRbuu7Zzq3tHUdTfxpwDwvftFdobvsxZ6DNBA946\n pclHf3KHl0hZ1iuSAd1z1puzx2tSFOxs0qPsR12w5VHGgI/KM/MjIzgVAsH3ih0kv/gDFYFhst6\n 7sy5nsxMtRLjNg6aKgtAKqMgLAnE8a3XItA+m1WVdnZrU4GBwj/HudXzFdm6aqXoLSnFN5Wimca\n 6451TyQP57raVR6vHzMbfeWpmjNp5NAcPT3xOfq1T/xPksyngmbgwLpwycNIWvq7rdErt7lSL8a\n KxMfgA==","X-Received":"by 2002:a17:907:848:b0:b9d:1670:6794 with SMTP id\n a640c23a62f3a-b9d729bc9d5mr401124966b.35.1775939480436; Sat, 11 Apr 2026\n 13:31:20 -0700 (PDT)","MIME-Version":"1.0","References":"<20260408220928.3328551-1-daniel@thingy.jp>\n <20260408220928.3328551-6-daniel@thingy.jp>","In-Reply-To":"<20260408220928.3328551-6-daniel@thingy.jp>","From":"Simon Glass ","Date":"Sat, 11 Apr 2026 14:31:04 -0600","X-Gm-Features":"AQROBzC2IsPxIhXfuRDiZqf2v3hsX0W41g89puNl_wR1txgh8-tCLW3cdGxd4eM","Message-ID":"\n ","Subject":"Re: [PATCH v3 5/5] board: qemu: m68k: Create virtio mmio instances","To":"daniel@thingy.jp","Cc":"visitorckw@gmail.com, angelo@kernel-space.org, bmeng.cn@gmail.com,\n u-boot@lists.denx.de","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}},{"id":3676240,"web_url":"http://patchwork.ozlabs.org/comment/3676240/","msgid":"","list_archive_url":null,"date":"2026-04-12T06:42:28","subject":"Re: [PATCH v3 5/5] board: qemu: m68k: Create virtio mmio instances","submitter":{"id":85408,"url":"http://patchwork.ozlabs.org/api/people/85408/","name":"Daniel Palmer","email":"daniel@thingy.jp"},"content":"Hi Angelo\n\nOn Sun, 12 Apr 2026 at 05:28, Angelo Dureghello wrote:\n> m68k: + qemu-m68k\n> + 422 | sep = memchr(fixup_str, ':', fixup_len);\n> + | ^\n> + 432 | sep = memchr(name, ':', fixup_len);\n> +m68k-linux-ld: cmd/virtio.o: in function `do_virtio':\n> +cmd/virtio.c:42:(.text.do_virtio+0xa6): undefined reference to `blk_common_cmd'\n> +m68k-linux-ld: final link failed: bad value\n> +make[1]: *** [Makefile:2105: u-boot] Error 1\n> +make: *** [Makefile:189: __sub-make] Error 2\n>\n> Looks like a \"select BLK\" is missing.\n\nYeah, I guess whatever config causes the virtio command to be enabled\nshould depend on or select it.\nI'll take a look and add a fix for v4.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=thingy.jp header.i=@thingy.jp header.a=rsa-sha256\n header.s=google header.b=e+og8whB;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=85.214.62.61; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=none (p=none dis=none) header.from=thingy.jp","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=thingy.jp header.i=@thingy.jp header.b=\"e+og8whB\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=none (p=none dis=none) header.from=thingy.jp","phobos.denx.de; spf=pass smtp.mailfrom=daniel@0x0f.com"],"Received":["from phobos.denx.de (phobos.denx.de [85.214.62.61])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4ftgvt6q1Rz1yCx\n\tfor ; Sun, 12 Apr 2026 16:42:50 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id D7924839D5;\n\tSun, 12 Apr 2026 08:42:45 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id 55F6B839D5; Sun, 12 Apr 2026 08:42:45 +0200 (CEST)","from mail-dy1-x132b.google.com (mail-dy1-x132b.google.com\n [IPv6:2607:f8b0:4864:20::132b])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 1CF1A8341A\n for ; Sun, 12 Apr 2026 08:42:41 +0200 (CEST)","by mail-dy1-x132b.google.com with SMTP id\n 5a478bee46e88-2d832f2f44cso386476eec.0\n for ; Sat, 11 Apr 2026 23:42:41 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-1.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=no\n autolearn_force=no version=3.4.2","ARC-Seal":"i=1; a=rsa-sha256; t=1775976160; cv=none;\n d=google.com; s=arc-20240605;\n b=gbit/IZMS4rkQuS0T+YSFlay8ht8LhZYjqF7j36c/aTc4M54x98fXcY/hDNoe6xj0S\n TrSJZETAx7J27ZB7p+ROyKS342wy4GUlaYT+gH7CpU3aYVzHeomzSz45hsrqiHcR/MMc\n pvQVJ0TCUooj9SMm1FbuPYLmxFmi32fPjNg7piQmutptls+rUdAmyMZf6TKyMZ3GOzV0\n TzvHo/U06EZO9NM5kFekLA/poP/Pz4LEbmLYdHGq40ihT6gLfgqRXA/SdgZQQHSSmlGn\n FSu91n8bPnJYlUuk07p0biWHEZh+Gidvgni1FuhnR6bXFqBKJM4Z7eBhuAkWqsjWNKL2\n JcYA==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:dkim-signature;\n bh=inpa90MuOGjyOTviur5osIWaeWS5ypycmjqkDb633iI=;\n fh=NkE7yuAmtwqzxskB4KxGqErm1Ug5krxk3F4BiKXYxAY=;\n b=DDi+8GQKazkQ7YCLmGnfLdCdQWrUJ1+xWu/q6K4707eIzo4LDfDwsos41YJtTV8NPb\n FdMmIqJaUeqhT6jBG+ZmMkjvlFJRwnMrbwxqWAi2+w/YOudj0B17eNOE3jkp9p7BydIo\n Zfq8UTW0gryeZTHE7SmLEtgMqe1xACrLGxkqAKUxxHIZxx1Pw55XW8vshIbUClhA0PN9\n +K5mzfKieQ/v1R+gzNaAmsmp/OYp9SGL+diqjlVZXl+Ijs5TfTCZKqpexElTin4H7HwS\n swz82RuWbn7xqkyLfaVidiPSs/cM3E8SymyqKmfUPMK99oG8HgY4OT///Zp0i+5S447q\n tfGQ==; darn=lists.denx.de","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=thingy.jp; s=google; t=1775976160; x=1776580960; darn=lists.denx.de;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:from:to:cc:subject:date:message-id:reply-to;\n bh=inpa90MuOGjyOTviur5osIWaeWS5ypycmjqkDb633iI=;\n b=e+og8whB/cI+tjWH2XP8APIPpmL6bI+A6QITCsveSS4nlbBE00HGQq7aWbYtKvYf0Z\n vRtkkljezib1yiPG8VE44IqFfkvmHr9lKdQwI8CoVAMoWFRWCE9NNgB9i3/PO3ihSB72\n A6S4g+uSFiu6HfoK4axwdVWYSVY+69uUoZ9ZM=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775976160; x=1776580960;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=inpa90MuOGjyOTviur5osIWaeWS5ypycmjqkDb633iI=;\n b=b4J0K0U8BlaGpzC8q+rXOwSZliPhji75hmCxyOHaaoOq4TtBuvK/4gTNPJbbOs2rE3\n 2irKaXGDelaH0RSQ0hIlYWSvS4+VG1kFIJVB4xdc3Xj2te5aG6G1aj+DY5x4dEiKn+Ey\n oojVgNC5O0Ake6Wh2ochNzMUH0SmOeAt5e68yxZZ87noQlL1Rs3/n5FzOMJU0p7bYFYo\n RCVm9eCxUis1kgDZLPZgPbRXq6aWR8NszpKwnbqgMBPHiKDU9EFslzs/xYZAQT+9acQK\n udQIX2msMYWmKX+wQJkmUCeMYuiFM7/k76iWAeG0SzJNSDUL/Y2+R2S34oZdilr4IeDY\n wMCQ==","X-Forwarded-Encrypted":"i=1;\n AJvYcCXB7EaBUY9HSQxxSm5hR45Z7Z79nMc1EzWX/pwIZQ+4ZBv1RnC2lbR5n4srcw5gXIJpl4oPMIE=@lists.denx.de","X-Gm-Message-State":"AOJu0YwVb9zQd8u2jOsVU9cmcpIBpAgCqMRlRKtD5h1UwiPrftwH4SVc\n DCQNBMvrkOYjLvJ4Okb2PAvy7kq3iCJXpTP268QBdQxh7/cLBeWcbob7ypnA9AvhVTPhUQRB2Sl\n S33YlfQJW6Bq3lfLndIADf2O4IneB28pM808xhnKmxw==","X-Gm-Gg":"AeBDieuGws/1EJ8fWP3Ge+7TqetQ54oKkoIJe8YbPdKq5kb9NWM0rw3d4mmpbTb+xAT\n mmoHUWxcS/MNkhvrV2gxBG1glnz+6lNEC1KbGSaDUMq4YyhV17ZCZ9kzlL7Z7hZ6S/eJkx/S1eG\n hsrGcyYHdk1fBq4o6t5QTU9uoRRo7fd6gee1iz+b4d1aBbRkrMxdsZa8QIPjb3+3NDLxtYxJXTN\n iUVpxQyhPRjztfxTBhgy2p7XeoWwLz+T6J8Kootu6gWaDNo/t0XhpFO+34boN4gshWI6vZRb5GQ\n AKo2VPgbR4uin3E=","X-Received":"by 2002:a05:7022:ec07:b0:128:d3de:c9e4 with SMTP id\n a92af1059eb24-12c34ef7f15mr5109554c88.30.1775976159957; Sat, 11 Apr 2026\n 23:42:39 -0700 (PDT)","MIME-Version":"1.0","References":"<20260408220928.3328551-1-daniel@thingy.jp>\n <20260408220928.3328551-6-daniel@thingy.jp>\n <358e3185-1a42-4786-9c37-fe7ac41054e6@kernel-space.org>","In-Reply-To":"<358e3185-1a42-4786-9c37-fe7ac41054e6@kernel-space.org>","From":"Daniel Palmer ","Date":"Sun, 12 Apr 2026 15:42:28 +0900","X-Gm-Features":"AQROBzBruwH-Wndq8AXvZQr74HcaraNYTO-ew8p-MXYGNyZYxcpJLrMaBHUs40g","Message-ID":"\n ","Subject":"Re: [PATCH v3 5/5] board: qemu: m68k: Create virtio mmio instances","To":"Angelo Dureghello ","Cc":"visitorckw@gmail.com, bmeng.cn@gmail.com, u-boot@lists.denx.de","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}}]