[{"id":3676203,"web_url":"http://patchwork.ozlabs.org/comment/3676203/","msgid":"","list_archive_url":null,"date":"2026-04-11T20:30:54","subject":"Re: [PATCH v3 4/5] virtio: blk: Fix converting the vendor id to a\n string","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"Hi Daniel,\n\nOn 2026-04-08T22:09:23, Daniel Palmer wrote:\n> virtio: blk: Fix converting the vendor id to a string\n>\n> Currently we are trying to work out if the vendor id is from\n> a virtio-mmio device and then casting a u32 to a char* and using\n> it as a C-string. By chance there is usually a zero after the u32\n> and it works.\n>\n> Since the vendor id we are trying to convert to a string is QEMU's\n> just define a value for the QEMU vendor id, check if the vendor\n> id matches and then use a predefined string for \"QEMU\".\n>\n> I don't think we should have been assumming all virtio-mmio vendor\n> ids are printable ASCII chars in the first place so do this special\n> casing just for QEMU. If the vendor id isn't QEMU print the hex\n> value of it.\n>\n> Signed-off-by: Daniel Palmer \n>\n> drivers/virtio/virtio_blk.c | 12 +++++-------\n> include/virtio_mmio.h | 2 ++\n> 2 files changed, 7 insertions(+), 7 deletions(-)\n\n> diff --git a/include/virtio_mmio.h b/include/virtio_mmio.h\n> @@ -5,6 +5,8 @@\n> +#define VIRTIO_MMIO_VENDOR_QEMU 0x554d4551\n\nThis vendor ID applies to all virtio transports, not just virtio-mmio,\ne.g. virtio_blk.c must include virtio_mmio.h even when built for\nplatforms that only have virtio-pci\n\nPlease can you move this to include/virtio.h instead? Something like\nVIRTIO_VENDOR_QEMU would be more appropriate.\n\nWith that:\nReviewed-by: Simon Glass \n\nRegards,\nSimon","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256\n header.s=google header.b=Y/EAroaa;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=85.214.62.61; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org\n header.b=\"Y/EAroaa\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=sjg@chromium.org"],"Received":["from phobos.denx.de (phobos.denx.de [85.214.62.61])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4ftQLF3nNPz1yCv\n\tfor ; Sun, 12 Apr 2026 06:31:17 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id B107E84154;\n\tSat, 11 Apr 2026 22:31:14 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id 132C384118; Sat, 11 Apr 2026 22:31:13 +0200 (CEST)","from mail-ej1-x62a.google.com (mail-ej1-x62a.google.com\n [IPv6:2a00:1450:4864:20::62a])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 56D4A84181\n for ; Sat, 11 Apr 2026 22:31:09 +0200 (CEST)","by mail-ej1-x62a.google.com with SMTP id\n a640c23a62f3a-b9382e59c0eso561772066b.0\n for ; Sat, 11 Apr 2026 13:31:09 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2","ARC-Seal":"i=1; a=rsa-sha256; t=1775939469; cv=none;\n d=google.com; s=arc-20240605;\n b=IS4CPFFOMIvKo87hcenWvwNf5Dft/RYkC+qMya7sexYhx4EoTSaNBKXp+lMuH9m+JZ\n A7VqJE1Al/7M5mG82rLG/VkRGUaX8u4eZ/BkBoxKcbIAM2cSFvnGdD1F+43uh9eMIsJr\n 08kyP4ZTwuwJ4+UKxFKlxzCc4yW9FNp7yoC6NuApk3y9WbMkCEakwg5rIo/ncnrCh1fd\n 1kc0TajZspoikPU95Q1RXaGnxb6TWTyp7KZb0dZQlOEeFTZdAQQXdtbh2ZKH6OqFnGRT\n +4p39+qjfgByOhEKn3Hll5ctDjdntJl155YHTkxm5QrFQOWVGCg9ZcJnApwCfn8hmeMR\n /HoQ==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:dkim-signature;\n bh=TQK6A2m1Ng85AjXyt1S6hx5mynGKOnm4ca1A91EQN80=;\n fh=DNnc0PxDvDAOtN2DNlU78zUxlw1DS1Be5zZEFqtZAt8=;\n b=aFlnn/D+WuRoR8LwUbuB+gtnH6iT3RxINuOifn7+mqo7cPrvUwSFNUu+20CznEY4z1\n elq0oRKMbp0UoyBuMYpjwYDl7pX8dt8ajSssRsedjiZNiP2S7XVFQBKcdG6P4xKqnFuv\n LG7yZ7h1YuK5hnOV6tH12isVuO+7ILCdIU7Vc8GjfQo1oZBYX4oqUaz1XuvkK4FP70JO\n o4PaUoHZaGNO4XE82NjI5QgzTfcGfpIXlX4X49bU/EYa9IybLUoVAgGn+dZwYHsC4wUp\n 7aogzicv2ZKf3igs8D5gRHU8RXcICAZNljgYRtrB6JR9hMZqKLx+Tz3kv56aBCodiHJs\n 8/GA==; darn=lists.denx.de","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=chromium.org; s=google; t=1775939469; x=1776544269; darn=lists.denx.de;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:from:to:cc:subject:date:message-id:reply-to;\n bh=TQK6A2m1Ng85AjXyt1S6hx5mynGKOnm4ca1A91EQN80=;\n b=Y/EAroaakxnK+OoIq4X2VTHJ7yN9LASOCoUQ5q5FJnZEQDn5zgqovQq5gkVuSffjup\n 3/8r7BgUv8XPgN3sIUSt7lUqH2I38svIiENz4LsJKlQd3HU6eysEARu8xw+TuW2L3nqq\n wAGKALsu/qgvOXTyqGsbKmAeynAU6PSMZYsb8=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775939469; x=1776544269;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=TQK6A2m1Ng85AjXyt1S6hx5mynGKOnm4ca1A91EQN80=;\n b=kGtd8wVOcBu2YDU6xhYiEKR1RgvverniT0qKguK03scZb46POxmD53ktruwU1h1uvQ\n 25X7ODpsk3cf26ciDb2b8oVP0At8nFM3Y7EdzCAX3Tis6uPaBvMUr+HUZZecv3fu1Sk0\n 5oBtZHaRR4nEt7sxBtAFnma8sX1pqx7JCPvYiHEX5szHmsYlCAWzY8RV+t7RItOPFqa6\n JK8zEtuZazvcnciaGHew8Abol21uqy4msGK/kB+eQ/hwTut4fPiHNqqlo8syuofsscS1\n 3e3XvqNeMhD4LIAcEhP1lHVa0xJ9ItiqOHmTU7TCmvjFNmHchK88uIKQfy54d4BuCIFc\n hPDw==","X-Forwarded-Encrypted":"i=1;\n AJvYcCWPG9EksKi59BkGGu0HFBlf9GyV9iiEbvP3Xu8IYHkEyhZQOLjc9SixCiR9WevuPZxET8sFqZk=@lists.denx.de","X-Gm-Message-State":"AOJu0Yw3wjkESNghzeE7DFEV5mCYau0578Xf3EmEHdPRgT3UHzF/dXlT\n 3n/0/feb1xdJBh3prgUVi0aKRfoUcnZR5XcHPDGwk74mjLmJk+SdIF2fWVYHiaeLE9LbL78N2VW\n u0zxBaRJBHvmg+BQQLzqox/eSt90vDAxesISZ9/yw","X-Gm-Gg":"AeBDiesPv0BmiP1Fn0IG29E/J2n+VIUiO8hiwtE0qdhZ/aFF1V9YoqEUf9X0RGXM5Ky\n RXajUYZkGUy8v3p9tJllLsc8MGGcr7b/mnnrtAt+Vgu9Xv80hgyHmBVRPNnK8JooeY8ksqpRr4n\n 2NkZUy7LjwPN0Z+vNZqLxs+MaFcGCPGazRgJiBb46VsEq5jHuniTn8U8XEQ1bt4paG8IMU3nfF7\n ZOc1DJ9YDaHCyxL5l52an4T8h4IVVUyVMSWu7SFrE04kxqk3rBtIEqYAW0Du0XCK+ZEMnni2P/i\n CCv01Q==","X-Received":"by 2002:a17:906:7947:b0:b9c:30b7:770f with SMTP id\n a640c23a62f3a-b9d7265d35emr490450566b.34.1775939468704; Sat, 11 Apr 2026\n 13:31:08 -0700 (PDT)","MIME-Version":"1.0","References":"<20260408220928.3328551-1-daniel@thingy.jp>\n <20260408220928.3328551-5-daniel@thingy.jp>","In-Reply-To":"<20260408220928.3328551-5-daniel@thingy.jp>","From":"Simon Glass ","Date":"Sat, 11 Apr 2026 14:30:54 -0600","X-Gm-Features":"AQROBzC16FWlOcijl06vs9Tn4NvfJJtKklXvXQFdtY9uS71DpAunCDC1cm32JfE","Message-ID":"\n ","Subject":"Re: [PATCH v3 4/5] virtio: blk: Fix converting the vendor id to a\n string","To":"daniel@thingy.jp","Cc":"visitorckw@gmail.com, angelo@kernel-space.org, bmeng.cn@gmail.com,\n u-boot@lists.denx.de","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}},{"id":3676388,"web_url":"http://patchwork.ozlabs.org/comment/3676388/","msgid":"","list_archive_url":null,"date":"2026-04-12T21:34:34","subject":"Re: [PATCH v3 4/5] virtio: blk: Fix converting the vendor id to a\n string","submitter":{"id":87364,"url":"http://patchwork.ozlabs.org/api/people/87364/","name":"Kuan-Wei Chiu","email":"visitorckw@gmail.com"},"content":"Hi Daniel,\n\nOn Thu, Apr 09, 2026 at 07:09:27AM +0900, Daniel Palmer wrote:\n> Currently we are trying to work out if the vendor id is from\n> a virtio-mmio device and then casting a u32 to a char* and using\n> it as a C-string. By chance there is usually a zero after the u32\n> and it works.\n> \n> Since the vendor id we are trying to convert to a string is QEMU's\n> just define a value for the QEMU vendor id, check if the vendor\n> id matches and then use a predefined string for \"QEMU\".\n> \n> I don't think we should have been assumming all virtio-mmio vendor\n> ids are printable ASCII chars in the first place so do this special\n> casing just for QEMU. If the vendor id isn't QEMU print the hex\n> value of it.\n> \n> Signed-off-by: Daniel Palmer \n> ---\n> drivers/virtio/virtio_blk.c | 12 +++++-------\n> include/virtio_mmio.h | 2 ++\n> 2 files changed, 7 insertions(+), 7 deletions(-)\n> \n> diff --git a/drivers/virtio/virtio_blk.c b/drivers/virtio/virtio_blk.c\n> index 3dd0cf36268b..d876c40deb05 100644\n> --- a/drivers/virtio/virtio_blk.c\n> +++ b/drivers/virtio/virtio_blk.c\n> @@ -11,6 +11,7 @@\n> #include \n> #include \n> #include \n> +#include \n> #include \n> #include \n> #include \"virtio_blk.h\"\n> @@ -164,14 +165,11 @@ static int virtio_blk_bind(struct udevice *dev)\n> \t\treturn devnum;\n> \tdesc->devnum = devnum;\n> \tdesc->part_type = PART_TYPE_UNKNOWN;\n> -\t/*\n> -\t * virtio mmio transport supplies string identification for us,\n> -\t * while pci trnasport uses a 2-byte subvendor value.\n> -\t */\n> -\tif (uc_priv->vendor >> 16)\n> -\t\tsprintf(desc->vendor, \"%s\", (char *)&uc_priv->vendor);\n> +\n> +\tif (uc_priv->vendor == VIRTIO_MMIO_VENDOR_QEMU)\n> +\t\tstrcpy(desc->vendor, \"QEMU\");\n\nIs there a chance that other non qemu virtio-mmio devices also use a\n4 character string for their vendor ID? If so, this patch will regress\ntheir output from a human-readable string to a raw hex value.\n\nRegards,\nKuan-Wei\n\n> \telse\n> -\t\tsprintf(desc->vendor, \"%04x\", uc_priv->vendor);\n> +\t\tsprintf(desc->vendor, \"%08x\", uc_priv->vendor);\n> \tdesc->bdev = dev;\n> \n> \t/* Indicate what driver features we support */\n> diff --git a/include/virtio_mmio.h b/include/virtio_mmio.h\n> index 8c072826db55..cc59bc516c2c 100644\n> --- a/include/virtio_mmio.h\n> +++ b/include/virtio_mmio.h\n> @@ -5,6 +5,8 @@\n> \n> #include \n> \n> +#define VIRTIO_MMIO_VENDOR_QEMU\t0x554d4551\n> +\n> struct virtio_mmio_plat {\n> \tphys_addr_t base;\n> };\n> -- \n> 2.51.0\n>","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=ZT1DuA1N;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=gmail.com","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.b=\"ZT1DuA1N\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=gmail.com","phobos.denx.de;\n spf=pass smtp.mailfrom=visitorckw@gmail.com"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fv3jB6KzBz1xtJ\n\tfor ; Mon, 13 Apr 2026 07:34:54 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 29E62839D5;\n\tSun, 12 Apr 2026 23:34:44 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id 98DCE83B99; Sun, 12 Apr 2026 23:34:42 +0200 (CEST)","from mail-pl1-x629.google.com (mail-pl1-x629.google.com\n [IPv6:2607:f8b0:4864:20::629])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 484CA80077\n for ; Sun, 12 Apr 2026 23:34:40 +0200 (CEST)","by mail-pl1-x629.google.com with SMTP id\n d9443c01a7336-2aae4816912so25087625ad.2\n for ; Sun, 12 Apr 2026 14:34:40 -0700 (PDT)","from google.com ([2402:7500:477:c367:3a21:b5ec:1429:fbe])\n by smtp.gmail.com with ESMTPSA id\n d9443c01a7336-2b2d843c5c2sm86024805ad.12.2026.04.12.14.34.36\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Sun, 12 Apr 2026 14:34:37 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-1.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_GMAIL_RCVD,FREEMAIL_FROM,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=no\n autolearn_force=no version=3.4.2","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1776029679; x=1776634479; darn=lists.denx.de;\n h=in-reply-to:content-disposition:mime-version:references:message-id\n :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to;\n bh=WBsG5W3S/FeZBb2k6xNUHGcbyCkAkyzQFqQ2ocMVLKk=;\n b=ZT1DuA1N+ReOkVnl0RiX1Fw9EW5zfiJqUOoZrVy6tkvVrlyIetZy2EKOjbQ4OSfc++\n CqD4i1GVDdYYciDTMH/tjHzIHmpNDT28yAtFiwYVLx0n5nVd77deJEUjzjFLDVjOXI+g\n oHwRv+tiYVWWsiPLaDRG+DrWOjtjetqwndyTNS6r9T5mZ29vkcuAHpaa73AGilNEUMrj\n hUwhSbrVdv7OlNJH4Zh00ugItavws+f6kg/z0MyuAMwr9RXcEbrh1+fLC9cyKsiHuGj9\n LWUa7qYku93f8xb28FbS9N9yD4cJtDFOIxfi1BWQ3NTD0dnR/C/ZFXUC5jHtVLwi3ue4\n nwyw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776029679; x=1776634479;\n h=in-reply-to:content-disposition:mime-version:references:message-id\n :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=WBsG5W3S/FeZBb2k6xNUHGcbyCkAkyzQFqQ2ocMVLKk=;\n b=sj5zYk8P38JjihOGOZG3osjNeHRyO3cdlWubHvcl4Z/XmFeOj5q6T2oMvdQw8WAaeK\n Q/zHZhwVCjANUrhCMtvo1c4t2q0mU1CZ7vl8/Clvo8DC5a9PuM/ZnHAaseuISSGiNwdW\n tDMNN2DtkN6xlzEmuCu/9LlGhOD43rWX7wktkbxpngeAg8ruxFBclM6LOz+fKxcanx3R\n Ftu8ho5fTLgUXs+lyIDM0ItFPrcfOVPP3Gc8ESNZ9a2Mh8KSYIMv+1lznGiJfboMCNLc\n RtrjK69zKAjv6eFLFs4ygvnQi2Gn1GZqD85oATqhX1qfy+FXgCjcOIpt87x46K7ozgnW\n j3hQ==","X-Forwarded-Encrypted":"i=1;\n AFNElJ9ryl8LhfGVhOPQ8piZL82G4Jqsmu9BrBh9HXRDTGcr1lnIdXa7wH54bnLZqLSDfHyeanBESVk=@lists.denx.de","X-Gm-Message-State":"AOJu0YxP4LIdotPsDuNZSwI3PAyatFQfFO2fx02JQoDig/soJXcFmwQU\n OZhDa1pdZRVTaA+MftB2s9yFct5dp32IOaLgq57La4/x1/vWAPaZg6Mz","X-Gm-Gg":"AeBDiet/tfMyZHwzhfjUSzskb3gPqfoY33AyadU26vbR7jtAxVh+Es/MXZ43LLiKz4I\n +Ap50Xb83BPiDUBJwywWCeqLCgCps6aYBN2Q/Q62xdGnmmGknBPbZ979s7oGoWxkoHblPW+Ao6J\n yEkA6o3LfcNC/ERSRZwZToJTv1oFa0+di7bZeansiq3EOlWcR0hpUpkvQmfJESrGS1szGq35jUJ\n PnqKJPB+afnIJYCljIuVm2JwP5+FGzsB6vosCKb4JHChYkKe+6t9ZAWgEOWEb/xcHx32pi7qXKW\n DvOefWRanR8UHldgga1mdJgR9tevvhxwwSQ48AWjh9FbgHEj0aUFYL9BJ2GS7pt5ivO6eICt4bX\n YeFccgUfZCpqx8BNKC8n9N0K/ZZv9VaUJGnhfiZKMxFFk3vwScv+PnkZualLqSfx+ujUCPfarKK\n ExyhVkPdWNXT0yqBgtUU3ham7cZO7/j1y8kkY=","X-Received":"by 2002:a17:903:2285:b0:2b0:b1e7:8841 with SMTP id\n d9443c01a7336-2b2d5a49b1emr112880415ad.32.1776029678548;\n Sun, 12 Apr 2026 14:34:38 -0700 (PDT)","Date":"Mon, 13 Apr 2026 05:34:34 +0800","From":"Kuan-Wei Chiu ","To":"Daniel Palmer ","Cc":"angelo@kernel-space.org, bmeng.cn@gmail.com, u-boot@lists.denx.de","Subject":"Re: [PATCH v3 4/5] virtio: blk: Fix converting the vendor id to a\n string","Message-ID":"","References":"<20260408220928.3328551-1-daniel@thingy.jp>\n <20260408220928.3328551-5-daniel@thingy.jp>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20260408220928.3328551-5-daniel@thingy.jp>","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}},{"id":3676389,"web_url":"http://patchwork.ozlabs.org/comment/3676389/","msgid":"","list_archive_url":null,"date":"2026-04-12T21:47:37","subject":"Re: [PATCH v3 4/5] virtio: blk: Fix converting the vendor id to a\n string","submitter":{"id":85408,"url":"http://patchwork.ozlabs.org/api/people/85408/","name":"Daniel Palmer","email":"daniel@thingy.jp"},"content":"Hi Kuan-Wei,\n\nOn Mon, 13 Apr 2026 at 06:34, Kuan-Wei Chiu wrote:\n> Is there a chance that other non qemu virtio-mmio devices also use a\n> 4 character string for their vendor ID? If so, this patch will regress\n> their output from a human-readable string to a raw hex value.\n\nThere might be other implementations of virtio but probably not used\ntogether with u-boot.\nI think this goes the other way too, we are assuming the ids are\nprintable ascii chars and it's possible to have an id that isn't.\nWhat is currently happening looks like luck and seems unsafe to me so\nI think regressing to printing hex is better.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=thingy.jp header.i=@thingy.jp header.a=rsa-sha256\n header.s=google header.b=A+vmdugU;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=85.214.62.61; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=none (p=none dis=none) header.from=thingy.jp","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=thingy.jp header.i=@thingy.jp header.b=\"A+vmdugU\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=none (p=none dis=none) header.from=thingy.jp","phobos.denx.de; spf=pass smtp.mailfrom=daniel@0x0f.com"],"Received":["from phobos.denx.de (phobos.denx.de [85.214.62.61])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fv40K0zNcz1xtJ\n\tfor ; Mon, 13 Apr 2026 07:48:01 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id AFE7683B99;\n\tSun, 12 Apr 2026 23:47:56 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id 5449883BC4; Sun, 12 Apr 2026 23:47:56 +0200 (CEST)","from mail-yw1-x1136.google.com (mail-yw1-x1136.google.com\n [IPv6:2607:f8b0:4864:20::1136])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 038EF839D5\n for ; Sun, 12 Apr 2026 23:47:52 +0200 (CEST)","by mail-yw1-x1136.google.com with SMTP id\n 00721157ae682-79a535e7c00so43051967b3.3\n for ; Sun, 12 Apr 2026 14:47:52 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-1.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=no\n autolearn_force=no version=3.4.2","ARC-Seal":"i=1; a=rsa-sha256; t=1776030471; cv=none;\n d=google.com; s=arc-20240605;\n b=KokKyOCR2rZo1XoWawio8wGC0Hll6bukUKaWh15qifeoN7dqR+Lr6olr5IcQm7zR2G\n IcLl4S2Y1AEVtalnkLSFKS9NY13E4H17Yv1AOEzYHokiAlUrZ+hwOFH64qd3o1b615ct\n LqiqVri6vVIztBgznokz/DjQvrzJqQwIvtAZwdUYAFQSOXcjmWGKWXx3jF6kqbMUJPKw\n ttWFhyBAEgepTRA8yVM8zaa53P9JTpuWZAQaQTO3nCDVnFekQsPSIzAbQv5wKeisKilW\n SMP64r/MAdl5T+Kn0Rerb/SeBkR3YKjSsKTqYnzRTuar8Y1GnTV1gLT2K0PrmqlzxlNS\n t+HQ==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:dkim-signature;\n bh=R3zMBYUHqDpFaKl+tjEGHQenNirmU7FpD3trzZgcW9o=;\n fh=0Oc5kyYjVCmya2mmcsaGUFu9KBl763qOyu40EeTAIFg=;\n b=KhpAJEUroCM5oZU4WCRkp3n4Lg6wtkqiRfSoab5cB+SzI9WsOWZ6JK9GAVMsebnAbq\n h2fUrcllXVj35OggGbQbx07sYCNI6jq+bcmZBnWv5IO7KQ4NCD0YKWYLJw/YPgQUqgWb\n I+B99GaLLEUXNyXVsozAoLRK3I5pyGHpsaRn7CwxxU99EJqc2zLFQaCZ12EA0vMnnFSY\n kas+6qrmNtZ7oJ74c7n4OkODM/hzsWECxKqB02cZFxAp7LM9KJ3O9GhfHftz82MfYCkD\n HWg5ZK8T3Bzi8Qs7x2uGE43cmjX1LxH9PEvQWvJkUMnDXYDyKJmPs5CzyVv9gA7rBJ6u\n 3wfg==; darn=lists.denx.de","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=thingy.jp; s=google; t=1776030471; x=1776635271; darn=lists.denx.de;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:from:to:cc:subject:date:message-id:reply-to;\n bh=R3zMBYUHqDpFaKl+tjEGHQenNirmU7FpD3trzZgcW9o=;\n b=A+vmdugUBIqwHfBjsFZW8IM9biZeWAGMbvKMp0oPpSwPuX6dkple8YfRpTwH/BAlmi\n E05dpAabGOjvjbscl0Z4mUQ9mCGjY9OadLKL5VqJXYLkMRw1UavFemdlRvBeDGZmZ7rU\n FxAKizRhvyQ1y22cT1SYAiYTx2/Jy0tOT7JmM=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776030471; x=1776635271;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=R3zMBYUHqDpFaKl+tjEGHQenNirmU7FpD3trzZgcW9o=;\n b=ClL+0LGTFRvPcibzepva0VJPj3Za99CixLfCHNHYgvt/ioEAjmw1iatCrTA+/Hcsfg\n sDzBNR4JdoWvxQ9e9ZWN+kKvBTXVEAMfJ3eAMEtky39O3WRrsgB28BkJftubeVXzTTQs\n RB3j1TnSe58LhkEzX7Q1W+LE4heKNp84hdClHIgZ6V74krCNyhewLIgpggEP9F00rw2D\n qpdn7Ar3ly8w1NYBBbnoQ8oTSt7ajstoxM1NxgWDzbrYTpwOJ8ue64BKGCl49J0//2vR\n EURjDvydzNzZzJQCuu9/3xUAeT78Gcrzi+6NcZb/v1so0a9HQEoQFLpK3kR9V+ZjD8Ux\n VTNw==","X-Forwarded-Encrypted":"i=1;\n AFNElJ+CKQdZZyvgnLNhdyERvQdnRGafg5uU/Iw7+07JnbV8fUX7jKCumsoADltdmvtmlD810ndBTxU=@lists.denx.de","X-Gm-Message-State":"AOJu0YywkrBXbTKT0p+url+fS0Uv00BpyzBbt7D6EqA1NHWgOYGTIA1M\n rKnV7hIQ6yE1QeDuYzExUn0wKX0l6nsGb7FdR8FKY9vkpzV7OyDA/bu7pGOiW/Sp9oVwXa/8slC\n ihXvucyisRr5ZMJ3FX90ygOsQ7ib/jPy9w60TcbRGLg==","X-Gm-Gg":"AeBDietdBbBfrh5BDWBOQy++EIe/MFNqW+UqL2qjEodr8onWu//ob+mPn0N56olVmgc\n WVeYHOklQIxE0XdiaCn11RFnRPKOs8Hzm0Zsj4seUb9oPAoCMw/GtXJEHaZ1qz4yo5rut6oDUA4\n T6q4yXmRSqtBksjhu4a3PquHXl7vomTOq8kUNr1dKyFZWvKIBiQS0uMMct9zcES2tb3B4Lj5VXk\n k5QCRD2WI9yKfY4XbtiRxO5ww1icPihypferqyqfFgQZo4DzlGSSZEhrjRPimBjNZmxohDxErWz\n JXGx9EorW9fb5fFc9MyRv9c3ZwifBjc4F1lFergwCFVscS51qHE=","X-Received":"by 2002:a05:690c:498f:b0:7b1:e942:bddb with SMTP id\n 00721157ae682-7b1e942c63bmr49833417b3.13.1776030471414; Sun, 12 Apr 2026\n 14:47:51 -0700 (PDT)","MIME-Version":"1.0","References":"<20260408220928.3328551-1-daniel@thingy.jp>\n <20260408220928.3328551-5-daniel@thingy.jp>\n ","In-Reply-To":"","From":"Daniel Palmer ","Date":"Mon, 13 Apr 2026 06:47:37 +0900","X-Gm-Features":"AQROBzAPrRUGjGRlE67z8nm-YnLb2x3bOnlQ4EYI_6Efdt3bt3Lw8yAjw4FG36k","Message-ID":"\n ","Subject":"Re: [PATCH v3 4/5] virtio: blk: Fix converting the vendor id to a\n string","To":"Kuan-Wei Chiu ","Cc":"angelo@kernel-space.org, bmeng.cn@gmail.com, u-boot@lists.denx.de","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}},{"id":3676390,"web_url":"http://patchwork.ozlabs.org/comment/3676390/","msgid":"","list_archive_url":null,"date":"2026-04-12T22:00:17","subject":"Re: [PATCH v3 4/5] virtio: blk: Fix converting the vendor id to a\n string","submitter":{"id":87364,"url":"http://patchwork.ozlabs.org/api/people/87364/","name":"Kuan-Wei Chiu","email":"visitorckw@gmail.com"},"content":"Hi Daniel,\n\nOn Mon, Apr 13, 2026 at 06:47:37AM +0900, Daniel Palmer wrote:\n> Hi Kuan-Wei,\n> \n> On Mon, 13 Apr 2026 at 06:34, Kuan-Wei Chiu wrote:\n> > Is there a chance that other non qemu virtio-mmio devices also use a\n> > 4 character string for their vendor ID? If so, this patch will regress\n> > their output from a human-readable string to a raw hex value.\n> \n> There might be other implementations of virtio but probably not used\n> together with u-boot.\n> I think this goes the other way too, we are assuming the ids are\n> printable ascii chars and it's possible to have an id that isn't.\n> What is currently happening looks like luck and seems unsafe to me so\n> I think regressing to printing hex is better.\n\nI just took a quick look through the virtio spec, and indeed it never\nmentions that the mmio vendor id should be a string.\n\nGiven this, should we even treat qemu as a special case here?\nPerhaps the simplest and most spec-compliant approach is to never\nassume it's a string, and just uniformly print the hex value for all\ndevices. What do you think?\n\nRegards,\nKuan-Wei","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=N2wxLAvU;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=gmail.com","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.b=\"N2wxLAvU\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=gmail.com","phobos.denx.de;\n spf=pass smtp.mailfrom=visitorckw@gmail.com"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fv4Gn3FS5z1xtJ\n\tfor ; Mon, 13 Apr 2026 08:00:33 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 1948983B99;\n\tMon, 13 Apr 2026 00:00:30 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id 71BC983EC6; Mon, 13 Apr 2026 00:00:29 +0200 (CEST)","from mail-pj1-x1034.google.com (mail-pj1-x1034.google.com\n [IPv6:2607:f8b0:4864:20::1034])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 4371D839D5\n for ; Mon, 13 Apr 2026 00:00:27 +0200 (CEST)","by mail-pj1-x1034.google.com with SMTP id\n 98e67ed59e1d1-35fb16e56efso364373a91.2\n for ; Sun, 12 Apr 2026 15:00:27 -0700 (PDT)","from google.com ([2402:7500:477:c367:3a21:b5ec:1429:fbe])\n by smtp.gmail.com with ESMTPSA id\n 98e67ed59e1d1-35e5a218959sm1167648a91.2.2026.04.12.15.00.19\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Sun, 12 Apr 2026 15:00:21 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-1.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_GMAIL_RCVD,FREEMAIL_FROM,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=no\n autolearn_force=no version=3.4.2","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1776031226; x=1776636026; darn=lists.denx.de;\n h=in-reply-to:content-disposition:mime-version:references:message-id\n :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to;\n bh=ir9+1D6sdH9XXHUjnwBZQA3nWGX6pOPIHT4P9Y832Xk=;\n b=N2wxLAvUdWX5DeADbA08m4Iw86cBWDh4PpXaTf24H7DqegnoGvhXfU7u8u6TA0pS3b\n 2C5Eduqr6M01/KmbDpRVbGWbrf7v112Dqm91Om91IYXPnvlUM6RxTdQD001XPViuu4CD\n 3d9BNH2yWnLskDuZoMk/CYNW9GM3KdexSjyZdAamkIZuhU3yUXVGtUDW+2dO4PVKiosy\n V51rIHSvDPSsB2W0v7o+TR0jRoQ9VvbQH8Yi3N5j6S8qsCU0d8+jpmNGFkRJjxo81b8D\n Al/218OkDtERFP6TNDmcRVcGrv04v63QWQv0hPZQvxtN7I2DoB5kGq6vW6TcHtq+P8w5\n cjhA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776031226; x=1776636026;\n h=in-reply-to:content-disposition:mime-version:references:message-id\n :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=ir9+1D6sdH9XXHUjnwBZQA3nWGX6pOPIHT4P9Y832Xk=;\n b=nFwoHCv8AVWkynolh7VsjE3Hj0b+bz90ERZ4cM7I4tUnTdYoku31qyG21fcz+by8sH\n 0bxhR+2+R2obLcOJBvCmGwNlKVb6BAp03FhRHcJKoX8KeIGqiVSyiOFRPiGi2Tz75eEx\n IptI/1nHB9/bSWLONzKvvDan5xKNUhi+UdYaXRQTFBLTyDokDV+6KPIz8jGFYHIKMEY6\n 3ni/YYf3AOUYB+t/txjTWGqXEiwBNsDZguQXF9dYVIGF4xwBH7oheCvclQc1cwsl91qB\n Ji9rEhhKDAVi6LnggN/89dSF0HuFVNnN57zIGsjGdCgzcEobtGC/ah3vBnw/Yk4hLgM0\n 8MHQ==","X-Forwarded-Encrypted":"i=1;\n AFNElJ91/rcc1ECT/LM+Hj7SDgjq7HeBjwzyeGhmowkdpO9UcApR65TVCBDhkgfyKhZ4QbvRz0pO4wg=@lists.denx.de","X-Gm-Message-State":"AOJu0YyeyOPnOjfAaianf4zLSkKExUoc+/k6/nBA77TDawiwllQtNA+r\n WgOWwo3aGRRGEPqFVueHsNkkGHIZzB5pOOHSZTmzDqHuHGrDdyVxabCA","X-Gm-Gg":"AeBDiev+xBG598OASj8/lw9Y0fkOccEmpvXwdTWD+swdOLk92WIz3axAEPu9eT8eWwi\n TY9TR+TuJ3EQoOU6TlwPoXZLEseFiYr8FvyS7wFcS6/0cFojTyk7/TrReHOu01rtMi6BVQHS6UC\n 2H16m8AGkqT+VY1mz/wEzM4a5TttjKTK3DMS1ewst57hd43d+kysnVJxv8o8wlWi0qQnppBxCQ8\n kmbojQgQ7MB1yAXHK/p/viJJoTBnW+QdN1B0tNFamDGTxk6IzYHjkNN5TTqQ93PsRyY3oUApcv4\n qC5aL0uOXVRdxOAe/yByPPwme6OYrUPf2hwbSdVJoq0YRiYBOkrEVglVAP6yWZzH+dGdSfTSdnF\n e+NpU60KIcxS1KkZNa8RqpzwNjRHpRY2CCUYOeZ1VgBj/GNoaqHtRy4/pcNTxJYVc73U9ZjtS0i\n gFTbXeCeoNMWcyHH8v1ikzQlz+LE7Gx54uTlJ4MA/R9uo4iA==","X-Received":"by 2002:a17:90a:e7cf:b0:34c:fe57:2793 with SMTP id\n 98e67ed59e1d1-35e42881e54mr11039297a91.20.1776031221827;\n Sun, 12 Apr 2026 15:00:21 -0700 (PDT)","Date":"Mon, 13 Apr 2026 06:00:17 +0800","From":"Kuan-Wei Chiu ","To":"Daniel Palmer ","Cc":"angelo@kernel-space.org, bmeng.cn@gmail.com, u-boot@lists.denx.de","Subject":"Re: [PATCH v3 4/5] virtio: blk: Fix converting the vendor id to a\n string","Message-ID":"","References":"<20260408220928.3328551-1-daniel@thingy.jp>\n <20260408220928.3328551-5-daniel@thingy.jp>\n \n ","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"\n ","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}},{"id":3676391,"web_url":"http://patchwork.ozlabs.org/comment/3676391/","msgid":"","list_archive_url":null,"date":"2026-04-12T22:05:22","subject":"Re: [PATCH v3 4/5] virtio: blk: Fix converting the vendor id to a\n string","submitter":{"id":85408,"url":"http://patchwork.ozlabs.org/api/people/85408/","name":"Daniel Palmer","email":"daniel@thingy.jp"},"content":"Hi Kuan-Wei,\n\nOn Mon, 13 Apr 2026 at 07:00, Kuan-Wei Chiu wrote:\n> I just took a quick look through the virtio spec, and indeed it never\n> mentions that the mmio vendor id should be a string.\n>\n> Given this, should we even treat qemu as a special case here?\n> Perhaps the simplest and most spec-compliant approach is to never\n> assume it's a string, and just uniformly print the hex value for all\n> devices. What do you think?\n\nI think printing a pretty vendor name makes sense and since it's\nbasically just QEMU right now the little special case for it isn't too\nbad.\nI think not confusing people by showing them a bunch of hex where they\nare used to seeing QEMU is also worthwhile.\n\nThanks,\n\nDaniel","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=thingy.jp header.i=@thingy.jp header.a=rsa-sha256\n header.s=google header.b=WYaf4QRn;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=none (p=none dis=none) header.from=thingy.jp","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=thingy.jp header.i=@thingy.jp header.b=\"WYaf4QRn\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=none (p=none dis=none) header.from=thingy.jp","phobos.denx.de; spf=pass smtp.mailfrom=daniel@0x0f.com"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fv4Nt25dmz1yGg\n\tfor ; Mon, 13 Apr 2026 08:05:50 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id DE27083B99;\n\tMon, 13 Apr 2026 00:05:41 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id 969C183F75; Mon, 13 Apr 2026 00:05:40 +0200 (CEST)","from mail-yw1-x1134.google.com (mail-yw1-x1134.google.com\n [IPv6:2607:f8b0:4864:20::1134])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id A9131839D5\n for ; Mon, 13 Apr 2026 00:05:37 +0200 (CEST)","by mail-yw1-x1134.google.com with SMTP id\n 00721157ae682-79ab5fd969aso38247667b3.0\n for ; Sun, 12 Apr 2026 15:05:37 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-1.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=no\n autolearn_force=no version=3.4.2","ARC-Seal":"i=1; a=rsa-sha256; t=1776031536; cv=none;\n d=google.com; s=arc-20240605;\n b=YfnZ41IrQVL9vp09/rW/APizmo6SeZS+X5AoYLTjQtKvxsqDAjUkmWvj/dhVKYJY4u\n CcgabFzyNcAF6lKl+QcgjW4WBav6ZG+VivxhziO5Wd++PbOd854a8Ddq6MEJ8Iyo1Q8t\n tDDfULGF/KnRnOLcpXQ7fNMX2fK/bV3SUwz/oQTTOZHX47SPm1Fq7s4ex6kVU2BtT83z\n OmqnWRehpF3KU6tXTlNJp6ykVO6q62Iahj+iKGz9AA5dA0X0w2AlJP82ugJZv5sfwZ54\n R9LCklC28pOWby4hzSjCR0tyUngbECy2chCohpgqNBM2zq7XMwo8f86yxpoX4rr2PXiO\n 0KZg==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:dkim-signature;\n bh=dVqpAVw58Z+iGFbipzLEmTykmY/WtjTZTiyUjA1aTUw=;\n fh=AZkfv9O+MwE3AqHevojEB1Pmo7dmYD5K2R0frz0+OCY=;\n b=RVBxhYUbxgUzWsZ7+CzJrBnz/BbaCJpFls8qIXsn5QWHRhvviujlESlAgKnEn1Qr3V\n 73+RGkfWn5snXg6z3VPEex8WbH7R/KS/hUmydkcxB8/XEhTsisji9Db+pIt83t5jLNPM\n sDSWE7dMK+yHGn0uxf39k3J4MOh6E2WGnlAbsYOGDpdZzhVX63BDobsfoxI5TOqcdh3M\n IBeiaFg+W6Os8MlNJu/s4M6/juNbEtrWnz7ZBPj0F3mWCDpzmjkBKmDmJNJmcvVNlLHP\n ZkJgZ159ge7LsZ8xHPsK1i5tfPDOjMlWZ2TlyKr7OSEYDWef7p2ehyHxx2/WccfXdd9b\n 7p+Q==; darn=lists.denx.de","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=thingy.jp; s=google; t=1776031536; x=1776636336; darn=lists.denx.de;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:from:to:cc:subject:date:message-id:reply-to;\n bh=dVqpAVw58Z+iGFbipzLEmTykmY/WtjTZTiyUjA1aTUw=;\n b=WYaf4QRnbIvpQUubTNSsPgFieRgaq2AjYVUZMsjRlWuEHPKdP51XSmx6PDz3yWeXWV\n MVcaX+HcrjUMInedAVN9fCOWXXnz/aSptuS80WDG9MsAlTvBn/VsJHM71bVFd5soF/Ek\n OtXKSL1cgiol9ckXY4kpKO+TWVLFmbdl2iVgw=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776031536; x=1776636336;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=dVqpAVw58Z+iGFbipzLEmTykmY/WtjTZTiyUjA1aTUw=;\n b=pcE1o+mON5nSOwrsDcxXHuQaXpukjCwvgIxBG9pnThW6Bz1kkGjqbWC5zG/WU9cqcO\n GMwKiofsmIPph8cSK61nP2bHxPTvZwNQCWJWCXcBWVajriO3YTHt1KJjSGlW6bXEfPgA\n Oxh5ZBJf5QZ9xFkT6+OU5N3bN53/G4jjwTJbVVPKRFTZ/2mRHHaPi+OTkM3SOd8v5qck\n 9eey9U/DUa2GaidHZPpSeQySgha+SVbBODUrawniDY0Gomzrfab5R27hx4f4Ol3HMUE5\n W2BrhBTIeg8v52i6D0FQICresl+bTxq6KBFuv9YUxVltk+MAd0ns+0OnNuL21AwKD0RP\n 9QPw==","X-Forwarded-Encrypted":"i=1;\n AFNElJ//YdRbPMmXOk934RMyiWdVSPiuyLEZp8/xFDzx7ir04mkrbSb0I0OYK8X+BKL8eJggdNLAf6o=@lists.denx.de","X-Gm-Message-State":"AOJu0Yx4S9DsIR3iCnINgULdHvIVSeElY3euRkSStyqtznY/grabo99U\n EwnTRc/k8wzCX5BgIpht6RaZITta3WqWdIfENAvg6j5kgEVnuV2+vXbWbVv+uLKBqXkNevcptPO\n s4hzMr2ziLXEtPtGA9GNI4SK61ipCSw0Ng16tt5PXEQ==","X-Gm-Gg":"AeBDiesaESJEvigLUT/LkmpPpEMQT6hkEVR20j5BcEiUGP+nFRc1YHUXfvN94gweway\n u9U/k9Jwl2NSgA4wceB3QLsA7xRQK6hMObD3ufeqpiSOfPQBHP1GIOTwe2UDmEsN/VfgEjU+9mx\n VhMH7KPdSq1o2t65eiu5VWF/HRTzsoz9GDBDAlOSTLovSo47Ebp8aOe7Hs7qurBsL8b5MD0PNre\n Mlx49gmCZJl8a2QW+58ZFXx5ClnsyIfZquJ7p7E6nLBZW6BPC+F8DKFquKcAv3Llx04b39K6zmo\n y6YkQAxfNG0mk2sCWFeMUAmdfnNzcJP1dBVEwM/A","X-Received":"by 2002:a05:690c:d92:b0:79e:62cf:8254 with SMTP id\n 00721157ae682-7af6f22b8bemr123191207b3.8.1776031536375; Sun, 12 Apr 2026\n 15:05:36 -0700 (PDT)","MIME-Version":"1.0","References":"<20260408220928.3328551-1-daniel@thingy.jp>\n <20260408220928.3328551-5-daniel@thingy.jp>\n \n \n ","In-Reply-To":"","From":"Daniel Palmer ","Date":"Mon, 13 Apr 2026 07:05:22 +0900","X-Gm-Features":"AQROBzB9plD7C0UNJaVsTkRvOco2fPGEMnrJVxCMPU_T8WZnTtBQc_M1GF7UAKc","Message-ID":"\n ","Subject":"Re: [PATCH v3 4/5] virtio: blk: Fix converting the vendor id to a\n string","To":"Kuan-Wei Chiu ","Cc":"angelo@kernel-space.org, bmeng.cn@gmail.com, u-boot@lists.denx.de","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}}]