[{"id":3676180,"web_url":"http://patchwork.ozlabs.org/comment/3676180/","msgid":"<CAFLszTjdAcFbyELhAC6Si9_pSOH8ZqMWD_inrTH3w+VNEXt68A@mail.gmail.com>","list_archive_url":null,"date":"2026-04-11T16:28:36","subject":"Re: [PATCH v3 2/5] m68k: Fix writew(), writel(), readw(), readl()\n endianness for classic m68k","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"On 2026-04-08T22:09:23, Daniel Palmer <daniel@thingy.jp> wrote:\n> m68k: Fix writew(), writel(), readw(), readl() endianness for classic m68k\n>\n> In Linux these are meant to read a little-endian value and swap\n> to the CPU endian.\n>\n> In u-boot for m68k this is currently broken and prevents\n> virtio-mmio from functioning.\n>\n> This change is only for classic m68k. Coldfire has read big-endian,\n> no swap for these in u-boot and Linux and existing drivers probably\n> depend on this.\n>\n> Signed-off-by: Daniel Palmer <daniel@thingy.jp>\n>\n> arch/m68k/include/asm/io.h | 31 ++++++++++++++++++++-----------\n>  1 file changed, 20 insertions(+), 11 deletions(-)\n\nReviewed-by: Simon Glass <sjg@chromium.org>","headers":{"Return-Path":"<u-boot-bounces@lists.denx.de>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256\n header.s=google header.b=ASrIxBs7;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org\n header.b=\"ASrIxBs7\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=sjg@chromium.org"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4ftJyx2m1lz1yGb\n\tfor <incoming@patchwork.ozlabs.org>; Sun, 12 Apr 2026 02:29:13 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id EE61B84154;\n\tSat, 11 Apr 2026 18:29:04 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id 40CFD8416F; Sat, 11 Apr 2026 18:29:03 +0200 (CEST)","from mail-pl1-x62b.google.com (mail-pl1-x62b.google.com\n [IPv6:2607:f8b0:4864:20::62b])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 7182483DC9\n for <u-boot@lists.denx.de>; Sat, 11 Apr 2026 18:29:00 +0200 (CEST)","by mail-pl1-x62b.google.com with SMTP id\n d9443c01a7336-2a871daa98fso19936595ad.1\n for <u-boot@lists.denx.de>; Sat, 11 Apr 2026 09:29:00 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2","ARC-Seal":"i=1; a=rsa-sha256; t=1775924939; cv=none;\n d=google.com; s=arc-20240605;\n b=DIc1eHwzx8ob/eJOiVEwkEnsUZipQuNyMx8fmWxH3Onk4izWOIgI3CkN4HxEDYebqL\n yAy43qO0Tgu6IxI4cC5r7rb3PGboNm13+HHs1WmFiwu9BKY/CfMV8j2gWhacT9OvwQn8\n /nE3/Nx7OP8kcrdmOCZmhQICN+WeuN/S5Sctyns3QxMLbFkg8fU89BBbLh3IuZdEtEAu\n QEfv5tdHUmci9PaIfNWCdUv+MPyV/l18fy6z0KmqbqZukSK8xlL1zj6iaVHXFQa6rLtG\n i2/q+Lb90a/UBrt4Tl+fDBlcQ0YKq9BtQT14dtFNhH9vw4xCfgOM4WguzGReADzzAs9H\n acpw==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:dkim-signature;\n bh=k/nmbm6JVzRS++F2190jGb9MqXHXbchef2D+kSN9Xxk=;\n fh=kI0ydHh3I9VudES9YPN+YmTUNcg1GAMjIdsyacz7lxc=;\n b=UtZTF96iEDV2ZeLqo/L+DLERkRlRn8FmBFyoHkt8bbG4nyA2NajZylDuIxjqVEK6AV\n oRNS54Y1KWYWU5vGjVEGEXjUZ1HxsJMZsRQNEcnCHdwp9+W8Jz2/woHIFnrCoYHmywtL\n X3FNCfUvzZPtujfE8pbVI2l7yPSj16aZcIOEeBjFnfyVAhvPty/VEcudAVq8T12qOMNx\n 6oK1G2Y3u6txCzExjk3OZWpOjQfQ3D9/KuFg5ApE3SgRstVAlFdrM5fhNeCCz3SxQqD2\n ZpiTAqUYnDo2tC7mWMQFiHUfKNrMXyjeQyWtV6o1NO5D8WWFdNkQqbOLDzxtbPmxq09z\n aQnw==; darn=lists.denx.de","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=chromium.org; s=google; t=1775924939; x=1776529739; darn=lists.denx.de;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:from:to:cc:subject:date:message-id:reply-to;\n bh=k/nmbm6JVzRS++F2190jGb9MqXHXbchef2D+kSN9Xxk=;\n b=ASrIxBs7x7Z0dgSJ0baiH2t9Tcz3ybkqDwDYlmi1gDD26pgzPiElE3ShVuBX22zh/h\n aI/TDOhyczzo8/b11othp0Aa8KYdgr0nbGagRblN6GvclkfiGXL5BG0zmbJicOLOE/av\n 7B7Z/FlgFgAZM/3sOqRM5BKtuROX6Bc+xsIe4=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775924939; x=1776529739;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=k/nmbm6JVzRS++F2190jGb9MqXHXbchef2D+kSN9Xxk=;\n b=T9OkS30SkfnIzp2LFZnNY3UZJX/MB2IT1SQ8ToreWLNw8Xk1T2RGkb8FilmnoLeBP/\n ZXeNNmJn6bCsYmYoKWI0zKdJXbPAfirNYRmJmZP+/LSRmrMswt10/jqZmYIG4w3DgjTu\n RDRsQzO5wBu6wm34E3LQ8GNtBybY7u463Xr9ttRlwl10dxYf7VM+BEkDoMvHJNBkte8L\n uURpfv/EBwsGGxD+yYctDWeqa0uQi2rkehJGqDzK0X0WGJ23v3zIdg/zSfcV3Yn24LyE\n XqncJ33VK4A29OvwSU7NmCWGUur5kK4yrk6cOjKYQfIAdLptCTJh54BrkwtGcM10AYZo\n OKIg==","X-Forwarded-Encrypted":"i=1;\n AFNElJ8j/1Zhb7lDxXZbwBrZ7RLFCrgUK5JNZUqdEAON96XS/qopCjt6mZNO/ttT3d88o1jUFSJG41M=@lists.denx.de","X-Gm-Message-State":"AOJu0Yx3H7JSVrahXeAMNpHonNZKtzwJ75TXIarzBZDToCH7yTud+eHQ\n cHifSbszpbTBCxyj0mlQU7fQPCHms8swHhE+4TPUscuDOmfrFrJKfRld6B9wkPP+G3f/D4ByTMA\n eI0dr6qaVUTkk14mbOpqMZaWJ7SM3zKoaetmXjxPP","X-Gm-Gg":"AeBDietm0ZyulYcT4bP1CRglN6GC8LyhckP2OY5wlf2snn56TkUYplMfzohuHgzL07n\n U2v6j6kn9a6MWGz0Id5LBMzQ7Va3eazvOrOkbn5Gl/gke8656XGZc80R++51/n5oz1tHhClYnHz\n LdwVCwfaa5FqBgfPbCp3TdyefaeB81n9/N86RmmBY1XsYnIhKgLsELGMyvyjRg/CS+hKu7YRhPb\n F8ME7v+S8TEyf+XOWoVFxxejxeWNJ5LZMr4FDSPaLXpwDy308aVRSJRCUv33X3gjDNr+Eam5M79\n OVZlwk9QtU2Kj1Vp","X-Received":"by 2002:a17:903:2c04:b0:2b2:4fcc:2687 with SMTP id\n d9443c01a7336-2b2d5a49c8cmr73621835ad.31.1775924938864; Sat, 11 Apr 2026\n 09:28:58 -0700 (PDT)","MIME-Version":"1.0","References":"<20260408220928.3328551-1-daniel@thingy.jp>\n <20260408220928.3328551-3-daniel@thingy.jp>","In-Reply-To":"<20260408220928.3328551-3-daniel@thingy.jp>","From":"Simon Glass <sjg@chromium.org>","Date":"Sat, 11 Apr 2026 10:28:36 -0600","X-Gm-Features":"AQROBzCYb5Ny5X0_rs5BYrzFrPnckqeoQCQy0qpOlFw2vNwaV2PwwPu4p50t24U","Message-ID":"\n <CAFLszTjdAcFbyELhAC6Si9_pSOH8ZqMWD_inrTH3w+VNEXt68A@mail.gmail.com>","Subject":"Re: [PATCH v3 2/5] m68k: Fix writew(), writel(), readw(), readl()\n endianness for classic m68k","To":"daniel@thingy.jp","Cc":"visitorckw@gmail.com, angelo@kernel-space.org, bmeng.cn@gmail.com,\n u-boot@lists.denx.de","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion <u-boot.lists.denx.de>","List-Unsubscribe":"<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>","List-Archive":"<https://lists.denx.de/pipermail/u-boot/>","List-Post":"<mailto:u-boot@lists.denx.de>","List-Help":"<mailto:u-boot-request@lists.denx.de?subject=help>","List-Subscribe":"<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" <u-boot-bounces@lists.denx.de>","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}},{"id":3676206,"web_url":"http://patchwork.ozlabs.org/comment/3676206/","msgid":"<f9270d65-c5cd-442c-82aa-b6e6ce96fd9f@kernel-space.org>","list_archive_url":null,"date":"2026-04-11T21:07:36","subject":"Re: [PATCH v3 2/5] m68k: Fix writew(), writel(), readw(), readl()\n endianness for classic m68k","submitter":{"id":85702,"url":"http://patchwork.ozlabs.org/api/people/85702/","name":"Angelo Dureghello","email":"angelo@kernel-space.org"},"content":"Tested-by: Angelo Dureghello <angelo@kernel-space.org>\n\n\nit's mainly ok, btw, since you need still probably a v4,\nsee below:\n\nOn 4/9/26 00:09, Daniel Palmer wrote:\n> In Linux these are meant to read a little-endian value and swap\n> to the CPU endian.\n> \n> In u-boot for m68k this is currently broken and prevents\n> virtio-mmio from functioning.\n> \n> This change is only for classic m68k. Coldfire has read big-endian,\n> no swap for these in u-boot and Linux and existing drivers probably\n> depend on this.\n> \n> Signed-off-by: Daniel Palmer <daniel@thingy.jp>\n> ---\n>  arch/m68k/include/asm/io.h | 31 ++++++++++++++++++++-----------\n>  1 file changed, 20 insertions(+), 11 deletions(-)\n> \n> diff --git a/arch/m68k/include/asm/io.h b/arch/m68k/include/asm/io.h\n> index 35ad4a1c0444..2577081d8363 100644\n> --- a/arch/m68k/include/asm/io.h\n> +++ b/arch/m68k/include/asm/io.h\n> @@ -23,18 +23,27 @@\n>  #define __raw_writew(w,addr) ((*(volatile u16 *) (addr)) = (w))\n>  #define __raw_writel(l,addr) ((*(volatile u32 *) (addr)) = (l))\n>  \n> -#define readb(addr)\t\tin_8((volatile u8 *)(addr))\n> -#define writeb(b,addr)\t\tout_8((volatile u8 *)(addr), (b))\n> -#if !defined(__BIG_ENDIAN)\n> -#define readw(addr)\t\t(*(volatile u16 *) (addr))\n> -#define readl(addr)\t\t(*(volatile u32 *) (addr))\n> -#define writew(b,addr)\t\t((*(volatile u16 *) (addr)) = (b))\n> -#define writel(b,addr)\t\t((*(volatile u32 *) (addr)) = (b))\n> +#define readb(addr)\tin_8((volatile u8 *)(addr))\n> +#define writeb(b, addr)\tout_8((volatile u8 *)(addr), (b))\n> +#ifdef CONFIG_M680x0\n> +/*\n> + * For classic m68k these work the same way as Linux:\n> + * Read a little endian value, swap to the CPU endian.\n> + */\n> +#define readw(addr)\tin_le16((volatile u16 *)(addr))\n> +#define readl(addr)\tin_le32((volatile u32 *)(addr))\n> +#define writew(b, addr)\tout_le16((volatile u16 *)(addr), (b))\n> +#define writel(b, addr)\tout_le32((volatile u32 *)(addr), (b))\n\nMy understanding is that, even if m68k is big endian, you need \nLE r/w for usage with virtio. \n\nWould M680x0 non-qemu work still with this change ?\nMaybe an #if defined (CONFIG_VIRTIO) && defined(CONFIG_M680x0)\nwould be better ?\n\n\n>  #else\n> -#define readw(addr)\t\tin_be16((volatile u16 *)(addr))\n> -#define readl(addr)\t\tin_be32((volatile u32 *)(addr))\n> -#define writew(b,addr)\t\tout_be16((volatile u16 *)(addr),(b))\n> -#define writel(b,addr)\t\tout_be32((volatile u32 *)(addr),(b))\n> +/*\n> + * For coldfire these read a big endian value and use it\n> + * as-is. This means that for little endian devices on the\n> + * bus like PCI device these won't work as expected currently.\n> + */\n> +#define readw(addr)\tin_be16((volatile u16 *)(addr))\n> +#define readl(addr)\tin_be32((volatile u32 *)(addr))\n> +#define writew(b, addr)\tout_be16((volatile u16 *)(addr), (b))\n> +#define writel(b, addr)\tout_be32((volatile u32 *)(addr), (b))\n>  #endif\n>  \n>  /*\n\nRegards,\n-- Angelo","headers":{"Return-Path":"<u-boot-bounces@lists.denx.de>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=kernel-space.org header.i=@kernel-space.org\n header.a=rsa-sha256 header.s=s1 header.b=TQIeqQBA;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=reject dis=none) header.from=kernel-space.org","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=kernel-space.org header.i=@kernel-space.org\n header.b=\"TQIeqQBA\";\n\tdkim-atps=neutral","phobos.denx.de; dmarc=pass (p=reject dis=none)\n header.from=kernel-space.org","phobos.denx.de;\n spf=pass smtp.mailfrom=angelo@kernel-space.org"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4ftR8R2tq1z1yCv\n\tfor <incoming@patchwork.ozlabs.org>; Sun, 12 Apr 2026 07:07:51 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 1DB8684118;\n\tSat, 11 Apr 2026 23:07:42 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id 6B50184154; Sat, 11 Apr 2026 23:07:40 +0200 (CEST)","from mail.kernel-space.org (unknown\n [IPv6:2a03:4000:b:d08:14a9:1bff:fedc:75ad])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 52AA4839D9\n for <u-boot@lists.denx.de>; Sat, 11 Apr 2026 23:07:38 +0200 (CEST)","from [IPV6:2a07:7e81:7daa:0:62cf:84ff:feee:627] (<unknown>\n [2a07:7e81:7daa:0:62cf:84ff:feee:627])\n by oreshnik (OpenSMTPD) with ESMTPSA id 88e008d3\n (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO);\n Sat, 11 Apr 2026 21:07:37 +0000 (UTC)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-1.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,RDNS_NONE,\n SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.2","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-space.org;\n s=s1; t=1775941657;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=DWAi+84Oz91wEtgs4TfxjQAdgfyrO4rMb838qbUcvdQ=;\n b=TQIeqQBANrMlY7C7trDjb3WAfhIa+xMeiWXRF/OLKL0AOpHoDHH72YhdRuEJ4B3/xE9c9u\n pSIYffafwiulLsOcU+q9Mr/o104QocOcHpCRSCPdFABVEBzVR8CwC/Wbtfb+c6W56jMCEd\n +vPc7cAvfoKPi4FpX/pAj4QqfzXrQ0I=","Message-ID":"<f9270d65-c5cd-442c-82aa-b6e6ce96fd9f@kernel-space.org>","Date":"Sat, 11 Apr 2026 23:07:36 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v3 2/5] m68k: Fix writew(), writel(), readw(), readl()\n endianness for classic m68k","To":"Daniel Palmer <daniel@thingy.jp>, visitorckw@gmail.com, bmeng.cn@gmail.com","Cc":"u-boot@lists.denx.de","References":"<20260408220928.3328551-1-daniel@thingy.jp>\n <20260408220928.3328551-3-daniel@thingy.jp>","Content-Language":"en-US, it","From":"Angelo Dureghello <angelo@kernel-space.org>","In-Reply-To":"<20260408220928.3328551-3-daniel@thingy.jp>","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"7bit","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion <u-boot.lists.denx.de>","List-Unsubscribe":"<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>","List-Archive":"<https://lists.denx.de/pipermail/u-boot/>","List-Post":"<mailto:u-boot@lists.denx.de>","List-Help":"<mailto:u-boot-request@lists.denx.de?subject=help>","List-Subscribe":"<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" <u-boot-bounces@lists.denx.de>","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}},{"id":3676223,"web_url":"http://patchwork.ozlabs.org/comment/3676223/","msgid":"<CAFr9PXmywknpi_ULyYAxcy3yn3kh6wfizejQMtAwgwxe1=hzXQ@mail.gmail.com>","list_archive_url":null,"date":"2026-04-12T00:59:13","subject":"Re: [PATCH v3 2/5] m68k: Fix writew(), writel(), readw(), readl()\n endianness for classic m68k","submitter":{"id":85408,"url":"http://patchwork.ozlabs.org/api/people/85408/","name":"Daniel Palmer","email":"daniel@thingy.jp"},"content":"Hi Angelo,\n\nOn Sun, 12 Apr 2026 at 06:07, Angelo Dureghello <angelo@kernel-space.org> wrote:\n\n> Would M680x0 non-qemu work still with this change ?\n> Maybe an #if defined (CONFIG_VIRTIO) && defined(CONFIG_M680x0)\n> would be better ?\n\nI think we need this change even for non-virtio. The bug just showed\nup because of virtio.\nI think this would have shown up if/when PCI support is added. I have\nPCI on my Amiga working in Linux so that's not totally impossible. :)\n\nCheers,\n\nDaniel","headers":{"Return-Path":"<u-boot-bounces@lists.denx.de>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=thingy.jp header.i=@thingy.jp header.a=rsa-sha256\n header.s=google header.b=fjrIjp9K;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=none (p=none dis=none) header.from=thingy.jp","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=thingy.jp header.i=@thingy.jp header.b=\"fjrIjp9K\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=none (p=none dis=none) header.from=thingy.jp","phobos.denx.de; spf=pass smtp.mailfrom=daniel@0x0f.com"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4ftXHw6ZZzz1yGg\n\tfor <incoming@patchwork.ozlabs.org>; Sun, 12 Apr 2026 10:59:40 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 9EB7F83B99;\n\tSun, 12 Apr 2026 02:59:32 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id 18A4E83B99; Sun, 12 Apr 2026 02:59:31 +0200 (CEST)","from mail-dl1-x1236.google.com (mail-dl1-x1236.google.com\n [IPv6:2607:f8b0:4864:20::1236])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 97C10839D9\n for <u-boot@lists.denx.de>; Sun, 12 Apr 2026 02:59:27 +0200 (CEST)","by mail-dl1-x1236.google.com with SMTP id\n a92af1059eb24-12c45281a06so561836c88.1\n for <u-boot@lists.denx.de>; Sat, 11 Apr 2026 17:59:27 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-1.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=no\n autolearn_force=no version=3.4.2","ARC-Seal":"i=1; a=rsa-sha256; t=1775955566; cv=none;\n d=google.com; s=arc-20240605;\n b=FAjSNjetB0lpafKhNEuxZPompZB7vLwp7hpFG9Z9CNC9VgdKCGme8Edgi2vDf7qRKK\n 8dpI2y91eWGQn+FQFesA2cnl60Zsni91ajG9kTKEl5mZ76OCD4CGmnN03Xi3j99Dzsb7\n fHK2kbrMxY/+ErY34iykUJiyRnXjByny0bTzlMZh+ZTb2oG3x8E+zqYo5jLqIEKU2a4J\n 70FP58HFK0zrbO4hkNgI7jtA3LdZrTl9BQUEo0zWz9CvlqN1XjAo81zIHoYS7ME3LGas\n i/njdoCCk13maLvGjpBZQKhkkol4Fxq/xXOI1isQf9D2G2PsOUABOLL59lLaZRq8VnOY\n 69Jw==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:dkim-signature;\n bh=9B/awkBf76NYQ3wZfgenyzP5dYSGtgNbKORGBL7qQDY=;\n fh=ZUGUgN1x0n8D4+gg/oXM2I8GAYqDnensOouY5qV2UWA=;\n b=VPGS2eBHxDVq9U3DrSqqOjVGPdOq5hLh8Op7DHQdUbq5GMzP1eB930Ga30BOmvNspE\n YAe8ZNHg7+WcmMOC1c+YrgxDsFO1tVMUAgr7S7oHQaCJy4RbvMg9Cp1XPto+DZpmZmgN\n F9r5h2OJNqV3b3Jd4PMsN89coofJA6X39mWo7Wo57ZIcKTHByN0QozxVY7Yf/4/XaQJE\n qemViE+ihIkLcfKrJZWzhWc2SftiNRftdtySosR7Iayb6sJk+gmKxDr08z0UxyT5n6fM\n dwpLMUM/J/oEgvjNvbksodN7qhiPdqURVXdFTNghsfeG5alTDjVb3KdG8nOmgixJ2von\n AN7Q==; darn=lists.denx.de","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=thingy.jp; s=google; t=1775955566; x=1776560366; darn=lists.denx.de;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:from:to:cc:subject:date:message-id:reply-to;\n bh=9B/awkBf76NYQ3wZfgenyzP5dYSGtgNbKORGBL7qQDY=;\n b=fjrIjp9KH/wuhu32UhNBZsx3Vdu0a5GpUOmLyNFsdUapH0sjciX2lACm9VnZ4FXU7B\n y3juk+LybWeu3oQ8Px9qM9JWPQb2jrOfXrxhwjF1C3yYAuglN6zit/qxgoepP05/Xu66\n 4eBjsqtpVcS1iedgWmsphVOgOG6o64H9f5UJI=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775955566; x=1776560366;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=9B/awkBf76NYQ3wZfgenyzP5dYSGtgNbKORGBL7qQDY=;\n b=OsXFT7wMaEn9ti96AWq2qq3A2cl9rDE0lRtXg8iFXjpvGRjHbm0PPKT+0zx3FmMfRs\n Fv5CzB4K5uQkduca6UeLNCfA+KO8rSnAgZNNMe55q2mJAZsI7f0ChThGmkBs6GhThuSH\n 04zyBbsiaZJBrMGPGG59C/UbEGRRu5b6fUIi3Mm7vFrdl8PotlvA3LwUPERzVQgd6wvK\n N/lsgyX5bhLIu1OmM1BbH41hHMK3yuy720hh4xvWxrUMLpyGAToRYqWihqUKe0sbHEd0\n uSO2P035z4F1NMtu6JDlfNi1ESAZrzd3AuCxS1kKU7STz3gHCNc75MYZ05f4MwRUebFC\n C79g==","X-Forwarded-Encrypted":"i=1;\n AJvYcCUlh7h3ldGe2inPOU4+JIccjHdhU1TeeTkeQ9GFMwbj3Lr0lVVKuighhdABAgx3iduKwaLw1/A=@lists.denx.de","X-Gm-Message-State":"AOJu0YwLUwDeMT8hXatdt2XO+00hHY/I/xESEnPbRH/kMo/HhbeXcxF9\n AKJj8oQDj9LOWCZMtIOa07Q4wpjc9Ms7j6hlDtMCWxasEHKraHeb8tM8TsUHn/i1MAil15USGJZ\n gQwOnhbZgpoqGv8ixv5tLrNt2Zgo60Nk1uCsibynVbg==","X-Gm-Gg":"AeBDievb+iN6dYljnvutl7Wa98NLkgB46MsBfyQw7h6WzrK53rz9LUStGxMtbOeA4fO\n aR9bjHN0nPDxoi9b2EoUu6STNIwRpql8XHFee/nGpBoovGY9LUIqTnZJdvrXSCFOVSCQaoY0qdD\n IaGbdVy2gy2L6D7y3xk/R71fuJqwxbuu19xIbSPaFFBJQaFIac70ebgl8ZaQ/1MEIsiZlsVS+d3\n TF9Ck8PtzURPzpNhdhcB+daUmD4FneDE+VlaYZruME1guWiz+qe/tp9giC+FgjOjl8UtxS4HcS4\n vtRrQo+fvu1z/cU=","X-Received":"by 2002:a05:7022:48e:b0:128:df3d:cd97 with SMTP id\n a92af1059eb24-12c34f07477mr4736775c88.35.1775955565679; Sat, 11 Apr 2026\n 17:59:25 -0700 (PDT)","MIME-Version":"1.0","References":"<20260408220928.3328551-1-daniel@thingy.jp>\n <20260408220928.3328551-3-daniel@thingy.jp>\n <f9270d65-c5cd-442c-82aa-b6e6ce96fd9f@kernel-space.org>","In-Reply-To":"<f9270d65-c5cd-442c-82aa-b6e6ce96fd9f@kernel-space.org>","From":"Daniel Palmer <daniel@thingy.jp>","Date":"Sun, 12 Apr 2026 09:59:13 +0900","X-Gm-Features":"AQROBzCT7MsLN13zN-xnXDk7dZNzn7QVWJMsxvJ6Ym73UVn6ijG1P5-Bebe19d8","Message-ID":"\n <CAFr9PXmywknpi_ULyYAxcy3yn3kh6wfizejQMtAwgwxe1=hzXQ@mail.gmail.com>","Subject":"Re: [PATCH v3 2/5] m68k: Fix writew(), writel(), readw(), readl()\n endianness for classic m68k","To":"Angelo Dureghello <angelo@kernel-space.org>","Cc":"visitorckw@gmail.com, bmeng.cn@gmail.com, u-boot@lists.denx.de","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion <u-boot.lists.denx.de>","List-Unsubscribe":"<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>","List-Archive":"<https://lists.denx.de/pipermail/u-boot/>","List-Post":"<mailto:u-boot@lists.denx.de>","List-Help":"<mailto:u-boot-request@lists.denx.de?subject=help>","List-Subscribe":"<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" <u-boot-bounces@lists.denx.de>","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}}]