[{"id":3676181,"web_url":"http://patchwork.ozlabs.org/comment/3676181/","msgid":"","list_archive_url":null,"date":"2026-04-11T16:28:33","subject":"Re: [PATCH v3 1/5] sysreset: qemu virt: Use __raw_writel()","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"On 2026-04-08T22:09:23, Daniel Palmer wrote:\n> sysreset: qemu virt: Use __raw_writel()\n>\n> The virt ctrl register seems to be native endian, currently this driver\n> uses writel(), which works by luck because its currently broken on m68k.\n>\n> Use __raw_writel() instead to avoid breaking this driver when the\n> endianness of writel() is fixed.\n>\n> Signed-off-by: Daniel Palmer \n> Acked-by: Kuan-Wei Chiu \n>\n> drivers/sysreset/sysreset_qemu_virt_ctrl.c | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n\nReviewed-by: Simon Glass ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256\n header.s=google header.b=MObGRrb+;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org\n header.b=\"MObGRrb+\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=sjg@chromium.org"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4ftJz6600Hz1yGb\n\tfor ; Sun, 12 Apr 2026 02:29:22 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 89A7D84198;\n\tSat, 11 Apr 2026 18:29:20 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id 22A5F8419C; Sat, 11 Apr 2026 18:29:19 +0200 (CEST)","from mail-pl1-x629.google.com (mail-pl1-x629.google.com\n [IPv6:2607:f8b0:4864:20::629])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id F1F9183DC9\n for ; Sat, 11 Apr 2026 18:29:16 +0200 (CEST)","by mail-pl1-x629.google.com with SMTP id\n d9443c01a7336-2b2503753efso25507915ad.0\n for ; Sat, 11 Apr 2026 09:29:16 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2","ARC-Seal":"i=1; a=rsa-sha256; t=1775924955; cv=none;\n d=google.com; s=arc-20240605;\n b=IuDj+qMVOdjqQ0o2g/btGuQjhfOolG4vOXqA+0M/eiCe0uD5oN3ufII2U2VwGkOHGO\n Z8qcCJlwFMID1ZtvvvhAcIpobdtDG7xX5KjB+MGDujmjP4bqP5QSe0UN5dZsbXCRL7x2\n aOWNdVuqmqprfE7+MlBoLLc2itT4+h7KwE5hgnIX7OfvvGtUZtYsYbG/ii/7BTXh4fx9\n +zFvMrRfIQYgZwDPqDR52dXSUhuBEH8VGlrfbIbLaJykz3k15GGU4lQjefrxBXJ8P6Lx\n d0dRHoaeyvQVTya1qkyFuOmEihHujom6UK+l64G+99QAcwlX9Kr93xblBD6EYXe3rEwK\n OJKA==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:dkim-signature;\n bh=q+OpAFKfzkGppTzTLfhYsZ+znyMviHTt1e8C1EjryCo=;\n fh=qlfCqAiDC3ltiUDXh2FNnfkIW0F1ElhX3Wnc0ZgWHsE=;\n b=hJ6/OnXCv4d/8wMgAGVvIeaGeiYwyy6do3Cf0qd6C0vgIWALQtuBlSHeUwhDOq4RW0\n uicAw3bYCQqlQR05zYEVmXq4FXZAiASrWNEPkbM3UHu2jQUb+qQzAoKwIGRu7nD5nKIe\n L3wXVG02Gf4Ri3GmAertUThYMY8j7BcorXhWvYyfwzxTWOVi9A75XohlUcXup1ncm8fm\n mLEsEfMyD5q3ojtR0YD6IJznyNixRPE5gzkb0JajqFnimjxZ9jUg+ap1EjK1Jr3J5trK\n KM2glKbW59uNAMw8tByxS3GJHEwIisyLsCgBNnxTBIqA6q2+QPiitja7/ioU3S0sGSNB\n 9chg==; darn=lists.denx.de","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=chromium.org; s=google; t=1775924955; x=1776529755; darn=lists.denx.de;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:from:to:cc:subject:date:message-id:reply-to;\n bh=q+OpAFKfzkGppTzTLfhYsZ+znyMviHTt1e8C1EjryCo=;\n b=MObGRrb+iEYM+LvRmP8mryZRAJGCFZWEdkBBab8Z6J6D980YCYlGT5fxFErwuATv8y\n fGZrmBNF9peFMUnsAqvuXkpa/cl654C3jWu2VghA/Xk3WFHQCRlUjxJt5laSzcl/dNHJ\n gdbvNDv20/L3KT87I0LFK8kGWttHGm8bE6eDQ=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775924955; x=1776529755;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=q+OpAFKfzkGppTzTLfhYsZ+znyMviHTt1e8C1EjryCo=;\n b=i+5T32Z06QmA8eU8G4galrYC5GuiNF4QQfqTodNpTH8pzp5VF3CEK3VQjV7pq59a99\n 7tc7EhwBbvpdfTamcu/Qn6jxmyxVLo1UPbSZSu1JhjXPIvGXHoj38lhMlcKIm+5pzSFU\n WdQEIiaXKpq78uYGW/qptPK3xdu2tS1sGK/SCKbmUmhK/wGBx8JKoCrljl9Hq4DS6MoJ\n Ti2cqpMbUkghaXPihOYE5AiMa9mI+iK2C/rMbQQX9moYyxYyRyL762ueErUJfb0oHwhW\n 3SHAMQE5kOLqBc6+1zcXaul2PSO0PPokaY+rzSD3CWoDCnt6du1lrVpLzoFl7DY5KD0U\n +KoA==","X-Forwarded-Encrypted":"i=1;\n AFNElJ+6GOydoXWBJPzYoB/hkeO1b+dUPoPE52MfAEOYpidxj8oCiXXNAite/YRxNNcSS0QMtW7C4BY=@lists.denx.de","X-Gm-Message-State":"AOJu0YyU14/SgEYxFwAwjmV6e9AxYQs1nMPtOcDGssjYfpOXWhQHFY+J\n csANmT6mjA2/M4RYKJyoubjgTckubKnBeTR65yGVDQyWueazXBJ++dMsdGk9xNpeOP+57E3hjqJ\n FXPATy/HupO5CLwlr5DPFwLi+Rrq6xKlK4sdpkupI","X-Gm-Gg":"AeBDietwfRKB+OiFwgyOoUdMrPVYb4P7bQ9gPZDXaJzlRB2xgd+E6fh61Cm0IdLyZw1\n UZm4Mx+6inBVUolVOI9FnM77mkW1s1X44RlwZNFUmznLool+2U4QVNfKpnJia41YncFeqGTm/8O\n lyRO/89Vq8pNTsA2STpZ1n6y1GA0o5PTCS5gQZS9ncJlN5NF0uT7tW6QFcj0OLQViM1Y705CPY4\n 3SaiLHzKyqwAsxsW2/TCPQdTkPgHrYNaO8S4B8ddVEMiOByDfTLVmbvI+B50QZ75wgCA1AA8lUw\n 14cYVSFWJF8cYEjG","X-Received":"by 2002:a17:903:b83:b0:2b0:c106:a402 with SMTP id\n d9443c01a7336-2b2d5944c5bmr90623085ad.3.1775924955478; Sat, 11 Apr 2026\n 09:29:15 -0700 (PDT)","MIME-Version":"1.0","References":"<20260408220928.3328551-1-daniel@thingy.jp>\n <20260408220928.3328551-2-daniel@thingy.jp>","In-Reply-To":"<20260408220928.3328551-2-daniel@thingy.jp>","From":"Simon Glass ","Date":"Sat, 11 Apr 2026 10:28:33 -0600","X-Gm-Features":"AQROBzD-vYAWHGeYi36mR7mkQ3QgSjy_5sVbvrNEAwCxsXBhkWmgHPnjAjzZRR0","Message-ID":"\n ","Subject":"Re: [PATCH v3 1/5] sysreset: qemu virt: Use __raw_writel()","To":"daniel@thingy.jp","Cc":"visitorckw@gmail.com, angelo@kernel-space.org, bmeng.cn@gmail.com,\n u-boot@lists.denx.de","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}},{"id":3676201,"web_url":"http://patchwork.ozlabs.org/comment/3676201/","msgid":"<9889b0a1-d9db-45db-b51c-48fdd16f1784@kernel-space.org>","list_archive_url":null,"date":"2026-04-11T19:40:15","subject":"Re: [PATCH v3 1/5] sysreset: qemu virt: Use __raw_writel()","submitter":{"id":85702,"url":"http://patchwork.ozlabs.org/api/people/85702/","name":"Angelo Dureghello","email":"angelo@kernel-space.org"},"content":"Reviewed-by: Angelo Dureghello \n\nOn 4/9/26 00:09, Daniel Palmer wrote:\n> The virt ctrl register seems to be native endian, currently this driver\n> uses writel(), which works by luck because its currently broken on m68k.\n> \n> Use __raw_writel() instead to avoid breaking this driver when the\n> endianness of writel() is fixed.\n> \n> Signed-off-by: Daniel Palmer \n> Acked-by: Kuan-Wei Chiu \n> ---\n> drivers/sysreset/sysreset_qemu_virt_ctrl.c | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/drivers/sysreset/sysreset_qemu_virt_ctrl.c b/drivers/sysreset/sysreset_qemu_virt_ctrl.c\n> index e7cacc9b6e98..5ab16001922b 100644\n> --- a/drivers/sysreset/sysreset_qemu_virt_ctrl.c\n> +++ b/drivers/sysreset/sysreset_qemu_virt_ctrl.c\n> @@ -38,7 +38,7 @@ static int qemu_virt_ctrl_request(struct udevice *dev, enum sysreset_t type)\n> \t\treturn -EPROTONOSUPPORT;\n> \t}\n> \n> -\twritel(val, plat->reg + VIRT_CTRL_REG_CMD);\n> +\t__raw_writel(val, plat->reg + VIRT_CTRL_REG_CMD);\n> \n> \treturn -EINPROGRESS;\n> }\n\n-- Angelo","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=kernel-space.org header.i=@kernel-space.org\n header.a=rsa-sha256 header.s=s1 header.b=RW0PfUhz;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=reject dis=none) header.from=kernel-space.org","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=kernel-space.org header.i=@kernel-space.org\n header.b=\"RW0PfUhz\";\n\tdkim-atps=neutral","phobos.denx.de; dmarc=pass (p=reject dis=none)\n header.from=kernel-space.org","phobos.denx.de;\n spf=pass smtp.mailfrom=angelo@kernel-space.org"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4ftPCg4KQqz1yGb\n\tfor ; Sun, 12 Apr 2026 05:40:31 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id DF69884154;\n\tSat, 11 Apr 2026 21:40:21 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id 7BFCD8416F; Sat, 11 Apr 2026 21:40:20 +0200 (CEST)","from mail.kernel-space.org (unknown\n [IPv6:2a03:4000:b:d08:14a9:1bff:fedc:75ad])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 8ABB984118\n for ; Sat, 11 Apr 2026 21:40:17 +0200 (CEST)","from [IPV6:2a07:7e81:7daa:0:62cf:84ff:feee:627] (\n [2a07:7e81:7daa:0:62cf:84ff:feee:627])\n by oreshnik (OpenSMTPD) with ESMTPSA id 5339ce76\n (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO);\n Sat, 11 Apr 2026 19:40:16 +0000 (UTC)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-1.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,RDNS_NONE,\n SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.2","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-space.org;\n s=s1; t=1775936416;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=yVu3b7dmLO/HBV7udXHQtd9SF/qs0o67vID4jFM7SpQ=;\n b=RW0PfUhzOTW7ZGLIct7cNN7bdDYboGCXcPsjbqpvbdAlnLDmCoJY9Vpfzqfjy1oguFV1X+\n o0Al0Z85mxZ1Iurv9LJOjuXgQ4nkkmcL+XyM51R2CJpnPZa2cJHOvt0F4+KlN5r54pn192\n O95sQDr9uw1HPKh3wxlMYOW5+ix+cl4=","Message-ID":"<9889b0a1-d9db-45db-b51c-48fdd16f1784@kernel-space.org>","Date":"Sat, 11 Apr 2026 21:40:15 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v3 1/5] sysreset: qemu virt: Use __raw_writel()","To":"Daniel Palmer , visitorckw@gmail.com, bmeng.cn@gmail.com","Cc":"u-boot@lists.denx.de","References":"<20260408220928.3328551-1-daniel@thingy.jp>\n <20260408220928.3328551-2-daniel@thingy.jp>","Content-Language":"en-US, it","From":"Angelo Dureghello ","In-Reply-To":"<20260408220928.3328551-2-daniel@thingy.jp>","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"7bit","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}}]