[{"id":3675180,"web_url":"http://patchwork.ozlabs.org/comment/3675180/","msgid":"","list_archive_url":null,"date":"2026-04-09T08:45:47","subject":"Re: [Intel-wired-lan] [PATCH net] ice: Fix missing 1's complement\n negation in GCS raw checksum","submitter":{"id":75597,"url":"http://patchwork.ozlabs.org/api/people/75597/","name":"Loktionov, Aleksandr","email":"aleksandr.loktionov@intel.com"},"content":"> -----Original Message-----\n> From: Intel-wired-lan On Behalf\n> Of Matt Fleming\n> Sent: Wednesday, April 8, 2026 9:02 PM\n> To: Nguyen, Anthony L ; Kitszel,\n> Przemyslaw \n> Cc: Andrew Lunn ; David S . Miller\n> ; Eric Dumazet ; Jakub\n> Kicinski ; Paolo Abeni ; intel-\n> wired-lan@lists.osuosl.org; netdev@vger.kernel.org; linux-\n> kernel@vger.kernel.org; kernel-team@cloudflare.com; Matt Fleming\n> \n> Subject: [Intel-wired-lan] [PATCH net] ice: Fix missing 1's complement\n> negation in GCS raw checksum\n> \n> From: Matt Fleming \n> \n> Commit 905d1a220e8d (\"ice: Add E830 checksum offload support\") added\n> Generic Checksum (GCS) support for E830 NICs but omitted the 1's\n> complement negation (~) when converting the hardware raw_csum to\n> skb->csum for CHECKSUM_COMPLETE.\n> \n> Without the negation, every CHECKSUM_COMPLETE packet fails the fast-\n> path validation in nf_ip_checksum() and falls through to software\n> checksumming via __skb_checksum_complete(), which triggers the rate-\n> limited \"hw csum failure\" warning. Packets are still accepted (the\n> software recheck passes) but hardware checksum offload is effectively\n> disabled and the warning floods dmesg on systems running nf_conntrack\n> on VLAN sub-interfaces.\n> \n> Multiple other drivers (idpf, ehea, iwlwifi, cassini, sunhme, enetc)\n> also apply ~ for CHECKSUM_COMPLETE. The ice driver was the only in-\n> tree user of csum_unfold() for CHECKSUM_COMPLETE that omitted it.\n> \n> Fixes: 905d1a220e8d (\"ice: Add E830 checksum offload support\")\n> Signed-off-by: Matt Fleming \n> ---\n> drivers/net/ethernet/intel/ice/ice_txrx_lib.c | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/drivers/net/ethernet/intel/ice/ice_txrx_lib.c\n> b/drivers/net/ethernet/intel/ice/ice_txrx_lib.c\n> index e695a664e53d..c177579e0114 100644\n> --- a/drivers/net/ethernet/intel/ice/ice_txrx_lib.c\n> +++ b/drivers/net/ethernet/intel/ice/ice_txrx_lib.c\n> @@ -92,7 +92,7 @@ static void ice_rx_gcs(struct sk_buff *skb,\n> \tdesc = (struct ice_32b_rx_flex_desc_nic *)rx_desc;\n> \tskb->ip_summed = CHECKSUM_COMPLETE;\n> \tcsum = (__force u16)desc->raw_csum;\n> -\tskb->csum = csum_unfold((__force __sum16)swab16(csum));\n> +\tskb->csum = csum_unfold((__force __sum16)~swab16(csum));\n> }\n> \n> /**\n> --\n> 2.43.0\n\n\nI'd recommend adding Cc: stable@vger.kernel.org\nReviewed-by: Aleksandr Loktionov ","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=j4EVQpug;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=140.211.166.137; helo=smtp4.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4frtnJ6GMkz1xtJ\n\tfor ; Thu, 09 Apr 2026 18:45:56 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id F05B2410EE;\n\tThu, 9 Apr 2026 08:45:53 +0000 (UTC)","from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id v067K3PltIlI; Thu, 9 Apr 2026 08:45:53 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id C6CE7410A1;\n\tThu, 9 Apr 2026 08:45:52 +0000 (UTC)","from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n by lists1.osuosl.org (Postfix) with ESMTP id 0DB061F6\n for ; Thu, 9 Apr 2026 08:45:52 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp2.osuosl.org (Postfix) with ESMTP id 0A75E4039B\n for ; Thu, 9 Apr 2026 08:45:52 +0000 (UTC)","from smtp2.osuosl.org ([127.0.0.1])\n by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id TCQm4xXI681J for ;\n Thu, 9 Apr 2026 08:45:51 +0000 (UTC)","from mgamail.intel.com (mgamail.intel.com [198.175.65.21])\n by smtp2.osuosl.org (Postfix) with ESMTPS id 4CA0040246\n for ; Thu, 9 Apr 2026 08:45:51 +0000 (UTC)","from orviesa002.jf.intel.com ([10.64.159.142])\n by orvoesa113.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 09 Apr 2026 01:45:50 -0700","from orsmsx903.amr.corp.intel.com ([10.22.229.25])\n by orviesa002.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 09 Apr 2026 01:45:50 -0700","from ORSMSX902.amr.corp.intel.com (10.22.229.24) by\n ORSMSX903.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.2562.37; Thu, 9 Apr 2026 01:45:50 -0700","from ORSEDG901.ED.cps.intel.com (10.7.248.11) by\n ORSMSX902.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.2562.37 via Frontend Transport; Thu, 9 Apr 2026 01:45:50 -0700","from PH8PR06CU001.outbound.protection.outlook.com (40.107.209.12) by\n edgegateway.intel.com (134.134.137.111) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.2562.37; Thu, 9 Apr 2026 01:45:49 -0700","from IA3PR11MB8986.namprd11.prod.outlook.com (2603:10b6:208:577::21)\n by DS0PR11MB7960.namprd11.prod.outlook.com (2603:10b6:8:fe::22) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9769.20; Thu, 9 Apr\n 2026 08:45:47 +0000","from IA3PR11MB8986.namprd11.prod.outlook.com\n ([fe80::e6f0:6afb:6ef9:ab5c]) by IA3PR11MB8986.namprd11.prod.outlook.com\n ([fe80::e6f0:6afb:6ef9:ab5c%5]) with mapi id 15.20.9745.012; Thu, 9 Apr 2026\n 08:45:47 +0000"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp4.osuosl.org C6CE7410A1","OpenDKIM Filter v2.11.0 smtp2.osuosl.org 4CA0040246"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1775724352;\n\tbh=N5xp+LPdsxy14qtIIOAb9BI9SmsmquXjpws6x+2+Jw0=;\n\th=From:To:CC:Date:References:In-Reply-To:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t From;\n\tb=j4EVQpugLiP//jjpuJGUY92lepCT5f7mA/B3LYUVUuDJEmPu/lpZYkG8UbMtOhvPo\n\t fi0Y6ZQtCQB9uusgnITo08cZmyYPDU3nnXJaI2hghwvsXn8WBF6MM32CJS7DF4M4Tg\n\t ljNjIjoD+MCVqQwArTMGvqTiRrgCwJ10JtFWHaOr74sM7eSpMj8Ds9y9EctV6R5bUg\n\t RdrUuA1KKf37N8ky5ll1eGLuFgC4jwjYN9fjqjrdxCEzfnhSK+svPNnI64tXuqpFTV\n\t QUkb/DmJD0gwdpEYVHt/MnnnPSZCPmvwDS4Hf6vVm4Cff/wtkJ2srF4caJHzGhC6Zq\n\t d4r8ZNnrWE5UQ==","Received-SPF":"Pass (mailfrom) identity=mailfrom; client-ip=198.175.65.21;\n helo=mgamail.intel.com; envelope-from=aleksandr.loktionov@intel.com;\n receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp2.osuosl.org 4CA0040246","X-CSE-ConnectionGUID":["+g4P6o08RFqybtK5xF5/Lg==","EI45RLxvT2yXT0gwddSGLw=="],"X-CSE-MsgGUID":["509qDvveREy0jCDqfcchsw==","Eyh94OKISH2Zphlwe2+K2Q=="],"X-IronPort-AV":["E=McAfee;i=\"6800,10657,11753\"; a=\"76602126\"","E=Sophos;i=\"6.23,169,1770624000\"; d=\"scan'208\";a=\"76602126\"","E=Sophos;i=\"6.23,169,1770624000\"; d=\"scan'208\";a=\"259157534\""],"X-ExtLoop1":"1","ARC-Seal":"i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=TJhXADgaTQXufN67WUDJDEBYbqi1XTSz5aBNjq7XLlxJV2NH8LpIRxNecTCIXVWMp5eJY0AGQqGxW/nh3kX3hZQWhAl3TmRd919ZiGbuldE/YkF3l3fV1D8ciEluXk9YxCkOu1sD9cepjb4RD1idC7zLZ8txkZXt6f8/RZjXZzhz2VSUOSC9IEhBx+2RqBNwiCtYSeQhIJ4dWAuowIO+YbJAlyNlc/Asfwfddpk6hJzuuWiwEkbY0xLbjsFosvjQAd2aQlXnHQ8bsp7bdU4xXxDzMbRJthUniz6bTT9/pvs3FLXHkyGBdrEhZgBOXDt39KJ4+IhGeY+G7cVbjGRGYA==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=N5xp+LPdsxy14qtIIOAb9BI9SmsmquXjpws6x+2+Jw0=;\n b=IFiifgSZYN2Pw9B8VpChQr5WJ5felAMah/TKFHGjhiXWbFLqFbFoKf6pEtT0edNnCGCWJfyW/eJ1hdhhj0vPWxb8L8jPPKfFy3yWdtt0FExm6b36Y+C1PsLNqLdKjNV4PZ9rqbN9f8SL5lJZPZ8PZlmLuUIro2aWsdG+y7hG/7BuhxqEROErWPMYlv02A+agC9CEg65RFFXqgN1Xopg51dlCWNTyWEyR02TzTPaLf3IIy6Ktl/TRHRQNR3t7c6pKhpF0P5RjjZf6YecdiDUaMI4qCbAHwk5Gpz8r7l0HjAnx4RTVD6bPi59g9J/Fq88UEINFLtV2n4zm2gUy4r6Atw==","ARC-Authentication-Results":"i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;\n dkim=pass header.d=intel.com; arc=none","From":"\"Loktionov, Aleksandr\" ","To":"Matt Fleming , \"Nguyen, Anthony L\"\n , \"Kitszel, Przemyslaw\"\n ","CC":"Andrew Lunn , \"David S . Miller\"\n , Eric Dumazet , Jakub Kicinski\n , Paolo Abeni ,\n \"intel-wired-lan@lists.osuosl.org\" ,\n \"netdev@vger.kernel.org\" ,\n \"linux-kernel@vger.kernel.org\" ,\n \"kernel-team@cloudflare.com\" , Matt Fleming\n ","Thread-Topic":"[Intel-wired-lan] [PATCH net] ice: Fix missing 1's complement\n negation in GCS raw checksum","Thread-Index":"AQHcx52Wus8Y9aTtgUiaojGbSlgRrbXWawWQ","Date":"Thu, 9 Apr 2026 08:45:47 +0000","Message-ID":"\n ","References":"<20260408190214.1287708-1-matt@readmodwrite.com>","In-Reply-To":"<20260408190214.1287708-1-matt@readmodwrite.com>","Accept-Language":"en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","x-ms-publictraffictype":"Email","x-ms-traffictypediagnostic":"IA3PR11MB8986:EE_|DS0PR11MB7960:EE_","x-ms-office365-filtering-correlation-id":"09a15001-0af2-4712-c6cd-08de96146538","x-ms-exchange-senderadcheck":"1","x-ms-exchange-antispam-relay":"0","x-microsoft-antispam":"BCL:0;\n ARA:13230040|1800799024|376014|366016|7416014|38070700021|18002099003|22082099003|56012099003;","x-microsoft-antispam-message-info":"\n uMU6VE6rAdTzRnvL3i0cHUrpNmY0kBAxt1QSlf6TsS5hGIprOPAC6RaLUM6JZYNQ+ryyJ0aSjIbc+ChlrYFzimGy413XwF1oOBBcNki5uVcR3lTR5UP8O+quE+trE5gAdAWi7hOhr+q2N31JPg0qNHMSU20n0CAWSFmhNYJQ2d5D7dMGXea9ceJ2IQkmWQ11012q/vVR65BJJOgta13MivQURTbYHx7FkLP2CbvzbauM4KOoZQ+nXPdS6mSnGCLFJ6lOs1w4uElC/CLQXlVGcrY6XfhretFonuXTb3w+1tfU7Ez8P73z/VM40JW5JfX/GPcdd5EQLD+R0soHTS+WBX/Mk344TtWCKoA66arVGgz+YYPT1oVhvL04PKIMotd1x+KiJFnhhuUl4q40/6XVU7Qu29Gmt8bW/f1rUE21Rk3DGuiEjD+u9RZA4KJGA5B6pQGstRSRXw7/GNFGTfRAtKm5YIwa7FVkXC4/XlSzh3eQeXLG831Wds4H+h7o/yBJSH2jqSlbJUkNhsBQobBdbVYouzPudlMzQtiyMly71eY2iFfDYlk97I6QRUaFuK8lUIkeTvQ1TzzSxTMXpE9UJUU5LpJWh9a4+EKQxiHteOcSMc/TEtbL0lf541GwrBCeSvXymhjgpS+jMTaRAPnfHzwBbm/fZayXSFJ1IHFwY3EwqFuD5z7Kneq3JGIS158d69POEIYZUuMcPda0U6chjMHf6cOtiBRmUFlJGMhsdg0K6mG8EarXkexAT7tddNw+AaGDPtt7vxjk3g26r6tcAOYqsscXeF517fwDSNCeKIc=","x-forefront-antispam-report":"CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:IA3PR11MB8986.namprd11.prod.outlook.com; PTR:; CAT:NONE;\n SFS:(13230040)(1800799024)(376014)(366016)(7416014)(38070700021)(18002099003)(22082099003)(56012099003);\n DIR:OUT; SFP:1101;","x-ms-exchange-antispam-messagedata-chunkcount":"1","x-ms-exchange-antispam-messagedata-0":"\n DtLE2m6bQuACpsixN5fdZbqoqd4nTaO6q5THFscnNi1RenXVSLmnEvDAf7/ehNqu/zHHjyduxU4J5LAtxUUYNwKZ8BK6C9DAne2YSgXx5bpHissrja2rahUyuXxYwXXlMYahtWzSuCk1pLS8tLbg7RvlMKI4rtWXGXX5/Q455KhQkGjylbIrwwmqViDt0He6duNN2wkRH5YS/keigqdxxTiKegMBma/J6zqUypm3rBiEXdnMUKMcDzJEx7lXfpG4WUPPT8VLhlmIrHJww4Ti9LJ1+2qEuKd/qhTRyo6jFlbDvHM4hocFrffK4q8fIRvuEHULsi/Jhnor0x47TFPoZD7cbyt6gy1iqPkkAQkN1k3aI2ZZrx8xQPFtN00Ms+zBZCf5vKxWIDk9IOIKhwyOs8I6+uHQH9DJQR27pH7hI0StiA7/2tUHuW9EpwszaH8vR4/HuNBv1hbtmtQm1t3G3/BxX0gEl+qrqbM7OfBYvsvgSyiHmDMf5mkYbTqTSOaKWBHEyHuaXTV+fhRbCxg0SbPWd5J3b+IdU/meNAxfg8KHEpR018GT0L9oqZ65APfVxIgf9pncmKg212lw6xATx6NN0kg9GlT2ulQpS9puwZ+W6owczaBitrLDt1MmJ8vz/j1L96DYtZ8Dv5V9ZMrzLFiyONn3j46SzytV4xEvWzoAtCK6b7FCgSJvfOftoIpwNPUNsHy/amCNLolvMLrJ8g9wgdlpDaL3lNsfpBVEv0YhzQ9q0S4hx2pt9apl+QWMjPndPcuDX5aQGeZ0Cv5F9U+vqeBFgzG+fAYdsHhe7iDrPx4WdKr59tsF+CpsIVT+OKsL9S12Pte6n4JstOzeK4OC4q0KWpux+hWemgAXa+YRtb8HeWGLHEXpS58Tnrwf3OesEOrVtm5VZd8wi0PDXFmAWWNSns8GKXPs30ybpDcOs+urw/ZVnaLnHFRb3b5YZ/O4rvuhjAHGbko6YgvHmwDoH0G6yzltNE24WlzWegAXPA5YqQ818/0+5F5o0K3mv4fj/aynJhTIaPj77dzV82C6MZN0Tmp7Jo2wmY3Dg11KXZ8dBkhzonsbuZahKRL++R+TW0aUQOg1wJDSq5hSWE2G8ZhWjK0EVFDP6/uu+rqRVD+v0uGpcYZA8W3NCsc8G/0PJj95YtHDzHg1DcaTr7wVV1F1Z1BWjgthd0BbuOIEUTxtt4NcIU6rh07SAJJ3SLaHRsH5DaJhyHrJ2+fMZJJj7mteYTXV4iLiXkmDgMbJpQCyMTjN20Cs3Crb9UM/1LWLEVXzG2jVeShKvhRWmUqW5Mb+hC5M6YUfHA8drxbsMH9JzhCQKx7vl15vALImz3nakh59bmyGrwOW7PcmzXhaFHROw/+V7BZzZS5kOBEJipZa9UUoGh+ju/YlcKRUaFvTfbPz1lTVSRk8X+PBMk/4Kl6yMbeWOF95Zeq03hADTOrHWx9ATumd5DRa47hrLSETcFHtdAelJKVe81xJJRdq0WXAQgUlGmA2+OIcyEcxe5Ntg89Y/dbCC66CqAliXxIw54jud54nncS4BXb+PzWYtQ+LAX2bddMk2R6+AJHkxG0C1LtMvaXuhsUXZFi2Kjmm5HsO93yoATBv0JY4g4s+eNK4HiqYYrBVfesUp162JHdGSKIqgoWgd2EXdEC1TyltwcpDNjj1/IEZt7i2Mo4y5k4fd5C7ytiptmoEd+OKmfb4RMdaLT8YF3DLFaDnAx43oWVdP5uJ5Z2yNhVG0EDeCIfctoOjgJQBDfRk9aI=","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"quoted-printable","MIME-Version":"1.0","X-Exchange-RoutingPolicyChecked":"\n LTdZO9Nw6+PqywxrNzAHoI6v20qb5Hstz6lHzqRRVX+AD6R89BVt2mpUj7j/KySlp+QRI6Hoy+MmR5x536BB2LpNOvRKFMolaZP/b6QWJJeo4TESg255/0Eaq2IC0fSwMuRHgfj95GVHgsEYSC7F0YQE88E7opQv9Gvft4P1b9CL0FHyQpuYb+zEjfSUNliGUQcsjD0TX/OqKJ3bwcns1dQWMrAjGP4uZ29PdcpbQReSmZh/LP7QIK37NKyOlf1ZQFzW+4tQL6hsLByieCeI9+mBnum+/zlIvaQAcyYOmOrBMYtgkmNByGbKR73DO06sTSrGfy5QcegZ2XiMIywu8g==","X-MS-Exchange-CrossTenant-AuthAs":"Internal","X-MS-Exchange-CrossTenant-AuthSource":"IA3PR11MB8986.namprd11.prod.outlook.com","X-MS-Exchange-CrossTenant-Network-Message-Id":"\n 09a15001-0af2-4712-c6cd-08de96146538","X-MS-Exchange-CrossTenant-originalarrivaltime":"09 Apr 2026 08:45:47.4772 (UTC)","X-MS-Exchange-CrossTenant-fromentityheader":"Hosted","X-MS-Exchange-CrossTenant-id":"46c98d88-e344-4ed4-8496-4ed7712e255d","X-MS-Exchange-CrossTenant-mailboxtype":"HOSTED","X-MS-Exchange-CrossTenant-userprincipalname":"\n jndmgqwHoMrQC3UxoW2RFB7zYxQv+HCQJDDFCkpZHRvl0cahjHnIBZ/GzB59qHNyWiOPSERvR/5hrM6ReFME9zU89+PhWchXg1zOQ+/lGUc=","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"DS0PR11MB7960","X-OriginatorOrg":"intel.com","X-Mailman-Original-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1775724351; x=1807260351;\n h=from:to:cc:subject:date:message-id:references:\n in-reply-to:content-transfer-encoding:mime-version;\n bh=xVk6CScZ/o/M4m49uajIRQ9ODy56pZ04B3W2G9bLrNg=;\n b=A3T2KDscnQIbysNyI373oHcv+DBEJv5jEI34Bj+U2K7RP1NvVFU5TWy2\n 75odnp1rkpt22VF2hNse0eeDWM0kzEKV6fieYAf33vULx6seIbGD4J8yk\n ZoEZ4c1rtJYzjhG1jUutg2mVyxYxbxUlKjPOPS5cE18HgkvJZAeEdC6CR\n Qrgt+l/iIOXtc02++n7RYPuBxbZ6XxcpxwVyxqBMR+/1Jtk/eZjobtqn2\n OsqG34jAPwg0s/AxCuwBIr4I/v7T/tgriFzfK66gEP9PM7VRyD/vqeC2z\n YC2OCs99OMuMi/zeV4puWU+nWYNewnbg1R0xk2o41R7w1VSuav53sqNDt\n g==;","X-Mailman-Original-Authentication-Results":["smtp2.osuosl.org;\n dmarc=pass (p=none dis=none)\n header.from=intel.com","smtp2.osuosl.org;\n dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com\n header.a=rsa-sha256 header.s=Intel header.b=A3T2KDsc","dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=intel.com;"],"Subject":"Re: [Intel-wired-lan] [PATCH net] ice: Fix missing 1's complement\n negation in GCS raw checksum","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "}},{"id":3676786,"web_url":"http://patchwork.ozlabs.org/comment/3676786/","msgid":"<20260413141126.GR469338@kernel.org>","list_archive_url":null,"date":"2026-04-13T14:11:26","subject":"Re: [Intel-wired-lan] [PATCH net] ice: Fix missing 1's complement\n negation in GCS raw checksum","submitter":{"id":82748,"url":"http://patchwork.ozlabs.org/api/people/82748/","name":"Simon Horman","email":"horms@kernel.org"},"content":"On Wed, Apr 08, 2026 at 08:02:14PM +0100, Matt Fleming wrote:\n> From: Matt Fleming \n> \n> Commit 905d1a220e8d (\"ice: Add E830 checksum offload support\") added\n> Generic Checksum (GCS) support for E830 NICs but omitted the 1's\n> complement negation (~) when converting the hardware raw_csum to\n> skb->csum for CHECKSUM_COMPLETE.\n> \n> Without the negation, every CHECKSUM_COMPLETE packet fails the\n> fast-path validation in nf_ip_checksum() and falls through to software\n> checksumming via __skb_checksum_complete(), which triggers the\n> rate-limited \"hw csum failure\" warning. Packets are still accepted\n> (the software recheck passes) but hardware checksum offload is\n> effectively disabled and the warning floods dmesg on systems running\n> nf_conntrack on VLAN sub-interfaces.\n> \n> Multiple other drivers (idpf, ehea, iwlwifi, cassini, sunhme, enetc)\n> also apply ~ for CHECKSUM_COMPLETE. The ice driver was the only in-tree\n> user of csum_unfold() for CHECKSUM_COMPLETE that omitted it.\n> \n> Fixes: 905d1a220e8d (\"ice: Add E830 checksum offload support\")\n> Signed-off-by: Matt Fleming \n\nReviewed-by: Simon Horman ","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=5IrH54aT;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::138; helo=smtp1.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fvTqG41SBz1y2d\n\tfor ; Tue, 14 Apr 2026 00:11:38 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id CDEA784797;\n\tMon, 13 Apr 2026 14:11:36 +0000 (UTC)","from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id 8s8Fk3QLZLNY; Mon, 13 Apr 2026 14:11:34 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id 9B5558478F;\n\tMon, 13 Apr 2026 14:11:34 +0000 (UTC)","from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n by lists1.osuosl.org (Postfix) with ESMTP id 4130F237\n for ; Mon, 13 Apr 2026 14:11:33 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp4.osuosl.org (Postfix) with ESMTP id 3245D422AE\n for ; Mon, 13 Apr 2026 14:11:33 +0000 (UTC)","from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id iOIBPHzOVTR4 for ;\n Mon, 13 Apr 2026 14:11:32 +0000 (UTC)","from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254])\n by smtp4.osuosl.org (Postfix) with ESMTPS id 7242E41F54\n for ; Mon, 13 Apr 2026 14:11:32 +0000 (UTC)","from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58])\n by tor.source.kernel.org (Postfix) with ESMTP id 7BC0260172;\n Mon, 13 Apr 2026 14:11:31 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id AD6D9C2BCAF;\n Mon, 13 Apr 2026 14:11:28 +0000 (UTC)"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp1.osuosl.org 9B5558478F","OpenDKIM Filter v2.11.0 smtp4.osuosl.org 7242E41F54"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1776089494;\n\tbh=DS+S0BRyZHRR76xF3fsEAk6msLD+shY5kdGfLkw+59M=;\n\th=Date:From:To:Cc:References:In-Reply-To:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t From;\n\tb=5IrH54aTBDhuladj5r410PFwdQDg0R7uSXxEAeBWNN2I8RRCxLbAzM3aFramTELSz\n\t wZUphAE6rNkpYlVzToxorXuP3gNoRKVhw5UPga4NwhAMAgeckY1Vfot+4ZFm6Qp4X1\n\t iZjwuAUlT+fsdLGk165GDp7yUaiWcpYYsDtCQooYSRCnD9aYusuRhuRGgdrTHc7szu\n\t FyqKSLnufTYuddgvpZ5zRaFLnAQVyiFxho0r3kVGhY50UQeLgKVTDIZ3tk1/amPodX\n\t cQAyzj2YOJM5E3AkeUdpUGb6+F45cnULA2IrAba0kJXbN5zxTTG5svzPMKPotuhoDk\n\t pW+/C4kfGsvxw==","Received-SPF":"Pass (mailfrom) identity=mailfrom; client-ip=172.105.4.254;\n helo=tor.source.kernel.org; envelope-from=horms@kernel.org;\n receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp4.osuosl.org 7242E41F54","Date":"Mon, 13 Apr 2026 15:11:26 +0100","From":"Simon Horman ","To":"Matt Fleming ","Cc":"Tony Nguyen ,\n Przemek Kitszel ,\n Andrew Lunn ,\n \"David S . Miller\" ,\n Eric Dumazet ,\n Jakub Kicinski , Paolo Abeni ,\n intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,\n linux-kernel@vger.kernel.org, kernel-team@cloudflare.com,\n Matt Fleming ","Message-ID":"<20260413141126.GR469338@kernel.org>","References":"<20260408190214.1287708-1-matt@readmodwrite.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20260408190214.1287708-1-matt@readmodwrite.com>","X-Mailman-Original-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n d=kernel.org; s=k20201202; t=1776089491;\n bh=gFRvrKXlOfg+aEGi39wpVj9CoHvkfV4SW9XjwhO71Bg=;\n h=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n b=Vuz8JIgyGFQs79J7jNYhLXjVTEJKcIy7q5fIMQvp69Rs6UAmh9zywB6sRRJyuSPZ2\n g+pdHQ203cM48BifuF+R1XKrQAour1unMgz1Hs9HNTMCQzb2M3F4CRrv4S2bN2AAfT\n 29qhXHvawfyEttE99sA2TD0YgSFFuxY+c2+oUt2NwsZH5HNRQi85n8aohpaOvSd32v\n fM9Vygo51KBRkcEEhB8B9OMaZ7kqOmtJ3ZeRTprb2EqP88EMVtZe1TDG9WyHnoQiru\n RKdLCkyaoXwYB6kV24hu8LH8p1H1q0ApAoO5ee8ZbPe7R36iMv9CJbvNo5XyKF14mn\n aGz59T8PyA/0w==","X-Mailman-Original-Authentication-Results":["smtp4.osuosl.org;\n dmarc=pass (p=quarantine dis=none)\n header.from=kernel.org","smtp4.osuosl.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.a=rsa-sha256 header.s=k20201202 header.b=Vuz8JIgy"],"Subject":"Re: [Intel-wired-lan] [PATCH net] ice: Fix missing 1's complement\n negation in GCS raw checksum","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "}}]