[{"id":3675229,"web_url":"http://patchwork.ozlabs.org/comment/3675229/","msgid":"<68377029-7ee8-4e8d-8ac9-9e278527725f@linaro.org>","list_archive_url":null,"date":"2026-04-09T10:08:26","subject":"Re: [PATCH] qemu-keymap: fix altgr modifier lookup for newer\n xkeyboard-config","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/people/85046/","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"content":"On 8/4/26 11:14, Dietmar Maurer wrote:\n> xkeyboard-config 2.37 removed the \"AltGr\" virtual modifier in favor\n> of mapping upper groups directly to Mod5. Since then,\n> xkb_keymap_mod_get_index(map, \"AltGr\") returns XKB_MOD_INVALID, so\n> AltGr-based keysyms were never generated.\n> \n> See: https://gitlab.freedesktop.org/xkeyboard-config/xkeyboard-config/-/commit/473f9bc32f9ba869829cc0d06a75cd1f2560aa60\n> \n> Try \"AltGr\" first, and fall back to \"Mod5\" for compatibility with\n> both old and new xkeyboard-config versions.\n> \n> Signed-off-by: Dietmar Maurer \n> ---\n> qemu-keymap.c | 3 +++\n> 1 file changed, 3 insertions(+)\n> \n> diff --git a/qemu-keymap.c b/qemu-keymap.c\n> index 1c081db287..d4dccf456e 100644\n> --- a/qemu-keymap.c\n> +++ b/qemu-keymap.c\n> @@ -230,6 +230,9 @@ int main(int argc, char *argv[])\n> shift = get_mod(map, \"Shift\");\n> ctrl = get_mod(map, \"Control\");\n> altgr = get_mod(map, \"AltGr\");\n> + if (!altgr) {\n> + altgr = get_mod(map, \"Mod5\");\n> + }\n> numlock = get_mod(map, \"NumLock\");\n> \n> state = xkb_state_new(map);\n\nReviewed-by: Philippe Mathieu-Daudé ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=D/Q7uVVc;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4frwdG6LqHz1yD3\n\tfor ; Thu, 09 Apr 2026 20:09:06 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wAmJT-00047T-9d; Thu, 09 Apr 2026 06:08:39 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wAmJR-00046z-AW\n for qemu-devel@nongnu.org; Thu, 09 Apr 2026 06:08:37 -0400","from mail-wr1-x435.google.com ([2a00:1450:4864:20::435])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1wAmJP-0001ac-FL\n for qemu-devel@nongnu.org; Thu, 09 Apr 2026 06:08:37 -0400","by mail-wr1-x435.google.com with SMTP id\n ffacd0b85a97d-43cf5fbacc9so307555f8f.1\n for ; Thu, 09 Apr 2026 03:08:30 -0700 (PDT)","from [192.168.69.228] (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-43d1e2a6f1esm64076836f8f.2.2026.04.09.03.08.27\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Thu, 09 Apr 2026 03:08:28 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1775729309; x=1776334109; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:from:references:cc:to\n :content-language:subject:user-agent:mime-version:date:message-id\n :from:to:cc:subject:date:message-id:reply-to;\n bh=czwoU/ZfheHOAdi+mpOX47DQyo69hYcINikhCvUDFnw=;\n b=D/Q7uVVcmnIuwaOUGTZy5Zd3/fAvAHg7IzBGTAPP+NB38LaQe87Fe2H06Kt7WAOfRg\n z+G9ikNO2lQSahfs9uihWMfD7cnGPhJfePcOtwY4qL5Ouc6x+hPIH2XUHyOqbc1REsAw\n Lo3sQXqNSlbelw4pCkb+SyDeZsaB0xis7FE/IHZZRXizrwSNPtCH0V/JTJ8r+3aI9Oew\n 0Q9luuxTOBtSEJBMi6E1Hm/nxFsCXljYQZSXD47AdE9Vha37ntbuKWx/c0/mBb85HUxP\n Qx8M0IPzmShE+9a8VbLLfOfDQa6Jcyja4DRw2fJA3wmKJWsQDA9179AIL1V7h0zBOlaF\n LLSg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775729309; x=1776334109;\n h=content-transfer-encoding:in-reply-to:from:references:cc:to\n :content-language:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=czwoU/ZfheHOAdi+mpOX47DQyo69hYcINikhCvUDFnw=;\n b=rRTCGyWdU+s243az4dVC9ch7BH3pO+ahlV0xKjaOFPUifeQPiSAXj41lmhuhmAhYBn\n uI32KypzTeq/ltIDULj+7FxhJVCbP//Z03yq1C8PXPHBRy2fyc2NweebXcSKKyc0PAlW\n r5ScW+jjqxiNgSG/fAeoM5s33OiEVbYAFv/mZ43L2MG4u0HnwTaMdcY0vo7LPrugBy2x\n cBsIjLil7tsj1NsoKT1mKZphGWlfA0fJwDLbtmN45m8NHCV9i4NuGRqA23qUu8Qn7rGt\n 6g4yjRXwr/CzT6gZWwNkqnlV2LW4oRZQB41Fn89YTgW45Ul5DAzBWD1Woi1mY5nBfjl+\n 35jg==","X-Forwarded-Encrypted":"i=1;\n AJvYcCUBFQHBW4bnIuEJeylpKBCKY75vSjCdqTmnenHYf6aRZgaj1Phv0cM1ldKhv3mbPTrpsn+PXXUytBmz@nongnu.org","X-Gm-Message-State":"AOJu0YyQKHfj0fVD/j73x0fdlZ1CmNnKj1vRoxcGsuGyGVQBME/bKSaa\n keRn+OI/whqU/bTLmbh4jF/JTEt6wt367Y5QFoYPkki2OJ9iSDX1YLz97unmZaQHIKA=","X-Gm-Gg":"AeBDievmAOLMqcvjIAcJV4dSmTZFvECPXUcLBtNBP7VBusB68ehN+hByCr+R+Co1dgv\n +iH+hQ5teOrmJL5B4fx0kpVVjhDfozdehX5+dls/5tNecfCcfEPHWIIdcn++GwBOKXygbykGj7H\n 6QU688CxxJQsW6twkiw6mutfhVWTGmpxAcveo6n5yAZkZjX25YgeRFrC7SoCtO5pZX/2AyD4YV9\n k9zl+2S2OwztFVMr//sVZg2L9pyM7wvis7ubpEB3kclw+y4tMWfUYIEXhcBlaZ3REO8VOz1LBD9\n giaL5qujl4duMqzpoENodzA5D//YO4WIKF3u6nUWS30Albv0bh+/19I7ZKSVdbxjjClo539xVNc\n rZZUiDHQBsyOhkGh8ZAfqeChK8g4Rmf4virKG2Keh2+qlcx7AVpvtn2UFT0PFwdcvAd1ApHm9YB\n b8XkAPljfmTSGSYg6ad5QF8H//txIoeTKm07jHsAJyu7wV3P6Lb+3RiXaBOThnnyV5rw==","X-Received":"by 2002:a05:6000:4804:b0:43d:21a:9a44 with SMTP id\n ffacd0b85a97d-43d595cd756mr4119926f8f.23.1775729308741;\n Thu, 09 Apr 2026 03:08:28 -0700 (PDT)","Message-ID":"<68377029-7ee8-4e8d-8ac9-9e278527725f@linaro.org>","Date":"Thu, 9 Apr 2026 12:08:26 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH] qemu-keymap: fix altgr modifier lookup for newer\n xkeyboard-config","Content-Language":"en-US","To":"Dietmar Maurer , qemu-devel@nongnu.org","Cc":"qemu-trivial@nongnu.org,\n =?utf-8?q?Marc-Andr=C3=A9_Lureau?= ,\n\t=?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= ","References":"<20260408091459.4001711-1-dietmar@proxmox.com>","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","In-Reply-To":"<20260408091459.4001711-1-dietmar@proxmox.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::435;\n envelope-from=philmd@linaro.org; helo=mail-wr1-x435.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}},{"id":3676242,"web_url":"http://patchwork.ozlabs.org/comment/3676242/","msgid":"","list_archive_url":null,"date":"2026-04-12T07:10:38","subject":"Re: [PATCH] qemu-keymap: fix altgr modifier lookup for newer\n xkeyboard-config","submitter":{"id":183,"url":"http://patchwork.ozlabs.org/api/people/183/","name":"Michael Tokarev","email":"mjt@tls.msk.ru"},"content":"On 08.04.2026 12:14, Dietmar Maurer wrote:\n> xkeyboard-config 2.37 removed the \"AltGr\" virtual modifier in favor\n> of mapping upper groups directly to Mod5. Since then,\n> xkb_keymap_mod_get_index(map, \"AltGr\") returns XKB_MOD_INVALID, so\n> AltGr-based keysyms were never generated.\n> \n> See: https://gitlab.freedesktop.org/xkeyboard-config/xkeyboard-config/-/commit/473f9bc32f9ba869829cc0d06a75cd1f2560aa60\n> \n> Try \"AltGr\" first, and fall back to \"Mod5\" for compatibility with\n> both old and new xkeyboard-config versions.\n\nMaybe we can go the other way 'round, namely, first try Mod5,\nand if that's not available, try AltGr? This way, \"current\"\nway will be tried first, and \"compat\" way will be a last resort?\n\nBut anyway,\n\nReviewed-by: Michael Tokarev \n\nThanks,\n\n/mjt","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n secure) header.d=tls.msk.ru header.i=@tls.msk.ru header.a=rsa-sha256\n header.s=202602 header.b=sZPw+UAe;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fthYb05Fdz1yCx\n\tfor ; Sun, 12 Apr 2026 17:12:01 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wBoyF-0006W4-Si; Sun, 12 Apr 2026 03:11:04 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wBoyD-0006VK-EN; Sun, 12 Apr 2026 03:11:01 -0400","from isrv.corpit.ru ([212.248.84.144])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wBoyB-0003WM-1B; Sun, 12 Apr 2026 03:11:01 -0400","from [192.168.177.146] (mjtthink.wg.tls.msk.ru [192.168.177.146])\n by isrv.corpit.ru (Postfix) with ESMTP id 1E00E19D60D;\n Sun, 12 Apr 2026 10:09:44 +0300 (MSK)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=tls.msk.ru; s=202602;\n t=1775977784; bh=b3I8f/WbGNwl7pTNhWOEryD9k7VgMyI9KvXlIh82FFo=;\n h=Date:Subject:To:Cc:References:From:In-Reply-To;\n b=sZPw+UAettb/aHIQoarhuANERdHc9mNU94OhhRqwaE497KXJ76aMIWhsrdZzDrh8H\n xFxbTdO5YDjL0OVqTau+J5NNoe8zQZ/ZsaULNPZ2kFhBAzTSuKUHUrLdksr7yF+jlP\n c2xaDiccg/PWyVwe7p9pqUp3Cl9fhUQvkS4LJmnGDjutb/akiFt1B4IBrDpvuoeY3t\n +9Lz8Pkah8XgWlIH+R1PZKKS02S60bN+JOm6XPFnBec/j+ERTT72eQGvp+QwfBnxb1\n wqnm1FjSAnLHKJjy5lYEAyLFWXWMfC29Mjd7tT8FEAq0bSwgGJr9xeFXRClLFV6hWm\n moKVQSMetRBJA==","Message-ID":"","Date":"Sun, 12 Apr 2026 10:10:38 +0300","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH] qemu-keymap: fix altgr modifier lookup for newer\n xkeyboard-config","To":"Dietmar Maurer , qemu-devel@nongnu.org","Cc":"qemu-trivial@nongnu.org,\n =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","References":"<20260408091459.4001711-1-dietmar@proxmox.com>","Content-Language":"en-US, ru-RU","From":"Michael Tokarev ","Autocrypt":"addr=mjt@tls.msk.ru; keydata=\n xsFNBGYpLkcBEACsajkUXU2lngbm6RyZuCljo19q/XjZTMikctzMoJnBGVSmFV66kylUghxs\n HDQQF2YZJbnhSVt/mP6+V7gG6MKR5gYXYxLmypgu2lJdqelrtGf1XtMrobG6kuKFiD8OqV6l\n 2M5iyOZT3ydIFOUX0WB/B9Lz9WcQ6zYO9Ohm92tiWWORCqhAnwZy4ua/nMZW3RgO7bM6GZKt\n /SFIorK9rVqzv40D6KNnSyeWfqf4WN3EvEOozMfWrXbEqA7kvd6ShjJoe1FzCEQ71Fj9dQHL\n DZG+44QXvN650DqEtQ4RW9ozFk3Du9u8lbrXC5cqaCIO4dx4E3zxIddqf6xFfu4Oa5cotCM6\n /4dgxDoF9udvmC36qYta+zuDsnAXrYSrut5RBb0moez/AR8HD/cs/dS360CLMrl67dpmA+XD\n 7KKF+6g0RH46CD4cbj9c2egfoBOc+N5XYyr+6ejzeZNf40yjMZ9SFLrcWp4yQ7cpLsSz08lk\n a0RBKTpNWJdblviPQaLW5gair3tyJR+J1ER1UWRmKErm+Uq0VgLDBDQoFd9eqfJjCwuWZECp\n z2JUO+zBuGoKDzrDIZH2ErdcPx3oSlVC2VYOk6H4cH1CWr9Ri8i91ClivRAyVTbs67ha295B\n y4XnxIVaZU+jJzNgLvrXrkI1fTg4FJSQfN4W5BLCxT4sq8BDtwARAQABzSBNaWNoYWVsIFRv\n a2FyZXYgPG1qdEB0bHMubXNrLnJ1PsLBlAQTAQoAPhYhBJ2L4U4/Kp3XkZko8WGtPZjs3yyO\n BQJmKS5HAhsDBQkSzAMABQsJCAcCBhUKCQgLAgQWAgMBAh4BAheAAAoJEGGtPZjs3yyOZSAP\n /ibilK1gbHqEI2zR2J59Dc0tjtbByVmQ8IMh0SYU3j1jeUoku2UCgdnGKpwvLXtwZINgdl6Q\n cEaDBRX6drHLJFAi/sdgwVgdnDxaWVJO/ZIN/uJI0Tx7+FSAk8CWSa4IWUOzPNmtrDfb4z6v\n G36rppY8bTNKbX6nWFXuv2LXQr7g6+kKnbwv4QFpD+UFF1CrLm3byMq4ikdBXpZx030qBL61\n b7PrfXcBLao0357kWGH6C2Zu4wBnDUJwGi68pI5rzSRAFyAQsE89sjLdR1yFoBH8NiFnAQXP\n LA8Am9FMsC7D/bi/kwKTJdcZvzdGU1HG6tJvXLWC+nqGpJNBzRdDpjqtxNuL76vVd/JbsFMS\n JchLN+01fNQ5FHglvkd6md7vO+ULq+r9An5hMiDoRbYVUOBN8uiYNk+qKbdgSfbhsgPURqHi\n 1bXkgMeMasqWbGMe7iBW/YH2ePfZ6HuKLNQDCkiWZYPQZvyXHvQHjuJJ5+US81tkqM+Q6Snq\n 0L/O/LD0qLlbinHrcx0abg06VXBoYmGICJpf/3hhWQM4f+B/5w4vpl8q0B6Osz01pBUBfYak\n CiYCNHMWWVZkW9ZnY7FWiiPOu8iE1s5oPYqBljk3FNUk04SDKMF5TxL87I2nMBnVnvp0ZAuY\n k9ojiLqlhaKnZ1+zwmwmPmXzFSwlyMczPUMSzsFNBGYpLkcBEAC0mxV2j5M1x7GiXqxNVyWy\n OnlWqJkbkoyMlWFSErf+RUYlC9qVGwUihgsgEhQMg0nJiSISmU3vsNEx5j0T13pTEyWXWBdS\n XtZpNEW1lZ2DptoGg+6unpvxd2wn+dqzJqlpr4AY3vc95q4Za/NptWtSCsyJebZ7DxCCkzET\n tzbbnCjW1souCETrMy+G916w1gJkz4V1jLlRMEEoJHLrr1XKDdJRk/34AqXPKOzILlWRFK6s\n zOWa80/FNQV5cvjc2eN1HsTMFY5hjG3zOZb60WqwTisJwArjQbWKF49NLHp/6MpiSXIxF/FU\n jcVYrEk9sKHN+pERnLqIjHA8023whDWvJide7f1V9lrVcFt0zRIhZOp0IAE86E3stSJhZRhY\n xyIAx4dpDrw7EURLOhu+IXLeEJbtW89tp2Ydm7TVAt5iqBubpHpGTWV7hwPRQX2w2MBq1hCn\n K5Xx79omukJisbLqG5xUCR1RZBUfBlYnArssIZSOpdJ9wWMK+fl5gn54cs+yziUYU3Tgk0fJ\n t0DzQsgfd2JkxOEzJACjJWti2Gh3szmdgdoPEJH1Og7KeqbOu2mVCJm+2PrNlzCybOZuHOV5\n +vSarkb69qg9nU+4ZGX1m+EFLDqVUt1g0SjY6QmM5yjGBA46G3dwTEV0/u5Wh7idNT0mRg8R\n eP/62iTL55AM6QARAQABwsF8BBgBCgAmFiEEnYvhTj8qndeRmSjxYa09mOzfLI4FAmYpLkcC\n GwwFCRLMAwAACgkQYa09mOzfLI53ag/+ITb3WW9iqvbjDueV1ZHwUXYvebUEyQV7BFofaJbJ\n Sr7ek46iYdV4Jdosvq1FW+mzuzrhT+QzadEfYmLKrQV4EK7oYTyQ5hcch55eX00o+hyBHqM2\n RR/B5HGLYsuyQNv7a08dAUmmi9eAktQ29IfJi+2Y+S1okAEkWFxCUs4EE8YinCrVergB/MG5\n S7lN3XxITIaW00faKbqGtNqij3vNxua7UenN8NHNXTkrCgA+65clqYI3MGwpqkPnXIpTLGl+\n wBI5S540sIjhgrmWB0trjtUNxe9QcTGHoHtLeGX9QV5KgzNKoUNZsyqh++CPXHyvcN3OFJXm\n VUNRs/O3/b1capLdrVu+LPd6Zi7KAyWUqByPkK18+kwNUZvGsAt8WuVQF5telJ6TutfO8xqT\n FUzuTAHE+IaRU8DEnBpqv0LJ4wqqQ2MeEtodT1icXQ/5EDtM7OTH231lJCR5JxXOnWPuG6el\n YPkzzso6HT7rlapB5nulYmplJZSZ4RmE1ATZKf+wUPocDu6N10LtBNbwHWTT5NLtxNJAJAvl\n ojis6H1kRWZE/n5buyPY2NYeyWfjjrerOYt3er55n4C1I88RSCTGeejVmXWuo65QD2epvzE6\n 3GgKngeVm7shlp7+d3D3+fAAHTvulQQqV3jOodz+B4yzuZ7WljkNrmrWrH8aI4uA98c=","In-Reply-To":"<20260408091459.4001711-1-dietmar@proxmox.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Received-SPF":"pass client-ip=212.248.84.144; envelope-from=mjt@tls.msk.ru;\n helo=isrv.corpit.ru","X-Spam_score_int":"-19","X-Spam_score":"-2.0","X-Spam_bar":"--","X-Spam_report":"(-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001,\n RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}},{"id":3676329,"web_url":"http://patchwork.ozlabs.org/comment/3676329/","msgid":"<1686f699-ea06-4489-9cf5-d940131fb319@linaro.org>","list_archive_url":null,"date":"2026-04-12T17:23:46","subject":"Re: [PATCH] qemu-keymap: fix altgr modifier lookup for newer\n xkeyboard-config","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/people/85046/","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"content":"On 12/4/26 09:10, Michael Tokarev wrote:\n> On 08.04.2026 12:14, Dietmar Maurer wrote:\n>> xkeyboard-config 2.37 removed the \"AltGr\" virtual modifier in favor\n>> of mapping upper groups directly to Mod5. Since then,\n>> xkb_keymap_mod_get_index(map, \"AltGr\") returns XKB_MOD_INVALID, so\n>> AltGr-based keysyms were never generated.\n>>\n>> See: https://gitlab.freedesktop.org/xkeyboard-config/xkeyboard- \n>> config/-/commit/473f9bc32f9ba869829cc0d06a75cd1f2560aa60\n>>\n>> Try \"AltGr\" first, and fall back to \"Mod5\" for compatibility with\n>> both old and new xkeyboard-config versions.\n> \n> Maybe we can go the other way 'round, namely, first try Mod5,\n> and if that's not available, try AltGr?  This way, \"current\"\n> way will be tried first, and \"compat\" way will be a last resort?\n\nHmm clever. Dietmar, do you mind posting a follow-up cleanup patch?\n\n> \n> But anyway,\n> \n> Reviewed-by: Michael Tokarev \n> \n> Thanks,\n> \n> /mjt","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=KDFvbv/U;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fty8M1zWwz1xtJ\n\tfor ; Mon, 13 Apr 2026 03:24:33 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wByXL-0004LF-4n; Sun, 12 Apr 2026 13:23:55 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wByXI-0004KN-56\n for qemu-devel@nongnu.org; Sun, 12 Apr 2026 13:23:52 -0400","from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1wByXG-0007mE-Af\n for qemu-devel@nongnu.org; Sun, 12 Apr 2026 13:23:51 -0400","by mail-wm1-x32e.google.com with SMTP id\n 5b1f17b1804b1-4887f49ec5aso44506275e9.1\n for ; Sun, 12 Apr 2026 10:23:49 -0700 (PDT)","from [192.168.69.228] (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-488d6864121sm74511425e9.28.2026.04.12.10.23.47\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Sun, 12 Apr 2026 10:23:47 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1776014628; x=1776619428; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :from:to:cc:subject:date:message-id:reply-to;\n bh=2JK7Kl0RfvaSXVCwqzI9oBx4v80TMOjf8l0TSwPpeXg=;\n b=KDFvbv/USSI8fTTlW7F89t0jJKDwX6oAdHEUPLeLtB5RmBotyar/POPVFh3xHgCeW2\n VBhpkKQHxtc143t17NASEzTVIqmPcTn0IvsLIGxyovuItjqcuicmbJKOd/LRd/kI4Gbk\n p0sLbL04uyBOFwODlJaPIm4lujXostYWmZEfSSjZoFgQU8wOdQ1PsXZ+qdFvvWZVASqv\n 8wtL63HB6XCtH70IGbt8iWUScixhwxxNP9Vi1y1Bk0ZYHfZzDyf8xITdevSNJXNxTHPp\n X/A0qFkZu98YBVVZvjAky6nS38Mj2JeMgROaHMV0J5B07OBvWh2WIrOo/jl83CinOYq7\n equA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776014628; x=1776619428;\n h=content-transfer-encoding:in-reply-to:content-language:from\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=2JK7Kl0RfvaSXVCwqzI9oBx4v80TMOjf8l0TSwPpeXg=;\n b=p/T5IaZ8f91CyxIGU1/NI0yh+S6v2En6KCYiJTovnJRg8n9UzkN300UjUSR9PT+xFe\n IIFC9C9FsZHXTPchTwZst4R0/lhS+TNEjvZo7x5JT9ZjPm6ElOrYBKxCTt3FStTC0W8o\n DU9s9TmvTVkSTIaJkXXDWrWshkKPcBQibn+j/F5dn6n2yjBppIcCbkx0T/B4IdzLYdBE\n Eg64k7ypHrWpOSyi5SKruMDi6VKUuhR7y9NogOFppXw+A0ZZYcrem1BkwOlLRgpW8tCt\n h8OMSW+AA1ysQsfOtXnZDJ/H41XITZnnndLtGUwirp9XtAxVr+kbkeUYQ+BsOIi5aw8S\n 8HHg==","X-Forwarded-Encrypted":"i=1;\n AJvYcCWl1LWucy3mQ2LLDSWftw1lIv9uHpD3ZDGRv12bUqLyQNb1CK0+o2zh3L9retjIrj0NmW6Eaol8FbXV@nongnu.org","X-Gm-Message-State":"AOJu0YzeztlVF7ohCXLadr7lpMAnnAOUvaqbDc+3sgPsnB2yvAwsYaDO\n bHIa7eI9GEQBkXJi+AyJyHa7suJiYrap8BjZgC3t7toHkHKq61RwHZqjGFefFssdAOU=","X-Gm-Gg":"AeBDieu688E/7Ch9UGdAioNtgwWc7kgvA12fltt05A8whyo/IxgMkaAoDMYNiHW8OQf\n qXfpQcwmnFgE/rt9eZsNkyhzRlSacThxTsumDgSbRsWBQL9BtZeW7nQIpBfdpvleK3GqOwUclzC\n lV9sH1PkrGXZzuAsISoz60dDgSsv9uEuzrXtDvJ9pvjc8cofTjpCg5pLsu2nTgNt/G8FOTy8vP0\n LHY74GU3oXlJ8/eR1ALGdMYSf2Z4LukeM0SRjlU/R63ICluOdWCrSpFBvuDN7KMwnpR93jaN1Up\n qtK7FDaDHEZWZCKfatJp5zMC05UcQ9Ov+Xqd5l0IpbNk1bP5TEzcw0oZUANgyDGn8wKCJPY5Rc1\n aGUFTw20swGJM/dWMVKqrMopKAkJHpGIipGcLkiqJdvMHQnXNt+54QhYeOZjS8WMlmZ5p5dfabD\n ZDJGqPfU9zf9QHDaaWxBs9n9JaPRPhT5/kTYuy/cxsTNck1OSe34A40pSCRyvH7ted9A==","X-Received":"by 2002:a05:600d:1c:b0:487:2439:b7be with SMTP id\n 5b1f17b1804b1-488d67bf6ebmr112303285e9.6.1776014628107;\n Sun, 12 Apr 2026 10:23:48 -0700 (PDT)","Message-ID":"<1686f699-ea06-4489-9cf5-d940131fb319@linaro.org>","Date":"Sun, 12 Apr 2026 19:23:46 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH] qemu-keymap: fix altgr modifier lookup for newer\n xkeyboard-config","To":"Michael Tokarev , Dietmar Maurer ,\n qemu-devel@nongnu.org","Cc":"qemu-trivial@nongnu.org","References":"<20260408091459.4001711-1-dietmar@proxmox.com>\n ","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","Content-Language":"en-US","In-Reply-To":"","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::32e;\n envelope-from=philmd@linaro.org; helo=mail-wm1-x32e.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]