[{"id":3676647,"web_url":"http://patchwork.ozlabs.org/comment/3676647/","msgid":"<3aa9911b-840a-4284-88ce-c9a5543932a3@nvidia.com>","list_archive_url":null,"date":"2026-04-13T10:56:28","subject":"Re: [PATCH 07/14] vfio/migration: Fix incorrect reporting for VFIO\n pending data","submitter":{"id":84049,"url":"http://patchwork.ozlabs.org/api/people/84049/","name":"Avihai Horon","email":"avihaih@nvidia.com"},"content":"On 4/8/2026 7:55 PM, Peter Xu wrote:\n> External email: Use caution opening links or attachments\n>\n>\n> VFIO reports different things in its fast/slow version of query pending\n> results. It was because it wants to make sure precopy data can reach 0,\n> which is needed to make sure sync queries will happen periodically over\n> time.\n>\n> Now with stopcopy size reporting facility it doesn't need this hack\n> anymore. Fix this by reporting the same values in fast/slow versions of\n> query pending request, except that the slow version will do a slow sync\n> with the hardwares.\n>\n> When at it, removing the special casing for vfio_device_state_is_precopy()\n> which may reporting nothing in a fast query. Then ther reporting will be\n> consistent to VFIO devices that do not support precopy phase.\n>\n> Copy stable might be too much; just skip it and skip the Fixes.\n>\n> Cc: Avihai Horon \n> Signed-off-by: Peter Xu \n> ---\n> hw/vfio/migration.c | 18 +++++++++++-------\n> 1 file changed, 11 insertions(+), 7 deletions(-)\n\nReviewed-by: Avihai Horon \n\nI also tested it with mlx5 VFIO device, similar to your test scenario \n(and some other variations of this test):\nmlx5 VFIO device with 4GB stopcopy size, configured \navail-switchover-bandwidth, downtime_limit too low, increased \ndowntime_limit, migration converged successfully -- exp_down/Remaining \nvalues seem correct.\n\nSo feel free to also add:\n\nTested-by: Avihai Horon ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=Nvidia.com header.i=@Nvidia.com header.a=rsa-sha256\n header.s=selector2 header.b=OTAtr7pL;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)","dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=nvidia.com;"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fvPVy2ZcQz1y2d\n\tfor ; Mon, 13 Apr 2026 20:57:14 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wCEyI-00058H-AH; Mon, 13 Apr 2026 06:56:51 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wCEyG-00057q-Ny\n for qemu-devel@nongnu.org; Mon, 13 Apr 2026 06:56:48 -0400","from mail-westus3azlp170100009.outbound.protection.outlook.com\n ([2a01:111:f403:c107::9] helo=PH7PR06CU001.outbound.protection.outlook.com)\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wCEy8-0006U7-U7\n for qemu-devel@nongnu.org; Mon, 13 Apr 2026 06:56:47 -0400","from BL1PR12MB5063.namprd12.prod.outlook.com (2603:10b6:208:31a::11)\n by PH7PR12MB7353.namprd12.prod.outlook.com (2603:10b6:510:20c::10)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9745.42; Mon, 13 Apr\n 2026 10:56:34 +0000","from BL1PR12MB5063.namprd12.prod.outlook.com\n ([fe80::a0c2:5681:4aca:90da]) by BL1PR12MB5063.namprd12.prod.outlook.com\n ([fe80::a0c2:5681:4aca:90da%7]) with mapi id 15.20.9818.014; Mon, 13 Apr 2026\n 10:56:34 +0000"],"ARC-Seal":"i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=dsIjtIxHwQhRHi+CyNXdSIFJcDc+RlmmL9Tft0wCRlnGrT110fdQxcSK+RlDP/Pty6konGCPJ3y3SfCQWyd6oY3aGgjykDr4hV8Y75TOTgMparC/pQQp9Xg+e2OeCfUmSKjbRSC/Cq42rgWabY+HsgInOYNRDBo1ZZbMGoIPLRFtFl8aIp/3EAbpxrf/YRvG7p2+RIs8P5sg4jZYk+0EdYppk4YfhERx7iQKJ1tUeusAoREkK7DUVbnl4aFnbztItu9hSSyrystg9IT8RAFglbXJ0xuk6KiACIp7ylmFdqAmzF+cjkTbjXm2XrH1OVvJ/oc2HVHDHvNHhTUaBtA8HA==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=YQMTuCSpBzFQiq0j0VxHm9kOSbTMKB35wiZjYRHyTos=;\n b=lWmC20aO2FQrzv5nzcfsQN+ZjoPPUUiw325pmGpF2WtImmU2W5tay11HsTc4zMzXmP+qFJVmwrO2spiXLN4tMsIYEntMb/8HFCQSSzt9NMHVNBUvg3R2dVsr8Q6EfS5sCgXbYQTd+a/qTqz1TTwHnE0yDUknrx1bccmZgY/kaFv0skJcl1TEQe13pPXkvxx07bISjmzfMtcDhrY8nhs4JNYceSQhxVch5VQgzIw8osOIYrXtTL5Pu04YLfNh3YhWrZkeF5IZ8d4qxSGohF9Vt5djxHviF++wnpoEwJO/dnoPyuOPBET/tFiKoFRm5oVbTuNXDKqjrjCJtCtZYD9lSg==","ARC-Authentication-Results":"i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com;\n dkim=pass header.d=nvidia.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=YQMTuCSpBzFQiq0j0VxHm9kOSbTMKB35wiZjYRHyTos=;\n b=OTAtr7pLCXJ0rprHe+geNIZhPolBY43V+k/wWQ2bIaDvZWCl7HlJMSLUXSNcdXqiecclYcCjkbTMw/cxPdXHbHGBw1BeWw7gf8evk1hoqdDFVRIU5qHtMxDcq7lPuOn8o2AfHUX1E8ueHizGX5I94kxRlO+i1tX9KamTlI5O08fh61a+/O+r95aqW3QzSPC3xBtPe/+5lTduQmnOghKGGOzTg2sVLzYYmEv91LdMLIsbwKkjD5rdfpScboxlzLHSNgOBqwJnqQnE7tVQk4PXj7BhtSZaDc7rNz828RgPKSx+uesmH5bhgy4d21ILjbApb2Eff5ycSbCBWXud4US+xA==","Message-ID":"<3aa9911b-840a-4284-88ce-c9a5543932a3@nvidia.com>","Date":"Mon, 13 Apr 2026 13:56:28 +0300","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH 07/14] vfio/migration: Fix incorrect reporting for VFIO\n pending data","To":"Peter Xu , qemu-devel@nongnu.org","Cc":"\"Maciej S . Szmigiero\" , =?utf-8?q?Daniel_P_?=\n\t=?utf-8?q?=2E_Berrang=C3=A9?= ,\n Zhiyi Guo , Juraj Marcin ,\n Prasad Pandit , Kirti Wankhede ,\n\t=?utf-8?q?C=C3=A9dric_Le_Goater?= ,\n Fabiano Rosas , Joao Martins ,\n Markus Armbruster , Alex Williamson ","References":"<20260408165559.157108-1-peterx@redhat.com>\n <20260408165559.157108-8-peterx@redhat.com>","Content-Language":"en-US","From":"Avihai Horon ","In-Reply-To":"<20260408165559.157108-8-peterx@redhat.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-ClientProxiedBy":"TL2P290CA0016.ISRP290.PROD.OUTLOOK.COM\n (2603:1096:950:3::18) To BL1PR12MB5063.namprd12.prod.outlook.com\n (2603:10b6:208:31a::11)","MIME-Version":"1.0","X-MS-PublicTrafficType":"Email","X-MS-TrafficTypeDiagnostic":"BL1PR12MB5063:EE_|PH7PR12MB7353:EE_","X-MS-Office365-Filtering-Correlation-Id":"624f6e84-f217-4dff-2da0-08de994b53f7","X-MS-Exchange-SenderADCheck":"1","X-MS-Exchange-AntiSpam-Relay":"0","X-Microsoft-Antispam":"BCL:0;\n ARA:13230040|7416014|376014|1800799024|366016|22082099003|56012099003|18002099003;","X-Microsoft-Antispam-Message-Info":"\n QWExCpgIHNY20cHS6ewkY7+XSioLAxpDZs7+Pmp6zSRpNQw9d57SzLvTREqQzdYFfkHbiHiHm6eis82F0GJmcKT2QTneFC3hZtrneRlnYcSFp0UX9bqAD7h/v+xxN70o9z86BjLivs9eh4qs8C415UdsLFGKfQEPddhgDmCv+yrDhvc5KnEJoi9wJ97MVyyyZVBj1qTFzJ/Qww6MmXxTF17aVKx1upu8ndfdDJjgYXy9H0S+1kz8kmDMlYSOXJ5zbmzazSdFjyyffpI7xySGF4Q8LLhsYsD/LIm6XLUjK3TL4GFaSGkoms25dyIgMl4/CkDN3wC0D2eTF52OgVUPJRWCuQdH8FL0XEoVM5YwFmpMbf/FSbVTbMjc5dgFX4HFPoz+woijFRyM5gVIitXMHTXXv2F4SOA3Ua54Cwx0TFW3QjYZOC/QF/eF2HZPDs106cD2gNZoE0Ld9AaLT3hhM/GqJNf08Fe9CCUbexhM6SLaQgl6ECRopnX+mWQNL9cAhFmbHelRud8evWadnD1QB2+sjcZ4iiF6NbFLd2TtzZkD0aqa+qH5w6ozNsQZg70HJN24GqxyRTOPZRydNkR4C2iryjg5gUTO5iWwK73VQ7golYesRNUZiD1Us36NnpX6Lmparv/gDrZsi8Tzn6z58d9ncEQJwI5BwByzMQdk8W4T9Av5Bnnp5LIP5Xcshzmo2XZYJgrJX0d3d8Y7PInFB3IlZs6RyKXIl4mWjDBp4lM=","X-Forefront-Antispam-Report":"CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:BL1PR12MB5063.namprd12.prod.outlook.com; PTR:; CAT:NONE;\n SFS:(13230040)(7416014)(376014)(1800799024)(366016)(22082099003)(56012099003)(18002099003);\n DIR:OUT; SFP:1101;","X-MS-Exchange-AntiSpam-MessageData-ChunkCount":"1","X-MS-Exchange-AntiSpam-MessageData-0":"=?utf-8?q?FZqa1NJWBEpzdZiB5IMACBvuqmvh?=\n\t=?utf-8?q?zUmR8Q80p667Y3F/XOeT+/enoll6dXNj/67VJwpvmQjjeLsA53tlQJHK8i1w349ZD?=\n\t=?utf-8?q?xBZghEgjjSwHROvmOvBmRr3qrYHRxDuCnbua8il84og4minv5f+J+keKc0OEPvCXx?=\n\t=?utf-8?q?1KP7m7dujoXp3/yJE9ZiZ44rO1hufAOTY8FjFwyFxU+Gdzg3n9nUs/8vGXQ3t1dcA?=\n\t=?utf-8?q?mKhTvqX84WhwVbkZ1qTrH1nXzfsdmiqFyaWVHV6LQtYEKeWZZpGazKiDQoQW3zO5Q?=\n\t=?utf-8?q?Vb9rQT0Pu+vKNKCgHxRvCWD6M2Mx51r0Qc2xUGgm1nvxHdnb6jXBCQ0GsQX18k74x?=\n\t=?utf-8?q?VWaVVFeuEs/TDiUoikP8Y58oyBByVwQmoFPaF4Gjx4u7IQfTvEuSvpkiof6zGSaQ4?=\n\t=?utf-8?q?8bSiPxMuSiE/Gm8cpNuTclReUA7iYwbyPPBVCDke9ayvWX9m4Wd06nR62jgFz7/c9?=\n\t=?utf-8?q?8vtl2G3pm5YFOO3kup0W5IfxIrorWJiIxxc8mJTyBUSE1pgnVSURtqXJ465+CT1js?=\n\t=?utf-8?q?Ea2CzDinVs2uwNDJwy5EQfdHNODzTpmf8p8My0mW0ku99GoyJOqxmflCLcZ506Tcc?=\n\t=?utf-8?q?flbNvTj+vRXjpQbqGIq5re8K/9PlBrbSS3qqpmxbipR125jSaXJcSQ6q1AcC5lO7t?=\n\t=?utf-8?q?ay3Q9qgS2ReTffEL5e3LhWGqOSWcjBHL/LHIi9s6ZC7EIyBMS1ExgPFFBL7WK93cR?=\n\t=?utf-8?q?ipBYeH2sKOitLly5P3uvZlm7TYsYoPGZlYfoca2KLEY4gp85H6LQPdprsDNfSKMGV?=\n\t=?utf-8?q?fMc+8M3ZdYWd01+HordzlEupUIida9g5y/ruMspMI/tCS8A4ma5FtCSMZYjqmujTd?=\n\t=?utf-8?q?OOurZYFP8GdRk/hNBZa5m7zAKmLDVEMmJGWXIDUq2PO5J3qhHXI3nQUNiQmGLS/Qi?=\n\t=?utf-8?q?/PZsexi0FK1aQLwuKL1OHwzsJ2R1UWa+4Mzsg2JM5VbrJLvn9yk4/VUXzK4jwTCRQ?=\n\t=?utf-8?q?l+nvgwy2g0bTA2px5Pp8ik95JoIC3s4G5fShzEk2B5PvjMNnfPT6JRJtgqq0EcyIi?=\n\t=?utf-8?q?4RAotypncEsCFMXVW3KemQHVNG+O1bFmixb5Sk8NIR0vnojQW4/qvlwuiYahk1Kq2?=\n\t=?utf-8?q?39Tkn4tCBFkdciVqgGGfMk574ma6knXcP0pucXOAqFD6eTxIE3ZBBQI4y+YwqoA1C?=\n\t=?utf-8?q?7835WtmnoZsAAW/BlC2EfAPl/EmU/wKas/i3rjSWwri2zRF7ENZ5Yao11SqE36wZV?=\n\t=?utf-8?q?DuVpFQ2XF0RUMMibnjb0On8dU6QAlauDJD9P9Po4PSXSZSV1bDR6EUW4uMAXwyrjD?=\n\t=?utf-8?q?ebu4Hgf5prwVGiudbeAMLJU/2ur7iAdqc8DnipNAjDjTuVbHtSK6GPwAK9yOlvLM0?=\n\t=?utf-8?q?7tlT/B2MkQNDRvjUy+QiugXy1BZHEK2knu5kEgWegzRwBv16oRdTjNMQviVOsRCMH?=\n\t=?utf-8?q?HoQ0fvnD10dxJEfnww4r89yaBqunCrjpywLarba+VOIgvvzv9K1E+HPiX8Ci/GKAI?=\n\t=?utf-8?q?e6I5fF8UzdPtK6Frl0dxd2Mh2Lw2AvW6EwJ7uqCiWdw4UqXKpKoyYMUOuuR4ZEetJ?=\n\t=?utf-8?q?+yCqzCT7ntjwbGV2axcFdAo8O4NszFbWxJOmM/ytHyYMopJXDbIGmxtBDK0Nc6ndS?=\n\t=?utf-8?q?ODWKEzM9Mb9sbqqqAoElKjPyP/YFjyTV1pv2r9SSazIwtJJ4PpVUD3y1SI+PmRc5F?=\n\t=?utf-8?q?uP34M+lbc/95gqW5bM5FYHepuq+aORrA=3D=3D?=","X-OriginatorOrg":"Nvidia.com","X-MS-Exchange-CrossTenant-Network-Message-Id":"\n 624f6e84-f217-4dff-2da0-08de994b53f7","X-MS-Exchange-CrossTenant-AuthSource":"BL1PR12MB5063.namprd12.prod.outlook.com","X-MS-Exchange-CrossTenant-AuthAs":"Internal","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"13 Apr 2026 10:56:34.4941 (UTC)","X-MS-Exchange-CrossTenant-FromEntityHeader":"Hosted","X-MS-Exchange-CrossTenant-Id":"43083d15-7273-40c1-b7db-39efd9ccc17a","X-MS-Exchange-CrossTenant-MailboxType":"HOSTED","X-MS-Exchange-CrossTenant-UserPrincipalName":"\n bpOpy08O9hHoxeAiWewOjAglTa9yRgekrXR6z9xvQT8VfXb7Da7PdPuoRotzFjCuycrEhe0bGVMhE5/OT4UN5A==","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"PH7PR12MB7353","Received-SPF":"permerror client-ip=2a01:111:f403:c107::9;\n envelope-from=avihaih@nvidia.com;\n helo=PH7PR06CU001.outbound.protection.outlook.com","X-Spam_score_int":"-25","X-Spam_score":"-2.6","X-Spam_bar":"--","X-Spam_report":"(-2.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.54,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]