[{"id":3676624,"web_url":"http://patchwork.ozlabs.org/comment/3676624/","msgid":"","list_archive_url":null,"date":"2026-04-13T09:59:23","subject":"Re: [PATCH 05/14] migration: Use the new save_query_pending() API\n directly","submitter":{"id":84049,"url":"http://patchwork.ozlabs.org/api/people/84049/","name":"Avihai Horon","email":"avihaih@nvidia.com"},"content":"On 4/8/2026 7:55 PM, Peter Xu wrote:\n> External email: Use caution opening links or attachments\n>\n>\n> It's easier to use the new API directly in the migration iterations. This\n> also paves way for follow up patches to add new data to report directly to\n> the iterator function.\n>\n> When at it, merge the tracepoints too into one.\n>\n> No functional change intended.\n>\n> Reviewed-by: Juraj Marcin \n> Signed-off-by: Peter Xu \n> ---\n> migration/savevm.h | 4 ----\n> migration/migration.c | 16 +++++++---------\n> migration/savevm.c | 23 ++---------------------\n> migration/trace-events | 3 +--\n> 4 files changed, 10 insertions(+), 36 deletions(-)\n\nReviewed-by: Avihai Horon ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=Nvidia.com header.i=@Nvidia.com header.a=rsa-sha256\n header.s=selector2 header.b=WncToKG7;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)","dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=nvidia.com;"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fvNFC6Bp3z1xtJ\n\tfor ; Mon, 13 Apr 2026 20:00:15 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wCE52-0003sz-1Q; Mon, 13 Apr 2026 05:59:44 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wCE4y-0003sZ-Cz\n for qemu-devel@nongnu.org; Mon, 13 Apr 2026 05:59:40 -0400","from\n mail-southcentralusazlp170130001.outbound.protection.outlook.com\n ([2a01:111:f403:c10c::1] helo=SA9PR02CU001.outbound.protection.outlook.com)\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wCE4v-00033N-S2\n for qemu-devel@nongnu.org; Mon, 13 Apr 2026 05:59:39 -0400","from BL1PR12MB5063.namprd12.prod.outlook.com (2603:10b6:208:31a::11)\n by SA1PR12MB5670.namprd12.prod.outlook.com (2603:10b6:806:239::9)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9818.20; Mon, 13 Apr\n 2026 09:59:28 +0000","from BL1PR12MB5063.namprd12.prod.outlook.com\n ([fe80::a0c2:5681:4aca:90da]) by BL1PR12MB5063.namprd12.prod.outlook.com\n ([fe80::a0c2:5681:4aca:90da%7]) with mapi id 15.20.9818.014; Mon, 13 Apr 2026\n 09:59:28 +0000"],"ARC-Seal":"i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=idTcS8m6gvOP4UbM+blMa6cBWz28dU3k4uh6djevG95a1nuDU0gbzEVouHP6XYet6xMPe9imjpvR6c+i/Xu6vzz8ZisMyV9kbyION5e6l9QuLT8LofsvSxroIyoAAfrF76KFCabApXRtb+pO0SSfJeiOqD++46ZKgudgveZc1sqBHJlowt+72WHTWfqBQt/a+1eLMMUMlR/TzC5EjKIu0Lgz9zP5pqcbzYNwBSeqTwe8IuNl3w01sLvGTxvm8c44obnsB7wKyPUQmLce1rYurjm60Dyo00bAAjh796cGTMV7BrjqzTRry2VjiuMzNFC1HvcHjiFQiOxFtE6UJIeVVg==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=I3VjBGi9/jAFcra/3KlJO1uzf3tt4B6/gLD4tsznKXc=;\n b=kEgbGACqqFB8t8EcsD2iN//7ua3u3dPUbjyYFc+KRk/DehURoAjhl+mf+6PBBMxcqqeES7KGueo5JivIBMJ/zrgExfToPAoeTRNum1SV/T7ya5cQwT6UzmC+hqgvuKhWax79gSTDjdRYLXntC8zpXkENjxQLtWIFEcYZoIo8fZ2X7jidEwNvjoz63jBBX7RnfNeTc+G2Hp6XtIJMVEIoc3lzc+/0Oo6je7ffkZ4Bc0Du1rg1Cyyig83CisTAe118ffwCXl0JROgee/rsHsItopw6lLna/ygtiP+NN8mJo1p2rzX9WGFhEM/lToYP2Wfq/44tbtA+kzuq2EyYKDg2Rw==","ARC-Authentication-Results":"i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com;\n dkim=pass header.d=nvidia.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=I3VjBGi9/jAFcra/3KlJO1uzf3tt4B6/gLD4tsznKXc=;\n b=WncToKG7LGWbunPDUJED8TB7Om493mUsf9B8lLHpvrIlqv4LmVSV/V2nH24TLrvWzhS6YMtWu9dLkK51xCfFkZUoAvCK2ZtkKwCiXDUqg1FhQ4Z1htUzMwxbOzUWuaRqgUGuH6nyy4ANBUUos8jTMLTj2DcMILuPG3V3vgM0rsIcsPYR6I2iGhLzcvgKwrQR1r2hMH9uDx1fcQ1r9mJtENgkbAGWwY7k14A6WzHPZllqQ8cRKcodyupFpbYxsVXYVK2FU0zEIT1bAg+Lph7wJwr+T88BKx+4MYH42N+V32cb1N6Lm1+wHR3W7nY5SFwFRIIb7nsAIg2vklUw/5PPaQ==","Message-ID":"","Date":"Mon, 13 Apr 2026 12:59:23 +0300","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH 05/14] migration: Use the new save_query_pending() API\n directly","To":"Peter Xu , qemu-devel@nongnu.org","Cc":"\"Maciej S . Szmigiero\" , =?utf-8?q?Daniel_P_?=\n\t=?utf-8?q?=2E_Berrang=C3=A9?= ,\n Zhiyi Guo , Juraj Marcin ,\n Prasad Pandit , Kirti Wankhede ,\n\t=?utf-8?q?C=C3=A9dric_Le_Goater?= ,\n Fabiano Rosas , Joao Martins ,\n Markus Armbruster , Alex Williamson ","References":"<20260408165559.157108-1-peterx@redhat.com>\n <20260408165559.157108-6-peterx@redhat.com>","Content-Language":"en-US","From":"Avihai Horon ","In-Reply-To":"<20260408165559.157108-6-peterx@redhat.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-ClientProxiedBy":"TL2P290CA0024.ISRP290.PROD.OUTLOOK.COM (2603:1096:950:3::8)\n To BL1PR12MB5063.namprd12.prod.outlook.com\n (2603:10b6:208:31a::11)","MIME-Version":"1.0","X-MS-PublicTrafficType":"Email","X-MS-TrafficTypeDiagnostic":"BL1PR12MB5063:EE_|SA1PR12MB5670:EE_","X-MS-Office365-Filtering-Correlation-Id":"7ffba8de-7e4b-4de8-704c-08de99435a00","X-MS-Exchange-SenderADCheck":"1","X-MS-Exchange-AntiSpam-Relay":"0","X-Microsoft-Antispam":"BCL:0;\n ARA:13230040|376014|7416014|1800799024|366016|56012099003|18002099003|22082099003;","X-Microsoft-Antispam-Message-Info":"\n hemamWvQb1SiNxRTqhegKDy1D23xIwj9kvFClRHMNHy2ltddt6G7NXT3DAqPFB6aIX/sezdV45munIamLe4rNRH2SZPP/d4H8dAdaGx5D3cc3RjxR721v4nGZ5AO/KaPyQUpdq3BIMqbA255KkIwaTorOMWXN6TsrebLeQbZB6C7PQdpJWEOSPbQ9V8JBjvi+37tFLWHiN8T4HXMOljA383hube7m87ffHMn9pDUWgvlbuPOKnkFjPwguwf1/cY6IwafCxHc42B37eiM9WwfQ+CUM1Ra0n7j/2/nzR2ADFsMqTt0GSpyV6QIIq+0TnEjVWfy6q6NH+iW0dMgDQ0onFY5RLHPPhJITrp1zSHt9KAyEYmWiAcTr/lKhwuMGrB1n+1qwgNQk0FaL8mFdPrSophC+iEv9PptGJU4JpdFO9G6dS1NDRT9MkOUrmIcW5R/bZP0Wr8VD6k+wWfdiCkWYVsTEPdvjuSLZq9XUhXT2CkiKK5l4sX0sLX5KTK2QRuVY+TXQjEDBO4IYwYysjb928XFgYtbAPW++z3Mpzs2szYMhUR7VFWY+hOp2cEp+X1rWceNEs7X29o+/4KAQJZoa5vfyFi1Tc8Vn+L6jjmmWZMIn8dzgtY+dC/JXOGzeNem5rnWRO2UfvYHdwjD6v59qv1GFncX2GdmqZ5jPnmRUx8rR/QkznUfV3fxKpB0zRP+60Vyk04JlFc7MZqP3vjySu342omzrlcsAy16+SZRQ0c=","X-Forefront-Antispam-Report":"CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:BL1PR12MB5063.namprd12.prod.outlook.com; PTR:; CAT:NONE;\n SFS:(13230040)(376014)(7416014)(1800799024)(366016)(56012099003)(18002099003)(22082099003);\n DIR:OUT; SFP:1101;","X-MS-Exchange-AntiSpam-MessageData-ChunkCount":"1","X-MS-Exchange-AntiSpam-MessageData-0":"=?utf-8?q?wd+a2P5tD439hfJNssenIwChyETn?=\n\t=?utf-8?q?b9g3pdlR7kCkFINCo920juj3PEJ/hYef1fvL9odwt3UUlhmw8t9BtUf3QbYK4NBZM?=\n\t=?utf-8?q?6WWZ5+5xAX5HhgVlfvK3WE9ViffIUl0Z7cc6AJ/hQWBhyFz1J0GW/aLUkgrbvENkb?=\n\t=?utf-8?q?u3oxOhk7g0M0H+XWfuAo6jMLkg/XWajKkcUMIQKe7O78rIOWU12R3PHiIUFly3iLE?=\n\t=?utf-8?q?j0aJXMwwql/jO2RsieF1JqwBzYqLqAg8pKCylDeOd/lsmzuC11wvT5d9gtvHiaxcp?=\n\t=?utf-8?q?7KTYIb1DBHpoB6JPkI/1efQkwWm0MJFQFUL0HeCooUvzA0r3ZxEqfU4BSY5WDuMLM?=\n\t=?utf-8?q?vOYCJB8Kxb5pfdFzN2tjeWdr0I0qcDlTDBFcQutOvUU3swD/QQTKHX02+sy2Z3rPQ?=\n\t=?utf-8?q?loYpFVhOqX3pxXfeYDd1teedoQYol5OjA7A7kWtFObQSgGvFN63HpfDqTPIFkMWX6?=\n\t=?utf-8?q?W4DK2sMiOPqe2tNkhzux6JxSmTgW2qxaIeQvoqxUVh+IGG9gfLiQZLDmvtCIBNGR1?=\n\t=?utf-8?q?MRsvYi21tOCINKX3XKgQDWgwO7Gk5C+oinM5QgXtJCIqxMlZdQOFiN+CCs/sDOJ7i?=\n\t=?utf-8?q?cYHU2gIE3AtIWQhUVMl9/kOHKliR59+McQT6zO8E8nFohKejoDgv/1hC++PKqj2dl?=\n\t=?utf-8?q?E/0tUAG+AGqDdPRRwsA/C2EEQdHWwb+wxyPpvC4lb0ndUBmSLLsxDaMHjSBoKWPhA?=\n\t=?utf-8?q?Qw+zJg/pvBcuO9fpotWLYy8q/BPe8dnzST+MqhxG/aBwaRNnXr+JF0Z2MqWCDNL9l?=\n\t=?utf-8?q?ix7mk0i+qwio/3rNyeC7adpzsUMT99wM4uWGFEBAuALaQNueT9kADYw2aeOO5sIaO?=\n\t=?utf-8?q?qDZubMke+xxh1E6xNxqLsMTAGYh7T15iwaFJqkJGeOy8xzzPn5bGfX/TmQZ1YSCVc?=\n\t=?utf-8?q?4g1ie2ISuiPFaAF+GS+Nd9YTKNVUa1iZmD7fY8lI6ZjMLUUPFfpLwzmvfQm9x1ltx?=\n\t=?utf-8?q?eOaC2eI5H6rL8GFYQLYq/dGthqmUPRIvIA+1mcoHTx6RAXTbnGNBjtW0BdgRpOmwa?=\n\t=?utf-8?q?PBsJvDbGMGsSRq6+vRvAazPIZFFPwU4WpVwa5MQniY9+3uTSIXRat7O1tB4YNzduC?=\n\t=?utf-8?q?/baHE+KEF2ZkwrvZfhaHsyAbszcNE/38bg08idnDO1cxHX69rvGQBuDpQYDgTpxDv?=\n\t=?utf-8?q?6ZS0wfw8U3LylvSTvq2a5GNKbY0Nu/jKu/cGcNJtCBFRkMZWcpmJaQRKzojdxx3F4?=\n\t=?utf-8?q?QByiHvuI0E0PAAbR+JlQL6pBSENuBGJvIaxtTQ42VjThES8XRiDkNjilY5pmq4rwa?=\n\t=?utf-8?q?MT6ViC38Bd5Vd8fvyqqWP/kYvVKFPuKQB+YaI6Kb6pW2HfTLsZ7N1VXX9MOmrUuOt?=\n\t=?utf-8?q?610jUHKFV43Y7CHkCvaoL16RhYjipVeZXfQGHHyXiR2gARXyk5VEN1DIt6Dt2nvHR?=\n\t=?utf-8?q?Nv45MSutTEJqgNMrr4Vr7dODdfG63Sj0OGbFWL4oVQMGFwbs4Yfp+fu4l3u0A9iaS?=\n\t=?utf-8?q?VVupLYLD2gASDMMbrlzJpDNeQjnuFwtlIcl0n6VCuf5LVa2S7GqXb4aAnhbIVM2A2?=\n\t=?utf-8?q?HG7VuptFGekOqo1IhkGt0QE53MIERdf0CTkvaGwZrHCrcTpGR3lQFzXc4lOhR58bG?=\n\t=?utf-8?q?xL8WjnCxE7GnRHtsRN2I/jhmkBmO7e1zgZOR8STI3dh2dJOoaT1Xv09B13IMY5jkL?=\n\t=?utf-8?q?CnCbBKH3bqNi25VBqo9+VHHUAlzmPBVw=3D=3D?=","X-OriginatorOrg":"Nvidia.com","X-MS-Exchange-CrossTenant-Network-Message-Id":"\n 7ffba8de-7e4b-4de8-704c-08de99435a00","X-MS-Exchange-CrossTenant-AuthSource":"BL1PR12MB5063.namprd12.prod.outlook.com","X-MS-Exchange-CrossTenant-AuthAs":"Internal","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"13 Apr 2026 09:59:28.7214 (UTC)","X-MS-Exchange-CrossTenant-FromEntityHeader":"Hosted","X-MS-Exchange-CrossTenant-Id":"43083d15-7273-40c1-b7db-39efd9ccc17a","X-MS-Exchange-CrossTenant-MailboxType":"HOSTED","X-MS-Exchange-CrossTenant-UserPrincipalName":"\n 15FG+52BKRuQovv+YyBdQZT+TppOq3clAfKrDEVEl6lCR+5f3qJIXdo7aAEWHPeK7oQD/UfWWlBS1IAHNd7iSw==","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"SA1PR12MB5670","Received-SPF":"permerror client-ip=2a01:111:f403:c10c::1;\n envelope-from=avihaih@nvidia.com;\n helo=SA9PR02CU001.outbound.protection.outlook.com","X-Spam_score_int":"-15","X-Spam_score":"-1.6","X-Spam_bar":"-","X-Spam_report":"(-1.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.54,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n FORGED_SPF_HELO=1, SPF_HELO_PASS=-0.001,\n SPF_NONE=0.001 autolearn=no autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]