[{"id":3675514,"web_url":"http://patchwork.ozlabs.org/comment/3675514/","msgid":"<9e3d8ee8-0988-48dc-8cd9-938a21c7dcb2@linaro.org>","list_archive_url":null,"date":"2026-04-09T21:00:40","subject":"Re: [PATCH v4 3/9] hw/hexagon: Add machine configs for sysemu","submitter":{"id":85046,"url":"http://patchwork.ozlabs.org/api/people/85046/","name":"Philippe Mathieu-Daudé","email":"philmd@linaro.org"},"content":"Hi Brian,\n\nOn 8/4/26 06:21, Brian Cain wrote:\n> From: Brian Cain \n> \n> Some header includes are modified here: these are uniquely required for\n> basic system emulation functionality and had not been required for linux-user.\n> \n> Acked-by: Markus Armbruster \n> Co-authored-by: Mike Lambert \n> Co-authored-by: Sid Manning \n> Signed-off-by: Brian Cain \n> ---\n> MAINTAINERS | 2 +\n> include/hw/hexagon/hexagon.h | 150 +++++++++++++++++++++++\n> hw/hexagon/machine_cfg_v66g_1024.h.inc | 64 ++++++++++\n> hw/hexagon/hexagon_dsp.c | 161 +++++++++++++++++++++++++\n> system/qdev-monitor.c | 2 +-\n> target/hexagon/translate.c | 1 +\n> hw/Kconfig | 1 +\n> hw/hexagon/Kconfig | 5 +\n> hw/hexagon/meson.build | 6 +\n> hw/meson.build | 1 +\n> 10 files changed, 392 insertions(+), 1 deletion(-)\n> create mode 100644 include/hw/hexagon/hexagon.h\n> create mode 100644 hw/hexagon/machine_cfg_v66g_1024.h.inc\n> create mode 100644 hw/hexagon/hexagon_dsp.c\n> create mode 100644 hw/hexagon/Kconfig\n> create mode 100644 hw/hexagon/meson.build\n\n\n> diff --git a/target/hexagon/translate.c b/target/hexagon/translate.c\n> index ae980c087f0..15258a203b3 100644\n> --- a/target/hexagon/translate.c\n> +++ b/target/hexagon/translate.c\n> @@ -32,6 +32,7 @@\n> #include \"translate.h\"\n> #include \"genptr.h\"\n> #include \"printinsn.h\"\n> +#include \"exec/target_page.h\"\n\nWhy? Rebase left-over?\n\n> #define HELPER_H \"helper.h\"\n> #include \"exec/helper-info.c.inc\"\n\n\n> diff --git a/hw/hexagon/Kconfig b/hw/hexagon/Kconfig\n> new file mode 100644\n> index 00000000000..7b9577f68f7\n> --- /dev/null\n> +++ b/hw/hexagon/Kconfig\n> @@ -0,0 +1,5 @@\n> +config HEX_DSP\n> + bool\n> + default y\n> + depends on HEXAGON && TCG\n\nNo need to check for TCG.\n\n> + imply PTIMER\n\nUsually you want \"select\" here, not \"imply\", but\nI don't see any PTIMER code being used.","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=jnlrsQm5;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fsC5f3kP0z1yGd\n\tfor ; Fri, 10 Apr 2026 07:01:08 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wAwUa-0003hv-Rf; Thu, 09 Apr 2026 17:00:48 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from ) id 1wAwUZ-0003h0-3F\n for qemu-devel@nongnu.org; Thu, 09 Apr 2026 17:00:47 -0400","from mail-wm1-x32d.google.com ([2a00:1450:4864:20::32d])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from ) id 1wAwUW-0003ov-VO\n for qemu-devel@nongnu.org; Thu, 09 Apr 2026 17:00:46 -0400","by mail-wm1-x32d.google.com with SMTP id\n 5b1f17b1804b1-483487335c2so14435025e9.2\n for ; Thu, 09 Apr 2026 14:00:44 -0700 (PDT)","from [192.168.69.228] (88-187-86-199.subs.proxad.net.\n [88.187.86.199]) by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-488d531f229sm32408275e9.3.2026.04.09.14.00.41\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Thu, 09 Apr 2026 14:00:42 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1775768443; x=1776373243; darn=nongnu.org;\n h=content-transfer-encoding:in-reply-to:from:references:cc:to\n :content-language:subject:user-agent:mime-version:date:message-id\n :from:to:cc:subject:date:message-id:reply-to;\n bh=xtdJaWoXSge7ijuVyU6eWPI/LUrb/2r/ZVbci45zRak=;\n b=jnlrsQm5i2ahiSpLxMnb4s+l3L0nOCNio9LnNwPacEDnBw+2K6zHBZszr0/FF3zY3F\n C7F0LS/N128qnnm0x4UIvmHIUeImzu/xk4+nD7Hh9BZN9/yqkMhRCqiE+UynkexUSrXk\n lT4ulnz4xAmk9ttqIcETy1V+D3Ea2Gs4pnbHsuaWw+8M77phl6MLV+Dx44xO8aHyJAda\n SR/qRLQV/SnWDw+ea6OapSNo2ESIaI57muo9S2ozFc4XUnx1OmJ/DgXuo0NwEC52DcYF\n 4fJt/bvyx8+SH+F87YeYnQVfZZuj8C0brsMGP+z+6kwRIoFuJFsCbmErhMbpsxAeyCTf\n 20cg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775768443; x=1776373243;\n h=content-transfer-encoding:in-reply-to:from:references:cc:to\n :content-language:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=xtdJaWoXSge7ijuVyU6eWPI/LUrb/2r/ZVbci45zRak=;\n b=hwKz28LXmpKCDwzGS4RABdi4Kmd9YecUy391b62xIVQUYro6YEJ9p/02CcS0+SCTBy\n wGO9oDXpqMA6RU93FTiro6q9VzI9j33hsWaTmCSYbEe+goyBj7TGTSLSMx3EJXE1zmAe\n o5K9LfbPl4ZOcLBtimfIm5xIpzhX2KUPvf3F83gH39CcaAsYGUdHBX87wckADBhCp4o8\n s2GTZ/Zal3gKmEgchLmyrQ1BB1cDnQAZUsHVXnSj0jMlPcU4uGuQ6Dw6wLkUpgwX8fIs\n TemMjDOXre6cN9qdfMTqT6mKCjwEG2hZbyic6QbflQBvEjNhNS/n7eRHjSPrKdh30JG5\n +q/Q==","X-Forwarded-Encrypted":"i=1;\n AJvYcCV6TFiDmN0HsGb7IP3l6ck9fq/hUNyJ0kgdqlCETiBP6JENho+Tidl6NobQZ+iDkoZHCAjEscPfKaex@nongnu.org","X-Gm-Message-State":"AOJu0Yx4bRR8H2Tg49zm4o74GXe8wzjGxdBRNFNeydWq32nSc1XPR3WN\n yUsJYCipbSB9DP8ngkQJU0T7SwDVnJDjqWYaChcryHphLVwW45Ugyi1z9t00Jn8SiR4=","X-Gm-Gg":"AeBDiesW3GTZuD/6IS2RgQAE4CmJg9spIJ8UWhHZHZ+D0xJITzS1tf8MwbZde8t9fJy\n jmybGEw7ojLm2qPUg5NHek48FNXAey4encgyXx4M5C4M9ue5fzo7DkB2/Nw4soEk1ViEmgXCNCP\n ZPuibXmRhAXL1zstaNNXl3iVXsbjSqKQiwk4AnSzrIfdnYiib5oVpIvWx3K7eCeK4Lgnp6IQzR+\n sz36gmu2M9rUTBFbCi8AoA44+qMzyDT9HOt0JiU000jHUAKl3xZt/lzvEjeYb26gXFkAsGjLJxA\n tsJAvWm+EfBWBMoI3BuN31LSsofdTWNtVaGEg6Gp+/msBeXDQqIV0ozmbgleNLZjSaZVlzizHAD\n R1OdfScIrj43l35q32r3fwRPS0W9Pnz/pzcDct4E3iCjh4y+l46E6ODF+zvAGjFVwQsGWCsEty4\n Rgx+5sUin6o6CZkS+CZAJR/u+NOlLJ3u+I/kqbCMaX2W7r8qR2m/6ywdDUTkbYGt/DuA==","X-Received":"by 2002:a05:600c:c08e:b0:480:3ad0:93bf with SMTP id\n 5b1f17b1804b1-488d6864d41mr2559745e9.24.1775768442608;\n Thu, 09 Apr 2026 14:00:42 -0700 (PDT)","Message-ID":"<9e3d8ee8-0988-48dc-8cd9-938a21c7dcb2@linaro.org>","Date":"Thu, 9 Apr 2026 23:00:40 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v4 3/9] hw/hexagon: Add machine configs for sysemu","Content-Language":"en-US","To":"Brian Cain , qemu-devel@nongnu.org","Cc":"ltaylorsimpson@gmail.com, matheus.bernardino@oss.qualcomm.com,\n marco.liebel@oss.qualcomm.com, quic_mburton@quicinc.com,\n sid.manning@oss.qualcomm.com, ale@rev.ng, anjo@rev.ng,\n Brian Cain , Markus Armbruster ,\n Mike Lambert , Sid Manning ,\n Paolo Bonzini ,\n =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= ","References":"<20260408042149.1902796-1-brian.cain@oss.qualcomm.com>\n <20260408042149.1902796-4-brian.cain@oss.qualcomm.com>","From":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","In-Reply-To":"<20260408042149.1902796-4-brian.cain@oss.qualcomm.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::32d;\n envelope-from=philmd@linaro.org; helo=mail-wm1-x32d.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]