[{"id":3675025,"web_url":"http://patchwork.ozlabs.org/comment/3675025/","msgid":"","list_archive_url":null,"date":"2026-04-08T23:50:39","subject":"Re: [PATCH v3 10/16] target/hexagon: add v68 HVX IEEE float compare\n insns","submitter":{"id":86757,"url":"http://patchwork.ozlabs.org/api/people/86757/","name":"Taylor Simpson","email":"ltaylorsimpson@gmail.com"},"content":"On Wed, Apr 8, 2026 at 10:37 AM Matheus Tavares Bernardino <\nmatheus.bernardino@oss.qualcomm.com> wrote:\n\n> Add HVX IEEE floating-point compare instructions:\n> - V6_vgthf, V6_vgtsf: greater-than compare\n> - V6_vgthf_and, V6_vgtsf_and: greater-than with predicate-and\n> - V6_vgthf_or, V6_vgtsf_or: greater-than with predicate-or\n> - V6_vgthf_xor, V6_vgtsf_xor: greater-than with predicate-xor\n>\n> Signed-off-by: Matheus Tavares Bernardino <\n> matheus.bernardino@oss.qualcomm.com>\n> ---\n> target/hexagon/mmvec/hvx_ieee_fp.h | 4 ++\n> target/hexagon/mmvec/macros.h | 3 +\n> target/hexagon/mmvec/hvx_ieee_fp.c | 48 +++++++++++++++\n> target/hexagon/imported/mmvec/encode_ext.def | 10 ++++\n> target/hexagon/imported/mmvec/ext.idef | 61 ++++++++++++++++++++\n> 5 files changed, 126 insertions(+)\n>\n> diff --git a/target/hexagon/mmvec/hvx_ieee_fp.h\n> b/target/hexagon/mmvec/hvx_ieee_fp.h\n> index d55837b756..ad854b905d 100644\n> --- a/target/hexagon/mmvec/hvx_ieee_fp.h\n> +++ b/target/hexagon/mmvec/hvx_ieee_fp.h\n> @@ -25,4 +25,8 @@ uint16_t qf_min_hf(uint16_t a1, uint16_t a2,\n> float_status *fp_status);\n> int32_t conv_w_sf(float32 a, float_status *fp_status);\n> int16_t conv_h_hf(float16 a, float_status *fp_status);\n>\n> +/* IEEE - FP compare instructions */\n> +uint32_t cmpgt_sf(uint32_t a1, uint32_t a2, float_status *fp_status);\n> +uint16_t cmpgt_hf(uint16_t a1, uint16_t a2, float_status *fp_status);\n>\n\nUse float32/float16 instead of uint32_t/uint16_t for the args. That's what\nthe implementations below use.\nThe return type should be bool.\n\nOtherwise\nReviewed-by: Taylor Simpson ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=AgUl/wlU;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4frfwq6nPCz1yD3\n\tfor ; Thu, 09 Apr 2026 09:51:38 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wAcfk-00081i-Ic; Wed, 08 Apr 2026 19:51:00 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wAcfe-00081A-Ai\n for qemu-devel@nongnu.org; Wed, 08 Apr 2026 19:50:54 -0400","from mail-pg1-x530.google.com ([2607:f8b0:4864:20::530])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1wAcfc-0004U0-In\n for qemu-devel@nongnu.org; Wed, 08 Apr 2026 19:50:54 -0400","by mail-pg1-x530.google.com with SMTP id\n 41be03b00d2f7-c70fb6aa323so132983a12.3\n for ; Wed, 08 Apr 2026 16:50:52 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; t=1775692251; cv=none;\n d=google.com; s=arc-20240605;\n b=dG1I4Qt2iEaGeI3Uce7E9NDvosDAjtAcsGODvOHK481GC0WqThLGaOpb7XVcPObX6p\n iPh/E3IsjO52gQ2Ee/Wh1f/+UeVmmVQBB4eQvBLQXeBUPzK31FpOz2hjxvRmVGHSuzwF\n 40SGN1cTgc/2swZcAMU6JTN0QMF/mf73NITxRiHZtP2Yga1xse7dB3iRLyvhYyasV7Zz\n R9yZ5PgY+x8mS3UiF93QJou9UyKQahoiRaABuBlsom/esp6r6mpWeAvtyZfrLsHoavEn\n Pd4OY0GcaUbc59LDuRcLWtUcCYgZRneqBrMhFw9yQqxBZFjR1rybiD7lhkKRBtjdlmbE\n Tv2g==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:dkim-signature;\n bh=u/WGsQ5rq0OojHisYPCTDH8LA3g49gUaI+vAkkagQhA=;\n fh=seHpsuERei6GoCJPMtZiXpXOw/2EVnvuQ7nSTREwIqg=;\n b=kfhA8v5nKlrGqGwmyqUj+Y/VwGUkPWENhzqGVciyWRW41ZzV/Zw0k9mXrivtbOXOVI\n xSmRhPIG/gZISzOHXYWdo7y8lBwfGVOdqJZm6Sqh3zx4sdwjs5dJQCelwFFMAjMG5UyM\n sb7yOXUsgKZX4eYhIwCHjdEcMsoOrS/CjFVv/WkNe/hnls8/jE8fIIhinhFFZRYeHOJU\n OmfPNteoX9FX0PYD7howriY/gz+AOf8oFy9bxdjv70lMS/40nB5GWuc82WNX3fUkKKRH\n 4oLuEv4VCkjvVKU88FQN7+iXA19k20QWoEYbFslr3MOhOBOuSxqlVGCVtgRZlQcnLuQ5\n 5k4Q==; darn=nongnu.org","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1775692251; x=1776297051; darn=nongnu.org;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:from:to:cc:subject:date:message-id:reply-to;\n bh=u/WGsQ5rq0OojHisYPCTDH8LA3g49gUaI+vAkkagQhA=;\n b=AgUl/wlUFfndFtObxd8W5K/aEgDc83BspCzhqXxDKSA8r8gT8IdOFYqBLaaaZfPKG2\n BJFxlLCbvC/0XqtMhgYGYhaEgpaPEv2HXWrU1rtB9FAnDlqUOyBOUTBbK+TlACXUwtO4\n MMqCx6rVd93R+pNFhaaM10egkXu1I00PoUYlKKSkRNwqHj3qUcqCLQprt0I1d9HyROFk\n mP/llau9XqFnrtctVIV8Vunt1SMFqo6fdYwM1oihc2ukAS9oar3uR6BLYa+A88r1J4ZM\n Y6RRVoNvGyMnkEwteQGFJlbTlgC4N0KwcEt5zNGiSnxXlnuMEKebSU+eVFd2pVZbynwC\n nERg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775692251; x=1776297051;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=u/WGsQ5rq0OojHisYPCTDH8LA3g49gUaI+vAkkagQhA=;\n b=FX83jNipRkps+Xj7vyLd0zWfcvgkbCPBkGFeDn3dTd/TYO4YcyP3/Pmk7dZBXsAhPd\n JnsHFp8mHkbn6p9Lww6lIM23R9nWeXOLSv1THB0I1al11A42o8g2zRKq/ZvZK1QtwOSC\n TcUkKBP0In9kmf6dJjT8MZ0cuoHQpuXfe3Wbdr5qSeULgzRV67PIuCcXov9afZZSspLO\n 48ZTTx/yCbk65KQoTsguznVxedeP7SEOlyzOBANdFTG/Q87rtTwERZRMm3ePZ+YZ5y9x\n c91k4jL5sCipZFCPkwVr6NOsFM5MoAsnhv/wQ8+FGlX6NP6npK+ErqgTeZH3tezIvTEU\n bdcQ==","X-Gm-Message-State":"AOJu0YyxtT+P7a8n5WowbYi4GUxQtobTmI08W+iUYW9rDYp5VkKhwv3y\n PkuTSuEmfmrC1t++hWlKEgBB/x6IgXdM75QGOv8glvrC1QGw+Dyy4vdqtU/9hcutY56pZj4hFZe\n 0GsW4JY58+QQnJ95uw3MVuljBm87QjRE=","X-Gm-Gg":"AeBDietGbPklMWVWGoHFQIaoRiEDBdiV+2EcyW9PMJSLga9IAj7h+gaaxhxgpv3IKjN\n KrpcsoD2PLyWGPr9HO/Xvc89Jz13KX13O9lTXdvAP8jJ0hlPpzxhX6doARh3cMF6ryu/JS94hls\n k8Eh7mBlZMzAtL9hB36DxVfEqxvUVfRI+BMuECjyZWP7IAe9J974Jj63qCOJEFh/P0ke/dKQoTd\n 2+U45HUmAyqFrM7e+0AmayvAT6USNHSE4c1fqdePuxJ8g0l0IlMS0Ua5Bcj4k/kDqOI0spgcNz+\n S6ulJrVboUmGnjJxLZW0cSSRAT1+T+OeflWgfT4=","X-Received":"by 2002:a17:903:17cf:b0:2b2:45b7:307f with SMTP id\n d9443c01a7336-2b2817d8a45mr234348725ad.9.1775692250962; Wed, 08 Apr 2026\n 16:50:50 -0700 (PDT)","MIME-Version":"1.0","References":"\n <9518dd95bde0a79b7d74bf1f2a15577bfaadb976.1775665981.git.matheus.bernardino@oss.qualcomm.com>","In-Reply-To":"\n <9518dd95bde0a79b7d74bf1f2a15577bfaadb976.1775665981.git.matheus.bernardino@oss.qualcomm.com>","From":"Taylor Simpson ","Date":"Wed, 8 Apr 2026 17:50:39 -0600","X-Gm-Features":"AQROBzCKjI63F_yxAgFgzmODmuyGLrerI53x7U4OTrC4oTOOpP43WAPLIlHO_5w","Message-ID":"\n ","Subject":"Re: [PATCH v3 10/16] target/hexagon: add v68 HVX IEEE float compare\n insns","To":"Matheus Tavares Bernardino ","Cc":"qemu-devel@nongnu.org, richard.henderson@linaro.org, ale@rev.ng,\n anjo@rev.ng, brian.cain@oss.qualcomm.com, marco.liebel@oss.qualcomm.com,\n philmd@linaro.org, quic_mburton@quicinc.com, sid.manning@oss.qualcomm.com","Content-Type":"multipart/alternative; boundary=\"000000000000d95ea1064efb91ba\"","Received-SPF":"pass client-ip=2607:f8b0:4864:20::530;\n envelope-from=ltaylorsimpson@gmail.com; helo=mail-pg1-x530.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,\n HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]