[{"id":3675424,"web_url":"http://patchwork.ozlabs.org/comment/3675424/","msgid":"<adfkjgIqMGCQeIRg@fedora>","list_archive_url":null,"date":"2026-04-09T17:40:51","subject":"Re: [PATCH 14/14] migration/qapi: Update unit for\n avail-switchover-bandwidth","submitter":{"id":89058,"url":"http://patchwork.ozlabs.org/api/people/89058/","name":"Juraj Marcin","email":"jmarcin@redhat.com"},"content":"On 2026-04-08 12:55, Peter Xu wrote:\n> Add \", in bytes per second\".  Unfortunately indentations need to be updated\n> completely, but no change on the rest.\n> \n> Cc: Markus Armbruster <armbru@redhat.com>\n> Suggested-by: Juraj Marcin <jmarcin@redhat.com>\n> Signed-off-by: Peter Xu <peterx@redhat.com>\n> ---\n>  qapi/migration.json | 18 +++++++++---------\n>  1 file changed, 9 insertions(+), 9 deletions(-)\n> \n> diff --git a/qapi/migration.json b/qapi/migration.json\n> index a6e24b5685..b7518b29c6 100644\n> --- a/qapi/migration.json\n> +++ b/qapi/migration.json\n> @@ -921,15 +921,15 @@\n>  #     (Since 2.8)\n>  #\n>  # @avail-switchover-bandwidth: to set the available bandwidth that\n> -#     migration can use during switchover phase.  **Note:** this does\n> -#     not limit the bandwidth during switchover, but only for\n> -#     calculations when making decisions to switchover.  By default,\n> -#     this value is zero, which means QEMU will estimate the bandwidth\n> -#     automatically.  This can be set when the estimated value is not\n> -#     accurate, while the user is able to guarantee such bandwidth is\n> -#     available when switching over.  When specified correctly, this\n> -#     can make the switchover decision much more accurate.\n> -#     (Since 8.2)\n> +#     migration can use during switchover phase, in bytes per\n> +#     second.  **Note:** this does not limit the bandwidth during\n> +#     switchover, but only for calculations when making decisions to\n> +#     switchover.  By default, this value is zero, which means QEMU\n> +#     will estimate the bandwidth automatically.  This can be set\n> +#     when the estimated value is not accurate, while the user is\n> +#     able to guarantee such bandwidth is available when switching\n> +#     over.  When specified correctly, this can make the switchover\n> +#     decision much more accurate.  (Since 8.2)\n>  #\n>  # @downtime-limit: set maximum tolerated downtime for migration.\n>  #     maximum downtime in milliseconds (Since 2.8)\n> -- \n> 2.53.0\n>\n\nReviewed-by: Juraj Marcin <jmarcin@redhat.com>","headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=iEJRJCSd;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=google header.b=f5JOD90T;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fs6gH6LSqz1yCv\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 10 Apr 2026 03:41:31 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wAtNG-0005rh-FR; Thu, 09 Apr 2026 13:41:02 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <jmarcin@redhat.com>)\n id 1wAtNF-0005rQ-37\n for qemu-devel@nongnu.org; Thu, 09 Apr 2026 13:41:01 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <jmarcin@redhat.com>)\n id 1wAtND-0000s9-4A\n for qemu-devel@nongnu.org; Thu, 09 Apr 2026 13:41:00 -0400","from mail-wm1-f69.google.com (mail-wm1-f69.google.com\n [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-577-ephMG4EnN9aUWdvXxkgsYA-1; Thu, 09 Apr 2026 13:40:56 -0400","by mail-wm1-f69.google.com with SMTP id\n 5b1f17b1804b1-4837bfcfe0dso9148175e9.1\n for <qemu-devel@nongnu.org>; Thu, 09 Apr 2026 10:40:56 -0700 (PDT)","from fedora (nat-88-212-17-233.antik.sk. [88.212.17.233])\n by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-488cd1a028esm28072185e9.35.2026.04.09.10.40.52\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 09 Apr 2026 10:40:53 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1775756458;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n in-reply-to:in-reply-to:references:references;\n bh=VywX1/inGwzjM3jfa9kpvzZzXkHCnrCsZrzg3SS6GF8=;\n b=iEJRJCSdztzbPovTG/xXeaNPV6F4CSkAln2y7kJUQVP3mhLWAzi/nqwVbvZ4asgZoyFng2\n h+n3FCEewCk8QiWPusiSJb3EcOSKey8NEoxLATQKd6GP+11Xz+fSlrT/GyvBE9jfGGT0ga\n 3AoABpyRS8r7b0UavMtkH01WgVoGXAI=","v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=redhat.com; s=google; t=1775756455; x=1776361255; darn=nongnu.org;\n h=in-reply-to:content-disposition:mime-version:references:message-id\n :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to;\n bh=VywX1/inGwzjM3jfa9kpvzZzXkHCnrCsZrzg3SS6GF8=;\n b=f5JOD90TYf9iAgICzjkLls62FMsXlCeGbPoSBs7dtcaiSXc2RrwamL151Fv7N5BINa\n XbZMktDUYB5VbOQYXbwzDsoSA+V2AbX7IH8SyJBi296ifS/7pVBfoivRrWa5AjAHGKSR\n SkeF/zzUv7PaDva8Q2ycg3c3t1iXD9Dy5Yjw7ePsAWsQX5ChIvNj0njIbbDkxDyPyqkZ\n SfZhZpYFcyK6X3NsITyY+ydMXIf8g+ySPR3VMFHFfIaJRLMad5so7JU/CV/1BkQ2zpor\n +SgSNs69AKT2MSwjO9fBK3YqY2fbXgRVsBpR7GffYCKv7XLWFM45U8lCUWlkS1vg9yZw\n gU5A=="],"X-MC-Unique":"ephMG4EnN9aUWdvXxkgsYA-1","X-Mimecast-MFC-AGG-ID":"ephMG4EnN9aUWdvXxkgsYA_1775756455","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775756455; x=1776361255;\n h=in-reply-to:content-disposition:mime-version:references:message-id\n :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=VywX1/inGwzjM3jfa9kpvzZzXkHCnrCsZrzg3SS6GF8=;\n b=c91Qt+Xuas440rgendsJ91bROpMxoy5fZRhN+fOaBvQloaw7Gp1NvgsVANdb1rQmcj\n GmNzwM/Npxhxf6IjlcwClIgrYYhIACZcWy2zosJRh/IiCZkBD+N3Tix8suAMzV2DzrY1\n nICmgMsWvLB54l2YSFFmxMyMQ3gS0FHjDXziAq3rK9Hxiv24yeR2399v+yWMTtTiMlcN\n fJ6XuhzRAOvTWLOYyUvXiEOKVW6Wqhx3kZbZQhhSplWpEw2Nnx8PmPtDKz1p39sWKzPB\n gsZvjsYLtRFARHVViBl441XrNEkLRdj0QzqrUsiLKmXyNpleFpZYsfLP6Jil8N6ZleVm\n fbpA==","X-Gm-Message-State":"AOJu0Yw/28mtCov9LOpZJYkjrx++OFX6oQGzYqB/oiKEYryxXzBCjoXR\n lrjMPWeVSZcM1aFLKO5pXoeX5PYL10PTTq9dC0+neZQg9duJaeAa9DOKHqtj2lcujG2ns/maAmq\n dvg4i7Aubt79NgBRsdkbx+x7fHsNapO7jUqpxtDqFb/oiZ6pCGe+UuUCn","X-Gm-Gg":"AeBDietcVPT6Wi4V90g7iFSoq9HlSIMm/xaRsCezGEgr0ovt2ViY6efdoJJAYs3TeOn\n lvxcEBC4oRcXAaVVEqPmxFcnuk+GMkXrIWPuQE/Niin9r1Sw3OjjDCzk4BAznj+qF1/K3Q/E6DO\n 9nDIdj5Np+SU8yl334zTtWgH6128Pe+iLRzOjVxZW+FHCcS7xAlCOlv4szdI1odizBANcijfd2G\n 6CQezX4pLxM42aIYS/qGtoKhqO+DBqqK0mAl7kGUZSS/owCFD8QKUW+3rdKX/bhNnGJpOyXezgM\n /iTAUgDyE+V60mUB/gjksVNujPQXJJFw2GOTbjbOuRfYmCcs3PCqXLYI8T9DLTFOwUgODX+99tx\n yDCAZs/YUOq2vAUQYeppSDrgvRo3C3lDD2OMOTUs=","X-Received":["by 2002:a05:600c:8b28:b0:47e:e48b:506d with SMTP id\n 5b1f17b1804b1-488cd0201d5mr75192515e9.16.1775756455287;\n Thu, 09 Apr 2026 10:40:55 -0700 (PDT)","by 2002:a05:600c:8b28:b0:47e:e48b:506d with SMTP id\n 5b1f17b1804b1-488cd0201d5mr75192055e9.16.1775756454784;\n Thu, 09 Apr 2026 10:40:54 -0700 (PDT)"],"Date":"Thu, 9 Apr 2026 19:40:51 +0200","From":"Juraj Marcin <jmarcin@redhat.com>","To":"Peter Xu <peterx@redhat.com>","Cc":"qemu-devel@nongnu.org,\n  \"Maciej S . Szmigiero\" <mail@maciej.szmigiero.name>, Daniel P\n\t=?utf-8?b?LiBCZXJyYW5nw6k=?= <berrange@redhat.com>,\n  Zhiyi Guo <zhguo@redhat.com>, Prasad Pandit <ppandit@redhat.com>,\n  Avihai Horon <avihaih@nvidia.com>, Kirti Wankhede <kwankhede@nvidia.com>,\n\t=?utf-8?q?C=C3=A9dric?= Le Goater <clg@redhat.com>,\n Fabiano Rosas <farosas@suse.de>,  Joao Martins <joao.m.martins@oracle.com>,\n Markus Armbruster <armbru@redhat.com>, Alex Williamson <alex@shazbot.org>","Subject":"Re: [PATCH 14/14] migration/qapi: Update unit for\n avail-switchover-bandwidth","Message-ID":"<adfkjgIqMGCQeIRg@fedora>","References":"<20260408165559.157108-1-peterx@redhat.com>\n <20260408165559.157108-15-peterx@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20260408165559.157108-15-peterx@redhat.com>","Received-SPF":"pass client-ip=170.10.129.124; envelope-from=jmarcin@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-25","X-Spam_score":"-2.6","X-Spam_bar":"--","X-Spam_report":"(-2.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.54,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development <qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<https://lists.nongnu.org/archive/html/qemu-devel>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]