[{"id":3675021,"web_url":"http://patchwork.ozlabs.org/comment/3675021/","msgid":"","list_archive_url":null,"date":"2026-04-08T23:30:09","subject":"Re: [PATCH v3 08/16] target/hexagon: add v68 HVX IEEE float misc\n insns","submitter":{"id":86757,"url":"http://patchwork.ozlabs.org/api/people/86757/","name":"Taylor Simpson","email":"ltaylorsimpson@gmail.com"},"content":"On Wed, Apr 8, 2026 at 10:37 AM Matheus Tavares Bernardino <\nmatheus.bernardino@oss.qualcomm.com> wrote:\n\n> Add HVX IEEE floating-point miscellaneous instructions:\n> - vassign_fp (vfmv): vector move\n> - vfneg_hf, vfneg_sf: vector floating-point negate\n> - vabs_hf, vabs_sf: vector absolute value\n>\n> Signed-off-by: Matheus Tavares Bernardino <\n> matheus.bernardino@oss.qualcomm.com>\n> ---\n> target/hexagon/imported/mmvec/encode_ext.def | 7 +++++++\n> target/hexagon/imported/mmvec/ext.idef | 12 ++++++++++++\n> 2 files changed, 19 insertions(+)\n>\n> diff --git a/target/hexagon/imported/mmvec/ext.idef\n> b/target/hexagon/imported/mmvec/ext.idef\n> index 0e9cace203..5312661684 100644\n> --- a/target/hexagon/imported/mmvec/ext.idef\n> +++ b/target/hexagon/imported/mmvec/ext.idef\n> @@ -3034,6 +3034,18 @@\n> ITERATOR_INSN_ANY_SLOT_2SRC(16,vmin_hf,\"Vd32.hf=vmin(Vu32.hf,Vv32.hf)\", \\\n> \"Vector min of hf input\", VdV.hf[i] = qf_min_hf(VuV.hf[i], VvV.hf[i],\n> \\\n> &env->hvx_fp_status))\n>\n> +/* IEEE FP move, negate, abs instructions */\n> +ITERATOR_INSN_IEEE_FP_16_32_LATE(32, vassign_fp, \"Vd32.w=vfmv(Vu32.w)\", \\\n> + \"Vector IEEE move\", VdV.w[i] = VuV.w[i])\n> +ITERATOR_INSN_IEEE_FP_16_32_LATE(16, vfneg_hf, \"Vd32.hf=vfneg(Vu32.hf)\", \\\n> + \"Vector IEEE neg: hf\", VdV.hf[i] = float16_chs(VuV.hf[i]))\n> +ITERATOR_INSN_IEEE_FP_16_32_LATE(32, vfneg_sf, \"Vd32.sf=vfneg(Vu32.sf)\", \\\n> + \"Vector IEEE neg: sf\", VdV.sf[i] = float32_chs(VuV.sf[i]))\n> +ITERATOR_INSN_IEEE_FP_16_32_LATE(16, vabs_hf, \"Vd32.hf=vabs(Vu32.hf)\", \\\n> + \"Vector IEEE abs: hf\", VdV.hf[i] = float16_abs(VuV.hf[i]))\n> +ITERATOR_INSN_IEEE_FP_16_32_LATE(32, vabs_sf, \"Vd32.sf=vabs(Vu32.sf)\", \\\n> + \"Vector IEEE abs: sf\", VdV.hf[i] = float32_abs(VuV.hf[i]))\n\n\nShould be VdV.sf[i] = float32_abs(vuV.sf[i])\nI'm surprised there isn't a test case that catches this.\n\nOtherwise\nReviewed-by: Taylor Simpson ","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=hQZf9viK;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4frfSs6t4lz1xtJ\n\tfor ; Thu, 09 Apr 2026 09:30:52 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wAcLq-0004KO-Ov; Wed, 08 Apr 2026 19:30:26 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wAcLo-0004Gw-Dd\n for qemu-devel@nongnu.org; Wed, 08 Apr 2026 19:30:24 -0400","from mail-pl1-x633.google.com ([2607:f8b0:4864:20::633])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1wAcLm-0000RT-NO\n for qemu-devel@nongnu.org; Wed, 08 Apr 2026 19:30:24 -0400","by mail-pl1-x633.google.com with SMTP id\n d9443c01a7336-2addb31945aso2129555ad.1\n for ; Wed, 08 Apr 2026 16:30:22 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; t=1775691021; cv=none;\n d=google.com; s=arc-20240605;\n b=loi3lVSrjvdIcw4CwZU5n1vUIAdM4zhyWBepyHxPdJ/ngzvKw1wpb3cN8vsac4eBo6\n ea4hwlmkWprox53VbexFTWfKIikX1nZYf3fXK/4WM91sgxBKmi9m3q0PyZTiReOXR4Ru\n ctMwaZ9zsBy9iJCJzWc4Cr0RYhVK2hk9IvPLnRHYNKibn4a/9BPWVibDi79TvyPSbo39\n 416ijsF02613K0AxneZNfiRdmKM061iUQRJA/euReGMAC5Bzs0i+7Njd4yzFzul+h5TE\n SOk6F2O0ixE6qtqHDt94qA96JmKFZqrGeUHFbIeZOEZjqNb9gFq6R7l5sPvbXRBXILMG\n jgHg==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:dkim-signature;\n bh=DTlBoQRl4C/4v0qjBblJOKydeJC045m40dzqZvQmXio=;\n fh=seHpsuERei6GoCJPMtZiXpXOw/2EVnvuQ7nSTREwIqg=;\n b=Wez9DSi1KONVsxUyp6cVoF7wjxXccZTnfB+WV1c2CbszcxgZWVLPW4vUSemM1A0FT/\n pfCcIxLNTVx40Y4xBvNU5coIyWANeYU9aZxXpJEk20qgMfXCwrv0IDMYuZlJJgcDhdf9\n 9DqdQ5wbbsUiAm6PB6wXjAMkP4ajFZZywLQdhPgJxa+RtTXPlZEF5EpjA86Bd8ZkJytG\n 23Eu/k0drVK+VYdZs6w+DQmNK7pnqTdzxTd+dRSeaLUYUZGxcB9iKcRidvqn1QkHCorc\n QGRDCA0a+lJm/yioV7jO5VLTc84IaYeiAJla2IZJHjiVLn9Jm5c6tWIvOUkXHFMbWAUv\n l2wA==; darn=nongnu.org","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1775691021; x=1776295821; darn=nongnu.org;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:from:to:cc:subject:date:message-id:reply-to;\n bh=DTlBoQRl4C/4v0qjBblJOKydeJC045m40dzqZvQmXio=;\n b=hQZf9viKR4kZgzIKwTQLb7ShHyBuulEEMpSuImBedsEC6p37xryxXr0Z0+QzdSfxlN\n VDx3MzhCgC3bWxnPRQe3bCY7fSz5fgLx68pg2nM25y2CAVwo7iY9Ao6l7gwBc0hPc1KX\n l/yN+79oPlWVtF+HFnQ7g2IPZ6CYayFRBocamLkxSpYV4i22s2f6FVXsSUgA1c8gKObZ\n Aj0P1wjbhMLQhcnV2DSgHzVjXXuWNfUBO5nJ79GoizpgiCbIRzIySZKJlbwkWwlORnAS\n bl9V22y/OqjgIDwbA3R1fmV+GWM7BfKfgNXMX1vSCqvlxVT/h2IsOWThxdlz5FV+kYde\n x1xg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775691021; x=1776295821;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=DTlBoQRl4C/4v0qjBblJOKydeJC045m40dzqZvQmXio=;\n b=r21Q6dAmzBzfDjP8rE0yvJgizGMa7BQN6OOBFThZg+FN2fOnk4cMhd2ziMMPVWuQna\n qXGxjKREmZGcnevMaH/HJdAECmwcpWtTeGiNoIyQNvebA/1j/cnqaibfZHVCB0PUb93y\n 99g52jkb7vyFvIpeBqwZt8laSwkVe7cW792Qzumq27fV2Y4S6kCjdSwr50cU4kFwPcF5\n 40rVPKsOPmpaUXzHUXcDFwqvjfxZR+E8f18K0WmTrOE0BIKfYBJ6SKNxXUhobCEHtys+\n T91uGHYs/P2p6GnB/1cfHRKuRP9pdNNKP/sbSoN+NUlbNMVuTVUyCxs9Op7hyp0TI5Hq\n +W3w==","X-Gm-Message-State":"AOJu0Yz4x7zb8Jr/eAs7ybEzV7jm5c1QA3MT9ljhNlZpsbenrAYDPPRx\n 3W/Tc0YgI4Ear1ttQtw2YKlm/sprN1UzrChy3hRP+ZWbv8Squ61dX3JPb4Xky3k2voKNqEfGRl3\n NTH2ZLh9YuBUxfkCx9KoXmm/2MUIbmlk=","X-Gm-Gg":"AeBDietBPt4wRKO8wVgea/NipPpJ7gVtbRi89R7KTddf129cLaQria94K9fPpsB41Nx\n ln6uGDDdMfoZeBmI8Z3wwRt9jZYJOF9SuRi3eFlbKgn/kRUeVPrMWDE7huIr3kowrQO9z1ulhhn\n /dNJVbA0uiXXplTOYGG9E/wUDhk8CjyW8M+FkDoVkavbCa96MTLQrFAFkrVsGDVyIceLePkUW1h\n YG72grEZNgSrDdWki1fYrqS/Vl/ijFRxkNESwamgERpzC96gok+TnZasvSV7TsWLtYaCajhBXs9\n GuCn9V8bWXIMIfUP8YYM81Vyoc3aY/utN1e8bAs=","X-Received":"by 2002:a17:902:e546:b0:2b0:5b4e:370c with SMTP id\n d9443c01a7336-2b281931aa5mr233465475ad.32.1775691020914; Wed, 08 Apr 2026\n 16:30:20 -0700 (PDT)","MIME-Version":"1.0","References":"\n <2aa7f105031465bdbd63c22bca6e2b77b92bab5f.1775665981.git.matheus.bernardino@oss.qualcomm.com>","In-Reply-To":"\n <2aa7f105031465bdbd63c22bca6e2b77b92bab5f.1775665981.git.matheus.bernardino@oss.qualcomm.com>","From":"Taylor Simpson ","Date":"Wed, 8 Apr 2026 17:30:09 -0600","X-Gm-Features":"AQROBzCY5_LzmL57OYVS9x2RuiGsuogEGGMAlJ_VNFYOx5vzOBT5nqYtPMIKios","Message-ID":"\n ","Subject":"Re: [PATCH v3 08/16] target/hexagon: add v68 HVX IEEE float misc\n insns","To":"Matheus Tavares Bernardino ","Cc":"qemu-devel@nongnu.org, richard.henderson@linaro.org, ale@rev.ng,\n anjo@rev.ng, brian.cain@oss.qualcomm.com, marco.liebel@oss.qualcomm.com,\n philmd@linaro.org, quic_mburton@quicinc.com, sid.manning@oss.qualcomm.com","Content-Type":"multipart/alternative; boundary=\"0000000000008854f7064efb48b8\"","Received-SPF":"pass client-ip=2607:f8b0:4864:20::633;\n envelope-from=ltaylorsimpson@gmail.com; helo=mail-pl1-x633.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,\n HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"}}]