[{"id":3674865,"web_url":"http://patchwork.ozlabs.org/comment/3674865/","msgid":"","list_archive_url":null,"date":"2026-04-08T17:38:45","subject":"Re: [PATCH v2 1/2] ASoC: tegra210_adx: simplify byte map get/put\n logic","submitter":{"id":66273,"url":"http://patchwork.ozlabs.org/api/people/66273/","name":"Jon Hunter","email":"jonathanh@nvidia.com"},"content":"On 08/04/2026 18:08, Piyush Patle wrote:\n> The byte-map controls (\"Byte Map N\") already expose a value range of\n> [0, 256] to userspace via SOC_SINGLE_EXT(), where 256 is the\n> \"disabled\" sentinel. The driver stored this state as a byte-packed\n> u32 map[] array plus a separate byte_mask[] bitmap tracking which\n> slots were enabled, because 256 does not fit in a byte. As a result\n> get_byte_map() had to consult byte_mask[] to decide whether to\n> report the stored byte or 256, and put_byte_map() had to keep the\n> two arrays in sync on every write.\n> \n> Store each slot as a u16 holding the control value directly\n> (0..255 enabled, 256 disabled). This is the native representation\n> for what userspace already sees, so get_byte_map() becomes a direct\n> return and put_byte_map() becomes a compare-and-store. The\n> hardware-facing packed RAM word and the IN_BYTE_EN mask are now\n> derived on the fly inside tegra210_adx_write_map_ram() from the\n> slot array, which is the only place that needs to know about the\n> hardware layout.\n> \n> The byte_mask scratch buffer is allocated dynamically using\n> kcalloc() based on soc_data->byte_mask_size, removing dependency\n> on SoC-specific constants. The byte_mask field is dropped from\n> struct tegra210_adx.\n\nSo this was already the case. However ...\n\n\n> -static void tegra210_adx_write_map_ram(struct tegra210_adx *adx)\n> +static int tegra210_adx_write_map_ram(struct tegra210_adx *adx)\n> {\n> +\tconst unsigned int bits_per_mask = BITS_PER_TYPE(*adx->map) * BITS_PER_BYTE;\n> +\tunsigned int *byte_mask;\n> \tint i;\n> \n> +\tbyte_mask = kcalloc(adx->soc_data->byte_mask_size, sizeof(*byte_mask),\n> +\t\t\t GFP_KERNEL);\n> +\tif (!byte_mask)\n> +\t\treturn -ENOMEM;\n> +\n\nNow you are allocating this everytime this function is called (which \nhappens on RPM resume) instead of ...\n\n> @@ -700,16 +706,15 @@ static int tegra210_adx_platform_probe(struct platform_device *pdev)\n> \n> \tregcache_cache_only(adx->regmap, true);\n> \n> -\tadx->map = devm_kzalloc(dev, soc_data->ram_depth * sizeof(*adx->map),\n> -\t\t\t\tGFP_KERNEL);\n> +\tadx->map = devm_kcalloc(dev,\n> +\t\t\t\tsoc_data->ram_depth * TEGRA_ADX_SLOTS_PER_WORD,\n> +\t\t\t\tsizeof(*adx->map), GFP_KERNEL);\n> \tif (!adx->map)\n> \t\treturn -ENOMEM;\n> \n> -\tadx->byte_mask = devm_kzalloc(dev,\n> -\t\t\t\t soc_data->byte_mask_size * sizeof(*adx->byte_mask),\n> -\t\t\t\t GFP_KERNEL);\n> -\tif (!adx->byte_mask)\n> -\t\treturn -ENOMEM;\n\n... here in the probe function, which makes more sense. IOW I am not \nsure why you have changed this.\n\nJon","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-tegra@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=Nvidia.com header.i=@Nvidia.com header.a=rsa-sha256\n header.s=selector2 header.b=mcLwKX9l;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c09:e001:a7::12fc:5321; helo=sto.lore.kernel.org;\n envelope-from=linux-tegra+bounces-13618-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com\n header.b=\"mcLwKX9l\"","smtp.subspace.kernel.org;\n arc=fail smtp.client-ip=52.101.201.71","smtp.subspace.kernel.org;\n dmarc=pass (p=reject dis=none) header.from=nvidia.com","smtp.subspace.kernel.org;\n spf=fail smtp.mailfrom=nvidia.com","dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=nvidia.com;"],"Received":["from sto.lore.kernel.org (sto.lore.kernel.org\n [IPv6:2600:3c09:e001:a7::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4frVfz2LYXz1xv0\n\tfor ; Thu, 09 Apr 2026 03:39:07 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sto.lore.kernel.org (Postfix) with ESMTP id 10F0A3001FCC\n\tfor ; Wed, 8 Apr 2026 17:39:03 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 5CB873D75D4;\n\tWed, 8 Apr 2026 17:39:02 +0000 (UTC)","from PH7PR06CU001.outbound.protection.outlook.com\n (mail-westus3azon11010071.outbound.protection.outlook.com [52.101.201.71])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id EA0273446CE;\n\tWed, 8 Apr 2026 17:39:00 +0000 (UTC)","from DS2PR12MB9750.namprd12.prod.outlook.com (2603:10b6:8:2b0::12)\n by BY5PR12MB4305.namprd12.prod.outlook.com (2603:10b6:a03:213::17) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9769.16; Wed, 8 Apr\n 2026 17:38:54 +0000","from DS2PR12MB9750.namprd12.prod.outlook.com\n ([fe80::56a8:d6bf:e24c:b391]) by DS2PR12MB9750.namprd12.prod.outlook.com\n ([fe80::56a8:d6bf:e24c:b391%6]) with mapi id 15.20.9769.016; Wed, 8 Apr 2026\n 17:38:54 +0000"],"ARC-Seal":["i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1775669942; cv=fail;\n b=YKy2ZDd0ZzY4oLQOV2B7fG9SAPryhBD86S6Jkv2YSMqE7DaORJMe1jrMoB+BK1UMq94nTxQ05ytjC6D5Ut8gRiy69FgtMCz6DeiKy+61rXmGGZP4VVpwtYIeZ0stIpSVZkbO7qNtfywgU81J3R/94YK+CdE72fdQXrmLPIf9/y8=","i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=u5muvZt5BZMDvBbzr2A8EjofYKj9CkEmQFeWrRhQXdZmwcekzd6XinejOF+ydfsLpZ5LJBnSNq4W1WdfIDFtHhUhvG9PoC1c/XGVkjgs7FW37eOgWnFAK29/gQ4zdtIf4jIyrGRHlGZ2JaOQBS0IJCUDsq+Bv04YmzSAYRf9x5/TSTJAPNAi4gDZFbcgTCEQr4IC5DdlGv7DVeZNHN5QWm1GqZwYztsOE2NM7iWcBZDYBC1Z6iP2XXQWSGLWZ8g7euGFMebfYXVo9Q4A8sCMYLHVckKKcTttNWfH2eez7NJLw3PbrqCydMNWNGEMgAYRkzT0WvLsY9NJGUUAev3NYQ=="],"ARC-Message-Signature":["i=2; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1775669942; c=relaxed/simple;\n\tbh=iIPUytMwmu4BY4F8zb9SKiIUytgNaCEf/DCoymZ0F30=;\n\th=Message-ID:Date:Subject:To:Cc:References:From:In-Reply-To:\n\t Content-Type:MIME-Version;\n b=uFGj/f1Pewh3l9DflHnExINaUrJR/tCIWlEC5d8ppeXcMF0Vo3UNnuT/qwtGTYHl1mVYsKQA7zfOBrCrLzwy5mQwMfyazuu1G+1CUUi5YhqbzKMMeHI0urOaQ6wxNaL/BbvFeuF38HvD8qnu2l/tpx2s3ANfTnXTvgOI3t5TaKA=","i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=jqC8fsyMI06BG+isthq57QsJpC3R5UO7DntMtzI+VBI=;\n b=Su2rPEDOCJYRhJ54yGncQ/8Jkn2u29ZH9BDzsUrI7x6WUrH6MUh7jDR/ieB4QjFo/gATI0XBHlhZA1und1oLkeBkmLfnHkrqKp4D+ewiuuQhskYPVAmNP8mve+cc/3cWaP/nXKw5KeIH89XLA/sXq9ufK4depfxHt8hCbLuzDLZp+ydWkZLwEC38yPcr0dhw7bbJZAZ6Rnq5XdJUCAgLtYkGwwXSpZVurEgB70leFhdwTk3N7nx0v+b/gmCVAKRCkt2TJEA6SCE5GOFkEhlNV1vVCpKdPNlzBa+YrINKMbRNG03o9o7dM9Sq5FwX2ZKHtJVaO3GTkO+BJ9mr209GRg=="],"ARC-Authentication-Results":["i=2; smtp.subspace.kernel.org;\n dmarc=pass (p=reject dis=none) header.from=nvidia.com;\n spf=fail smtp.mailfrom=nvidia.com;\n dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com\n header.b=mcLwKX9l; arc=fail smtp.client-ip=52.101.201.71","i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com;\n dkim=pass header.d=nvidia.com; arc=none"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=jqC8fsyMI06BG+isthq57QsJpC3R5UO7DntMtzI+VBI=;\n b=mcLwKX9lv7UN2HxLCfBaeuCqBcgOHP/QXV78Alz/54c9UvIExhITIKnT8CxgEvoFJrB1/81HEmdFFdv8ivLLs0JziLYkKN83GtzPcOJIUb5b+RMeHa3nJpUzNE6Wvl2Hi1pV4Q8S/xlEZaZOPa/Iy/RQyO7KwHB2f/aJ+c3127csa+3TdHS78OAN7X1pFSXMitXHyRcNokehGE4aceLYwzr7lY3tQJGbPPUyqDBwKdISjkGpbpDnGl4K3LZhsiA9ToJw4wCVX3p3kRlOok8Nbdj6X1f6axBF0z4vfqprRYmr0MCmXG4wmVZ+DE057BzBItzUifw4XiNPXdf9b48MWg==","Message-ID":"","Date":"Wed, 8 Apr 2026 18:38:45 +0100","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v2 1/2] ASoC: tegra210_adx: simplify byte map get/put\n logic","To":"Piyush Patle , Mark Brown ","Cc":"Sheetal , Thierry Reding ,\n Liam Girdwood , Jaroslav Kysela ,\n Takashi Iwai ,\n Kuninori Morimoto ,\n linux-sound@vger.kernel.org, linux-tegra@vger.kernel.org,\n linux-kernel@vger.kernel.org","References":"<20260407170308.100238-3-piyushpatle228@gmail.com>\n <20260408170818.70322-1-piyushpatle228@gmail.com>\n <20260408170818.70322-2-piyushpatle228@gmail.com>","From":"Jon Hunter ","Content-Language":"en-US","In-Reply-To":"<20260408170818.70322-2-piyushpatle228@gmail.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-ClientProxiedBy":"DS7PR03CA0156.namprd03.prod.outlook.com\n (2603:10b6:5:3b2::11) To DS2PR12MB9750.namprd12.prod.outlook.com\n (2603:10b6:8:2b0::12)","Precedence":"bulk","X-Mailing-List":"linux-tegra@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","X-MS-PublicTrafficType":"Email","X-MS-TrafficTypeDiagnostic":"DS2PR12MB9750:EE_|BY5PR12MB4305:EE_","X-MS-Office365-Filtering-Correlation-Id":"1a9a11c8-df93-471c-b0bd-08de9595b450","X-MS-Exchange-SenderADCheck":"1","X-MS-Exchange-AntiSpam-Relay":"0","X-Microsoft-Antispam":"\n\tBCL:0;ARA:13230040|1800799024|376014|7416014|10070799003|366016|18002099003|22082099003|56012099003;","X-Microsoft-Antispam-Message-Info":"\n\tj8t8rtW6fM6KMM3uowm1UcGMSLZAcs1UTgUE+zxAYsw93QCncOS/kyFW1xffzw45Eog/L8wDtAr0GdLpz/G16AiEdcckxhcrNuUozoO8lCqiDZ4oT3NCoiyonWIEEzRBhtQCgAicBmcX83FZWsCUSjPFrmQi2vrIY+ec//KIefWxqbj2RFRq/2YuQHQMuKRP+c2XO6l4ub92c/6DLTAhIVbXm+URGKdqJQgRjsyv61b9OQE19oXHnpdLO1BiSWJMjy8foPc/N2xaUVPtkOhIOOkUVXCXRych+FfabwjTpHQeexR918DdDU2sF8tTxL7Xj+dSr868k4m9yf/oEn5U/Us7kQy3xj/ME1AJXasF02JaTm5LMhk6n06Fu0caF0ynmV+2/Uu/lK/OPx4jY3gkfvr9cwVXYfR+KHWufO6kEHiXhoxoKrhJr7btSMlPj/8jPJmiOm31eF1YTQdNpomYMhEWvN2noWyQdGEN2KmH4mEf53P4pRr66XdblLixJ/nK0ZwYvOflZUnlB0djaR0o4UX9sfoy2BoXdcU7h9Hsn/uNZ0N5szKwRY0k5XaKSeyc+3f5gEn0G4wP91MzQDSktZnrbwhUEX9JAoCViNXQ9p1RKFs/FDbkQsM+4YMcjPM3RWP3AwVO8jwm2j+briny1jlwVE04UBlTTkANW3BhXHzD259R/uxAW7kUSzUbKIpCQ5kKbqCdvGHPZkiFgE73963eGprGBHBEP87Rx2AGKR8=","X-Forefront-Antispam-Report":"\n\tCIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS2PR12MB9750.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(376014)(7416014)(10070799003)(366016)(18002099003)(22082099003)(56012099003);DIR:OUT;SFP:1101;","X-MS-Exchange-AntiSpam-MessageData-ChunkCount":"2","X-MS-Exchange-AntiSpam-MessageData-0":"=?utf-8?q?kqR/qCYlJcGcxYlmDGFJwscefKeK?=\n\t=?utf-8?q?mWbYTm8aA6LzLrrszgRIBcykXjuluU63tpbmiUbYUxbHnW/9MoG0PeRSX9P1+req6?=\n\t=?utf-8?q?i4nR9rAXC5olztHJs0rJeB9fQV4UKi28EvCjcBF7NCID1lVFBWsuJYFLEyOCorXbH?=\n\t=?utf-8?q?HD/nbIr1asMqwsjzsBTGJobqqdyUjuPfUHxipPeK64SuEhfz05PbOQcwGw9F/V/As?=\n\t=?utf-8?q?KpdDKF6mz3n9DbbVnKdCHs/R5z1fhFpNwkFepC9ImXVkj4kmNSUyLamZCjh/rTm/E?=\n\t=?utf-8?q?Drw9UkmPabP4KVYBs5V+5BLwRQrse9Z4d7TaXIHvobFHfLMZ5eVtdZzncFZPy2AEN?=\n\t=?utf-8?q?Fm67QGJwf+am4qPip9dHHYf/u+gsQjCQfMrO9i0NgzZ9AkkqcuBvHIjFTq/NxLJdh?=\n\t=?utf-8?q?+LWanuW5MvVmB3YWK1aXv+S7z9r3so1am3Gp5l2abC0lmSHRHj92+PtyXFRA33GBY?=\n\t=?utf-8?q?/JG3kAXn3lzDv6W9SOyG9PAif3fcP8UTAgqT0x++Cp5yK1T+naY1qDFU6OMz+6euh?=\n\t=?utf-8?q?9bLpa045X18xjC8ITTfpmmrTxSxyki85K9m4910pAQMWc3dBl4/v052hKbBhlHsL+?=\n\t=?utf-8?q?YWHBkPDyEvW8RQdAfiId6otKvTJ9CUT2nA1edEg9Bi1mrlf/pNhzsLGPFMBCsCTnI?=\n\t=?utf-8?q?GJcUMPpfEWer4qVD4fakfe4AuW0y1O7mX0EtpUZz+9WW41MvBw+gCZxCAKv/TVNyL?=\n\t=?utf-8?q?r/MZueSVUOTVpg1P5ejnob3GP8sFnC+JVkhGH1gA5HdXNtNWVh02VLB8PUNfTQJn/?=\n\t=?utf-8?q?ReqGIBVIEMozUBq8tSem713vonaL/2JGMDKAgQUVREaMLTVevqQU9j+JdS3ogH3X+?=\n\t=?utf-8?q?ak4dbSxfT6ZNjXGLBFl8O33fyK60zWOEE1FmsNOhA3CapgY6dD9f7+VKA381IKppB?=\n\t=?utf-8?q?fXNOsFJqkpGkfPhoVSEzAb+NVhqUhxYZ6uJVW76Bain1PxMohYT7T1KmMX5fw30Jv?=\n\t=?utf-8?q?Nm8HUDKgOfxd/TjOKNookjYXY1P0vC+elAJQK1uY0ptRHW4HZPGHWh+kQOw5rtpij?=\n\t=?utf-8?q?Nt6SRZvffR+rnyjUXm8erLxi4MYVwgqKnoWNiXrniptu3Q9OgyHcSKNN3/AnWzWyu?=\n\t=?utf-8?q?y59hStXIeAUvXxP5FgSpnrKc1Jc36HpYaHfClEbPFgnd+T3Lc5GlS/LJNPbm4RmR8?=\n\t=?utf-8?q?becRiNapySbUrfpf+aApN5QnF6Rl9GAWKIGryDIASB/cDthkKFA0w866dc3qjMNtI?=\n\t=?utf-8?q?YE+lyKguRvu8JhjF2V3FaXNWLivb+IxphHnB4j/KN92Jg3g1H1M1HvVGyImLylR8Z?=\n\t=?utf-8?q?nWeS6Aeef6sFY4iHPBIYoYBh2pF7tjzbDIBzKQmCsyhDvWz7QeOa+4wwTLc1y9pIr?=\n\t=?utf-8?q?olIFAl9xIvS1aT4r2iA6mG2NPMJ8qOR9pYu/87k01+dvZ108+C+Lroj48pgdgN6Zu?=\n\t=?utf-8?q?B/9iQfyzGBBnQBefoyBCXhhrKyUxBSc+ZSe7JVwRGIGZE5sbAgLo/mPU+JQcmvWW2?=\n\t=?utf-8?q?U2mRwxgllmQzP3PFZ2gfNpx4W63nKA99JrNgXfQBcquR106kRhUK+BoJKmH7gyWiB?=\n\t=?utf-8?q?OB3z7IyHCvL2lzIoZVL7vcRcWim1QxkLg9RVL9v7RvS3kuP043OZsf2/KZHK8S/Uz?=\n\t=?utf-8?q?WtEoOGgxYBzRLp6PRsmii3pdP1xkSzfCREd/hVp+LjIoyy7IfK7+ZdTk+LyRNQFV3?=\n\t=?utf-8?q?jKGlph7N970AkB05s3F/Wd64m98Q0CraLjNI3DU53JvLtwzHQAX4RUTrEeSl3rVB5?=\n\t=?utf-8?q?19j2vY1wC0Risfrq7?=","X-MS-Exchange-AntiSpam-MessageData-1":"yDyLufoSTNv8Nw==","X-OriginatorOrg":"Nvidia.com","X-MS-Exchange-CrossTenant-Network-Message-Id":"\n 1a9a11c8-df93-471c-b0bd-08de9595b450","X-MS-Exchange-CrossTenant-AuthSource":"DS2PR12MB9750.namprd12.prod.outlook.com","X-MS-Exchange-CrossTenant-AuthAs":"Internal","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"08 Apr 2026 17:38:54.2075\n (UTC)","X-MS-Exchange-CrossTenant-FromEntityHeader":"Hosted","X-MS-Exchange-CrossTenant-Id":"43083d15-7273-40c1-b7db-39efd9ccc17a","X-MS-Exchange-CrossTenant-MailboxType":"HOSTED","X-MS-Exchange-CrossTenant-UserPrincipalName":"\n HZK46dX5Z06Y/nJbhat5NaCwlO9344gwvLIS6+uXFHNkv79Rv930qHj1wYMSI5lOD8yrT57DyVpUMI3BRizyuw==","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"BY5PR12MB4305"}},{"id":3674871,"web_url":"http://patchwork.ozlabs.org/comment/3674871/","msgid":"","list_archive_url":null,"date":"2026-04-08T17:47:33","subject":"Re: [PATCH v2 1/2] ASoC: tegra210_adx: simplify byte map get/put\n logic","submitter":{"id":24878,"url":"http://patchwork.ozlabs.org/api/people/24878/","name":"Mark Brown","email":"broonie@kernel.org"},"content":"On Wed, Apr 08, 2026 at 10:38:17PM +0530, Piyush Patle wrote:\n\n> +static int tegra210_adx_write_map_ram(struct tegra210_adx *adx)\n> {\n> +\tconst unsigned int bits_per_mask = BITS_PER_TYPE(*adx->map) * BITS_PER_BYTE;\n\nWhy are we multiplying by BITS_PER_BYTE here? We've got a number of\nbits already from BITS_PER_TYPE().\n\n> +\tfor (i = 0; i < adx->soc_data->ram_depth; i++) {\n> +\t\tu32 word = 0;\n> +\t\tint b;\n> +\n> +\t\tfor (b = 0; b < TEGRA_ADX_SLOTS_PER_WORD; b++) {\n> +\t\t\tunsigned int slot = i * TEGRA_ADX_SLOTS_PER_WORD + b;\n> +\t\t\tu16 val = adx->map[slot];\n> +\n> +\t\t\tif (val >= 256)\n> +\t\t\t\tcontinue;\n> +\n> +\t\t\tword |= (u32)val << (b * BITS_PER_BYTE);\n> +\t\t\tbyte_mask[slot / bits_per_mask] |= 1U << (slot % bits_per_mask);\n\nHow big can bits_per_mask get?\n\n> @@ -118,9 +144,7 @@ static int tegra210_adx_runtime_resume(struct device *dev)\n> \tregcache_cache_only(adx->regmap, false);\n> \tregcache_sync(adx->regmap);\n> \n> -\ttegra210_adx_write_map_ram(adx);\n> -\n> -\treturn 0;\n> +\treturn tegra210_adx_write_map_ram(adx);\n\nWe need to unwind at least the regcache_cache_only() above if resume\nfails.","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-tegra@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=nkihFGBe;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c15:e001:75::12fc:5321; helo=sin.lore.kernel.org;\n envelope-from=linux-tegra+bounces-13620-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"nkihFGBe\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201"],"Received":["from sin.lore.kernel.org (sin.lore.kernel.org\n [IPv6:2600:3c15:e001:75::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4frVtl5YwQz1xy1\n\tfor ; Thu, 09 Apr 2026 03:49:19 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sin.lore.kernel.org (Postfix) with ESMTP id BCC3530177B6\n\tfor ; Wed, 8 Apr 2026 17:47:38 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 665CD3D8907;\n\tWed, 8 Apr 2026 17:47:38 +0000 (UTC)","from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 26C723D88F5;\n\tWed, 8 Apr 2026 17:47:37 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id A8AEBC19421;\n\tWed, 8 Apr 2026 17:47:35 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1775670458; cv=none;\n b=jOqavKXzV4rcxYMfXFaXCGkdww4IAJHga5rQC2iXZVjYYk8FUW+RuPu5CMw8WC3FolMsW8uFWxSKp6OOmRbPz48etU4riisSmF5TgYpOk3VbN6cqhyjpUeWQVo2RLxmHZ9xbPRZD6MjSmxhrrQw2xgJODecNYxEN+TxuiT7+CNw=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1775670458; c=relaxed/simple;\n\tbh=9/klKvSlizIayUaxcYHHwAkDpZgPnGNGV0vnti6e/DE=;\n\th=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:\n\t Content-Type:Content-Disposition:In-Reply-To;\n b=JmFFAM12PGLnz8pHhdX8Rpzvebs6o5EOv0F0Lop9THksFadZEnSrP8THmpDtz7g/pMgP+nmNDPzIixz165FxXFEtpL15HQw8HsJlRjj272jMwDDw/gaP1jXgN2oM5dSUr0OccXju+kwDPxaMAbF4Cay9QSJ66fRVvy5o0HbOo6U=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=nkihFGBe; arc=none smtp.client-ip=10.30.226.201","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1775670457;\n\tbh=9/klKvSlizIayUaxcYHHwAkDpZgPnGNGV0vnti6e/DE=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=nkihFGBelbJSveqBK49nprxCicaenxXQ3u27vYfVfueA1vUqijM8WDOle3NgKT/Z2\n\t bVyiZtwYZSySKromJ/nbvZEzg72U+84bdor1RN52/p7Kez/xPtFhuNohD1Ch9AcSrc\n\t O29RhZtTOwbmSsGfhd1pYQ1VDp1/jRcaQRDgg7mU3m+XukF1KBuufzicPLawmHhlnA\n\t DEvhZ4al7tIWoa1K/ZwoxGWxVTWDNVJ4kw3wUgjcG0UKvA9c2ZDBQd1PoO8M1b5ut4\n\t YGyfzKtu4iIfIDbF3bC5aw3KDx9q1E+taACKGq13yWPKvyhy/xl0m4cugX6xcpDqLH\n\t Figc8t0yMAf6Q==","Date":"Wed, 8 Apr 2026 18:47:33 +0100","From":"Mark Brown ","To":"Piyush Patle ","Cc":"Sheetal , Jonathan Hunter ,\n\tThierry Reding ,\n\tLiam Girdwood ,\n\tJaroslav Kysela , Takashi Iwai ,\n\tKuninori Morimoto ,\n\tlinux-sound@vger.kernel.org, linux-tegra@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org","Subject":"Re: [PATCH v2 1/2] ASoC: tegra210_adx: simplify byte map get/put\n logic","Message-ID":"","References":"<20260407170308.100238-3-piyushpatle228@gmail.com>\n <20260408170818.70322-1-piyushpatle228@gmail.com>\n <20260408170818.70322-2-piyushpatle228@gmail.com>","Precedence":"bulk","X-Mailing-List":"linux-tegra@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha512;\n\tprotocol=\"application/pgp-signature\"; boundary=\"9uJ3Y4c7fwmPojbd\"","Content-Disposition":"inline","In-Reply-To":"<20260408170818.70322-2-piyushpatle228@gmail.com>","X-Cookie":"Often things ARE as bad as they seem!"}},{"id":3674997,"web_url":"http://patchwork.ozlabs.org/comment/3674997/","msgid":"","list_archive_url":null,"date":"2026-04-08T21:19:26","subject":"Re: [PATCH v2 1/2] ASoC: tegra210_adx: simplify byte map get/put\n logic","submitter":{"id":92665,"url":"http://patchwork.ozlabs.org/api/people/92665/","name":"Piyush Patle","email":"piyushpatle228@gmail.com"},"content":"On Wed, Apr 8, 2026 at 11:09 PM Jon Hunter wrote:\n>\n>\n> On 08/04/2026 18:08, Piyush Patle wrote:\n> > The byte-map controls (\"Byte Map N\") already expose a value range of\n> > [0, 256] to userspace via SOC_SINGLE_EXT(), where 256 is the\n> > \"disabled\" sentinel. The driver stored this state as a byte-packed\n> > u32 map[] array plus a separate byte_mask[] bitmap tracking which\n> > slots were enabled, because 256 does not fit in a byte. As a result\n> > get_byte_map() had to consult byte_mask[] to decide whether to\n> > report the stored byte or 256, and put_byte_map() had to keep the\n> > two arrays in sync on every write.\n> >\n> > Store each slot as a u16 holding the control value directly\n> > (0..255 enabled, 256 disabled). This is the native representation\n> > for what userspace already sees, so get_byte_map() becomes a direct\n> > return and put_byte_map() becomes a compare-and-store. The\n> > hardware-facing packed RAM word and the IN_BYTE_EN mask are now\n> > derived on the fly inside tegra210_adx_write_map_ram() from the\n> > slot array, which is the only place that needs to know about the\n> > hardware layout.\n> >\n> > The byte_mask scratch buffer is allocated dynamically using\n> > kcalloc() based on soc_data->byte_mask_size, removing dependency\n> > on SoC-specific constants. The byte_mask field is dropped from\n> > struct tegra210_adx.\n>\n> So this was already the case. However ...\n>\n>\n> > -static void tegra210_adx_write_map_ram(struct tegra210_adx *adx)\n> > +static int tegra210_adx_write_map_ram(struct tegra210_adx *adx)\n> > {\n> > + const unsigned int bits_per_mask = BITS_PER_TYPE(*adx->map) * BITS_PER_BYTE;\n> > + unsigned int *byte_mask;\n> > int i;\n> >\n> > + byte_mask = kcalloc(adx->soc_data->byte_mask_size, sizeof(*byte_mask),\n> > + GFP_KERNEL);\n> > + if (!byte_mask)\n> > + return -ENOMEM;\n> > +\n>\n> Now you are allocating this everytime this function is called (which\n> happens on RPM resume) instead of ...\n\nYou're right, I was wrong here. I read Sheetal's v1comment as\n\"allocate it dynamically\" and over-corrected by moving the\nallocation into write_map_ram() itself.\n\n>\n> > @@ -700,16 +706,15 @@ static int tegra210_adx_platform_probe(struct platform_device *pdev)\n> >\n> > regcache_cache_only(adx->regmap, true);\n> >\n> > - adx->map = devm_kzalloc(dev, soc_data->ram_depth * sizeof(*adx->map),\n> > - GFP_KERNEL);\n> > + adx->map = devm_kcalloc(dev,\n> > + soc_data->ram_depth * TEGRA_ADX_SLOTS_PER_WORD,\n> > + sizeof(*adx->map), GFP_KERNEL);\n> > if (!adx->map)\n> > return -ENOMEM;\n> >\n> > - adx->byte_mask = devm_kzalloc(dev,\n> > - soc_data->byte_mask_size * sizeof(*adx->byte_mask),\n> > - GFP_KERNEL);\n> > - if (!adx->byte_mask)\n> > - return -ENOMEM;\n>\n> ... here in the probe function, which makes more sense. IOW I am not\n> sure why you have changed this.\n>\n>\nThe intent was only to drop the dependency on\nthe SoC-specific TEGRA264_*_BYTE_MASK_COUNT\nconstant; the lifetime should still be probe-scoped\n\nFor v3 I'll keep byte_mask as a member of struct tegra210_adx and\nallocate it once in probe() with:\n\n adx->byte_mask = devm_kcalloc(dev, soc_data->byte_mask_size,\n sizeof(*adx->byte_mask),\n GFP_KERNEL);\n\nThat keeps Sheetal's \"no chip-specific constant\" requirement (size\nis still soc_data->byte_mask_size) while avoiding the per-RPM-resume\nallocation.\nI think that would be better, Right?\n\nSame change in tegra210_amx.c.","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-tegra@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=F8KQW8Bm;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c04:e001:36c::12fc:5321; helo=tor.lore.kernel.org;\n envelope-from=linux-tegra+bounces-13625-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=\"F8KQW8Bm\"","smtp.subspace.kernel.org;\n arc=pass smtp.client-ip=209.85.208.169","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=gmail.com"],"Received":["from tor.lore.kernel.org (tor.lore.kernel.org\n [IPv6:2600:3c04:e001:36c::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4frbZ66vrbz1xy1\n\tfor ; Thu, 09 Apr 2026 07:20:14 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id C117B301475E\n\tfor ; Wed, 8 Apr 2026 21:20:11 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id E653234B43F;\n\tWed, 8 Apr 2026 21:20:10 +0000 (UTC)","from mail-lj1-f169.google.com (mail-lj1-f169.google.com\n [209.85.208.169])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 4B955344DA2\n\tfor ; Wed, 8 Apr 2026 21:20:09 +0000 (UTC)","by mail-lj1-f169.google.com with SMTP id\n 38308e7fff4ca-38dd575bcf3so2020131fa.3\n for ;\n Wed, 08 Apr 2026 14:20:09 -0700 (PDT)"],"ARC-Seal":["i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1775683210; cv=pass;\n b=UtQNM2FO5fmvuTUkBXltAQCCoPImkWnVwl2g2roOU0EPnJ6drE1wCMG8gsF8k81JmEQyMGLPywzM1DwK9Dqx0uJ9794/eDnIgt4MgY7nrSar7lS/vvgFa+s/C0XVF5xI7uwfNErjn1eyQh/BG8uQ6IYlE0bpzQxqNM0gzRzoAKg=","i=1; a=rsa-sha256; t=1775683207; cv=none;\n d=google.com; s=arc-20240605;\n b=gj4pb+xSqdFp6mIT6Bg4IBLfmfAvde5TAXghVkTanodsgSx7/y2IPo9zlp1LNMkoc3\n xwqxK4Bg8iIs5PNuqVVzM66VqdbAnMgo0K1FIoC0+dJo8knUF3O+XW4suFeQDGCJjcra\n FFDVfm+Bb8XHvIL0LEieqafrPCMnnKxx7EQcAopUKyzgrePL55E5s1j+jwBWU9r+mVxo\n YeTZMcOafbpMzofJH2ypTj/oQLdZ8uNpIrRgpwOSjoa17prBe32jVcKFWyqDHIGYWigG\n vIbyIshN18IM9XGdjRfH95gsQPLhqOaDE3IpCNAnbHzD3jLryNr4qPOklxUSm3e3XGwb\n qCHA=="],"ARC-Message-Signature":["i=2; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1775683210; c=relaxed/simple;\n\tbh=w6HuGbAt29hunfsVixF+Oz6nMbU+6+kA8Wt8FyAQRNA=;\n\th=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:\n\t To:Cc:Content-Type;\n b=QHNUT+qlYx8AnYfJU86fgfk9wBXadTjZz9bOlA5WcgXCa7L5l113yya6OF1fuLi/K3WjTMMtqpNA3JakOK9RX162qvfuLsvAKGbXuPBTqo1jt0R2MhxzeDyBvyoSVfJ2f1xI+KeElT3v7ZJasg9htRaX610hsgfWQKtRcuqmx1c=","i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:dkim-signature;\n bh=EMCMLECo02eXBhSDMm1eRN49LeGDrS1E5IJtLpRBGmI=;\n fh=XNTFctSEdg/Je4Mw9KBMpJYsrIHfJCVjMNrFUNAVOXI=;\n b=l1svLdmv6WcbgH7SgFl8hPHHuariOk+Qnoao81DBUJ7tIO5TnY4tEwf64+GPQaVeOo\n QSe76xQGsMWTyamPDSFylE7ihQMOKev1u89u7N9A0/4pTZcv4j8WhZ0XYOvgvfhMxtrX\n zZHLQpLETEGZZP3pA/m80Q4saqFrBaxLnl8e2YMn30S+5f+UxQvK0J7bBZZbO3IiBGJB\n ScL7fOSYyIih+BJBI+9dQzNzo8Fvg1IH0uh1xMlZyslsHOTEPp827SbV1GZ4tEuxlJ4n\n TPVCDP3mpYvcnU5anDnq9SQdTqqY321Vxvucq36phdqvR5yTvmuHrZG3GeKaHCg+w+P1\n 3l3w==;\n darn=vger.kernel.org"],"ARC-Authentication-Results":["i=2; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com;\n spf=pass smtp.mailfrom=gmail.com;\n dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=F8KQW8Bm; arc=pass smtp.client-ip=209.85.208.169","i=1; mx.google.com; arc=none"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1775683207; x=1776288007;\n darn=vger.kernel.org;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:from:to:cc:subject:date\n :message-id:reply-to;\n bh=EMCMLECo02eXBhSDMm1eRN49LeGDrS1E5IJtLpRBGmI=;\n b=F8KQW8Bmb+MA6qkyODQLh88/V+GlS6du8nqcNK0ASAtXN7yk703km0+VX0zuqqRPgq\n 9pZprFTZxJdpbZayjTOwMqoqICtQ2iEs8Kzr5tloju6knt70LvX+E312hZVoDjGLfrLG\n Cy8Kjn3anaSUyDbElFtmGMlIcemT+dK6BZ2hWLQV+sm7tevlcwyHfLLvhVbeWb1MSDs6\n mxFqmRPDSkB05JPwUkYUpdaem1w4Uy4d7DIhEwLAJDN6/boGCPf94UbIMrixm5vObQfz\n SmrORHqWgQ8tGFEaVcdy2QM2WS2sILWS04pytik1YJo0NtKTgZkTd5I6SFG1/KYnSVnf\n w7rw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775683207; x=1776288007;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=EMCMLECo02eXBhSDMm1eRN49LeGDrS1E5IJtLpRBGmI=;\n b=ikqvvWCM0k7SWB187txczCXs0CLytf6+JX2FHO8lnCV7Tck75EPd1xby/v/+yaj245\n oo3L487TjqM8BhQkipPkP+1oqXVeTTuRx8LbB7omiQOVG8jk9bIr1yV7SfTqr6B+npUa\n YQJfEnVVv040pdO5LstEQgbEmH/Y0ZD5+lbUDe8Bt9EvSEObbGYoECDM/aa03FpoNiRL\n v58Q2Af4XXkUNOGIlSM9tYDME3k27qIZt9SJjhi6FQPzzrpR1h8iJBBuQ2DRcQ8gW8D6\n hlo3bq6XyQ/He9EkYr0CrHcrbYNMc2cLsd3d7ICNHBwzpZKMcAcDv9C1yw6yJEDsRCiN\n Qb+A==","X-Forwarded-Encrypted":"i=1;\n AJvYcCWL4BHrILjsM6rROLBwWbVYmQWn0E2eUJEdHUt+Jt2DFH2qmMt+sgyx0LeENmtKrWqO2H/ejM3OVN2BhQ==@vger.kernel.org","X-Gm-Message-State":"AOJu0YxmCVUwNRCy/BNQheX1wnsjlAqCP/NJ1so/Dtuq20n8U8HouaPK\n\t5DZJ2FHFwxkdvWbl9zXulIK3gZsub0RmDOAW+O9BPMDkkytDA6FWApRgY5BphA4zyP+vl3vgAOj\n\tYKLwIfJO0zCyCXC+dst/gWi/XEym1dTg=","X-Gm-Gg":"AeBDietncwcanuTFYosqt4QP/VzP+fuxKEh6Vgn0GWswOyUf3SU82mH2F/XkQ6MTqFq\n\t84JuKlF40kM/ZqtkCm136zEu8atpkYLCcSZD/NBAQSkLqE/FGaAyjkTTq+NV4ZA8cLyoQjt+V+x\n\tW9+SBFyc+f9/WJl8EgdXNFVG3B/XOBzV9XICxtCPoDF8jyjFBhV8tKPBCVdoDy7Sv0snn0oz9bm\n\txguwqy/e1TV6QeuodvZqAWjL+O4ajMTdtNFPeS8qtDXzpnKvOT0hD9BRkGslSvkFyxucg0sidQr\n\tPH493sk+xeAxAKpZI6RstjZA9ti14ELRo8Xo/M0=","X-Received":"by 2002:a05:6512:3e0e:b0:5a3:c690:b4a6 with SMTP id\n 2adb3069b0e04-5a3e7a16b15mr368920e87.7.1775683207122; Wed, 08 Apr 2026\n 14:20:07 -0700 (PDT)","Precedence":"bulk","X-Mailing-List":"linux-tegra@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","References":"<20260407170308.100238-3-piyushpatle228@gmail.com>\n <20260408170818.70322-1-piyushpatle228@gmail.com>\n <20260408170818.70322-2-piyushpatle228@gmail.com>\n ","In-Reply-To":"","From":"Piyush Patle ","Date":"Thu, 9 Apr 2026 02:49:26 +0530","X-Gm-Features":"AQROBzBUy-it-vv-kjO6ebLVhc04dn2olvWf_81zN6zTyAHrTx2NmaM7LrDNOQo","Message-ID":"\n ","Subject":"Re: [PATCH v2 1/2] ASoC: tegra210_adx: simplify byte map get/put\n logic","To":"Jon Hunter ","Cc":"Mark Brown , Sheetal ,\n\tThierry Reding ,\n Liam Girdwood ,\n\tJaroslav Kysela , Takashi Iwai ,\n\tKuninori Morimoto ,\n linux-sound@vger.kernel.org,\n\tlinux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable"}},{"id":3675000,"web_url":"http://patchwork.ozlabs.org/comment/3675000/","msgid":"","list_archive_url":null,"date":"2026-04-08T21:25:25","subject":"Re: [PATCH v2 1/2] ASoC: tegra210_adx: simplify byte map get/put\n logic","submitter":{"id":92665,"url":"http://patchwork.ozlabs.org/api/people/92665/","name":"Piyush Patle","email":"piyushpatle228@gmail.com"},"content":"> > +static int tegra210_adx_write_map_ram(struct tegra210_adx *adx)\n> > {\n> > + const unsigned int bits_per_mask = BITS_PER_TYPE(*adx->map) * BITS_PER_BYTE;\n>\n> Why are we multiplying by BITS_PER_BYTE here? We've got a number of\n> bits already from BITS_PER_TYPE().\n\nOkay correct, that's a bug BITS_PER_TYPE() already returns bits,\nso the extra * BITS_PER_BYTE is a unit error. It also references\nthe wrong type: the bitmap word is unsigned int (which is what the\noriginal code's hard-coded 32 came from), not the map element type.\n\nFor v3 I'll change it to:\n const unsigned int bits_per_mask = BITS_PER_TYPE(*adx->byte_mask);\n\n>\n> > + for (i = 0; i < adx->soc_data->ram_depth; i++) {\n> > + u32 word = 0;\n> > + int b;\n> > +\n> > + for (b = 0; b < TEGRA_ADX_SLOTS_PER_WORD; b++) {\n> > + unsigned int slot = i * TEGRA_ADX_SLOTS_PER_WORD + b;\n> > + u16 val = adx->map[slot];\n> > +\n> > + if (val >= 256)\n> > + continue;\n> > +\n> > + word |= (u32)val << (b * BITS_PER_BYTE);\n> > + byte_mask[slot / bits_per_mask] |= 1U << (slot % bits_per_mask);\n>\n> How big can bits_per_mask get?\n\nWith the fix above, bits_per_mask == BITS_PER_TYPE(unsigned int) ==\n32,\nmatching the original \"slot / 32\" / \"slot % 32\" expressions exactly.\n\n>\n> > @@ -118,9 +144,7 @@ static int tegra210_adx_runtime_resume(struct device *dev)\n> > regcache_cache_only(adx->regmap, false);\n> > regcache_sync(adx->regmap);\n> >\n> > - tegra210_adx_write_map_ram(adx);\n> > -\n> > - return 0;\n> > + return tegra210_adx_write_map_ram(adx);\n>\n> We need to unwind at least the regcache_cache_only() above if resume\n> fails.\n\nAs per Jon's comment on the same patch, I'm moving the\nbyte_mask buffer back to a probe-time devm_kcalloc() in v3, so\nwrite_map_ram() no longer has a failure path. runtime_resume() will\ngo back to returning 0 unconditionally and the regcache_cache_only()\nunwind won't be needed. If write_map_ram() ever grows another failure\nmode in the future, the unwind would have to be added then.\n\nThanks\nPiyush Patle","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-tegra@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=CTndhkJQ;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.234.253.10; helo=sea.lore.kernel.org;\n envelope-from=linux-tegra+bounces-13630-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=\"CTndhkJQ\"","smtp.subspace.kernel.org;\n arc=pass smtp.client-ip=209.85.208.170","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=gmail.com"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org [172.234.253.10])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4frbkm1jqFz1yD3\n\tfor ; Thu, 09 Apr 2026 07:27:44 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id 7C5EB30474D8\n\tfor ; Wed, 8 Apr 2026 21:26:09 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 49D2839EF39;\n\tWed, 8 Apr 2026 21:26:09 +0000 (UTC)","from mail-lj1-f170.google.com (mail-lj1-f170.google.com\n [209.85.208.170])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id BBDC8346AC3\n\tfor ; Wed, 8 Apr 2026 21:26:07 +0000 (UTC)","by mail-lj1-f170.google.com with SMTP id\n 38308e7fff4ca-38e09b14102so1772751fa.0\n for ;\n Wed, 08 Apr 2026 14:26:07 -0700 (PDT)"],"ARC-Seal":["i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1775683569; cv=pass;\n b=IDaFdnh2Co9NMi4nhvhvFcUFTH+e16qp0DraFjlpoRmEbEaY0N/wfNIu1KuHhn6lK3gqgze2dT8t3pk+oxyts0lUZt5izzVrHMpkXhROXBG8IsInQ7VDPGLOwMSmup0TFUGj+YrtXeLw/ouhqC9cW6DsX+JGG4SXKKXEt20b4YE=","i=1; a=rsa-sha256; t=1775683566; cv=none;\n d=google.com; s=arc-20240605;\n b=fEE0o5vA8gXeQOgu268a21EQTKGD4Gow10GP1YVxu9cGgu9vBLpckfo46C6yKbTK5Q\n 8vg+7X6m7RN5PUzT4wMHQRC3ZGRsHvWj2ryI0biWlrxRcagmHOw3Y8nFLc6x2w7CnCG5\n 3oXgR2i92V+/azUaexjXQLa450dfjD8MDJHICfuYCawGIIWQZ/tcpzL/J1ANF03OzJIQ\n lVyWPWrTOf3xM1IQ93jjwZyv4k/toCgAWxx2Xcs7Y1PrXRleOlAAhr1XugvIeae+nphY\n 50OzQQ8obQ2gmv7RrmwPKke/lM9OeaxLqGPo35VBW1+D6TBzv7iLQaURPY/ybyN5u3NR\n jOcA=="],"ARC-Message-Signature":["i=2; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1775683569; c=relaxed/simple;\n\tbh=IjEhnGk+PnwNFCcn8LSU9mwNYM/h4JiXspnBYoeLYKk=;\n\th=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject:\n\t To:Cc:Content-Type;\n b=M9gvRq1LwPsQHpHkqwaqiipfPJvHnusJQVzqpPDv2gU9Iab5nq35K5LBxO98Pvyv2GipiCb22lBEKJdKBwmROI88wzU40jHQmZHVhxwhpjDE5Jpubn/kfoxYA7VzuaCtHIIaYpLZTS2r1hs0FOqUc8KPzhiK7Na7AKpx7AmJu2w=","i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:dkim-signature;\n bh=dwZXnwgA8rxc31lodqUK1A0pWXEiOHI8DyLdgVyJCi8=;\n fh=MoAKbqoBghpw4CqgfheJfVxp2q+DAAC7fhyC09RAnFo=;\n b=c42hdXQlJwxEV2nid3Ub+nGkekN/X1CPUfuJk0Ylgt1+NtcA4/SQUs8UmQw3jSapyL\n R/8LhoODOK1YqlR4dal7ALGebBP7IWcpV9qtfXWMMlAbgzAMcDJCW/FG4nY1bWiPtCaP\n p3LSNBi/x2IaZffMX0iHr/NrWougmFX4aoELskrPOKq/cmII+JFqhbTVeXQkVD6k+l5K\n OrfSrXhbi8DWWdn0wUr0Dsq7iQgsTOCLz77N7Koxw7E1EOYDMbSrIP7P5xAC4tIBQc0V\n PzqHOQ3dIsMVB07AwtEV3e8UvGRHsuOKtRFhFeiWLlgnrOIAqH4kNES6B9RM/cPIJKCI\n S8dw==;\n darn=vger.kernel.org"],"ARC-Authentication-Results":["i=2; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com;\n spf=pass smtp.mailfrom=gmail.com;\n dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=CTndhkJQ; arc=pass smtp.client-ip=209.85.208.170","i=1; mx.google.com; arc=none"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1775683566; x=1776288366;\n darn=vger.kernel.org;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:from:to:cc:subject:date:message-id:reply-to;\n bh=dwZXnwgA8rxc31lodqUK1A0pWXEiOHI8DyLdgVyJCi8=;\n b=CTndhkJQ/Wq4jJ1qvXKvvzBYIJe+TDLnIZCEXNqKZdSZ+T82THRh4J7BSeg+q/sgxG\n +5MxHTJ6GpWg1ao88BdFJMvFzTmj8TPQLHOPfRSx8yTjYWDH3mkmKVzhMvCQqR7UCcNe\n 3NfN0dlYjcLt9ekb6mzQTGNC+hDhV/Z392oWuDX1gHOvU/y4iBZZeHsCQh7niIxWr3az\n oLi7/8YiX7JuEP4ImJFOjWicPC6X8s/MV67m5cE6/XEZbOvRw2Boetnu+V6lrIuk1zpg\n A9xx0lkqyk+WW8mGaG8NOsD87zppXnegvaTgXysEpzebCmpseIioV3Jqd3HyXBbJUYh9\n wKvQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775683566; x=1776288366;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=dwZXnwgA8rxc31lodqUK1A0pWXEiOHI8DyLdgVyJCi8=;\n b=Jgq/RUb+Mei2gX/DvCnh2GPM+Xfg68Da4FjFCe+UXdhFNWGR7zvrApsmVxcNOFJs2O\n NjVoePh6Xl40aO+k0YiYGyJYgerSGIC48Xw6E/Uitjm1I+XN+XQCfYmZ9A9V9wWCu9Q2\n iQbZOm0Qq179KUxW57ejk5KInqRchyb48IgdKr9TjKwXWU3IiKIXvu4xV3PvQIuLOghX\n F8nLCTP07EcGpUZSplo51u/t6dvAz5eW6dhlX3VYfe+ITrtwWGWQ6sORd2eQHM35cNy/\n C33Nwo7SfJTmKQAtdU5Ippy2NHWHy3851a125dym2jwVNPSb/huGxwQx5cKLrY1rb9m2\n Vynw==","X-Forwarded-Encrypted":"i=1;\n AJvYcCX+EojhgrV908Mf5Du1gYQgeMjhiRGvP6y+dv6n5/rxFGEW/vFw9kPXTCRi4zd4XTLysmikXqTBnUFfbQ==@vger.kernel.org","X-Gm-Message-State":"AOJu0YzS6ezTxzDZs0L8sDFTjcMmCVZzqQrZMf4zBAHdR3rJaW1mCuXg\n\tdWhBgr+SXPshMcsjDFKsJPN46ZFQuA/K6UEYLvTQHyy1UyxgRhhZIV53AdWVMVubK0Aq3mFaEBD\n\tCiMWSu/3olG7Cmwddjp0yRJl2qRWFugA=","X-Gm-Gg":"AeBDieueBoYkK5RwsYI8uGJ7ngnRF8sj3cePJuC4SWpVuXKsyRz2JfzRRap6cbvjGgl\n\t3PulBoOmozrejDJeYzxdGesLe4K1ddUKz67gfsLPzwfnq32kx6juebueXubRYTznhUNqzHNln4n\n\tdDAxFOF/7A3tGh8vLoqgeccfYqmL7juIT686tU7WKHs8Xuct4N2AqxY/uqwLUmjtdkB6JCD1sBB\n\t3gQzEF4czI7QXhGT14Af94zfG+S3obeUNmeZNNdbWETuQQy3Jo1DkykGmjDoEgJmqfm2cl7FWUw\n\tvGf3N6ZXwigZCvtM80LvKxQEEUOTCToOx2xAvUbQL2zeWr+vdQ==","X-Received":"by 2002:a05:6512:124c:b0:5a3:d306:297 with SMTP id\n 2adb3069b0e04-5a3e7a236e8mr378775e87.13.1775683565728; Wed, 08 Apr 2026\n 14:26:05 -0700 (PDT)","Precedence":"bulk","X-Mailing-List":"linux-tegra@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","References":"<20260407170308.100238-3-piyushpatle228@gmail.com>\n <20260408170818.70322-1-piyushpatle228@gmail.com>\n <20260408170818.70322-2-piyushpatle228@gmail.com>\n ","In-Reply-To":"","From":"Piyush Patle ","Date":"Thu, 9 Apr 2026 02:55:25 +0530","X-Gm-Features":"AQROBzBu6KzdQPIYr38nwiFPhnZEm0vYHac0EK6sgh9vp6wbo8mZ1lzGfAkVeSI","Message-ID":"\n ","Subject":"Re: [PATCH v2 1/2] ASoC: tegra210_adx: simplify byte map get/put\n logic","To":"Mark Brown ","Cc":"Sheetal , Jonathan Hunter ,\n\tThierry Reding ,\n Liam Girdwood ,\n\tJaroslav Kysela , Takashi Iwai ,\n\tKuninori Morimoto ,\n linux-sound@vger.kernel.org,\n\tlinux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org","Content-Type":"text/plain; charset=\"UTF-8\""}}]