[{"id":3676197,"web_url":"http://patchwork.ozlabs.org/comment/3676197/","msgid":"","list_archive_url":null,"date":"2026-04-11T17:39:24","subject":"Re: [PATCH v1 2/2] test: env: add test for himport_r SIZE_MAX\n overflow guard","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/people/6170/","name":"Simon Glass","email":"sjg@chromium.org"},"content":"Hi Aristo,\n\nOn 2026-04-08T14:03:35, Aristo Chen wrote:\n> test: env: add test for himport_r SIZE_MAX overflow guard\n>\n> Add a unit test that verifies himport_r rejects SIZE_MAX as the size\n> argument, ensuring the integer overflow guard added to lib/hashtable.c\n> is exercised and not accidentally regressed.\n>\n> Signed-off-by: Aristo Chen \n>\n> test/env/hashtable.c | 17 +++++++++++++++++\n> 1 file changed, 17 insertions(+)\n\n> diff --git a/test/env/hashtable.c b/test/env/hashtable.c\n> @@ -122,3 +122,20 @@ static int env_test_htab_deletes(struct unit_test_state *uts)\n> + /* SIZE_MAX would cause malloc(size + 1) to wrap to malloc(0) */\n> + ut_asserteq(0, himport_r(&htab, \"\", SIZE_MAX, '\\0', 0, 0, 0, NULL));\n\nPlease can you add a check that errno is set to EINVAL after the\nhimport_r() call?\n\nIt's a pretty old API that!\n\nReviewed-by: Simon Glass \n\nRegards,\nSimon","headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org header.a=rsa-sha256\n header.s=google header.b=iScYyK6w;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=chromium.org header.i=@chromium.org\n header.b=\"iScYyK6w\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=none dis=none) header.from=chromium.org","phobos.denx.de;\n spf=pass smtp.mailfrom=sjg@chromium.org"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4ftLXR1bcDz1y2d\n\tfor ; Sun, 12 Apr 2026 03:39:50 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id 0202384118;\n\tSat, 11 Apr 2026 19:39:48 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id CE83C84154; Sat, 11 Apr 2026 19:39:46 +0200 (CEST)","from mail-pg1-x530.google.com (mail-pg1-x530.google.com\n [IPv6:2607:f8b0:4864:20::530])\n (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 9DB5783DC9\n for ; Sat, 11 Apr 2026 19:39:44 +0200 (CEST)","by mail-pg1-x530.google.com with SMTP id\n 41be03b00d2f7-c766a95a72dso2027594a12.1\n for ; Sat, 11 Apr 2026 10:39:44 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,\n DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,\n RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham\n autolearn_force=no version=3.4.2","ARC-Seal":"i=1; a=rsa-sha256; t=1775929183; cv=none;\n d=google.com; s=arc-20240605;\n b=WtCILOxvG/uttySyPdF2A2OSfAzGlUTQJQ29JGjOYYU99wf19cBeuBiBYpqhq41NSj\n PvUhGK4bDjwWG2yFCDmjJWvwKl+ZsUkh8Z9gAdVdcY/MH+PoYTn4AP5Ex2Ict++ZKcL6\n zhhxcS5se0wBbiaKMrZBcI6oMScQ+6MSaWRDXFsbbl7mPvqhv4nuEiNS4cI06RH+EwxO\n AWiIUqS16/j6+K1eomp0AVEfWjhMXNI/x1zVoCUl7Rahu6THyVTt/J4Wllhcd2VSZWEy\n PAqaBuU0tReZb7rB6BRNAmzYmQfAzwIZl+G2b5TthMo07VoDaSkIG29KLH6EVg/DF4iq\n y+UQ==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:dkim-signature;\n bh=6lEbo0zYPwTdJL7kyJ2Xzt2F01WOM7CTr2fXCAeyeew=;\n fh=RMotW0d5XlV4ufFtnrZdzQ0yk4gZppNtVCUWCpNgShU=;\n b=LOzK5wOrQm+N1+5+sZF/6IoBRze+d9RZJwng+irXRdv74ee6Q32G6ltCYLRZXufdzJ\n SCzMX/OCgwkcY3m3o/rfROFBYby+MGKDcZcliuUk/mnIb0QACSmdXJTNORgl3CKEChg0\n YvGUzQHbH3vY6tV3GEHdJAOXriS5KNzSMgF8EqcAQRAQV8Ttv0XBc7uGrMpNCxMnWW/z\n 8Gr7mlwYJP91XYk1qjwmSWRmOo0kbZYb239OPkofcThQqZvh3yAyoP1/G2W0QiO+cCp9\n k4HnrgJzWxtdMvwyBxhke53tnde/yDMK4fdWvRBuv6+XL03awxhFKqh8X0llir177nuv\n 8TMg==; darn=lists.denx.de","ARC-Authentication-Results":"i=1; mx.google.com; arc=none","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=chromium.org; s=google; t=1775929183; x=1776533983; darn=lists.denx.de;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:from:to:cc:subject:date:message-id:reply-to;\n bh=6lEbo0zYPwTdJL7kyJ2Xzt2F01WOM7CTr2fXCAeyeew=;\n b=iScYyK6wH9kw3l9qm8Hf8IlOK0KIZ3XJdEorZUfdDNP6eNAyjYskIYxtnt9ndfXZiY\n DLJswE7h7rr54Wwlw55AkCE9/vw7iXnb+1K60/+LqprHC6PRpMP8pMU/s9YyDAf3vzwH\n CB942DT6fV+BOM5725Vz41Od7phjcLl0MPs1s=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775929183; x=1776533983;\n h=cc:to:subject:message-id:date:from:in-reply-to:references\n :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date\n :message-id:reply-to;\n bh=6lEbo0zYPwTdJL7kyJ2Xzt2F01WOM7CTr2fXCAeyeew=;\n b=FNMMliU6oLDmU6cNtJJdluZZhxtGv6j52nEDn4R+yhMY9yE9YmDwHipU0q6HMQjEpm\n ZHKjTMnUiXrc/JgSqGGnLAGkCKomcGLKhEIyZAMeK5o5uULvf5khp3Uof8kNtAAC3PEs\n 1Rd08/Bs9qnn6Gi+itFiOlUltXiiP8wc4emCRp+KTBj9mNE/xXGn9v8lW9uGMqwW4v8g\n +8el/OK2+HNSsKluv6U19SH9gnNpNrVnvC+mI2GZy6L1jB9sYBjKIKO2YO3Rfo2+BjLa\n 8lKYoBUHjs4aMvu3GxLc6bIf7qRhPlP61XjkhgnoMeP7GmoElAjTthLivv0sCLKR2v96\n HaWQ==","X-Gm-Message-State":"AOJu0YxoyfevWazdu0mEl/PLpP1aVApcS4xivDbs/Sqckt90tFurxiNP\n KudSa56AyB6LM6P8nkaWgzCIyPJJVo97plZ8YIgJ+W0xDdcj1oJ9syAzP0dg5cJCExZ3Xm7zaXp\n 0aNzpuU5Mnq2dj+FrwwJnZ9O6aJKST6vCKqL+vxP/He1QQf90eerEcCLq","X-Gm-Gg":"AeBDievGBbtq5foY0xuiR471qu2fjf8i1QjeNI7xB1vM51HO0ui0fanoEjBPJ61dEXP\n z6jNvs0em3ORmwBoViczlQkWRlfsLvXeuSim77oHZOLosqSVu6wil6FrSRNfGdOJH4TEubjVXDy\n uC3+7J3F8fFrRS/z+RhvI1WQqpYJ0x6cEKaTfpY2bZ0zE2ov50TsVkxh0LkS05VNxyz4CMKUP9y\n Y3jrmBBdLpEv/EJxYysD1ojK8lFXar+d3VUCjvSfoRTH7+sORMMqPc9DAWY05m/XFwLd0Fu/clC\n y2jezA==","X-Received":"by 2002:a05:6a00:2d85:b0:82c:9126:31e3 with SMTP id\n d2e1a72fcca58-82f0c31050amr8568818b3a.26.1775929183029; Sat, 11 Apr 2026\n 10:39:43 -0700 (PDT)","MIME-Version":"1.0","References":"<20260408140339.798015-1-aristo.chen@canonical.com>\n <20260408140339.798015-2-aristo.chen@canonical.com>","In-Reply-To":"<20260408140339.798015-2-aristo.chen@canonical.com>","From":"Simon Glass ","Date":"Sat, 11 Apr 2026 11:39:24 -0600","X-Gm-Features":"AQROBzA5OsO_lWqmSomBn6E6Q7Of7o4XWcnMf5a3VYoKLs4lmtH4peoH1AM70l4","Message-ID":"\n ","Subject":"Re: [PATCH v1 2/2] test: env: add test for himport_r SIZE_MAX\n overflow guard","To":"aristo.chen@canonical.com","Cc":"u-boot@lists.denx.de, Tom Rini ","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" ","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"}}]