[{"id":3675058,"web_url":"http://patchwork.ozlabs.org/comment/3675058/","msgid":"","list_archive_url":null,"date":"2026-04-09T03:21:10","subject":"Re: [PATCH] RISC-V: Fix Zbkb single-bit IOR/XOR synthesis [PR124818]","submitter":{"id":92310,"url":"http://patchwork.ozlabs.org/api/people/92310/","name":"Jeffrey Law","email":"jeffrey.law@oss.qualcomm.com"},"content":"On 4/8/2026 10:54 AM, Christoph Müllner wrote:\n> Only Zbs provides the bseti/binvi support that can directly handle a\n> large single-bit immediate in scalar IOR/XOR operations. Zbkb alone\n> does not, but synthesize_ior_xor treated Zbkb as sufficient and\n> returned false for such constants.\n>\n> On RV32 with -march=rv32gc_zbkb this leaves an unmatchable\n> (ior:SI reg (const_int 0x20000)) RTL insn, which later triggers an ICE\n> in extract_insn during virtual register instantiation.\n>\n> Restrict the single-bit fast path to Zbs and add an RV32 Zbkb\n> regression test for the reduced reproducer.\n>\n> \tPR target/124818\n>\n> gcc/ChangeLog:\n>\n> \t* config/riscv/riscv.cc (synthesize_ior_xor): Do not treat\n> \tTARGET_ZBKB as sufficient for single-bit immediate IOR/XOR.\n>\n> gcc/testsuite/ChangeLog:\n>\n> \t* gcc.target/riscv/pr124818.c: New test.\nThis is almost certainly a 16 regression.  OK for the trunk.\n\nJeff","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","gcc-patches@gcc.gnu.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","gcc-patches@gcc.gnu.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256\n header.s=qcppdkim1 header.b=XgBNd088;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n header.a=rsa-sha256 header.s=google header.b=O4NWwa7Z;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org\n (client-ip=2620:52:6:3111::32; helo=vm01.sourceware.org;\n envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org;\n receiver=patchwork.ozlabs.org)","sourceware.org;\n\tdkim=pass (2048-bit key,\n unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256\n header.s=qcppdkim1 header.b=XgBNd088;\n\tdkim=pass (2048-bit key,\n unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n header.a=rsa-sha256 header.s=google header.b=O4NWwa7Z","sourceware.org; dmarc=none (p=none dis=none)\n header.from=oss.qualcomm.com","sourceware.org;\n spf=pass smtp.mailfrom=oss.qualcomm.com","server2.sourceware.org;\n arc=none smtp.remote-ip=205.220.168.131"],"Received":["from vm01.sourceware.org (vm01.sourceware.org\n [IPv6:2620:52:6:3111::32])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4frlbK0yR6z1yD3\n\tfor ; Thu, 09 Apr 2026 13:21:47 +1000 (AEST)","from vm01.sourceware.org (localhost [127.0.0.1])\n\tby sourceware.org (Postfix) with ESMTP id 6486E4BA2E09\n\tfor ; Thu, 9 Apr 2026 03:21:45 +0000 (GMT)","from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com\n [205.220.168.131])\n by sourceware.org (Postfix) with ESMTPS id D19674BA2E08\n for ; Thu, 9 Apr 2026 03:21:14 +0000 (GMT)","from pps.filterd (m0279864.ppops.net [127.0.0.1])\n by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 6392GUS8061673\n for ; Thu, 9 Apr 2026 03:21:13 GMT","from mail-dy1-f200.google.com (mail-dy1-f200.google.com\n [74.125.82.200])\n by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dduvv1qea-1\n (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT)\n for ; Thu, 09 Apr 2026 03:21:13 +0000 (GMT)","by mail-dy1-f200.google.com with SMTP id\n 5a478bee46e88-2d3a617ad90so1136511eec.0\n for ; Wed, 08 Apr 2026 20:21:13 -0700 (PDT)","from [172.31.0.25] ([136.38.201.137])\n by smtp.gmail.com with ESMTPSA id\n 5a478bee46e88-2cba5df5c24sm22218327eec.27.2026.04.08.20.21.11\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Wed, 08 Apr 2026 20:21:11 -0700 (PDT)"],"DKIM-Filter":["OpenDKIM Filter v2.11.0 sourceware.org 6486E4BA2E09","OpenDKIM Filter v2.11.0 sourceware.org D19674BA2E08"],"DMARC-Filter":"OpenDMARC Filter v1.4.2 sourceware.org D19674BA2E08","ARC-Filter":"OpenARC Filter v1.0.0 sourceware.org D19674BA2E08","ARC-Seal":"i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1775704875; cv=none;\n b=xjlTDsNxAUzupqW4eTzdogJB7yfrWdU6W/mtFPA0FZ7cDOtjGsgPJ+9gpAoD53YSM2f1wRPsf2n0zmBF7v0B4IfaZms8+1qPlpZzV37fUqWtdhwaRyYLFk1/8hQu9gEiV8xhfHsvl+DqGiWSTX5/kp5HMs6YRD+PksVNAEuK0a4=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=sourceware.org; s=key;\n t=1775704875; c=relaxed/simple;\n bh=eqhOgWIie24D8nk5z2oVzE1+shHUNMOE/De651o7C/g=;\n h=DKIM-Signature:DKIM-Signature:Message-ID:Date:MIME-Version:\n Subject:To:From;\n b=VQh+oA9WEpm7MH0EeDNzZOGrVlkCp1M9nBusU9jEXwm4+xnXv75zbMPlDVw7jwa/cWdGqnTb1cMfb9x0mzRetKfeerNZxibMKoWCwRCMOTij9zvtEblpro5Zqmo8Q642CvrIg9I0gRwlGYZalAdmBh/mN6YTg683Y0pJAmBZLQU=","ARC-Authentication-Results":"i=1; server2.sourceware.org","DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h=\n content-transfer-encoding:content-type:date:from:in-reply-to\n :message-id:mime-version:references:subject:to; s=qcppdkim1; bh=\n toNBOCY+Mf4hZGmFS+1r8L5sYhaciyMHZNeGAGRxIeQ=; b=XgBNd088CPTzjUyW\n 7f0qwIh3dS+v2UIPoHLfZ+9eXisFlO/EBvRa1nZrjVLV3j8c0ujqtaOT9PfLUo0F\n lUPMVCt4vDIUhKptyKGdf+l3StfUTUYe7tt7+2SEVhjkz2Qs6dVrkxqS7kjhr17a\n p+XhFTcipUl4YAhihPbigyxYXgP+JDuKzy67J4sGwXZrGHq+r2xhnvBAAaEOAYem\n B7WD/QivYQXKV9hrN1/fPokk/1cBxvBISvpOflh3UiAzhypmxK8bs3LLkLEHFVmU\n 8vxem+h9wXJj9tOTrkK1sC4FK1vxBulThEN+tuKki4DOqXkhE5dk9//F6dEhsiaJ\n b/i2qQ==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=oss.qualcomm.com; s=google; t=1775704873; x=1776309673; darn=gcc.gnu.org;\n h=content-transfer-encoding:in-reply-to:from:content-language\n :references:to:subject:user-agent:mime-version:date:message-id:from\n :to:cc:subject:date:message-id:reply-to;\n bh=toNBOCY+Mf4hZGmFS+1r8L5sYhaciyMHZNeGAGRxIeQ=;\n b=O4NWwa7ZvfEjTdjpDf6NhV4lCoq1DD3rGCeGcWA3OqAodsxa16VFX9BlTvvHU7bMpT\n CAkCVjYXqGg6ca/H4RYBANRw3UiW8ealL5JztBzTfkYydXgGX48HNL6i2gHGP3u5dH/G\n qgulugHt75SpxXNyQMEfHstgsaEebAhQYfKEHsrCPFFmcRpF1P4CGZcuJglExs0iCerS\n UmGQOEWP9LjPdVJuOme/7AblaQwIBTHqcJxRc9ctDNAwpNGWDuRxxvjU/w88uKYXLcXY\n +152xj4tII7gKWMtTkbdXVFyuNbmS7RbxGEb5tEFODoBtnP979nm0WgnMsmtIYDQ4YL0\n /ISQ=="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775704873; x=1776309673;\n h=content-transfer-encoding:in-reply-to:from:content-language\n :references:to:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=toNBOCY+Mf4hZGmFS+1r8L5sYhaciyMHZNeGAGRxIeQ=;\n b=nul/DCIzqyqe9KAMdwqNaQsupRYTenBqRQRKA2uPlcda8dUcxfoeHCno5oqbddjW3c\n vncnzz9C4uTA+Nh5IT9nSPOOsxJL4VazAJxtR9BoJEtC09MAUmmUQ2vzf3/PWb8xR8Y7\n QD0cqfmjKX4hM75muPhTvoKQ11dAHmjFYFxk9DafEfJMtbzSn+LFPNcINpu+se51j3cL\n AEC5KtOq5Po/i149fT3hSQKf3yzzcQhMME2+ntze1dkXX2MMpHmoMW7LWHGgLpB9mm3A\n c2gqVycuDKLy3I/yzGV3Fxe1tEDY7UxJ6nofvVBc4CvLvpiA+5W3RDsOr8Yw3IaofZxA\n /FBA==","X-Forwarded-Encrypted":"i=1;\n AJvYcCWXY6KwlYFeHYrIXn4HHXGeXi2v9SFFEJaTN1071DS4rIBsMTsh2D3jPVOLFfQU8peyF/VTWzL6YlPdEw==@gcc.gnu.org","X-Gm-Message-State":"AOJu0Yziw5Op45FzmZ/dle0I2XUQw7WgbrqoS4bjp0vL0pXmPFewLjta\n YpPkIhjawcNbGTr2Rg5njAYIKv1BD7hgh4YveXGJtp13Bqa+0J5EE6JHvO2+f5a+uKZz/rrij29\n uvIZjbTFk8dCRsX6/pQ483UTczsBb1nlpuHCNnjAyH1t306d1agEDsu7fqUGR","X-Gm-Gg":"AeBDieulxsY2CFaxgzbG5ZAEEK771wU7ZeHdJqu9RvVzQubScsyRMXH4VmNIx7pgm+E\n cjOFYel4dFnbvMcpPkxdyywxg26Pql6wyCwKBBB62VBcGPmcUK3jlwkwPUnzzEJln0NichG38v+\n TYZl2dtyI5UgqTL+F7qHAWIctLyUDfBELDcMPs0wKTAGDAqZreh864XPeKnSaqfnwiAO5jSQbN6\n Ezxu839adjE87No10w0wg2c/+Zt8ZBhDAgkhwuAjkVT81SFd3SCap9fitq/LCd7rfLSrbxJRa9Z\n Pyp8TDp70JarQIrGsbBqoaxsOLZ2skG6NHAy83ExX7iL3V5uxYPu72KUqyIGImPoWqdNakcymq4\n rfE7oX0Yl5cfCCH/1K0d4h42bb0ZpbM9QhK6RVA28/BttlcDM6A==","X-Received":["by 2002:a05:7300:7f9f:b0:2d3:9c91:6c49 with SMTP id\n 5a478bee46e88-2d39c916ec5mr1948287eec.30.1775704872717;\n Wed, 08 Apr 2026 20:21:12 -0700 (PDT)","by 2002:a05:7300:7f9f:b0:2d3:9c91:6c49 with SMTP id\n 5a478bee46e88-2d39c916ec5mr1948265eec.30.1775704872136;\n Wed, 08 Apr 2026 20:21:12 -0700 (PDT)"],"Message-ID":"","Date":"Wed, 8 Apr 2026 21:21:10 -0600","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH] RISC-V: Fix Zbkb single-bit IOR/XOR synthesis [PR124818]","To":"=?utf-8?q?Christoph_M=C3=BCllner?= ,\n gcc-patches@gcc.gnu.org, Kito Cheng ,\n Palmer Dabbelt , Robin Dapp ,\n Andrew Waterman , Jim Wilson ,\n Jeff Law ,\n Shreya Munnangi ","References":"<20260408165426.4154722-1-christoph.muellner@vrull.eu>","Content-Language":"en-US","From":"Jeffrey Law ","In-Reply-To":"<20260408165426.4154722-1-christoph.muellner@vrull.eu>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwNDA5MDAyOCBTYWx0ZWRfX+RfwIqs2TVcl\n ehV96cOpU7sSINyIHzXEpWA6EwYxZly3G+uU0DeLP/+ORJXxpmIj9krJaf0Dy2qAjeDjL+NnI9a\n XE/jehaeFH6vTWucgIcCasBWgglecGsT65UzAH/xoYmrbzPLHCqsp8Cl/0rIDXbJMdLXneiVI//\n kYMMz7jdOjizHLs7eD8JtgYu3s2oagEq00iGw/zE8xO70/8QUgtzgbU55BrOpYePKpXIx/QFB0F\n NoRhc94szs1h4rikAaTYEPhwuhRvUiJ26POwq8wJBr1kVnbiImF52q5p7PHFRP/2lXVSoiVIrLx\n o3dhjxfzsjfExBSHBxaP4kYjlFfaRVAc/iTGHZMs43DVUD0GT2jaDSpkFwRyYRXl7LgTnlmPFGE\n BMOae6fO3f4QGLmisUGm9kmF1xj9jGoIIzZcKxvLPan3Kc/2W29wl7yzDNMS9sWMAO6rmYDButm\n aYL0VYNZOPD6dJBvbEw==","X-Authority-Analysis":"v=2.4 cv=DrxmPm/+ c=1 sm=1 tr=0 ts=69d71b29 cx=c_pps\n a=PfFC4Oe2JQzmKTvty2cRDw==:117 a=asGLMfRmzhnGNxaIYohjRg==:17\n a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10\n a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22\n a=m-gV37XQk2GePPpxiSgA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10\n a=6Ab_bkdmUrQuMsNx7PHu:22","X-Proofpoint-ORIG-GUID":"PlA8AbgzGbJJU8Bw5FlrGvNpGZF-nKd_","X-Proofpoint-GUID":"PlA8AbgzGbJJU8Bw5FlrGvNpGZF-nKd_","X-Proofpoint-Virus-Version":"vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-04-09_01,2026-04-08_01,2025-10-01_01","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n malwarescore=0 impostorscore=0 phishscore=0 suspectscore=0 bulkscore=0\n priorityscore=1501 clxscore=1015 lowpriorityscore=0 adultscore=0 spamscore=0\n classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0\n reason=mlx scancount=1 engine=8.22.0-2604010000 definitions=main-2604090028","X-BeenThere":"gcc-patches@gcc.gnu.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Gcc-patches mailing list ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org"}}]