[{"id":3675042,"web_url":"http://patchwork.ozlabs.org/comment/3675042/","msgid":"<177569945304.949482.10774857473121933938.git-patchwork-notify@kernel.org>","list_archive_url":null,"date":"2026-04-09T01:50:53","subject":"Re: [PATCH net 1/7] ipvs: fix NULL deref in ip_vs_add_service error\n path","submitter":{"id":80291,"url":"http://patchwork.ozlabs.org/api/people/80291/","name":null,"email":"patchwork-bot+netdevbpf@kernel.org"},"content":"Hello:\n\nThis series was applied to netdev/net.git (main)\nby Florian Westphal :\n\nOn Wed, 8 Apr 2026 18:35:06 +0200 you wrote:\n> From: Weiming Shi \n> \n> When ip_vs_bind_scheduler() succeeds in ip_vs_add_service(), the local\n> variable sched is set to NULL. If ip_vs_start_estimator() subsequently\n> fails, the out_err cleanup calls ip_vs_unbind_scheduler(svc, sched)\n> with sched == NULL. ip_vs_unbind_scheduler() passes the cur_sched NULL\n> check (because svc->scheduler was set by the successful bind) but then\n> dereferences the NULL sched parameter at sched->done_service, causing a\n> kernel panic at offset 0x30 from NULL.\n> \n> [...]\n\nHere is the summary with links:\n - [net,1/7] ipvs: fix NULL deref in ip_vs_add_service error path\n https://git.kernel.org/netdev/net/c/9a91797e61d2\n - [net,2/7] netfilter: nfnetlink_log: initialize nfgenmsg in NLMSG_DONE terminator\n https://git.kernel.org/netdev/net/c/1f3083aec883\n - [net,3/7] netfilter: xt_multiport: validate range encoding in checkentry\n https://git.kernel.org/netdev/net/c/ff64c5bfef12\n - [net,4/7] netfilter: ip6t_eui64: reject invalid MAC header for all packets\n https://git.kernel.org/netdev/net/c/fdce0b3590f7\n - [net,5/7] netfilter: nft_ct: fix use-after-free in timeout object destroy\n https://git.kernel.org/netdev/net/c/f8dca15a1b19\n - [net,6/7] netfilter: nfnetlink_queue: make hash table per queue\n https://git.kernel.org/netdev/net/c/936206e3f6ff\n - [net,7/7] selftests: nft_queue.sh: add a parallel stress test\n https://git.kernel.org/netdev/net/c/dde1a6084c5c\n\nYou are awesome, thank you!","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","netfilter-devel@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=VzNMksFH;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c04:e001:36c::12fc:5321; helo=tor.lore.kernel.org;\n envelope-from=netfilter-devel+bounces-11749-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"VzNMksFH\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201"],"Received":["from tor.lore.kernel.org (tor.lore.kernel.org\n [IPv6:2600:3c04:e001:36c::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4frjb500dcz1yD3\n\tfor ; Thu, 09 Apr 2026 11:51:28 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id A9560301E7FF\n\tfor ; Thu, 9 Apr 2026 01:51:19 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id CFFC3363C6F;\n\tThu, 9 Apr 2026 01:51:17 +0000 (UTC)","from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 57C6E3630B2;\n\tThu, 9 Apr 2026 01:51:17 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id F39B3C2BC9E;\n\tThu, 9 Apr 2026 01:51:16 +0000 (UTC)","from [10.30.226.235] (localhost [IPv6:::1])\n\tby aws-us-west-2-korg-oddjob-rhel9-1.codeaurora.org (Postfix) with ESMTP id\n 7CF783930793;\n\tThu, 9 Apr 2026 01:50:54 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1775699477; cv=none;\n b=E2IjT2E7b4jRjpwkJz5gpGEREpfTr0nvbtBvhm+uIY0vPcRK/5GqRMEF+UOv/Js3Zfr69kTokgZhFj/ygXWi0ldaTUnxOpHBb4JwqDm34b2nTMJQNmGUvY29UbJNxpqTEGO59VbhfgI2mp7G9bW1HnlRgLikqXpeMy7ZjxeneNU=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1775699477; c=relaxed/simple;\n\tbh=4tiPiLc0ubj/toDkCFd3Kanmf/vGuOCItA7BcG8m7dI=;\n\th=Content-Type:MIME-Version:Subject:From:Message-Id:Date:References:\n\t In-Reply-To:To:Cc;\n b=G6kb3aDmCHmY7Kt8Ujy6KvjpppJ+vH0gLOC2E7muUViUYSGGcsZGTBXR1SabAhTbJ0FWqirifyTAPwNkCllNZapR/IEFgpGRt55ARhOMBUQTXuENWOcw7C0oPm8cIKAGAgdIV2MC68p8QCoMx8fWJWoJ4iKSOiUZ6q5ChFEWgdo=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=VzNMksFH; arc=none smtp.client-ip=10.30.226.201","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1775699477;\n\tbh=4tiPiLc0ubj/toDkCFd3Kanmf/vGuOCItA7BcG8m7dI=;\n\th=Subject:From:Date:References:In-Reply-To:To:Cc:From;\n\tb=VzNMksFHoV6aND36MDY/hkIUoZUAU0zwJ82EBaLrq/HspZiycQmenGv+jqdSO1qfy\n\t o+XGCaigT6yDgeqnDdMpdfCkaGAhAjB23Z0+rTzBOzqPVgpqbjY4jTkKadJs4Ri9eT\n\t r0BYI5wU2fAcFHrqgUBnO/IXiZjIMe5B9gXndAxjDrCZcvdnjJlexiprj1u+qoBkF9\n\t 2IkVaJYwn094Ll7GTzdsImsrm8p5Mzfd3JsB0ZUp20jjCJfxxE4S8tqiF42vVb1dO1\n\t 4rzO8mvya9c7jAZrP2tL+A2qobpUGpIYdAPPCYHt3kX1Tqx0k7scvgPyr0CxeyDHn0\n\t zPbxm4Jm4YkKw==","Content-Type":"text/plain; charset=\"utf-8\"","Precedence":"bulk","X-Mailing-List":"netfilter-devel@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"Re: [PATCH net 1/7] ipvs: fix NULL deref in ip_vs_add_service error\n path","From":"patchwork-bot+netdevbpf@kernel.org","Message-Id":"\n <177569945304.949482.10774857473121933938.git-patchwork-notify@kernel.org>","Date":"Thu, 09 Apr 2026 01:50:53 +0000","References":"<20260408163512.30537-2-fw@strlen.de>","In-Reply-To":"<20260408163512.30537-2-fw@strlen.de>","To":"Florian Westphal ","Cc":"netdev@vger.kernel.org, pabeni@redhat.com, davem@davemloft.net,\n edumazet@google.com, kuba@kernel.org, netfilter-devel@vger.kernel.org,\n pablo@netfilter.org"}}]