[{"id":3674911,"web_url":"http://patchwork.ozlabs.org/comment/3674911/","msgid":"","list_archive_url":null,"date":"2026-04-08T19:01:08","subject":"Re: [PATCH] ifcvt: reject use of ctrap post reload [PR 105192]","submitter":{"id":91428,"url":"http://patchwork.ozlabs.org/api/people/91428/","name":"Andrew Pinski","email":"andrew.pinski@oss.qualcomm.com"},"content":"On Wed, Apr 8, 2026 at 8:24 AM Xi Ruoyao wrote:\n>\n> The ctrap expanders of several targets can end up creating pseudos. And\n> it would be really counter-intuitive to disallow a define_expand to\n> generate pseudos. So don't invoke the expander post reload.\n>\n> PR target/105192\n>\n> gcc/\n>\n> * ifcvt.cc (find_if_header): Don't attempt to use ctrap expander\n> after reload.\n\nOk for all branches. There is maybe a small missed optimization for\nsome targets after this patch but I think that is ok.\n\nThanks,\nAndrew\n\n>\n> gcc/testsuite/\n>\n> * gcc.c-torture/compile/pr105192.c: New test.\n> ---\n>\n> Bootstrapped and regtested on x86_64-linux-gnu and\n> mips64el-linux-gnuabi64. Ok for trunk?\n>\n> gcc/ifcvt.cc | 2 +-\n> gcc/testsuite/gcc.c-torture/compile/pr105192.c | 9 +++++++++\n> 2 files changed, 10 insertions(+), 1 deletion(-)\n> create mode 100644 gcc/testsuite/gcc.c-torture/compile/pr105192.c\n>\n> diff --git a/gcc/ifcvt.cc b/gcc/ifcvt.cc\n> index 7f5af2ca915..c151146c1b2 100644\n> --- a/gcc/ifcvt.cc\n> +++ b/gcc/ifcvt.cc\n> @@ -5180,7 +5180,7 @@ find_if_header (basic_block test_bb, int pass)\n> && cond_exec_find_if_block (&ce_info))\n> goto success;\n>\n> - if (targetm.have_trap ()\n> + if (!reload_completed && targetm.have_trap ()\n> && optab_handler (ctrap_optab, word_mode) != CODE_FOR_nothing\n> && find_cond_trap (test_bb, then_edge, else_edge))\n> goto success;\n> diff --git a/gcc/testsuite/gcc.c-torture/compile/pr105192.c b/gcc/testsuite/gcc.c-torture/compile/pr105192.c\n> new file mode 100644\n> index 00000000000..0cc61505218\n> --- /dev/null\n> +++ b/gcc/testsuite/gcc.c-torture/compile/pr105192.c\n> @@ -0,0 +1,9 @@\n> +/* { dg-additional-options \"-fno-if-conversion -fharden-compares\" } */\n> +\n> +int a, b;\n> +\n> +void\n> +foo (void)\n> +{\n> + b = a % 0 > 0;\n> +}\n> --\n> 2.53.0\n>","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","gcc-patches@gcc.gnu.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","gcc-patches@gcc.gnu.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256\n header.s=qcppdkim1 header.b=K56p3z7v;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n header.a=rsa-sha256 header.s=google header.b=FyiJJgnW;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org\n (client-ip=2620:52:6:3111::32; helo=vm01.sourceware.org;\n envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org;\n receiver=patchwork.ozlabs.org)","sourceware.org;\n\tdkim=pass (2048-bit key,\n unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256\n header.s=qcppdkim1 header.b=K56p3z7v;\n\tdkim=pass (2048-bit key,\n unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n header.a=rsa-sha256 header.s=google header.b=FyiJJgnW","sourceware.org; dmarc=none (p=none dis=none)\n header.from=oss.qualcomm.com","sourceware.org;\n spf=pass smtp.mailfrom=oss.qualcomm.com","server2.sourceware.org;\n arc=pass smtp.remote-ip=205.220.180.131"],"Received":["from vm01.sourceware.org (vm01.sourceware.org\n [IPv6:2620:52:6:3111::32])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4frXVg6KQNz1xy1\n\tfor ; Thu, 09 Apr 2026 05:02:00 +1000 (AEST)","from vm01.sourceware.org (localhost [127.0.0.1])\n\tby sourceware.org (Postfix) with ESMTP id 598854BA2E26\n\tfor ; Wed, 8 Apr 2026 19:01:52 +0000 (GMT)","from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com\n [205.220.180.131])\n by sourceware.org (Postfix) with ESMTPS id 690E74BA2E1B\n for ; Wed, 8 Apr 2026 19:01:24 +0000 (GMT)","from pps.filterd (m0279870.ppops.net [127.0.0.1])\n by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 638GDJjf674820\n for ; Wed, 8 Apr 2026 19:01:23 GMT","from mail-pg1-f198.google.com (mail-pg1-f198.google.com\n [209.85.215.198])\n by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ddtbmrp6j-1\n (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT)\n for ; Wed, 08 Apr 2026 19:01:23 +0000 (GMT)","by mail-pg1-f198.google.com with SMTP id\n 41be03b00d2f7-c76c6280732so216395a12.0\n for ; Wed, 08 Apr 2026 12:01:23 -0700 (PDT)"],"DKIM-Filter":["OpenDKIM Filter v2.11.0 sourceware.org 598854BA2E26","OpenDKIM Filter v2.11.0 sourceware.org 690E74BA2E1B"],"DMARC-Filter":"OpenDMARC Filter v1.4.2 sourceware.org 690E74BA2E1B","ARC-Filter":"OpenARC Filter v1.0.0 sourceware.org 690E74BA2E1B","ARC-Seal":["i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1775674884; cv=pass;\n b=jowKWSYFQraJ93tCdbrmarnte16ND95N2pTR43bfZkno/1h38i7ZR39ELSV2CjNRpLe/cr6H2weSuMkLlmuKawMniX/0k8DtOomprWqK0NMQj1Y4Q/RzQ+uDNqR3GRM7FfOCBg6mYQedrWZVG48MmoAyjwdMcNrtPdENRMX4iGw=","i=1; a=rsa-sha256; t=1775674882; cv=none;\n d=google.com; s=arc-20240605;\n b=WJzW3oto7NVT5joNklAiHVLwvhv0G6+8ghhxqnJ+w0RCOuFHFUk4VwCyEFeAz9LSIT\n y6eYEYeIMn1+VAf3557L8oskKj7/MWSB+fkc4e0V1hmAb9Pcwjs8r9x/8oJt504dv0wy\n g0Bn8QGgkFoutRExIM/bibQxQtGYsFIVxlg++n6/ulu+V2167eFYFFvUYVj48EoDYaY6\n Xs/qCYjSdK82mvmnlVFE6O0bA2Mb9k4kluEhGDPA6hvhLQqw5Kto4LaJ78yjxgvfQAGf\n yEyJKo+6JAIXljzLYc/Tgs9yHjF4pzVFVe37fZe4LxbXFB3joXIQ1Rm9NzOApPEezfjC\n pZbA=="],"ARC-Message-Signature":["i=2; a=rsa-sha256; d=sourceware.org; s=key;\n t=1775674884; c=relaxed/simple;\n bh=NvhcIpsCbNA557dKWS1sjO+s2i94hjO1u0j1GgUADdU=;\n h=DKIM-Signature:DKIM-Signature:MIME-Version:From:Date:Message-ID:\n Subject:To;\n b=bCx3WUWdC2G0DrZZAWjqIQWMbTeshkdObM+pCL3l+hexFgs4Bp04gNp0/ZEpdfD27eBkO1xrkHVFC7PANxjww7pT1BrFaL1smTdWmG5eZnkX6v7bd4xDUr21VESpePrJGrAVKouYETlOMGa0Do6fhUWgeBI6lkCgNGR/LxWaZow=","i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n s=arc-20240605;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:dkim-signature;\n bh=WYzw2v5EbO7YpzMpMua8Pfk2ELtkbyvss/XNB3+xUGM=;\n fh=/O4SjbCkxfeQEU1BQODG4QpUx6EpfuBUFeZzA6Jsr/c=;\n b=RF4f0dbWeVhgL5EMilSj2NVq9NdsFCi6mnb1uUHlfDphp+X9Z01Mih+L50YIqc95XU\n E1oKWbFwd4uSCzjX9r8O2JVFObCQcnQ6/YTItXffCGtpXezil7tij8vBn3GHiDtfBCSL\n dyCVHkCDj7234fOM6I2smZc0EQZweju5h0RE1Qqg6iFVU5zAl2fWf7ANHMBltqdwSwPj\n eMLotSC4NXd4o5oVhVkkirlOfYGLokWUAj+EWT0keBoe19FzT6xsLKBam7JA7DL+oy5e\n ROvY9yO7IFeKhmE9jfhX4yAJCOD2OULDsFM09B1XVWtkxnRvXWi2eqK5CGBs+ZIAT/1u\n 8lnw==; darn=gcc.gnu.org"],"ARC-Authentication-Results":["i=2; server2.sourceware.org","i=1; mx.google.com; arc=none"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h=\n cc:content-transfer-encoding:content-type:date:from:in-reply-to\n :message-id:mime-version:references:subject:to; s=qcppdkim1; bh=\n WYzw2v5EbO7YpzMpMua8Pfk2ELtkbyvss/XNB3+xUGM=; b=K56p3z7vWXlD1qjC\n q4ZoQibgoyiupuSX7HiABX6JVlplmf4fYt09bjKXZU29rjI34LdoxLw3u+Tyrdu/\n rTlXQvQsVeuNmikknfVyiIz4/g2nOZBE2T1Ez4YaFoz1/QMCFVEKaA7mAo7A7t45\n qjL+ZHSqg3BIENqMtHDTbDwVoo6qSQKZvGeCpJc4m9VuPpGOTwe3z2L9SNap28zm\n g6EI3dv5yyaEVqZfP/9ddlkXHDGUFkVAWlV8hcC63MhinTcYuCo7YlQChlOmMRfk\n RnBKahojYTH6C7f0umUUb8Ef2klyeCTXtSTsb3c7lgpfmOsYg2DDeVz+gpBhi20C\n N8O/BQ==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=oss.qualcomm.com; s=google; t=1775674882; x=1776279682; darn=gcc.gnu.org;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:from:to:cc:subject:date\n :message-id:reply-to;\n bh=WYzw2v5EbO7YpzMpMua8Pfk2ELtkbyvss/XNB3+xUGM=;\n b=FyiJJgnW0c2ocvAsFdkGwMh71rIKCD3dC2XhgX1+tw2+IC0ez0f1hyISSiuVx9UZg/\n fleAwTAOO7zWEsvvrrPRrVTeeU/MDXyYlvE9M/GdbqndFG+Obo22CyTATClZ3ekQUxaT\n 37JioMd4D7T1hhy4iNezcmk/5Gu8c1JZzyuTX98QBp5u0eBuP4PaphUJK3xPRSZ4/q4O\n lhdiIUA0VkR1g+OQ1E1BadgDAOlRMmZdnjt4cfMg2m6x/3YLvDGbcbky/MOJS+3sfyBY\n 4pLVRj1CHEfixS0HyFFi6wPQCekh2xn2oMdg0sVsHwg6PWBj0Qbgn4UAuh0PhD/W/C+R\n +tUA=="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775674882; x=1776279682;\n h=content-transfer-encoding:cc:to:subject:message-id:date:from\n :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=WYzw2v5EbO7YpzMpMua8Pfk2ELtkbyvss/XNB3+xUGM=;\n b=mvuLg7oFXbHSFDnluIgOtXR1/lswexV5KuNVpi90565BYOYikx/ym5sQ2TKOzJFP0v\n +pQto29SJUfXCUHMPB5QDptEu1BICjXEmBtGUMpfQGsPAPtXmNti4h/Qzyj/Xw+AIlqh\n 2AlKLkqF0cXzNaNbJ0IYJyV2afTcrbyPCc8tFdxfUfn0A1pZNtcj1acCCmVRD8MytsnT\n 93aCekwBZvfpZBPH2vNr0u+QwW3j1SVrVOwNqm9UBJM20Qhzi2gQ/3oFVLFI6baMtSe3\n 76jb/FE2RXTfrvTUsjjmiyJHgtfhEaYSNv7u4QB84XkXdRZgd2+DQoRUC9YvuX3pBKjY\n unYQ==","X-Gm-Message-State":"AOJu0YwtvjtWeBZddFb0uXBjzo2mA1DNHhAgqVTX/XGUM0o+XTh6vW+n\n /SyWA/PY97p0H5q47VD6AhdvsQ2eR909mHR8F9/tHUXFMn/nKLJgQa3dR2fU2QPPbgA8EipxnFH\n oEPFsE50BEtc61S3wRqmyWBFRGOlsnvW03gHqfZxCOy7N9/mTt9z0rr8ajUdfXWI24Pu4oz2S9e\n 46c8thiTg7yoFSqYpEQUmt5zwpzUcMUMK73w4=","X-Gm-Gg":"AeBDieuc01x/BWfFwgCHlg3qp+597d6lz02pI46FVmbbhnH5M1wIGKfj9hrwWp7o0o7\n KjftgswqmXsVUKRC4cYT+fTS85FP7pDL0cBk4Esjsp7rz3Pw0ipBuBgFdFYiAs5FA816/AMjipT\n PbEEjcucAL8C6QQ6oL1rHFlGKQcCZFWeWGwJ9LNSG7SZs2eOBmskZ4LTg1VU9vshED5Obvc+rBD\n 64=","X-Received":["by 2002:a05:7300:fb91:b0:2c0:c415:cfd6 with SMTP id\n 5a478bee46e88-2cbfa9b3704mr11795819eec.13.1775674882435;\n Wed, 08 Apr 2026 12:01:22 -0700 (PDT)","by 2002:a05:7300:fb91:b0:2c0:c415:cfd6 with SMTP id\n 5a478bee46e88-2cbfa9b3704mr11795788eec.13.1775674881804; Wed, 08 Apr 2026\n 12:01:21 -0700 (PDT)"],"MIME-Version":"1.0","References":"<20260408152354.77017-1-xry111@xry111.site>","In-Reply-To":"<20260408152354.77017-1-xry111@xry111.site>","From":"Andrew Pinski ","Date":"Wed, 8 Apr 2026 12:01:08 -0700","X-Gm-Features":"AQROBzDKRiEvegnbB4MeOaTRHa6NS5tv-LK8HKYig2JjjjA-vTt88yZdjjcIqu8","Message-ID":"\n ","Subject":"Re: [PATCH] ifcvt: reject use of ctrap post reload [PR 105192]","To":"Xi Ruoyao ","Cc":"gcc-patches@gcc.gnu.org, Mingcong Bai ,\n Henry Chen , Zixing Liu ","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","X-Proofpoint-GUID":"NAt9HM26WOCI6dzPlnpd6fGfV3CgM9IS","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwNDA4MDE3NyBTYWx0ZWRfX0+gUH5FX1z07\n mn7dpI6A+oFdcvqLX3gHuQ7x6nKu0Z3Y5ubMePkUbiLcJ4dvaG8ihB7E28vrOk3ZBkhI7yGPrBJ\n qX4YlFTGrpljvKb5TlWO3B2BLsIkY9Dl3HLMThV1MIORRsTJyheJGrhR1BxxuUxhZmSzVNPBjV7\n ts7uGM7VJqTdfCvsPxALIvQXIzyp2IDRj58uByj4bARfsobycVwpkUdqQnKHMN3hH2SKYEVorME\n v/g3FSvlLf/CIde8VjKsAlgchxaH9b5lxkHLK/km5vykD8oVN7R/5E356TI2x1Ad8q0QklrnqhN\n C9t+yC/IWN/7H1i09jFqrKKNGf85/i3yJ7n5msuRd7X9WCpgFJLFUP3rxCXgetVhELEmFeYTFS/\n thPGe01fnohF5Nud1X4WLZJJRS6BA/DshEJOfYctqzTUwFzTJg0JkZ5e8wPwijYwQwkKHO36cJa\n t9iqkXbpSARp6OHHYkg==","X-Authority-Analysis":"v=2.4 cv=YM2vDxGx c=1 sm=1 tr=0 ts=69d6a603 cx=c_pps\n a=Qgeoaf8Lrialg5Z894R3/Q==:117 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10\n a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22\n a=gowsoOTTUOVcmtlkKump:22 a=YXldPPernLzIU1aI58sA:9 a=QEXdDO2ut3YA:10\n a=x9snwWr2DeNwDh03kgHS:22","X-Proofpoint-ORIG-GUID":"NAt9HM26WOCI6dzPlnpd6fGfV3CgM9IS","X-Proofpoint-Virus-Version":"vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-04-08_05,2026-04-08_01,2025-10-01_01","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n phishscore=0 priorityscore=1501 impostorscore=0 adultscore=0 spamscore=0\n lowpriorityscore=0 bulkscore=0 clxscore=1015 suspectscore=0 malwarescore=0\n classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0\n reason=mlx scancount=1 engine=8.22.0-2604010000 definitions=main-2604080177","X-BeenThere":"gcc-patches@gcc.gnu.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Gcc-patches mailing list ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org"}}]