[{"id":3676646,"web_url":"http://patchwork.ozlabs.org/comment/3676646/","msgid":"<20260413105450.GN469338@kernel.org>","list_archive_url":null,"date":"2026-04-13T10:54:50","subject":"Re: [Intel-wired-lan] [PATCH iwl-net v2 4/6] ixgbe: fix cls_u32\n nexthdr path returning success when no entry installed","submitter":{"id":82748,"url":"http://patchwork.ozlabs.org/api/people/82748/","name":"Simon Horman","email":"horms@kernel.org"},"content":"On Wed, Apr 08, 2026 at 03:11:52PM +0200, Aleksandr Loktionov wrote:\n> ixgbe_configure_clsu32() returns 0 (success) after the nexthdr loop\n> even when ixgbe_clsu32_build_input() fails for every candidate entry\n> and no jump-table slot is actually programmed. Callers that test the\n> return value would then falsely believe the filter was installed.\n> \n> The variable 'err' already tracks the last ixgbe_clsu32_build_input()\n> return value; if the loop completes with a successful break, err is 0.\n> If all attempts failed, err holds the last failure code. Change the\n> unconditional 'return 0' to 'return err' so errors are propagated\n> correctly.\n> \n> Fixes: 1cdaaf5405ba (\"ixgbe: Match on multiple headers for cls_u32 offloads\")\n> Signed-off-by: Aleksandr Loktionov \n> Cc: stable@vger.kernel.org\n> Reviewed-by: Marcin Szycik \n> ---\n> v1 -> v2:\n> - Add Fixes: tag; reroute from iwl-next to iwl-net (false-success\n> return is a user-visible correctness bug, not a cleanup).\n\nReviewed-by: Simon Horman ","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=8uoJIUXQ;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::136; helo=smtp3.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fvPSM69pkz1yDF\n\tfor ; Mon, 13 Apr 2026 20:54:59 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id 3793E6071F;\n\tMon, 13 Apr 2026 10:54:58 +0000 (UTC)","from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id v-7S_HiFWEU6; Mon, 13 Apr 2026 10:54:56 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id 0749D605EF;\n\tMon, 13 Apr 2026 10:54:56 +0000 (UTC)","from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n by lists1.osuosl.org (Postfix) with ESMTP id 343CC283\n for ; Mon, 13 Apr 2026 10:54:55 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp1.osuosl.org (Postfix) with ESMTP id 1A70380701\n for ; Mon, 13 Apr 2026 10:54:55 +0000 (UTC)","from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id LUzaJomf_2Wu for ;\n Mon, 13 Apr 2026 10:54:54 +0000 (UTC)","from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31])\n by smtp1.osuosl.org (Postfix) with ESMTPS id 2D5E3806ED\n for ; Mon, 13 Apr 2026 10:54:54 +0000 (UTC)","from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58])\n by sea.source.kernel.org (Postfix) with ESMTP id A41E141661;\n Mon, 13 Apr 2026 10:54:53 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 638EFC116C6;\n Mon, 13 Apr 2026 10:54:52 +0000 (UTC)"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp3.osuosl.org 0749D605EF","OpenDKIM Filter v2.11.0 smtp1.osuosl.org 2D5E3806ED"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1776077696;\n\tbh=QPZjPqBTgIApsUsjb4wfwFztDHzZclAwfWv3FFH5YTw=;\n\th=Date:From:To:Cc:References:In-Reply-To:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t From;\n\tb=8uoJIUXQ8CY2RG1om/Y2rR9+BqkYAHP4Z4671Wl0RuX3WzrjBliO+BNRsOxN/Z4OY\n\t Aq0I1ietjSLnWHR+KsUIWKAmcymR+dPkvZvjdcnTUiOxoeCRISePYi2CC397PST89j\n\t BBHA9YFXpSYsS7D5NHMcBlSc6CeGohfCO5567PjEE2qjYUtKKGsp6okEYdTWmR8/WV\n\t xDrotdq+66qeL0k3fahoTCG0pZ42hDZDJ6q5mUCls2UJTR2d/XCz5MiTAkVAqqEhy7\n\t IZBlYl+vlg0gD+BiISakIumBsSJJNYQO3iXXYTqYOLRQsQ5ypYiBTWNpKez4W4C7/e\n\t XHB9U7hGcYF2g==","Received-SPF":"Pass (mailfrom) identity=mailfrom; client-ip=172.234.252.31;\n helo=sea.source.kernel.org; envelope-from=horms@kernel.org;\n receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp1.osuosl.org 2D5E3806ED","Date":"Mon, 13 Apr 2026 11:54:50 +0100","From":"Simon Horman ","To":"Aleksandr Loktionov ","Cc":"intel-wired-lan@lists.osuosl.org, anthony.l.nguyen@intel.com,\n netdev@vger.kernel.org, Marcin Szycik ","Message-ID":"<20260413105450.GN469338@kernel.org>","References":"<20260408131154.2661818-1-aleksandr.loktionov@intel.com>\n <20260408131154.2661818-5-aleksandr.loktionov@intel.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20260408131154.2661818-5-aleksandr.loktionov@intel.com>","X-Mailman-Original-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n d=kernel.org; s=k20201202; t=1776077693;\n bh=nz5hxxicKyK9BXmV2TEjGdfMjMpJw2jsLLzARmCjv5I=;\n h=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n b=Y/30kM3r2N63GzzLiQlAttghWO10O6LvFF5HbwPtLczvbXdm/JViuh2Ap481ew5ra\n 8liF+004dJPeIJ2Q3kKL6nhXxD/n7KSfFeefsJOV1qXbYFBa/4djNB2TaX3GE3XgY1\n z4yDt8Sh0RYEu/0i8C5X07PVb2ggRSCVxk+HI1EOnzddbi+LYaiMS/V5gaezCWjdZl\n cJD1ep3rO1IjOaqX4jrmRHoFQADEml09InnL4Le9p274txJGljZBVJgs5CVE7RnlLx\n e1mjozks+dVQFe1LE3L1f3aXiQvpD+gol5hZUcamwAlu9cDcyyo4HN8QdcRJp5tthd\n 3wV15Xf/GmwdA==","X-Mailman-Original-Authentication-Results":["smtp1.osuosl.org;\n dmarc=pass (p=quarantine dis=none)\n header.from=kernel.org","smtp1.osuosl.org;\n dkim=pass (2048-bit key,\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=Y/30kM3r"],"Subject":"Re: [Intel-wired-lan] [PATCH iwl-net v2 4/6] ixgbe: fix cls_u32\n nexthdr path returning success when no entry installed","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "}}]