[{"id":3676636,"web_url":"http://patchwork.ozlabs.org/comment/3676636/","msgid":"<20260413103050.GL469338@kernel.org>","list_archive_url":null,"date":"2026-04-13T10:30:50","subject":"Re: [Intel-wired-lan] [PATCH iwl-net v2 2/6] ixgbe: add bounds\n check for debugfs register access","submitter":{"id":82748,"url":"http://patchwork.ozlabs.org/api/people/82748/","name":"Simon Horman","email":"horms@kernel.org"},"content":"On Wed, Apr 08, 2026 at 03:11:50PM +0200, Aleksandr Loktionov wrote:\n> From: Paul Greenwalt <paul.greenwalt@intel.com>\n> \n> Prevent out-of-bounds MMIO accesses triggered through user-controlled\n> register offsets.  IXGBE_HFDR (0x15FE8) is the highest valid MMIO\n> register in the ixgbe register map; any offset beyond it would address\n> unmapped memory.\n> \n> Add a defense-in-depth check at two levels:\n> \n> 1. ixgbe_read_reg() -- the noinline register read accessor.  A\n>    WARN_ON_ONCE() guard here catches any future code path (including\n>    ioctl extensions) that might inadvertently pass an out-of-range\n>    offset without relying on higher layers to catch it first.\n>    ixgbe_write_reg() is a static inline called from the TX/RX hot path;\n>    adding WARN_ON_ONCE there would inline the check at every call site,\n>    so only the read path gets this guard.\n> \n> 2. ixgbe_dbg_reg_ops_write() -- the debugfs 'reg_ops' interface is the\n>    only current path where a raw, user-supplied offset enters the driver.\n>    Gating it before invoking the register accessors provides a clean,\n>    user-visible failure (silent ignore with no kernel splat) for\n>    deliberately malformed debugfs writes.\n> \n> Add a reg <= IXGBE_HFDR guard to both the read and write paths in\n> ixgbe_dbg_reg_ops_write(), and a WARN_ON_ONCE + early-return guard to\n> ixgbe_read_reg().\n> \n> Fixes: 91fbd8f081e2 (\"ixgbe: added reg_ops file to debugfs\")\n> Signed-off-by: Paul Greenwalt <paul.greenwalt@intel.com>\n> Cc: stable@vger.kernel.org\n> Signed-off-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>\n> ---\n> v1 -> v2:\n>  - Add Fixes: tag; reroute from iwl-next to iwl-net (security-relevant\n>    hardening for user-controllable out-of-bounds MMIO).\n\nThanks for the update.\n\nAnd sorry for not thinking to ask this earlier: this patch\naddresses possible overruns of the mapped address space if the\nsupplied value for reg is too large. But do we also need a\nguard against underrun if the value for reg is too small?\n\n...","headers":{"Return-Path":"<intel-wired-lan-bounces@osuosl.org>","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=97xs6mSH;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=140.211.166.136; helo=smtp3.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fvNwk2rslz1xtJ\n\tfor <incoming@patchwork.ozlabs.org>; Mon, 13 Apr 2026 20:31:01 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id A021D60B09;\n\tMon, 13 Apr 2026 10:30:59 +0000 (UTC)","from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id Bj0tXB9H5r-I; Mon, 13 Apr 2026 10:30:59 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id 15BC860BC6;\n\tMon, 13 Apr 2026 10:30:59 +0000 (UTC)","from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n by lists1.osuosl.org (Postfix) with ESMTP id 80242283\n for <intel-wired-lan@lists.osuosl.org>; Mon, 13 Apr 2026 10:30:57 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp3.osuosl.org (Postfix) with ESMTP id 65A9C60BC6\n for <intel-wired-lan@lists.osuosl.org>; Mon, 13 Apr 2026 10:30:57 +0000 (UTC)","from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id wxXpVkI_m3ou for <intel-wired-lan@lists.osuosl.org>;\n Mon, 13 Apr 2026 10:30:56 +0000 (UTC)","from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254])\n by smtp3.osuosl.org (Postfix) with ESMTPS id 8E05D60B09\n for <intel-wired-lan@lists.osuosl.org>; Mon, 13 Apr 2026 10:30:56 +0000 (UTC)","from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58])\n by tor.source.kernel.org (Postfix) with ESMTP id EC8DD60180;\n Mon, 13 Apr 2026 10:30:54 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 845FFC2BCB5;\n Mon, 13 Apr 2026 10:30:53 +0000 (UTC)"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=<UNKNOWN> ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp3.osuosl.org 15BC860BC6","OpenDKIM Filter v2.11.0 smtp3.osuosl.org 8E05D60B09"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1776076259;\n\tbh=sUUF+72eSb9zEIZzvMPZr0bN9WaFPdpDxmbWRONnTUA=;\n\th=Date:From:To:Cc:References:In-Reply-To:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t From;\n\tb=97xs6mSHeqJVYOK8Ypmpeir2jNbY8QTqv0RDq1Ty9iLWb8x6S0UtChLxz4+cjE4ao\n\t Czlta7ilSHEQwMuGebmr6uPhbO88yWvci+vzoQH/mJlEXaC+9CIoKHMSMSaTxdwvIZ\n\t meaa6ew4cbZm/bJekBx8OAeP74Y0mZtX3Z4CuDDElyyEcivW0/vkhAvxQj9dNdWpD3\n\t LEVxMJ8E8sYybVY/0eyePN7aXnmDR3G6tI9m5pbQaboxP+IzxxOrAUxO1+Trege2Ix\n\t endwE4o3M6jz4xnOyVyPRVBuAy6DikhFTFJ8qfb2aIuMaIbLjOKwDDRlDIDpENu388\n\t AFxIMowI4u+Bg==","Received-SPF":"Pass (mailfrom) identity=mailfrom; client-ip=172.105.4.254;\n helo=tor.source.kernel.org; envelope-from=horms@kernel.org;\n receiver=<UNKNOWN>","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp3.osuosl.org 8E05D60B09","Date":"Mon, 13 Apr 2026 11:30:50 +0100","From":"Simon Horman <horms@kernel.org>","To":"Aleksandr Loktionov <aleksandr.loktionov@intel.com>","Cc":"intel-wired-lan@lists.osuosl.org, anthony.l.nguyen@intel.com,\n netdev@vger.kernel.org, Paul Greenwalt <paul.greenwalt@intel.com>","Message-ID":"<20260413103050.GL469338@kernel.org>","References":"<20260408131154.2661818-1-aleksandr.loktionov@intel.com>\n <20260408131154.2661818-3-aleksandr.loktionov@intel.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20260408131154.2661818-3-aleksandr.loktionov@intel.com>","X-Mailman-Original-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n d=kernel.org; s=k20201202; t=1776076254;\n bh=ZZ5n5swHim3raXBjfjDTGvGtf3AkWA9HWolWBpnbGSI=;\n h=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n b=hi3v3CtyoEcPmYpmhDY4nfGSXYwTU80Qf8lFCGEC3mLRH9b6GWU38gKyBkhg6kqpx\n nGG0Dh+HoSB0FMn5SJR7dCmunvpBQneZ5bS4Vxk9NBGBsoH3T2mFnf3BuTHlKSk4j3\n C7WW3FToIAqDCGUawKdHmhZfEmwcBzJyAcPtoaWi9/5nUPdlSPtbpZM0Y7+eSTU5q7\n xcJUmGfzl6JSJVUMW4VWkaRqRGmkvpa556FTsUewU7VKH6UsVHvzXBFsf3+basZN8+\n p5FdC4hUxoR8MJISV/kJsxKOh7fnKqyvwqYVmlV/fHLhUoEJgrshLwF9ZMBYBhunCz\n 9A2+7wgktv5GA==","X-Mailman-Original-Authentication-Results":["smtp3.osuosl.org;\n dmarc=pass (p=quarantine dis=none)\n header.from=kernel.org","smtp3.osuosl.org;\n dkim=pass (2048-bit key,\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=hi3v3Cty"],"Subject":"Re: [Intel-wired-lan] [PATCH iwl-net v2 2/6] ixgbe: add bounds\n check for debugfs register access","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>","List-Unsubscribe":"<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>","List-Archive":"<http://lists.osuosl.org/pipermail/intel-wired-lan/>","List-Post":"<mailto:intel-wired-lan@osuosl.org>","List-Help":"<mailto:intel-wired-lan-request@osuosl.org?subject=help>","List-Subscribe":"<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>"}},{"id":3676996,"web_url":"http://patchwork.ozlabs.org/comment/3676996/","msgid":"<dda1f0f3-f57b-418a-93e6-2cdaa1d2ef35@intel.com>","list_archive_url":null,"date":"2026-04-14T01:00:28","subject":"Re: [Intel-wired-lan] [PATCH iwl-net v2 2/6] ixgbe: add bounds\n check for debugfs register access","submitter":{"id":9784,"url":"http://patchwork.ozlabs.org/api/people/9784/","name":"Jacob Keller","email":"jacob.e.keller@intel.com"},"content":"On 4/13/2026 3:30 AM, Simon Horman wrote:\n> On Wed, Apr 08, 2026 at 03:11:50PM +0200, Aleksandr Loktionov wrote:\n>> From: Paul Greenwalt <paul.greenwalt@intel.com>\n>>\n>> Prevent out-of-bounds MMIO accesses triggered through user-controlled\n>> register offsets.  IXGBE_HFDR (0x15FE8) is the highest valid MMIO\n>> register in the ixgbe register map; any offset beyond it would address\n>> unmapped memory.\n>>\n>> Add a defense-in-depth check at two levels:\n>>\n>> 1. ixgbe_read_reg() -- the noinline register read accessor.  A\n>>    WARN_ON_ONCE() guard here catches any future code path (including\n>>    ioctl extensions) that might inadvertently pass an out-of-range\n>>    offset without relying on higher layers to catch it first.\n>>    ixgbe_write_reg() is a static inline called from the TX/RX hot path;\n>>    adding WARN_ON_ONCE there would inline the check at every call site,\n>>    so only the read path gets this guard.\n>>\n>> 2. ixgbe_dbg_reg_ops_write() -- the debugfs 'reg_ops' interface is the\n>>    only current path where a raw, user-supplied offset enters the driver.\n>>    Gating it before invoking the register accessors provides a clean,\n>>    user-visible failure (silent ignore with no kernel splat) for\n>>    deliberately malformed debugfs writes.\n>>\n>> Add a reg <= IXGBE_HFDR guard to both the read and write paths in\n>> ixgbe_dbg_reg_ops_write(), and a WARN_ON_ONCE + early-return guard to\n>> ixgbe_read_reg().\n>>\n>> Fixes: 91fbd8f081e2 (\"ixgbe: added reg_ops file to debugfs\")\n>> Signed-off-by: Paul Greenwalt <paul.greenwalt@intel.com>\n>> Cc: stable@vger.kernel.org\n>> Signed-off-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>\n>> ---\n>> v1 -> v2:\n>>  - Add Fixes: tag; reroute from iwl-next to iwl-net (security-relevant\n>>    hardening for user-controllable out-of-bounds MMIO).\n> \n> Thanks for the update.\n> \n> And sorry for not thinking to ask this earlier: this patch\n> addresses possible overruns of the mapped address space if the\n> supplied value for reg is too large. But do we also need a\n> guard against underrun if the value for reg is too small?\n> \n\nI don't think so. This is bounds checking a register offset which is an\nunsigned 32-bit value and begins at 0, so the map goes from 0 to\nIXGBE_HFDR. Since the value is unsigned, if it does underflow somehow it\nwould then get caught by the check for IXGBE_HFDR right?\n\nThanks,\nJake\n\n> ...","headers":{"Return-Path":"<intel-wired-lan-bounces@osuosl.org>","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=FxUVsAzx;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::137; helo=smtp4.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fvmD83HDtz1yCv\n\tfor <incoming@patchwork.ozlabs.org>; Tue, 14 Apr 2026 11:00:40 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id 534C7427FA;\n\tTue, 14 Apr 2026 01:00:38 +0000 (UTC)","from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id XsSGdTaRquxf; Tue, 14 Apr 2026 01:00:37 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id 808F9427E4;\n\tTue, 14 Apr 2026 01:00:37 +0000 (UTC)","from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137])\n by lists1.osuosl.org (Postfix) with ESMTP id 68490283\n for <intel-wired-lan@lists.osuosl.org>; Tue, 14 Apr 2026 01:00:36 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp4.osuosl.org (Postfix) with ESMTP id 5A3FC427E4\n for <intel-wired-lan@lists.osuosl.org>; Tue, 14 Apr 2026 01:00:36 +0000 (UTC)","from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id jcoybwH7Qsmv for <intel-wired-lan@lists.osuosl.org>;\n Tue, 14 Apr 2026 01:00:35 +0000 (UTC)","from mgamail.intel.com (mgamail.intel.com [198.175.65.19])\n by smtp4.osuosl.org (Postfix) with ESMTPS id 6E2A6427E3\n for <intel-wired-lan@lists.osuosl.org>; Tue, 14 Apr 2026 01:00:35 +0000 (UTC)","from orviesa007.jf.intel.com ([10.64.159.147])\n by orvoesa111.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 13 Apr 2026 18:00:34 -0700","from fmsmsx902.amr.corp.intel.com ([10.18.126.91])\n by orviesa007.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 13 Apr 2026 18:00:35 -0700","from FMSMSX902.amr.corp.intel.com (10.18.126.91) by\n fmsmsx902.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.2562.37; Mon, 13 Apr 2026 18:00:33 -0700","from fmsedg903.ED.cps.intel.com (10.1.192.145) by\n FMSMSX902.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.2562.37 via Frontend Transport; Mon, 13 Apr 2026 18:00:33 -0700","from SN4PR2101CU001.outbound.protection.outlook.com (40.93.195.4) by\n edgegateway.intel.com (192.55.55.83) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.2562.37; Mon, 13 Apr 2026 18:00:33 -0700","from DS0PR11MB7579.namprd11.prod.outlook.com (2603:10b6:8:14d::5) by\n SA2PR11MB4842.namprd11.prod.outlook.com (2603:10b6:806:f8::17) with\n Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.9745.41; Tue, 14 Apr 2026 01:00:31 +0000","from DS0PR11MB7579.namprd11.prod.outlook.com\n ([fe80::4199:4cb5:cf88:e79e]) by DS0PR11MB7579.namprd11.prod.outlook.com\n ([fe80::4199:4cb5:cf88:e79e%5]) with mapi id 15.20.9818.014; Tue, 14 Apr 2026\n 01:00:31 +0000"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=<UNKNOWN> ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp4.osuosl.org 808F9427E4","OpenDKIM Filter v2.11.0 smtp4.osuosl.org 6E2A6427E3"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1776128437;\n\tbh=pblcjKaB1vQsojRX6AX8UdUuUfXvS0jeR55S//TxSLs=;\n\th=Date:To:CC:References:From:In-Reply-To:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t From;\n\tb=FxUVsAzxLAl26JBrAx2PtIdW+4dS8WchPAjU534dYlJesCqy5YDoboUBo/BT/GwG3\n\t poZVcKF8/gSxe8DiplNXtqbYTJ+6mHhDb5DpzDC/utxtrbUvjJlkyq6kLRBnJ448N3\n\t qsnlYN8xcnFgiUtSTN5Fk429Tm0/jNfU40sLi4BmP8+MbU28ET20mhvM7C2gmywPho\n\t qrH+BYMs/JbH3zZxaGltGRDiEDXv9YFv4NPE6teKSBlbKuQ6KAwQ2ajRd7qAJENs7P\n\t lJ01rcubUSDtZTjFJ5miCSwYynCnKxPxsLmvB3Q28EwPonsDsP0SrLuCUuvhR/5h81\n\t BsG2Dm0WIEMrg==","Received-SPF":"Pass (mailfrom) identity=mailfrom; client-ip=198.175.65.19;\n helo=mgamail.intel.com; envelope-from=jacob.e.keller@intel.com;\n receiver=<UNKNOWN>","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp4.osuosl.org 6E2A6427E3","X-CSE-ConnectionGUID":["9BqTkqvTTCSgDsaw4Ux62Q==","4X19zRpUT6OUTpZvGUYUiA=="],"X-CSE-MsgGUID":["+BfExt4hQv6SC18KC7SdcQ==","OjIDj2p9RAKvwsJSzXy8lQ=="],"X-IronPort-AV":["E=McAfee;i=\"6800,10657,11758\"; a=\"76981449\"","E=Sophos;i=\"6.23,178,1770624000\"; d=\"scan'208\";a=\"76981449\"","E=Sophos;i=\"6.23,178,1770624000\"; d=\"scan'208\";a=\"230177422\""],"X-ExtLoop1":"1","ARC-Seal":"i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=IgqhTgmMeGby3nZDtXbKLrJkuR63UnSJyozjTeMMazbEamHKQqpzPbppzcNlA9bQZKLmDwTudpyqYzz1yf4LVMuPvfOx2UPSLHEHn7C2arQHxJ9UA0dk7ijr2KmiTFX08wCna25wC+PkF2vNf9cV2r2NlD4mL23kDH7lH88Tgu+CHcclZ4qUEI3xUtwgjMTnaHbV/5uM3cCyAsndHwE5+EKpCijE395WduN7jVrAl5FSN+yjg6qHCT+o7avS3wg1v5vIsMD8/IBLcXqVQMJd3y1uyGq/a9NEplXwZ9BPn6yaUsuHDADUxX+jdIeMIUSFMrYZWKcUhJJjOP25gD3eWQ==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=pblcjKaB1vQsojRX6AX8UdUuUfXvS0jeR55S//TxSLs=;\n b=gXCUxSSAXl10rgAvwutJcSbBziUaFMhdy4TAD6ej9Vpi2F5oU0EEzN0PCAcrv2nZP2X7ch2JMwOMZsX16VGLaO9u6hwEh6UDhu7ccf/N+oKcaRAPnQftm8HvJFR9dHyDAvu8WdsbcdvW5vwFn2g/5g3m2jpMNwMgdBnq7sFuBs4naM6GetP6EJfrTUUAykZ5WBrnLQeGnJMG0vZ+eYT8rO/ov4T9NS/LjNaNACJzo4GoTf8YM9HkXtYIPn3vLxstOWpyZ6A/APIuVvZTaJFzr4bFhb8Xm+c9v5YZgAKUh+hwoZuBchiP161TlKZlsjH1FwqDZgKDJOhk5yKkNgSF3w==","ARC-Authentication-Results":"i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;\n dkim=pass header.d=intel.com; arc=none","Message-ID":"<dda1f0f3-f57b-418a-93e6-2cdaa1d2ef35@intel.com>","Date":"Mon, 13 Apr 2026 18:00:28 -0700","User-Agent":"Mozilla Thunderbird","To":"Simon Horman <horms@kernel.org>, Aleksandr Loktionov\n <aleksandr.loktionov@intel.com>","CC":"<intel-wired-lan@lists.osuosl.org>, <anthony.l.nguyen@intel.com>,\n <netdev@vger.kernel.org>, Paul Greenwalt <paul.greenwalt@intel.com>","References":"<20260408131154.2661818-1-aleksandr.loktionov@intel.com>\n <20260408131154.2661818-3-aleksandr.loktionov@intel.com>\n <20260413103050.GL469338@kernel.org>","Content-Language":"en-US","From":"Jacob Keller <jacob.e.keller@intel.com>","In-Reply-To":"<20260413103050.GL469338@kernel.org>","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"7bit","X-ClientProxiedBy":"MW4PR04CA0121.namprd04.prod.outlook.com\n (2603:10b6:303:84::6) To DS0PR11MB7579.namprd11.prod.outlook.com\n (2603:10b6:8:14d::5)","MIME-Version":"1.0","X-MS-PublicTrafficType":"Email","X-MS-TrafficTypeDiagnostic":"DS0PR11MB7579:EE_|SA2PR11MB4842:EE_","X-MS-Office365-Filtering-Correlation-Id":"45f697a3-c89f-4262-b3af-08de99c13990","X-MS-Exchange-SenderADCheck":"1","X-MS-Exchange-AntiSpam-Relay":"0","X-Microsoft-Antispam":"BCL:0;\n ARA:13230040|1800799024|366016|376014|22082099003|18002099003|56012099003;","X-Microsoft-Antispam-Message-Info":"\n FX8k562wzI6SxJQykGEjGvw+rqi+kHY6oKBnJ5JfOMPaWVk+RCthq5lByHiqNZED2JKHCKfYOlLnEe54ej26A9vwP457TdbqsqKMzQZxOiAUPiKV1Ysn+72B4viQB/WWbLuzhD7jd1e6pgba79GE1odcr3VyTvGkURj7l3QRrJXgrsPkn6rqc/Ktt/BIZboNYuhrdjlI5ej1GjLWO/19ekx9+TgpLddVPdTrXHtPwEB2tI4LoxUX3k1mMln63X5iEyS3dohZgx6SsII6ctWc6gSuE8jWAwWJVy5Ks75/XsAWbqMstmz61gfd3xpU7Drw5prIMPE2UsBADZi+9YRqKmwB9OFKFsDMuCnIn9VdpbeWCPOqYLyj5VmNgYOTeO8hwP8ItkABxgw8taj+NxX7Gt/DSmaXyE1uiufu8U0rr1pdLnACP4Jaw3PU7SEK5U0ejS6NodbVyUaZJHtItZk2Ot1nMlO8M6LNUXtpTs8lvx2N3WCW2WPZ1QHUm/CqusaxSC62YgVAUrRu+zJdLE+MJovpGQMD5TZx5J/mIyW/dWzcAt5SJDqBH0MEQ31I6ikYVP5RfGbXFMQ30sx5QK9QpfxfcgFX/v/PvJXO6ON3PTcGYrtC7BlnHg0+H1IQK8id8YA/E92QDLfDpRO90ViCh8o1F3RFWYPm3F9F8sXhHbeSTab20LDwQ3MKSipyceO2EG61weSPW/UUh+R14uamG+LkcVH9vgUBp41OfubdW4U=","X-Forefront-Antispam-Report":"CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:DS0PR11MB7579.namprd11.prod.outlook.com; PTR:; CAT:NONE;\n SFS:(13230040)(1800799024)(366016)(376014)(22082099003)(18002099003)(56012099003);\n DIR:OUT; SFP:1101;","X-MS-Exchange-AntiSpam-MessageData-ChunkCount":"1","X-MS-Exchange-AntiSpam-MessageData-0":"=?utf-8?q?y2r05CCekURo6Zh/Vvdge7wAzc1L?=\n\t=?utf-8?q?0+UTexuMBWIBBibs9ch6o7hfScmlIDtnefIY/2m1KMtNsR/dkRlmcG4jzIjJCwYVN?=\n\t=?utf-8?q?gRVQDTMIiFBk2oTp+g3LSxdSkckF2t1r6Vt8x40W8qzKb9/YLxmZbXylWiJZ3SBHM?=\n\t=?utf-8?q?G025wRRYPCZ7QGTEChPq/qlhouqQuDYolmjXw0azeZpfoyxb71+MRv9va5X1OZ/H0?=\n\t=?utf-8?q?+TdGUehlW8dbgK1XmAlfJZLStJsEaSe1c8gzyEJ6gkFZ0lcrAzbD3XfRMzPptz2gw?=\n\t=?utf-8?q?KIP3YTt1VEuHrm5e/z48EHHxtLT0sydb7AH2W/4QRQzvK3e7kD1p/NtbXbgvoBLjP?=\n\t=?utf-8?q?lcrkuRRGyW/74Dmudy2ubMTqiLd3l/P9nn8FfeULX/ySbl0QpNX2ptufSI0j9z/YE?=\n\t=?utf-8?q?X9WeLhGguxFaZ3WNioeyHTM/VTcDNVFJunbH7jsLZPHzrhBi/qej/mXLcBsNUbm91?=\n\t=?utf-8?q?YWfJ3hdqHaUocjFONJ4IQBQaTO3j2gcDx4iFLZ7yGkQY/y2VRASi3srRAqgrKNQoo?=\n\t=?utf-8?q?MYO20zamxLSRaYVb7FumXrapUMFewrQf4ISat8fg+0U0WlxHGo10/YrJz1hYHkdxF?=\n\t=?utf-8?q?vuvbxoc20JbCd9RcKD/GyxlEw0W3tAWzIZl/2BuM8SMGhbWd7kal8nZuSKwzLiv98?=\n\t=?utf-8?q?1JYLAMeKzQhSGkoQah6KVYiR7znikNCtorS0n6S+GO1xNX/0yar2YIMk/iezc+nFC?=\n\t=?utf-8?q?Wssw6wSoUW9ufvC5R0l0TGVKCtRmLvfJjxagMxCsK7tXxLsg4+69AKVz2e4jtPdCs?=\n\t=?utf-8?q?zaLXlPkxvG/R3D5BJcAluHttVuKNrCK62XEHIQ4u3mkLcancoeKJdyjSkIQdnbV/q?=\n\t=?utf-8?q?hf5aiYhNmO1xw39QDN+5WJ5K/hXcyoUZAoJErK4uPacikpy4TPCUE0i55kIPUXNqg?=\n\t=?utf-8?q?+SqEQcPVXQ0leUna9AMXvKU3IJpy4vJhv7ZrqaxHunypLfwtOcPRlnVBocUlptFzT?=\n\t=?utf-8?q?fhWwY3umTg9ZC1V4ticrmP7OnNUhG1uxHAWCI9X86vrj4dvMp2RUP9A8IAxjPVY+q?=\n\t=?utf-8?q?H/0DGdwdY+sEaH9woCcEFtBMCpbi8FBViHvbtNBswxFjS1kaLT15N/3qqiRoaCdGS?=\n\t=?utf-8?q?uOBjbSSNIdPNQMpqqcjyhIfcqA2ZdrA9VFzIMqeNIntnO2jgFDf3nnQ3QA2ExSTvh?=\n\t=?utf-8?q?gKmqnvALdZphkrawqy+W6/NBjcg5blfzUjOZBAg59EvxL0/dJz6ZM3HaDKKH6trLF?=\n\t=?utf-8?q?TriQ5JZhTtajLrEd3SWBvEUV5Q0oy2AQQU8kOlb73D5J1dS/ds8KqVN7YEdFd0lWV?=\n\t=?utf-8?q?QNPipBbO+sIGqOsAkkGSJJyjmJe6tuhz3blCBj56NKMkmjwWFL5ihzfLHXBgF3Zuc?=\n\t=?utf-8?q?bdyYpqZvwJb9JatBaIGH523xWrFf9j3GuZQmU5hMVDDgwwct74jlkVynNg7Zx9Hoi?=\n\t=?utf-8?q?bq8B3a54HPjYiOUtqNgJ6Z1XrDfEQsxPqtDANrpEdH2YQP7jKurXHTpULteBnAQr8?=\n\t=?utf-8?q?5b8eAAN0TT3WRvfFZ/llkc4DJYp5NTUr7kH2QPiAeciolVn4Czcj92zfJKmaGPQsP?=\n\t=?utf-8?q?VJKbueqaD1CB96KriHPgFOtcFbSD6x1mK6IaE+lglF1tchMJCeyJfh6ekpe923arL?=\n\t=?utf-8?q?9Bmz0qIGoZYgCJcBtfRgzvBKlzv9qy3MCqEWQ+nCC3TD1pe6DzKb4eatkQ9JT1XvG?=\n\t=?utf-8?q?bDvvHi8j1ZM15w09aalkWXMp0ZbmLl4w=3D=3D?=","X-Exchange-RoutingPolicyChecked":"\n FaILWPPRs+E6SqPYMWdtUQxWA8aWTmSC/QS3xkIu6V8ZUrHBbHfIbNXw/dEPAlUrZlF/tcb9fC5LQZKuuV/DxOMFXoDZpAS24p45AFjFmhhn8TJUGXHMmuws69McLWWm7PFTcipiLIfWCed4lm0azgtMb48ckUHrV1ODT1Gp4QPay/hr2kvCA2/lUhX6pRGNqyUQ9Afy3+3gmt9SDRc/XtLR6wKUfX1qh2RnStMEtVV/zvY/0oQs39e1QRjdeQhCo3Em4qwjbdz/lfbJ9ItGXsdTyE2ZcFS14JNqK8/FHRLQgzM70mcwhuwgn/1O0Hx164K9j/ZyC4V2AfQ76XP4ug==","X-MS-Exchange-CrossTenant-Network-Message-Id":"\n 45f697a3-c89f-4262-b3af-08de99c13990","X-MS-Exchange-CrossTenant-AuthSource":"DS0PR11MB7579.namprd11.prod.outlook.com","X-MS-Exchange-CrossTenant-AuthAs":"Internal","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"14 Apr 2026 01:00:30.8174 (UTC)","X-MS-Exchange-CrossTenant-FromEntityHeader":"Hosted","X-MS-Exchange-CrossTenant-Id":"46c98d88-e344-4ed4-8496-4ed7712e255d","X-MS-Exchange-CrossTenant-MailboxType":"HOSTED","X-MS-Exchange-CrossTenant-UserPrincipalName":"\n sIBnmyXIKTt2EtnCvchsJY4Y2yGxaYfwWlpY9E7YwEFhLrK+jEETLVSl9TmNwD7gAn00FFIgG8lGc85li+aiBAy2cMIOT56wGSFMddLTi8Q=","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"SA2PR11MB4842","X-OriginatorOrg":"intel.com","X-Mailman-Original-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1776128435; x=1807664435;\n h=message-id:date:subject:to:cc:references:from:\n in-reply-to:content-transfer-encoding:mime-version;\n bh=VFSJBr0ZPfcM/0//+tnFb28Q7PnE5Oe04blSBQMQWp8=;\n b=WGXkR0ejizAm/b0IqbnYnO7+4Zf0AbqJugjIvT4IudVRPNzzOFCkoeC9\n oAcyeU1fGgTH0/Lkx+I/L0cbJx7syHmwqFkMRSvbuDPoTvF0c4I1zvvGB\n eHSHwnV20BSa4zYW40t7o9G+Jp+llSynLQ2W6k2dCBYAXk55qQWpZjYvK\n sn9MSw0EzikKdAQXJ+81pgC9OqnNglPPDijox+UWL3CdNcT9tvhtupEBi\n tGYUkH1sx4GJ0F/OqRjLbQqFBSDlK+L6MWlohwWiNmpLsDq5PyzekTwqu\n UQu/DxVajJy2BOTYvgNMwep6Kxsd+jfGrTGwsqC0c9Pjq8bm/CJ7UvgVV\n Q==;","X-Mailman-Original-Authentication-Results":["smtp4.osuosl.org;\n dmarc=pass (p=none dis=none)\n header.from=intel.com","smtp4.osuosl.org;\n dkim=pass (2048-bit key,\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=WGXkR0ej","dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=intel.com;"],"Subject":"Re: [Intel-wired-lan] [PATCH iwl-net v2 2/6] ixgbe: add bounds\n check for debugfs register access","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>","List-Unsubscribe":"<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>","List-Archive":"<http://lists.osuosl.org/pipermail/intel-wired-lan/>","List-Post":"<mailto:intel-wired-lan@osuosl.org>","List-Help":"<mailto:intel-wired-lan-request@osuosl.org?subject=help>","List-Subscribe":"<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>"}},{"id":3677323,"web_url":"http://patchwork.ozlabs.org/comment/3677323/","msgid":"<20260414171630.GA772670@horms.kernel.org>","list_archive_url":null,"date":"2026-04-14T17:16:30","subject":"Re: [Intel-wired-lan] [PATCH iwl-net v2 2/6] ixgbe: add bounds\n check for debugfs register access","submitter":{"id":82748,"url":"http://patchwork.ozlabs.org/api/people/82748/","name":"Simon Horman","email":"horms@kernel.org"},"content":"On Mon, Apr 13, 2026 at 06:00:28PM -0700, Jacob Keller wrote:\n> On 4/13/2026 3:30 AM, Simon Horman wrote:\n> > On Wed, Apr 08, 2026 at 03:11:50PM +0200, Aleksandr Loktionov wrote:\n> >> From: Paul Greenwalt <paul.greenwalt@intel.com>\n> >>\n> >> Prevent out-of-bounds MMIO accesses triggered through user-controlled\n> >> register offsets.  IXGBE_HFDR (0x15FE8) is the highest valid MMIO\n> >> register in the ixgbe register map; any offset beyond it would address\n> >> unmapped memory.\n> >>\n> >> Add a defense-in-depth check at two levels:\n> >>\n> >> 1. ixgbe_read_reg() -- the noinline register read accessor.  A\n> >>    WARN_ON_ONCE() guard here catches any future code path (including\n> >>    ioctl extensions) that might inadvertently pass an out-of-range\n> >>    offset without relying on higher layers to catch it first.\n> >>    ixgbe_write_reg() is a static inline called from the TX/RX hot path;\n> >>    adding WARN_ON_ONCE there would inline the check at every call site,\n> >>    so only the read path gets this guard.\n> >>\n> >> 2. ixgbe_dbg_reg_ops_write() -- the debugfs 'reg_ops' interface is the\n> >>    only current path where a raw, user-supplied offset enters the driver.\n> >>    Gating it before invoking the register accessors provides a clean,\n> >>    user-visible failure (silent ignore with no kernel splat) for\n> >>    deliberately malformed debugfs writes.\n> >>\n> >> Add a reg <= IXGBE_HFDR guard to both the read and write paths in\n> >> ixgbe_dbg_reg_ops_write(), and a WARN_ON_ONCE + early-return guard to\n> >> ixgbe_read_reg().\n> >>\n> >> Fixes: 91fbd8f081e2 (\"ixgbe: added reg_ops file to debugfs\")\n> >> Signed-off-by: Paul Greenwalt <paul.greenwalt@intel.com>\n> >> Cc: stable@vger.kernel.org\n> >> Signed-off-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>\n> >> ---\n> >> v1 -> v2:\n> >>  - Add Fixes: tag; reroute from iwl-next to iwl-net (security-relevant\n> >>    hardening for user-controllable out-of-bounds MMIO).\n> > \n> > Thanks for the update.\n> > \n> > And sorry for not thinking to ask this earlier: this patch\n> > addresses possible overruns of the mapped address space if the\n> > supplied value for reg is too large. But do we also need a\n> > guard against underrun if the value for reg is too small?\n> > \n> \n> I don't think so. This is bounds checking a register offset which is an\n> unsigned 32-bit value and begins at 0, so the map goes from 0 to\n> IXGBE_HFDR. Since the value is unsigned, if it does underflow somehow it\n> would then get caught by the check for IXGBE_HFDR right?\n\nIf the entire range from 0 to IXGBE_HFDR is mapped,\nand it's ok for reg to have any value in that range,\nthen I agree there is no problem here.\n\nReviewed-by: Simon Horman <horms@kernel.org>","headers":{"Return-Path":"<intel-wired-lan-bounces@osuosl.org>","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=VsesJfI3;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::138; helo=smtp1.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fw9tJ6D4Vz1yCv\n\tfor <incoming@patchwork.ozlabs.org>; Wed, 15 Apr 2026 03:16:40 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id 2644584CAC;\n\tTue, 14 Apr 2026 17:16:39 +0000 (UTC)","from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id 9obS8LihYHMA; Tue, 14 Apr 2026 17:16:37 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id D077084CA2;\n\tTue, 14 Apr 2026 17:16:37 +0000 (UTC)","from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136])\n by lists1.osuosl.org (Postfix) with ESMTP id 33E9A375\n for <intel-wired-lan@lists.osuosl.org>; Tue, 14 Apr 2026 17:16:36 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp3.osuosl.org (Postfix) with ESMTP id 19A236F4B8\n for <intel-wired-lan@lists.osuosl.org>; Tue, 14 Apr 2026 17:16:36 +0000 (UTC)","from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id tCoV1eGhchGL for <intel-wired-lan@lists.osuosl.org>;\n Tue, 14 Apr 2026 17:16:35 +0000 (UTC)","from sea.source.kernel.org (sea.source.kernel.org\n [IPv6:2600:3c0a:e001:78e:0:1991:8:25])\n by smtp3.osuosl.org (Postfix) with ESMTPS id 74C5B6080E\n for <intel-wired-lan@lists.osuosl.org>; Tue, 14 Apr 2026 17:16:35 +0000 (UTC)","from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58])\n by sea.source.kernel.org (Postfix) with ESMTP id A9C7E43D19;\n Tue, 14 Apr 2026 17:16:34 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 433ACC19425;\n Tue, 14 Apr 2026 17:16:33 +0000 (UTC)"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=<UNKNOWN> ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp1.osuosl.org D077084CA2","OpenDKIM Filter v2.11.0 smtp3.osuosl.org 74C5B6080E"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1776186997;\n\tbh=I699JIDyeUL9Ff7gnnz6ACPPehC+vYO0BQr3hqPowVA=;\n\th=Date:From:To:Cc:References:In-Reply-To:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t From;\n\tb=VsesJfI3fjOcx0v4dNtcMMfESEuUuJlaa+RGBxqWfY5soaibs8V1kAe9aI6t+pBt+\n\t say9mDStuQxQV6g6Dly9L5cfYL6Dmi2x0jmkAwysZZBPyIBamKQqmEBUXSmax2hkwF\n\t Grq1owIiL5q+/X8yhGpjyQwE+kQN38+qr/y1/BzWn80XmcRsAVfp/Nwr8Ch6rQ69IA\n\t f7ZS1WSmnUlMizgg9PXWQrbb4VDFJCKnpnjYIiyM2xHdVuT4akhHIXa/XrDcLBUT2J\n\t TBSDp7jR/JMjmt1/0ZRQGqzgeyvnREQHnSZ+Kg6dVWUsVHlByrucAvGGj0sxWB8Ql3\n\t O3NgRgg+vF0tg==","Received-SPF":"Pass (mailfrom) identity=mailfrom;\n client-ip=2600:3c0a:e001:78e:0:1991:8:25; helo=sea.source.kernel.org;\n envelope-from=horms@kernel.org; receiver=<UNKNOWN>","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp3.osuosl.org 74C5B6080E","Date":"Tue, 14 Apr 2026 18:16:30 +0100","From":"Simon Horman <horms@kernel.org>","To":"Jacob Keller <jacob.e.keller@intel.com>","Cc":"Aleksandr Loktionov <aleksandr.loktionov@intel.com>,\n intel-wired-lan@lists.osuosl.org, anthony.l.nguyen@intel.com,\n netdev@vger.kernel.org, Paul Greenwalt <paul.greenwalt@intel.com>","Message-ID":"<20260414171630.GA772670@horms.kernel.org>","References":"<20260408131154.2661818-1-aleksandr.loktionov@intel.com>\n <20260408131154.2661818-3-aleksandr.loktionov@intel.com>\n <20260413103050.GL469338@kernel.org>\n <dda1f0f3-f57b-418a-93e6-2cdaa1d2ef35@intel.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<dda1f0f3-f57b-418a-93e6-2cdaa1d2ef35@intel.com>","X-Mailman-Original-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n d=kernel.org; s=k20201202; t=1776186994;\n bh=YglCd9xnuRc5fVSgrwjKGLYx/Zqhu1YuloxrREYHN98=;\n h=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n b=OqJi3uzPfg8O/OIubAf/jG0KpIY5PG8BorLO55teIT3h8Ol1Wm9gA8o2dub7pdIiz\n kKW2f9iZugbrw7OumA1v01sV16LJsEBkhevAZ6X8NCtgbdB9pCRL+YajrcSiVTuAxi\n xB2A+0TVCW8J7/XFAaeEMizpQiUoTQZ28fShibOPArFq5feMVCp7RPTtFIB7FvyJk7\n GStBouimnx8nG5q67mQV5LpSCAIl8OlvmK0cal9jx7uFRVBVcG255g8asQWr+ba3W6\n EuINzZocNLYJVFqHId80Gtq+YJI24BMThCu5TPK3W89Vads5nlgQ/ryW2EGfKzSHHK\n wNG6Xr47OioLQ==","X-Mailman-Original-Authentication-Results":["smtp3.osuosl.org;\n dmarc=pass (p=quarantine dis=none)\n header.from=kernel.org","smtp3.osuosl.org;\n dkim=pass (2048-bit key,\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=OqJi3uzP"],"Subject":"Re: [Intel-wired-lan] [PATCH iwl-net v2 2/6] ixgbe: add bounds\n check for debugfs register access","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n <intel-wired-lan.osuosl.org>","List-Unsubscribe":"<https://lists.osuosl.org/mailman/options/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>","List-Archive":"<http://lists.osuosl.org/pipermail/intel-wired-lan/>","List-Post":"<mailto:intel-wired-lan@osuosl.org>","List-Help":"<mailto:intel-wired-lan-request@osuosl.org?subject=help>","List-Subscribe":"<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>,\n <mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>"}}]