[{"id":3676915,"web_url":"http://patchwork.ozlabs.org/comment/3676915/","msgid":"<4c3e2771-4466-4390-9dbe-4175570da338@qti.qualcomm.com>","list_archive_url":null,"date":"2026-04-13T20:49:04","subject":"Re: [PATCH] ipa: Type-convert constants in jump functions during\n inlining (PR124777)","submitter":{"id":92871,"url":"http://patchwork.ozlabs.org/api/people/92871/","name":"Jeffrey Law","email":"jefflaw@qti.qualcomm.com"},"content":"Looks reasonable to me, and the key fix seems correct: when a constant \njump function is propagated into a formerly pass-through position during \ninlining, the constant must be converted/validated against the \ndestination parm type, not copied blindly.\n\nA few review notes:\n\n- **Main correctness change looks right**\n- Replacing the raw `ipa_set_jf_cst_copy` path in \n`update_jump_functions_after_inlining` with `ipa_convert_prop_cst_jf \n(...)` is the important fix.\n- Using `ipacp_value_safe_for_type` is consistent with IPA-CP’s existing \nrules for constant propagation.\n\n- **Refdesc handling seems preserved**\n- The old code did:\n- remember whether dst’s pass-through refdesc was decremented,\n- copy constant jf,\n- zap refdesc if needed.\n- The new helper preserves that behavior for the successful-conversion \ncase and degrades to unknown on failed conversion. That seems sensible.\n\n- **One thing I’d want double-checked**\n- In `ipa_convert_prop_cst_jf`, on conversion failure you call \n`ipa_set_jf_unknown (dst)` directly.\n- If `dst` had a decremented pass-through refdesc, is it always OK for \n`ipa_set_jf_unknown` alone to clean up the state correctly?\n- I suspect yes, since `ipa_set_jf_unknown` should zap any refdesc, but \nthis is the one lifecycle/detail point I’d verify.\n\n- **API exposure**\n- Making `ipacp_value_safe_for_type` non-static and declaring it in \n`ipa-cp.h` is fine.\n- No layering concern jumps out from these files.\n\n- **Test**\n- The test is good in spirit: it exercises the problematic \nsigned/unsigned/short/char constant flow that could previously lead to a \nwrong constant and bogus `__builtin_unreachable`.\n- Since this is a run test using `__builtin_exit(0)`, it should catch \nthe regression well enough.\n\nSo overall: **I don’t see a substantive bug in the patch**, just the \nminor request to verify that the failed-conversion path doesn’t need \nexplicit pre-zap handling beyond `ipa_set_jf_unknown`.\n\n\n\nOn 4/8/2026 6:31 AM, Martin Jambor wrote:\n> Hi,\n>\n> PR 124777 revealed that update_jump_functions_after_inlining does not\n> properly fold_convert constants when it propagates them from constant\n> jump functions to formerly pass-through ones, leading to expectations\n> of wrong constants in parameters leading to inserting bogus\n> builtin_unreachables during inlining.\n>\n> This patch fixes it by calling ipacp_value_safe_for_type which is what\n> IPA-CP uses during its propagation and moved handling of the case to a\n> separate function.\n>\n> Bootstrapped and LTO-bootstrapped and tested on x86_64-linux. OK for\n> master?\n>\n> Thanks,\n>\n> Martin\n>\n>\n> gcc/ChangeLog:\n>\n> 2026-04-07 Martin Jambor \n>\n> \tPR ipa/124777\n> \t* ipa-cp.h (ipacp_value_safe_for_type): Declare.\n> \t* ipa-cp.cc (ipacp_value_safe_for_type): Make public.\n> \t* ipa-prop.cc (ipa_set_jf_cst_copy): Fix comment.\n> \t(ipa_convert_prop_cst_jf): New function.\n> \t(update_jump_functions_after_inlining): Handle the constant to\n> \tpass-through case by calling ipa_convert_prop_cst_jf.\n>\n> gcc/testsuite/ChangeLog:\n>\n> 2026-04-07 Martin Jambor \n>\n> \tPR ipa/124777\n> \t* gcc.dg/ipa/pr124777.c: New test.\nNot really my space, but after getting familiar with the couple of APIs \nin here it looks quite sensible.\n\nOK for the trunk.\n\njeff","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","gcc-patches@gcc.gnu.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","gcc-patches@gcc.gnu.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256\n header.s=qcppdkim1 header.b=G/kTrdg1;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org\n (client-ip=2620:52:6:3111::32; helo=vm01.sourceware.org;\n envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org;\n receiver=patchwork.ozlabs.org)","sourceware.org;\n\tdkim=pass (2048-bit key,\n unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256\n header.s=qcppdkim1 header.b=G/kTrdg1","sourceware.org; dmarc=none (p=none dis=none)\n header.from=qti.qualcomm.com","sourceware.org;\n spf=pass smtp.mailfrom=qti.qualcomm.com","server2.sourceware.org;\n arc=pass smtp.remote-ip=205.220.180.131"],"Received":["from vm01.sourceware.org (vm01.sourceware.org\n [IPv6:2620:52:6:3111::32])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fvffw4ysSz1yD4\n\tfor ; Tue, 14 Apr 2026 06:49:39 +1000 (AEST)","from vm01.sourceware.org (localhost [127.0.0.1])\n\tby sourceware.org (Postfix) with ESMTP id C7FD14BA2E37\n\tfor ; Mon, 13 Apr 2026 20:49:36 +0000 (GMT)","from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com\n [205.220.180.131])\n by sourceware.org (Postfix) with ESMTPS id 7D5744BA2E08\n for ; Mon, 13 Apr 2026 20:49:07 +0000 (GMT)","from pps.filterd (m0279871.ppops.net [127.0.0.1])\n by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 63DG4mNM2459354; Mon, 13 Apr 2026 20:49:06 GMT","from ch4pr07cu001.outbound.protection.outlook.com\n (mail-ch4pr07cu00100.outbound.protection.outlook.com [40.93.20.96])\n by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dh3pq0xnh-1\n (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT);\n Mon, 13 Apr 2026 20:49:06 +0000 (GMT)","from LV2PR02MB11156.namprd02.prod.outlook.com\n (2603:10b6:408:350::22) by SA3PR02MB11094.namprd02.prod.outlook.com\n (2603:10b6:806:466::13) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9769.48; Mon, 13 Apr\n 2026 20:49:04 +0000","from LV2PR02MB11156.namprd02.prod.outlook.com\n ([fe80::ca5:a90e:7b8a:3905]) by LV2PR02MB11156.namprd02.prod.outlook.com\n ([fe80::ca5:a90e:7b8a:3905%2]) with mapi id 15.20.9745.044; Mon, 13 Apr 2026\n 20:49:04 +0000"],"DKIM-Filter":["OpenDKIM Filter v2.11.0 sourceware.org C7FD14BA2E37","OpenDKIM Filter v2.11.0 sourceware.org 7D5744BA2E08"],"DMARC-Filter":"OpenDMARC Filter v1.4.2 sourceware.org 7D5744BA2E08","ARC-Filter":"OpenARC Filter v1.0.0 sourceware.org 7D5744BA2E08","ARC-Seal":["i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1776113347; cv=pass;\n b=R+RvDBGsOiBDcUnMUjT3nrn1wHII2G+FU8u7hqXi0wvyZe4W0zp36SJssbZ3+1+TAQb1rGmAxJA7wcecjPQj6e6tn5A5n8utRYqhHQHTn28nbLcMVK33++9ohDFPVCkzlk0dzdLZf/JuUnJ+V5/9gJnpLfu5thgy7PKTFBN2FpA=","i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=IHW8nPsomimnEzf/KG3zFVo+P+LDGlKZFLUBRMAtz9JuvqZymPNUdrF0niqrSrX8VKvBDbD3PYNCuT2YwN5cWa1iAe4qKNLh9SK931qQd/ahTO4jzuGxcwZtYYvQjXDpec0aRnXRk8TT/LDen2bOojW3xTy9SI0+VPJhF3oPJYB7TFICZGTMm9GUxsYSERqLGUFryqo6rbCeq/TwCJQScg+wOyfE6IpeEq172EbJTKZJUAlGedYV2ic7g4Wz1M5hPtpq4ZEV/hFjRjnTWkPIKR71RhDRIMQGU3JyNWIwGw4KP7hV9D8WhjzroyE9W65TBxsc8R32pU8I/qXSiuCw6A=="],"ARC-Message-Signature":["i=2; a=rsa-sha256; d=sourceware.org; s=key;\n t=1776113347; c=relaxed/simple;\n bh=MQ6h0bIHTrGsWKlAsIZSpeCzw8iIS0TARIf5UiIFyx4=;\n h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version;\n b=Fg22TQxtCGQAXVC5tgO7zTD+TK5cbv33qvSVeVHNG5nOxZIPA8+Hmut24GFtjY6AeWbgjvsfvPBHYjQY2Lx63Bpr/UfgNTYwBwy7t8bt9v8imdAwFTtDIbLdrXBL368ENwSIVwcqx+niZPBMTM41+Xx9XF1s/55DPntUctxMB7A=","i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=MQ6h0bIHTrGsWKlAsIZSpeCzw8iIS0TARIf5UiIFyx4=;\n b=HY5R+jovSw6XbydnZe7eA0uHrO+W2rYzg2m0GP33eCvyZoYKHLUIDIiVFAjkcIz8TCBPdr1BPzQBUblm+FTVQasyZnWQpGRQ9Hh3WsRUQbRVEuwPxEyrxJqtb3UjZ7qi7wDAMOVyDtY9dStiUUss7ZD/CWb5S81iy+14L0XFIoXZljnb+J5uSr0erzlIdDkLAbRK3ues35IsZtFjwaGrfqyU6qgG8PMjwqwKEb9GI+vfs2o84qlT+puEWbB5iLMiHWLy7XX+BP51GZ+y2tUsruZ2ypRHjCqFCUKLTw/yU0yiLlq/UxD7ELhwqpnWINy77edz/4hNDBZBOJRaLkHCEQ=="],"ARC-Authentication-Results":["i=2; server2.sourceware.org","i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=qti.qualcomm.com; dmarc=pass action=none\n header.from=qti.qualcomm.com; dkim=pass header.d=qti.qualcomm.com; arc=none"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h=\n cc:content-id:content-transfer-encoding:content-type:date:from\n :in-reply-to:message-id:mime-version:references:subject:to; s=\n qcppdkim1; bh=MQ6h0bIHTrGsWKlAsIZSpeCzw8iIS0TARIf5UiIFyx4=; b=G/\n kTrdg18AaiE32nbdGaEMuxUcWfIARee0wH/0W4liWC7QbuJn1ZhcInvDXEoPMomd\n Zc/yFPsPOtnbJdUhRP+sBMD4UqUjWeEpxDPUE9ZDGPAeyT50OrfBeO1VBXINMfsF\n D7jAPHkGIzJNBe6ofTPBEc1GEwfbyiRLiDvpw3k5YJ3CNmtWrXevVriZ/aEtRhOd\n KnYSyqOAkgqH1QtPyBY2oLmpwzRrQebTYEZGp+qA11z3kuYhyoYTmol+iKnMZdIt\n sNlLb9v4vFdw80ARgjnRmH0UAgG6SIwlHbLp8u0WRgnJ4S0cmv0cw/DVCZ1rbv75\n VSYvK1Aja/nVf2AAC/Og==","From":"Jeffrey Law ","To":"Martin Jambor , GCC Patches ","CC":"Jan Hubicka ","Subject":"Re: [PATCH] ipa: Type-convert constants in jump functions during\n inlining (PR124777)","Thread-Topic":"[PATCH] ipa: Type-convert constants in jump functions during\n inlining (PR124777)","Thread-Index":"AQHcy4b2X6mBIaNNEEid4Z1QF2x9uQ==","Date":"Mon, 13 Apr 2026 20:49:04 +0000","Message-ID":"<4c3e2771-4466-4390-9dbe-4175570da338@qti.qualcomm.com>","References":"","In-Reply-To":"","Accept-Language":"en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","x-ms-publictraffictype":"Email","x-ms-traffictypediagnostic":"LV2PR02MB11156:EE_|SA3PR02MB11094:EE_","x-ms-office365-filtering-correlation-id":"ea4f015b-6cb9-46da-010c-08de999e1993","x-ms-exchange-senderadcheck":"1","x-ms-exchange-antispam-relay":"0","x-microsoft-antispam":"BCL:0;\n ARA:13230040|366016|1800799024|376014|38070700021|18002099003|56012099003|22082099003;","x-microsoft-antispam-message-info":"\n GCVVdfoBP2WZo2fMQIAjvNuwmYHtIQRHF6ge4l7MKSWkazxIlvVDY3Utzu1Nd2lyW8nv2onzcvxS0xKdl0drfGoJCaYg2kuC7VZqKnn95bjlrvHkOuhAwbkgjBmtVgHuDOiMjAn0WulivSxjxkqOD47bqIA3j+4OvTztBM3TgtWTLnJd3qUBjqbZ2KSj1ENizdw2QMMzonOkR/FSuJDb4AZBmdhn9ZpUzAZKq3RZ/H4gIJFP5Fzf9p9E4dp1wpdWN6O8RR7DQMPIaLgW2wuTg7JSPEU+9Lz2dxvzeNJt3TDv6SKAJnhOC1QJBE3dclQagIOzJYlhrq5tP6+sXZI5UIRJWmC5dztqGnnuQVcgHjGRtmlX6xyW3FSaIkD2xHKNsGDg/OqS11uAjXtTi1ndEp3g9VWsdgF4b+AqMcl/8v2EDcXLSUHRf4Pxw1fdu66yH8RnLKqWam86e85X9XrRKxQCYoERhQEAzJar16zcsWzEDyzdzCQJLU2RGwavDFBaKBfCusJAxH5lctxpxPbBdOk1jU0AjryYStuILg0X3HM9VoL9/jSadinwuWukaFMVv6R5Zy9Cc6gndQ4vBcdRphP7+EfHjkOUxfGmT8eXRKidqKU0ade0PBS44Ib27ydTZYCWeV5JTDuDiuClxb34RVXD8ynDNxkY4ZGBNr3XjzdLGZ7IUDy0fbzhJ1C4SLy5l2ki5BMINk7RK8zM/GdJrDwyliU3SuKo/MHGXe4PoGk=","x-forefront-antispam-report":"CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:LV2PR02MB11156.namprd02.prod.outlook.com; PTR:;\n CAT:NONE;\n SFS:(13230040)(366016)(1800799024)(376014)(38070700021)(18002099003)(56012099003)(22082099003);\n DIR:OUT; SFP:1101;","x-ms-exchange-antispam-messagedata-chunkcount":"1","x-ms-exchange-antispam-messagedata-0":"=?utf-8?q?Mf7WnW5bkjflF6ITxg/8+86Swkle?=\n\t=?utf-8?q?ONjie1TcuLGlnC3yapABu/FCQK6MqY0XGzJ8eR3NbYvd6DQiD7yBzLpfHBdqvKVqD?=\n\t=?utf-8?q?dSQtP10vmEyFUo4AXaxG4sByMZCX5LFlBRGubTPJmteahPGmEyvLPCHcdZToAW+Qa?=\n\t=?utf-8?q?b3GRlpY6u1nJD4c6MumOl7CVFkawOpeUySV/9saFDPTf/WRvH18HjdxBko1YZsNah?=\n\t=?utf-8?q?UuVjAdvn4PVmEk3bwJ+H9CGkjm0PdDCj9ZYkbyo2GRfwEhugQNDp55HHqkz2tDrTR?=\n\t=?utf-8?q?2YYFy2jwY5kZUalUpH/Z/UxBCOYQsE7tXX1eB7gFYeUrrLEq9nDBnQp42WDSLJzY5?=\n\t=?utf-8?q?SIZOsE4ntkf3cF0i3nXNnRAIvjjmHi++exVPm0ajsqgfuUZUNz0cklUhwI28ZHqJf?=\n\t=?utf-8?q?dpYfi6wsekDZtQ1+CY0K+S4mcB5dtaKNU2fwdTl0liD5FDUCy8jbc5wSe/4lyxUif?=\n\t=?utf-8?q?j8h7ZIPAdhoAX+2JbML0J0fAwY+CATbukmr4JbipjdbcP0bNxATMNeYZ07BsymGyH?=\n\t=?utf-8?q?/AWJE/f8FPBsugoYuxlYC030zR5/b7dnEhbgMo+ebBwAcXbQDfV21ND6UwTz9ar+z?=\n\t=?utf-8?q?u5rQPFTwVGNOZDTow/36uMv6+2Y9iIuaQ+29tG3squlKev4musi8vhjqhXGb+U2S9?=\n\t=?utf-8?q?YdpYMYwVB+9F0qU0/z4mdQnuFmr8zXxnkhwB815qpWDttoZOz5OW2OUXmSjnOuHQy?=\n\t=?utf-8?q?R3CZ9x70Ale8cxBtXQTiHtcdYyCeCtDj6cPKPOji/qvCtPSiti8HlJ06wn/FSI/3/?=\n\t=?utf-8?q?euFe1XivNUn/+e/TxY8ch6Iz9Qyyo+2PaukQrwIqxA7M7jUHTeyjprFH4kTu7sokc?=\n\t=?utf-8?q?D49z5Z54YKg98AHzBrB1QWXecjrOxu7+qqq77+fOJqxvyn4bzNF00eZeZF+shxZkM?=\n\t=?utf-8?q?JlK81dLtz3FTWMP5vMoSaWaogcgUOCv22crtaseLyOOk3WlfK9aLm+yDrjK5jEeo7?=\n\t=?utf-8?q?eDavhW2L3RXDZ1Hd80ADkCq/wVmhvr/SG6F2eFQnK9kiAX7w5SHnhNVCHmIdMOACQ?=\n\t=?utf-8?q?DBm+YgK4PtPSL+OKCJ3ANZFV/Zllx3VH3txSj9MExSLI1myYeQonaN8uVOJRbL00C?=\n\t=?utf-8?q?T+kh+0TsY9vrosr/La5Z+OlJTAZ9kYMZo+bDTjHfx0tWA8DjyVbUouaG+0XHpK7nE?=\n\t=?utf-8?q?J0QMse+dn2SkWWPGCx17ONJ2tcQQedzZq4KoUiD2Tbj28CHXwp7ACg8tVKc53GL6h?=\n\t=?utf-8?q?Lrz2cTpIazGDP3/dyS7ne4ZEZ3iGtLXryvOky9MFLTX84ZDSQq15gbrrViEQYX65R?=\n\t=?utf-8?q?Q2/eOQUDdJOH3R4lfmgOrqXaqf34Rh+CKr4vV2oLnDj3W5DBybN+Jyg5PNx28Vzjj?=\n\t=?utf-8?q?VsgX99jAcErjlsYLSCe3KJ79emXWo8jOeDI9ZQSD9Hzed47/KS1BThuqGv1tW5gZd?=\n\t=?utf-8?q?MwsyHvw1sBv/rVYFkQDtkUU2+/Ezrl0fPRuck4IN1iNaYQ7+QE+n0cjWFg2/hWYWr?=\n\t=?utf-8?q?bxgRhkxUmD8SBUKmMDjj0pCoHiNTJDmhJ7kuFtg4xT4Zqhu6c5R0AEOHMifhUSukE?=\n\t=?utf-8?q?RfA4bvJyJ3GL4+H/bWgEEUfm143vo6A2XATr2CjMsGV0FGkDKVkHALhybS60OWzkn?=\n\t=?utf-8?q?S7qfpKNepz/AD9ymPX6jOQCNHj10pAbdoonQjju1dNFnOsBgiwOR3ZE/a/GoTz/YL?=\n\t=?utf-8?q?hSMHjP38fV3VBRrvxe6cBxZFrxSNrQUprDDz6XB4bgtz/nrahFRCg=3D?=","Content-Type":"text/plain; charset=\"utf-8\"","Content-ID":"<7FC75716B7531F418F3603C4425C543E@namprd02.prod.outlook.com>","Content-Transfer-Encoding":"base64","MIME-Version":"1.0","X-Exchange-RoutingPolicyChecked":"\n ULGt/YJkF45GuAIjqh8AUpgCuTsF6npJH/W8uIObDHYOGiga9lIbu/fksHXM6T1EliY1Ty+78tQt+tVe1ATjqvDqmediT+UAilV+RK4gwaG8Fsv8eL3P6mQq3l7THHlUYYZIG2RjhboLhraNNlWzMoj4UreT/rzn6p8wFoB69bFsEaaXFmGc89auTSweZgrOvYD8EjLCYKeQIBFhu7F46CUrs0/h7xdvtsL80OQioFDGKx7hfMSjCruazkz6qPlhmR88ZEisF5FKlIQdR/dMZZ5ix/Jl6xtZqzfWKsJEKgMAXcK1KKjCNMNtpwAwRzCTqTaKE7CSUKrve+Elx7LvJQ==","X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount":"1","X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0":"\n 0lOCJgsshJy+FgFukDggWZX8hi2cXQ2Hla/4urHiyTi1w+Pl2o4FEVykQKcwvtgSI3roJn1iQA34IcASatQ1RgZPTc1IkDAnDlz+pnCrXq92GTojeSWWZgwi/WZd5pGH91UhqJtStIwFRLmHInRSbpkm249+Sl5Qch23VTc6WpZT1kwDs9tYsx8D4jW8DuiqHgmu/S4S1tAkd5V6EyrLGizSdCGm9etcszy4bpVeN8NhYrlwRwB0wojU66vkWfvEHpHVhBB+kOwOUsG6AV6QnlXhH3nOcyeoELRNR7TxyjkHpEa0Ot2+sx7a6GOpNZ0hRNVr5EdmHuOPkjSlhALxDmWRn1eewtWW15ZXrYcuwl+Oozxv5Y/PlHWv6we01yan4ZI5E/HU9i0xQYLy9mjYWNz089WLHaRXi00ObVcBYqjEVYtRrQnNaDwJ1NAC+oIvScMJbuzXD3Dk/BeNSlWZtOnPzBrQ1/WeVF37zXk4yYffHRBS3u0bk0POCrFcFPFOCPOw09ALBFbcLt9F9iE0PUoaluHcBQAkx8dlKroLHmk6KDK5Rz8MwjfmBSoJMfEPDq4dsogtQTZiVL/hLRC8csifdqV65VjuRejqRpgSXpRD4fmhtXVwxE1YzHygoXVC","X-OriginatorOrg":"qti.qualcomm.com","X-MS-Exchange-CrossTenant-AuthAs":"Internal","X-MS-Exchange-CrossTenant-AuthSource":"LV2PR02MB11156.namprd02.prod.outlook.com","X-MS-Exchange-CrossTenant-Network-Message-Id":"\n ea4f015b-6cb9-46da-010c-08de999e1993","X-MS-Exchange-CrossTenant-originalarrivaltime":"13 Apr 2026 20:49:04.5497 (UTC)","X-MS-Exchange-CrossTenant-fromentityheader":"Hosted","X-MS-Exchange-CrossTenant-id":"98e9ba89-e1a1-4e38-9007-8bdabc25de1d","X-MS-Exchange-CrossTenant-mailboxtype":"HOSTED","X-MS-Exchange-CrossTenant-userprincipalname":"\n nQsDZylrv5I1QTPDoqS1NwX9AE4c3m28MugzHP/qRs7RBvZZAwRl3kx7zCEEBtUbJOfokZiHUfKaepHWsv2v44Jpe+1kLbNX0NYI3QHLMbI=","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"SA3PR02MB11094","X-Proofpoint-GUID":"m9yPXvxx2ZNJ7Xr8fbTLo9Xo-ge_4qPF","X-Proofpoint-ORIG-GUID":"m9yPXvxx2ZNJ7Xr8fbTLo9Xo-ge_4qPF","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwNDEzMDIwNCBTYWx0ZWRfX2YwhE85y9vWp\n jMknyRQJVWoJuI8WBZQUGwArttfEJKAZLYrPC1eKgnNSyH/tz3LPrDfZ6gzpZtzGEHC2gx0cHR+\n RqwiQ/RNbuxTBof0DxHHlgtmYSrbdf9VZFgEQAqCzvP6XI/AgAuS7YLmjq5r/Ta0Xa8Rin227n4\n ouhgnc8ymCIz1wHHTeUK0ETAtk8Km5I+u3tY0uvJyPZjrrUpd46dYiPgP6tkGbYP/W3ckbVhVM8\n 58ChMe8bZepfWecBfZXdvigPFLJVEsmtukz9K4TA+/F+RELj+kryrmW/LM8Y1EGtCGB1it5noPS\n E1cstjvTVkzWM6FuUMsBQV2+SDGZs8qZ4+y17lyd8IeRdfbxJWhfGAXu+0ZmtOGDNkwHc4pCK3x\n Ro7sy6QXpUpFofNr8bhtCUG5091NlwamKA1XqVE73NqUE3rAO4b6V7f01gLdQRzhFrBVv8vuQ3V\n 4VUeZTK7yXTWw9Z5ZtA==","X-Authority-Analysis":"v=2.4 cv=Vv0Txe2n c=1 sm=1 tr=0 ts=69dd56c2 cx=c_pps\n a=9xaBLH33BRUJl5e4Wy82dw==:117 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19\n a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10\n a=A5OVakUREuEA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22\n a=3WHJM1ZQz_JShphwDgj5:22 a=2iXUqxcHcvC0hpz1DAIA:9 a=QEXdDO2ut3YA:10","X-Proofpoint-Virus-Version":"vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-04-13_03,2026-04-13_04,2025-10-01_01","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n clxscore=1011 lowpriorityscore=0 impostorscore=0 priorityscore=1501\n suspectscore=0 phishscore=0 spamscore=0 malwarescore=0 adultscore=0\n bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound\n adjust=0 reason=mlx scancount=1 engine=8.22.0-2604010000\n definitions=main-2604130204","X-BeenThere":"gcc-patches@gcc.gnu.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Gcc-patches mailing list ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org"}},{"id":3676917,"web_url":"http://patchwork.ozlabs.org/comment/3676917/","msgid":"","list_archive_url":null,"date":"2026-04-13T20:52:37","subject":"Re: [PATCH] ipa: Type-convert constants in jump functions during\n inlining (PR124777)","submitter":{"id":92310,"url":"http://patchwork.ozlabs.org/api/people/92310/","name":"Jeffrey Law","email":"jeffrey.law@oss.qualcomm.com"},"content":"On 4/13/2026 2:49 PM, Jeffrey Law wrote:\n> Looks reasonable to me, and the key fix seems correct: when a constant\n> jump function is propagated into a formerly pass-through position during\n> inlining, the constant must be converted/validated against the\n> destination parm type, not copied blindly.\n[ ...]\nNuts, did it again.  Ignore the LLM slop at the top.  My ACK stands.\n\njeff","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","gcc-patches@gcc.gnu.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","gcc-patches@gcc.gnu.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256\n header.s=qcppdkim1 header.b=MQvc42oR;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n header.a=rsa-sha256 header.s=google header.b=gRphrFj4;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=gcc.gnu.org\n (client-ip=2620:52:6:3111::32; helo=vm01.sourceware.org;\n envelope-from=gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org;\n receiver=patchwork.ozlabs.org)","sourceware.org;\n\tdkim=pass (2048-bit key,\n unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256\n header.s=qcppdkim1 header.b=MQvc42oR;\n\tdkim=pass (2048-bit key,\n unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n header.a=rsa-sha256 header.s=google header.b=gRphrFj4","sourceware.org; dmarc=none (p=none dis=none)\n header.from=oss.qualcomm.com","sourceware.org;\n spf=pass smtp.mailfrom=oss.qualcomm.com","server2.sourceware.org;\n arc=none smtp.remote-ip=205.220.168.131"],"Received":["from vm01.sourceware.org (vm01.sourceware.org\n [IPv6:2620:52:6:3111::32])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fvfkZ05sKz1y2d\n\tfor ; Tue, 14 Apr 2026 06:53:10 +1000 (AEST)","from vm01.sourceware.org (localhost [127.0.0.1])\n\tby sourceware.org (Postfix) with ESMTP id 042DD4BA2E16\n\tfor ; Mon, 13 Apr 2026 20:53:08 +0000 (GMT)","from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com\n [205.220.168.131])\n by sourceware.org (Postfix) with ESMTPS id 82F404BA2E08\n for ; Mon, 13 Apr 2026 20:52:41 +0000 (GMT)","from pps.filterd (m0279863.ppops.net [127.0.0.1])\n by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 63DEmaVJ1764445\n for ; Mon, 13 Apr 2026 20:52:40 GMT","from mail-dl1-f70.google.com (mail-dl1-f70.google.com\n [74.125.82.70])\n by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dh2k0980y-1\n (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT)\n for ; Mon, 13 Apr 2026 20:52:40 +0000 (GMT)","by mail-dl1-f70.google.com with SMTP id\n a92af1059eb24-1273dfdaf5dso4694846c88.0\n for ; Mon, 13 Apr 2026 13:52:40 -0700 (PDT)","from [172.31.0.11] ([136.38.201.137])\n by smtp.gmail.com with ESMTPSA id\n a92af1059eb24-12c346fb141sm15473221c88.12.2026.04.13.13.52.38\n for \n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Mon, 13 Apr 2026 13:52:38 -0700 (PDT)"],"DKIM-Filter":["OpenDKIM Filter v2.11.0 sourceware.org 042DD4BA2E16","OpenDKIM Filter v2.11.0 sourceware.org 82F404BA2E08"],"DMARC-Filter":"OpenDMARC Filter v1.4.2 sourceware.org 82F404BA2E08","ARC-Filter":"OpenARC Filter v1.0.0 sourceware.org 82F404BA2E08","ARC-Seal":"i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776113561; cv=none;\n b=GBld8FKcWM5MEILjU2y3ipNvWjWlVdbivPGA98du+BmDK+QSF4g9pxRGDN1QxiH9/XQ5RI8vuxencaG4Lwz+9WrctegrJaxJZpI6JJxolhWaEtB3m12jmlP+WOnmmH6HUDXyWRnxzWh0kXmUMavi7nC/S5H0aAGfeqU6XZVdm3c=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=sourceware.org; s=key;\n t=1776113561; c=relaxed/simple;\n bh=vfOzOBvL/i3ofWdBEQJCTvyPDMMAeuH4i7Hys9+qmSs=;\n h=DKIM-Signature:DKIM-Signature:Message-ID:Date:MIME-Version:\n Subject:To:From;\n b=POQAIUg1aQb6uScBB4sFOqqHsk58Sxc3ZUZOz3WF3V9ntXYC3CE1/GVaWBSa4SwbC15ouaMNp56TO7NIkz5M7xVJw012qLhbUxWQyTfcHuOl7HpxGnfPaXkDRkeAeCfMWAyeGDjcWq2G5my75j9sT5bsTwQXXYo6de2iVfrbT1Y=","ARC-Authentication-Results":"i=1; server2.sourceware.org","DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h=\n content-transfer-encoding:content-type:date:from:in-reply-to\n :message-id:mime-version:references:subject:to; s=qcppdkim1; bh=\n vfOzOBvL/i3ofWdBEQJCTvyPDMMAeuH4i7Hys9+qmSs=; b=MQvc42oROgiysuCW\n ZsKoNxExs9ukiA0m4E2xs1biT19QAsiRjl3xCSU002pYPpYnt4nZFz74BxKIX6ku\n 2WI05rZxBpWvPDJOFDbwi0unlZdfSS/aOdAMkR/k43SPxKhJr1W5n3i/gKTtTqS9\n drwEAzcE1M/mfVqS2s5UvZ5wsD7BZkie4cIft1jLTVHxh7jiCsqJx3L1puG4Wng5\n 0zcu+X1wBohGwxPE8oB6u6qa/gQiObiCln7K5g4AY4WbzukwbOZ/8gCXmJ/mTasD\n BfRDqoQ7UK76vjj5sYnacUmL8YgHVD+EBpoqHrh3ZImatx4JN9CLW1f1qXaxVh2g\n S0BtuA==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=oss.qualcomm.com; s=google; t=1776113560; x=1776718360; darn=gcc.gnu.org;\n h=content-transfer-encoding:in-reply-to:from:content-language\n :references:to:subject:user-agent:mime-version:date:message-id:from\n :to:cc:subject:date:message-id:reply-to;\n bh=vfOzOBvL/i3ofWdBEQJCTvyPDMMAeuH4i7Hys9+qmSs=;\n b=gRphrFj4k6WOjXjP3oS1I5xnRo3jo3975B3VPX1/ZzcXEsulfA+wOupmxqNoEVZoXO\n D1ZU4lT5xc08x8KUO91D0z0kmAnULiOg1wXT8Di8ZjDKqo/TEha5CPCtwxzp9QttzqoX\n 8ATbLBWwKohZ7xVMTwNdP/5vqzQ6CA/Q52g/HJKpEQsYk9GZzot9rqwAYg5yQSPSHGK5\n kZAJseYF/Y7FgrgUglP04XWMfusns/j1hG5+hBKLCuK53/3wWCm/HGy9YGtw6Hfq/Aob\n RfXGV65oHr9HwY1FlOYlYWLfSudDDSx5MiE6xs8bkXlgy2jRJpWPufEbmydQD2cg3IWG\n LZ1g=="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1776113560; x=1776718360;\n h=content-transfer-encoding:in-reply-to:from:content-language\n :references:to:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=vfOzOBvL/i3ofWdBEQJCTvyPDMMAeuH4i7Hys9+qmSs=;\n b=UaYJdRJvG1YVuntKlgUbqBJkiz+j8BFBbjKsvpJ8tncD4RaGJYQ2A9OISKM9j0iTH1\n KedzjETSUa2pkg0NQc8e9lwC7PJlA8s/XmpocA3pLojJSka/ONmxhhUMxwWUWqenxSsL\n BT6iJRgmXapoxjOA/w6axs1PX9eWPVeLM/PH7kx4IKh2xPPXEIWX2J7we19XjWRK2Ge8\n NkSH7l7kAWI2GyQiQXrUYqOL2B/Fv09dfuB1rYR1OYqy5YrYoh2+J3XXkafAmTie/HLK\n f/1Cdr1kzWWAltn3zrc78VKMChfpu5I4WO6CqDBClowIe7XSiEEizH1OmOesgYl7/Thx\n QK4g==","X-Gm-Message-State":"AOJu0YwhGm3QGK3pugfVDOtppIPQfQGqqMH1V0rK+b0Qs7BYinVMwyCb\n os1ciTKZeuL1RyaoklFxUmUV3Oel778kVHhv/K7AmMnR43aKzsN2JERKbQTiZfPYbEdzh96CcT5\n cJXe4u+EU7/2EE1JKazF+/ZIWAK0u6BnwDBmWqEZ+/fauK8+BbDzuLajrvv1TThf+HbIb","X-Gm-Gg":"AeBDieskvuwxEo5NkWkpAYGNmbMNVs1h2xR8y72T+eOodUSLBcCa8TxYHzJChBvyMxd\n cXwMWyT/9RBqCjKWLcCX3EKDfQ+/kcN8SfzOMvaIs149I65R8J8wBRFLrpKF+PUB+FxXmNnay/V\n OxwjVEgI3vTSwvuvCf4HvzIheZw5z3nqcnlpoidWchfAdquYFZNby8iifrG0ce8FBULBN5VXcys\n yxInIQnLuUuGPgSv0ePpmIHc8bRTbRjU5ST38oS9g3enavaluGQyeGtrpv6eWsFYJzgKTWP+QKM\n ijRO6K3FTS+O2BEX83Xk+V1toos55LtUbSO/eIwNfEzaFMsQ436/gBDB7IAJYkBTVpAju2oo+34\n P3n6rbhgSV/PIhDCEoKkNJeQqDw0R2JbLtVwm6t+bmvZ7VYWtjA==","X-Received":["by 2002:a05:7022:f016:b0:12a:6abf:ab1c with SMTP id\n a92af1059eb24-12c352e2905mr7387601c88.11.1776113559711;\n Mon, 13 Apr 2026 13:52:39 -0700 (PDT)","by 2002:a05:7022:f016:b0:12a:6abf:ab1c with SMTP id\n a92af1059eb24-12c352e2905mr7387588c88.11.1776113559088;\n Mon, 13 Apr 2026 13:52:39 -0700 (PDT)"],"Message-ID":"","Date":"Mon, 13 Apr 2026 14:52:37 -0600","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH] ipa: Type-convert constants in jump functions during\n inlining (PR124777)","To":"gcc-patches@gcc.gnu.org","References":"\n <4c3e2771-4466-4390-9dbe-4175570da338@qti.qualcomm.com>","Content-Language":"en-US","From":"Jeffrey Law ","In-Reply-To":"<4c3e2771-4466-4390-9dbe-4175570da338@qti.qualcomm.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-Proofpoint-GUID":"QHHt1GV6W9X3i-WD4rw_epXuZ7BltsZW","X-Authority-Analysis":"v=2.4 cv=CsGPtH4D c=1 sm=1 tr=0 ts=69dd5798 cx=c_pps\n a=SvEPeNj+VMjHSW//kvnxuw==:117 a=asGLMfRmzhnGNxaIYohjRg==:17\n a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10\n a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22\n a=PD6MrF3pX1g7qd6mN0cA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10\n a=Kq8ClHjjuc5pcCNDwlU0:22","X-Proofpoint-ORIG-GUID":"QHHt1GV6W9X3i-WD4rw_epXuZ7BltsZW","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwNDEzMDIwNSBTYWx0ZWRfXxsdhwFB2ls0b\n B2FL7ECPY/upHxJwvC/G9cPquZsF6qEqDKaYjWJW4AKFphnsmt6qYOlOWoKN3WNiS78/t778AVQ\n akPBUvInoVes9nyvt6fZXeM9rOFYwDkCGPsrABrFBPJv8+lircixW8tLGWoD7nv8fFSPTcq7Jqc\n oxmLk/VDR6TZUHQibUtgKnCr+7dY5ZTHm3+CIdb5m8fHQWKObIenglYOYUyfPsYlJSubYwedcTb\n NW4ApA3cDVSQlQTDeU+hIl/f+O9lvjqEXIkbkKPGydpmpcqFZWBDJoqifJhRtrqsZgTufFpwA42\n sVhK+Im2G4tQf8+2x4/ueam5x2EZaPuMgwdmj6px7c5Z/aKFKUGVAVot2Wqznq+emjPTNAmsIkK\n FdpFIawPmmNXUsgFbFKI4NrRwlHdailA/9qDJv+hSVIP1r4NMP48f43VEHP+lSWUHG43RmqvsBt\n /8ZlkAl/9zxgsprbTcA==","X-Proofpoint-Virus-Version":"vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-04-13_03,2026-04-13_04,2025-10-01_01","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n spamscore=0 suspectscore=0 bulkscore=0 clxscore=1015 phishscore=0\n malwarescore=0 priorityscore=1501 impostorscore=0 lowpriorityscore=0\n adultscore=0 classifier=typeunknown authscore=0 authtc= authcc=\n route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604010000\n definitions=main-2604130205","X-BeenThere":"gcc-patches@gcc.gnu.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Gcc-patches mailing list ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"gcc-patches-bounces~incoming=patchwork.ozlabs.org@gcc.gnu.org"}}]