[{"id":3675477,"web_url":"http://patchwork.ozlabs.org/comment/3675477/","msgid":"","list_archive_url":null,"date":"2026-04-09T19:20:55","subject":"Re: [patch V2 09/11] power: supply: charger-manager: Switch to\n alarm_start_timer()","submitter":{"id":74928,"url":"http://patchwork.ozlabs.org/api/people/74928/","name":"Sebastian Reichel","email":"sebastian.reichel@collabora.com"},"content":"Hi,\n\nOn Wed, Apr 08, 2026 at 01:54:24PM +0200, Thomas Gleixner wrote:\n> The existing alarm_start() interface is replaced with the new\n> alarm_start_timer() mechanism, which does not longer queue an already\n> expired timer and returns the state. Adjust the code to utilize this.\n> \n> No functional change intended.\n> \n> Signed-off-by: Thomas Gleixner \n> Cc: Sebastian Reichel \n> Cc: linux-pm@vger.kernel.org\n> ---\n> V2: Rename to alarm_start_timer()\n> ---\n\nAcked-by: Sebastian Reichel \n\nGreetings,\n\n-- Sebastian\n\n> drivers/power/supply/charger-manager.c | 12 +++++++-----\n> 1 file changed, 7 insertions(+), 5 deletions(-)\n> --- a/drivers/power/supply/charger-manager.c\n> +++ b/drivers/power/supply/charger-manager.c\n> @@ -881,7 +881,7 @@ static bool cm_setup_timer(void)\n> \tmutex_unlock(&cm_list_mtx);\n> \n> \tif (timer_req && cm_timer) {\n> -\t\tktime_t now, add;\n> +\t\tktime_t exp;\n> \n> \t\t/*\n> \t\t * Set alarm with the polling interval (wakeup_ms)\n> @@ -893,14 +893,16 @@ static bool cm_setup_timer(void)\n> \n> \t\tpr_info(\"Charger Manager wakeup timer: %u ms\\n\", wakeup_ms);\n> \n> -\t\tnow = ktime_get_boottime();\n> -\t\tadd = ktime_set(wakeup_ms / MSEC_PER_SEC,\n> +\t\texp = ktime_set(wakeup_ms / MSEC_PER_SEC,\n> \t\t\t\t(wakeup_ms % MSEC_PER_SEC) * NSEC_PER_MSEC);\n> -\t\talarm_start(cm_timer, ktime_add(now, add));\n> \n> \t\tcm_suspend_duration_ms = wakeup_ms;\n> \n> -\t\treturn true;\n> +\t\t/*\n> +\t\t * The timer should always be queued as the timeout is at least\n> +\t\t * two seconds out. Handle it correctly nevertheless.\n> +\t\t */\n> +\t\treturn alarm_start_timer(cm_timer, exp, true);\n> \t}\n> \treturn false;\n> }\n>","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","netfilter-devel@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=collabora.com header.i=sebastian.reichel@collabora.com\n header.a=rsa-sha256 header.s=zohomail header.b=AUAa/L3+;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.234.253.10; helo=sea.lore.kernel.org;\n envelope-from=netfilter-devel+bounces-11778-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (1024-bit key) header.d=collabora.com\n header.i=sebastian.reichel@collabora.com header.b=\"AUAa/L3+\"","smtp.subspace.kernel.org;\n arc=pass smtp.client-ip=136.143.188.112","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=collabora.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=collabora.com"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org [172.234.253.10])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fs8wD2z0Mz1yHG\n\tfor ; Fri, 10 Apr 2026 05:22:52 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id E2A093026C1F\n\tfor ; Thu, 9 Apr 2026 19:22:23 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 302EB3368BF;\n\tThu, 9 Apr 2026 19:22:22 +0000 (UTC)","from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com\n [136.143.188.112])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 7E3DD261B8D;\n\tThu, 9 Apr 2026 19:22:20 +0000 (UTC)","by mx.zohomail.com with SMTPS id 177576246039850.8603406281004;\n\tThu, 9 Apr 2026 12:21:00 -0700 (PDT)","by venus (Postfix, from userid 1000)\n\tid 2ACC9180E60; Thu, 09 Apr 2026 21:20:55 +0200 (CEST)"],"ARC-Seal":["i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1775762541; cv=pass;\n b=NoGOE8m1aD0kAAG0vRLfIDj6OjFF1dZvC12OAP+IQsW4A2wgxeCybalb1/if+MEJyTPbkIRnytHGXIjmNWAMXgpYHNEiD0VMfJ+L0/1s2R9GXbyPLqi5gMEz9lHXDrQTgAh2j00dSWZXNblRp+P9ADfhhcK/EWaGHgWcIIyXAkU=","i=1; a=rsa-sha256; t=1775762463; cv=none;\n\td=zohomail.com; s=zohoarc;\n\tb=LQlkhaNjyUWKbfUI20z4Sf3YS1KXPL7jIOiTz9QQebt+/5alABNaXgzyknVE0jXSnulby0iELWugUFszjHTtlJAiAu2XyP9z3N04j9ynaHH5XoFoFxtLKE0jiRtIoPVxaWEVrGyQXtiF0hkGtvLBzx0FKM7iVd9MbRqe9rFNuxo="],"ARC-Message-Signature":["i=2; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1775762541; c=relaxed/simple;\n\tbh=ABg8sJ+/UIG+zaHTF8FE4V2Q8CfCjtoq7FfLessYPIs=;\n\th=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:\n\t Content-Type:Content-Disposition:In-Reply-To;\n b=KDQubcoe6SHVJMlkMKkrxcrXCWB6fms36HoRn6IPivpEJHNbsjsIM5vtwjVF/U4yDtc4qQxqL1n0SdjDEkiGaYGB3MREmKhTmzZR5/Pm0kRDzcYQcDvn5vWtXeTA0AjQd6+0ZbhKvH5jgOjDxAGWAWxqr8C9fpA8ibJnz5SRs9Q=","i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com;\n s=zohoarc;\n\tt=1775762463;\n h=Content-Type:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To;\n\tbh=F3Si1X1PgfNUXsdrfdhmzDQHbKwjXj53THXSeknqpyA=;\n\tb=LPS7I3lOkF4ABWJNXHjlKfo/6IkuMA20YSQPMs692qQJKYfxqk28xUkElvEmLgdpeimhqC3DoHYFsjiHqpJ27GPJyCiaODVsxC5cqgMe0hPfI4GwsGDg4iRuxK4bxQHuaZ/wUYmij2f/Yw/ONiMz4zjJ0ZagsmFYKLXYYue3L3k="],"ARC-Authentication-Results":["i=2; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=collabora.com;\n spf=pass smtp.mailfrom=collabora.com;\n dkim=pass (1024-bit key) header.d=collabora.com\n header.i=sebastian.reichel@collabora.com header.b=AUAa/L3+;\n arc=pass smtp.client-ip=136.143.188.112","i=1; mx.zohomail.com;\n\tdkim=pass header.i=collabora.com;\n\tspf=pass smtp.mailfrom=sebastian.reichel@collabora.com;\n\tdmarc=pass header.from="],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1775762463;\n\ts=zohomail; d=collabora.com; i=sebastian.reichel@collabora.com;\n\th=Date:Date:From:From:To:To:Cc:Cc:Subject:Subject:Message-ID:References:MIME-Version:Content-Type:In-Reply-To:Message-Id:Reply-To;\n\tbh=F3Si1X1PgfNUXsdrfdhmzDQHbKwjXj53THXSeknqpyA=;\n\tb=AUAa/L3+2lwVCL2ZUfTY1LNdK91B6s8tQ5VeIrMtAQqAlMwE3MmmyWcWyy6p2VkA\n\t3IUgm2n8XHb5tSjzFDzvnXYsIxyoPcDV6hZBRg74n1V6qVPnKT3yHQ0EWte9RuGdrs/\n\tfuorKCbCwIr7tGLCtnF9xpeN4Q4XRD+Q+LOa3cm8=","Date":"Thu, 9 Apr 2026 21:20:55 +0200","From":"Sebastian Reichel ","To":"Thomas Gleixner ","Cc":"LKML , linux-pm@vger.kernel.org,\n\tCalvin Owens ,\n Anna-Maria Behnsen ,\n\tFrederic Weisbecker ,\n \"Peter Zijlstra (Intel)\" ,\n\tJohn Stultz , Stephen Boyd ,\n\tAlexander Viro ,\n Christian Brauner , Jan Kara ,\n\tlinux-fsdevel@vger.kernel.org, Pablo Neira Ayuso ,\n\tFlorian Westphal , Phil Sutter ,\n netfilter-devel@vger.kernel.org,\n\tcoreteam@netfilter.org","Subject":"Re: [patch V2 09/11] power: supply: charger-manager: Switch to\n alarm_start_timer()","Message-ID":"","References":"<20260408102356.783133335@kernel.org>\n <20260408114952.536945376@kernel.org>","Precedence":"bulk","X-Mailing-List":"netfilter-devel@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha512;\n\tprotocol=\"application/pgp-signature\"; boundary=\"wmsijnsatuforoie\"","Content-Disposition":"inline","In-Reply-To":"<20260408114952.536945376@kernel.org>","X-Zoho-Virus-Status":"1","X-Zoho-AV-Stamp":"zmail-av-0.2.2.1.5.2/275.753.7","X-ZohoMailClient":"External"}}]