[{"id":3674728,"web_url":"http://patchwork.ozlabs.org/comment/3674728/","msgid":"","list_archive_url":null,"date":"2026-04-08T12:07:49","subject":"Re: [Intel-wired-lan] [PATCH iwl-next 1/2] i40e: implement basic\n per-queue stats","submitter":{"id":75597,"url":"http://patchwork.ozlabs.org/api/people/75597/","name":"Loktionov, Aleksandr","email":"aleksandr.loktionov@intel.com"},"content":"> -----Original Message-----\n> From: Intel-wired-lan On Behalf\n> Of Paolo Abeni\n> Sent: Wednesday, April 8, 2026 1:44 PM\n> To: intel-wired-lan@lists.osuosl.org\n> Cc: Nguyen, Anthony L ; Kitszel,\n> Przemyslaw ; Andrew Lunn\n> ; David S. Miller ; Eric\n> Dumazet ; Jakub Kicinski ;\n> Alexei Starovoitov ; Daniel Borkmann\n> ; Jesper Dangaard Brouer ; John\n> Fastabend ; Stanislav Fomichev\n> ; netdev@vger.kernel.org\n> Subject: [Intel-wired-lan] [PATCH iwl-next 1/2] i40e: implement basic\n> per-queue stats\n> \n> Only expose the counters currently available (bytes, packets); add\n> account for base stats to deal with ring clear.\n> \n> Signed-off-by: Paolo Abeni \n> ---\n> drivers/net/ethernet/intel/i40e/i40e.h | 7 ++\n> drivers/net/ethernet/intel/i40e/i40e_main.c | 133\n> ++++++++++++++++++++\n> 2 files changed, 140 insertions(+)\n> \n> diff --git a/drivers/net/ethernet/intel/i40e/i40e.h\n> b/drivers/net/ethernet/intel/i40e/i40e.h\n> index dcb50c2e1aa2..fe642c464e9c 100644\n> --- a/drivers/net/ethernet/intel/i40e/i40e.h\n> +++ b/drivers/net/ethernet/intel/i40e/i40e.h\n> @@ -836,16 +836,23 @@ struct i40e_vsi {\n> \tstruct i40e_eth_stats eth_stats;\n> \tstruct i40e_eth_stats eth_stats_offsets;\n> \tu64 tx_restart;\n\n...\n\n> +static void i40e_zero_tx_ring_stats(struct netdev_queue_stats_tx *tx)\n> {\n> +\ttx->bytes = 0;\n> +\ttx->packets = 0;\n> +\ttx->stop = 0;\n> +\ttx->wake = 0;\n> +\ttx->hw_drops = 0;\n> +}\n> +\n> +static void i40e_add_tx_ring_stats(struct i40e_ring *tx_ring,\n> +\t\t\t\t struct netdev_queue_stats_tx *tx) {\n> +\tu64 bytes, packets;\n> +\tunsigned int start;\n> +\n> +\tdo {\n> +\t\tstart = u64_stats_fetch_begin(&tx_ring->syncp);\n> +\t\tbytes = tx_ring->stats.bytes;\n> +\t\tpackets = tx_ring->stats.packets;\n> +\t} while (u64_stats_fetch_retry(&tx_ring->syncp, start));\n> +\n> +\ttx->bytes += bytes;\n> +\ttx->packets += packets;\n> +\n> +\ttx->stop += tx_ring->tx_stats.tx_stopped;\n> +\ttx->wake += tx_ring->tx_stats.restart_queue;\n> +\ttx->hw_drops += tx_ring->tx_stats.tx_busy; }\nWhy the reads are outside the seqlock region? \nOn 32-bit kernels, unprotected u64 reads can tear IMHO\n\n> +\n> +static void i40e_get_queue_stats_tx(struct net_device *dev, int idx,\n> +\t\t\t\t struct netdev_queue_stats_tx *tx) {\n\n...\n\n> \tnetdev->netdev_ops = &i40e_netdev_ops;\n> \tnetdev->watchdog_timeo = 5 * HZ;\n> \ti40e_set_ethtool_ops(netdev);\n> --\n> 2.53.0","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=IjZFig3G;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=140.211.166.137; helo=smtp4.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4frMJw5d9kz1xy1\n\tfor ; Wed, 08 Apr 2026 22:08:00 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id C631440E95;\n\tWed, 8 Apr 2026 12:07:58 +0000 (UTC)","from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id uKRvHKONIgxt; Wed, 8 Apr 2026 12:07:58 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id 0FEC740DBE;\n\tWed, 8 Apr 2026 12:07:58 +0000 (UTC)","from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n by lists1.osuosl.org (Postfix) with ESMTP id C653A237\n for ; Wed, 8 Apr 2026 12:07:56 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp4.osuosl.org (Postfix) with ESMTP id B061940DBE\n for ; Wed, 8 Apr 2026 12:07:56 +0000 (UTC)","from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id iaxtePbkynRn for ;\n Wed, 8 Apr 2026 12:07:56 +0000 (UTC)","from mgamail.intel.com (mgamail.intel.com [198.175.65.13])\n by smtp4.osuosl.org (Postfix) with ESMTPS id C844D40D83\n for ; Wed, 8 Apr 2026 12:07:55 +0000 (UTC)","from fmviesa006.fm.intel.com ([10.60.135.146])\n by orvoesa105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 08 Apr 2026 05:07:55 -0700","from orsmsx903.amr.corp.intel.com ([10.22.229.25])\n by fmviesa006.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 08 Apr 2026 05:07:54 -0700","from ORSMSX901.amr.corp.intel.com (10.22.229.23) by\n ORSMSX903.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.2562.37; Wed, 8 Apr 2026 05:07:53 -0700","from ORSEDG903.ED.cps.intel.com (10.7.248.13) by\n ORSMSX901.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.2562.37 via Frontend Transport; Wed, 8 Apr 2026 05:07:53 -0700","from SA9PR02CU001.outbound.protection.outlook.com (40.93.196.0) by\n edgegateway.intel.com (134.134.137.113) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.2562.37; Wed, 8 Apr 2026 05:07:52 -0700","from IA3PR11MB8986.namprd11.prod.outlook.com (2603:10b6:208:577::21)\n by CY8PR11MB7780.namprd11.prod.outlook.com (2603:10b6:930:78::18)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9769.20; Wed, 8 Apr\n 2026 12:07:49 +0000","from IA3PR11MB8986.namprd11.prod.outlook.com\n ([fe80::e6f0:6afb:6ef9:ab5c]) by IA3PR11MB8986.namprd11.prod.outlook.com\n ([fe80::e6f0:6afb:6ef9:ab5c%5]) with mapi id 15.20.9745.012; Wed, 8 Apr 2026\n 12:07:49 +0000"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp4.osuosl.org 0FEC740DBE","OpenDKIM Filter v2.11.0 smtp4.osuosl.org C844D40D83"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1775650078;\n\tbh=ft22wFgdXozzukdLeBOgnewc1wA+78TqYF8CTe3e7+k=;\n\th=From:To:CC:Date:References:In-Reply-To:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t From;\n\tb=IjZFig3GfP0fhrXYrcHwhh62kMkL87nX+sCJEZGK2X0VNuNJrxccXUzN/L9LjEdId\n\t ZU7PUg+xWORpAHw60cvIhsmkzhLqHFoQlAEEUl5W0k+ZRHUsbfrTpJhUiri2SuUE3a\n\t WZONPBoX/gJXBmLiEleUM0H9pXrsR3FkB77KBXX+by/bLcSO+3LSgvf7Xwre+BCLX1\n\t OhvmCE77vXwIbbncorDgAQFh3UXcWGzvlgGFaV0thLBC5XYksJpTvY6BDexSB+K9e1\n\t 7CagY0/qJZg58IRrEeRk4fLHV3XEbcl1fF29WE9qAriK4VMFOIKL+rbGXdyJu1+mZD\n\t rIj7H+oEbgr6g==","Received-SPF":"Pass (mailfrom) identity=mailfrom; client-ip=198.175.65.13;\n helo=mgamail.intel.com; envelope-from=aleksandr.loktionov@intel.com;\n receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp4.osuosl.org C844D40D83","X-CSE-ConnectionGUID":["Npb4MCbZR9azKVq5O/UdXQ==","8W6T6wvER5ebUNN7br95Bw=="],"X-CSE-MsgGUID":["5G83ODF9Spu6x8t6gWMmAw==","J5zjhjiNTouBaUZfOkyMlg=="],"X-IronPort-AV":["E=McAfee;i=\"6800,10657,11752\"; a=\"87706824\"","E=Sophos;i=\"6.23,167,1770624000\"; d=\"scan'208\";a=\"87706824\"","E=Sophos;i=\"6.23,167,1770624000\"; d=\"scan'208\";a=\"223691179\""],"X-ExtLoop1":"1","ARC-Seal":"i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=oMNl6K1eEs1l4oE89ZZkfDjrdZNEOGi5+17rb09sbYv09OJGhRhL5un/jJvqSmxqNxJQgSQGqbA3FbJ1tRn337d3u0kMjFtlrY05+UYe5ydHJAQDb7gU6rH8u79KiGCUxLxj55ImOSWywYQXVEV6y/jSdQcLAMG+dH4Bl1CkE+IEUNfGNldeYznFicdMNuUWTRWrZeRCeK8FiBTWGbBThGw+9pVE+FW+Yw4Qugpq7PYsKYuDa9SA3hoGECYBmuDTdzcQ2TiVKNHZpo4FCFGDos586MgGD2WghkLc2QrgHwUu8mO729kcLkcGmAeRyH1MIpmoHncrhlTs3gTualfgaQ==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=ft22wFgdXozzukdLeBOgnewc1wA+78TqYF8CTe3e7+k=;\n b=JgHBXjs12U6Esz2SbITejf7Xi91GmUQc52gPUlkX46enkil4+F0SJqML/JKUPSO9xpLxhw5xpp++BFHiIDUcWUxDNeWwlAyCW03tXWRWxM38P8rdZaL+vPcFcNn+HhwQSFGLaSulStC9zO0I2JLhJJqvjZQUPs5375cEnndbaW49s2LkiDSm1Tgb5FfZbx3eU8QsGAOxcfFCAHu+W7EwUnBHDscPS1g2+ToCFF6UlPixb8ka1tpKE6mDxJeXnlnx05kxu18AoxjPpyxPhvOeaubLq/75NpFORt+vGWdjJbuCjeJyzWKHUQ7L29U6j+eok+DzckDKLg/4oSa056rssA==","ARC-Authentication-Results":"i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;\n dkim=pass header.d=intel.com; arc=none","From":"\"Loktionov, Aleksandr\" ","To":"Paolo Abeni , \"intel-wired-lan@lists.osuosl.org\"\n ","CC":"\"Nguyen, Anthony L\" , \"Kitszel, Przemyslaw\"\n , Andrew Lunn , \"David\n S. Miller\" , Eric Dumazet , \"Jakub\n Kicinski\" , Alexei Starovoitov , \"Daniel\n Borkmann\" , Jesper Dangaard Brouer ,\n John Fastabend , Stanislav Fomichev\n , \"netdev@vger.kernel.org\" ","Thread-Topic":"[Intel-wired-lan] [PATCH iwl-next 1/2] i40e: implement basic\n per-queue stats","Thread-Index":"AQHcx00ah0K1XtZUDUCg0We5OxvIebXVEWSQ","Date":"Wed, 8 Apr 2026 12:07:49 +0000","Message-ID":"\n ","References":"\n <0815f1eb4b60faa653ea703e420395b724d05216.1775648513.git.pabeni@redhat.com>","In-Reply-To":"\n <0815f1eb4b60faa653ea703e420395b724d05216.1775648513.git.pabeni@redhat.com>","Accept-Language":"en-US","Content-Language":"en-US","X-MS-Has-Attach":"","X-MS-TNEF-Correlator":"","x-ms-publictraffictype":"Email","x-ms-traffictypediagnostic":"IA3PR11MB8986:EE_|CY8PR11MB7780:EE_","x-ms-office365-filtering-correlation-id":"b00f205d-95bf-43ea-58a6-08de95677415","x-ms-exchange-senderadcheck":"1","x-ms-exchange-antispam-relay":"0","x-microsoft-antispam":"BCL:0;\n ARA:13230040|7416014|376014|1800799024|366016|38070700021|22082099003|56012099003|18002099003;","x-microsoft-antispam-message-info":"\n vrgfttaewACZc4YoWTbYNGO9XCfN3USrqewEm52NMbHVO9kjZe3bghvqEK8i5RRHY2uRBcwI8hOf23P7b7glJTyt/1UNndQP3Pm6BB6CMC3fMTtFwW+jPDjlUBrX1VEH+vWgfJM1LP+jcDxjgIYal0Mh3zhPjIW44x9oYMT1CP8zohKMeHzkY8+qd8gGXgnKTc+eKko5gMcHDwkIODc1ATwomuy+QeluPf+Vqx5dkJQBmhDeXClp0W5e+v/4VL5lHvq92RykAWdU3ayivyUAYn5DI2656k/UPCt+SoNhg64HV/7EyF/Z3kpFF6DGpvr3ug8RhW3NIJlVXcDbyq/0qAjOD+TgCTAaNklLpbcV+K/X/kRWglFe7I3luZQ+okiCJf0++aNfjHTdo9LM+mNmXskmOTaNidukLDpkuL6+ZNUqnI+4K4K93ifWwSO+P2zahTpT16dc53jjewWCd9nIikSSRNg74ifUXyo/87kCdNy4RBxaf92Tp8I0xJJwayvNWSuZYY7Yvuqcb/08MPhdVOFP12SjZXb3deIxytARUuSuW0XaDI9w8LwWEL3ghM4G8JHBtxVwomo8zwhzWWRNPysSTIFIDonzjpONJD/j8YuLi/2KOCCqQKnhnaVRwyVy/ZnMrxhp+7k1yTscBpGt4r3MhDB0w2Rqfwwp7LlNIu/BAobr4JRsqSeurrEtXq7hrKliuXpBiW7sAbH0uFxeIo6h4zwZtVboLJB1KsEAh5LAOrNTZr+OPNfMsXhrQeg/j73yVUq/YMskzUFzpkx4pcLcmi3WccVpQPWHAIaXROs=","x-forefront-antispam-report":"CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:IA3PR11MB8986.namprd11.prod.outlook.com; PTR:; CAT:NONE;\n SFS:(13230040)(7416014)(376014)(1800799024)(366016)(38070700021)(22082099003)(56012099003)(18002099003);\n DIR:OUT; SFP:1101;","x-ms-exchange-antispam-messagedata-chunkcount":"1","x-ms-exchange-antispam-messagedata-0":"\n RLOaJT3LUdf3BuWuOyVogL62FDk46n9VYrcM84V4pXfkT6r6pf39X26sTQdWpJmoU0dkSmaJR3NggpD2HThwL//EEo2NpQH9wyfPoBwzszt5r5lFUMVzWSo/5Nmw+zIunjOtnpKY+iNakRLLJwb4k/Oj+Y33pwIQlTacvotoV80MbHxUCO6BbprOYUhW3oedX8aL0zkIUZ+az4ptVczyn0Y1R+U7lJmO2w5Fv08dMfCRIBxYB+zQtaGDPjFngVfqJkJkZGEOg8WBSdWHn2yfazDGWJj2h8u3OP4CIl+w2VcyYURr+erWxrkb33EGJ/Fw/qslO2AYHzs2pHd17ZelszuHpww90cIP8fPPlfNNWw0jnc/If3zsBcYPV71wycjVyQNpTCpbPR87QV3TlOzvSIX6rEkD1tFEyxF/fpbEIfR0fFFxNyp3ZU+S1c1JTPmmMjuAh8OWNzWKX7GOTWXG7gwbrD1hD/9/nKquHk1j+9f850bvGbT+ceG23P+St6AJEfpRQKolypKBkaVUTp+hKQ0aOsDk3N8sepqr3osH0EMnfbDKgulsLAdn1kmihHRE0qYJSjPqPfyUsB5LUWmbXwOa/idr7pALdnS9tjpv6fjPSpmujHON/L4QP43F6g5nHNG2uhgOLy5EdX4K0FxcyaIkuipmLHUSX1J6fGkHW5I/rCJhSp6wtXkuTwuqF76Y+8EBO84Vl0Dhu9EUOZN1dJt2DlyR68K/UsC/efGQelQxOVsebRSkzS+TDqDHxyvJLTXwwbALVrlcLELJHwTA1Z4KaSgfd4ZngxY7g7nURxXbyIN6p6hBcy4Uv34IyAbTzeeFd3Fn7DGcVj+zZ8fQ32DKnU9keGPIfwZow307Tkng/338MX+4050wag6FS1EQLsd57sl+i547Qi1pUMbbtYY2s0Kc1B+SodJPWtOkO0gWUeGhXBkW5Xf1Mjm8Ii0E/fiHbmG7UzXS2wcx/3hizyMZYBnbfpymtbDFyt3NwpIqTl58hldISF2+Q0YzIqRlTtdLIpvynq9J/X9v/Jr14+LiKzxHh8ZExH2Do3mmnFGHCHe3vNT/Aue+g8aCpTO9VFhxQrWMjmtuZc/7warPj0x23P2WiV+vHoexAM3oclz4h5eY7P4e/FTgBFTA9zE7esMPVHXSqQeRo7kUqOpw20xnGoWrFzDbH36Ic0cVpfzC1WoA7b6V1PBYufc27O3FGEdGGLcMoBycPq5zOf2RnqrnNfJU6q4FsDD84bD682XteoKsvZdhdGXZinD0Do/2HoX880eq6jlRNGPRflVDzfDGHHydJ1JLWCvPbt4KcnSeAgFdzi8FVbrnhg0SKuPc+TzOstY8P0FEqgScLTeZDzdnsdA8CdsFXMcTSesWHLJ9ZzKH0G8HHkrgojNUrQ5V09SP2ie4vGlO9ndcKKcnPsvvjlsMTIALoHbIFd3rKYUINtvFsy/vP/1zHCSM0fxu2Dq9h7f59bNtOr2W6wIl5lGesBHpCqetwe2KPhc+jwgMC5UJJ/tApGJyp1R1+VPbStQ0CXsnJldD5HHSn1JZmZUO9/1ACPz9p4OETihoM0QbHNsYYrR7dpOwN26A+PpURKCcVhOEHx+QPKr1HRomBj8L8mtcWn+t43IYdrDsrNyZ5jZkG0/YpKyB9Til7kMhTQ/qnVXYJu1dpgBX80kK94vLezJJcBXcpAHNtahLqSWZFMtfsiWGYaHIn6oyVkfENCmi2N/KcscUDZwZosh+Mmk5P0CAGFnI6ZM58JhgSAI=","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"quoted-printable","MIME-Version":"1.0","X-Exchange-RoutingPolicyChecked":"\n EYr66Z/S62GPL2WiX0Qw0IkVUM3cR2qlRIWNiCvXaRiLUcMjQJrCWgn+bX5DPbyOdnsDJfOtTcdYKJGSnmcmzpYBW1/pWlLrUXjTx+MARXP6Zd0Kkqush6CuSdcqOUj9iHFm59n1GuK/9dnJqcvGs7SK9r8J5fFjolO16xd8hSqA7TRUsN8nPJ+i0BiGAxZJYr1C9SRDV/JYsDkGpLA/n+PpdVRuuPH6cb4iRIY34dfrJ2TKtbTk1BXv1cPJBMZ1vnlQ/rRrVuQyl62KSm4SUDdbWjxQyFFZbr00lXAQKABVQTeHmMIQhNc6ARBjZMhChBQ2dmII4bRFvmfBTARTTA==","X-MS-Exchange-CrossTenant-AuthAs":"Internal","X-MS-Exchange-CrossTenant-AuthSource":"IA3PR11MB8986.namprd11.prod.outlook.com","X-MS-Exchange-CrossTenant-Network-Message-Id":"\n b00f205d-95bf-43ea-58a6-08de95677415","X-MS-Exchange-CrossTenant-originalarrivaltime":"08 Apr 2026 12:07:49.4600 (UTC)","X-MS-Exchange-CrossTenant-fromentityheader":"Hosted","X-MS-Exchange-CrossTenant-id":"46c98d88-e344-4ed4-8496-4ed7712e255d","X-MS-Exchange-CrossTenant-mailboxtype":"HOSTED","X-MS-Exchange-CrossTenant-userprincipalname":"\n doBT9QPSY4IX0DLLfxUBAr/1AwFzjKxsi/Ud7J8YI/cz0B1BAMU9M3o7DMEJNHSXmLrWR+0hKMeOVglYBvQe/lnmm/27QdxyY4KgmuyBkJk=","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"CY8PR11MB7780","X-OriginatorOrg":"intel.com","X-Mailman-Original-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1775650076; x=1807186076;\n h=from:to:cc:subject:date:message-id:references:\n in-reply-to:content-transfer-encoding:mime-version;\n bh=t6vfCbQ9SNJquZ82fhUpWQV8cAHSmxf9mjTqUU5TSRQ=;\n b=hY0EVLGSlbxig36SAQFsfMHI6eL1zB0JnbrkZOgYMhVnT0t/C8hou2DV\n M44x98+gxguKaLDWeyftmQO2oqSd4Qc4tiDlGVy1Ci0slUJswChMzL90A\n 2/D14ayaF0n7HhMCYM/wBeLNGdw6R2q7b+8Lv4wOmvQACu1aUE/CcMnoh\n I4xWJztBZNraeDFFytjrrRcEucQUGcX1ceR9g3cOiAXjzWJgYxyKGb423\n N5HhcrPwZLj7zWk1EPCt+wk1A1gKWAlPTZervxgTPa5LTpprNgbsz6oXU\n X9J3USq8BDufNuV0f4ywBoQehd4yw+FLIeYm2xbwv11y+s2Mf/Ru9pIyt\n g==;","X-Mailman-Original-Authentication-Results":["smtp4.osuosl.org;\n dmarc=pass (p=none dis=none)\n header.from=intel.com","smtp4.osuosl.org;\n dkim=pass (2048-bit key,\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=hY0EVLGS","dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=intel.com;"],"Subject":"Re: [Intel-wired-lan] [PATCH iwl-next 1/2] i40e: implement basic\n per-queue stats","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "}},{"id":3674812,"web_url":"http://patchwork.ozlabs.org/comment/3674812/","msgid":"<2bae0dc2-4035-4fe2-a87e-dc5dae6c7df5@redhat.com>","list_archive_url":null,"date":"2026-04-08T14:44:11","subject":"Re: [Intel-wired-lan] [PATCH iwl-next 1/2] i40e: implement basic\n per-queue stats","submitter":{"id":67312,"url":"http://patchwork.ozlabs.org/api/people/67312/","name":"Paolo Abeni","email":"pabeni@redhat.com"},"content":"On 4/8/26 2:07 PM, Loktionov, Aleksandr wrote:\n>> -----Original Message-----\n>> From: Intel-wired-lan On Behalf\n>> Of Paolo Abeni\n>> Sent: Wednesday, April 8, 2026 1:44 PM\n>> To: intel-wired-lan@lists.osuosl.org\n>> Cc: Nguyen, Anthony L ; Kitszel,\n>> Przemyslaw ; Andrew Lunn\n>> ; David S. Miller ; Eric\n>> Dumazet ; Jakub Kicinski ;\n>> Alexei Starovoitov ; Daniel Borkmann\n>> ; Jesper Dangaard Brouer ; John\n>> Fastabend ; Stanislav Fomichev\n>> ; netdev@vger.kernel.org\n>> Subject: [Intel-wired-lan] [PATCH iwl-next 1/2] i40e: implement basic\n>> per-queue stats\n>>\n>> Only expose the counters currently available (bytes, packets); add\n>> account for base stats to deal with ring clear.\n>>\n>> Signed-off-by: Paolo Abeni \n>> ---\n>> drivers/net/ethernet/intel/i40e/i40e.h | 7 ++\n>> drivers/net/ethernet/intel/i40e/i40e_main.c | 133\n>> ++++++++++++++++++++\n>> 2 files changed, 140 insertions(+)\n>>\n>> diff --git a/drivers/net/ethernet/intel/i40e/i40e.h\n>> b/drivers/net/ethernet/intel/i40e/i40e.h\n>> index dcb50c2e1aa2..fe642c464e9c 100644\n>> --- a/drivers/net/ethernet/intel/i40e/i40e.h\n>> +++ b/drivers/net/ethernet/intel/i40e/i40e.h\n>> @@ -836,16 +836,23 @@ struct i40e_vsi {\n>> \tstruct i40e_eth_stats eth_stats;\n>> \tstruct i40e_eth_stats eth_stats_offsets;\n>> \tu64 tx_restart;\n> \n> ...\n> \n>> +static void i40e_zero_tx_ring_stats(struct netdev_queue_stats_tx *tx)\n>> {\n>> +\ttx->bytes = 0;\n>> +\ttx->packets = 0;\n>> +\ttx->stop = 0;\n>> +\ttx->wake = 0;\n>> +\ttx->hw_drops = 0;\n>> +}\n>> +\n>> +static void i40e_add_tx_ring_stats(struct i40e_ring *tx_ring,\n>> +\t\t\t\t struct netdev_queue_stats_tx *tx) {\n>> +\tu64 bytes, packets;\n>> +\tunsigned int start;\n>> +\n>> +\tdo {\n>> +\t\tstart = u64_stats_fetch_begin(&tx_ring->syncp);\n>> +\t\tbytes = tx_ring->stats.bytes;\n>> +\t\tpackets = tx_ring->stats.packets;\n>> +\t} while (u64_stats_fetch_retry(&tx_ring->syncp, start));\n>> +\n>> +\ttx->bytes += bytes;\n>> +\ttx->packets += packets;\n>> +\n>> +\ttx->stop += tx_ring->tx_stats.tx_stopped;\n>> +\ttx->wake += tx_ring->tx_stats.restart_queue;\n>> +\ttx->hw_drops += tx_ring->tx_stats.tx_busy; }\n> Why the reads are outside the seqlock region? \n> On 32-bit kernels, unprotected u64 reads can tear IMHO\n\nCurrently there is no seqlock on the write side; to keep the series\nsmall I preferred avoid fixing the pre-existing issue. In any case I\nthink moving stop, wake, hw_drops (and others) under seqlock protection\nis an orthogonal change.\n\n/P","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=3Ztba7Mu;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::137; helo=smtp4.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4frQnP0gMQz1xv0\n\tfor ; Thu, 09 Apr 2026 00:44:25 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id 616C440F3A;\n\tWed, 8 Apr 2026 14:44:23 +0000 (UTC)","from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id rScMGuWYv2D5; Wed, 8 Apr 2026 14:44:22 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id 1025140E21;\n\tWed, 8 Apr 2026 14:44:22 +0000 (UTC)","from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n by lists1.osuosl.org (Postfix) with ESMTP id DF0451F6\n for ; Wed, 8 Apr 2026 14:44:20 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp1.osuosl.org (Postfix) with ESMTP id C50AC82238\n for ; Wed, 8 Apr 2026 14:44:20 +0000 (UTC)","from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id 9lFuHYdGQYAp for ;\n Wed, 8 Apr 2026 14:44:20 +0000 (UTC)","from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.129.124])\n by smtp1.osuosl.org (Postfix) with ESMTPS id B581082486\n for ; Wed, 8 Apr 2026 14:44:19 +0000 (UTC)","from mail-wr1-f70.google.com (mail-wr1-f70.google.com\n [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-599-bGI4YazvPj-7TKN8dBjCDw-1; Wed, 08 Apr 2026 10:44:15 -0400","by mail-wr1-f70.google.com with SMTP id\n ffacd0b85a97d-43d1bfbd219so5016867f8f.0\n for ; Wed, 08 Apr 2026 07:44:15 -0700 (PDT)","from [192.168.88.32] ([212.105.153.231])\n by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-43d1e2a7223sm55239228f8f.5.2026.04.08.07.44.12\n (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n Wed, 08 Apr 2026 07:44:13 -0700 (PDT)"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp4.osuosl.org 1025140E21","OpenDKIM Filter v2.11.0 smtp1.osuosl.org B581082486"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1775659462;\n\tbh=pezfrKC7eYGJMuBaqOOteFy8MQajQLtYRWeC0Y5aebs=;\n\th=Date:To:Cc:References:From:In-Reply-To:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t From;\n\tb=3Ztba7MulRE0OAmwDQHBUmfIU/oN7CdbTz5kY8FFX5UFGINQSPwvDFaoPcGNf3/yW\n\t QFpTrFrD0pslLk9pnuL1HcExDE0ihgTwzvlqB055vsviD//eUMH1ahRRu2JeJgTEdP\n\t v0m+0JsxsI1c4CZ05Wfi4VfX5y6J95utQJB2xgsAdsT2g4QFTzzZF2fVw/a2rBHl2r\n\t vhe55K5QQuRm3yjASDuueQilb+QlUlSPSb21SvUhvaCWarw90ESSoDdIuebVk+SjqU\n\t Qs/DwzT9uM3TwB4d2WryB6NIg1E6qkZzcKeEiMN3A3ZJ225RYx/mBoX7gPTofsIOPM\n\t aSSurJXmMYgnQ==","Received-SPF":"Pass (mailfrom) identity=mailfrom; client-ip=170.10.129.124;\n helo=us-smtp-delivery-124.mimecast.com; envelope-from=pabeni@redhat.com;\n receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp1.osuosl.org B581082486","X-MC-Unique":"bGI4YazvPj-7TKN8dBjCDw-1","X-Mimecast-MFC-AGG-ID":"bGI4YazvPj-7TKN8dBjCDw_1775659455","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1775659455; x=1776264255;\n h=content-transfer-encoding:in-reply-to:from:content-language\n :references:cc:to:subject:user-agent:mime-version:date:message-id\n :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=pezfrKC7eYGJMuBaqOOteFy8MQajQLtYRWeC0Y5aebs=;\n b=cGN2prqOk5D+tq33hAVxbzeyNfrPpp/ayuTo8fYTVP9VCCaKbziYPpRZjYXDKndIQm\n DUVrUy3mQcI/Mrd9qyZEwwJBzHxWT3XE5dBpqrIe0FKDuMCGVZ9ctMh8ajDnZaomhsF/\n pPAc/zsKdF3oyKcQu1Pd3U1PJp9FATrxdPH2CGgZvrYbVWB7+e6mkw2V4baS9z+ZdBFT\n 0F3FpFSte7dpP6SClM4Lto+FP3F0nAZ6la/pq4j50UD4bMOeqj+Rd5A4F5Gf4rC83jjw\n i8dPA/si4To9nxqjiEejZrMpCmuHUoJfFZboeH5LhIBLS9VVorQ52NCCiy3GOlMedIYt\n CoEw==","X-Forwarded-Encrypted":"i=1;\n AJvYcCXg7z/Ijv7TudTPbf/rcInmPXCvTPoRQp7pARuERf8OgFurUY/HPLQdKcNkGgCq7y7GHFjkTmJj6Z8eQcQ0xwg=@lists.osuosl.org","X-Gm-Message-State":"AOJu0YxUusAQkjhrAeZqvODkJSII+WrbW+ETgj2t7PgC0uaGyaYS1O2j\n ZImpbaN4/kDWh3dsnDfShQViKNm6L4jZg6xXEAbOMHuABkRy27BEBIPZVrho/X/SBttduYqoyaS\n 86IlEpU4zQWI5AViIkUt7R60ydmXrGUAuJcA3bjiqxt9RQXB3dGUEr/bjO7zrjVQuGDTtHwU=","X-Gm-Gg":"AeBDietvoWxbXV31qzbQnE0oWLCf5yA9LNRXm8V7pWwvluqKh1AwlYemI4Zv/iiV3Io\n hCI4wp2CTN9eacWPYwQMwYbuyjoBc4NJCNYPCjgO3uaFObEY35J3imAJIE7Nt10bhb5Y96d9sYW\n YGS3jcSawheBoTGrHh9cJze+j0cIg8XXiAfS8q+9oZRt6MZoZ854rfygEOSY0rfXdR8sorzYzD5\n 2/C/EdMOrbeIb4laovkNNWQDjGqvWN1Ml9YMbB7yaCWVEdjNP7UGHRy716liiJUq+KqFRGkHjnY\n 57CuRtd4LWAZpsPy+rfS9QE0l5fP3B1BjqKSa/679jbZCwqgIAZ2g/3tjyLkkz7flWFOzbgriSD\n 6fmKnvmQqHzgrqUb/4Bes2fE6+VQTNZgqngaPL+PCtplRXDp1/0R1B7gExg==","X-Received":["by 2002:a5d:64e4:0:b0:43b:8fa4:194d with SMTP id\n ffacd0b85a97d-43d292855famr30342523f8f.6.1775659454565;\n Wed, 08 Apr 2026 07:44:14 -0700 (PDT)","by 2002:a5d:64e4:0:b0:43b:8fa4:194d with SMTP id\n ffacd0b85a97d-43d292855famr30342478f8f.6.1775659453959;\n Wed, 08 Apr 2026 07:44:13 -0700 (PDT)"],"Message-ID":"<2bae0dc2-4035-4fe2-a87e-dc5dae6c7df5@redhat.com>","Date":"Wed, 8 Apr 2026 16:44:11 +0200","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","To":"\"Loktionov, Aleksandr\" ,\n \"intel-wired-lan@lists.osuosl.org\" ","Cc":"\"Nguyen, Anthony L\" ,\n \"Kitszel, Przemyslaw\" ,\n Andrew Lunn , \"David S. Miller\"\n , Eric Dumazet ,\n Jakub Kicinski , Alexei Starovoitov ,\n Daniel Borkmann ,\n Jesper Dangaard Brouer ,\n John Fastabend ,\n Stanislav Fomichev ,\n \"netdev@vger.kernel.org\" ","References":"\n <0815f1eb4b60faa653ea703e420395b724d05216.1775648513.git.pabeni@redhat.com>\n ","From":"Paolo Abeni ","In-Reply-To":"\n ","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"yn6kLBnmnT5qMzKbP8XyZBRG9kCdr5gRugwEuZp5krw_1775659455","X-Mimecast-Originator":"redhat.com","Content-Language":"en-US","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"7bit","X-Mailman-Original-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=redhat.com;\n s=mimecast20190719; t=1775659458;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=pezfrKC7eYGJMuBaqOOteFy8MQajQLtYRWeC0Y5aebs=;\n b=apP1WAvtLZcmzr66ubZhS4undbd7I8FUATRf7mEhBy/Ii6/EFD+sqlGOQA0tECMFLOjOVK\n blQBqY5EPTX4/APEI/CuTtcVHY+TDMIfHxHgd07R8JhiwkVl3EFA5ZvKX9jT3hm+lrjJP0\n 6YuJ67DqItvRsmMxOm3/XOH4FeYuKo4=","X-Mailman-Original-Authentication-Results":["smtp1.osuosl.org;\n dmarc=pass (p=quarantine dis=none)\n header.from=redhat.com","smtp1.osuosl.org;\n dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com\n header.a=rsa-sha256 header.s=mimecast20190719 header.b=apP1WAvt"],"Subject":"Re: [Intel-wired-lan] [PATCH iwl-next 1/2] i40e: implement basic\n per-queue stats","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "}},{"id":3675032,"web_url":"http://patchwork.ozlabs.org/comment/3675032/","msgid":"<20260408174504.17210f78@kernel.org>","list_archive_url":null,"date":"2026-04-09T00:45:04","subject":"Re: [Intel-wired-lan] [PATCH iwl-next 1/2] i40e: implement basic\n per-queue stats","submitter":{"id":77159,"url":"http://patchwork.ozlabs.org/api/people/77159/","name":"Jakub Kicinski","email":"kuba@kernel.org"},"content":"On Wed, 8 Apr 2026 13:43:45 +0200 Paolo Abeni wrote:\n> +static void i40e_get_queue_stats_tx(struct net_device *dev, int idx,\n> +\t\t\t\t struct netdev_queue_stats_tx *tx)\n> +{\n> +\tstruct i40e_netdev_priv *np = netdev_priv(dev);\n> +\tstruct i40e_vsi *vsi = np->vsi;\n> +\tstruct i40e_ring *tx_ring;\n> +\n> +\trcu_read_lock();\n> +\ttx_ring = READ_ONCE(vsi->tx_rings[idx]);\n> +\tif (!tx_ring)\n> +\t\tgoto out;\n> +\n> +\ti40e_zero_tx_ring_stats(tx);\n> +\ti40e_add_tx_ring_stats(tx_ring, tx);\n> +\n> +\tif (i40e_enabled_xdp_vsi(vsi)) {\n> +\t\ttx_ring = READ_ONCE(vsi->xdp_rings[idx]);\n> +\t\tif (tx_ring)\n> +\t\t\ti40e_add_tx_ring_stats(tx_ring, tx);\n\nIf XDP Tx happens on dedicated queues it should be added to base,\nnot to the stats of the \"stack\" queue. This is in anticipation of\nXDP being its own queue type one day, we'll then isolate those\nout of base. Ripping the out of TX could cause regressions.\n\n> +\t}\n> +\n> +out:\n> +\trcu_read_unlock();\n> +}\n> +\n> +static void i40e_get_base_stats(struct net_device *dev,\n> +\t\t\t\tstruct netdev_queue_stats_rx *rx,\n> +\t\t\t\tstruct netdev_queue_stats_tx *tx)\n> +{\n> +\tstruct i40e_netdev_priv *np = netdev_priv(dev);\n> +\tstruct i40e_vsi *vsi = np->vsi;\n> +\n> +\ttx->bytes = vsi->tx_bytes;\n> +\ttx->packets = vsi->tx_packets;\n> +\ttx->wake = vsi->tx_restart_base;\n> +\ttx->stop = vsi->tx_stopped_base;\n> +\ttx->hw_drops = vsi->tx_busy_base;\n> +\n> +\trx->bytes = vsi->rx_bytes;\n> +\trx->packets = vsi->rx_packets;\n> +}","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=D1E/7j1C;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=2605:bc80:3010::137; helo=smtp4.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4frh6b1klBz1xtJ\n\tfor ; Thu, 09 Apr 2026 10:45:11 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id 603DC406F0;\n\tThu, 9 Apr 2026 00:45:09 +0000 (UTC)","from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id ooLjUb4mjzCG; Thu, 9 Apr 2026 00:45:08 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id CDDE64070F;\n\tThu, 9 Apr 2026 00:45:08 +0000 (UTC)","from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n by lists1.osuosl.org (Postfix) with ESMTP id 2A0F62C7\n for ; Thu, 9 Apr 2026 00:45:07 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp4.osuosl.org (Postfix) with ESMTP id 1BF92406F0\n for ; Thu, 9 Apr 2026 00:45:07 +0000 (UTC)","from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id ehfLo37FSqDF for ;\n Thu, 9 Apr 2026 00:45:06 +0000 (UTC)","from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31])\n by smtp4.osuosl.org (Postfix) with ESMTPS id 7D0504064E\n for ; Thu, 9 Apr 2026 00:45:06 +0000 (UTC)","from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58])\n by sea.source.kernel.org (Postfix) with ESMTP id 98269444C0;\n Thu, 9 Apr 2026 00:45:05 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id E7781C19421;\n Thu, 9 Apr 2026 00:45:04 +0000 (UTC)"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp4.osuosl.org CDDE64070F","OpenDKIM Filter v2.11.0 smtp4.osuosl.org 7D0504064E"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1775695508;\n\tbh=fh2RT04a1qE4AdjGEhrjiAI4NtAoE435wHmxjKkMiWM=;\n\th=Date:From:To:Cc:In-Reply-To:References:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t From;\n\tb=D1E/7j1C9A563933Xe6uduL/ZL8j+S+da1OoGH/VHV7ChqN5xZRVknbvcqf2TzX3n\n\t UQFee4euIqLX4ION5ZlSzt4KX/ha1Sa4Ra7pun8CtBuYKqg1O9Y/8AEA2vsBOyd92H\n\t NmAITZLOhm49aAq8IId2RvCReSJmUDDrjCydeDKy/r198hd002qRDHKKPpDqSI+Orx\n\t oJBeXUI4vctRj97khFfKNgF4mFxnt0bv41NTTw8bp1LWe26zyv3LVR3UJATOpYwtK7\n\t So9LOKnh1WSx6QvGtJUNe8YbxOgtU6GlGXvxLboeu/MeM7vnZX+DJiYhaeMGJWMDLb\n\t CaRzZsTBH3/ww==","Received-SPF":"Pass (mailfrom) identity=mailfrom; client-ip=172.234.252.31;\n helo=sea.source.kernel.org; envelope-from=kuba@kernel.org;\n receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp4.osuosl.org 7D0504064E","Date":"Wed, 8 Apr 2026 17:45:04 -0700","From":"Jakub Kicinski ","To":"Paolo Abeni ","Cc":"intel-wired-lan@lists.osuosl.org, Tony Nguyen\n , Przemek Kitszel\n , Andrew Lunn , \"David\n S. Miller\" , Eric Dumazet ,\n Alexei Starovoitov , Daniel Borkmann\n , Jesper Dangaard Brouer , John\n Fastabend , Stanislav Fomichev ,\n netdev@vger.kernel.org","Message-ID":"<20260408174504.17210f78@kernel.org>","In-Reply-To":"\n <0815f1eb4b60faa653ea703e420395b724d05216.1775648513.git.pabeni@redhat.com>","References":"\n <0815f1eb4b60faa653ea703e420395b724d05216.1775648513.git.pabeni@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=US-ASCII","Content-Transfer-Encoding":"7bit","X-Mailman-Original-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n d=kernel.org; s=k20201202; t=1775695505;\n bh=yKPYnKdH6B2V81W24pAJpsyTt+fFkWrquiwbGfT6igE=;\n h=Date:From:To:Cc:Subject:In-Reply-To:References:From;\n b=hMAMHib3bR4GWd9vMtRvPlmGJZmi1vzYPXO8sa7qzqs9ZxnCx7gaZVqftnQTbllZn\n 6cFlCVWSIaYW5NEn+YWcEwL1fcg85Ye7lK6ByD+th7IfRm+Ap8r/PP8JaF7T7wCyJ3\n SUk56fPyMEu7QXxe69UPAaaE5zpvc5k0Sgitx8KYo+SoYdZC8bXQGyAdZ5JIX2H6Yb\n +z9MU8X/8v/cjXNMaM/pAWKx6bgtFBhRPHafUA9EzZZRL2cCzWilXH1c8iEtQY3V29\n 4rByjybIrhD/afsXGg/iSgIys8Y2UuvI7ykZ67qX7MjpUChsFVEGq5V+M1czy5N7WI\n aRCpSBK/6UDCw==","X-Mailman-Original-Authentication-Results":["smtp4.osuosl.org;\n dmarc=pass (p=quarantine dis=none)\n header.from=kernel.org","smtp4.osuosl.org;\n dkim=pass (2048-bit key,\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=hMAMHib3"],"Subject":"Re: [Intel-wired-lan] [PATCH iwl-next 1/2] i40e: implement basic\n per-queue stats","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "}},{"id":3676997,"web_url":"http://patchwork.ozlabs.org/comment/3676997/","msgid":"<7f5bb0a1-90f2-44e7-be93-7a2fd4f58dc2@intel.com>","list_archive_url":null,"date":"2026-04-14T01:22:51","subject":"Re: [Intel-wired-lan] [PATCH iwl-next 1/2] i40e: implement basic\n per-queue stats","submitter":{"id":9784,"url":"http://patchwork.ozlabs.org/api/people/9784/","name":"Jacob Keller","email":"jacob.e.keller@intel.com"},"content":"On 4/8/2026 7:44 AM, Paolo Abeni wrote:\n> On 4/8/26 2:07 PM, Loktionov, Aleksandr wrote:\n>>> -----Original Message-----\n>>> From: Intel-wired-lan On Behalf\n>>> Of Paolo Abeni\n>>> Sent: Wednesday, April 8, 2026 1:44 PM\n>>> To: intel-wired-lan@lists.osuosl.org\n>>> Cc: Nguyen, Anthony L ; Kitszel,\n>>> Przemyslaw ; Andrew Lunn\n>>> ; David S. Miller ; Eric\n>>> Dumazet ; Jakub Kicinski ;\n>>> Alexei Starovoitov ; Daniel Borkmann\n>>> ; Jesper Dangaard Brouer ; John\n>>> Fastabend ; Stanislav Fomichev\n>>> ; netdev@vger.kernel.org\n>>> Subject: [Intel-wired-lan] [PATCH iwl-next 1/2] i40e: implement basic\n>>> per-queue stats\n>>>\n>>> Only expose the counters currently available (bytes, packets); add\n>>> account for base stats to deal with ring clear.\n>>>\n>>> Signed-off-by: Paolo Abeni \n>>> ---\n>>> drivers/net/ethernet/intel/i40e/i40e.h | 7 ++\n>>> drivers/net/ethernet/intel/i40e/i40e_main.c | 133\n>>> ++++++++++++++++++++\n>>> 2 files changed, 140 insertions(+)\n>>>\n>>> diff --git a/drivers/net/ethernet/intel/i40e/i40e.h\n>>> b/drivers/net/ethernet/intel/i40e/i40e.h\n>>> index dcb50c2e1aa2..fe642c464e9c 100644\n>>> --- a/drivers/net/ethernet/intel/i40e/i40e.h\n>>> +++ b/drivers/net/ethernet/intel/i40e/i40e.h\n>>> @@ -836,16 +836,23 @@ struct i40e_vsi {\n>>> \tstruct i40e_eth_stats eth_stats;\n>>> \tstruct i40e_eth_stats eth_stats_offsets;\n>>> \tu64 tx_restart;\n>>\n>> ...\n>>\n>>> +static void i40e_zero_tx_ring_stats(struct netdev_queue_stats_tx *tx)\n>>> {\n>>> +\ttx->bytes = 0;\n>>> +\ttx->packets = 0;\n>>> +\ttx->stop = 0;\n>>> +\ttx->wake = 0;\n>>> +\ttx->hw_drops = 0;\n>>> +}\n>>> +\n>>> +static void i40e_add_tx_ring_stats(struct i40e_ring *tx_ring,\n>>> +\t\t\t\t struct netdev_queue_stats_tx *tx) {\n>>> +\tu64 bytes, packets;\n>>> +\tunsigned int start;\n>>> +\n>>> +\tdo {\n>>> +\t\tstart = u64_stats_fetch_begin(&tx_ring->syncp);\n>>> +\t\tbytes = tx_ring->stats.bytes;\n>>> +\t\tpackets = tx_ring->stats.packets;\n>>> +\t} while (u64_stats_fetch_retry(&tx_ring->syncp, start));\n>>> +\n>>> +\ttx->bytes += bytes;\n>>> +\ttx->packets += packets;\n>>> +\n>>> +\ttx->stop += tx_ring->tx_stats.tx_stopped;\n>>> +\ttx->wake += tx_ring->tx_stats.restart_queue;\n>>> +\ttx->hw_drops += tx_ring->tx_stats.tx_busy; }\n>> Why the reads are outside the seqlock region? \n>> On 32-bit kernels, unprotected u64 reads can tear IMHO\n> \n\nPaolo is correct that just moving these into the do/while loop is\nuseless, since the increments aren't protected properly.\n\n> Currently there is no seqlock on the write side; to keep the series\n> small I preferred avoid fixing the pre-existing issue. In any case I\n> think moving stop, wake, hw_drops (and others) under seqlock protection\n> is an orthogonal change.\n> \n> /P\n\nI ended up doing some work on ice to fix a lot of similar issues a few\nmonths ago.. The intel drivers weren't using u64_stats_t, and several\nerror/debug counters were not being handled appropriately.\n\nI'd personally prefer fixing existing issues before we compound them by\nadding even more incorrect code. Even on 64bit systems we need to use\nREAD_ONCE/WRITE_ONCE or local64_t, which the u64_stats_t type uses\ninternally.\n\nI can understand the desire to limit scope of work, and the issues may\nfeel \"minor\" but ultimately I'd rather not see us continue making the\nproblem bigger instead of fixing it.\n\nHowever.. if other maintainers feel strongly that the additions are\nacceptable despite being incorrect w.r.t. the stats logic, I suppose we\ncan continue this and have someone from Intel look into cleaning up the\nmess like I did for ice.\n\nIt looks like the series has some other requested changes either way though.","headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=W3I1Srb5;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=140.211.166.138; helo=smtp1.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4fvmk60Jpnz1y2d\n\tfor ; Tue, 14 Apr 2026 11:23:09 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id 53666848CE;\n\tTue, 14 Apr 2026 01:23:07 +0000 (UTC)","from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id 7s5eN6FAqOw9; Tue, 14 Apr 2026 01:23:05 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id B7BA0848CD;\n\tTue, 14 Apr 2026 01:23:05 +0000 (UTC)","from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137])\n by lists1.osuosl.org (Postfix) with ESMTP id 98E95283\n for ; Tue, 14 Apr 2026 01:23:03 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp4.osuosl.org (Postfix) with ESMTP id 8AEAE42827\n for ; Tue, 14 Apr 2026 01:23:03 +0000 (UTC)","from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id osSCnFdv6CKL for ;\n Tue, 14 Apr 2026 01:23:02 +0000 (UTC)","from mgamail.intel.com (mgamail.intel.com [198.175.65.18])\n by smtp4.osuosl.org (Postfix) with ESMTPS id 9D52B42826\n for ; Tue, 14 Apr 2026 01:23:01 +0000 (UTC)","from orviesa009.jf.intel.com ([10.64.159.149])\n by orvoesa110.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 13 Apr 2026 18:23:00 -0700","from fmsmsx901.amr.corp.intel.com ([10.18.126.90])\n by orviesa009.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 13 Apr 2026 18:23:00 -0700","from FMSMSX903.amr.corp.intel.com (10.18.126.92) by\n fmsmsx901.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.2562.37; Mon, 13 Apr 2026 18:22:59 -0700","from fmsedg902.ED.cps.intel.com (10.1.192.144) by\n FMSMSX903.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.2562.37 via Frontend Transport; Mon, 13 Apr 2026 18:22:59 -0700","from CH5PR02CU005.outbound.protection.outlook.com (40.107.200.67) by\n edgegateway.intel.com (192.55.55.82) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.2.2562.37; Mon, 13 Apr 2026 18:22:59 -0700","from DS0PR11MB7579.namprd11.prod.outlook.com (2603:10b6:8:14d::5) by\n MW4PR11MB7101.namprd11.prod.outlook.com (2603:10b6:303:219::9) with\n Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.9818.15; Tue, 14 Apr 2026 01:22:54 +0000","from DS0PR11MB7579.namprd11.prod.outlook.com\n ([fe80::4199:4cb5:cf88:e79e]) by DS0PR11MB7579.namprd11.prod.outlook.com\n ([fe80::4199:4cb5:cf88:e79e%5]) with mapi id 15.20.9818.014; Tue, 14 Apr 2026\n 01:22:54 +0000"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp1.osuosl.org B7BA0848CD","OpenDKIM Filter v2.11.0 smtp4.osuosl.org 9D52B42826"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1776129785;\n\tbh=wgw8yUWejr5IoQH8Oq0d0pLuyYhIwZcJ3iaWZpKjXnM=;\n\th=Date:To:CC:References:From:In-Reply-To:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t From;\n\tb=W3I1Srb5wFmPeFJ8qfpMCcrRwnQK9j5ZGCpmmxg19rd5Deso1yD3zwcG63bm6S9Qg\n\t s8N8Boj9gmPlfwUCQp+04ex4SxLbD1CF7b37yBx2LkoySGsx/QCcdXLUX9rEqEOqUa\n\t DnDOqmIJ8OAo1+2K5vP3lZhW27EzxeBUSZNHrJqVMBmC2P0Wbm3f53ENpWOCECnGdY\n\t pbSDSSLwbgZ475kzm47bJEFZxr5dRxbCAaujekHxKjq/39iqG3YNoqTRSOFGIAsd0B\n\t lAr3r4jUbx8RjCG0PVyShoSXnWrwL/LQGJTHirHmOz419rUzEW9IgYvSJTdpFn69ji\n\t R4j+zj8zo/h4w==","Received-SPF":"Pass (mailfrom) identity=mailfrom; client-ip=198.175.65.18;\n helo=mgamail.intel.com; envelope-from=jacob.e.keller@intel.com;\n receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp4.osuosl.org 9D52B42826","X-CSE-ConnectionGUID":["2GfQ/fVtRTCHiX5+AzfS5A==","R6DBn6cZRx6qRLrZqba+EQ=="],"X-CSE-MsgGUID":["KraFAmq+Qle3f8XB+f9zLg==","cbRjOHg4T4SIDO+LA0F5+Q=="],"X-IronPort-AV":["E=McAfee;i=\"6800,10657,11758\"; a=\"77098467\"","E=Sophos;i=\"6.23,178,1770624000\"; d=\"scan'208\";a=\"77098467\"","E=Sophos;i=\"6.23,178,1770624000\"; d=\"scan'208\";a=\"229817001\""],"X-ExtLoop1":"1","ARC-Seal":"i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n b=bUAnb+SzOaY1TFjsDNSE9IbCvmy9ZCyX/vRZbQRGfqWFWVEEvnUFLj55TVfTmoGT4QeJ7qamj5pGjhsrctgLYegdoAt7dovUrmKr1fDZX0+kq6yFct0zEF88Kkqtcy1QoWjxio3I2TTZzhRwbBNpkRJgt/gZgpajaw9WXYXCs779Vo07zAfUzNRReNgXwjMCffCnR+3vHSzI2EL1oqSkrICyY8mN6PqNxLxVG2QUHxJMxJXAWNIF08aN89TclK8RlxVkST9vDkvvdyAKzPoRKidqrJZOKxlgogZay+qX/N8zn/Rba2JCe42eCa74VIzMwu7n87S7iuqjSDdkzWlCpg==","ARC-Message-Signature":"i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector10001;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=wgw8yUWejr5IoQH8Oq0d0pLuyYhIwZcJ3iaWZpKjXnM=;\n b=ZNsUdYuL6+7TMvnvN47U7BntP5pR1d0jnpd7/x4Faoo5Z1RKdnYRxYAzFnYkdmE9JjM1AgVfSs1fUJ/7IXfjDs4MGZ41NMJbv8C9rbBNkQ5xfw/PKDLWAC1NadPARrw+8wMv0T0OOobFw/6MOLavU4kC0sFOgLEWjMY785zKFqayJczAnTaJxmAeVZk3HOksOa6miUPO5SZeEQ5WM+jS3eMHrIrBpP3qWr6PA0t6f/mf6a2QxRg4XfYEDsXaLQHoh/w+fbQvMuggVO142oYv8Zp2Q3PBp32qsQ87CdDzgdwkoEZ0X/HTg585EJVSHFJmOnW5m7iFV6ovN5RqXfLA9w==","ARC-Authentication-Results":"i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;\n dkim=pass header.d=intel.com; arc=none","Message-ID":"<7f5bb0a1-90f2-44e7-be93-7a2fd4f58dc2@intel.com>","Date":"Mon, 13 Apr 2026 18:22:51 -0700","User-Agent":"Mozilla Thunderbird","To":"Paolo Abeni , \"Loktionov, Aleksandr\"\n , \"intel-wired-lan@lists.osuosl.org\"\n ","CC":"\"Nguyen, Anthony L\" , \"Kitszel, Przemyslaw\"\n , Andrew Lunn , \"David\n S. Miller\" , Eric Dumazet , \"Jakub\n Kicinski\" , Alexei Starovoitov , \"Daniel\n Borkmann\" , Jesper Dangaard Brouer ,\n John Fastabend , Stanislav Fomichev\n , \"netdev@vger.kernel.org\" ","References":"\n <0815f1eb4b60faa653ea703e420395b724d05216.1775648513.git.pabeni@redhat.com>\n \n <2bae0dc2-4035-4fe2-a87e-dc5dae6c7df5@redhat.com>","Content-Language":"en-US","From":"Jacob Keller ","In-Reply-To":"<2bae0dc2-4035-4fe2-a87e-dc5dae6c7df5@redhat.com>","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"7bit","X-ClientProxiedBy":"MW4PR02CA0025.namprd02.prod.outlook.com\n (2603:10b6:303:16d::11) To DS0PR11MB7579.namprd11.prod.outlook.com\n (2603:10b6:8:14d::5)","MIME-Version":"1.0","X-MS-PublicTrafficType":"Email","X-MS-TrafficTypeDiagnostic":"DS0PR11MB7579:EE_|MW4PR11MB7101:EE_","X-MS-Office365-Filtering-Correlation-Id":"7222f968-d7c5-44e0-a92a-08de99c45a66","X-MS-Exchange-SenderADCheck":"1","X-MS-Exchange-AntiSpam-Relay":"0","X-Microsoft-Antispam":"BCL:0;\n ARA:13230040|1800799024|366016|7416014|376014|56012099003|22082099003|18002099003;","X-Microsoft-Antispam-Message-Info":"\n cLgsUjjmq/ovLCSS+2jxR+RiU/3a3bi9BLx0GTN1/z5Iaxn+Jbj1qkbVGxxX2q07RFWKoJZGI6C/VPj3IFgml62s9HhfvJ4tIVRccMjs6UwhsluLRSssUeoKHZ0uh8pqZro7HvkMQ8G+xmYpYybfg39YvrWAmQnDLtQPJFsmg7GZK37JCFvW7LSnI3EM//imX/6bjHRML7z9D+5N8RwTCRMNEY8R3cfyGKWOJbG5BdzcdEXolaT0DcdpusRQkGuAM3w09MaZI+YuDOgEMVpM40qf4Yf1fC37UdL6lJa0PfkvBsJ1PCiBgZRHhFiisvmH32YuvPJc2UY6BlXwolzCjMoYCB7Ty4UWFhm2/wvD2pzAx8BDEjaS0h+jnv7dPV7e7l8fTGShznhkVY1OF5fqVfUPGMgrprVCCgeXsACObKFJG3d+kq27ewn01uSs8+TXfsAHh8ij9i0YjKJW/cKhXNm+r1z9TDwpjjfon4BUyuoRkilEWtT6g4pub25wCwY9SLsDU6PJLtzzjrAhgWoSRnNWGYwNWae7FS54fW+9HEIRUVZ0Q1j9WqMDS+0PQP8f6l1O6NsWn86I85PvW3Ji0Ma0BIsQWrDsfOEvQ33Q7RWstrYnDhQphIvxHNu927NH8LWMAK2pCjOUox0EoklWXQtlbZ5JvS852nCjXcf+xVxLSBZzoKbNcz6qXMa39OirG4j/kUHjB6CM+1QJV2wcBP2jE51rLrUGEdToNs2EvD4=","X-Forefront-Antispam-Report":"CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:DS0PR11MB7579.namprd11.prod.outlook.com; PTR:; CAT:NONE;\n SFS:(13230040)(1800799024)(366016)(7416014)(376014)(56012099003)(22082099003)(18002099003);\n DIR:OUT; SFP:1101;","X-MS-Exchange-AntiSpam-MessageData-ChunkCount":"1","X-MS-Exchange-AntiSpam-MessageData-0":"=?utf-8?q?fYIiD/ea2CWIRneIUrzquoeOpTD5?=\n\t=?utf-8?q?DoTvETnKj4hZGT41L7f5iqX+JCVOJ2hXXvzEST9iPQaD6xcTSVG5e7xbeyqgiD9Fb?=\n\t=?utf-8?q?Fm0+QU38YIufLAdcJ6sXbgeDKehIhIA8hVuJZRSJgyPb+W0yrzn1q7ovbrOMxCO13?=\n\t=?utf-8?q?RY/kEjLzsjzRpddKB1N7Y7MkR2WTgLNNtNY6Eg3mg8dZX+RuaYIQqfEWR4rSNxt6D?=\n\t=?utf-8?q?Uj8YyjcBm/eLHWN97XFLPHkEF8m5vNjkSkSdzxiZqZhLFJKQmQHbVZLb+WV3ujj8k?=\n\t=?utf-8?q?1ZdT4FqYgIGQOdjiG6Ih+JQ9cKcAet+pV8yvxWcy9pPMbGZ3mXfIrMy1+rYfgAVmT?=\n\t=?utf-8?q?DohAyAmWueSwl7Aby9urMcQclzA/sRpnZyDVrFdB2PDx6nluaHWrdP710bprJeO6j?=\n\t=?utf-8?q?FMfCCXE2M/RbPBf/nCVn8z76JSGd1ipZtVIp8adcsaPRjnYVLjcsilaiAW1NkTrzP?=\n\t=?utf-8?q?XeIonrT882hsfpNR/swpCgLmqlsBwnhOgR19FLymfY2GFXYxpssA2KkHkh6Hw158e?=\n\t=?utf-8?q?YtFiDju2XQeevZzgtoETFUrhaMZDavyn4aZHNBZZkFZkMScV1R1u6JxmFtNSTt5M8?=\n\t=?utf-8?q?qfG781d/PxXQ3jWLsV9Ef/+gh+f7XHQnUWqCWvzFHtZhZGs40cIQTuuO/VGAw0C/8?=\n\t=?utf-8?q?FOU7FoK4Iew90ArW//o7vV9V1eKDMySOkbsB+vJAQCOKIKgchFAuZ1h23q1LDZd8D?=\n\t=?utf-8?q?80F/JtMMgtDJ0l9ywDczn3RYsD0dfxWIo7kZiKmHyiWKgUcJUVdPU0t7IyMwxFB0E?=\n\t=?utf-8?q?ixg03Q77DwWH175jayiAQqIAz/qcySBel9L+iqKEeVY9wpSgH2G0TD9Q6qxASiD7U?=\n\t=?utf-8?q?Vvj+AL1cZNScj36Ohbdu50TUbwx48x8oWG/n9mp263zp28IVGdJgaEzqQKUI0TNfE?=\n\t=?utf-8?q?5c6456tf8ZWnTcq0Bx2uBedhbwdsSrMiqAXnzaeTIXfhlXdyjiYIrKr+5P4PODe+x?=\n\t=?utf-8?q?Nc0zz0nc8X6mP8Sud5fCYgyHTwEqRr8OLZjN3kRYtsVGwrWdCSsSnyW9e33p+neHn?=\n\t=?utf-8?q?JarexhcoU0XtR5hcNL4Fv+MMG+Pbr/VYV4YKxYoq5IU5iyRvJQlij64TY3bQ6TyPW?=\n\t=?utf-8?q?pjEDpO1/r561o0NR2BWFancstExhV892pu39pGRUZpK3bBxKdkvsFasKHLWj1RiE3?=\n\t=?utf-8?q?InhqLabdHatbuLjxTuFEmnxG9aeLgoY5Wf8m63ClGMldsirI1gQJcgRCFrfkvXAFg?=\n\t=?utf-8?q?ltbDjh8MYsae2HtxOpCC3ws3e9KYszqU428MXbuhNb7Rd3wbW9bnzw0X1tkO54efi?=\n\t=?utf-8?q?bx0kWioI2sRtWho5mRY+6zdC8ZDZWLH6u8bhmHa2jXCte+OAIAnESuDd04h0rpFxY?=\n\t=?utf-8?q?Cw9DqSIenFrQulHKTfFOqpH5EffNTU0nc13iI0/r0qmzrg1B+xxCmhKDvP0uSd8Uq?=\n\t=?utf-8?q?w4dbjeJmWW7ex19KSq8GeilaK45XWWAyOQ/hvtR1eCE536NSdwCnkPic3UFFSak/q?=\n\t=?utf-8?q?L9lvq3d5WUcgRQ2o2URmM8K0rDY4FO91aAXRS9/q55abButwnqIp8ai1uOVKpK5WK?=\n\t=?utf-8?q?mNkk6D1V+NUl/rGTzdlLUPUKvmUAm1kzI0wxMGIaYUF36+++L0+rL7gYZ2ORHt6+R?=\n\t=?utf-8?q?TvzsKUHhxh69byzw50HY3usd6PFLDDhNKLjHOJScv7RhK3M9Dw81gAyYryhg6QYl2?=\n\t=?utf-8?q?ImxlWzlrS1rL4RcPfae6amE4adz0FQQQ=3D=3D?=","X-Exchange-RoutingPolicyChecked":"\n ZfeJs+QU3mUgxgYbxqRDzk7UXbP+NIGMU7EGF6UR4PEwj8aJITAuD1ZwBzPmqg4n9NFbFhkZ5R47o1mSHsfNFWMf9cPGn/5uu9z2spr5k0ayJW/Hcn3cZ+9xh3AB/eWYHJTnrCJASRifz468cGIPAO7rmnxR5MykvbBJffEhItZhIb3A3kgWumprE+rmRT4kgaTDuu/ApJEEl4DIdvbpzp/C399rhzlAuub+hLu3lsO6tvg6RL5cdGbkH1LWjysjBI3xjYCA/7V5c/ZhRITmpRqvUyTGKxMchPkZfn/5tm5WQLlJBSzhmzkq6bmaaub/ZMbY2Vx5rjqZS0LYdRBaAg==","X-MS-Exchange-CrossTenant-Network-Message-Id":"\n 7222f968-d7c5-44e0-a92a-08de99c45a66","X-MS-Exchange-CrossTenant-AuthSource":"DS0PR11MB7579.namprd11.prod.outlook.com","X-MS-Exchange-CrossTenant-AuthAs":"Internal","X-MS-Exchange-CrossTenant-OriginalArrivalTime":"14 Apr 2026 01:22:54.3785 (UTC)","X-MS-Exchange-CrossTenant-FromEntityHeader":"Hosted","X-MS-Exchange-CrossTenant-Id":"46c98d88-e344-4ed4-8496-4ed7712e255d","X-MS-Exchange-CrossTenant-MailboxType":"HOSTED","X-MS-Exchange-CrossTenant-UserPrincipalName":"\n ycoNIp0q44GqO4BN8TEMCfgGjZ3uZzBCjBZfndV8LrahjSVA3mPIOLL6ogWWGbNvawbZ5nXQzsMq6I7kY/3N1gq+A/8+iIJV4yZz6swrsTE=","X-MS-Exchange-Transport-CrossTenantHeadersStamped":"MW4PR11MB7101","X-OriginatorOrg":"intel.com","X-Mailman-Original-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1776129783; x=1807665783;\n h=message-id:date:subject:to:cc:references:from:\n in-reply-to:content-transfer-encoding:mime-version;\n bh=lnNNZLW+cSASeAuma9EHOxE0+dylGtVnmQxac2pSK2M=;\n b=clRNDLnr9OFfaX9lub6a3PnITtQIQ+qIiUSw3pbOEgvE89BTsnSgOgKH\n vsz6sOQeZ1HVTkaDGATXqqa9Sd8M2yDXevkJBj4UHKF4FxfDt8Gp7x5nC\n x9Nb+iv7dtlz5ZIgzQCBSD+1TNyVI0tKUJcoEnv+4YXD2N7mw/xLDI95T\n 3K4BZY1t+tqW6RXkUBle4SiBJzV/QAVMWfck2Ob/f7zSJBrSx/UnGBwHa\n dQaUQsiwfsFTrPPxtb2IsJ1vznS0tJde62Kmkg97KmFxwV97BWfB1IB8C\n WHCO9QgIJdnVqmCgWL6zGcv9QxiIevuoDyyzwbsA2NjtwN2zcwT21Sf1Z\n A==;","X-Mailman-Original-Authentication-Results":["smtp4.osuosl.org;\n dmarc=pass (p=none dis=none)\n header.from=intel.com","smtp4.osuosl.org;\n dkim=pass (2048-bit key,\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=clRNDLnr","dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=intel.com;"],"Subject":"Re: [Intel-wired-lan] [PATCH iwl-next 1/2] i40e: implement basic\n per-queue stats","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "}}]