[{"id":3675120,"web_url":"http://patchwork.ozlabs.org/comment/3675120/","msgid":"<20260409-heavy-colorful-monkey-e09d42@quoll>","list_archive_url":null,"date":"2026-04-09T07:43:53","subject":"Re: [PATCH v2 2/4] dt-bindings: gpio: realtek: Add\n realtek,rtd1625-gpio","submitter":{"id":68952,"url":"http://patchwork.ozlabs.org/api/people/68952/","name":"Krzysztof Kozlowski","email":"krzk@kernel.org"},"content":"On Wed, Apr 08, 2026 at 10:52:41AM +0800, Yu-Chun Lin wrote:\n> +maintainers:\n> + - Tzuyi Chang \n> +\n> +description: |\n> + GPIO controller for the Realtek RTD1625 SoC, featuring a per-pin register\n> + architecture that differs significantly from earlier RTD series controllers.\n> + Each GPIO has dedicated registers for configuration (direction, input/output\n> + values, debounce), and interrupt control supporting edge and level detection\n> + modes.\n> +\n> +properties:\n> + compatible:\n> + enum:\n> + - realtek,rtd1625-iso-gpio\n> + - realtek,rtd1625-isom-gpio\n> +\n> + reg:\n> + maxItems: 1\n> + description: |\n> + Memory region containing both interrupt control and GPIO\n> + configuration registers in a contiguous address space.\n> +\n> + For realtek,rtd1625-iso-gpio:\n> + - Base + 0x0 ~ 0xff: Interrupt control registers\n> + - Base + 0x100 ~ 0x397: GPIO configuration registers\n> +\n> + For realtek,rtd1625-isom-gpio:\n> + - Base + 0x0 ~ 0x1f: Interrupt control registers\n> + - Base + 0x20 ~ 0x2f: GPIO configuration registers\n\nDrop description, you are duplicating here DTS. Bindings do not need to\nserve as reference manual for the device.\n\nHowever when you state them like this and give them names, I have the\nsame concerns as last time - please consult your datasheet whether this\nis really one address space.\n\nWith description dropped:\n\nReviewed-by: Krzysztof Kozlowski \n\nBest regards,\nKrzysztof","headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-gpio@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=EVllBZVK;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.234.253.10; helo=sea.lore.kernel.org;\n envelope-from=linux-gpio+bounces-34916-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"EVllBZVK\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org [172.234.253.10])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4frsQw4l39z1yD3\n\tfor ; Thu, 09 Apr 2026 17:44:56 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id EC7D3300C58B\n\tfor ; Thu, 9 Apr 2026 07:43:57 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 2F56637C939;\n\tThu, 9 Apr 2026 07:43:57 +0000 (UTC)","from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id E35DC3081BE;\n\tThu, 9 Apr 2026 07:43:56 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 05C1EC4CEF7;\n\tThu, 9 Apr 2026 07:43:55 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1775720637; cv=none;\n b=c5kWS9bClbUFWuIflP0ug9EkLyYAtlN6vNGDrOeSTBMR/QwolE63YM5Ycefkq6pF7b9iGxQg7DIWcUMIz1wFYkteRx2S2/Rk7f899B8jhu2mq7ugeyAIWOWVxrPVf7c748e/bUaI4qMSjiHve4iMdeHtw62/wyhgKMLuwGZQodw=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1775720637; c=relaxed/simple;\n\tbh=uq/R6PmosWxaig3fB+at0I2ppDM6xQzhVCUmWXfCLIE=;\n\th=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:\n\t Content-Type:Content-Disposition:In-Reply-To;\n b=mWutZHr1/EXXKSypSsMK9JLPX8pI9HGi2iyndpCiVQdYG4N64HfCmowHSAXKx2LoZLGUBRGQ5Kby52/VfHrqZX9ReKWV7498HRLQR+UiFExftNym1kZZgRmpkpdj0TLXJvGmWeJxb78fGQwETQg+tVMxjbVFydcteHKWFwaUyMk=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=EVllBZVK; arc=none smtp.client-ip=10.30.226.201","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1775720636;\n\tbh=uq/R6PmosWxaig3fB+at0I2ppDM6xQzhVCUmWXfCLIE=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=EVllBZVKxqZDb6GWFRf6NCvRGFukJ+3EsnP2wGG9WlFBKXTj1m8EIxNieXFokKcNC\n\t DY8z5BewLaM0clOfV8z+g1lmeigkmas2Ef6llkBYUOLKsmHrhs6frICytJD1gAsrKP\n\t ILgqkdcyErgC7vKK10MJFyN83omrsJUU66Wg5JXSURzCIb3ir1Ij3WrhC0G+47k5+2\n\t fOyhhnUVmELllc1kcdTZyR18jQlxhVRpMa5u74L1GuCocHwkhIB/mey17qCMktLJqH\n\t ipAjY8yoPibjVwitnUb53lOicQ19oNEt78twPkuxZBkzykgu0tVCNo/b3LtrTDEbtB\n\t v2GJLeLdgZMLA==","Date":"Thu, 9 Apr 2026 09:43:53 +0200","From":"Krzysztof Kozlowski ","To":"Yu-Chun Lin ","Cc":"linusw@kernel.org, brgl@kernel.org, robh@kernel.org,\n\tkrzk+dt@kernel.org, conor+dt@kernel.org, afaerber@suse.com,\n tychang@realtek.com,\n\tlinux-gpio@vger.kernel.org, devicetree@vger.kernel.org,\n linux-kernel@vger.kernel.org,\n\tlinux-arm-kernel@lists.infradead.org, linux-realtek-soc@lists.infradead.org,\n cy.huang@realtek.com,\n\tstanley_chang@realtek.com, james.tai@realtek.com","Subject":"Re: [PATCH v2 2/4] dt-bindings: gpio: realtek: Add\n realtek,rtd1625-gpio","Message-ID":"<20260409-heavy-colorful-monkey-e09d42@quoll>","References":"<20260408025243.1155482-1-eleanor.lin@realtek.com>\n <20260408025243.1155482-3-eleanor.lin@realtek.com>","Precedence":"bulk","X-Mailing-List":"linux-gpio@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20260408025243.1155482-3-eleanor.lin@realtek.com>"}}]